This patch will clip the overflowed tick label. In order to check the width,
this patch add the max-width into tick label element.
Furthermore, componentWillReceiveProps is deprecated from React 16.3.
So this patch will use componentDidUpdate instead of it.
Differential Revision: https://phabricator.services.mozilla.com/D2818
--HG--
extra : moz-landing-system : lando
Because the console output area is marked as aria-live and the filter bar is inside this area, it inherits the aria-live attribute.
For screen reader users, this causes spurious speaking of typed characters when typing in the filter box.
Worse, it causes spurious speaking of numbers as the number of messages suppressed by various filters changes, resulting in an intolerable user experience.
Differential Revision: https://phabricator.services.mozilla.com/D2816
--HG--
extra : moz-landing-system : lando
The test was disabled for intermittent failure, but I did
not managed to make it fail with --verify.
There was a fixed needed in the test for the angle since
the property used there was deprecated.
Differential Revision: https://phabricator.services.mozilla.com/D2784
--HG--
extra : moz-landing-system : lando
This duplicates some of the styles from other about:pages, reusing existing
variables when possible.
Differential Revision: https://phabricator.services.mozilla.com/D2717
--HG--
extra : moz-landing-system : lando
At the moment, a tag that has document type capabilities will try to
load tag content with invalid MIME types as a document. This patch
will cause the load to fail silently instead.
This will cause failures in certain WPTs that expect plugins to be
present to fill in MIME type requirements, which we currently don't
have available on CI. These WPTs have been disabled for the moment.
MozReview-Commit-ID: 9JGR4LClE5x
Differential Revision: https://phabricator.services.mozilla.com/D2542
--HG--
extra : moz-landing-system : lando
Looking at the mocks, the non-selected color is closer to grey-50.
The text should have the same color as the icons.
Depends on D2703
Differential Revision: https://phabricator.services.mozilla.com/D2704
--HG--
extra : moz-landing-system : lando
The inplace-editor is programmatically hiding the autocomplete-popup
on TAB and notifies the caller. The caller (eg rule view) will trigger
a click on the next focusable element immediately after that.
If the HTMLTooltip is still consuming outside clicks at that point
the click will be swallowed and the new inplace-editor cannot be created.
Depends on D2661
Differential Revision: https://phabricator.services.mozilla.com/D2662
--HG--
extra : moz-landing-system : lando
A click event is only fired if the element on which mousedown and mouseup
happened are the same. If this is not the case, the HTMLTooltip will not
be able to hide itself.
Listening to mouseup makes the behavior more consistent but forces the
hide() method to be always asynchronous, while before it was only
asynchronous for tooltips using the XULWrapper.
Depends on D2660
Differential Revision: https://phabricator.services.mozilla.com/D2661
--HG--
extra : moz-landing-system : lando
This patch adds:
- a new action actions/ui:selectPage
- takes a page id in argument
- returns type PAGE_SELECTED, with selected page id as 'page'
- a new reducer reducers/ui-state
- on PAGE_SELECTED, updates the state by setting 'page' in 'selectedPage'
The state of the application after this patch looks as follows:
{
ui: {
selectedPage: String
}
}
As we add more devices the way we identify the selected page might change
(maybe use an index instead of an id) but that is good enough for now.
The "dispatch" helper is forwarded to the App component via connect.
From that point, components are responsible for forwarding the dispatch
property to all components who need to dispatch actions.
Differential Revision: https://phabricator.services.mozilla.com/D2549
--HG--
extra : moz-landing-system : lando
The inplace-editor is programmatically hiding the autocomplete-popup
on TAB and notifies the caller. The caller (eg rule view) will trigger
a click on the next focusable element immediately after that.
If the HTMLTooltip is still consuming outside clicks at that point
the click will be swallowed and the new inplace-editor cannot be created.
Depends on D2661
Differential Revision: https://phabricator.services.mozilla.com/D2662
--HG--
extra : moz-landing-system : lando
A click event is only fired if the element on which mousedown and mouseup
happened are the same. If this is not the case, the HTMLTooltip will not
be able to hide itself.
Listening to mouseup makes the behavior more consistent but forces the
hide() method to be always asynchronous, while before it was only
asynchronous for tooltips using the XULWrapper.
Depends on D2660
Differential Revision: https://phabricator.services.mozilla.com/D2661
--HG--
extra : moz-landing-system : lando
I generally tried to preserve the behavior of consumers where they treated an
exception from getInterface(Ci.nsIContentFrameMessageManager) as a signal to use
some sort of fallback.
I did change the behavior of consumers that walked up to the root same-type
docshell before getting the message manager to just get it directly from the
docshell they have. Please review those parts carefully, and let me know if you
want me to ask some subject area experts to review those.
This removes the border-radius from the autocomplete popup (and
its items) and refines the spacing.
Since we have more padding for the autocomplete items, we need
to adjust the xOffset when showing the popup.
The yOffset of the webconsole autocomplete is tweaked a bit so
we see its border; the xOffset of the markup search input is also
tweaked to consider the left padding we use to display the search
icon in the input.
MozReview-Commit-ID: JyLySLBUgGy
--HG--
extra : rebase_source : 04d0e1335447c576f7e23f4b8a2280337695ac46
If the width of the devtool window is narrow, tooltip's label has a line break.
This patch will prevent it.
Differential Revision: https://phabricator.services.mozilla.com/D2636
--HG--
extra : moz-landing-system : lando
Using the full string each time, although more verbose, allows us to easily
search for string IDs and see where they are used.
Differential Revision: https://phabricator.services.mozilla.com/D2590
--HG--
extra : moz-landing-system : lando
Currently we have a structure like the following:
<div role="menu" id="toolbox-meatball-menu">
<li class="menuitem">
<button
role="menuitemcheckbox"
aria-checked="true">
<span class="label">Dock to Bottom</span>
</button>
</li>
<li class="menuitem">
<button
role="menuitemcheckbox">
<span class="label">Dock to Right</span>
</button>
</li>
<hr></hr>
<li class="menuitem">
<button
class="command"
role="menuitem">
<span class="label">Documentation…</span>
</button>
</li>
</div>
As a result there is an <li> wrapper element between the role="menuitem" element
at the role="menu" element. By setting role="presentation" on the <li> wrapper
we can produce a more sensible accessibility tree.
Differential Revision: https://phabricator.services.mozilla.com/D2642
--HG--
extra : moz-landing-system : lando
Nicolas Chevobbe
Mantaroh Yoshinaga
James Teh
Julian Descottes
Kyle Machulis
Brian Hackett
David Walsh
Jason Laster
Dorel Luca
Bogdan Tara
Narcis Beleuzu
Razvan Caliman
Boris Zbarsky
Alexandre Poirot
sole
Noemi Erli
Daisuke Akatsuka
Tiberius Oros
dvarga
Brian Birtles