This allows to create NetworkEventActor directly from the parent process
and avoid most of the data being piped from the parent to the content processes.
MozReview-Commit-ID: 8p3A5yl5eVB
--HG--
extra : rebase_source : 49eb0406eff31b8262ac316884a4abd57512f6cf
This allows to create NetworkEventActor directly from the parent process
and avoid most of the data being piped from the parent to the content processes.
MozReview-Commit-ID: 8p3A5yl5eVB
--HG--
extra : rebase_source : 3f022b2be7d1ab79c926ad9302e9ee232acc48b2
The input expansion tests are removed since the new test now cover the input
growing/shrinking.
MozReview-Commit-ID: 4RIQar4ytX
--HG--
extra : rebase_source : 0372ef695c37646cabc7f40ec22e3c652dcce133
extra : source : f4aef5b3c68fca33e19dcf67e1b7e5fc4006a227
Since codeMirror jsterm is becoming the default, we explicitely
set the pref to false before each jsterm test so they run with
the 2 version of the component.
MozReview-Commit-ID: 2qxIcRlIS9M
--HG--
extra : rebase_source : 606cd9e0953bf0cb805477fbe52b96f33e38c075
DocShells are associated with outer DOM Windows, rather than Documents, so
having the getter on the document is a bit odd to begin with. But it's also
considerably less convenient, since most of the times when we want a docShell
from JS, we're dealing most directly with a window, and have to detour through
the document to get it.
MozReview-Commit-ID: LUj1H9nG3QL
--HG--
extra : source : fcfb99baa0f0fb60a7c420a712c6ae7c72576871
extra : histedit_source : 5be9b7b29a52a4b8376ee0bdfc5c08b12e3c775a
DocShells are associated with outer DOM Windows, rather than Documents, so
having the getter on the document is a bit odd to begin with. But it's also
considerably less convenient, since most of the times when we want a docShell
from JS, we're dealing most directly with a window, and have to detour through
the document to get it.
MozReview-Commit-ID: LUj1H9nG3QL
--HG--
extra : rebase_source : a13c59d1a5ed000187c7fd8e7339408ad6e2dee6
Changes:
- All files
- Generally shuffled around telemetry events to fix issues with properties not been sent or being sent in the wrong order.
- devtools/client/framework/browser-menus.js
- Added telemetry open event to missed codepath.
- devtools/startup/DevToolsShim.jsm
- Added missing telemetry "shortcut" property.
- devtools/startup/devtools-startup.js
- Added comment to sendEntryPointTelemetry().
MozReview-Commit-ID: ELldeyF32rG
--HG--
extra : rebase_source : bbe9a9bf279e6a6c1324a162885cc35b04cf27ce
Changes:
Pretty much all files contain changes to the order of events and properties... these are to stop subtle issues with events not being logged because not all properties were sent and some events were sent in the wrong order.
-devtools/client/framework/test/browser_devtools_api.js
- Renamed test-tool-1 and 2 because we need to include the panel names in Events.yaml and "-" is not allowed.
- devtools/client/framework/toolbox.js
- Removed unneeded const REGEX_PANEL.
- Generally shifted things around to ensure we send events from all codepaths.
- toolkit/components/telemetry/Events.yaml
- Changed telemetry event `"devtools.main", "enter"` to include all built-in panel names including "other."
MozReview-Commit-ID: 2G3Z9pzj1QC
--HG--
extra : rebase_source : 54920e6fe2116a3112fefe17715b5b22ad6f5d32
Some test files were affected by adding a new CoarseType, particularly in XPCShell tests. New rules were added to handle this CoarseType, and in a few cases the IDs of deserialized nodes had to be adjusted. The colors of CoarseTypes have also changed slightly and the resulting tests had to be updated.
--HG--
extra : histedit_source : 99db02f1b6acafb1376f71af3b8fceb9adbbb8e0
Added a new CoarseType that refers to DOM nodes. Updated the trees to represent the CoarseType. Created a new type of count in the heap snapshot that sorts the data by a more descriptive type name. Created the descriptive in JS::ubi::Base.
--HG--
extra : histedit_source : be24efa4d2ccb85e82046d7cf7d2c3a1e13b1fd7
By mixing system colors and non-system colors we can arrive at a situation where
we have white text on a white background when using Windows high-constrast mode
or various themes on Linux.
This patch brings the colors used for DevTools doorhangers into line with the
colors used for arrowpanels elsewhere in Firefox.
Differential Revision: https://phabricator.services.mozilla.com/D2456
--HG--
extra : moz-landing-system : lando
Migrate the ShaderEditor to use the HTMLTooltip instead of the
old XUL-only Tooltip. The HTMLTooltip doesn't provide a builtin
setTextContent API, so the shadereditor is now creating the
markup for the tooltip and setting it as the content.
The styles have been ported to shadereditor.css and now rely on
theme variables.
This will allow us to move all the old tooltip code to the old
debugger folder, which will be the last consumer of the widget.
MozReview-Commit-ID: HVyxtf0xM4x
--HG--
extra : rebase_source : cdb7d6eabe77816f7f6d93299f7a8440ec4ce9a4
This patch removes the <kbd>Esc</kbd> handler from codeMirror
to put it on the jsterm-container. This prevent the interference
from codeMirror when we don't need to handle the event (i.e. it
should bubbles up to the toolbox where the split console state
is managed).
The webconsole_split test is run with both old and
new jsterm.
MozReview-Commit-ID: BaLyj4wSdmv
--HG--
extra : rebase_source : 6b549379839dc824a38ee49ffd859092cfbecb13
extra : source : de58a50eb0165665644b07fffd228e5478861e2e
The widget will hide the XUL panel when clicking to the outside of panel
automatically.
If a user clicks the MenuButton when opening the popup, the popup will hide
automatically and mouse click event will be fired on macOS and Linux.
(Windows will eat this click event since the consumeoutsideclicks of this panel
is false.)
As a result of it, the popup menu will be reopened. In order to prevent this,
this patch will disable the MenuButton until popup is hidden by using
the popuphidden event. This popuphidden event will be fired before the click
event of MenuButton, then the click event of MenuButton will be fired after
popuphidden immediately.
MozReview-Commit-ID: 42xV0aWDmkR
--HG--
extra : rebase_source : 526d89b876a0db13feee5629272c74275b4cf611
It's currently only accessible on XULDocument and XULElement, but that makes porting existing
JS to run in an HTML document inconvenient. We could alternatively change calling JS, but
this can be easily moved and exposed in chrome contexts.
MozReview-Commit-ID: JitYET20NSE
--HG--
extra : rebase_source : 75d823c688cba8d84dc19705e83284be383962f2
This changes the behavior for inspecting rejected Promises such that:
(1) We don't consider them safe getters, treating them as we would a thrown exception
(2) Manually handle the rejection with `catch` when possible, so that we don't create
an error when trying to inspect the promise and leaving it unhandled
MozReview-Commit-ID: HZL4BrjCKkA
--HG--
extra : rebase_source : 45d84b1c8ef5a6fc2a9c060dba44b2f56147740b
This new API allows to instanciate an actor in the parent process from actors running in the parent process.
The created actors are returned to the client from the actors running in content,
but after that, the client communicates directly with the created actors running in the parent process.
MozReview-Commit-ID: 5B3wRQ94UEx
--HG--
extra : rebase_source : 808ea31fe8a467d0185fc27056c6524873cddbce
Changes:
Pretty much all files contain changes to the order of events and properties... these are to stop subtle issues with events not being logged because not all properties were sent and some events were sent in the wrong order.
-devtools/client/framework/test/browser_devtools_api.js
- Renamed test-tool-1 and 2 because we need to include the panel names in Events.yaml and "-" is not allowed.
- devtools/client/framework/toolbox.js
- Removed unneeded const REGEX_PANEL.
- Generally shifted things around to ensure we send events from all codepaths.
- toolkit/components/telemetry/Events.yaml
- Changed telemetry event `"devtools.main", "enter"` to include all built-in panel names including "other."
MozReview-Commit-ID: 2G3Z9pzj1QC
--HG--
extra : rebase_source : bc691ae42b521e3a58c1a4aa9dbd455a3aa258a0
In this patch, implement following basic things of 'ThisFirefox' page for new
about:debugging.
* Add a pref devtools.aboutdebbugging.enabled-new to enable new about:debbugging.
* Add a function which switches new/old about:debugging page by the pref.
* Add devtools/client/aboutdebugging-new directory for new about:debugging.
* Add basic html, css, JavaScript and React component.
MozReview-Commit-ID: 5DtV7rRcS0S
--HG--
extra : rebase_source : 26496ef8273c03b78a7b8d00f44beac5f18d09ef
This introduces an event-telemetry middleware that we'll
be able to re-use for other events.
A test is added to make sure we do log those events as intended.
The telemetry mock for mocha test is modified to include
recordEvent so the test still run.
MozReview-Commit-ID: 1SHnVIRGdDz
--HG--
extra : rebase_source : 7a7d6c7ff3fdbe1da6a16bc47017dbf5d90582db
This then can be used directly in the console, or passed to reps
and ObjectInspector so it can be called from there.
MozReview-Commit-ID: uQOiGuYbJK
--HG--
extra : rebase_source : a8a84b558dea69b7c2793b9e2d67a44a0809eb43
This should prevent introducing further delay when opening DevTools.
MozReview-Commit-ID: D9XDieFoU8a
--HG--
extra : rebase_source : f7a5309ed2f64ec358fee13068efd6da8acfbdd2
This is to avoid rendering for a frame or two without the menu item icons being
visible which causes flicker, particularly on lower-end machines.
MozReview-Commit-ID: Aq7AOkPwu9V
--HG--
extra : rebase_source : ee371cf848dcf39ec9f3cd9689268c3e9ef41c54
This is so that we can hook into the componentDidMount method.
MozReview-Commit-ID: 5NCDgvDPbe1
--HG--
extra : rebase_source : 3768f50b20d208f5d9bb5724194fcdc2927a873c
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI. This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates
MozReview-Commit-ID: Dzy6t2zYljL
--HG--
extra : rebase_source : 9c400bed3c9d29a186fc987c9bd0ffceb37bfd94
It was using `window` which refers to the browser window, but we actually want to synthesize
the click in the devtools window.
MozReview-Commit-ID: KeIwq3JIJin
--HG--
extra : rebase_source : c769229d19661370d5448f0b5b236ce8b2eb91c4
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI. This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates
MozReview-Commit-ID: Dzy6t2zYljL
--HG--
extra : rebase_source : fbfbcf7608efbfb35c9be4018ff0f4e70b2768d2
Since codeMirror jsterm is becoming the default, we explicitely
set the pref to false before each jsterm test so they run with
the 2 version of the component.
MozReview-Commit-ID: 2qxIcRlIS9M
--HG--
extra : rebase_source : 025dcf3ee32969db87621f6c92e284a21e2a51e2
The actual fix for this issue will come in a future
reps bundle when https://github.com/devtools-html/debugger.html/pull/6705
gets merged.
But, I do want this change to be uplifted to release, and it should be
easier to only apply this simple change than the whole next release
which would contain unrelated code changes.
Also, this patch introduces a test to make sure we don't ever regress
this.
MozReview-Commit-ID: 3QPrx3TLln0
--HG--
extra : rebase_source : 9a62da36af01506e9290d059a2aa3a4a7c8bc75f
We have a different order in nsCSSPropertyId for no good reason. The only
invariant there is that longhands come before shorthands, and shorthands before
aliases.
Luckily that's also an invariant that NonCustomPropertyId has, so we can reuse
them.
Differential Revision: https://phabricator.services.mozilla.com/D2463
MozReview-Commit-ID: 1hsQu6hmqiN
The optimization this code was working around has now been fixed.
Differential Revision: https://phabricator.services.mozilla.com/D2419
--HG--
extra : rebase_source : 586f19d9254c4aab88f54bd7b4122b613e1b39e8
extra : histedit_source : 4555f3e34c9863ae9db41f437f2c9ce6a3fed006
The popup was properly sized (and positionned), if it was previously closed,
which could led to layout issues when changing the autocomplete popup (e.g.
by typing a ".").
We now always call openPopup when there's items in the popup so it's always
properly sized.
I'm expecting some performance overhead here, but I'm working on another bug
that should make the popup faster.
A test is added to make sure we do resize the popup as needed.
MozReview-Commit-ID: K7dOllMrq0b
--HG--
extra : rebase_source : 95cf1a6c6f21ee253756f4f26a2fab89887f14b6
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI. This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates
MozReview-Commit-ID: Dzy6t2zYljL
--HG--
extra : rebase_source : b15f75e39d04c8485b4eb63416fd1f1e4175fafe
As per https://design.firefox.com/icons/icons/android/open-in-new-24.svg
but rather adapted to match the proportions of the other icons and fit on
a 16x16 grid.
MozReview-Commit-ID: 9bGWiBjX1P4
--HG--
extra : rebase_source : 1b87badf8ed045368c7f3d003c3c4f4611ab6a4b
This removes AutoMaybeEnterFrameRealm. Most places pass cx->realm->principals: it preserves behavior when the (possibly wrapped) SavedFrame and cx are same-compartment. The main exception is the JSStackFrame DOM bindings code where we have to be a bit smarter about which principals to use.
getCssPath and getXPath will need to reuse the same logic as findCssSelector
to handle shadowDOM support.
This patch moves the methods next to findCssSelector, in toolkit's css-selector.js
to avoid duplicating logic between devtools/ and toolkit/
The content of the methods is stricltly the same, except for the Node global
not available in css-selector.js. Instead we use `ele.ownerGlobal.Node` here.
MozReview-Commit-ID: J0KuORWLUoO
--HG--
extra : rebase_source : 26a1801670e5554577f0f77b62667527f7b497bb