Sebastian Hengst
0819f35e51
Backed out 4 changesets (bug 525063) on request from Andi. a=backout
...
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Tristan Bourvon
a3a77c0312
Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan
2018-04-10 21:11:02 +02:00
Daniel Holbert
db1f9ead22
Bug 1444481 part 2: Replace unneeded #includes in nsStyleConsts.h with more specific ones (and add missing headers to nsStyleCoord.h). r=xidorn
...
nsStyleConsts.h doesn't use anything from gfxRect.h or nsFont.h, so this patch
removes those #includes from it. However, it does need some other headers that
it was pulling in indirectly via those #includes, which I'm now making it
*directly* #include. Specifically, it needs:
- inttypes.h for "uint8_t"
- gfxFontConstants.h for NS_FONT_WEIGHT_BOLD and related constants.
On its own, the above changes cause build errors in nsStyleCoord.h, because
that other header has an #include for nsStyleConsts.h, which it was
inadvertently depending on (very indirectly) to provide some definitions (via
the aforementioned removed #includes). So we need to give nsStyleCoord.h some
new #includes to directly provide what it needs & keep it
compiling. Specifically:
- mozilla/gfx/Types.h for the mozilla::Side type
- nsISupportsImpl.h for the NS_INLINE_DECL_THREADSAFE_REFCOUNTING macro
MozReview-Commit-ID: BDlaIIOQiPE
--HG--
extra : rebase_source : a16f85f030330ff009461c4d48028327cc4ba0cf
2018-03-09 11:53:22 -08:00
Ting-Yu Lin
dc7e13b5d5
Bug 1418905 - Move nsRuleNode::ComputeCoordPercentCalc() into nsStyleCoord. r=heycam
...
MozReview-Commit-ID: GLLseBxhUiP
--HG--
extra : rebase_source : 2940610dbb5e81e463db82459a46a54eb693e5cb
2017-11-20 14:05:19 +08:00
Ting-Yu Lin
320b123d4b
Bug 1418905 - Move nsRuleNode::ComputeComputedCalc() into nsStyleCoord. r=heycam
...
MozReview-Commit-ID: LFxZGzyyii6
--HG--
extra : rebase_source : 516a8ed1a372d483f4c96cd392c1d382b0b4e38a
2017-11-20 13:30:27 +08:00
Daniel Holbert
680815cd6e
Bug 1412346 part 5: (automated patch) Switch a bunch of C++ files in layout to use our standard mode lines. r=jfkthame
...
This patch was generated automatically by the "modeline.py" script, available
here: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py
For every file that is modified in this patch, the changes are as follows:
(1) The patch changes the file to use the exact C++ mode lines from the
Mozilla coding style guide, available here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line
(2) The patch deletes any blank lines between the mode line & the MPL
boilerplate comment.
(3) If the file previously had the mode lines and MPL boilerplate in a
single contiguous C++ comment, then the patch splits them into
separate C++ comments, to match the boilerplate in the coding style.
MozReview-Commit-ID: EuRsDue63tK
--HG--
extra : rebase_source : 3356d4b80ff6213935192e87cdbc9103fec6084c
2017-10-27 10:33:53 -07:00
Ehsan Akhgari
740fbc891f
Bug 1378000 - Remove nsStyleCoord::HashValue(); r=bholley
...
This method is dead code.
2017-07-03 21:55:18 -04:00
Ting-Yu Lin
3cfff373f7
Bug 1333366 Part 1 - Update document related to Corner and HalfCorner. r=mats
...
MozReview-Commit-ID: 4wnjQOvploH
--HG--
extra : rebase_source : f300a44b190377e8217e5070f2d01261f54f5d22
2017-01-24 18:37:05 +08:00
Ting-Yu Lin
d4db857fcf
Bug 1320014 Part 2 - Rename Corner to LogicalCorner, and move it to nsStyleCoord.h. r=mats
...
To avoid confusion with the mozilla::css::corner, rename ::Corner to
mozilla::LogicalCorner, and move it to nsStyleCoord.h. Also, append
LogicalCorner prefix to all the enum values to match the coding style.
It also fixed the build error preemptively in a later patch that removing
::css namespace from mozilla::css::corner.
MozReview-Commit-ID: BbRYFuT3v4W
--HG--
extra : rebase_source : b8891eaa475c803de9a2137cb5e9a5a4bde37b9f
2017-01-04 16:52:12 +08:00
Ting-Yu Lin
b8e8384476
Bug 1325006 Part 1 - Allow enum or enum classes to be stored in nsStyleCoord. r=heycam
...
MozReview-Commit-ID: EEXh6n8u7l6
--HG--
extra : rebase_source : 2a73a5f136d2b6c04848fbeee7067781cb38400d
2016-12-21 17:03:07 +08:00
Ting-Yu Lin
754b6c9659
Bug 1317588 Part 3 - Remove #define NS_SIDE_TOP/RIGHT/BOTTOM/LEFT. r=mats
...
This patch was written with the help of the following script. Also, manually
add mozilla qualifier to the enum values in nsStyleCoord.h, gfxRect.h, and
Types.h to make it build.
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename "NS_SIDE_TOP" "eSideTop"
rename "NS_SIDE_RIGHT" "eSideRight"
rename "NS_SIDE_BOTTOM" "eSideBottom"
rename "NS_SIDE_LEFT" "eSideLeft"
MozReview-Commit-ID: 9T0ORsqM6nP
--HG--
extra : rebase_source : 884ad96104c6e9cf6c8b3145d2d3a071ecccfe6a
2016-11-18 18:12:25 +08:00
Ting-Yu Lin
c9cfd878cb
Bug 1317588 Part 2 - Remove mozilla::css::Side typedef. r=mats
...
This patch is written with the help of the following script.
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename "css::Side" "Side"
MozReview-Commit-ID: DPV6vivpPUp
--HG--
extra : rebase_source : 9c4f66dc9d2b26c89a4517fba4ff9c5db413411b
2016-11-18 16:28:38 +08:00
Manish Goregaokar
dc45507308
Bug 1295662 - Document layout of nsStyleCorners and inset StyleBasicShape; r=heycam
...
MozReview-Commit-ID: DYwaSnLvWJK
--HG--
extra : rebase_source : 1b03f8b3ed067897acbeed0719bdc03ca12f55fa
2016-08-17 15:39:34 +05:30
Manish Goregaokar
38e52065f0
Bug 1290061 - stylo: Mark nsStyleUnion/Unit fields as unsafe and private for bindgen; r=bholley
...
MozReview-Commit-ID: 6K38Gvbn4vn
--HG--
extra : rebase_source : afad5ea307d17c86ad4fb6be32f577f656c5f76f
2016-07-28 17:53:19 +05:30
Manish Goregaokar
16e3e13447
Bug 1287435 - stylo: Add bindings for nsStyleCoord::Calc; r=heycam
2016-07-15 20:56:48 +05:30
Daniel Holbert
fb4d5e0d63
Bug 1275067: Flip logic in nsStyleCoord::ToLength, for safer general-case behavior. r=heycam
...
MozReview-Commit-ID: 7KYn5hv2Kmd
2016-05-24 23:54:35 -07:00
Mats Palmgren
b4594808f5
Bug 1273705 - Add convenience methods to check if a margin is 'auto' on either side in an axis. r=dholbert
2016-05-18 13:49:32 +02:00
Bobby Holley
21a222e332
Bug 1270515 - Bonus fix: Factor out unnecessary Reset calls during nsStyleCoord initialization. r=dbaron
...
The previous patches prevent us from generating temporaries at the affected callsites,
but this could still have benefits in other places.
2016-05-06 16:11:10 -07:00
Bobby Holley
23b53c3cad
Bug 1270515 - Avoid synthesizing temporary nsStyleCoords in nsStyleSides::ToLength. r=dbaron
2016-05-06 16:11:10 -07:00
Bobby Holley
e7fab38387
Bug 1270515 - Avoid synthesizing temporary nsStyleCoords in nsStyleSides::ConvertsToLength. r=dbaron
2016-05-06 16:11:10 -07:00
Bobby Holley
6e6e20ba47
Bug 1269901 - Refactor Helpers. r=dbaron
2016-05-04 16:56:17 -07:00
Nicholas Nethercote
8198d15f1e
Bug 1038663 (part 6, attempt 2) - Allow percentage values for 'word-spacing'. r=heycam.
2015-11-08 16:40:37 -08:00
Nigel Babu
52d7459eca
Backed out 6 changesets (bug 1038663) for Android opt R2 bustage
...
Backed out changeset 97e3492d6080 (bug 1038663)
Backed out changeset d176322f2d36 (bug 1038663)
Backed out changeset f69af9161252 (bug 1038663)
Backed out changeset 8bb77e5fad8c (bug 1038663)
Backed out changeset 954e57438f51 (bug 1038663)
Backed out changeset 16c0919101cd (bug 1038663)
2015-11-06 12:49:36 +05:30
Nicholas Nethercote
b7bd8564c0
Bug 1038663 (part 6) - Allow percentage values for 'word-spacing'. r=heycam.
...
--HG--
extra : rebase_source : b7220e3c156dfef451e79b2911fbba7dec93850d
2015-11-05 17:25:46 -08:00
Birunthan Mohanathas
a8939590de
Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
...
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
2015-07-13 08:25:42 -07:00
Jonathan Kew
28d878bacb
Bug 1159305 - patch 1 - Provide logical accessors for nsStylePosition and nsStyleSides fields. r=dbaron
2015-05-11 11:35:47 +01:00
Ehsan Akhgari
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Ehsan Akhgari
4354953b4f
Bug 1118486 - Part 1: Use `= delete` instead of MOZ_DELETE directly; r=Waldo
...
Most of this patch (with the exception of dom/bindings/Codegen.py) was
generated by the following bash script:
#!/bin/bash
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "*/.git*" \
! -wholename "obj-*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_DELETE '= delete'
2015-01-08 23:19:05 -05:00
Max Vujovic
4c4ed2fc92
Bug 948265 - Add CSS saturate filter to nsCSSFilterInstance. r=mstange,dbaron
2014-08-20 17:52:28 -07:00
Max Vujovic
891ddf7cb3
Bug 948265 - Add CSS hue-rotate filter to nsCSSFilterInstance. r=mstange,dbaron
2014-08-20 15:46:59 -07:00
Ehsan Akhgari
2b84010cb8
Bug 1048246
- Fix more bad implicit constructors in layout; r=roc
...
--HG--
extra : rebase_source : ed828993139bc70232508364a9f046e38b7d3e06
2014-08-07 19:48:38 -04:00
Cameron McCormack
5a3e19e62c
Bug 1026344 - Part 4: Make nsStyleCoord::Calc refcounted and introduce a non-refcounted nsStyleCoord::CalcValue. r=dbaron
...
This means that style structs holding computed calc() values are now able to be
stored in the rule tree.
2014-06-19 13:18:03 +10:00
Cameron McCormack
916d111a71
Bug 1026344 - Part 2: Make nsStyleUnit a uint8_t-sized enum so we can use it on nsStyle{Sides,Corners}. r=dbaron
2014-06-19 13:17:10 +10:00
Simon Sapin
12935dcb17
Bug 976787 part 1: Add the grid-template-{columns,rows} properties to the style system. r=dholbert
2014-03-10 15:54:13 -07:00
David Zbarsky
3250bd906e
[Bug 847110] Fix up includes in layout/style r=dbaron
2013-03-02 19:31:48 -05:00
Paul Adenot
2ff8ad5b57
Bug 761393 - Add a method to hash an nsStyleCoord. r=dbaron
2012-08-26 21:08:32 -07:00
Ehsan Akhgari
e368dc9c85
Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
...
This patch was generated by a script. Here's the source of the script for
future reference:
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int
convert PRUintn unsigned
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
2012-08-22 11:56:38 -04:00
Aryeh Gregor
d0ad5a7d0c
Bug 777292 part 2 - Change all nsnull to nullptr
2012-07-30 17:20:58 +03:00
Gervase Markham
82ff7027aa
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
Daniel Holbert
22ee3b126d
Bug 742581: Make definition of nsStyleCoord::GetCoordValue() consistent with the declaration, regarding what the function's return type is. r=dbaron
2012-04-06 17:01:32 -07:00
L. David Baron
17659793f1
Make nsStyleCoord's member variables private, as they should have been. (Bug 730240) r=bzbarsky
2012-02-24 21:23:14 -08:00
L. David Baron
a252d1e95b
Depend on assignment and copy construction of unions in nsStyleCoord. (Bug 730240) r=bzbarsky
2012-02-24 21:23:14 -08:00
Boris Zbarsky
e0c4316236
Bug 716628. Implement support for 'turn' unit in CSS. r=dbaron
2012-02-04 00:01:23 -05:00
Michael Wu
d2b70213ac
Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones
...
--HG--
rename : tools/trace-malloc/bloatblame.c => tools/trace-malloc/bloatblame.cpp
2011-09-28 23:19:26 -07:00
L. David Baron
3d7d18c200
Simplify storage of computed calc() as a result of removing min() and max(). (Bug 363249) r=bzbarsky a2.0=blocking2.0:beta6
2010-09-11 09:27:13 -07:00
L. David Baron
8e923adf2c
Remove support for min() and max() in calc(): remove support for parsing and storage. (Bug 363249) r=bzbarsky a2.0=blocking2.0:beta6
2010-09-11 09:27:12 -07:00
L. David Baron
8d91e9081d
Make it possible to store pointer values in nsStyleSides. (Bug 585715) r=bzbarsky a2.0=blocking+
2010-08-25 12:17:56 +02:00
L. David Baron
46490e81bb
Introduce nsStyleCoord::HasCoordOrNonPercentCalc to check for either a coord value or a calc() value not containing a percent. (Bug 585715) r=bzbarsky a2.0=blocking+
2010-08-25 12:17:55 +02:00
L. David Baron
685f0146eb
Introduce nsStyleCoord::HasPercent to check for either a percent value or a calc() value containing a percent. (Bug 585715) r=bzbarsky a2.0=blocking+
2010-08-25 12:17:55 +02:00
L. David Baron
2a023744e6
Add support for calc() to the 'width' property. (Bug 585715) r=bzbarsky a2.0=blocking2.0+
2010-08-11 12:32:53 -07:00