Alex Chronopoulos
6316ff735c
Bug 1460559 - Enable AsyncLogger in media capture files. r=pehrsons
...
MozReview-Commit-ID: 7IXcP2zcn5k
--HG--
extra : rebase_source : a75af575a137b7c050355a9c84ec256e6fc585b6
2018-05-11 15:05:16 +02:00
Alex Chronopoulos
d409b4d3b8
Bug 1457427 - Restructure EnumerateDevices method is webrtc engine to improve readability. r=pehrsons
...
Restructuring of the existing code no functional change.
MozReview-Commit-ID: FARNItrajfD
--HG--
extra : rebase_source : 0887c6546bb43538e32b99950e2febca77a32bfb
2018-05-07 19:33:41 +02:00
Paul Adenot
fbf116232d
Bug 1444976 - Trace some initial real-time media stuff. r=pehrsons
...
MozReview-Commit-ID: 7mmDHVS2t8f
--HG--
extra : rebase_source : ac56722792f99aadd8e359ef9ae4b30f6dc78076
extra : source : 7b9d0ce0b1cb20540d1c5bf4c77596359b5cb73e
2018-04-12 17:51:35 +02:00
Andreea Pavel
5a4b5686f6
Merge mozilla-central to autoland a=backout on a CLOSED TREE
...
--HG--
extra : rebase_source : 3bbd9b3ffa46ec76f58d6d4d6ce672dd909b8457
2018-04-18 21:36:17 +03:00
Andreea Pavel
14ac5e554d
Backed out 3 changesets (bug 1444976) for failing android at dom/media/tests/mochitest/test_getUserMedia_mediaStreamTrackClone.html a=backout
...
Backed out changeset 79b7ee8b01ee (bug 1444976)
Backed out changeset 35ca96cabe3c (bug 1444976)
Backed out changeset 2512c9c24244 (bug 1444976)
2018-04-18 21:25:14 +03:00
Andreas Pehrson
1c41efddfa
Bug 1454625 - Don't update settings from constraints if already updated from frame. r=padenot
...
MozReview-Commit-ID: KgiPUnXCWoM
--HG--
extra : rebase_source : 2f378128008ed8c95fb7f3cb3b6601c54ef4c88b
2018-04-17 17:09:11 +02:00
Andreas Pehrson
3be3fab400
Bug 1454625 - Schedule settings update before setting mImage. r=padenot
...
MozReview-Commit-ID: 9IasAgJImuI
--HG--
extra : rebase_source : 67fc9036b72c19f8fa73084053d617537e0cdaca
2018-04-17 11:14:19 +02:00
Paul Adenot
f00a090b8a
Bug 1444976 - Trace some initial real-time media stuff. r=pehrsons
...
MozReview-Commit-ID: 7mmDHVS2t8f
--HG--
extra : rebase_source : a6b0bd42a63f3fc6e4a6307249ed447d749f96c4
extra : source : 7b9d0ce0b1cb20540d1c5bf4c77596359b5cb73e
2018-04-12 17:51:35 +02:00
Cosmin Sabou
2680ecadac
Backed out 3 changesets (bug 1444976) for build bustages on dom/media/AsyncLogger. CLOSED TREE
...
Backed out changeset b021b33ddf74 (bug 1444976)
Backed out changeset 822a57090d84 (bug 1444976)
Backed out changeset 0fa5f7cfee1d (bug 1444976)
2018-04-17 13:07:12 +03:00
Paul Adenot
d9b247b0d7
Bug 1444976 - Trace some initial real-time media stuff. r=pehrsons
...
MozReview-Commit-ID: 7mmDHVS2t8f
--HG--
extra : rebase_source : 0ab839099c0a5d83f639a1157c126d6fae60cb1e
extra : source : 7b9d0ce0b1cb20540d1c5bf4c77596359b5cb73e
2018-04-12 17:51:35 +02:00
Nico Grunbaum
b5c0e1c02f
Bug 1449832 - restore screen share scaling code to prevent cropping r=pehrsons
...
MozReview-Commit-ID: KctPLbF4PSa
--HG--
extra : rebase_source : 8a3a63a1df890e2343dec44f4cdfe1193d317a9a
2018-04-12 14:26:14 -07:00
Andreas Pehrson
aaf89f2684
Bug 1447982 - Rename mLastPrefs to mNetPrefs and update comment for clarity. r=padenot
...
MozReview-Commit-ID: CJPSDG5OHBs
--HG--
extra : rebase_source : 4be85639204fb53f02f1f5262fa945b78a97b286
2018-03-26 12:24:17 +02:00
Andreas Pehrson
83d5534ca3
Bug 1447982 - Remove early exit when no change on Reconfigure. r=padenot
...
We don't want to skip all remaining steps. For now it just affects some logging,
but there may be new ones added in the future.
MozReview-Commit-ID: 7fBdgLNT780
--HG--
extra : rebase_source : dc5113298c1dbadd23c19127349a4a66cd460b4c
2018-03-26 12:23:12 +02:00
Andreas Pehrson
deb26bcad0
Bug 1447982 - Pass GraphImpl into ApplySettings. r=padenot
...
MozReview-Commit-ID: GQlRUB3O1em
--HG--
extra : rebase_source : 80f6fc2f599a917f05de5af00103bbbff3f1caf0
2018-03-26 12:18:35 +02:00
Andreas Pehrson
cb8419331d
Bug 1447982 - Remove unused MediaEnginePrefs from AllocationHandle. r=padenot
...
MozReview-Commit-ID: 3gIU7MCddWG
--HG--
extra : rebase_source : f894d4dcefe229cd8b3aa170c9dd617b4a2b6314
2018-03-26 12:15:56 +02:00
Andreas Pehrson
1776ec7eae
Bug 1447982 - Apply and update mic source settings on Reconfigure. r=padenot
...
MozReview-Commit-ID: KKcRclPpCB2
--HG--
extra : rebase_source : 688291ca5dbaecd0992ad98555d1b4da54aebf84
2018-03-26 11:05:52 +02:00
Andreas Pehrson
be1fb6ddb7
Bug 1447982 - Mic source's ApplySettings shouldn't have weird side effects. r=padenot
...
MozReview-Commit-ID: DCVi5Wy4WN2
--HG--
extra : rebase_source : 422704dbd55e50326816aebb3bdc7767ba835e4a
2018-03-26 11:04:51 +02:00
Andreas Pehrson
6c20c3f1cf
Bug 1447982 - Move mic source allocation logging so it actually covers allocations. r=padenot
...
MozReview-Commit-ID: Ipq5vqCfvgi
--HG--
extra : rebase_source : 9501f3ce7eee7e6cbf5bc839e4f7581be5a5a543
2018-03-26 11:03:58 +02:00
Andreas Pehrson
bd47efdaa2
Bug 1447982 - Cover channel count changes also when mic source is stopped (muted). r=padenot
...
MozReview-Commit-ID: HtDS5SXL08
--HG--
extra : rebase_source : bd815cffb2705fcb1da817b10daeb738405e76dd
2018-03-26 11:02:26 +02:00
Andreas Pehrson
b47ca1eca7
Bug 1447982 - Guard against destroyed stream. r=padenot
...
MozReview-Commit-ID: 51opeU1U6GR
--HG--
extra : rebase_source : 45abf299f05fa1cd8520723b329652d83c1212d7
2018-03-26 10:57:36 +02:00
Andreas Pehrson
c26ee52a6e
Bug 1447982 - Remove unnecessary conditional. r=padenot
...
MozReview-Commit-ID: LKy9TGsGEfj
--HG--
extra : rebase_source : 1bba3bf46287febe8c249b8603503db7ae8716e1
2018-03-26 10:57:06 +02:00
Bryce Van Dyk
27bbb1c83b
Bug 1453648 - Remove special handling for Sine source at 440 Hz test device. r=achronop
...
MozReview-Commit-ID: foVINjjMOX
--HG--
extra : rebase_source : 6d33600302fdd89b6eee6a874b82e30a06eeb5de
2018-04-11 17:12:28 -04:00
Andreas Pehrson
c376bbc538
Bug 1450954 - Add back code to undo screenshare constraints hack. r=jib
...
MozReview-Commit-ID: 9rDRj7U8vQi
--HG--
extra : source : e2bd588aa90fe44fe38caed6bc7680111394b934
extra : histedit_source : 148034b0adc84941ae9c39716bb3da6d8258e3a4
2018-04-10 13:13:41 +02:00
Andreas Pehrson
1e2190d040
Bug 1451798 - Check the variable actually containing the string. r=jib
...
MozReview-Commit-ID: 2xizfHwVPiW
--HG--
extra : rebase_source : 345327a6721e84b64ba3b66cb308dbe1100391bb
2018-04-06 15:06:46 +02:00
Nils Ohlmeier [:drno]
48edb741ab
Bug 1446880: updated IDP interface to use RTCIdentityProviderOptions. r=mt
...
MozReview-Commit-ID: 2xwDYR2kk27
--HG--
extra : rebase_source : 043a2217af0735ad0a5d0d72398e7771fd055105
2018-03-20 11:15:10 +00:00
Brindusan Cristian
88cd740311
Backed out 3 changesets (bug 1446880) for mochitest failures on test_exceptions_from_jsimplemented.htm CLOSED TREE
...
Backed out changeset 3d162d7e2721 (bug 1446880)
Backed out changeset 7142d472f2a4 (bug 1446880)
Backed out changeset 50c255c237f1 (bug 1446880)
2018-04-04 20:48:59 +03:00
Nils Ohlmeier [:drno]
f3ad51380e
Bug 1446880: updated IDP interface to use RTCIdentityProviderOptions. r=mt
...
MozReview-Commit-ID: 2xwDYR2kk27
--HG--
extra : rebase_source : c25e6ae78af97bf974079a58795a8f11ceb10912
2018-03-20 11:15:10 +00:00
Bryce Van Dyk
93937894aa
Bug 1449178 - MediaEngineWebRTC now clears device indicies while updating before checking cubeb. r=padenot
...
Stop us potentially keeping a stale device list when updating if we can't get a
cubeb context.
MozReview-Commit-ID: H6GdeNXObWV
--HG--
extra : rebase_source : 48fce949627fa17402336db824374847e1b439e6
2018-03-26 14:14:47 -04:00
Miko Mynttinen
65c6bee9d6
Bug 1445302 - Replace TArray.RemoveElementAt(TArray.Length() - 1) pattern with TArray.RemoveLastElement() or TArray.PopLastElement() r=froydnj
...
MozReview-Commit-ID: rGjabnP2iz
--HG--
extra : rebase_source : 1ef6c5ce028ac9ebd9f3176d57835c43fe46bada
2018-03-13 14:51:33 +01:00
Matthew Gregan
3eacaf6b89
Bug 1445546 - Initialize COM on the MediaManager thread. r=padenot
...
MozReview-Commit-ID: 92FErxjmDE5
--HG--
extra : rebase_source : a1c3c5a1dd08a81fff64c85e7a953052803de64c
2018-03-20 10:31:40 +13:00
Andreas Pehrson
32da610e23
Bug 1443803 - Protect against destroyed MediaStream in MediaEngineWebRTCMicrophoneSource. r=padenot
...
MozReview-Commit-ID: 3vyzS0DceKI
--HG--
extra : rebase_source : 127ff05f24c28c813af9cd3c90484fdedbf8faa2
2018-03-14 16:46:46 +01:00
Andreas Pehrson
4c95dc3099
Bug 1438134 - Make the return value of MediaEngineSource::Reconfigure well defined. r=jib
...
MozReview-Commit-ID: DR3sdtdZkob
--HG--
extra : rebase_source : 35d60c11c8bd50547062af708cb009f7835b5893
2018-02-22 15:35:16 +01:00
Andreas Pehrson
f88baf18ca
Bug 1438134 - Apply new capability only after stopping capture. r=jib
...
MozReview-Commit-ID: 6rtcyFpwxmP
--HG--
extra : rebase_source : 8f8b510f7a0369e2f07a61dbdfcaa9272674b0ad
2018-02-14 12:24:25 +01:00
Adrian Wielgosik
27009d1b15
Bug 1445408 - Remove nsIDOMClientRect. r=bz
...
MozReview-Commit-ID: HP4E3cADa8i
--HG--
extra : rebase_source : caffa42f22f6c25d62d080aa6f65e5105ad263e9
2018-03-13 14:19:17 +01:00
Andreas Pehrson
411e973fab
Bug 1436694 - Clarify that MediaEngineSources can be double-stopped. r=padenot
...
This is already true for the audio sources. It should be for all.
Crashtests showed that shutting down amidst the async init can lead to
double-stops. It is impossible to completely protect yourself from them without
waiting for all queued operations to resolve (results to become known) before
taking action. Doing that would require a refactor in MediaManager and cause
higher latency for device operations so it seems like the wrong way to go.
MozReview-Commit-ID: 5Cci6whzTL7
--HG--
extra : rebase_source : f4dccbc5a56e33ecc54d63ddefbae43d90ee95d4
extra : source : f5cc71d38e4a7c0e4db830242c1d454fcbdb9e48
extra : histedit_source : 3cd8615054ce9935047e4168c3a472152792886b
2018-02-22 12:23:06 +01:00
Andreas Pehrson
5a5674705c
Bug 1280099 - Retain image size after stopping MediaEngineDefaultVideoSource. r=jib
...
MozReview-Commit-ID: Kacol64Jo0F
--HG--
extra : rebase_source : 6c57c7eff9c1adbe84dc2815482ff02ccd44a39d
extra : histedit_source : 3acea4ea361d8c73122b6facdcd5d6b7a41601f2
2018-03-06 18:11:38 +01:00
Andreas Pehrson
c2cf44b1d5
Bug 1441145 - Swap width and height in target capability if the frame is rotated. r=jib
...
MozReview-Commit-ID: 3QO3W0J3b6G
--HG--
extra : rebase_source : 956fe446b34fb797e11a36ab21b9808c23ac8cc1
2018-02-26 15:42:57 +01:00
Andreas Pehrson
edf62f8506
Bug 1440169 - Don't reset mLastNotify in resuming Start(). r=padenot
...
MozReview-Commit-ID: 6AL8QpSnwwm
--HG--
extra : rebase_source : 1cf74cb4c177fcaca91f923748308e20d6c38136
2018-03-02 12:48:34 +01:00
Andreas Pehrson
624c03aed6
Bug 1440169 - Take TrackTicks samples in SineWaveGenerator::generate. r=achronop,padenot
...
MediaEngineDefaultAudio uses the SineWaveGenerator and passes a
TrackTicks (int64_t) arg to generate(). It need to take the same type
or bad things can happen.
MozReview-Commit-ID: EoybtTFkWhT
--HG--
extra : rebase_source : c21bbbc2729d092ad78ffe877bf141dbce3a41d3
2018-03-02 11:43:57 +01:00
Andreas Pehrson
ae85e5be40
Bug 1440040 - Improve MediaEngineWebRTCMicrophoneSource logging. r=padenot
...
MozReview-Commit-ID: 3mB1gZOGfCY
--HG--
extra : rebase_source : 12d0ae852b704717e8c7b4d5f0a3a2ad4f38d50e
2018-02-28 22:46:33 +01:00
Andreas Pehrson
a087cace0d
Bug 1440040 - Fix assertion that checks for appending silence in real callback when enabled. r=padenot
...
MozReview-Commit-ID: IiEQ7fKKz8g
--HG--
extra : rebase_source : d0e0d532fb7cd4223a072502be2097065f4037df
2018-02-28 22:45:40 +01:00
Andreas Pehrson
aecea2a024
Bug 1440040 - Properly apply microphone capture settings. r=padenot
...
MozReview-Commit-ID: 7TqYvHrltxm
--HG--
extra : rebase_source : 5a6d972c6e07b17737c17cfa4827cbe5352c852a
2018-02-28 22:41:15 +01:00
Andreas Pehrson
c597c8df87
Bug 1440252 - Implement MediaEngineWebRTCMicrophoneSource::GetSettings. r=padenot
...
MozReview-Commit-ID: IVbax9Xxs8R
--HG--
extra : rebase_source : 6d42af31705860100ba40b0d750ddce2b513467d
2018-02-26 09:41:20 +01:00
Andreas Pehrson
ce1efe51da
Bug 1440347 - Lock while modifying mAllocations. r=padenot
...
--HG--
extra : rebase_source : 2f5c6e13e8f930b82ff26190485bb8eed69592e4
extra : histedit_source : 0b3cfe11cdd16ee5bf42eec68196de9531e2c36b
2018-02-23 10:20:01 +01:00
Andreas Pehrson
f5d34fea0d
Bug 1430856
- Default to two default capabilities when a camera can handle anything. r=jib
...
If a camera returns no capabilities we interpret it as it being able to handle
any capability we throw at it. However, we also end up trying to start it with
the default capability of 0x0@0. This often works, but we can crash when
rescaling it to the chosen target capability 0x0@0.
With this patch we inject up to two default capabilities, one at 640x480@30 and
one at 1280x720@30. With constraints present we'll try to adjust these defaults
so they fit within the constraints while at the same time preserve the
aspect ratio given by prefs.
MozReview-Commit-ID: 3mr7Li5TTbV
--HG--
extra : rebase_source : c525c2fd8d60f5dece548216caefc4976e9afb0b
2018-02-13 20:22:18 +01:00
Andreas Pehrson
7186f8d0f3
Bug 1430856
- Cache CaptureCapability in CapabilityCandidate. r=jib
...
This will lead to less ipc calls, hopefully speeding up getUserMedia for many
devices.
This also lets us inject any hardcoded capabilities into the candidateSet in
the future (read: next patch).
MozReview-Commit-ID: HjIhRK1nVA1
--HG--
extra : rebase_source : f58e16c45f7bd6738ce0a0527dc86854f804bc7b
2018-02-13 20:13:47 +01:00
Andreas Pehrson
fe7bade6b4
Bug 1434946 - Indentation fix. r=jib
...
MozReview-Commit-ID: JCQxatbThyI
--HG--
extra : rebase_source : 6d5c7319a69da1b5e93b352be79400ad8fd526f8
2018-02-01 18:35:55 +01:00
Andreas Pehrson
0c896f9aef
Bug 1434946 - Set framerate in settings when capabilities are updated. r=jib
...
This adds back the `framerate` update that was removed in bug 1299515.
It also fixes a threading issue (not really an issue, but it broke the
documented policy) where Start() wrote to mCapability without holding mMutex.
MozReview-Commit-ID: Jda5moNhlkM
--HG--
extra : rebase_source : a8f27f064b9f818eb29aa72a18605786c474631b
2018-02-01 17:00:59 +01:00
Andreas Pehrson
f52aa5b27e
Bug 1434946 - Report resolution change in settings already on first frame. r=jib
...
MozReview-Commit-ID: IzhdiHgVKOc
--HG--
extra : rebase_source : 085308eb966554ed71fb6b758cd59132b43d6ceb
2018-02-01 16:58:35 +01:00
Andreas Pehrson
422d32be88
Bug 1434861 - Simplify rescaling code in MediaEngineRemoteVideoSource::DeliverFrame. r=jib
...
Most importantly, this reduces the number of copies to 1 in the common case.
In a case where we are rescaling because there are competing gUM requests
this does two copies, where one is the crop-and-scale operation itself.
In the worst case we do two allocations, but with a buffer pool and a recycling
ImageContainer we allocate very rarely in practice.
MozReview-Commit-ID: B0Et4wZol9n
--HG--
extra : rebase_source : e0950a53278336773570c9e989a21392195f8898
2018-02-01 16:06:19 +01:00