Originally, the patch for Bug 1298722 was not going to label these functions as
MOZ_MUST_USE, and it added a brief code-comment to explain that. But then it
did end up labeling them as MOZ_MUST_USE after all, in response to some review
feedback. And it kept the now-incorrect comment around by accident, it
seems. This followup just removes that incorrect comment.
MozReview-Commit-ID: 2c35wQPzXRN
This allows for the alignas(_) case to be distinguished from the
MOZ_NON_PARAM case through notes.
The following is what the IntInterval bug fixed in Part 2 of this bug
looks like with the new diagnostics:
/home/mlayzell/Code/moz/working/dom/media/gtest/TestIntervalSet.cpp:196:47: error: Type 'IntIntervals' (aka 'IntervalSet<int>') must not be used as parameter
static void GeneratePermutations(IntIntervals aI1,
^
/home/mlayzell/Code/moz/working/dom/media/gtest/TestIntervalSet.cpp:196:47: note: Please consider passing a const reference instead
/home/mlayzell/Code/moz/working/dom/media/Intervals.h:695:17: note: 'IntIntervals' (aka 'IntervalSet<int>') is a non-param type because member 'mIntervals' is a non-param type 'ContainerType' (aka 'AutoTArray<Interval<int>, 4>')
ContainerType mIntervals;
^
/home/mlayzell/Code/moz/working/obj-clang-x86_64-pc-linux-gnu/dist/include/nsTArray.h:2472:3: note: 'ContainerType' (aka 'AutoTArray<Interval<int>, 4>') is a non-param type because member '' is a non-param type 'union (anonymous union at /home/mlayzell/Code/moz/working/obj-clang-x86_64-pc-linux-gnu/dist/include/nsTArray.h:2472:3)'
union
^
/home/mlayzell/Code/moz/working/obj-clang-x86_64-pc-linux-gnu/dist/include/nsTArray.h:2477:72: note: 'union (anonymous union at /home/mlayzell/Code/moz/working/obj-clang-x86_64-pc-linux-gnu/dist/include/nsTArray.h:2472:3)' is a non-param type because member 'mAlign' is a non-param type 'mozilla::AlignedElem<(mozilla::AlignmentFinder<Header>::alignment > mozilla::AlignmentFinder<elem_type>::alignment) ? mozilla::AlignmentFinder<Header>::alignment : mozilla::AlignmentFinder<elem_type>::alignment>'
MOZ_ALIGNOF(Header) : MOZ_ALIGNOF(elem_type)> mAlign;
^
/home/mlayzell/Code/moz/working/obj-clang-x86_64-pc-linux-gnu/dist/include/mozilla/Alignment.h:85:8: note: 'mozilla::AlignedElem<(mozilla::AlignmentFinder<Header>::alignment > mozilla::AlignmentFinder<elem_type>::alignment) ? mozilla::AlignmentFinder<Header>::alignment : mozilla::AlignmentFinder<elem_type>::alignment>' is a non-param type because member 'elem' has an alignas(_) annotation
struct AlignedElem<4>
^
MozReview-Commit-ID: 4KIbzEKnmNU
With this patch, permissions are not actually applied,
but the permissions api is in place.
MozReview-Commit-ID: CTaXz5sa1xy
--HG--
extra : rebase_source : d5cc18abbae6809b196f8497ff91608d662d5030
extra : source : e4c13d11e401ae3bd40be3a5a7fb0aaf95c992bb
- Convert the object used to represent permissions to the format
used in the optional permissions UI (property hosts becomes origins)
- Turn Extension.userPermissions into a getter
MozReview-Commit-ID: Dc44DMfKjG
--HG--
extra : rebase_source : e24e1b52edd3ddcd353a6407497ec4076039af03
Add support for -moz-image-rect
r=Manishearth
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix#15948 and [Bug 1341763](https://bugzilla.mozilla.org/show_bug.cgi?id=1341763)
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: c2d9f663afd6c804c30a7a077392b836e1fa29b5
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 89cf026c56b5e318143703cd3c857732e8e81991
This patch makes urlbarBindings.xml use AppConstants from the global scope and
removes the related field.
MozReview-Commit-ID: E2KvOsZVX7q
--HG--
extra : rebase_source : f0d8c35e17717d81ae1d7d2d1cc5fea21b1b5ccd
With this patch, permissions are not actually applied,
but the permissions api is in place.
MozReview-Commit-ID: CTaXz5sa1xy
--HG--
extra : rebase_source : f623b4c7c66888ab1fb4876a3d63ec47677711b8
extra : source : e4c13d11e401ae3bd40be3a5a7fb0aaf95c992bb
- Convert the object used to represent permissions to the format
used in the optional permissions UI (property hosts becomes origins)
- Turn Extension.userPermissions into a getter
MozReview-Commit-ID: Dc44DMfKjG
--HG--
extra : rebase_source : 4924aa007da4b649266311138b4d240eeeade9a4
Michael Layzell
Daniel Holbert
Robert Longson
Kris Maglione
Joel Maher
Stanford Lockhart
Aki Sasaki
Sebastian Hengst
Hrishikesh Barman
Dão Gottwald
Timothy Nikkel
Olli Pettay
Wes Kocher
Ben Kelly
Boris Zbarsky
Andrew Swan
Nazım Can Altınova
Federico Padua
Emilio Cobos Álvarez
Gijs Kruitbosch