6ef703115e
Bug 1689548 - [devtools] Don't simulate flash on screenshot when prefers-reduced-motion is enabled. r=ladybenko.
...
We also take this opportunity to simplify the simulateCameraFlash function by
using a simpler version of element.animate.
Differential Revision: https://phabricator.services.mozilla.com/D103457
2021-01-29 15:05:05 +00:00
2eaa5a9634
Bug 1687915 - [devtools] Display a warning message when the --selector argument passed to :screenshot does not match any node. r=ladybenko.
...
When the selector doesn't return any node, we log a warning on the page.
A test case is added in browser_jsterm_screenshot_command_selector.js to ensure
this works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D102753
2021-01-29 15:04:52 +00:00
796bb2f86e
Bug 1689034 - part 1: Get rid of communication part between plugin process and widget in the main process r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D103138
2021-01-28 08:23:33 +00:00
2ffc4487a8
Bug 1551571 - New inactive CSS rule to show warning when table-layout is used on non-table elements. r=fluent-reviewers,flod,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D101224
2021-01-28 13:32:49 +00:00
15010b1abb
Bug 1682220 - [devtools] Use nsiWorkerDebugger#windowIds instead of window reference in DevToolsWorkerChild. r=ochameau.
...
This also allow us to remove the ignoreExistingTargets option we had to workaround Bug 1673024.
Differential Revision: https://phabricator.services.mozilla.com/D99648
2021-01-28 13:23:45 +00:00
23fbcf2d92
Bug 1671457 - Fixed incorrect inactive CSS warning for text-overflow r=jdescottes
...
Corrected the warning about when text-overflow has no effect including different settings for overflow-x and overflow-y depending on the writing mode.
Depends on D102814
Differential Revision: https://phabricator.services.mozilla.com/D102815
2021-01-25 23:20:29 +00:00
05898b6c22
Bug 1671457 - Put vertical writing mode check into separate method r=jdescottes
...
In order to be able to reuse the check for whether a note has a vertical writing mode, the logic got split out from the table track parent method into its own method.
Differential Revision: https://phabricator.services.mozilla.com/D102814
2021-01-25 22:59:26 +00:00
f5a8824095
Bug 1657435 - [devtools] Migrate from getAllDocShellsInSubtree to getAllBrowsingContextsInSubtree in DevTools. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D103027
2021-01-26 17:31:12 +00:00
43cc7423e5
Bug 1651391 - Display remote type in the browser toolbox context selector. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D88082
2021-01-26 13:37:56 +00:00
f790641b12
Bug 1688538: Add a code-comment to explain why devtools shouldn't warn for "inactive" properties that are inherited-by-default. r=jdescottes
...
DONTBUILD because this is a code-comment-only change.
Differential Revision: https://phabricator.services.mozilla.com/D102886
2021-01-25 19:29:13 +00:00
c30e9de30a
Bug 1688508 - Also enable the event on initialization.
...
MANUAL PUSH: Orange on browser_markup_shadowdom_dynamic.js on a
CLOSED TREE
2021-01-25 14:12:40 +01:00
b74a3bb722
Bug 1688508 - Fire shadowrootattached only if devtools is observing the document. r=smaug
...
Much like devtools manages the existing stylesheet changed events.
This is tested by devtools/client/inspector/markup/test/browser_markup_shadowdom.js
Differential Revision: https://phabricator.services.mozilla.com/D102875
2021-01-25 11:30:51 +00:00
dc813a31cc
Backed out changeset 870a4ac0af45 (bug 1583901) for devtools failures at browser_rules_preview-tooltips-sizes.js.
2021-01-24 01:22:23 +02:00
f6362f9f72
Bug 1583901 - New inactive CSS rule to show warning when fill-* or stroke-* is used on non-SVG-basic-shape and non-SVG-text elements. r=fluent-reviewers,flod,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D101295
2021-01-23 21:38:22 +00:00
7fd701f5b0
Backed out changeset acc496d59a30 (bug 1682220) after backing out Bug 1657130 for being its blocker.
...
CLOSED TREE
2021-01-21 14:11:55 +02:00
087cac0b8e
Bug 1682220 - [devtools] Use nsiWorkerDebugger#windowIds instead of window reference in DevToolsWorkerChild. r=ochameau.
...
This also allow us to remove the ignoreExistingTargets option we had to workaround Bug 1673024.
Depends on D99441
Differential Revision: https://phabricator.services.mozilla.com/D99648
2021-01-20 07:04:55 +00:00
c44968b45f
Bug 1674068 - [devtools] Fix wrong host being displayed for content process storages r=ochameau
...
Since about:blank gets spawned in the same process when included in a frame, it was being added as a host for the top page in content process storage resources. This patch removes about:blank from the `windows` list unless it is the top level page itself.
Differential Revision: https://phabricator.services.mozilla.com/D96029
2021-01-18 14:59:07 +00:00
2fa4a4364b
Bug 1685493 - Ensure breaking in xpcshell test, even if first line isn't breakable. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D101019
2021-01-19 11:01:54 +00:00
54c1b8dee1
Bug 1687108 - Remove unused content policy types. r=ckerschb,remote-protocol-reviewers,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D102083
2021-01-19 09:42:13 +00:00
86a26392f1
Bug 1687205 - [devtools] Use the network event actor id when getting stacktraces r=ochameau,devtools-backward-compat-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D102116
2021-01-18 17:28:03 +00:00
9cb65eed7f
Bug 1665383 - [devtools] Enable NETWORK_EVENT and NETWORK_EVENT_STACKTRACE by default for fission r=ochameau
...
Enable NETWORK_EVENT and NETWORK_EVENT_STACKTRACE resources by default
Differential Revision: https://phabricator.services.mozilla.com/D99625
2021-01-18 17:27:55 +00:00
a862e95663
Bug 1607741 - [devtools] Remove webconsole cd command. r=ladybenko.
...
The command is removed and the test that were using it
are either removed or updated.
Differential Revision: https://phabricator.services.mozilla.com/D101928
2021-01-18 17:02:14 +00:00
77bb8db1ff
Backed out 3 changesets (bug 1687205, bug 1687192, bug 1665383) for causing devtools failures in browser_net_block-csp.js CLOSED TREE
...
Backed out changeset 812caf90c2c5 (bug 1687192)
Backed out changeset 68f676381ab4 (bug 1687205)
Backed out changeset 34dd7e523954 (bug 1665383)
2021-01-18 18:00:02 +02:00
2f728bd220
Bug 1687205 - [devtools] Use the network event actor id when getting stacktraces r=ochameau,devtools-backward-compat-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D102116
2021-01-18 12:50:14 +00:00
f62c623e39
Bug 1665383 - [devtools] Enable NETWORK_EVENT and NETWORK_EVENT_STACKTRACE by default for fission r=ochameau
...
Enable NETWORK_EVENT and NETWORK_EVENT_STACKTRACE resources by default
Differential Revision: https://phabricator.services.mozilla.com/D99625
2021-01-18 12:50:06 +00:00
8e41ab4800
Bug 1489217 - Pull out headers and cookies fetching from _createNetworkEvent into a dedicated function. r=bomsy
...
I'm doing that because previous patch triggered an eslint warning
about _createNetworkEvent being too complex.
Differential Revision: https://phabricator.services.mozilla.com/D101829
2021-01-18 08:48:12 +00:00
4544e6fbb4
Bug 1489217 - Avoid 'NS_ERROR_FAILURE [nsITraceableChannel.setNewListener]' exception when running DevTools. r=bomsy
...
This exception happens quite frequently with Fission enabled as we start observing requests
while the page already start loading. This happens frequently when target switching.
Differential Revision: https://phabricator.services.mozilla.com/D101828
2021-01-18 08:49:50 +00:00
1b5b46ec79
Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs,marionette-reviewers,whimboo,remote-protocol-reviewers
...
Depends on D100172
Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-14 21:45:14 +00:00
cae099948e
Bug 1686564 - [devtools] Register onExceptionUnwind only once. r=nchevobbe
...
Stop unregistering onExceptionUnwind on navigation (will-navigate) and pauses.
So that we no longer have to re-register it on window-ready and resume.
Instead, only check that we aren't paused when processing an exception.
Regarding navigation, I don't think we want to ignore any exception during the process of navigating to another page.
I would rather say we want to catch anything that happen during this process!
Differential Revision: https://phabricator.services.mozilla.com/D101651
2021-01-14 08:28:18 +00:00
b326fcddff
Bug 1686480 - [devtools] Make ThreadActor.pauseOnExceptions just a wrapper to reconfigure method. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D101650
2021-01-14 07:51:33 +00:00
b95dbbd583
Bug 1686480 - [devtools] Allow all options currently passed to ThreadActor.attach to be passed via ThreadActor.reconfigure. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D101471
2021-01-14 07:54:01 +00:00
04a5a9ecf9
Bug 1686480 - [devtools] A few naive cleanups in ThreadActor. r=nchevobbe
...
Bind onExceptionUnwind only once, remove unused _scripts attribute, create _debuggerSourcesSeen from constructor.
Differential Revision: https://phabricator.services.mozilla.com/D101470
2021-01-14 07:50:56 +00:00
2abb23a415
Backed out 4 changesets (bug 1680637, bug 1682395) for causing mochitest failures in browser_javascriptDialog*.js
...
CLOSED TREE
Backed out changeset f5c4603fc02d (bug 1680637)
Backed out changeset 2f89ad4b915e (bug 1682395)
Backed out changeset 2b7e1df00a1c (bug 1680637)
Backed out changeset c35335c49551 (bug 1680637)
2021-01-14 01:51:52 +02:00
7ba40f5b60
Bug 1579017 - Corrected inactive CSS rule for order property, making it valid for grid items. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D101267
2021-01-13 19:28:17 +00:00
75d7922fc7
Bug 1589658 - [devtools] Guard against missing handlerDO.script in React event-collector r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D101599
2021-01-13 15:16:07 +00:00
298219ee45
Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs,marionette-reviewers,whimboo
...
Depends on D100172
Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-13 13:27:08 +00:00
d6961d7fdf
Bug 1681888 - [devtools] Remove defer usage in devtools/server/startup/worker.js. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D100552
2021-01-13 13:58:41 +00:00
00c0475c5d
Bug 1686417 - [devtools] Generate a list of deprecated DOM methods and attributes. r=ladybenko.
...
This patch modifies and renameGeneratePureDOMFunctions.py so it generates a new file
indicating all the deprecated properties and methods so we can retrieve those information
in DevTools, in order, for example, to not call those deprecated properties and avoid generating
warning messages.
Differential Revision: https://phabricator.services.mozilla.com/D80864
2021-01-13 13:03:10 +00:00
2d91e59e16
Bug 1682029 - [devtools] Remove unused screenshotToDataUrl in devtools/server/actors/device.js r=devtools-backward-compat-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D101347
2021-01-13 09:06:16 +00:00
7742c03714
Backed out 4 changesets (bug 1680637, bug 1682395) for causing Marionette failures. CLOSED TREE
...
Backed out changeset 073e0be7db95 (bug 1680637)
Backed out changeset 552b91b31b0f (bug 1682395)
Backed out changeset c80de6c72779 (bug 1680637)
Backed out changeset d513e228b0ad (bug 1680637)
2021-01-13 02:13:06 +02:00
06e7942185
Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs
...
Depends on D100172
Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-12 22:32:24 +00:00
c6424c9f35
Bug 1685090 - [devtools] Set breakpoints against the top level process target in the context of the browser toolbox. r=jdescottes
...
We need to use the same technique as in watchResources in order to ensure
reaching out the top level targets running in the parent process...
Differential Revision: https://phabricator.services.mozilla.com/D100926
2021-01-11 13:20:30 +00:00
0dc8212706
Bug 1685257 - [devtools] Remove unused allowChromeProcess trait. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D101017
2021-01-07 13:40:46 +00:00
a9d7e2e52e
Bug 1681893 -[devtools] Remove defer usage in devtools/server/tests/xpcshell/head_dbg.js r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D101258
2021-01-11 07:49:25 +00:00
bf1098943a
Bug 1551569 - New inactive CSS rule to show warning when margin or padding is used on internal table elements. r=nchevobbe,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D101091
2021-01-11 07:30:02 +00:00
947d31a9ff
Bug 1685667 - Move devtools/shared/screenshot files to client/server. r=jdescottes.
...
Since capture.js was only loaded by server files and
save.js by client files, there wasn't any reason to
have them in devtools/shared.
The files are moved and the references are updated.
Differential Revision: https://phabricator.services.mozilla.com/D101142
2021-01-08 17:36:36 +00:00
2b7ccb7ce1
Bug 1685917 - Remove the moz-focus-outer code. r=heycam
...
This pseudo does nothing and we successfully removed it in bug 1655859
(firefox 81).
Differential Revision: https://phabricator.services.mozilla.com/D101289
2021-01-11 01:57:17 +00:00
fd417d4f9f
Bug 1628936 - [devtools] Use the correct storage principal for handling cookies. r=ladybenko
...
For iframes it's important that we use the correct storage principal when interacting with cookies.
With dFPI enabled the origin attributes of third party contexts are different from the top ones.
This led to situations where we didn't show any cookies for storage isolated third party frames.
Differential Revision: https://phabricator.services.mozilla.com/D99439
2021-01-08 16:33:36 +00:00
cf1c89970f
Bug 1439963 - [devtools] Handle evaluation result in a new task, after the evaluation is done. r=ochameau.
...
This way we ensure that any microtask created by the evaluated expression are
run, which can impact what we send to the client (e.g. `Promise.resolve().then(() => 246)`
will show a resolved promise instead of a pending one).
Some stubs and node tests are added to ensure this does fix the issue.
Differential Revision: https://phabricator.services.mozilla.com/D100979
2021-01-08 13:47:00 +00:00
dae4c7eb6f
Bug 1682780 - [devtools] Used contants to define ThreadActor `state` attribute. r=jdescottes,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D100986
2021-01-07 13:36:11 +00:00
Nicolas Chevobbe
Masayuki Nakano
Sebastian Zartner
Alexandre Poirot
Daniel Holbert
Emilio Cobos Álvarez
Brindusan Cristian
Mihai Alexandru Michis
Belén Albeza
Masatoshi Kimura
Hubert Boma Manilla
Noemi Erli
Micah Tigley
Julian Descottes
Falguni Islam
Butkovits Atila
pedrofonsecadev
Paul Zuehlcke