Margaret Leibovic
ef66ed11a8
Bug 1152412 - Handle errors downloading and parsing documents for reader view. r=bnicholson
...
--HG--
extra : rebase_source : 3bb7f0207971e48445ad46ddc28d2855d8ba1c3f
2015-04-10 14:41:14 -07:00
vivek
c72a0e5ed1
Bug 1145567 : display toolbar only after Domcontentloaded is triggered -r=margaret.
2015-04-13 13:37:37 -07:00
Margaret Leibovic
bc75832484
Bug 1152022, update Readability to github tip, r=gijs,margaret
...
--HG--
extra : amend_source : 2daac7cb2125136f8fb6895b4b45a53623489d8d
2015-04-09 15:11:24 -07:00
Ryan VanderMeulen
d1af26684e
Backed out changeset e4242ba4cc35 for robocop bustage.
2015-04-09 22:55:51 -04:00
Margaret Leibovic
ca1497979e
No bug, update Readability to github tip, rs=me
2015-04-09 15:11:24 -07:00
Gijs Kruitbosch
8771b32ca6
Bug 1147337 - stop checking article URL as AboutReader.jsm gets created separately every time anyway, r=margaret
...
--HG--
extra : rebase_source : d56acc2bb7d8446259de0ba40cc56af25306bd38
extra : amend_source : 61c66c2075d020e5074a77f9cc64f78ca8e1c621
2015-04-09 00:15:37 +01:00
Blake Winton
06e5c3d6bc
Bug 1149520 - Move the font-size change to the container, so as not to repaint the toolbar. r=jaws, r=margaret
2015-04-07 13:43:57 -04:00
Margaret Leibovic
eb59d95834
Bug 1150695 - Use isProbablyReaderable function from Readability.js. r=Gijs
...
--HG--
extra : rebase_source : eda318f683d424bf4c0c85a4475798926daa1a4f
extra : amend_source : 672d462c003914dac96063b220d39b6d5d124d31
2015-04-03 16:25:22 -04:00
Blake Winton
81acc6ce98
Bug 1137211 - Move the click handler to the document so we can click on the margins. ui-r=phlsa, r=margaret, r=jaws
2015-04-01 16:40:08 -04:00
Margaret Leibovic
709ab91d5d
No bug, update Readability to github tip, rs=me
2015-04-03 11:08:25 -04:00
Gijs Kruitbosch
352a7c0220
No bug, update Readability and JSDOMParser to github tip, rs=me
...
--HG--
extra : rebase_source : dbfc50e5de39ea8ac7190d48af10121a91d77411
2015-04-02 21:48:31 +01:00
Gijs Kruitbosch
55aa47af9f
Bug 1147487 - don't try to reader-ize non-HTML documents, r=margaret,jaws
...
--HG--
extra : rebase_source : 107eb010f3c7967e038b7a0b4895425e4e3e7312
2015-04-01 13:40:25 +01:00
Mark Hammond
8ad4b52081
Bug 1149859 - readermode now considers paragraphs with 100 chars acceptable instead of 200. r=margaret
2015-04-02 14:56:19 +11:00
Blake Winton
98b195606c
Bug 1145809
- Add the reading mode footer. ui-r=mmaslaney, r=Unfocused
2015-03-30 12:50:01 -04:00
Margaret Leibovic
08e224dd1b
Bug 1147597 r=gavin
...
--HG--
extra : rebase_source : c3551470f3b57f4fc33ef2d6391d3de4d22c3aee
2015-03-30 13:27:29 -04:00
Mark Capella
8564c33801
Bug 1134446 - Automatically open the ReadingList sidebar the first time ReaderMode is used, r=unfocused
2015-03-29 08:35:23 -04:00
Blake Winton
c329e40afb
Bug 1147889 - Transition background and text color in Reading Mode. ui-r=mmaslaney, r=Unfocused
...
--HG--
extra : rebase_source : 62c80f66ad03d14fd0ec126182bd3809a87633c4
2015-03-28 22:10:54 -07:00
Margaret Leibovic
cef3c3aa64
Bug 1146373 - Don't resize reader view images in JS. r=Gijs
...
--HG--
extra : rebase_source : d7b428fb57beeebbbb27369a1fe04ea8d7fd62eb
2015-03-23 16:55:26 -07:00
Margaret Leibovic
2004dde9a1
Bug 1147122 - Restore reader view error message if about:reader fails when user clicks reader button. r=Gijs
...
--HG--
extra : rebase_source : 1a4233cc2046285f7303d36c0bde21e19a19636d
2015-03-24 17:30:43 -07:00
Gijs Kruitbosch
332d99565c
Bug 1146666 - fix reader mode button's dealing with history.pushState, r=margaret
...
--HG--
extra : rebase_source : 7e319675091bebc7f48d0683058195cfdecbeabe
2015-03-25 00:33:16 +00:00
Margaret Leibovic
faf2258dd6
No bug: update readability libs to the up-to-date github versions. rs=me+Gijs
...
--HG--
extra : rebase_source : a3fe5635643ee253f82764f8e54409982978703e
2015-03-23 11:29:23 -07:00
Gijs Kruitbosch
82c7c6de1e
No bug: update readability libs to the up-to-date github versions to include significant perf and quality improvements, rs=me
...
--HG--
extra : rebase_source : 464cf93b5110cc456454bab0b698bc10d32bea49
2015-03-20 20:50:45 -07:00
Gijs Kruitbosch
24111fd7bd
Backed out changeset 8a292af9c827 for android robocop orange
2015-03-20 22:47:21 -07:00
Gijs Kruitbosch
f2a65002f0
No bug: update readability libs to the up-to-date github versions to include significant perf and quality improvements, rs=me
...
--HG--
extra : rebase_source : 4d6afe3274ee52434b97bb5021a2d297ed86a30e
2015-03-20 20:50:45 -07:00
Margaret Leibovic
c0ede94dd6
Bug 1143844 - Check document for readerable content to determine whether or not to show reader button. r=Gijs
...
--HG--
extra : rebase_source : 7a849952243aa5ff8d4711a1f0308747558faa2f
2015-03-18 13:42:52 -07:00
Margaret Leibovic
c6a82ac4da
backout 1dbf52164ffe for bc1 failures on a CLOSED TREE
...
--HG--
extra : amend_source : 5f9977341e412cb0de22dfc099430aae516bc21e
2015-03-19 12:23:28 -07:00
Margaret Leibovic
b05f8534af
Bug 1143844 - Check document for readerable content to determine whether or not to show reader button. r=Gijs
...
--HG--
extra : rebase_source : bb719f59ab850517449e08cb3f86c06ff727692d
2015-03-18 13:42:52 -07:00
Carsten "Tomcat" Book
3c57b5be0b
merge mozilla-inbound to mozilla-central a=merge
2015-03-18 13:51:53 +01:00
Jesse Ruderman
54ce7cf07e
Bug 1144351 - Add newline at the end of 'JSDOMParser error' messages. r=mfinkle
2015-03-17 21:06:06 -07:00
Gijs Kruitbosch
eb35e37139
No bug, update Readability.js to the version in github, rs=margaret,me per discussion earlier today
...
--HG--
extra : amend_source : bf0d161d34ef298b3338ae4b1ec9469817132504
2015-03-17 20:58:58 -07:00
Margaret Leibovic
b4bc567f0e
Bug 1139678 - (Part 3) Don't try interacting with the window in AboutReader if it has been unloaded. r=Gijs
...
--HG--
extra : rebase_source : f49a9f306bf4544573eb18c0bcd38b23a22b3ce6
2015-03-17 14:41:28 -07:00
Margaret Leibovic
5327d3c2ae
Bug 1139678 - Don't do reader parse until user clicks on reader button. r=bnicholson
...
--HG--
extra : rebase_source : 98f768841b9a858c9d8bce53cb9dc6770796c2ea
2015-03-12 20:06:37 -07:00
Nicholas Nethercote
923f0cf761
Bug 1143508 (part 2) - Optimize pair returning from makeNodeElement() in JSDOMParser. r=bnicholson.
...
In one workload this avoids allocating 2.3 MB of short-lived arrays.
--HG--
extra : rebase_source : 58e12863e5ac047e165094b5b9906e308cd59e32
2015-03-16 15:13:16 -07:00
Nicholas Nethercote
67a9132228
Bug 1143508 (part 1) - Optimize tag name scanning in JSDOMParser. r=bnicholson.
...
On one workload I saw this reduce the cumulative allocations done for strings
drop from 2.3 MB to 0.9 MB.
--HG--
extra : rebase_source : 631cb179722c389c9127a5a9b4692581774f0935
2015-03-16 15:13:14 -07:00
Wes Kocher
4a1d74cfc0
Backed out changeset 2693283b5d8b (bug 1142814) for bc1 orange
2015-03-16 17:45:45 -07:00
Nicholas Nethercote
b6b27f0a2a
Bug 1142814 - Optimize String.fromCharCode() when the number of args is small but > 1. r=jandem.
...
This avoids an unnecessary malloc.
The patch also adds testing for String.fromCharCode() with 2--20 args.
--HG--
extra : rebase_source : 4f56b15053914ebf6c94518047abbd5955482c1e
2015-03-12 17:19:48 -07:00
Sebastian Hengst
394a2dd441
Bug 1143470 - Add BUG_COMPONENT to moz.build files in toolkit and xulrunner. r=gavin
2015-03-15 19:36:24 +01:00
Margaret Leibovic
39d8969088
Bug 998031 - Reader Mode toolbar should scroll in and out instead of fading. r=bnicholson
...
--HG--
extra : rebase_source : f5021a6e3f36cb8d8e1e380ed1763361bad95489
extra : amend_source : 2304c25e5570f0e1f505b0778ac1873e9b86dd8c
2015-03-05 11:23:27 -08:00
Margaret Leibovic
627343c909
Bug 1141757 - Catch exceptions thrown in ReaderWorker. r=Yoric
...
--HG--
extra : rebase_source : fa7f40ee78042c9ac9694d9912071bfc26c46304
2015-03-11 08:39:54 -07:00
Margaret Leibovic
b356b72ed3
Bug 1141618 - Disable reader worker logging by default. r=Mossop
2015-03-10 13:01:10 -07:00
Margaret Leibovic
bfda3f109f
Bug 1141317 - Account for new #container div in about:reader CSS. r=bnicholson
...
--HG--
extra : rebase_source : 45bcbdc1a9c2a3371b89c5cd17cf6183e939e40a
2015-03-09 19:15:39 -07:00
Margaret Leibovic
676b28dd15
Bug 1140172 - Use a single reader worker instead of spawning infinite workers. r=bnicholson f=Yoric
...
--HG--
rename : toolkit/components/reader/content/JSDOMParser.js => toolkit/components/reader/JSDOMParser.js
rename : toolkit/components/reader/content/Readability.js => toolkit/components/reader/Readability.js
rename : toolkit/components/reader/content/readerWorker.js => toolkit/components/reader/ReaderWorker.js
extra : rebase_source : b4fdefa5ae522b57d001bbb7087352807f4f6cb6
2015-03-05 17:31:05 -08:00
Margaret Leibovic
22c88554a0
Bug 1120004 - Update styles of Reader View controls on mobile. r=bnicholson
...
--HG--
extra : rebase_source : b50005d5f99151a0ea9d6c2b022791198db8b846
2015-02-27 16:52:03 -08:00
Margaret Leibovic
83e3f73fce
Bug 1128757 - Do not trim fragments from URLs loaded in reader view. r=bnicholson
...
--HG--
extra : rebase_source : 95965e5fba02193d5bbb94e5427f7d939547b01a
2015-02-26 14:08:29 -08:00
Margaret Leibovic
f336a1e08a
Bug 1124011 - Hide reader view buttons related to reading list if reading list is disabled, and enable reader view by default on Nightly. r=Unfocused
...
--HG--
extra : rebase_source : 2647d467ac309dc8c4a35522768c4756a288180e
2015-02-19 11:47:20 -08:00
Mark Capella
4acb3731d8
Bug 1133489 - Hook up "Open ReadingList" button in desktop ReaderMode, r=unfocused
2015-02-27 14:31:31 -05:00
Margaret Leibovic
b1c8846285
Bug 1134441 - Replace font size controls with +/- buttons. r=bnicholson
...
--HG--
extra : rebase_source : 0251d53ec2ecef1506ce985414f814f9f582c974
2015-02-24 17:15:03 -08:00
Margaret Leibovic
ca71b41209
Bug 1136231 - Unify Reader View type options to be Sans-Serif on Left, Serif on Right. r=bnicholson
...
--HG--
extra : rebase_source : 272bf154f6ccb17cac511001aa3947588f2334a8
2015-02-24 09:53:48 -08:00
Boris Kudryavtsev
5a434a5a09
Bug 1135364 - Close <meta> tag in aboutReader.html. r=bnicholson
...
--HG--
extra : rebase_source : acf250cf95897931d71a543dcb43ee535814f4cd
extra : histedit_source : f08133774f5a94874c475fb78c66978feac907a4
2015-02-23 20:41:00 -08:00
Margaret Leibovic
796341ee9f
Bug 1134443 - Update Readability.js from shared library on github. r=bnicholson
...
--HG--
extra : rebase_source : ae98587574357345b188cc48b6bfecd78bb26612
extra : histedit_source : dc684a44e421b42ac959a0113613c801d5cf185d
2015-02-22 16:18:16 -08:00
Phil Ringnalda
e3c03410ef
Back out 66cf24f275b7 (bug 1124011) for frequent ASan crashes in test_memoryReporters.xul
2015-02-22 22:00:56 -08:00
Margaret Leibovic
f752a5a22d
Bug 1124011 - Hide reader view buttons related to reading list if reading list is disabled, and enable reader view by default on Nightly. r=Unfocused
...
--HG--
extra : rebase_source : 53ebca45c92bb811b9ffa2e9faa33983c3dd1181
extra : histedit_source : c6cbbdccb6e057f0f06501ff517bad5ff687532e
2015-02-19 11:47:20 -08:00
Abdelrhman Ahmed
7e4b81d7e2
Bug 1132925 - Pass messages to the parent process to set reader mode prefs. r=margaret
2015-02-20 15:56:00 -05:00
Margaret Leibovic
7cdbc04b44
backout a9139003abaf for busting mobile
2015-02-20 14:06:56 -08:00
Abdelrhman Ahmed
cf5e451b64
Bug 1132925 - Pass messages to the parent process to set reader mode prefs. r=margaret
2015-02-20 14:00:12 -08:00
Margaret Leibovic
94cb523c5c
Bug 1135234 - Use "serif" and "sans-serif" in reader mode controls to match desktop. r=bnicholson
...
--HG--
extra : rebase_source : 2133c4d475ea326f5fe8115e1b8a08723f5af092
extra : amend_source : 0504d868a9554d9aa07d913d52210ca020d49d4b
2015-02-20 13:27:09 -08:00
Margaret Leibovic
79579aae38
Bug 1131303 - Update strings for reader view/reading list UI, and add title text to reader view toolbar buttons. r=Unfocused,rnewman
...
--HG--
extra : rebase_source : 42a40f76da543930c9f08373fb0836774a1c5290
2015-02-12 09:15:45 -08:00
Margaret Leibovic
8ea7eb86e6
Bug 1132307 - Use <button> elements instead of <a> elements in reader mode toolbar. r=bnicholson
...
--HG--
extra : rebase_source : 960931ca6b2a23aaa98fc93c46b1cb96a68c8b0e
2015-02-13 14:09:44 -08:00
Margaret Leibovic
f013fe48c4
Bug 1132547
- Move reader.has_used_toolbar logic to Android's Reader.js. r=bnicholson
...
--HG--
extra : rebase_source : 6c3e57259a0dc4a70222fa2fdf4aa1c5b823f93c
2015-02-12 15:23:26 -08:00
Fabrice Desré
032708d8ab
Bug 1132844 - Fix ReaderMode.jsm to work with jsloader.reuseGlobal r=margaret
2015-02-13 15:13:40 -08:00
Margaret Leibovic
f63aff6e67
Bug 1120735 - Implement desktop reader mode controls. r=jaws,bnicholson
...
--HG--
extra : rebase_source : 931f6bd5497ca84fa54eb0f8365acf940a7cd86f
2015-01-21 17:21:11 -08:00
Margaret Leibovic
0be0977efe
Bug 907079 - Simplify reader mode style popup logic, including removing the use of the window.history API. r=mfinkle
...
--HG--
extra : rebase_source : 8466fd81f0a55c0ea7cf608622f6805741c21a3a
2015-01-28 17:43:07 +01:00
Mark Capella
4788e40421
Bug 1081742 - Reader mode doesn't support RTL, r=bnicholson
2015-02-03 21:49:38 -05:00
Margaret Leibovic
e6495a8e8a
Bug 1117258 - Implement reader mode content CSS for desktop. r=jaws
2015-01-26 10:19:47 +01:00
Margaret Leibovic
d2c02d2fcc
Bug 795981 - (Part 1) Hook up reader mode for desktop. r=jaws
...
--HG--
extra : rebase_source : d2ecf5b2079f6bdbfc2ccfe6149a86075293967f
2014-12-30 10:44:34 -05:00
Margaret Leibovic
a9c456e1d0
Bug 1111142 - (Part 3) Replace fennec-specific logic in AboutReader.jsm with messages. r=mfinkle,bnicholson
...
--HG--
extra : rebase_source : 869c7e58be536c8aa385e3e0ab5aed334fcc7d80
2014-12-23 10:10:34 -05:00
Margaret Leibovic
2d7e538a56
Bug 1111142 - (Part 2) Load AboutReader in a frame script on Fennec. r=mfinkle,bnicholson
...
--HG--
extra : rebase_source : 4fa6fa81125f0e5f6f39f8de5a1e1ce3f2365e0d
2014-12-23 15:32:15 -05:00
Margaret Leibovic
333c5ba82b
Bug 1111142 - (Part 1) Turn aboutReader.js into an AboutReader module. r=mfinkle,bnicholson
...
--HG--
rename : toolkit/components/reader/content/aboutReader.js => toolkit/components/reader/AboutReader.jsm
extra : rebase_source : 71b5f80bc1db7378721c5a433f2b8e20bd5169c5
2014-12-19 13:51:24 -08:00
Phil Ringnalda
29a03dfb07
Back out 3 changesets (bug 1111142) for having a startling perf impact
...
CLOSED TREE
Backed out changeset 9b62d0e8b412 (bug 1111142)
Backed out changeset e66b9aa4b22c (bug 1111142)
Backed out changeset 6b480b80299a (bug 1111142)
--HG--
rename : toolkit/components/reader/AboutReader.jsm => toolkit/components/reader/content/aboutReader.js
2015-01-02 22:34:15 -08:00
Margaret Leibovic
a08c6530c5
Bug 1111142 - (Part 3) Replace fennec-specific logic in AboutReader.jsm with messages. r=mfinkle,bnicholson
...
--HG--
extra : rebase_source : 1158189d7fd82bd293fa590569f013a92499dbfc
2014-12-23 10:10:34 -05:00
Margaret Leibovic
cbf1d77ac3
Bug 1111142 - (Part 2) Load AboutReader in a frame script on Fennec. r=mfinkle,bnicholson
...
--HG--
extra : rebase_source : 18bd3f75e7ab32a7a29e3c11708db55d8dffc124
2014-12-23 15:32:15 -05:00
Margaret Leibovic
7bc6c6fb9c
Bug 1111142 - (Part 1) Turn aboutReader.js into an AboutReader module. r=mfinkle,bnicholson
...
--HG--
rename : toolkit/components/reader/content/aboutReader.js => toolkit/components/reader/AboutReader.jsm
extra : rebase_source : 3dad2e92d4dcc8c4f8df32d2b2b6321b7f874a7d
2014-12-19 13:51:24 -08:00
Margaret Leibovic
6c0d9cdf77
Bug 1116231 - Move reader.parse-on-load. pref change observer back to Reader.js. r=bnicholson
...
--HG--
extra : rebase_source : bfd297fd0af91bbfce62c22db0ca7a958ab4430f
2014-12-29 15:12:45 -05:00
Margaret Leibovic
ea0dadcc9d
Bug 1107588 - Use an xhr to download reader mode content instead of creating new browser elements. r=mfinkle
...
--HG--
extra : rebase_source : fe24bfefa2efc5500ca74a9be5f79a958bab32ee
2014-12-30 14:56:09 -05:00
Margaret Leibovic
c4d427c2d6
Bug 1093172 - Add status when adding reading list item from Reader.js. r=rnewman
2014-12-08 10:44:26 -08:00
Ryan VanderMeulen
4415636429
Backed out 3 changesets (bug 1093172) for robocop failures.
...
Backed out changeset 8d1c3083f7e6 (bug 1093172)
Backed out changeset 4fa27d0105df (bug 1093172)
Backed out changeset c85c0a37dcb9 (bug 1093172)
2014-12-19 23:51:18 -05:00
Margaret Leibovic
7073e68a97
Bug 1093172 - Add status when adding reading list item from Reader.js. r=rnewman
...
--HG--
extra : rebase_source : ab1793ee80415c6e09028c757acd43d31426c2d4
2014-12-08 10:44:26 -08:00
Margaret Leibovic
3e44c28a99
Bug 1112960 - Remove empty extra ReaderMode.jsm file. r=oops DONTBUILD
...
--HG--
extra : rebase_source : f259e86fa5a8f9ea51297de625dd388a9ef437f8
2014-12-17 18:13:06 -08:00
Margaret Leibovic
3dbb00ba33
Bug 793920 - (Part 2) Split up Reader.js to create shared ReaderMode.jsm in /toolkit. r=bnicholson
...
--HG--
rename : mobile/android/chrome/content/Reader.js => toolkit/components/reader/ReaderMode.jsm
extra : rebase_source : 5f66c449c50135d53644ebc507357ab560938bc7
extra : histedit_source : 53ad05bc9a30977399627c13f07971d7f7250814
2014-12-12 13:47:07 -08:00
Margaret Leibovic
de5e9c40f7
Bug 793920 - (Part 1) Move majority of Android reader mode code to a shared place in /toolkit. r=Mossop,bnicholson
...
--HG--
rename : mobile/android/chrome/content/JSDOMParser.js => toolkit/components/reader/content/JSDOMParser.js
rename : mobile/android/chrome/content/Readability.js => toolkit/components/reader/content/Readability.js
rename : mobile/android/chrome/content/aboutReader.html => toolkit/components/reader/content/aboutReader.html
rename : mobile/android/chrome/content/aboutReader.js => toolkit/components/reader/content/aboutReader.js
rename : mobile/android/chrome/content/readerWorker.js => toolkit/components/reader/content/readerWorker.js
rename : mobile/android/locales/en-US/chrome/aboutReader.properties => toolkit/locales/en-US/chrome/global/aboutReader.properties
extra : rebase_source : f0b900c46bb5dc894303ddf3701be7b019b61ae0
extra : histedit_source : 7417d0e4032ed3a3b1ab83af8f7e8a92951fdead
2014-12-10 16:44:53 -08:00