Chris Fronk
3b7a1daba2
Bug 1647536 - Support ref counted pointers in nsDeque r=froydnj
...
Adds a new specialization of nsDeque, nsRefPtrDeque for use with
reference counted pointers.
Differential Revision: https://phabricator.services.mozilla.com/D84766
2020-08-22 15:47:59 +00:00
Mihai Alexandru Michis
fb644eda26
Backed out changeset 5838f8b581ed (bug 1647536) for causing failures in browser_active_mediasession_among_tabs.js
...
CLOSED TREE
2020-08-14 19:42:51 +03:00
Chris Fronk
8770c8a332
Bug 1647536 - Support ref counted pointers in nsDeque r=froydnj
...
Adds a new specialization of nsDeque, nsRefPtrDeque for use with
reference counted pointers.
Differential Revision: https://phabricator.services.mozilla.com/D84766
2020-08-14 15:19:48 +00:00
Emilio Cobos Álvarez
ff61891772
Bug 1653011 - Simplify and make WeakPtr<Derived> usable and compact. r=froydnj,sg,geckoview-reviewers,jgilbert,kvark,snorp
...
Having two classes in the inheritance chain inherit from SupportsWeakPtr
now won't compile, but you can use WeakPtr<Derived> when any base class
inherits from SupportsWeakPtr.
Differential Revision: https://phabricator.services.mozilla.com/D83674
2020-07-23 14:51:46 +00:00
Simon Giesecke
cd8b8939b9
Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Chris Fronk
6f84249b41
Bug 1337953 - Make nsDeque templated on pointer type r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D79629
2020-06-25 02:39:23 +00:00
Butkovits Atila
7916df7f02
Backed out changeset 5614bcd268d1 (bug 1337953) for bustage at FuzzyLayer.cpp. CLOSED TREE
2020-06-23 11:01:37 +03:00
Jean-Yves Avenard
4f53bc5dc3
Bug 1647133 - P3. Use nsISerialEventTarget where it's actually that. r=valentin
...
All uses are always the main thread and its derivative (obtained via EventTargetFor method) or nullptr.
Depends on D80421
Differential Revision: https://phabricator.services.mozilla.com/D80422
2020-06-22 11:13:24 +00:00
Chris Fronk
cea9cef934
Bug 1337953 - Make nsDeque templated on pointer type r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D79629
2020-06-23 00:58:13 +00:00
Byron Campen [:bwc]
fa6e7a3c25
Bug 1645219: Repurpose DataChannelShutdown into DataChannelRegistry (which gives us some weak-pointer-like semantics) r=ng
...
Differential Revision: https://phabricator.services.mozilla.com/D79375
2020-06-18 16:27:31 +00:00
Mihai Alexandru Michis
dd5e04a92b
Backed out changeset cc9bea1151d3 (bug 1645219) for causing failures in netinet/sctp_usrreq.c
...
CLOSED TREE
2020-06-18 05:07:54 +03:00
Byron Campen [:bwc]
f0925b9486
Bug 1645219: Repurpose DataChannelShutdown into DataChannelRegistry (which gives us some weak-pointer-like semantics) r=ng
...
Differential Revision: https://phabricator.services.mozilla.com/D79375
2020-06-16 00:17:10 +00:00
Simon Giesecke
13502cf27c
Bug 1642991 - Use RemoveElementsBy where easily possible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D78055
2020-06-08 09:01:48 +00:00
Nico Grunbaum
46b83b6604
Bug 1218356 - P2 - Implement the RTCDataChannel stats;r=dminor
...
Note that transportId is not implemented and is not a stat but a key back into
the stats report. It identifies the related transport stats object. We don't
have transport stats, so this can not be implemented at the moment.
Differential Revision: https://phabricator.services.mozilla.com/D57116
2020-05-29 10:46:42 +00:00
Simon Giesecke
792ed4cd28
Bug 1626570 - Improve handling of copying arrays in netwerk/sctp/datachannel/. r=drno
...
Differential Revision: https://phabricator.services.mozilla.com/D73638
2020-05-05 13:00:58 +00:00
Nils Ohlmeier [:drno]
fd51c326b1
Bug 1632241: turn off SCTP auth and address reconfiguration r=ng
...
Depends on D72053
Differential Revision: https://phabricator.services.mozilla.com/D72057
2020-04-23 04:33:57 +00:00
Chris Peterson
9db7016a65
Bug 1630511 - Replace MOZ_MUST_USE with [[nodiscard]] in netwerk. r=necko-reviewers,dragana
...
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
Differential Revision: https://phabricator.services.mozilla.com/D71144
2020-04-18 06:37:32 +00:00
Andreas Farre
63e21eec70
Bug 1620594 - Part 1: Rework NS_ReleaseOnMainThreadSystemGroup. r=nika
...
To be able to remove SystemGroup, NS_ReleaseOnMainThreadSystemGroup
needs to have its dependency on SystemGroup removed. Since all
releases using SystemGroup would've released on the main thread anyway
we can safely replace NS_ReleaseOnMainThreadSystemGroup with
NS_ReleaseOnMainThread.
Depends on D64390
Differential Revision: https://phabricator.services.mozilla.com/D67631
--HG--
extra : moz-landing-system : lando
2020-04-07 15:16:23 +00:00
Byron Campen [:bwc]
944d6971a3
Bug 1603887: Drive closing of DataChannels with transport events, not negotiation events. r=ng
...
Differential Revision: https://phabricator.services.mozilla.com/D67946
--HG--
extra : moz-landing-system : lando
2020-03-23 21:52:51 +00:00
Nico Grunbaum
7c9ebecaf3
Bug 1552293 - round up freinds of DataChannel and DataChannelConnection - r=dminor
...
Differential Revision: https://phabricator.services.mozilla.com/D31527
--HG--
extra : moz-landing-system : lando
2020-03-23 20:35:28 +00:00
sonakshi
641f3860b8
Bug 1621589 - Convert pointer to rtcweb_datachannel_open_request to UniqueFreePtr r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D66894
--HG--
extra : moz-landing-system : lando
2020-03-16 15:19:44 +00:00
Boris Zbarsky
00cd5d4380
Bug 1619112 part 5. Stop accepting nsAString in ErrorResult error-throwing. r=smaug
...
Callers should pass in UTF-8, since that's what the JS engine ends up with in the end anyway.
The various URL changes are because NS_NewURI converts incoming nsAString to
UTF-8 anyway. So we might as well do that up-front and then use the UTF-8
string for both the NS_NewURI call and the error-reporting if it fails.
Differential Revision: https://phabricator.services.mozilla.com/D65543
--HG--
extra : moz-landing-system : lando
2020-03-06 21:08:02 +00:00
Eric Rahm
b9ba9be64d
Bug 1322095 - Part 1b: Update callbacks to support moved args and convert nsAutoPtr usage. r=jya
...
In order to support the update to move args when invoking callbacks we:
- Convert anything that was using WrapRunnable with `nsAutoPtr` to `UniquePtr`
- Convert anything that was using a non-const ref as a param to either a
const ref or a by-val copy
Addtionally we convert the remaining `nsAutoPtr` usage to `UniquePtr`.
Differential Revision: https://phabricator.services.mozilla.com/D59961
--HG--
extra : moz-landing-system : lando
2020-02-21 22:43:53 +00:00
Boris Zbarsky
d82355eb35
Bug 1615481. Throw the right exception from DataChannel.send() when the message is too big. r=jib
...
Differential Revision: https://phabricator.services.mozilla.com/D62850
--HG--
extra : moz-landing-system : lando
2020-02-18 20:34:28 +00:00
Emilio Cobos Álvarez
e5463ecf7f
Bug 1614718 - Add two missing includes to unbust thunderbird.
...
Differential Revision: https://phabricator.services.mozilla.com/D62474
--HG--
extra : moz-landing-system : lando
2020-02-11 19:18:45 +00:00
Eric Rahm
2c08316c5d
Bug 1610070 - Part 3: Convert the rest of netwerk/ to use UniquePtr. r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D60341
--HG--
extra : moz-landing-system : lando
2020-02-11 16:20:08 +00:00
Coroiu Cristina
73c0827187
Backed out 2 changesets (bug 1322095) for build bustage at dist/include/mtransport/runnable_utils.h on a CLOSED TREE
...
Backed out changeset 14e115ba7f12 (bug 1322095)
Backed out changeset 078c0fe497b7 (bug 1322095)
2020-01-23 19:50:51 +02:00
Eric Rahm
e120eee6b8
Bug 1322095 - Part 1b: Update callbacks to support moved args and convert nsAutoPtr usage. r=jya
...
In order to support the update to move args when invoking callbacks we:
- Convert anything that was using WrapRunnable with `nsAutoPtr` to `UniquePtr`
- Convert anything that was using a non-const ref as a param to either a
const ref or a by-val copy
Addtionally we convert the remaining `nsAutoPtr` usage to `UniquePtr`.
Differential Revision: https://phabricator.services.mozilla.com/D59961
--HG--
extra : moz-landing-system : lando
2020-01-23 17:38:18 +00:00
Jan-Ivar Bruaroey
85c420c220
Bug 1547106: Throw OperationError in createDataChannel() if id in use. r=bwc
...
Differential Revision: https://phabricator.services.mozilla.com/D60569
--HG--
extra : moz-landing-system : lando
2020-01-22 14:20:26 +00:00
Nico Grunbaum
0374ef3d44
Bug 1586593 - dispatch CloseInt on DataChannel Open ACK failure - r=bwc
...
Differential Revision: https://phabricator.services.mozilla.com/D48938
--HG--
extra : moz-landing-system : lando
2019-10-11 17:03:23 +00:00
Nico Grunbaum
890b535549
Bug 1584751 - Only open DataChannelConnections that aren't already open; r=bwc
...
Differential Revision: https://phabricator.services.mozilla.com/D47691
--HG--
extra : moz-landing-system : lando
2019-10-05 02:48:15 +00:00
Nico Grunbaum
5115905e34
Bug 1584695 - Place DataChannelConnection connection state behind an accessor - r=bwc
...
Differential Revision: https://phabricator.services.mozilla.com/D47690
--HG--
extra : moz-landing-system : lando
2019-10-05 02:48:08 +00:00
Oana Pop Rus
4c353ccfd5
Backed out 2 changesets (bug 1584695, bug 1584751) for Assertion failures at at /builds/worker/workspace/build/src/xpcom/threads/BlockingResourceBase.cpp on a CLOSED TREE
...
Backed out changeset fac79eb65900 (bug 1584751)
Backed out changeset dd5211c4ded2 (bug 1584695)
2019-10-03 11:38:45 +03:00
Nico Grunbaum
a9ee1a3154
Bug 1584751 - Only open DataChannelConnections that aren't already open; r=bwc
...
Differential Revision: https://phabricator.services.mozilla.com/D47691
--HG--
extra : moz-landing-system : lando
2019-10-03 04:56:26 +00:00
Nico Grunbaum
294e97c17a
Bug 1584695 - Place DataChannelConnection connection state behind an accessor - r=bwc
...
Differential Revision: https://phabricator.services.mozilla.com/D47690
--HG--
extra : moz-landing-system : lando
2019-10-03 04:56:18 +00:00
Andy Grover
05e7a5dee3
Bug 1584785 - Fix issues found via PVS-studio static analyzer
...
Differential Revision: https://phabricator.services.mozilla.com/D47559
--HG--
extra : moz-landing-system : lando
2019-09-30 09:35:42 +00:00
Nico Grunbaum
11d7e7febf
Bug 1581023 - Expand DataChannel logging capabilities - r=bwc
...
Differential Revision: https://phabricator.services.mozilla.com/D45800
--HG--
extra : moz-landing-system : lando
2019-09-19 14:50:57 +00:00
Byron Campen [:bwc]
0ef1037a0d
Bug 1553789: Don't connect unless our transport is the one that is ready. r=mjf
...
Differential Revision: https://phabricator.services.mozilla.com/D37898
--HG--
extra : moz-landing-system : lando
2019-07-15 14:10:03 +00:00
Byron Campen [:bwc]
0f9ef24e81
Bug 1562341: Set mNegotiatedIdLimit when the channel opens, and remove some code that was stomping our initially chosen max streams. r=mjf
...
Differential Revision: https://phabricator.services.mozilla.com/D36517
--HG--
extra : moz-landing-system : lando
2019-07-08 16:08:56 +00:00
Byron Campen [:bwc]
568b0afffe
Bug 1556795: Add some thread assertions, and remove an unused member. r=ng
...
Differential Revision: https://phabricator.services.mozilla.com/D35049
--HG--
extra : moz-landing-system : lando
2019-06-20 20:24:02 +00:00
Byron Campen [:bwc]
3ecf23e57c
Bug 1556795: Simplifications related to DataChannel::mFlags. r=ng
...
Differential Revision: https://phabricator.services.mozilla.com/D35048
--HG--
extra : moz-landing-system : lando
2019-06-20 20:24:00 +00:00
Byron Campen [:bwc]
a2d135b8fe
Bug 1556795: Allocate stream ids as soon as client/server is negotiated, and try to negotiate id limit increases after. r=ng
...
Differential Revision: https://phabricator.services.mozilla.com/D35047
--HG--
extra : moz-landing-system : lando
2019-06-20 20:23:57 +00:00
Ciure Andrei
4ffd609e9c
Backed out 4 changesets (bug 1556795)for causing RTCPeerConnection-createDataChannel.html to perma fail CLOSED TREE
...
Backed out changeset 05898e5d5434 (bug 1556795)
Backed out changeset a87072937e2c (bug 1556795)
Backed out changeset f8ce8930bcab (bug 1556795)
Backed out changeset 112937d690e0 (bug 1556795)
2019-06-20 18:33:22 +03:00
Byron Campen [:bwc]
e3a896998c
Bug 1556795: Add some thread assertions, and remove an unused member. r=ng
...
Differential Revision: https://phabricator.services.mozilla.com/D35049
--HG--
extra : moz-landing-system : lando
2019-06-19 18:40:17 +00:00
Byron Campen [:bwc]
2ae75bd3ee
Bug 1556795: Simplifications related to DataChannel::mFlags. r=ng
...
Differential Revision: https://phabricator.services.mozilla.com/D35048
--HG--
extra : moz-landing-system : lando
2019-06-19 18:40:05 +00:00
Byron Campen [:bwc]
806b266db5
Bug 1556795: Allocate stream ids as soon as client/server is negotiated, and try to negotiate id limit increases after. r=ng
...
Differential Revision: https://phabricator.services.mozilla.com/D35047
--HG--
extra : moz-landing-system : lando
2019-06-19 20:46:19 +00:00
Byron Campen [:bwc]
d3597b0e64
Bug 1381136: Stop sending with PPID fragmentation. r=ng
...
Differential Revision: https://phabricator.services.mozilla.com/D34393
--HG--
extra : moz-landing-system : lando
2019-06-11 19:44:02 +00:00
Byron Campen [:bwc]
2d6cf50175
Bug 1551589: readyState fixes r=ng
...
Depends on D31085
Differential Revision: https://phabricator.services.mozilla.com/D31123
--HG--
extra : moz-landing-system : lando
2019-05-29 21:27:18 +00:00
Mihai Alexandru Michis
4916ef8c09
Merge mozilla-central to autoland. CLOSED TREE
2019-05-17 12:36:07 +03:00
Nico Grunbaum
07d183b29f
Bug 1551702 - hide DataChannelConnection ctor, and set local port - r=bwc
...
Differential Revision: https://phabricator.services.mozilla.com/D31343
--HG--
extra : moz-landing-system : lando
2019-05-16 18:43:13 +00:00