* Update green color used for success
* Fix actions menulist alignment
* Make various elements use new accent colors
* Fix lack of border on HTML checkboxes
* Update various colors to proton colors
* Update input border-radius to 2px
* Update border colors
Differential Revision: https://phabricator.services.mozilla.com/D110033
Still use a shouldCloseClient flag, but instead of closing the client from the target's destruction,
from which we should ignore cross process target switching,
we now close it from the descriptor destruction.
Descriptor destruction should only happen when the toolbox is meant to be closed.
Differential Revision: https://phabricator.services.mozilla.com/D106835
- implement the new "inspected-window" command
- move WebExtensionInspectedWindowFront implement to the command, making the front empty
- migrate tests to use the commands instead of front
- stop maintaining the current top level target in ExtensionParent.jsm, no longer have to use watchTargets
- stop creating a new descriptor on each new target
- instead only pull one new dedicated "commands" for WebExt (still in ExtensionParent.jsm)
- remove TabDescriptor isDevToolsExtensionContext as we no longer need anything special in the descriptor
- remove now unused methods on DevToolsShims (createWebExtensionInspectedWindowFront, createDescriptorForTabForWebExtension)
- remove the now unused TabDescriptorFactory.createDescriptorForTab's "forceCreationForWebextension" option, as CommandsFactory.forTab always instantiate a brand new commands
- migrate webext to use the command instead of front
Differential Revision: https://phabricator.services.mozilla.com/D108994
Depends on D110368
Both the flag and the event are not used.
The only thing which matters from the framework perspective is to wait for panel.open to resolve.
Differential Revision: https://phabricator.services.mozilla.com/D110369
Move the methods of the targetCommand that were related to targetConfiguration
to a dedicated command.
We also move the custom TargetConfigurationFront methods into the command.
Callsites are modified to use the new command. Doing so for the debugger involved
a bit more work as we needed to pass the command to the existing `setupCommands`
bootstrap function.
Differential Revision: https://phabricator.services.mozilla.com/D110200
Those tests were ignored by a rule in the jest config,
and they're not providing a good coverage anyway as
they're relying on mocks.
We definitely have a better coverage in existing mochitests,
so let's remove those 2 tests.
We take this opportunity to remove a non-existing path
from the jest config.
Differential Revision: https://phabricator.services.mozilla.com/D110217
After applying D102448,
uriloader/exthandler/tests/mochitest/test_nullCharFile.xhtml starts to fail.
The reason is that it adds image sniffer into net-content-sniffers which is not
expected.
Such that, this patch
- adds two other sniffers category:
- orb-content-sniffers
- The sniffers that are needed in ORB.
- net-and-orb-content-sniffers
- The sniffers that are in either orb-content-sniffers or net-content-sniffers.
- changes the way to ensure we only use the sniffers in the
requested category.
Differential Revision: https://phabricator.services.mozilla.com/D107207
So far, we had rendered all of the animation graphs amenably.
Thus, since it took time if the number of animations is huge, it had affected the performance.
This bug was caused by that reason.
In order to resolve it, we make it restrict to render graphs that are out of the displaying area.
Differential Revision: https://phabricator.services.mozilla.com/D109845
Since RDM spawn a new browsing context target, closing it
was restoring the taret configuration, which meant disabling
any color-scheme simulation that might have been enabled.
This patch introduces a flag that is set when the color scheme
simulation is set, and that will be checked before disabling
it when the target is destroyed.
This way, the simulation is only disabled when the actual target
that was used to set it is destroyed (i.e. the toolbox target).
A test is added to check that the original issue with RDM is resolved.
Differential Revision: https://phabricator.services.mozilla.com/D109906
This adds a resource for the cookie storage type, that supports inspecting iframes, etc. on Fission.
NOTE: in order to use this new resource, set the `devtools.testing.enableServerWatcherSupport` to `true`
Differential Revision: https://phabricator.services.mozilla.com/D108040
This is the only highlighter-ruler test which modifies the size of the window via toolbox dock mode change.
There are a couple of issues:
We assume that the highlighter will be updated when we ask for its new content but we are not waiting on any event.
We also assume that the window size can be measured immediately after changing the docking mode.
Addressing the first issue by using asyncWaitUntil already reduces the failure rate significantly.
To address the second issue I am just adding a small delay before measuring the window dimension.
We could probably get a more in-depths fix and try to wait for rendering/paint/etc... I don't think it's worth the effort in the scope of this intermittent
Differential Revision: https://phabricator.services.mozilla.com/D109700
This patch dose a few things:
- close the tab we open in the test
- move the setTimeout we were doing in a content task from the test
to the function we are calling directly (this test is the only consumer
of this function)
- cleanup the created content worker at the end of the test
Differential Revision: https://phabricator.services.mozilla.com/D108968
The test seems to run a bit long sometimes, so let's request a longer one.
Also, don't call store.dispatch in dispatchMessagesClear if store is null (store
is nullified when the console gets destroyed).
Differential Revision: https://phabricator.services.mozilla.com/D108967
This adds a resource for the cookie storage type, that supports inspecting iframes, etc. on Fission.
NOTE: in order to use this new resource, set the `devtools.testing.enableServerWatcherSupport` to `true`
Differential Revision: https://phabricator.services.mozilla.com/D108040
The test failure doesn't seem to have anything to do with Fission,
but this might have introduce some changes in timings that would
trigger a race condition somehow.
The test was failing because in one of the test we were moving a slider
to change a color, while the slider element had a height of 0, which
would interfere with the computations that are done later.
This patch adds a helper function to create the Spectrum widget, wait for the
slider to have a non-zero height and then calling `show` (where some dimensions
are being cached).
Differential Revision: https://phabricator.services.mozilla.com/D109876
Enabling the support for stylesheet resources highlighted some issue with the
current situation.
A couple server tests needed to instantiate a resource watcher to pass.
We also add a test case for link from inspector to stylesheet when doing a same
process navigation (we already had one for target switching).
Differential Revision: https://phabricator.services.mozilla.com/D106081
With the previous patches in this queue, it looks like the
timing is stlightly modified, and on initial load we can
reveive stylesheet resources _before_ the intial dom-loading
event.
Since we're using dom-loading to clear the UI, we might destroy
stylesheets that we shouldn't.
We fix that in 2 folds:
- clear the UI in onTargetAvailable, which we do receive before any resources
- add a flag to the `dom-loading` resource when we're already going to be triggering
onTargetAvailable for a given interaction (toolbox opening, cross-process
navigation or any navigation when target will follow the global lifecycle).
Differential Revision: https://phabricator.services.mozilla.com/D109471
This was previously done in the inspector panel initialization phase, after the
inspector front was created, which could lead to races.
Since the pageStyle actor requires stylesheets to being watched (when watcher
support is enabled), we do this in the inspector front, before creating the
page style actor.
We put the resourceWatcher instance on targetFront from resourceWatcher#_onTargetAvailable
so we can use it from everywhere.
Differential Revision: https://phabricator.services.mozilla.com/D109470
Tim Nguyen
Mark Banner
Kajal Sah
Nicolas Chevobbe
Julian Descottes
Alexandre Poirot
Morgan Reschenberg
wartmanm
Tom Tung
Daisuke Akatsuka
Belén Albeza
Butkovits Atila