20a9b720d4
Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv
...
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.
Differential Revision: https://phabricator.services.mozilla.com/D90873
2020-10-02 13:23:49 +00:00
23a4305389
Bug 1668548 - Only pass the error value to a cleanup function with QM_TRY*. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D92067
2020-10-02 10:04:37 +00:00
6d35002b92
Bug 1668539 - Do not prevent RVO with QM_TRY_RETURN. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D92061
2020-10-02 10:03:29 +00:00
ae5e3a0d7c
Backed out 5 changesets (bug 1666219, bug 1665347) for crashing hazard task. CLOSED TREE.
...
Backed out changeset c261ec06a826 (bug 1665347)
Backed out changeset 212c9df41410 (bug 1665347)
Backed out changeset 435f02d9f1d7 (bug 1665347)
Backed out changeset 7b36a79247b7 (bug 1666219)
Backed out changeset af8025162523 (bug 1665347)
2020-10-01 23:17:19 +02:00
8598a731fc
Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv
...
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.
Differential Revision: https://phabricator.services.mozilla.com/D90873
2020-10-01 15:37:50 +00:00
104db9798f
Backed out 5 changesets (bug 1666219, bug 1665347) for indexedDB related bustage CLOSED TREE
...
Backed out changeset 5cd7e2d67f91 (bug 1665347)
Backed out changeset 9159fdd05097 (bug 1665347)
Backed out changeset 64a086636738 (bug 1665347)
Backed out changeset 5ef18af381ec (bug 1666219)
Backed out changeset 3b81349a5f39 (bug 1665347)
2020-10-01 17:41:23 +03:00
4c5b983d6f
Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv
...
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.
Differential Revision: https://phabricator.services.mozilla.com/D90873
2020-10-01 12:02:26 +00:00
67084ddd9b
Bug 1666216 - Enable ScopedLogExtraInfo logging. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D90877
2020-09-30 08:24:18 +00:00
c711008a61
Bug 1666219 - Introduce QM_TRY_INSPECT to avoid unwrapping Result objects where not necessary. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D90843
2020-09-29 10:57:14 +00:00
de7bab0f06
Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D82325
2020-09-23 15:17:15 +00:00
45dd2a39a3
Bug 1665890 - Use QM_TRY_RETURN where possible; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D90679
2020-09-22 14:21:52 +00:00
eaa00050e4
Bug 1665850 - Switch JS to use non-reference errors with mozilla::Result. r=jandem
...
Also switch optimizations for HasFreeLSB and existing tests to no longer
use references.
Differential Revision: https://phabricator.services.mozilla.com/D90661
2020-09-21 13:14:10 +00:00
2e065c64d6
Bug 1665614 - Make mozilla::Result work with non-copyable/non-param error types. r=emilio,jandem
...
Among other things, there were some misuses of std::forward, and
GenericErrorResult was (presumably accidentally) instatiated with
references as the template argument type, e.g. const nsresult&,
which circumvented the check for not calling it with NS_OK in
ResultExtensions.h
Differential Revision: https://phabricator.services.mozilla.com/D90561
2020-09-21 13:12:48 +00:00
270e7e2200
Backed out 5 changesets (bug 1665927, bug 1665614, bug 1665850) for causing bustage on Result.h. CLOSED TREE
...
Backed out changeset 1467e76399e8 (bug 1665927
2020-09-21 15:25:16 +03:00
70bda1ef61
Bug 1665850 - Switch JS to use non-reference errors with mozilla::Result. r=jandem
...
Also switch optimizations for HasFreeLSB and existing tests to no longer
use references.
Differential Revision: https://phabricator.services.mozilla.com/D90661
2020-09-21 11:11:02 +00:00
3b0420646e
Bug 1665614 - Make mozilla::Result work with non-copyable/non-param error types. r=emilio,jandem
...
Among other things, there were some misuses of std::forward, and
GenericErrorResult was (presumably accidentally) instatiated with
references as the template argument type, e.g. const nsresult&,
which circumvented the check for not calling it with NS_OK in
ResultExtensions.h
Differential Revision: https://phabricator.services.mozilla.com/D90561
2020-09-21 10:38:19 +00:00
f05dba1711
Bug 1663924 - Add ScopedLogExtraInfo. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D90112
2020-09-21 10:32:55 +00:00
f01767bb45
Bug 1665083 - QM_TRY (without _VAR) should fail to compile when the success type is not empty. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D90274
2020-09-18 14:51:54 +00:00
2306d2079a
Backed out 11 changesets (bug 1663924, bug 1664844) for multiple failures. CLOSED TREE
...
Backed out changeset 2da9fde7a109 (bug 1663924)
Backed out changeset 9353759cc783 (bug 1663924)
Backed out changeset 309354891d60 (bug 1663924)
Backed out changeset 4e51461c369c (bug 1663924)
Backed out changeset e3196b68932c (bug 1663924)
Backed out changeset 25b16cbae152 (bug 1664844)
Backed out changeset e02961ac5ee7 (bug 1663924)
Backed out changeset dde2058c20ef (bug 1663924)
Backed out changeset a80f52551e3a (bug 1663924)
Backed out changeset 0c37ce712c2c (bug 1663924)
Backed out changeset 8cc5dcc86f40 (bug 1663924)
2020-09-18 04:52:32 +03:00
f0debef582
Bug 1663565 - Introduce QM_TRY_RETURN/QM_TRY_DEBUG_RETURN macros and quota client specific equivalents; r=dom-workers-and-storage-reviewers,sg,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D89413
2020-09-17 14:01:01 +00:00
8993cde73d
Bug 1665565 - Replace ToResultInvoke with MOZ_TO_RESULT_INVOKE_TYPED; r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D90523
2020-09-17 13:17:58 +00:00
ecd6a4b573
Bug 1664770 - Use QM_TRY* for upgrade classes' base classes; r=dom-workers-and-storage-reviewers,janv,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D90120
2020-09-17 12:55:21 +00:00
b17fa7a272
Bug 1664770 - Use QM_TRY* for metadata related functions; r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D90119
2020-09-17 08:09:01 +00:00
c606d3c776
Bug 1664770 - Use QM_TRY* for GetBinaryInputStream and GetBinaryOutputStream; r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D90118
2020-09-17 08:08:28 +00:00
1f5fbe5f43
Bug 1664770 - Use QM_TRY* for storage initialization code; r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D90094
2020-09-17 12:55:57 +00:00
4f1ba76c89
Bug 1663924 - Add ScopedLogExtraInfo. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D90112
2020-09-17 09:38:12 +00:00
559e163f24
Backed out 9 changesets (bug 1663924, bug 1664844) for Linux Mochitests leaks. CLOSED TREE
...
Backed out changeset 8d28611ac9b2 (bug 1663924)
Backed out changeset e0b0b3a19544 (bug 1663924)
Backed out changeset 884e286909f9 (bug 1663924)
Backed out changeset ffed28f0b547 (bug 1664844)
Backed out changeset 4c22c3c8aa28 (bug 1663924)
Backed out changeset fcaed021597c (bug 1663924)
Backed out changeset 30394cbcaaf6 (bug 1663924)
Backed out changeset 014bcf5d13b9 (bug 1663924)
Backed out changeset ccf09dfa817a (bug 1663924)
2020-09-16 19:16:21 +03:00
228c508686
Bug 1663924 - Add ScopedLogExtraInfo. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D90112
2020-09-16 14:56:20 +00:00
b26988fef6
Bug 1664412 - Mark some error handling functions as MOZ_COLD. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D89885
2020-09-14 12:14:17 +00:00
75112e975a
Bug 1661711 - Use Result<V, E> for GetDirectoryOrigin and use *_TRY_VAR for its callsites; r=sg,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D89704
2020-09-10 12:37:37 +00:00
697765505f
Bug 1663610 - Do not declare a variable in the scope *_TRY is used. r=janv,dom-workers-and-storage-reviewers
...
Depends on D89429
Differential Revision: https://phabricator.services.mozilla.com/D89430
2020-09-08 12:52:00 +00:00
91500edec4
Bug 1536596 - Crash with details on principal verification failures in early-beta-or-earlier builds. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D88290
2020-09-08 15:47:21 +00:00
f9e3a895af
Bug 1662087 - Replace explicit error handling involving `mozilla::Result::isErr` with IDB_TRY/IDB_TRY_VAR in ActorsParent.cpp; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D88864
2020-09-08 15:05:06 +00:00
ec62d45a35
Bug 1660751 - Use bare const char* in HandleError signature to reduce size of calling code. r=dom-workers-and-storage-reviewers,janv
...
Not that this is deliberately de-optimizing performance: Now, the HandleError
functions need to use the nsDependentCString constructor to determine the
length of the literals at run-time, since that's lost. While passing that
in addition would reduce the binary size wins again, and is not necessary,
since this code is only called in error situations, which are not
performance-critical.
Differential Revision: https://phabricator.services.mozilla.com/D89148
2020-09-08 07:40:30 +00:00
ffb37d08c1
Bug 1660751 - Make HandleError function MOZ_NEVER_INLINE. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D89147
2020-09-02 15:03:06 +00:00
ebcfb83228
Bug 1660751 - QM: Log failures in the browser console; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D88004
2020-09-08 07:40:46 +00:00
e5ee46c338
Bug 1662097 - QM_TRY/QM_TRY_VAR cleanup functions should have access to tryTempResult; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D88807
2020-09-07 12:24:33 +00:00
7e31de8547
Bug 1662004 - Add support for nested QM_TRY/QM_TRY_VAR macros; r=dom-workers-and-storage-reviewers,sg,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D88764
2020-09-07 18:00:00 +00:00
16aa57011b
Bug 1661988 - Introduce QM_DEBUG_TRY/QM_DEBUG_TRY_VAR/QM_DEBUG_FAIL macros and quota client specific equivalents; r=dom-workers-and-storage-reviewers,sg,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D88760
2020-09-07 10:05:13 +00:00
bd8716748a
Bug 1661988 - Clean up TestQuotaCommon.cpp; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D89318
2020-09-07 08:51:21 +00:00
78228ee48f
Bug 1662077 - QM: Replace ToResultInvoke with MOZ_TO_RESULT_INVOKE where possible; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D88786
2020-08-31 14:51:29 +00:00
b5b7c7cac5
Bug 1659053 - Have a test to verify the fix; r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D88026
2020-08-28 15:32:58 +00:00
29ea2d7f88
Bug 1659053 - Restore or remove the origin directory if its directory name is inconsistent with the origin in the directory metadta file; r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D88025
2020-08-28 17:38:35 +00:00
a8d941f9a6
Bug 1661085 - Use IDB_TRY_* macros in CreateMarkerFile and RemoveMarkerFile. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88170
2020-08-28 15:51:23 +00:00
41774cf0d3
Bug 1661084 - Add CollectWhile/CollectEach algorithms for Result. r=janv
...
Differential Revision: https://phabricator.services.mozilla.com/D88169
2020-08-28 15:51:06 +00:00
7a010f17ae
Backed out 11 changesets (bug 1661083, bug 1661085, bug 1661084) for build bustages on ResultExtensions.h. CLOSED TREE
...
Backed out changeset 962967831dd4 (bug 1661085)
Backed out changeset 8e61a7d2daf9 (bug 1661085)
Backed out changeset 1edbc081c9f0 (bug 1661085)
Backed out changeset c640f4126079 (bug 1661085)
Backed out changeset b5fc9ebaac12 (bug 1661085)
Backed out changeset 4e3faaadccb6 (bug 1661085)
Backed out changeset 522cdd011e03 (bug 1661085)
Backed out changeset 896e47fc24e3 (bug 1661085)
Backed out changeset bf4043d4ce8e (bug 1661085)
Backed out changeset d0162bb5012e (bug 1661084)
Backed out changeset f0e7db520938 (bug 1661083)
2020-08-28 16:27:58 +03:00
670d542257
Bug 1661639 - QM: Only debug builds need to use expressions in HandleError; r=dom-workers-and-storage-reviewers,sg
...
Depends on D87834
Differential Revision: https://phabricator.services.mozilla.com/D88570
2020-08-28 11:44:46 +00:00
557c5bf3ad
Bug 1661085 - Use IDB_TRY_* macros in CreateMarkerFile and RemoveMarkerFile. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88170
2020-08-28 10:03:07 +00:00
fccf1a2cc3
Bug 1661084 - Add CollectWhile/CollectEach algorithms for Result. r=janv
...
Differential Revision: https://phabricator.services.mozilla.com/D88169
2020-08-28 10:02:49 +00:00
171d05204b
Bug 1660406 - Use QM_FAIL with cleanup in QuotaManager::EnsureStorageIsInitialized; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D87834
2020-08-28 10:43:02 +00:00
68c61ad122
Bug 1661425 - QM: Change the order of failure handling patterns from chronological to reverse chronological; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D88394
2020-08-28 10:42:39 +00:00
f2f47372af
Bug 1659959 - Introduce QM_FAIL macro and quota client specific equivalents; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D87633
2020-08-27 11:10:10 +00:00
3dd521872b
Bug 1536596 - Added unit tests for AnonymizedOriginString. r=dom-workers-and-storage-reviewers,janv
...
Depends on D88288
Differential Revision: https://phabricator.services.mozilla.com/D88289
2020-08-26 13:54:53 +00:00
0cb09645d3
Bug 1536596 - Change AnonymizedOriginString and AnonymizedCString into functions. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D88288
2020-08-26 14:12:45 +00:00
e5e50f34c8
Bug 1647316 - Treat all usages in DOM Cache as database usages; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D86529
2020-08-18 09:29:03 +00:00
e714fc9814
Bug 1659925 - Use QM_TRY with cleanup in QuotaManager::EnsureStorageIsInitialized; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D87565
2020-08-24 08:15:20 +00:00
57c6350d78
Bug 1659680 - QM: Introduce ToResultGet and use it in EnsureStorageIsInitialized; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D87422
2020-08-24 17:41:30 +00:00
549e4c14b7
Bug 1659677 - QM: Replace SuccessEnforcer with mozilla::Result::orElse; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D87420
2020-08-24 16:36:08 +00:00
094129f698
Bug 1659929 - QM_TRY/QM_TRY_VAR should use *CUSTOM_RET_VAL* instead of *CUSTOM_RET_VAR* internal macros; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D87566
2020-08-21 09:49:51 +00:00
b7ae478543
Bug 1659693 - Support additional cleanup function in QM_TRY/QM_TRY_VAR; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D87431
2020-08-21 08:11:25 +00:00
64d2674507
Bug 1659689 - QM: Change return type of LoadCacheVersion to Result<int32_t, nsresult>; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D87430
2020-08-21 05:44:19 +00:00
ee8d613f32
Bug 1659689 - QM: Change return type of LoadLocalStorageArchiveVersion to Result<int32_t, nsresult>; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D87429
2020-08-21 05:11:14 +00:00
2d14cadbbe
Bug 1659689 - QM: Change return type of IsLocalStorageArchiveInitialized to Result<bool, nsresult>; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D87428
2020-08-21 05:11:11 +00:00
d238a70396
Bug 1659683 - QM: Record first initialization attempt directly in UpgradeStorageFrom* functions; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D87426
2020-08-21 05:11:03 +00:00
14808faf69
Bug 1659683 - QM: Record first initialization attempt directly in UpgradeFromPersistentStorageDirectoryToDefaultStorageDirectory; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D87425
2020-08-21 05:11:00 +00:00
a07b1845e7
Bug 1659683 - QM: Record first initialization attempt directly in UpgradeFromIndexedDBDirectoryToPersistentStorageDirectory; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D87424
2020-08-21 05:16:40 +00:00
8c74711517
Bug 1658874 - Change return type of QuotaManager::CreateLocalStorageArchiveConnection to Result<V, E>; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D86913
2020-08-20 11:04:05 +00:00
56128d1bfc
Bug 1658324 - Convert most of the error handling in QuotaManager::EnsureStorageIsInitialized to QM_TRY/QM_TRY_VAR; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D86560
2020-08-20 13:32:21 +00:00
850817430e
Backed out 3 changesets (bug 1658874, bug 1658324, bug 1659660) for bustage at ActorsParent.cpp. CLOSED TREE
...
Backed out changeset b69e256013a3 (bug 1659660)
Backed out changeset 4939692a9047 (bug 1658874)
Backed out changeset e27fb7cd29fe (bug 1658324)
2020-08-20 13:57:20 +03:00
33dc9faddb
Bug 1658874 - Change return type of QuotaManager::CreateLocalStorageArchiveConnection to Result<V, E>; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D86913
2020-08-20 08:52:34 +00:00
21c2588147
Bug 1658324 - Convert most of the error handling in QuotaManager::EnsureStorageIsInitialized to QM_TRY/QM_TRY_VAR; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D86560
2020-08-20 07:32:05 +00:00
f3e1fbf443
Bug 1609625 - Align the name of key for TimeStamp errors; r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D87610
2020-08-19 16:33:09 +00:00
e116198cc4
Bug 1609625 - Deal with recorded time duration if it across sleep/wake; r=dom-workers-and-storage-reviewers,sg,janv
...
Depends on D83305
Differential Revision: https://phabricator.services.mozilla.com/D83524
2020-08-18 07:31:24 +00:00
93f8af72df
Bug 1609625 - Remove the probe for tracking time duration on initializing repositories and add a probe for tracking time duration on loading quota; r=dom-workers-and-storage-reviewers,sg,janv
...
Depends on D83304
Differential Revision: https://phabricator.services.mozilla.com/D83305
2020-08-18 07:53:15 +00:00
246bfa7db7
Bug 1659962 - Add additional MOZ_ARG_* macros; r=jwalden
...
Differential Revision: https://phabricator.services.mozilla.com/D87579
2020-08-19 14:31:40 +00:00
4d6fbf54e6
Bug 1658873 - Support variable declaration containing commas in QM_TRY_VAR; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D86912
2020-08-18 08:25:49 +00:00
918c62f869
Bug 1658872 - Replace MOZ_PASTE with MOZ_CONCAT in MOZ_UNIQUE_VAR definition; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D86911
2020-08-18 08:23:34 +00:00
1fccb4c60f
Bug 1634436 - Make cipher-strategy stateful and keep mode, key and IV as state. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D80014
2020-08-17 08:42:20 +00:00
0c03ba166c
Bug 1658471 - Remove dom.security.featurePolicy.enabled. r=baku
...
We've shipped it on by default since 74 (bug 1617219).
Differential Revision: https://phabricator.services.mozilla.com/D86665
2020-08-12 10:57:04 +00:00
c35198fb73
Bug 1658504 - Support declaration of variables in QM_TRY_VAR; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D86685
2020-08-11 11:17:56 +00:00
1e02318b49
Bug 1653335 - Replace MakeSpan uses by constructor calls. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D83817
2020-08-07 07:49:47 +00:00
96f3e7e019
Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-04 11:27:07 +00:00
381fca9783
Backed out 4 changesets (bug 1654992, bug 1654991) for causing timeous in mask-opacity-1e.html
...
Backed out changeset 11f0f54c6e0a (bug 1654992)
Backed out changeset a353dd5b3f08 (bug 1654991)
Backed out changeset 6a7964ba549f (bug 1654991)
Backed out changeset cf3bfb91d98c (bug 1654991)
2020-08-03 22:09:36 +03:00
032d2ac9d3
Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-03 14:54:18 +00:00
deee6a2007
Bug 1651016 - Allow definition of module specific TRY/TRY_VAR macros using generic QM_TRY_META/QM_TRY_VAR_META macros; r=dom-workers-and-storage-reviewers,ttung,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D84313
2020-07-24 07:01:37 +00:00
58d6af1651
Bug 1651016 - Convert remaining NS_ENSURE_SUCCESS to QM_TRY in FileStreams.cpp; r=dom-workers-and-storage-reviewers,ttung,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D84312
2020-07-24 07:01:36 +00:00
f504378166
Bug 1651016 - Convert remaining NS_ENSURE_SUCCESS to QM_TRY in ActorsParent.cpp; r=dom-workers-and-storage-reviewers,ttung,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D83958
2020-07-24 07:01:36 +00:00
8e9d12cff6
Bug 1651016 - Convert remaining NS_ENSURE_TRUE to QM_TRY; r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D83953
2020-07-24 07:01:36 +00:00
d9083e868b
Bug 1651016 - Convert NS_ENSURE_SUCCESS and NS_ENSURE_TRUE in EnsureDirectory; r=dom-workers-and-storage-reviewers,ttung,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D83931
2020-07-24 07:01:36 +00:00
efff70bde9
Bug 1651016 - Allow MOZ_TRY/QM_TRY to handle nsresult values and optionally enforce success for some special values; r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D83929
2020-07-24 07:01:35 +00:00
4c3f248c7a
Bug 1651016 - Allow MOZ_TRY/QM_TRY to handle bool values by wrapping them with OkIf; r=dom-workers-and-storage-reviewers,ttung,sg,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D83928
2020-07-24 10:20:42 +00:00
7ae4b87c84
Bug 1651016 - Introduce QM_TRY and QM_TRY_VAR macros; r=dom-workers-and-storage-reviewers,ttung,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D83927
2020-07-24 07:11:24 +00:00
fe64f78ef1
Backed out changeset c5a8759b3f85 (bug 1651016) for build bustages at gtest.h on a CLOSED TREE
2020-07-24 09:59:44 +03:00
89a2c67112
Bug 1651016 - Introduce QM_TRY and QM_TRY_VAR macros; r=dom-workers-and-storage-reviewers,ttung,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D83927
2020-07-24 06:35:07 +00:00
74e45489fa
Backed out 9 changesets (bug 1651016) for causing hazard failures in TestQuotaCommon.cpp
...
CLOSED TREE
Backed out changeset 5e566996d34e (bug 1651016)
Backed out changeset 002ddedb37dc (bug 1651016)
Backed out changeset aed04f32eb91 (bug 1651016)
Backed out changeset 2f4529e62cd3 (bug 1651016)
Backed out changeset 8f2aa854a083 (bug 1651016)
Backed out changeset 7f6eb1658a16 (bug 1651016)
Backed out changeset 5d5b249ca664 (bug 1651016)
Backed out changeset 9142d4249c29 (bug 1651016)
Backed out changeset 8d2cc761e5ba (bug 1651016)
2020-07-24 00:00:55 +03:00
da90942030
Bug 1651016 - Allow definition of module specific TRY/TRY_VAR macros using generic QM_TRY_META/QM_TRY_VAR_META macros; r=dom-workers-and-storage-reviewers,ttung,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D84313
2020-07-23 09:18:29 +00:00
82f28d2c55
Bug 1651016 - Convert remaining NS_ENSURE_SUCCESS to QM_TRY in FileStreams.cpp; r=dom-workers-and-storage-reviewers,ttung,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D84312
2020-07-23 09:18:22 +00:00
d380b48ae6
Bug 1651016 - Convert remaining NS_ENSURE_SUCCESS to QM_TRY in ActorsParent.cpp; r=dom-workers-and-storage-reviewers,ttung,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D83958
2020-07-23 09:18:05 +00:00
0c646b6416
Bug 1651016 - Convert remaining NS_ENSURE_TRUE to QM_TRY; r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D83953
2020-07-23 18:29:02 +00:00
c83c17ecd2
Bug 1651016 - Convert NS_ENSURE_SUCCESS and NS_ENSURE_TRUE in EnsureDirectory; r=dom-workers-and-storage-reviewers,ttung,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D83931
2020-07-23 09:17:29 +00:00
6962e6e3b7
Bug 1651016 - Allow MOZ_TRY/QM_TRY to handle nsresult values and optionally enforce success for some special values; r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D83929
2020-07-23 18:29:53 +00:00
8bb9a5e834
Bug 1651016 - Allow MOZ_TRY/QM_TRY to handle bool values by wrapping them with OkIf; r=dom-workers-and-storage-reviewers,ttung,sg,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D83928
2020-07-23 18:13:32 +00:00
a14d13c5e0
Bug 1651016 - Introduce QM_TRY and QM_TRY_VAR macros; r=dom-workers-and-storage-reviewers,ttung,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D83927
2020-07-23 09:17:00 +00:00
8f54209ef6
Bug 1651165 - Rename idle service r=Gijs,geckoview-reviewers,snorp
...
Differential Revision: https://phabricator.services.mozilla.com/D83413
2020-07-20 16:06:59 +00:00
63e00f01a8
Bug 1614397 - Remove the temporary telemetry probe for tracking temporary storage initialization time; r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D83304
2020-07-13 13:54:04 +00:00
7b8ef5617f
Bug 1621920 - Convert SDB client to use the new macro for warning about unknown stuff and add handling of unknown directories in SDB client directory; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D81690
2020-07-02 07:20:06 +00:00
0829d2432e
Bug 1649393 - Remove old IDB files directories during 1.0 to 2.0 storage upgrade; r=dom-workers-and-storage-reviewers,ttung
...
If an old IDB files directory exists, it no longer causes a failure during the
storage upgrade. The directory is removed instead.
Differential Revision: https://phabricator.services.mozilla.com/D81870
2020-07-01 16:07:56 +00:00
c151383a4a
Bug 1649503 - Fix behaviour of UsageInfo. r=dom-workers-and-storage-reviewers,janv
...
Depends on D81829
Differential Revision: https://phabricator.services.mozilla.com/D81830
2020-07-01 10:38:46 +00:00
4db9224db5
Bug 1649503 - Add tests for UsageInfo. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D81829
2020-07-01 10:32:39 +00:00
9364b353d4
Bug 1648010 - Remove NS_NAMED_LITERAL_CSTRING and NS_NAMED_LITERAL_STRING macros. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80631
2020-07-01 08:42:31 +00:00
e3c223da3e
Bug 1648010 - Fix uses of NS_LITERAL_STRING with C string literals. r=geckoview-reviewers,agi,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80861
2020-07-01 08:34:12 +00:00
cd8b8939b9
Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
f482502235
Bug 1621920 - Convert LS client to use the new macro for warning about unknown stuff and add testing for unknown directories in LS client directory; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D80167
2020-06-26 01:56:45 +00:00
f7200a696c
Bug 1621920 - Provide a new testable macro for warning about unknown files or directories; r=dom-workers-and-storage-reviewers,ttung,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D80166
2020-06-25 07:16:47 +00:00
3048b298b2
Bug 1621920 - Fix some comments in test_unknownFiles.js; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D80165
2020-06-25 07:16:50 +00:00
43fe271d3f
Bug 1634436 - Make DecryptingInputStream implement nsIIPCSerializableInputStream. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D75913
2020-06-25 13:23:06 +00:00
ea360db963
Bug 1634436 - Make DecryptingInputStream implement nsICloneableInputStream. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D75815
2020-06-17 15:04:29 +00:00
5205b46013
Bug 1634436 - Fix DecryptingInputStream::Available and add tests. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D79811
2020-06-23 11:29:42 +00:00
8193fe19be
Bug 1641512 - Use distinct types for file and database usage. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77462
2020-06-25 09:30:06 +00:00
55e3bdd7f8
Bug 1641512 - Use Result<UsageInfo, nsresult> as return type of InitOrigin and add separate InitOriginWithoutTracking. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77453
2020-06-25 09:31:39 +00:00
c23800e5f2
Bug 1641512 - Use Result<UsageInfo, nsresult> as return type of GetUsageForOrigin. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77452
2020-06-25 08:34:43 +00:00
0084f5d032
Backed out 3 changesets (bug 1621920) for bustages on ActorsParent.cpp . CLOSED TREE
...
Backed out changeset 6d94049a8f9e (bug 1621920)
Backed out changeset b85b0e346dee (bug 1621920)
Backed out changeset e3e3a090ee96 (bug 1621920)
2020-06-25 10:08:13 +03:00
48989fbc7c
Bug 1621920 - Convert LS client to use the new macro for warning about unknown stuff and add testing for unknown directories in LS client directory; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D80167
2020-06-25 06:29:48 +00:00
5dac5d306c
Bug 1621920 - Provide a new testable macro for warning about unknown files or directories; r=dom-workers-and-storage-reviewers,ttung,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D80166
2020-06-25 06:27:01 +00:00
82cb01d28e
Bug 1621920 - Fix some comments in test_unknownFiles.js; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D80165
2020-06-25 06:26:43 +00:00
3e754f2b5c
Bug 1645943 - Override xFullPathname to avoid the use of GetFullPathNameW; r=janv,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D80202
2020-06-24 16:08:45 +00:00
7686c6ddbd
Bug 1645943 - A testcase to ensure temporary storage initialization is not blocked by a cache directory in an origin directory that ends with a period; r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D80001
2020-06-22 22:15:01 +00:00
87438519f0
Bug 1637500 - P2. Rename methods as they are not always dealing with "threads". r=froydnj
...
Before P1, GetCurrentThreadSerialEventTarget would have always returned the same data as NS_GetCurrentThread, making the comment incorrect Now it will properly return the running TaskQueue if any.
This change of name more clearly exposes what they are doing, as we aren't always dealing with threads directly; but a nsISerialEventTarget
Differential Revision: https://phabricator.services.mozilla.com/D80354
2020-06-23 05:05:36 +00:00
a338574f2d
Backed out 2 changesets (bug 1645943) for build bustages on QuotaClient.cpp. CLOSED TREE
...
Backed out changeset 7a2022403814 (bug 1645943)
Backed out changeset 3ed2b9424225 (bug 1645943)
2020-06-23 01:11:33 +03:00
a767576b6e
Bug 1645943 - A testcase to ensure temporary storage initialization is not blocked by a cache directory in an origin directory that ends with a period; r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D80001
2020-06-22 16:17:35 +00:00
6ccabd4784
Bug 1602668 - M(1) manifest and test changes. r=kmag,karlt,necko-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D70362
2020-06-22 19:09:49 +00:00
92ffcc48e8
Bug 1641512 - Replace Append method by operator+=. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77451
2020-06-11 10:42:24 +00:00
2e8e66ab3c
Bug 1641512 - Rename AppendTo*Usage methods to Increment*Usage. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77450
2020-06-11 10:42:16 +00:00
dea8831f5c
Bug 1641512 - Introduce Usage type with operator+/+=. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77449
2020-06-11 10:42:12 +00:00
38fd6472cd
Bug 1641512 - Remove unused include directive. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77447
2020-06-11 10:42:10 +00:00
f786f97363
Bug 1641512 - Remove unused UsageInfo::DatabaseUsage function. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77446
2020-06-11 10:42:07 +00:00
478765004c
Bug 1621916 - Provide a usable stack when requestFinished throws; r=dom-workers-and-storage-reviewers,sg,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D77217
2020-06-11 07:04:38 +00:00
e655325a13
Bug 1634436 - Add support for seeking (nsISeekableStream). r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D74669
2020-06-11 08:02:29 +00:00
aa427a3937
Bug 1634436 - Add encrypted stream implementation. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D76481
2020-06-11 08:00:39 +00:00
0e09b9191c
Backed out changeset 3f5baab34b1f (bug 1621916) for causing failure at QuotaRequests.cpp. CLOSED TREE
2020-06-11 09:58:59 +03:00
e72a3e7779
Bug 1621916 - Provide a usable stack when requestFinished throws; r=dom-workers-and-storage-reviewers,sg,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D77217
2020-06-11 06:36:55 +00:00
bf2c33ba86
Bug 1641231 - Reduce raw pointers as functions arguments for DirectoryLock related functions in QuotaManager; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D78068
2020-06-10 10:11:53 +00:00
4970cd9ea4
Bug 1641231 - Use FlippedOnce for DirectoryLockImpl::mInvalidate; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D78067
2020-06-10 12:25:09 +00:00
714f42fd9c
Bug 1641231 - Use InitializedOnce for DirectoryLockImpl::mOpenListener; r=dom-workers-and-storage-reviewers,janv,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D78066
2020-06-10 10:11:53 +00:00
9810bb5a2b
Bug 1641231 - Use NotNull for DirectoryLockImpl's member variables; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D78065
2020-06-10 10:10:47 +00:00
55867d7488
Bug 1641231 - Replace raw pointers as functions arguments in DirectoryLockImpl; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D78062
2020-06-10 10:10:39 +00:00
9d2af3f636
Bug 1482279 - Update the comment in dom/quota/test/common/content.js. r=asuth
...
Since content has no access to chrome-privileged objects without permissive
COWs, we can no longer unwrap the methods anymore. On the other hand,
SpecialPowers wrapper improved so that we don't have to unwrap the return
value from getAsArrayBuffer() manually.
Differential Revision: https://phabricator.services.mozilla.com/D79140
2020-06-10 22:51:22 +00:00
43e76aca07
Backed out 2 changesets (bug 1634436) for causing bustages in TestEncryptedStream.cpp
...
CLOSED TREE
Backed out changeset dc8cff56948f (bug 1634436)
Backed out changeset 2bdc7d7249f5 (bug 1634436)
2020-06-10 22:17:20 +03:00
672ce1ce54
Bug 1634436 - Add support for seeking (nsISeekableStream). r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D74669
2020-06-10 16:17:20 +00:00
de661a3fd7
Bug 1634436 - Add encrypted stream implementation. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D76481
2020-06-10 16:17:06 +00:00
ab2cd5732d
Backed out 5 changesets (bug 1641231) for assertion failures on FlippedOnce.h. CLOSED TREE
...
Backed out changeset f91248e16c71 (bug 1641231)
Backed out changeset 3c4db99ba498 (bug 1641231)
Backed out changeset 125533344189 (bug 1641231)
Backed out changeset 203e3ec45022 (bug 1641231)
Backed out changeset 84668b82ebee (bug 1641231)
2020-06-09 20:39:47 +03:00
3402c1562f
Bug 1641231 - Reduce raw pointers as functions arguments for DirectoryLock related functions in QuotaManager; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D78068
2020-06-08 08:22:43 +00:00
893617b0d8
Bug 1641231 - Use FlippedOnce for DirectoryLockImpl::mInvalidate; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D78067
2020-06-04 08:30:33 +00:00
deebd6c64d
Bug 1641231 - Use InitializedOnce for DirectoryLockImpl::mOpenListener; r=dom-workers-and-storage-reviewers,janv,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D78066
2020-06-09 06:59:40 +00:00
453b1fffec
Bug 1641231 - Use NotNull for DirectoryLockImpl's member variables; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D78065
2020-06-04 08:23:10 +00:00
49df6834b9
Bug 1641231 - Replace raw pointers as functions arguments in DirectoryLockImpl; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D78062
2020-06-04 07:53:45 +00:00
13502cf27c
Bug 1642991 - Use RemoveElementsBy where easily possible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D78055
2020-06-08 09:01:48 +00:00
b9a2ffc214
Bug 1482279 - Stop using Cu.forcePermissiveCOWs() in SpecialPowers. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D74641
2020-05-31 03:41:03 +00:00
50ef0fddc5
Bug 1641231 - Split GetUsageForOrigin into a smaller function; r=dom-workers-and-storage-reviewers,sg,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77286
2020-05-29 13:57:50 +00:00
12150459e9
Bug 1641231 - Use Result instead of an out parameter for QuotaUsageRequestBase::GetUsageForOrigin; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D77080
2020-05-29 13:20:24 +00:00
08b4a5ca2c
Bug 1641231 - Do not pass a raw pointer only for dereferencing for functions in actor classes; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D77079
2020-05-29 12:34:59 +00:00
3ee1a7f56f
Bug 1641231 - Reduce the usage for passing raw pointers in RegisterNormalOriginOp/UnregisterNormalOriginOp; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D77078
2020-05-29 12:34:57 +00:00
061f3b01c3
Bug 1641231 - Replace new operator with MakeRefPtr for constructing actor classes; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D77077
2020-05-29 12:34:52 +00:00
42f5cca14e
Bug 1621916 - Fix IndexedDB to ignore unknown files in the client directory during initialization and usage calculation; r=dom-workers-and-storage-reviewers,sg,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D77073
2020-05-28 11:14:52 +00:00
d123d73b2d
Bug 1621916 - Remove unused argument in Client::InitOrigin; r=dom-workers-and-storage-reviewers,sg
...
Depends on D77070
Differential Revision: https://phabricator.services.mozilla.com/D77072
2020-05-27 15:52:49 +00:00
e7a857459c
Bug 1621916 - Add unknown files for Cache API morgue directory and its subdirectories; r=dom-workers-and-storage-reviewers,ttung
...
Cache API is currently not consistent regarding unknown files. Some unknown
files are reported and ignored, other unknown files are reported and deleted or
just silently deleted without a warning.
Quota Manager, IndexedDB, SimpleDB and LocalStorage currently report and ignore
such files. We should try to unify this in future.
Differential Revision: https://phabricator.services.mozilla.com/D76718
2020-05-27 14:31:59 +00:00
5183f79beb
Bug 1621916 - Unify reporting of unknown files across quota manager, idb, sdb and ls quota client; r=dom-workers-and-storage-reviewers,ttung
...
Depends on D76703
Differential Revision: https://phabricator.services.mozilla.com/D76717
2020-05-26 07:02:07 +00:00
68a6cbf429
Bug 1621916 - Fix IndexedDB to ignore unknown files in the files and journals directory during initialization and usage calculation; r=dom-workers-and-storage-reviewers,ttung
...
All unknown files in the files and journals directory are now properly filtered
out if the filename can't be converted to an integer.
Differential Revision: https://phabricator.services.mozilla.com/D76703
2020-05-26 07:22:12 +00:00
e93eaffe2e
Bug 1621916 - Run test_unknownFiles.js in multiple modes; r=dom-workers-and-storage-reviewers,ttung
...
The functionality needs to be verified for all initialization states (modes)
since some methods don't automatically trigger temporary storage initialization
which results in calling different quota client methods (for example
GetUsageForOrigin calls either Client::InitOrigin or Client::GetUsageForOrigin).
Depends on D76701
Differential Revision: https://phabricator.services.mozilla.com/D76702
2020-05-28 10:03:59 +00:00
4acff3dff1
Bug 1621916 - Fix SimpleDB to ignore unknown files during initialization and usage calculation; r=dom-workers-and-storage-reviewers,ttung
...
SimpleDB files on disk now use a suffix, so unknown files can be filtered out.
Depends on D76700
Differential Revision: https://phabricator.services.mozilla.com/D76701
2020-05-25 15:57:54 +00:00
6b9c3a93f9
Bug 1621916 - Extract profile creation from test_unknownFiles.js into make_unknownFiles.js and make it more sophisticated; r=dom-workers-and-storage-reviewers,ttung
...
A generated profile now matches real world profiles:
- contains directory metadata
- contains real quota client specific files
- contains unique non-empty unknown files (instead of empty foo.bar files)
- contains unique non-empty unknown directories (instead of empty foo dirs)
There's now only one origin directory which contains unknown files and
directories. All methods that take a principal are verified to work with the
origin direcrtory.
Depends on D76095
Differential Revision: https://phabricator.services.mozilla.com/D76700
2020-05-25 16:01:32 +00:00
22dd0c4c8d
Bug 1621916 - Update test_unknownFiles.js with unknown files for cache, sdb and ls quota client; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D76095
2020-05-28 08:34:06 +00:00
7735eac323
Bug 1621916 - Enhance test_unknownFiles.js to cover initTemporaryStorage method; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D75952
2020-05-26 08:24:49 +00:00
93f51d3a5d
Bug 1621916 - Convert test_unknownFiles.js to use quasi subtests; r=dom-workers-and-storage-reviewers,sg
...
Depends on D75950
Differential Revision: https://phabricator.services.mozilla.com/D75951
2020-05-28 07:58:56 +00:00
ca29971168
Bug 1621916 - Convert test_unknownFiles.js to use async functions; r=dom-workers-and-storage-reviewers,sg
...
Depends on D75949
Differential Revision: https://phabricator.services.mozilla.com/D75950
2020-05-28 07:57:43 +00:00
63f5c04b35
Bug 1621916 - Remove redundant checks that were needed before we started ignoring unknown files and directories; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D75949
2020-05-27 15:02:29 +00:00
1345656755
Bug 1621916 - Simplify test_unknownFiles.js by merging stage 1 and stage 2; r=dom-workers-and-storage-reviewers,ttung
...
We plan to replace this test with more thorough tests in bug 1620277, but for
now it's still needed and will be part of a short term fix for ignoring
unknown files and directories.
Differential Revision: https://phabricator.services.mozilla.com/D75948
2020-05-27 15:02:04 +00:00
37ef8a125d
Backed out changeset a845717e4d10 (bug 1482279) for causing multiple failures.
...
CLOSED TREE
2020-05-23 02:22:20 +03:00
0701e89b7e
Bug 1482279 - Stop using Cu.forcePermissiveCOWs() in SpecialPowers. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D74641
2020-05-22 21:46:25 +00:00
626676da02
Bug 1638831 - Rename clearStorageForPrincipal to clearStoragesForPrincipal in tests; r=dom-workers-and-storage-reviewers,ttung
...
Depends on D75786
Differential Revision: https://phabricator.services.mozilla.com/D75788
2020-05-18 13:05:28 +00:00
99503e97e8
Bug 1638831 - Clean up the test for clearStoragesForOriginAttributesPattern(); r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D75786
2020-05-18 13:05:25 +00:00
dc69f70165
Backed out 2 changesets (bug 1624802) for test_listOrigins.js failures CLOSED TREE
...
Backed out changeset e374ffe2e05e (bug 1624802)
Backed out changeset 8e2da4b3c32b (bug 1624802)
2020-05-14 19:56:00 +03:00
17f553f88d
Bug 1624802 - Run some dom/quota xpcshell tests in a child process as well; r=dom-workers-and-storage-reviewers,sg
...
For now, only test_listOrigins.js, test_originWithCaret.js and test_simpledb.js
can run in a child process because they don't need to set preferences or access
files in the profile directory.
We will be able to run more tests in a child process once we have SpecialPowers
for xpcshell implemented using JSProcessActors and when we expose the base
directory used by QuotaManager through a new QuotaManagerService method (to
avoid getting the profile directory using nsIDirectoryService because that
doesn't work in a child process).
Differential Revision: https://phabricator.services.mozilla.com/D75281
2020-05-14 15:35:29 +00:00
3b74d7ea87
Bug 1624802 - Support running dom/quota xpcshell tests in a child process; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D75279
2020-05-14 15:27:38 +00:00
6caab074de
Bug 1624802 - Refactor tests in dom/quota/test; r=dom-workers-and-storage-reviewers,ttung
...
The refactoring consists of:
- moving tests into dedicated directories for given test type
(browser, mochitest, xpcshell)
- replacing add_test with addTest in browser tests to share common setup code
- adding a way to synchronously load scripts in all test types by providing a
path relative to the top level directory
- adding a way to explicitely run a mochitest inside a worker context
(loadWorkerScript)
- removing the need to declare testGenerator in tests
- removing the need to set some common preferences in individual tests
- sharing common functions for:
- system context (system.js)
- content context (content.js)
- browser tests (browser.js)
- mochitest tests (mochitest.js)
- xpcshell tests (xpcshell.js)
- nested content test inside a browser test (nestedtest.js)
- buffer/view/blob/file (file.js)
Differential Revision: https://phabricator.services.mozilla.com/D73149
2020-05-08 09:49:52 +00:00
53e4e4c078
Bug 1626570 - Improve handling of copying arrays in dom/quota/. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D73629
2020-05-05 12:58:56 +00:00
0d91cacd5b
Bug 1624802 - Add a method for retrieving storage name in tests; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D73144
2020-05-05 06:25:18 +00:00
00dceeab95
Bug 1624802 - Add a pref for overriding storage name; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D73142
2020-05-05 06:24:17 +00:00
718c6d81f9
Bug 1633326 - Add an additional warning message that shows the file path when it fails to create a file; r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D72591
2020-04-27 08:38:55 +00:00
34acbb653a
Bug 1619165 - Reformat recent changes to the Google coding style r=andi
...
First reformat with clang-format 10
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D68802
2020-04-25 09:40:08 +00:00
2e68c75bb1
Bug 1626973 - Add assertions for result of MaybeUpdateSize. r=janv,dom-workers-and-storage-reviewers
...
Depends on D69580
Differential Revision: https://phabricator.services.mozilla.com/D69587
--HG--
extra : moz-landing-system : lando
2020-04-03 16:16:50 +00:00
02b4a20039
Bug 1626846 - Disable useDOSDevicePathSyntax for QuotaStorage on Windows; r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69318
--HG--
extra : moz-landing-system : lando
2020-04-06 09:28:35 +00:00
3d69caa161
Bug 1536796 - P6 - Changes on dom/quota unit test to verify the fix; r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D60872
--HG--
extra : moz-landing-system : lando
2020-04-01 07:52:33 +00:00
94e4123950
Bug 1536796 - P3 - Use QM_NewLocalFile in QM and its clients; r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D67875
--HG--
extra : moz-landing-system : lando
2020-04-01 07:26:27 +00:00
4debe01abb
Bug 1536796 - P1 - Introduce a flag (useDOSDevicePathSyntax) to nsILocalFileWin and a method (QM_NewLocalFile) to QuotaCommon; r=janv,dom-workers-and-storage-reviewers,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D67873
--HG--
extra : moz-landing-system : lando
2020-04-01 07:26:27 +00:00
14ca007916
Bug 1625138 - Part 41: Remove no longer needed includes for mozilla/TypeTraits. r=froydnj
...
Also adds missing includes in some files, these were previously only transivitely
included through mozilla/TypeTraits.h.
Differential Revision: https://phabricator.services.mozilla.com/D68561
--HG--
extra : moz-landing-system : lando
2020-03-28 16:00:09 +00:00
ebec34a898
Bug 1625138 - Part 16: Replace mozilla::IsIntegral with std::is_integral. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68371
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:15 +00:00
9ad58ea608
Bug 1625138 - Part 13: Replace mozilla::IsUnsigned with std::is_unsigned. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68368
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:14 +00:00
d371cf7402
Bug 1624880 - Fix quota/test/unit/upgrades tests when LSNG is disabled by default; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D68211
--HG--
extra : moz-landing-system : lando
2020-03-26 19:20:56 +00:00
58d0171406
Bug 1620632 - Ensure nsTArray_Impl only declares a copy-constructor/assignment operator if E is copy-constructible. r=froydnj
...
To correctly implement this, it must be known on instantiation whether E is
copy-constructible, which is not the case if only a forward declaration is
available. This can be resolved either by making sure a full definition of E is
available, which is preferable. But in cases where this is not (easily) possible,
the information can be explicitly provided by the MOZ_DECLARE_COPY_CONSTRUCTIBLE
and MOZ_DECLARE_NON_COPY_CONSTRUCTIBLE macros. In particular, declarations for
IPDL-declared types are added to nsTArray.h itself, like it was already done
for MOZ_DECLARE_RELOCATE_USING_MOVE_CONSTRUCTOR.
Differential Revision: https://phabricator.services.mozilla.com/D66244
--HG--
extra : moz-landing-system : lando
2020-03-20 17:13:51 +00:00
Simon Giesecke
Sebastian Hengst
Bogdan Tara
Jan Varga
Butkovits Atila
Csoregi Natalia
Tom Tung
Razvan Maries
Tom Tung
Emilio Cobos Álvarez
Noemi Erli
Andreea Pavel
Mihai Alexandru Michis
Doug Thayer
Jan Varga
Narcis Beleuzu
Jean-Yves Avenard
Brindusan Cristian
tkhan
Masatoshi Kimura
Sylvestre Ledru
André Bargull