When creating an instance of nsISpellChecker, we always use
mozSpellChecker::Create. So we should use mozSpellChecker directly instead of
nsISpellChecker.
Differential Revision: https://phabricator.services.mozilla.com/D10993
--HG--
extra : rebase_source : 0feffa60e6dc788904d212a77acbf416279af083
extra : histedit_source : b89cc8270c2df70ae414479f43ac30e8aa0a3d42
There are surprisingly many of them.
(Plus a couple of unnecessary checks after `new` calls that were nearby.)
--HG--
extra : rebase_source : 47b6d5d7c5c99b1b50b396daf7a3b67abfd74fc1
Summary:
When implementing async call for PRemoteSpellcheckEngine, IPDL doesn't support
Promise. But now, IPDL supports it, so I should convert to it to avoid
unexpected leak.
And SetDictionary supports empty string as parameter to clear dictionary. So
SetDictionaryFromList should support empty string to clear it to remove
SetDictionary sync call.
Reviewers: masayuki
Tags: #secure-revision
Bug #: 1480699
Differential Revision: https://phabricator.services.mozilla.com/D2714
--HG--
extra : rebase_source : 17fe76e6484f2af4021fe0d963e4fc47f53bebd8
The language parameter of mozIPersonalDictionary is unused, so we should remove
this from parameter. Then, no one uses mLanguage member of mozHunspell now.
Differential Revision: https://phabricator.services.mozilla.com/D2349
--HG--
extra : moz-landing-system : lando
The later is only interesting when the returned value is used
MozReview-Commit-ID: 8CF5HSkcttf
--HG--
extra : rebase_source : deb1761dd017108c9dba1d831a996baf54c7f425
No one uses mozISpellI18NManager, so we should get rid of this interface.
MozReview-Commit-ID: 7f0Cy3tHnt1
--HG--
extra : rebase_source : 414c81cd4bec07124a271138e60ca3fb62ccc439
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
Our bundled Hunspell now significantly differs from upstream Hunspell. Most
importantly, it supports loading dictionaries from jar: URIs, which is now a
requirement for loading bundled and extension dictionaries. This means that
system Hunspell libraries are no longer compatible with our spell checker
code. We should remove the option to use them so that users don't fall into
the trap of trying to use them.
MozReview-Commit-ID: 2ihJe6YOnGf
--HG--
extra : rebase_source : ceb091b9475a2b101156405a02a60015fc36da17
This will allow us to store dictionaries in packed extension XPIs and/or
omni.ja, which should give us a significant startup performance win.
MozReview-Commit-ID: K7fzJJAywjC
--HG--
extra : rebase_source : 4022d27bc4896d8ef27d4141b6c9bc0dd9e1c0a0
extra : absorb_source : 04bdcab8ff8005a0537d1747ba52e84946e7806a
The work to migrate to Sqlite.jsm seems to have caused a timing problem
in our tests where shutdown the content process while this IPC message
is still unresolved. This causes us to destroy RemoteSpellCheckingEngineChild
without it having processed its RecvNotiy..., leading to the promise being
leaked. As far as I can tell this resolves all of our leak issues on try.
MozReview-Commit-ID: GdwVIp5dj1m
--HG--
extra : rebase_source : b7bf5838c53e40b49bea17df123028a2dbd26e5e
This patch was autogenerated by my decomponents.py
It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.
It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <
Makoto Kato
Ehsan Akhgari
Nicholas Nethercote
Brian Hackett
Sylvestre Ledru
Miko Mynttinen
arthur.iakab
Emilio Cobos Álvarez
Kris Maglione
Cosmin Sabou
Doug Thayer
Masatoshi Kimura
Andrew McCreight
Florian Quèze
Chris Manchester
Henri Sivonen
Xidorn Quan
Ryan VanderMeulen
Tooru Fujisawa
Mark Banner
Jan Beich
Kan-Ru Chen
Phil Ringnalda