Automatic update from web-platform-tests[css-properties-values-api] Test initial values individually.
Split up the assertions of the initial value test into multiple tests.
This makes it possible to add test expectations for things which are not
supported yet.
R=futhark@chromium.org
Bug: 641877
Change-Id: I8756b2d066a8bc2ae542ca033d98754255aeb2b2
Reviewed-on: https://chromium-review.googlesource.com/c/1304560
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603859}
--
wpt-commits: 6014df860a812202756c59f230e9bfafb2c8332c
wpt-pr: 13774
Automatic update from web-platform-tests[css-properties-values-api] Test computed values individually.
- Having large buckets of assertions in the same test is not great if
one of those assertions fail.
- Running all tests twice with and without inherited font size is not
relevant for a large amount of the tests.
Therefore:
- Use only one assertion per test, allowing fine-grained test
expectations.
- Only test inherited font-size for a few relevant cases.
R=futhark@chromium.org
Bug: 641877
Change-Id: I0a26dc29da4ca3be04f33b86bb063e48cb2f4c08
Reviewed-on: https://chromium-review.googlesource.com/c/1304520
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603850}
--
wpt-commits: 704a0dbc3dd38a81085b7b813b5602532a63cabd
wpt-pr: 13780
Automatic update from web-platform-testsConsistently use `manager` for ManagerGroup.pool entries (#13775)
--
wpt-commits: 8bb642da20e51c1e8cb8f8e23b1adeb444ab26ad
wpt-pr: 13775
Automatic update from web-platform-testsIndent `manager_group` method calls to within the `with` scope (#13778)
While variable binding `manager_group` does survive after the `with`
statement, that will be after `__exit__` has been called. That still
works, but there's no reason for the reader to wonder if there's a
difference, whether indentation is intentional.
--
wpt-commits: e2f346f20d1d165360ae7ca7df4b027113c217b0
wpt-pr: 13778
Automatic update from web-platform-testsRemove unused method `ManagerGroup.is_alive()` (#13777)
It's not used internally, and the only `ManagerGroup` instance is
created at `with ManagerGroup(...) as manager_group` in wptrunner.py,
and the method is also not called there.
--
wpt-commits: 086f4ef0144b35ee125d1edfc478632b6885b1c7
wpt-pr: 13777
Automatic update from web-platform-tests[css-properties-values-api] Compute <resolution> values to 'dppx'.
Unfortunately, calc() in <resolution> values is not yet supported in Blink.
(Such values were not allowed for <resolution> before CSS Values and Units
Level 4).
R=futhark@chromium.org
Bug: 641877
Change-Id: I4b3fdcd24f37018a415489e7d15220dc34698c04
Reviewed-on: https://chromium-review.googlesource.com/c/1304554
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603843}
--
wpt-commits: 9d2432a20edd05076fa49f265adeeb64e78a3aba
wpt-pr: 13776
Automatic update from web-platform-testsServiceWorker: Move WPTs for ServiceWorkerContainer.startMessages() into its own file
This CL moves tests for ServiceWorkerContainer.startMessages() and message
queues from postmessage-to-client.https.html to
postmessage-to-client-message-queue.https.html. This doesn't change test
behavior.
The motivations of this change are as follows:
- Tests for startMessages() are timing out on all web browsers[1]. This hides
the results of typical tests for WindowClient.postMessage(), and makes it
difficult to add new tests for WorkerClient.postMessage().
- Test formats are totally different among them. This makes it difficult to read
test scripts.
[1] https://wpt.fyi/results/service-workers/service-worker/postmessage-to-client.https.html?aligned&label=stable
Bug: 894682
Change-Id: Ia66af523ccff4529f85aac23df5059be099290a2
Reviewed-on: https://chromium-review.googlesource.com/c/1307025
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603837}
--
wpt-commits: 899e3a45f8d628c4a7cfb324e031a99f3a4aefdf
wpt-pr: 13770
Automatic update from web-platform-tests[css-properties-values-api] Compute <time> values to seconds.
The CSSPrimitiveValue::IsTime function (non-static) did for some reason
use GetType() instead of TypeWithCalcResolved(), even though both
ComputeSeconds() and TypeWithCalcResolved() do seemingly handle calculated
time correctly.
R=futhark@chromium.org
Bug: 641877
Change-Id: I0e927265f01855b8262ed9201df9eae647171b8d
Reviewed-on: https://chromium-review.googlesource.com/c/1304481
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603832}
--
wpt-commits: 9082397e214eef1fd04e478e353cd0d19a64f040
wpt-pr: 13771
Automatic update from web-platform-tests[filter-effects] Inheritance and initial values (#13105)
Test that Filter Effects properties inherit.
Test that initial values match the spec.
https://drafts.fxtf.org/filter-effects/#property-index
--
wpt-commits: 7b078f0d6ff82157c57f343838f61b5200686e53
wpt-pr: 13105
Automatic update from web-platform-tests[css-properties-values-api] Proper computed value for <color>.
As of an imminent spec change, <color> values no longer compute to their
specified value, but behave like <color> values in general.
Note that color keywords are parsed as CSSIdentifierValue (holding a
CSSValueID), and custom idents are parsed as CSSCustomIdentValue (holding a
String), which is why the "tomato | <color>" works as it should.
R=futhark@chromium.org
Bug: 641877
Change-Id: I946536a9d54dbaa7af589cb99acdba72f37fe016
Reviewed-on: https://chromium-review.googlesource.com/c/1303365
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603628}
--
wpt-commits: 38bb114c431508bf122a9699869c7a72e4feb5b3
wpt-pr: 13761
Automatic update from web-platform-testsAssign a name to iframes when loading the initial about:blank
Before, it would assign the name too late,
causing scripts (which will not wait for another tick)
to accidentally spawn pop-up windows instead of loading
into the iframe.
--
Use `t.step_func` and expected path checking
--
wpt-commits: 4939eaea72260f3ded7c1d935c929b220cfaa9ab, 76b8a916dcabe7f1160b1690d1c2721118955693
wpt-pr: 13585
Automatic update from web-platform-testsPython 3: Use six.create_bound_method() in test_response.py (#13624)
--
wpt-commits: 669ee6464677befda509ca4056ab8269db7e94a8
wpt-pr: 13624
Automatic update from web-platform-testsUse the correct out-of-flow containing block in continuations.
We cannot just use the innermost inline, without checking if it's a
valid containing block for absolutely positioned descendants. Find the
right ancestor.
The idea of using the *next* inline in the continuation chain may not be
ideal, but it's not obvious that using the previous one would be much
better (it's more work to find that one anyway), so leaving it as it is.
The spec says that if the relatively positioned inline occurs on
multiple lines, CSS 2 doesn't define exact behavior. Therefore, in the
test, put the same amount of stuff on the line preceding the
interrupting block-level element as on the line following it, to be sure
that the abspos descendant is sized the way we want it to be.
Bug: 897535
Change-Id: Ie9bc4e83400bc283b9c95aafef821000f2303d12
Reviewed-on: https://chromium-review.googlesource.com/c/1301457
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603466}
--
wpt-commits: 38470be9afc947a30b9b1a066d8419cec4d0a3a8
wpt-pr: 13731
Automatic update from web-platform-testsWPT: Adjust expected timing resolution
We recently increased[1] the minimum resolution of web-exposed timers.
This patch relaxes the WPT tests accordingly to allow for a higher
resolution (with a small delta to account for floating point errors).
Bug: 897775
[1] https://chromium-review.googlesource.com/c/1290916
Change-Id: I6f8a8d8ac2b827ae54718db6f8940cafb1cad665
Reviewed-on: https://chromium-review.googlesource.com/c/1298017
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603461}
--
wpt-commits: 14b8cd38f01ee9127919c12a7d29e372643c2097
wpt-pr: 13709
Automatic update from web-platform-testsFix pip aspect ratio test
--
Merge pull request #13734 from web-platform-tests/beaufortfrancois-patch-1
Fix pip aspect ratio test
--
wpt-commits: 39322dfcc55488ee0b2dd8e4495d20cf103c6e15, 1d5dbb331ad61eec01d55bc160b99772de3254d7
wpt-pr: 13734
Automatic update from web-platform-testsSwapping @MSFTkihans with @zouhir (#13733)
We agreed to this at TPAC
--
wpt-commits: 2e7a549d07c54cbdb9002634bf5a4cc6ce8f9acb
wpt-pr: 13733
Automatic update from web-platform-tests[filter-effects] filter arguments optional (#13750)
grayscale() etc may be used without arguments.
https://github.com/w3c/fxtf-drafts/issues/1
--
wpt-commits: 8d90bc4a082eb30f8843e38068f29a9e81bf2fca
wpt-pr: 13750
Automatic update from web-platform-testsUpdate comments and test mix-blend-mode on pattern
The working group recently resolved that mix-blend-mode should not
apply to never-rendered elements such as pattern, see:
https://github.com/w3c/fxtf-drafts/issues/309. This patch updates the
comment in LayoutObject::IsBlendingAllowed and adds a web platform test
(all browsers should pass this already). This removes the TODO added in
https://chromium-review.googlesource.com/c/chromium/src/+/1169624.
Change-Id: Ie74fd48075ae377636cb3efe93dd2fa6896fc534
Reviewed-on: https://chromium-review.googlesource.com/c/1303954
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603379}
--
wpt-commits: 66aabf66f58aee669c26df6e67f85fbc6d3aaf9f
wpt-pr: 13752
Automatic update from web-platform-tests[LayoutNG] Rebaseline fast/writing-mode/border-image-vertical-lr.html
fast/writing-mode/border-image-vertical-lr.html produces
different results because, in legacy, block direction borders
applied to inline boxes affect positioning of the line box in
vertical-lr writing-mode, when they should not.
This patch rebaselines it, and also adds a minimized test to
check such borders do not affect line box positioning.
Gecko, and WebKit fail the test. Edge passes this test,
though it paints the border at the incorrect position.
Testing the border positoin is not ref-testable and that it
is not included.
Bug: 636993
Change-Id: I2568d19dac7f7ea886a46d45620bc22feb172c53
Reviewed-on: https://chromium-review.googlesource.com/c/1301698
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603051}
--
wpt-commits: f6708be2927871d1f19543f6e7e5531721433bfd
wpt-pr: 13732
Automatic update from web-platform-testsAvoid the use of `readlink -f` in shell scripts (#13639)
This doesn't work on macOS. Replacement taken from:
https://serverfault.com/a/406371
--
wpt-commits: 2836eb26641c99285b5d4e441b614325ec86d8ca
wpt-pr: 13639
Automatic update from web-platform-testsUpdate mozrunner from 7.1.0 to 7.2.0 (#13708)
--
wpt-commits: 904e0e229d5aac656c356a3432e5822aa2690150
wpt-pr: 13708
Automatic update from web-platform-testsUpdate mozdebug from 0.1 to 0.1.1 (#13707)
--
wpt-commits: e45b651d2b0a4d0b8f239723b8bb9836ad18d9a5
wpt-pr: 13707
Automatic update from web-platform-testsUpdate mozprofile from 2.0.0 to 2.1.0 (#13700)
--
wpt-commits: 2e05acd3f2da01b6bf08fb4f1adee3bed06e5ccf
wpt-pr: 13700
Automatic update from web-platform-testsUpdate scroll-padding initial values in wpt tests.
There was a conflict in the scroll snap spec for the initial values of
scroll-padding-top/bottom/left/right[1]. Some of the initial values were
auto, while others were 0px. Now the conflict has been resolved with
all the initial values set to auto[2], we should update the wpt test to
reflect that.
The current implementation in Blink already reflects the updated spec,
so this patch also removes the expectations that were simply for the
failures.
[1] https://github.com/w3c/csswg-drafts/issues/3189
[2]
https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-padding-top
Bug: 891954
Change-Id: Ib9c2280590091be27127abeee0a611b687cd37a2
Reviewed-on: https://chromium-review.googlesource.com/c/1299605
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602929}
--
wpt-commits: f5832ccdb3c303d03565d391ed7ce3bf9719f5c1
wpt-pr: 13726
Automatic update from web-platform-testsUpdating tests for Window onerror is not triggered bug fix.
Chromium starts propagating errors from worker's onerror to window's onerror
after https://chromium-review.googlesource.com/c/chromium/src/+/1287208,
resulting in test failures for mixed-content/module-data-worker-import
tests that do not account for the thrown exception being sent to the window.
This CL adds preventDefault() to the worker.onerror() to handle the case of
uncaught exceptions.
Strictly speaking, this is not necessary according to the current spec, as
"worker's error event" fired at Step 12.1 of #run-a-worker
https://html.spec.whatwg.org/multipage/workers.html#run-a-worker
does not cause "report the error" and thus window's onerror.
But whether window.onerror is fired or not is not what the mixed-content tests
aim to test.
Change-Id: I571aaa85d90b5f933b6212691dcc783579b294be
Reviewed-on: https://chromium-review.googlesource.com/c/1294535
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602207}
--
wpt-commits: 7da2537be5ac9af69065b478cc30b1c1f410d024
wpt-pr: 13666
Automatic update from web-platform-testsInsert an error message block when parsing was stopped after an error
The <parsererror> element was not being added to the parsed document in
certain cases involving attribute parsing. For example, if an undeclared
namespace prefix was used in the document, then parsing would stop, but
a <parsererror> element would not be inserted into the document to
indicate that a parsing error occurred.
When XMLDocumentParser::StopParsing() is called to stop parsing, call
InsertErrorMessageBlock() to insert the <parsererror> element if an
error occurred.
Based on https://codereview.chromium.org/771493002/ by dtrebbien@gmail.com
Bug: 295809, 898775
Change-Id: Ic67a3ab885fae4b01ca92f6d927b3f523f7423ed
Reviewed-on: https://chromium-review.googlesource.com/c/1224791
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602674}
--
wpt-commits: f10f0251a051a0aff6f7b5d15e0c821d173ae837
wpt-pr: 12989
Anders Hartvoll Ruud
Philip Jägenstedt
L. David Baron
Hiroki Nakagawa
Eric Willigers
Michael Howell
Ms2ger
Simon Pieters
moz-wptsync-bot
Eric Willigers
Morten Stenshorne
Sami Kyostila
Luke Bjerring
François Beaufort
Marcos Cáceres
Philip Rogers
Zirro
Michael[tm] Smith
Koji Ishii
pyup.io bot
Sandra Sun
Katie Dillon
Reza.Zakerinasab
Emircan Uysaler
Fredrik Söderquist
autofoolip