77fe9db976
Bug 493683 part 2: When an Accessible mutates, fire name change events on an Accessible labelled by it (or an ancestor thereof) via a relation. r=eeejay
...
HasNameDependent is now set on an Accessible (and thus its descendants) which has A LABEL_FOR relation.
When text mutations occur on such an Accessible, EventQueue::PushNameChange now queues a name change for the Accessible being labelled.
Differential Revision: https://phabricator.services.mozilla.com/D102677
2021-01-27 00:34:21 +00:00
1af2138c00
Bug 493683 part 1: Rename HasNameDependentParent to HasNameDependent due to upcoming broader usage. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102676
2021-01-25 00:39:39 +00:00
92f8f50dd8
Bug 1688680 - Don't include AXTextStateSync in read-only collapsed text selection events. r=morgan.
...
Differential Revision: https://phabricator.services.mozilla.com/D102948
2021-01-25 17:58:52 +00:00
0921a6cd36
Bug 1688938 - Uncomment state change tests. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D103076
2021-01-26 19:26:29 +00:00
81befd069d
Bug 1686832 - Cache MULTI_LINE in mozAccessible. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D101842
2021-01-22 20:42:26 +00:00
079775e780
Bug 1656107 - remove FindContentForSubDocument use from NotificationController. r=farre
...
Differential Revision: https://phabricator.services.mozilla.com/D98613
2021-01-21 00:46:15 +00:00
b41a2b9d21
Bug 1687239 part 2 - Remove plugin support from layout/. r=emilio
...
Note that there's still a little plugin related code in
widget/ and gfx/ etc after this. That can be removed
once we remove plugin support from dom/ etc.
The removal from layout/ should be pretty complete though.
Differential Revision: https://phabricator.services.mozilla.com/D102140
2021-01-25 11:53:49 +00:00
334efb391e
Bug 1687239 part 1 - Remove plugin tests from layout/, dom/ and accessible/. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D102139
2021-01-25 11:53:31 +00:00
7dc8c1a190
Bug 1686238: Only attempt to traverse containers menu if containers are enabled and defined r=yzen
...
Differential Revision: https://phabricator.services.mozilla.com/D102799
2021-01-22 21:02:50 +00:00
135c36619d
Bug 1686995 - Add AXTextSelectionDirection and AXTextSelectionGranularity to text selection events. r=morgan
...
.. and also add AXTextSelectionChangedFocus and AXTextStateSync when needed.
Differential Revision: https://phabricator.services.mozilla.com/D102509
2021-01-22 21:12:56 +00:00
09060aa168
Bug 1686164: Implement ignoreWithParent for context menu items and submenus. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101652
2021-01-21 19:58:13 +00:00
57732c3083
Bug 1687535: Give several LazyInstantiator functions fast paths that avoid a11y instantiation. r=Jamie
...
This prevents us from instantiating accessibility (and incurring a significant performance cost later in the runtime) when we already know the answers a caller will receive if a11y were instantiated.
Differential Revision: https://phabricator.services.mozilla.com/D102371
2021-01-21 17:19:47 +00:00
ff8e5cb389
Backed out changeset 2860943a09a3 (bug 1686164) for build bustages at mozSelectableElements.mm. CLOSED TREE
2021-01-21 10:58:18 +02:00
fdab0ce3d7
Bug 1686164: Implement ignoreWithParent for context menu items and submenus. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101652
2021-01-21 08:42:02 +00:00
9ed618367f
Bug 1667998 - skip some accessible related browser-chrome tests when running a11y-checks. r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D100841
2021-01-15 21:51:50 +00:00
a6e8d4aaa9
Bug 1667998 - converted calls to EventUtils.sendMouseEvent to be async. r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D97323
2021-01-15 18:20:44 +00:00
477b1bc69a
Backed out changeset ea36fa2936a2 (bug 1686164) for causing failures on test_controls.html. CLOSED TREE
2021-01-20 08:43:35 +02:00
1baf91ec07
Bug 1686164: Implement ignoreWithParent for context menu items and submenus. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101652
2021-01-19 22:04:52 +00:00
03c0b5f0e4
Bug 1669748: Null check the document IAccessibles sent for OOP iframes. r=yzen
...
The COM proxy for a DocAccessibleParent at the top level in its content process really should never be null.
However, some systems seem to have a broken COM configuration which causes problems like this.
This does mean a11y is broken, but users who get a11y enabled because of something other than an AT (e.g. touch screen) probably aren't even aware.
Regardless, we shouldn't crash.
Instead, we assert (in debug builds) and null check.
Differential Revision: https://phabricator.services.mozilla.com/D102129
2021-01-19 19:30:57 +00:00
720902efa2
Bug 1686839 - Apply MustPrune dynamically and not at creation time. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D101853
2021-01-19 17:15:05 +00:00
eede5be7ec
Bug 1687480 - Fire NSAccessibility notifications for expanding and collapsing rows, r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D102308
2021-01-19 16:53:38 +00:00
09c48de881
Bug 1686827 - GeckoTextMarker is lesser than if child's offset is greater or equal. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D101835
2021-01-15 19:18:46 +00:00
a5ce58cf1a
Bug 1625953 - P2: Introduce support for aria-controls and aria-flowto in mac. r=morgan
...
This is via AXARIAControls and AXLinkedUIElements respectively.
Differential Revision: https://phabricator.services.mozilla.com/D101085
2021-01-15 17:22:56 +00:00
515ee847be
Bug 1625953 - P1: Introduce getRelationsByType for mozAccessible. r=morgan
...
A small refactor to make all of the relations getting easier.
Differential Revision: https://phabricator.services.mozilla.com/D101084
2021-01-15 17:22:49 +00:00
8ad2a18a79
Backed out 5 changesets (bug 1667998) for breaking a11y checks CLOSED TREE
...
Backed out changeset 633dda979b22 (bug 1667998)
Backed out changeset c9838cdb1303 (bug 1667998)
Backed out changeset 501c54cf59be (bug 1667998)
Backed out changeset 615b74c822ec (bug 1667998)
Backed out changeset 6d187c01fcb3 (bug 1667998)
2021-01-15 20:16:06 +02:00
3b3d85b83e
Bug 1667998 - skip some accessible related browser-chrome tests when running a11y-checks. r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D100841
2021-01-15 16:54:20 +00:00
33ccace61e
Bug 1667998 - converted calls to EventUtils.sendMouseEvent to be async. r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D97323
2021-01-15 16:53:43 +00:00
9e9b090ec4
Backed out 2 changesets (bug 1625953) for Eslint failure
...
Backed out changeset 33fa80e826a8 (bug 1625953)
Backed out changeset 36da5d89bc8a (bug 1625953)
2021-01-15 06:37:54 +02:00
0c9ddcad81
Bug 1625953 - P2: Introduce support for aria-controls and aria-flowto in mac. r=morgan
...
This is via AXARIAControls and AXLinkedUIElements respectively.
Depends on D101084
Differential Revision: https://phabricator.services.mozilla.com/D101085
2021-01-08 00:22:25 +00:00
1dcdfb0a26
Bug 1625953 - P1: Introduce getRelationsByType for mozAccessible. r=morgan
...
A small refactor to make all of the relations getting easier.
Differential Revision: https://phabricator.services.mozilla.com/D101084
2021-01-08 00:19:04 +00:00
da5cf09b14
Bug 1623286: Fire offscreen state change a11y events when a XUL tab panel is switched. r=eeejay
...
Without this, the AT-SPI cache isn't updated and Orca mouse review fails after switching tabs.
Differential Revision: https://phabricator.services.mozilla.com/D101428
2021-01-14 17:56:59 +00:00
0646b214b4
Bug 1359482: Don't expose the editable state on ARIA grids and gridcells. r=eeejay
...
The editable state is about navigable text (with a caret), not editable as in "not read only".
ATs don't want this exposed for grids and it causes problems for them.
They can (and already do) distinguish between gridcell and cell using xml-roles.
Differential Revision: https://phabricator.services.mozilla.com/D101707
2021-01-15 01:32:13 +00:00
1b5b46ec79
Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs,marionette-reviewers,whimboo,remote-protocol-reviewers
...
Depends on D100172
Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-14 21:45:14 +00:00
e3097163dd
Bug 1597437 - Handle 'window.content' legacy getter better with Fission, r=farre,Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D100167
2020-12-21 12:08:08 +00:00
7742c03714
Backed out 4 changesets (bug 1680637, bug 1682395) for causing Marionette failures. CLOSED TREE
...
Backed out changeset 073e0be7db95 (bug 1680637)
Backed out changeset 552b91b31b0f (bug 1682395)
Backed out changeset c80de6c72779 (bug 1680637)
Backed out changeset d513e228b0ad (bug 1680637)
2021-01-13 02:13:06 +02:00
06e7942185
Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs
...
Depends on D100172
Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-12 22:32:24 +00:00
c19d6d89b4
Bug 1682865: Map roles::EDITCOMBOBOX to mozTextAccessible r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101407
2021-01-11 22:04:13 +00:00
36e53a5e88
Bug 1685623: Account for search engine initialization race r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101098
2021-01-11 22:04:49 +00:00
c2f1413e6b
Bug 1685078 - Support full <image> syntax in list-style-image as per spec. r=jrmuizel,TYLin
...
This allows supporting image-set(), etc, and simplifies the bullet frame
code significantly, too thanks to two changes:
* Instead of manually managing the image request, use the CSS image
loader, with the `REQUEST_REQUIRES_REFLOW` flag, to handle image
loads correctly. This didn't exist when this code was initially
implemented, but we can nicely use it now.
* Instead of re-implementing another WebRender command-builder thing,
we can just reuse the nsImageRenderer code.
Differential Revision: https://phabricator.services.mozilla.com/D100774
2021-01-08 09:44:24 +00:00
2bc463ad54
Bug 1681292: Ensure menu items correctly expose AXVisibleChildren and AXChildren r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D99949
2021-01-07 21:33:21 +00:00
29a8164b84
Bug 1680589: Make AXDisclosing settable on outline rows r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101053
2021-01-07 21:29:27 +00:00
18e3c81cf5
Bug 1684896 - For the static NSDictionary MacSelectorMap objects, use function-local statics rather than globals. r=morgan
...
This means that the NSDictionaries will be constructed the first time the
wrapper function is called, and not at C++ static initializer time.
This avoids false positive warnings when running with the environment variables
`OBJC_DEBUG_MISSING_POOLS=YES LIBDISPATCH_DEBUG_MISSING_POOLS=NO`.
Differential Revision: https://phabricator.services.mozilla.com/D100976
2021-01-07 17:53:39 +00:00
c21730a605
Bug 1682985 - Support aria-busy with AXElementBusy and AXElementBusyChanged. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D100838
2021-01-06 17:23:45 +00:00
7ae6aea145
Bug 1684173 - Add newline character at end of files when missing r=sylvestre,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D100484
2021-01-07 08:53:08 +00:00
7d7078d54e
Backed out changeset 47c73e5e08a4 (bug 1685078) for multiple failures related to CSS. CLOSED TREE
2021-01-07 10:44:10 +02:00
b58ddc19df
Bug 1519636 - Reformat recent changes to the Google coding style r=andi
...
Updated with Debian clang-format version 11.0.1-1
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D100934
2021-01-06 17:17:23 +00:00
9fbf3695e7
Bug 1685078 - Support full <image> syntax in list-style-image as per spec. r=jrmuizel,TYLin
...
This allows supporting image-set(), etc, and simplifies the bullet frame
code significantly, too thanks to two changes:
* Instead of manually managing the image request, use the CSS image
loader, with the `REQUEST_REQUIRES_REFLOW` flag, to handle image
loads correctly. This didn't exist when this code was initially
implemented, but we can nicely use it now.
* Instead of re-implementing another WebRender command-builder thing,
we can just reuse the nsImageRenderer code.
Differential Revision: https://phabricator.services.mozilla.com/D100774
2021-01-07 04:15:01 +00:00
5cd8830a74
Bug 1683723 - Replace deprecated Cocoa enum constants with their modern replacements. r=spohl
...
I ran the following command:
```
rg -l 'NSAlphaShiftKeyMask' . | xargs sed -i '' -e 's/NSAlphaShiftKeyMask/NSEventModifierFlagCapsLock/g'
rg -l 'NSAlternateKeyMask' . | xargs sed -i '' -e 's/NSAlternateKeyMask/NSEventModifierFlagOption/g'
rg -l 'NSAnyEventMask' . | xargs sed -i '' -e 's/NSAnyEventMask/NSEventMaskAny/g'
rg -l 'NSApplicationDefined' . | xargs sed -i '' -e 's/NSApplicationDefined/NSEventTypeApplicationDefined/g'
rg -l 'NSBorderlessWindowMask' . | xargs sed -i '' -e 's/NSBorderlessWindowMask/NSWindowStyleMaskBorderless/g'
rg -l 'NSCenterTextAlignment' . | xargs sed -i '' -e 's/NSCenterTextAlignment/NSTextAlignmentCenter/g'
rg -l 'NSClosableWindowMask' . | xargs sed -i '' -e 's/NSClosableWindowMask/NSWindowStyleMaskClosable/g'
rg -l 'NSCommandKeyMask' . | xargs sed -i '' -e 's/NSCommandKeyMask/NSEventModifierFlagCommand/g'
rg -l 'NSCompositeCopy' . | xargs sed -i '' -e 's/NSCompositeCopy/NSCompositingOperationCopy/g'
rg -l 'NSControlKeyMask' . | xargs sed -i '' -e 's/NSControlKeyMask/NSEventModifierFlagControl/g'
rg -l 'NSDeviceIndependentModifierFlagsMask' . | xargs sed -i '' -e 's/NSDeviceIndependentModifierFlagsMask/NSEventModifierFlagDeviceIndependentFlagsMask/g'
rg -l 'NSFlagsChanged' . | xargs sed -i '' -e 's/NSFlagsChanged/NSEventTypeFlagsChanged/g'
rg -l 'NSFullScreenWindowMask' . | xargs sed -i '' -e 's/NSFullScreenWindowMask/NSWindowStyleMaskFullScreen/g'
rg -l 'NSFullSizeContentViewWindowMask' . | xargs sed -i '' -e 's/NSFullSizeContentViewWindowMask/NSWindowStyleMaskFullSizeContentView/g'
rg -l 'NSFunctionKeyMask' . | xargs sed -i '' -e 's/NSFunctionKeyMask/NSEventModifierFlagFunction/g'
rg -l 'NSHelpKeyMask' . | xargs sed -i '' -e 's/NSHelpKeyMask/NSEventModifierFlagHelp/g'
rg -l 'NSKeyDown' . | xargs sed -i '' -e 's/NSKeyDown/NSEventTypeKeyDown/g'
rg -l 'NSKeyUp' . | xargs sed -i '' -e 's/NSKeyUp/NSEventTypeKeyUp/g'
rg -l 'NSLeftMouseDownMask' . | xargs sed -i '' -e 's/NSLeftMouseDownMask/NSEventMaskLeftMouseDown/g'
rg -l 'NSLeftMouseDown' . | xargs sed -i '' -e 's/NSLeftMouseDown/NSEventTypeLeftMouseDown/g'
rg -l 'NSLeftMouseDragged' . | xargs sed -i '' -e 's/NSLeftMouseDragged/NSEventTypeLeftMouseDragged/g'
rg -l 'NSLeftMouseUp' . | xargs sed -i '' -e 's/NSLeftMouseUp/NSEventTypeLeftMouseUp/g'
rg -l 'NSMiniaturizableWindowMask' . | xargs sed -i '' -e 's/NSMiniaturizableWindowMask/NSWindowStyleMaskMiniaturizable/g'
rg -l 'NSMiniControlSize' . | xargs sed -i '' -e 's/NSMiniControlSize/NSControlSizeMini/g'
rg -l 'NSMouseEntered' . | xargs sed -i '' -e 's/NSMouseEntered/NSEventTypeMouseEntered/g'
rg -l 'NSMouseExited' . | xargs sed -i '' -e 's/NSMouseExited/NSEventTypeMouseExited/g'
rg -l 'NSMouseMoved' . | xargs sed -i '' -e 's/NSMouseMoved/NSEventTypeMouseMoved/g'
rg -l 'NSNumericPadKeyMask' . | xargs sed -i '' -e 's/NSNumericPadKeyMask/NSEventModifierFlagNumericPad/g'
rg -l 'NSOtherMouseDownMask' . | xargs sed -i '' -e 's/NSOtherMouseDownMask/NSEventMaskOtherMouseDown/g'
rg -l 'NSOtherMouseDown' . | xargs sed -i '' -e 's/NSOtherMouseDown/NSEventTypeOtherMouseDown/g'
rg -l 'NSOtherMouseDragged' . | xargs sed -i '' -e 's/NSOtherMouseDragged/NSEventTypeOtherMouseDragged/g'
rg -l 'NSOtherMouseUp' . | xargs sed -i '' -e 's/NSOtherMouseUp/NSEventTypeOtherMouseUp/g'
rg -l 'NSRegularControlSize' . | xargs sed -i '' -e 's/NSRegularControlSize/NSControlSizeRegular/g'
rg -l 'NSResizableWindowMask' . | xargs sed -i '' -e 's/NSResizableWindowMask/NSWindowStyleMaskResizable/g'
rg -l 'NSRightMouseDown' . | xargs sed -i '' -e 's/NSRightMouseDown/NSEventTypeRightMouseDown/g'
rg -l 'NSRightMouseDragged' . | xargs sed -i '' -e 's/NSRightMouseDragged/NSEventTypeRightMouseDragged/g'
rg -l 'NSRightMouseUp' . | xargs sed -i '' -e 's/NSRightMouseUp/NSEventTypeRightMouseUp/g'
rg -l 'NSRightTextAlignment' . | xargs sed -i '' -e 's/NSRightTextAlignment/NSTextAlignmentRight/g'
rg -l 'NSScrollWheelMask' . | xargs sed -i '' -e 's/NSScrollWheelMask/NSEventMaskScrollWheel/g'
rg -l 'NSScrollWheel' . | xargs sed -i '' -e 's/NSScrollWheel/NSEventTypeScrollWheel/g'
rg -l 'NSShiftKeyMask' . | xargs sed -i '' -e 's/NSShiftKeyMask/NSEventModifierFlagShift/g'
rg -l 'NSSmallControlSize' . | xargs sed -i '' -e 's/NSSmallControlSize/NSControlSizeSmall/g'
rg -l 'NSTabletPointEventSubtype' . | xargs sed -i '' -e 's/NSTabletPointEventSubtype/NSEventSubtypeTabletPoint/g'
rg -l 'NSTitledWindowMask' . | xargs sed -i '' -e 's/NSTitledWindowMask/NSWindowStyleMaskTitled/g'
```
Then I removed changes to third-party webrtc code, removed a comment in accessible/mac/mozAccessible.mm,
and performed some manual replacements in native_mouse_mac_window.xhtml.
Differential Revision: https://phabricator.services.mozilla.com/D100260
2021-01-05 21:17:11 +00:00
9e19999a57
Bug 1681909 - P3: Implement e10s post search filter and test. r=morgan
...
The test adds fission testing as well.
Differential Revision: https://phabricator.services.mozilla.com/D100732
2021-01-05 20:35:37 +00:00
4537ab3655
Bug 1681909 - P2: Implement post filter for non-e10s case. r=morgan
...
Introducing this as a separate patch to simplify this changeset and first introduce a straightforward-ish implementation.
Differential Revision: https://phabricator.services.mozilla.com/D100731
2021-01-05 20:35:35 +00:00
James Teh
Eitan Isaacson
Steven MacLeod
Mats Palmgren
Morgan Reschenberg
Bas Schouten
Brindusan Cristian
Yura Zenevich
Butkovits Atila
Marco Zehe
Noemi Erli
Dorel Luca
Micah Tigley
Nika Layzell
Emilio Cobos Álvarez
Markus Stange
Kartik Gautam
Sylvestre Ledru