Граф коммитов

8912 Коммитов

Автор SHA1 Сообщение Дата
Mitchell Hentges df45b126d1 Bug 1698616: Bump python dependencies r=firefox-build-system-reviewers,glandium
Did you know that our version of requests was from 2015? Phwoar!
This bumps `jinja2`, `py`, `pyyaml`, `requests` and `urllib3`.
There's significant risk for regressions due to breaking changes,
though due to the dynamic nature of Python, they're tricky to track
down.

The potential breaking changes I'm expecting to potentially affect
us are:

* `requests@2.11.0`: No longer accepts non-strings as header values.
* `requests@2.16.0`: `requests.packages` namespace was removed due to
  packages no longer being vendored. The namespace has been
  incrementally restored over future releases, but it's unclear to
  what degree.
* `requests@2.24.0`: Redirect resolution now only happens when
  `allow_redirects` is `True`.
* `requests` version of `urllib3` was bumped from `1.13.1` to `1.26`,
  unsure what repercussions that will have.

This also added dependencies to `flake8_requirements`. This is because
the vendored `importlib-metadata` update (and the new
`typing-extensions` dependency) is found by `pip`, but the
vendored `typing-extensions` is _not_ discovered (perhaps due to
details around "eggs" and the way we add vendored code to the sys.path).
So, `pip` tries to install it manually and fails when it finds no hash.
By re-compiling `flake8_requirements`, the necessary hashes are made
available.

Differential Revision: https://phabricator.services.mozilla.com/D108526
2021-05-04 20:43:26 +00:00
Calixte Denizet 11d5119f80 Bug 1541224 - Avoid to use uninitialized handle when flushing ccov counters r=marco
Counters can be flushed before init has been called so this patch add a condition in FlushCounters to be sure that everything has been initialized.

Differential Revision: https://phabricator.services.mozilla.com/D110575
2021-05-04 16:02:49 +00:00
Mike Hommey c43f8a0984 Bug 1708935 - Don't run clippy on crates that don't build on Linux. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D114210
2021-05-04 09:31:12 +00:00
Glenn Watson 7947bc10f1 Bug 1706824 - Remove old direct-composition example. r=gfx-reviewers,lsalzman
This was an old example / proof of concept of directly drawing
to a DirectComposition surface.

We now have the example-compositor/ project that shows how to
integrate with DirectComposition on Windows and Wayland on
Linux, in addition to a shipping implementation in Gecko for
CoreAnimation and DirectComposition.

Differential Revision: https://phabricator.services.mozilla.com/D113052
2021-05-04 00:32:41 +00:00
Mike Hommey fb2daa993e Bug 1708592 - Install clang-format via a toolchain artifact. r=sylvestre
(Drive-by) Similar to what we just did for rustfmt and clippy.

Differential Revision: https://phabricator.services.mozilla.com/D113906
2021-04-30 21:09:12 +00:00
Mike Hommey dc5646ba96 Bug 1708592 - Install rustfmt and clippy via a toolchain artifact. r=sylvestre
This will tie the version used for CI lints to the version of rust used
for builds on CI.

Bonus point: we can now have rustfmt and clippy on Windows and mac,
which allows to run the corresponding mozlint unit tests on those
platforms.

Differential Revision: https://phabricator.services.mozilla.com/D113905
2021-04-30 21:09:12 +00:00
Mike Hommey c2a87c9b07 Bug 1708592 - Normalize paths when filtering in clippy and rustfmt lints. r=sylvestre
Without normalization, the paths don't match the filters on Windows.

Differential Revision: https://phabricator.services.mozilla.com/D113904
2021-04-30 21:09:12 +00:00
Mike Hommey f2dcdd5390 Bug 1708592 - Get tools from MOZ_FETCHES_DIR on automation. r=firefox-build-system-reviewers,mhentges
While here, remove the unused clippyProcess.config. And because we need
to manipulate `$PATH` before running `cargo`, use the same wrapping
function in `get_clippy_version`.

Differential Revision: https://phabricator.services.mozilla.com/D113902
2021-04-30 21:09:11 +00:00
Mike Hommey 8a7d4ba4d9 Bug 1708591 - Disable test_eslint.py on Windows. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D113895
2021-04-30 08:12:31 +00:00
Valentin Gosu 9e4bdb9c25 Bug 1694662 - Remove old cache implementation r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D106456
2021-04-30 07:20:24 +00:00
Valentin Gosu 5c900317ff Bug 1694662 - Remove OfflineAppCacheHelper r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D106445
2021-04-30 07:20:20 +00:00
Valentin Gosu 5aa53ddea9 Bug 1694662 - Remove OfflineCache update logic r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D106443
2021-04-30 07:20:19 +00:00
Andrew Halberstadt 730d952a79 Bug 1708293 - [lint] Add a linter to prefer multiline skip-if statements in test manifests, r=releng-reviewers,jmaher
This will warn if someone includes something like:

    skip-if = <condition A> || <condition B>  # reason A is skipped; reason B is skipped

Instead they should use:

    skip-if =
        <condition A>  # reason A is skipped
        <condition B>  # reason B is skipped

Differential Revision: https://phabricator.services.mozilla.com/D113707
2021-04-29 18:38:59 +00:00
Florian Quèze 3e63d9143b Bug 1635442 - Only initialize LUL when the StackWalk feature is requested on Linux, r=gerald.
Differential Revision: https://phabricator.services.mozilla.com/D113693
2021-04-29 15:27:26 +00:00
Alexandru Michis 335b6f5f96 Backed out changeset 6bd7baadb78c (bug 1702086) for causing Bug 1607574.
CLOSED TREE
2021-04-28 23:23:01 +03:00
Andi-Bogdan Postelnicu 6666ac0af8 Bug 1696180 - Update Clang based static analysis to clang 12. r=firefox-build-system-reviewers,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D113330
2021-04-28 09:56:13 +00:00
Myeongjun Go a4c2f8da8d Bug 1698567 - [perfdocs] Provide a way to link directly to individual Raptor tests r=sparky,perftest-reviewers,firefox-source-docs-reviewers,ahal
Differential Revision: https://phabricator.services.mozilla.com/D110779
2021-04-27 18:19:03 +00:00
Joel Maher ff43e8acc0 Bug 1577013 - turn off reftest-gpu jobs as they are not testing what they intend to and are being deprecated in the short term. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D112091
2021-04-27 15:32:46 +00:00
Gerald Squelart a354af1934 Bug 1707537 - Make ChildProfilerController::mThread thread-safe, and reset it before final dispatch and shutdown, to prevent re-entrancy - r=florian
Bug 1613798 (shutdown crashes during ChildProfilerController::ShutdownAndMaybeGrabShutdownProfileFirst's nsThread::Shutdown) could be explained by another nested shutdown destroying the same thread first, so when coming back to the first inner loop, there's a UAF on the already-destroyed thread!

Now we first reset the `mThread` pointer so it cannot be used by later/nested function calls, but keep a local reference (which should be the last one) to dispatch the shutdown operations and then shutdown the thread itself.

Also the thread pointer is now encapsulated in a DataMutex, in case it is accessed from different threads (e.g., the main thread and the IPC reception thread.)

Differential Revision: https://phabricator.services.mozilla.com/D113304
2021-04-26 23:17:02 +00:00
Steve Fink a45b73b47e Bug 1702310 - Add --gecko-profile-features and similar options to `mach try fuzzy` and `mach raptor` etc. to make it easier to generate marker-only profiles, configure threads and sampling interval, etc. r=perftest-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D110451
2021-04-26 21:59:29 +00:00
Sylvestre Ledru 5af4ac8850 Bug 1702922 - mozlint/clippy: Adjust the tests with the new version of clippy r=linter-reviewers,marco DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D113286
2021-04-26 09:12:24 +00:00
Sylvestre Ledru 518cfdaa66 Bug 1702922 - mozlint/clippy: Set the minimal version of clippy to 2021.03.23 r=linter-reviewers,marco DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D113285
2021-04-26 09:12:24 +00:00
Butkovits Atila 2e34e363b9 Backed out 2 changesets (bug 1696251) for causing js-bench-sm failures. CLOSED TREE
Backed out changeset 1c84c9a34575 (bug 1696251)
Backed out changeset e169193b7423 (bug 1696251)
2021-04-23 02:53:36 +03:00
Alex Lopez 41687360e8 Bug 1696251 - Turn all properties in MachCommandBase subclasses into methods. r=mhentges,perftest-reviewers,sparky
As a step towards moving mach commands outside of classes, this converts all
properties into methods so that they can later become top-level helper functions.

Differential Revision: https://phabricator.services.mozilla.com/D112196
2021-04-22 19:44:52 +00:00
Alex Lopez d1a82b8092 Bug 1696251 - Pass MachCommandBase object as first argument for Mach Commands. r=mhentges,remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers
As an intermediate step to allow mach commands as standalone functions, the MachCommandBase
subclass instance that currently corresponds to self has to be made available as a separate
argument (named command_context).

Differential Revision: https://phabricator.services.mozilla.com/D109650
2021-04-22 18:56:15 +00:00
Dave Townsend 30b4f94dd3 Bug 1700972: Remove profile-per-install onboarding UI. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D112292
2021-04-21 20:06:31 +00:00
Myeongjun Go 5870ecd14e Bug 1691558 - Using an escape character to find the exact path r=sparky
Differential Revision: https://phabricator.services.mozilla.com/D112182
2021-04-21 19:24:06 +00:00
imoraru 63d199a7e6 Backed out changeset b413fce77522 (bug 1698616) for breaking mach commands (bug 1706456). a=backout 2021-04-21 14:16:08 +03:00
Mitchell Hentges 73f81b1c85 Bug 1698616: Bump python dependencies r=firefox-build-system-reviewers,glandium
Did you know that our version of requests was from 2015? Phwoar!
This bumps `jinja2`, `py`, `pyyaml`, `requests` and `urllib3`.
There's significant risk for regressions due to breaking changes,
though due to the dynamic nature of Python, they're tricky to track
down.

The potential breaking changes I'm expecting to potentially affect
us are:

* `requests@2.11.0`: No longer accepts non-strings as header values.
* `requests@2.16.0`: `requests.packages` namespace was removed due to
  packages no longer being vendored. The namespace has been
  incrementally restored over future releases, but it's unclear to
  what degree.
* `requests@2.24.0`: Redirect resolution now only happens when
  `allow_redirects` is `True`.
* `requests` version of `urllib3` was bumped from `1.13.1` to `1.26`,
  unsure what repercussions that will have.

This also added dependencies to `flake8_requirements`. This is because
the vendored `importlib-metadata` update (and the new
`typing-extensions` dependency) is found by `pip`, but the
vendored `typing-extensions` is _not_ discovered (perhaps due to
details around "eggs" and the way we add vendored code to the sys.path).
So, `pip` tries to install it manually and fails when it finds no hash.
By re-compiling `flake8_requirements`, the necessary hashes are made
available.

Differential Revision: https://phabricator.services.mozilla.com/D108526
2021-04-20 13:57:47 +00:00
Florian Quèze 1362e81ad5 Bug 1706097 - AUTO_PROFILER_LABEL_DYNAMIC_NSCSTRING_NONSENSITIVE should record BHR label frames even when the profiler is not running, r=gerald.
Differential Revision: https://phabricator.services.mozilla.com/D112630
2021-04-20 09:32:13 +00:00
Cosmin Sabou 785f9b8a87 Backed out changeset d4a5d8567977 (bug 1696251) for non-unified build bustages. CLOSED TREE 2021-04-19 19:43:31 +03:00
Alex Lopez 75dfe35468 Bug 1696251 - Pass MachCommandBase object as first argument for Mach Commands. r=mhentges,remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers
As an intermediate step to allow mach commands as standalone functions, the MachCommandBase
subclass instance that currently corresponds to self has to be made available as a separate
argument (named command_context).

Differential Revision: https://phabricator.services.mozilla.com/D109650
2021-04-19 16:15:11 +00:00
Steve Fink df6f52ac53 Bug 1697929 - Create a breakpad injector toolchain build. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D109504
2021-04-19 14:21:42 +00:00
Mark Banner e6bcef6070 Bug 1556460 - Upgrade jsdoc version to 3.6.6. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D112345
2021-04-16 16:17:26 +00:00
Mark Banner 1e592fa0f9 Bug 1704857 - Bump eslint-plugin-mozilla version numbers. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D111895
2021-04-16 16:17:26 +00:00
Gerald Squelart d66c075c59 Bug 1704680 - Annotate crash reports when child-process profiler shuts down - r=canaltinova,gsvelto
This should help investigate bug 1613798.
In particular, this should show if the profiler is taking too long to serialize its profile buffer, or something else is happening afterwards (whether the profiler is running or not).

Differential Revision: https://phabricator.services.mozilla.com/D111786
2021-04-15 22:38:09 +00:00
Mitchell Hentges 9d79c31fbe Bug 1694531: Add docs for quarantined Try builds r=sheehan
Removes irrelevant mercurial-specific information about
pushing to try, adds note about removing the qurantine
attribute from Try builds.

Differential Revision: https://phabricator.services.mozilla.com/D107298
2021-04-14 16:59:47 +00:00
Bogdan Tara 4de76f4cdf Backed out 8 changesets (bug 1696531) for test_dmd.js and test_subprocess.js xpc failures CLOSED TREE
Backed out changeset 907102743c5f (bug 1696531)
Backed out changeset c631966a64c0 (bug 1696531)
Backed out changeset 754ce2bf288a (bug 1696531)
Backed out changeset 7129c9cfe519 (bug 1696531)
Backed out changeset dba2bea61b29 (bug 1696531)
Backed out changeset 33f3e86a5ce8 (bug 1696531)
Backed out changeset 7dcbb17a1578 (bug 1696531)
Backed out changeset 1f982303513f (bug 1696531)
2021-04-14 17:49:29 +03:00
Andrew Halberstadt cc560a87f0 Bug 1696531 - Keep Python 2 compatibility in tools/rb/fix_stacks.py for now, r=bhearsum
This file is also used by some browser-chrome tests which are still Python 2
for now. So let's not drop PY2 compat just yet.

Depends on D109728

Differential Revision: https://phabricator.services.mozilla.com/D111728
2021-04-14 13:54:27 +00:00
Ben Hearsum 42620225bf Bug 1696531: fix dmd.py and related tools to support python 3 r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D109731
2021-04-14 13:54:24 +00:00
Mark Banner dae9d6efad Bug 1498604 - Make './mach doc' use jsdoc installed into node_modules rather than the system. r=mossop,ahal
Differential Revision: https://phabricator.services.mozilla.com/D111652
2021-04-14 13:35:20 +00:00
Alexandru Michis a2ac402751 Backed out changeset 53d4fb9f562f (bug 1498604) for causing doc generate failures.
CLOSED TREE
2021-04-14 02:22:56 +03:00
Mark Banner 6bdee38462 Bug 1498604 - Make './mach doc' use jsdoc installed into node_modules rather than the system. r=mossop,ahal
Differential Revision: https://phabricator.services.mozilla.com/D111652
2021-04-13 19:59:37 +00:00
Paul Zuehlcke 522131845a Bug 1699668 - Tests for shim warning. r=webcompat-reviewers,johannh,denschub
Differential Revision: https://phabricator.services.mozilla.com/D109718
2021-04-13 16:11:21 +00:00
Mike Hommey 9bce63da4f Bug 1704685 - Remove leftover from bug 1686888. r=firefox-build-system-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D111765
2021-04-13 04:57:48 +00:00
Butkovits Atila 3003d0968b Backed out changeset 9079df388206 (bug 1704685) as requested by Glandium. CLOSED TREE 2021-04-13 06:30:15 +03:00
Mike Hommey 14b2bd7ad0 Bug 1704685 - Remove leftover from bug 1686888. r=firefox-build-system-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D111765
2021-04-13 02:52:53 +00:00
Andrew Creskey 4f7b86c141 Bug 1703956 - Extend network perfstats to include all http channel completion times r=necko-reviewers,valentin
Add HttpChannelCompletion, which is just the completion time for any request.
This allows us to measure overall improvements, instead of shifting requests from cache to network via RCWN.

Differential Revision: https://phabricator.services.mozilla.com/D111335
2021-04-12 21:42:21 +00:00
Nisarg 4b18d50091 Bug 1698838 - Create a format command as an alternative to lint --fix. r=ahal
***
Bug 1698838 - Restrict the list of linters to valid formatters r=ahal

***
Bug 1698838 - Abort formatting even if one of the linters passed is invalid r=ahal

***

***

Differential Revision: https://phabricator.services.mozilla.com/D109231
2021-04-12 18:01:14 +00:00
Eugen Sawin a4f82a3dc6 Bug 1691821 - [1.b.5] Adjust build files to support the new autofill component. r=zbraniecki,dimi
Differential Revision: https://phabricator.services.mozilla.com/D110271
2021-04-12 17:33:16 +00:00