The reasons of this patch:
- P9 didn't handle the deletion of deprecated client well. It shouldn't continue
if the client is failed to be removed. This patch correct this behavior.
- Meanwhile, it's not really good to just crash while finding a deprecated
client. At least, the client should be removed while finding it before
crashing the Firefox.
- Besides, if we eventaully only check the deprecated client during the
initialization. It makes the code simpler to make the deprecated check to
InitializeOrigin.
Therefore, this patch is a little bit against the P11, but I think it's a right
thing to do here.
Differential Revision: https://phabricator.services.mozilla.com/D24678
--HG--
extra : moz-landing-system : lando
The previous patches didn't take care of the case there might have an asmjs
folder in the older version. To fix that, this patch makes Client allow to have
asmjs folders in the older version by requesting the callee of TypeFromText()
for passing the current storage version. If the version is lower than the
deprecate version, then the assertion won't be enabled.
The test verfies the fix by adding the older profile an asmjs folder.
Differential Revision: https://phabricator.services.mozilla.com/D24542
--HG--
extra : moz-landing-system : lando
This adds a new quota client implementation, but only implements ShutdownWorkThreads.
At shutdown we wait for all running operations to finish including database actors which are closed by using an extra IPC message which avoids races between the parent and child.
Databases are dropped on the child side as soon as they are not used (e.g. after unlinking by the cycle collector).
This patch is an automatic replacement of s/NS_NOTREACHED/MOZ_ASSERT_UNREACHABLE/. Reindenting long lines and whitespace fixups follow in patch 6b.
MozReview-Commit-ID: 5UQVHElSpCr
--HG--
extra : rebase_source : 4c1b2fc32b269342f07639266b64941e2270e9c4
extra : source : 907543f6eae716f23a6de52b1ffb1c82908d158a
To improve the Firefox 57 to 56 downgrade scenario, have 57 and 58
re-number the version 3.0 schema introduced by bug 1290481 to
version 2.1. Firefox 56's Quota Manager will recognize the minor
schema version and accept the schema from the future.
--HG--
extra : rebase_source : c2458e380966e4f1ec60a6df5f01135231f308fe
extra : source : e895c35e9b4e9dbc6849d40d644af97c028fffcf
Sylvestre Ledru
Jan Varga
Luke Wagner
Tom Tung
Chris Peterson
Andrew Sutherland
Kartikaya Gupta
Ben Turner
Wes Kocher
Andrew McCreight
Andrea Marchesini
Ben Kelly
Ehsan Akhgari