This patch does a few things:
* Fleshes out the launcher process failure ping;
* Sends that ping via pingsender;
* If there is any failure in doing so, we fall back to the Windows event log;
* Any launcher process failures will result in us falling back to the normal
startup code path, ensuring that users will still see a browser.
A sample ping will be attached to the bug.
Differential Revision: https://phabricator.services.mozilla.com/D19697
--HG--
extra : moz-landing-system : lando
Replaced promiseWaitForCondition with TestUtils.waitForCondition. Replaced all occurences of promiseWaitForCondition with TstUtils.waitForCondition, in mozilla-central/browser/base/content/test/general/browser_minimize.js
Differential Revision: https://phabricator.services.mozilla.com/D21036
--HG--
extra : moz-landing-system : lando
When we open firefox with pinned tabs, we first paint a window with
one tab open, and then that tab gets displaced after the pinned tabs
come in. This aims to ensure that our first paint contains the
pinned tab, so that we don't have tabs moving around after first
paint.
MozReview-Commit-ID: GC1y6NlgLTd
Differential Revision: https://phabricator.services.mozilla.com/D18742
--HG--
extra : moz-landing-system : lando
Add a 'View Saved Logins' footer to the password manager autocomplete popup.
Differential Revision: https://phabricator.services.mozilla.com/D19602
--HG--
extra : moz-landing-system : lando
This patch does a few things:
* Fleshes out the launcher process failure ping;
* Sends that ping via pingsender;
* If there is any failure in doing so, we fall back to the Windows event log;
* Any launcher process failures will result in us falling back to the normal
startup code path, ensuring that users will still see a browser.
A sample ping will be attached to the bug.
***
Format cleanup
Differential Revision: https://phabricator.services.mozilla.com/D19697
--HG--
extra : moz-landing-system : lando
however, in the file head.js other functions use BrowserTestUtils instead of TestUtils, so I wasn't sure which of those is the
correct one, so I used the one suggested in the issue.
Differential Revision: https://phabricator.services.mozilla.com/D21011
--HG--
extra : moz-landing-system : lando
This test was failing intermittently in opt and pgo builds because there was a slightly chance that
the test extension may be calling browser.extension.getViews while the popup context was unloading
but it wasn't still destroyed and so it wasn't yet removed from the set of the extension views.
This patch fixes this intermittency by changing the promiseBrowserContentUnloaded test helper to
ensure that the unloadPromise is resolved when the "inner-window-destroyed" message for the
extension window is being notified to the "observer service" listeners, as it is what
the ExtensionPageChild is listening to decide when the ExtensionPageContextChild should be
unloaded and removed from the set of the extension views.
Differential Revision: https://phabricator.services.mozilla.com/D20658
--HG--
extra : moz-landing-system : lando
Summary: Before this change no style for invalid input fields was included in Firefox and thus invalid text fields where not highlighted as invalid as per the Firefox Photon design guide.
Test Plan:
Screenshot: https://hostux.pics/images/2019/01/25/image5123a27cc99ab189.png
# Installed my add-on: https://addons.mozilla.org/firefox/addon/mastodon-simplified-federation/
# Go to settings page and enter some invalid string in the input field.
# Open add-on debugger and inspect that element.
# (important!) Disable my workaround I added. (in options.css), see the screenshot at the top right, where I did this.
# And you can still see the invalid style…
Reviewers: rpl, bwinton
Reviewed By: bwinton
Subscribers: bwinton, caitmuenster
Bug #: 1514567
Differential Revision: https://phabricator.services.mozilla.com/D17558
--HG--
extra : rebase_source : ea0ee02b258f4767164bf6fe76dec0df2d7d8b70
extra : amend_source : 7570445162cbe059171bb73c934d37018fe54a3d
Switch to using DOMFormBeforeSubmit event instead of earlyformsubmit observer notifications.
Differential Revision: https://phabricator.services.mozilla.com/D16656
--HG--
extra : moz-landing-system : lando
Extend ActorChild for satchel's formSubmitListener in order to listen to the event.
Differential Revision: https://phabricator.services.mozilla.com/D16655
--HG--
rename : toolkit/components/satchel/formSubmitListener.js => toolkit/components/satchel/FormSubmitChild.jsm
extra : moz-landing-system : lando
The status regarding whether a page is bookmarked or not is updated async.
While the update is pending, the Bookmark this page button ignores activation.
Thus, the test must wait for the update to be finished before trying to press the button.
This fixes intermittent timeouts in this test.
Differential Revision: https://phabricator.services.mozilla.com/D20978
--HG--
extra : moz-landing-system : lando
We had previously missed to call browser.updateSecurityUIForContentBlockingEvent on
onLocationChange updates, to reset the contentBlockingEvent state. This would mean that
on tab switch the contentBlockingEvent state for benign pages would still be what it was
set to on the last tracker page.
Differential Revision: https://phabricator.services.mozilla.com/D20328
--HG--
extra : moz-landing-system : lando
Switch to using DOMFormBeforeSubmit event instead of earlyformsubmit observer notifications.
Differential Revision: https://phabricator.services.mozilla.com/D16656
--HG--
extra : moz-landing-system : lando
Extend ActorChild for satchel's formSubmitListener in order to listen to the event.
Differential Revision: https://phabricator.services.mozilla.com/D16655
--HG--
rename : toolkit/components/satchel/formSubmitListener.js => toolkit/components/satchel/FormSubmitChild.jsm
extra : moz-landing-system : lando