af6751ef10
Bug 1205533 - Fix and disallow warnings in gfx/qcms/. r=jrmuizel.
...
This patch fixes various warnings from MSVC.
- Several "truncation from 'double' to 'float'" warnings, easily fixed by
appending 'f' to literals.
- Some "signed/unsigned mismatch" warnings. In read_tag_lutType(), MSVC is
apparently promoting the multiplication of a uint8_t and a uint16_t to an
int32_t, oddly enough. A uint32_t cast fixes the warning.
- |offset| was unused in qcms_data_create_rbg_with_gamma().
- A couple of "overflow in floating-point constant arithmetic" warnings
involving INFINITY in transform_util.c. There is some type confusion here --
in C99 HUGE_VAL is a double and INFINITY is a float. So the HUGE_VAL here
should actualy be HUGE_VALF. But, strangely enough, that isn't enough to
avoid the warning, I don't know why. However, it turns out that any
non-positive value for |interval| will have the same effect, so I just
removed all the INFINITY/HUGE_VAL stuff and used -1 instead.
It also fixes an ARM-only GCC warning.
- "'__force_align_arg_pointer__' attribute directive ignored". This is an
x86-only attribute. Instead of disabling it on x86-64, instead enable it on
i386 (which avoids enabling it uselessly on ARM).
--HG--
extra : rebase_source : 61015b7e48aebd58035fc222abf076e79a99a972
2015-09-17 17:11:27 -07:00
58bb8fc72f
Bug 1166252 - Reject lut8/16Type with empty CLUT grid. r=jrmuizel
...
--HG--
extra : commitid : KiU2IKstYSk
2015-08-25 15:48:55 -04:00
9b363da3c3
Bug 1176551 - Don't reject valid profiles with no CLUT offset. r=jrmuizel
...
--HG--
extra : commitid : FPpGSvD0Xkd
2015-06-23 17:49:39 -07:00
27b42e9142
Bug 1132468 - Reject invalid sizes. r=jrmuizel
2015-02-24 17:02:10 -05:00
1ecfd0d5e2
Bug 1136389 - Fix qcms num in/out channels mismatch. r=jrmuizel
...
--HG--
extra : rebase_source : a3154a1cb1a517f5a2039382589725c5f99e8c83
2015-02-24 19:03:25 -05:00
8fcbd56508
Bug 969226 - Check if there is enough data to read u32 to avoid buffer overflow. r=bgirard
2014-04-09 15:20:18 -04:00
660395892d
Bug 976143 - Fix build warnings in iccread.c; r=jrmuizel
2014-03-27 21:05:15 +01:00
cf3277421c
Bug 907196 - Split CreateCMSOutputProfile profile loading into GetCMSOutputProfileData. r=BenWa, r=jmuizelaar
2013-11-07 18:20:08 +08:00
5ced299fa2
Backed out changeset ef14be22d6f7 (bug 907196) for Windows bustage.
...
CLOSED TREE
2014-01-13 10:25:52 -05:00
46a51e4e02
Bug 907196 - Split CreateCMSOutputProfile profile loading into GetCMSOutputProfileData. r=BenWa, r=jmuizelaar
2013-11-07 18:20:08 +08:00
80a44473db
Bug 726586 - Uninitialised value use in build_input_gamma_table. r=jrmuizel
...
--HG--
extra : rebase_source : c156458305645abe6e2fa39697c3281f24588822
2012-12-10 11:10:26 -05:00
f3eedbbb1b
Bug 679527 - Prefer floorf over floor in qcms. r=jrmuizel
2012-10-19 16:35:24 -04:00
d9f4daaff9
Bug 700773. qcms: cleanup up some integer types. r=bgirard
...
This fixes a couple of warnings in clang and makes things more consistent.
--HG--
extra : rebase_source : feac84090f270461a73de955902bc016b5835616
2011-11-08 15:43:33 -05:00
4426ead531
Bug 550969 - Fix white_point_from_temp to handle out of range input. r=jmuizelaar
2011-10-14 14:58:34 -04:00
e6e07e47b0
Bug 674230 - Merge from qcms github branch v4; r=jmuizelaar
2011-07-27 10:11:19 -04:00
1eac9663aa
Bug 605179. qcms: revert build warning fixes. r=ehsan
...
0ec22e77aefc fixed some build warnings that no longer happen because pedantic is disabled.
2011-05-10 11:55:39 -04:00
a63db003fb
Bug 613440. Make loading ICM profiles from non-ASCII paths work. r=jmuizelaar
2011-03-30 13:40:47 -04:00
76b8dd5301
Bug 506207 - Check the return value of fread to make sure the readed data is valid; r,a=joe
2011-02-28 13:01:05 -08:00
78236f0f98
Bug 605179 - Fix build warnings in gfx/; r=roc a=bsmedberg
...
--HG--
extra : rebase_source : f9bd24d5f4bc6124b431ce22e6ac72bd218dc208
2010-12-05 18:38:12 +00:00
d2a1c857c0
Bug 561787: Add missing #include to iccread.c, to fix compile warnings about declarations of memcpy. r=roc
2010-04-28 23:13:13 -07:00
e7503e900c
Bug 556405 - Support building qcms on Android, r=jrmuizel
2010-04-05 17:38:43 -07:00
0d8421521c
Bug 550188. qcms: remove an empty loop that annoyed coverity. r=bgirard
2010-03-04 12:13:13 -05:00
0d2d8d41c8
Bug 488800. qcms: accept ICCv4 profiles. r=bobbyholley
...
ICCv4 profiles are a superset of ICCv2 so it shouldn't hurt us to accept them and
just treat them the same way we do ICCv2 profiles.
2009-10-02 17:57:25 -04:00
d4133284fb
Bug 504766. qcms: Fix unaligned reads in qcms. r=jrmuizel
...
Offsets are not guaranteed to be aligned, so don't assume that they are.
memcpy instead of just casting and dereferencing.
2009-09-08 11:36:28 -04:00
aa0a779122
Bug 491195 fix warnings in qcms
...
mostly comparisons between unsigned and signed
also an incomplete initializer
and a warning about using C++ style variables
r=jrmuizel
2009-07-22 17:31:03 -05:00
a5cefc0393
Bug 504888. qcms: Avoid integer overflow when checking buffer bounds. r=bobbyholley
...
Found by Chris Evans
2009-07-21 23:32:27 -04:00
5f01b80d83
Bug 498245. Check that the profile is an RGB profile before checking if it's bogus. r=bholley
...
This avoids unitialized reads on non-RGB profiles.
2009-07-02 11:34:08 -04:00
75e4ff4fd2
Bug 498245. Profiles with negative colorant tristiumlus values are bogus. r=bholley
...
Make sure we reject these profiles.
2009-07-02 11:34:06 -04:00
f9b6997806
Bug 497363. qcms: Fix a memory leak when fread() fails. r=joedrew
...
Fixes a possible leak in qcms_profile_from_file() when fread()
can't read the entire profile.
2009-06-12 14:38:34 -04:00
da6dd3cda6
Color profile reading is broken on windows. b=492962 r=joe
...
The fix is to properly fopen() with "rb" instead of just "r", so that windows knows to treat it as a binary
2009-05-15 18:07:34 -04:00
90fcc20f84
Bug 488747 - Fix endian handling in qcms. r=joe
2009-04-21 22:22:29 -04:00
dcd15d3bce
Bug 489133 - Handle bad cHRM chunks in PNGs. r=joe
2009-04-21 22:21:48 -04:00
334cd17929
Bug 487765 - Fix qcms build problems on Solaris. r=jrmuizel
2009-04-14 11:25:31 -04:00
af28265c3e
Bug 487566 - OS/2 problems to build qcms; r=mozilla@Weilbacher.org
2009-04-11 09:53:40 +02:00
52c97edf1e
Bug 481926 - Rewrite color management component sr=vlad, r=ted, r=joedrew (\o/)
...
Replaces lcms with qcms
2009-04-07 12:02:11 -04:00
db7246feb6
Backed out changeset 6f3c2171bbb2:
...
Bug 481926 - Rewrite color management component. r=joe,ted sr=vlad
2009-04-03 16:27:27 -04:00
e823d73623
Bug 481926 - Rewrite color management component. r=joe,ted sr=vlad
2009-04-03 15:09:56 -04:00
Nicholas Nethercote
Benoit Girard
Jeff Muizelaar
Ms2ger
guozhu cheng
Ryan VanderMeulen
Julian Seward ext:(%2C%20Benoit%20Girard%20%3Cbgirard%40mozilla.com%3E)
Yati Sagade
Makoto Kato
Daniel Holbert
Michael Wu
Vladimir Vukicevic
timeless@mozdev.org
Ginn Chen
Joe Drew