d5deea2a4f
Bug 1338374 - Make Vector not use AlignedStorage for its inline element storage. r=froydnj, r=keeler
...
--HG--
extra : rebase_source : 81eb5278404b4843ed5a59819f6000f74200aa41
2017-01-30 15:56:05 -08:00
8f8272ae04
Bug 1339555 - Make various operator-news into a known-non-null pointer use a ::operator new overload that odesn't null-check. r=froydnj
...
--HG--
extra : rebase_source : cad3ffa778db607bb2ccee2ac42671e60d3c8160
2017-02-14 11:23:18 -08:00
9c7c14c872
Bug 1338574 - Part 1: Add MOZ_CRASH_UNSAFE_OOL and MOZ_CRASH_UNSAFE_PRINTF to crash with a runtime generated explanation string. r=froydnj
...
--HG--
extra : rebase_source : 3ba633aa77ab96f763ea03a8308c539c9c2aeda0
2017-02-21 18:01:41 +01:00
4308a12546
Bug 1338574 - Part 0: Pass __LINE__ as an argument to MOZ_REALLY_CRASH() instead of using it directly. r=froydnj
...
--HG--
extra : rebase_source : 1df7776a4627c4af417be78649ba22203dca8026
2017-02-21 18:01:38 +01:00
b3223b115f
Bug 1060419 - fix comment in IntegerPrintfMacros.h to reflect Printf.h change, r=froydnj
...
MozReview-Commit-ID: 1Zdi7XNHUHL
--HG--
extra : rebase_source : f9c3cfd96504b232ad25cf1c49f3fcb07f461cc1
2016-12-14 14:16:20 -07:00
d7372e37d9
Bug 1338374 - Use alignas/alignof to define Variant's internal raw storage. r=froydnj
...
--HG--
extra : rebase_source : a75613ba7c17ceccf20e6f096a118bfedfa1eb15
2017-01-30 15:56:05 -08:00
1811cee01b
Bug 1338374 - Make tl::Min/Max variadic. r=froydnj
...
--HG--
extra : rebase_source : 140441135e9ee1fcde0541e39a19e1a5c47203c8
2017-01-30 15:56:05 -08:00
318b206490
Bug 1338374 - Use alignas/alignof, and don't use sizeof where alignof should have been used, in MaybeOneOf. r=froydnj
...
--HG--
extra : rebase_source : eb102c6344a6b2fc5a8c904d3361ac3f6735dd43
2017-01-30 15:56:05 -08:00
a35278e9a7
Bug 1325368 - Assume Win7 or later when testing Windows version. r=jimm
...
MozReview-Commit-ID: 718G0htR17H
--HG--
extra : rebase_source : e6f7a3584f03c802218a1de526345e1df1e67cf8
2017-01-29 16:42:46 +09:00
06bb70ebad
Bug 1318677 part 3 - mozilla::Result: Add a new packing strategy to pack small enumerated values in a single word. r=Waldo
2017-02-07 18:57:43 +00:00
60cb2de0a8
Bug 1318677 part 2 - mozilla::Result: Use a single enum to dispatch to the Result implementation. r=Waldo
2017-02-07 18:57:43 +00:00
cc14318018
Bug 1318677 part 1 - Use a smaller mask to remove the error tag. r=jandem
2017-02-07 18:57:42 +00:00
33a6ca0109
Bug 1335780, part 2 - Tests for Maybe<const Type>. r=froydnj
2017-01-03 08:53:05 +00:00
94c9b96404
Bug 1335780, part 1 - Make Maybe<T>::emplace() work when T is const. r=froydnj
2017-01-03 08:53:05 +00:00
3c1ae9aa91
Bug 1332797 - Delete the temporary directory used to store the double-conversion clone when all's said and done. r=froydnj
...
--HG--
extra : rebase_source : 838b42e130e757aae6795b41f75e0d04f0644a65
2017-01-26 13:26:40 -08:00
cd89862c7a
Bug 1332797 - Note the double-conversion git revision last used when importing double-conversion code. r=froydnj
...
--HG--
extra : rebase_source : 16af43fcda79ffc4743fda12c9ce945ee4fd8a26
2017-01-24 12:56:06 -08:00
5a966975cc
Bug 1332797 - Update our double-conversion import using the command |./update.sh d8d4e668ee1e6e10b728f0671a89b07d7c4d45be|. r=generating-script-was-reviewed
...
--HG--
extra : rebase_source : 484d0ba0085c70b1e75790a098cbe4a1a9a0c95b
2017-01-24 09:30:13 -08:00
0fdc1cbc93
Bug 1332797 - Make update.sh fail if applying a local patch creates a *.{orig,rej} file. r=froydnj
...
--HG--
extra : rebase_source : 0b774ad1df5a8bc95d4af806f80bb7a2f6f8d738
2017-01-24 09:29:50 -08:00
dd137bcf96
Bug 1332797 - Update our various local patches to apply against tip double-conversion. r=froydnj
...
--HG--
extra : rebase_source : 6b785879615aea4b9be0c31edb51bc86f8c958f9
2017-01-24 09:29:47 -08:00
bdf8fd6644
Bug 1332797 - Adjust update.sh to work against tip double-conversion. r=froydnj
...
--HG--
extra : rebase_source : b34256579fe5e55fa1a3a7a2e4ae1495265055f4
2017-01-23 15:13:21 -08:00
645ca06a98
Bug 1332797 - Move mfbt/double-conversion source files into a new source/ subdirectory, to segregate upstream files from update.sh and our local patches. r=froydnj
...
--HG--
rename : mfbt/double-conversion/LICENSE => mfbt/double-conversion/source/LICENSE
rename : mfbt/double-conversion/README => mfbt/double-conversion/source/README
rename : mfbt/double-conversion/bignum-dtoa.cc => mfbt/double-conversion/source/bignum-dtoa.cc
rename : mfbt/double-conversion/bignum-dtoa.h => mfbt/double-conversion/source/bignum-dtoa.h
rename : mfbt/double-conversion/bignum.cc => mfbt/double-conversion/source/bignum.cc
rename : mfbt/double-conversion/bignum.h => mfbt/double-conversion/source/bignum.h
rename : mfbt/double-conversion/cached-powers.cc => mfbt/double-conversion/source/cached-powers.cc
rename : mfbt/double-conversion/cached-powers.h => mfbt/double-conversion/source/cached-powers.h
rename : mfbt/double-conversion/diy-fp.cc => mfbt/double-conversion/source/diy-fp.cc
rename : mfbt/double-conversion/diy-fp.h => mfbt/double-conversion/source/diy-fp.h
rename : mfbt/double-conversion/double-conversion.cc => mfbt/double-conversion/source/double-conversion.cc
rename : mfbt/double-conversion/double-conversion.h => mfbt/double-conversion/source/double-conversion.h
rename : mfbt/double-conversion/fast-dtoa.cc => mfbt/double-conversion/source/fast-dtoa.cc
rename : mfbt/double-conversion/fast-dtoa.h => mfbt/double-conversion/source/fast-dtoa.h
rename : mfbt/double-conversion/fixed-dtoa.cc => mfbt/double-conversion/source/fixed-dtoa.cc
rename : mfbt/double-conversion/fixed-dtoa.h => mfbt/double-conversion/source/fixed-dtoa.h
rename : mfbt/double-conversion/ieee.h => mfbt/double-conversion/source/ieee.h
rename : mfbt/double-conversion/strtod.cc => mfbt/double-conversion/source/strtod.cc
rename : mfbt/double-conversion/strtod.h => mfbt/double-conversion/source/strtod.h
rename : mfbt/double-conversion/utils.h => mfbt/double-conversion/source/utils.h
extra : rebase_source : e84171373b2f766698ea48d23484ed05463a4d8a
2017-01-23 15:11:50 -08:00
70018b9399
Bug 1332797 - Clear out the current double-conversion copy before updating it so that our copying properly handles added/removed files. r=froydnj
...
--HG--
extra : rebase_source : b4a4b088dfe3a1d08cc1600c04da5dc65e484807
2017-01-23 15:10:47 -08:00
ad91d7c540
Bug 1332797 - Make the double-conversion update script clone the double-conversion repository into a temporary directory, then copy out of it, taking an optional git revision to use. After this patch, |./update.sh 04cae7a8d5ef3d62ceffb03cdc3d38f258457a52| is a no-op. r=froydnj
...
--HG--
extra : rebase_source : 6fab09db9cec6aaba6004014d32c93338127bd26
2017-01-23 11:27:01 -08:00
7700214282
Bug 1264053 - Transfer DifferentProcess ArrayBuffers by copying, r=jorendorff
...
--HG--
extra : rebase_source : aed39bb2f92888af7626fd4c37df366cb1761bb8
extra : histedit_source : 4e231e7ef1b0b21d0c4bff2ebaa611e8b321e6d4
2017-01-19 14:02:40 -08:00
79e41b270d
Bug 1331495 - Add an operator<< overload for Maybe. r=froydnj
...
MozReview-Commit-ID: 8TcYoikeCvR
--HG--
extra : rebase_source : 591e3c635ae5521418105e2ad1fc2672143eceeb
2017-01-18 13:53:35 -05:00
ba58645c87
Bug 1329194 - mfbt:tests: Define RETURN_INSTR for SH in TestPoisonArea. r=glandium
2017-01-20 09:12:22 +09:00
4d9bda0d08
Bug 1317642 Disable WeakPtr thread assertions on MinGW r=froydnj
...
MinGW has two threading models: win32 API based, which disables std::thread,
and POSIX based which enables it but requires an emulation library (winpthreads).
Rather than attempting to switch to pthread emulation at this point, we are
disabling the std::thread based assertion checking for WeakPtr on MinGW.
MozReview-Commit-ID: BmHo70n6AuK
--HG--
extra : rebase_source : 08495775b2925a797c8098216911d30c0b79ef3d
2017-01-13 13:50:21 -06:00
e46dbc2c0f
Bug 1324093 - Part 4: Make MOZ_Report{Crash,AssertionFailure} be MOZ_NEVER_INLINE. r=froydnj
...
You'd think that this would throw off the assertion stacks in nsTraceRefcnt::WalkTheStack. But as far as I can tell, it was already setting |skipFrames| too high!
On top of that, the function was getting out-of-lined in some instances already. It really should have been MOZ_ALWAYS_INLINE_EVEN_DEBUG.
MozReview-Commit-ID: J2FZmi0pKro
--HG--
extra : rebase_source : 20e5be9f8c21637a28435f47b8ab2de101825679
2017-01-18 09:37:54 +13:00
0cf4adb5f3
Bug 1324093 - Part 3.5: Add MOZ_MAYBE_UNUSED to mfbt/Attributes.h. r=froydnj
...
MozReview-Commit-ID: Ef1nkRipaDg
--HG--
extra : rebase_source : ea298dc948a027e5a686c2f022cce5d8cb170f27
2017-01-18 09:37:54 +13:00
2166409a1d
Bug 1324093 - Part 3: Don't MOZ_ReportAssertionFailure in non-debug builds. r=froydnj f=Waldo f=nbp
...
Not only does this trim the code, it also makes MOZ_RELEASE_ASSERT follow the advice of MOZ_CRASH earlier in the file:
* If we're a DEBUG build and we crash at a MOZ_CRASH which provides an
* explanation-string, we print the string to stderr. Otherwise, we don't
* print anything; this is because we want MOZ_CRASH to be 100% safe in release
* builds, and it's hard to print to stderr safely when memory might have been
* corrupted.
MozReview-Commit-ID: Kuxzn1v9Vfs
--HG--
extra : rebase_source : 5c6efe7cb9adb1c366b423d6ff8f95002512985c
2017-01-18 09:37:46 +13:00
77329182eb
Bug 1324093 - Part 2: Don't AnnotateMozCrashReason on debug builds. r=bsmedberg
...
I left gMozCrashReason visible (but not meaningfully used) in all builds, in order to match the behavior of Assertions.cpp, and to avoid more #ifdef clutter in nsExceptionHandler.cpp.
MozReview-Commit-ID: smoFkddGzd
--HG--
extra : rebase_source : 498f927f62fc944edf254c2ff3b115131367a506
2017-01-18 09:34:02 +13:00
dd8c1f9d4e
Bug 1324093 - Part 1: Move MOZ_REALLY_CRASH's null-deref and TerminateProcess into a never-inline function. r=froydnj
...
The C versus C++ distinction was only there so that Android could make sure it used the global ::abort. I didn't see the need to maintain the distinction for Windows. (Besides, with this change we're no longer doing textual inclusion of "TerminateProcess" in the macro, so people can't take over the name.)
Linux's abort sequence wasn't long enough to be troublesome, so I left it alone.
MozReview-Commit-ID: Ah5XtWpevGz
--HG--
extra : rebase_source : 37c3fb4c50bcba8e48c6a965a02e3f8608940538
2017-01-18 09:33:25 +13:00
d27150b889
Bug 1324093 - Part 0: Use MOZ_{BEGIN,END}_EXTERN_C in Assertions.h. r=froydnj
...
Drive-by cleanup.
MozReview-Commit-ID: 8slQlbS3NS2
--HG--
extra : rebase_source : 2df96c531b8cfa03ca17c134393c5f054ca25927
2017-01-18 09:32:47 +13:00
642927f52b
Bug 1329334 - Variant::as<> should use MOZ_RELEASE_ASSERT. r=froydnj
...
MozReview-Commit-ID: E95959RYm2r
--HG--
extra : rebase_source : 774fcf05c3e6baf080a0e74358e7441242465bb4
2017-01-10 14:24:49 +08:00
ceb22bead5
Bug 1325541 - Expand comments for MOZ_MUST_USE. r=froydnj.
...
DONTBUILD because it's a comment-only change.
--HG--
extra : rebase_source : 1b2343279f15a05ba633a0407f3eba07d6231083
2016-12-23 16:11:33 +11:00
bbf01a2d5f
Bug 1329236: Remove the DECLTYPE(expr) workaround in TestMaybe.cpp. r=ehsan
...
MozReview-Commit-ID: 5n5iRdJKn7M
--HG--
extra : rebase_source : 181165142b1f39c59c404b0b692383dd63a423b9
2017-01-06 12:53:20 -06:00
f6a73ed989
Bug 1315274 - rename mozilla::MakeRange to mozilla::IntegerRange; r=Waldo
...
MakeRange is just way too generic for this sort of thing.
2017-01-06 09:22:53 -05:00
5d60d5ca87
Bug 1312001 - Scramble hash codes securely, to avoid leaking bits of object and symbol addresses.
...
MozReview-Commit-ID: yR1cIjrlPP
--HG--
extra : rebase_source : 871821e53eee5502cd255d52f02665f6845e3f09
2016-11-30 15:31:56 -06:00
20bc668a02
Bug 1280295 - Remove MOZ_HAVE_REF_QUALIFIERS. r=froydnj
2017-01-03 22:42:33 -08:00
b4ceaa3474
Bug 1325351 part 3 - Make Maybe accept value from different Maybe type when the inner type is convertible. r=froydnj
...
MozReview-Commit-ID: 2kYTncYh1Or
--HG--
extra : rebase_source : f3263ce10f3afae6e8ac734296dbb0e641c55c99
2016-12-23 11:49:33 +11:00
30961dadd7
Bug 1325351 part 2 - Simplify 'Some' function. r=froydnj
...
MozReview-Commit-ID: AkLVQw9WYwy
--HG--
extra : rebase_source : 97449d0b2376d53ee7761da2a1ab425492c70ba6
2016-12-23 11:32:33 +11:00
3526b1e58d
Bug 1325351 part 1 - Remove workaround for VC in Maybe. r=froydnj
...
MozReview-Commit-ID: Anlrf3D2WtN
--HG--
extra : rebase_source : 9cc2e29e374753ad40774ebd0a0efce9f9449e3b
2016-12-29 10:58:01 +11:00
82a8828349
Backed out changeset b4d189ca8add (bug 1325351) for spidermonkey cgc and plain shell failure in Maybe.h. r=backout
2016-12-27 10:41:01 +01:00
fe7c0739e3
Backed out changeset 79754b9b89b7 (bug 1325351)
2016-12-27 10:39:49 +01:00
6c5fadc6f5
Backed out changeset 45f0755ff471 (bug 1325351)
2016-12-27 10:39:45 +01:00
3cead98957
Bug 1325351 part 3 - Make Maybe accept value from different Maybe type when the inner type is convertible. r=froydnj
...
MozReview-Commit-ID: 2kYTncYh1Or
--HG--
extra : rebase_source : 2d15fb3c252f1c0505d739d9540079ceb9296b39
2016-12-23 11:49:33 +11:00
254c28b64c
Bug 1325351 part 2 - Simplify 'Some' function. r=froydnj
...
MozReview-Commit-ID: AkLVQw9WYwy
--HG--
extra : rebase_source : 8bdd5aeb7761d32c25e55966275d9a0804eb3948
2016-12-23 11:32:33 +11:00
32962b7da7
Bug 1325351 part 1 - Remove workaround for VS2010 in Maybe. r=froydnj
...
MozReview-Commit-ID: Anlrf3D2WtN
--HG--
extra : rebase_source : a90c32e397c5081e51e6c2461d045591afae9320
2016-12-23 11:32:09 +11:00
7f0959b60f
Bug 1313351 - Fix js::RefCounted to not do leak checking. r=jandem
2016-12-23 21:13:26 +01:00
a4e86a0fbf
Bug 1322792 - require GCC 4.9 to build; r=glandium
2016-12-23 05:47:31 -05:00
0aed7a4ac5
Merge mozilla-central to mozilla-inbound
...
--HG--
rename : testing/docker/base-build/HASH => taskcluster/docker/base-build/HASH
rename : testing/docker/base-test/HASH => taskcluster/docker/base-test/HASH
rename : testing/docker/centos6-build-upd/HASH => taskcluster/docker/centos6-build-upd/HASH
rename : testing/docker/centos6-build/HASH => taskcluster/docker/centos6-build/HASH
rename : testing/docker/decision/HASH => taskcluster/docker/decision/HASH
rename : testing/docker/image_builder/HASH => taskcluster/docker/image_builder/HASH
rename : testing/docker/recipes/tooltool.py => taskcluster/docker/recipes/tooltool.py
rename : testing/docker/tester/HASH => taskcluster/docker/tester/HASH
2016-12-22 16:25:35 +01:00
4e68f1ffa7
Bug 1322465 part 8 - Use explicit/MOZ_IMPLICIT for the unary constructors in mfbt/. r=Ehsan
...
MozReview-Commit-ID: 2TpfrAaAIuu
--HG--
extra : rebase_source : 4fb5af1beb94c059cbadfaf27fe3949ae8b85efb
2016-12-16 15:57:15 +08:00
c8b800005a
Bug 1319740 - Parametrize ComputeSingleDisplayName based on the character type of the key string, and iterate through the string using iterators, not using null-termination. r=arai
...
--HG--
extra : rebase_source : 1c11bd11300dd467e8579faec677d1b7cb9f2e1b
2016-12-02 14:02:36 -08:00
549d7571b3
Bug 1320905 - Add js::RefCounted that uses js_delete (r=waldo)
2016-12-05 15:59:18 -08:00
1e97bdd3fb
Backed out changeset f38852711f38 (bug 1320905) for bustage on a CLOSED TREE
...
--HG--
extra : amend_source : 2e75cec3778e0ceb8a5d99d94004968604403f3a
2016-12-05 16:13:36 +01:00
0bf74100a8
Bug 1320905 - Add js::RefCounted that uses js_delete (r=waldo)
...
MozReview-Commit-ID: D0mSwdm0nn0
2016-12-05 08:46:27 -06:00
2ebbd09068
Bug 1320752 - remove mozilla/Function.h; r=gerald
...
We have std::function available now, which is likely to be somewhat more
efficient.
2016-11-28 11:03:53 -05:00
a666835bf5
merge mozilla-inbound to mozilla-central a=merge
...
--HG--
extra : rebase_source : 7f6b0f633da54f747b30496110e5260a226fe249
2016-11-25 15:36:56 +01:00
c627faaa2b
Bug 1319673 - Make it compile error when instantiate a Variant with duplicate type. r=Tomcat,Waldo
...
MozReview-Commit-ID: IKoLU2FjtzA
--HG--
extra : rebase_source : dcf3ff852af5a985c6c77dcfb1e2a901e92fb869
2016-11-23 15:12:50 +08:00
1985af695f
Bug 1319626 - Part 2: Add BorderLayer class and basic support for them. r=mstange
...
--HG--
extra : rebase_source : de87afc8015649fb5f4a7c4da5f4dc49e19f3d85
2016-11-24 18:11:30 +13:00
831c1e052a
Backed out changeset 4909935f8081 (bug 1319626)
2016-11-24 17:02:32 +01:00
15af88120a
Bug 1319626 - Part 2: Add BorderLayer class and basic support for them. r=mstange
2016-11-24 18:11:30 +13:00
8b27dda5d1
merge mozilla-inbound to mozilla-central a=merge
2016-11-22 15:53:05 +01:00
c100bc54ce
Bug 1319016 - Part2 - Make IsVariant class use IntegralConstant as true false type. r=froydnj
...
MozReview-Commit-ID: G4ohbnUy049
--HG--
extra : rebase_source : 2c20783fe3556ecd0cc04ec1b37b002d044a4e06
2016-11-21 14:28:49 +08:00
cb26e3892f
Bug 1319016 - Part1 - Make IntegralConstant::value use constexpr. r=froydnj
...
MozReview-Commit-ID: DtrDeMC1f5T
--HG--
extra : rebase_source : 820fb6a1a3562bb3d6aa62294338f1328f0fb1c4
2016-11-21 14:27:58 +08:00
2975885bae
Bug 1283562 - Add mozilla::Result<V, E> for fallible return values. r=jwalden
2016-11-21 12:52:03 +01:00
d60ec2b4d6
Bug 1315624 - Delete operator&& and operator|| for CastableTypedEnumResult. r=froydnj
...
Defining these two overloading functions destroys short-circuit evaluation.
MozReview-Commit-ID: Ac7zPtAGOiE
--HG--
extra : rebase_source : 4b3906b5162c1214b9814166f7d0d7de9cb0a7f9
2016-11-07 15:00:16 +08:00
06c4e95cd0
Bug 1316206 - Make RefPtr(decltype(nullptr)) MOZ_IMPLICIT - r=froydnj
...
Making this constructor non-explicit will permit automatic conversions from
'nullptr' into RefPtr types, which I think are not dangerous.
The one spot that this affects is in 'UserDataType nsBaseHashtable::Get(KeyType)',
which does a 'return 0;' into the UserDataType, which could be a bool, an int, a
RefPtr or other. I'm changing that into a C++11 "value initialization", which
falls back to "zero initialization" for PODs: 'return UserDataType{};'.
Also fixed the comment to clarify not-found return values, as Get(KeyType) was
not only used for pointers anyway.
MozReview-Commit-ID: F41VlvTNOZU
--HG--
extra : rebase_source : 71d5dacac75ca188e5c55d45f48a5fca76d953c6
2016-11-08 15:12:33 +11:00
f71d8c43ff
Bug 1316206 - RefPtr construction/assignment from nullptr - r=froydnj
...
Added constructor and operator= from a nullptr, bypassing the incoming pointer
check.
Note that the constructor is 'explicit', because one particular use in
nsBaseHashtable is doing a 'return 0' into a templated type that is a RefPtr in
many cases. Making this new constructor explicit removes it from consideration
in this case.
As it's not strictly necessary to have it MOZ_IMPLICIT (but could still be
nice), I will tackle that in the patch after next.
Also changed all zeroes into nullptr when relevant in RefPtr.h (other system-
wide affected files will be updated in following patch.)
MozReview-Commit-ID: Ds4CEv9hZWI
--HG--
extra : rebase_source : f4ec156b13ea3bdcf32b1a33d76ff9771ad6d1dc
2016-11-10 07:58:10 +11:00
515f250ac5
Bug 1309573 - Part 1: Define the crash reason in MFBT to let everything use it. r=froydnj
...
--HG--
extra : rebase_source : 12eda091c0453e067a13a80261b814128d27c45c
2016-11-06 22:57:00 -05:00
d585884d50
Bug 1315352 - follow-up - placate the static analysis to re-open this CLOSED TREE; r=me
2016-11-07 19:26:11 -05:00
9238cab1b1
Bug 1315352 - enable Range<T> -> Range<const T> conversion; r=Waldo
...
Since |T*| converts into |const T*|, if we want to rewrite code such as:
void DoSomething(const T*, size_t);
void DoSomethingElse(T* x, size_t len)
{
...
DoSomething(x, len);
}
to use ranges:
void DoSomething(Range<const T>);
void DoSomethingElse(Range<T> x)
{
...
DoSomething(x);
}
we need to ensure this conversion works. gsl::span<T> already provides
something like this as well.
2016-11-07 19:30:34 -04:00
c8d4517ee9
Bug 1315004 - rename Range::start to Range::begin to match C++ conventions; r=botond
...
Among other things, this change means that you can use ranged-for syntax
with Range, which is more fitting and pleasant than the alternative.
2016-11-05 21:13:38 -04:00
a19333ea56
Bug 1324829 - Add the `mozilla::Result::andThen` method; r=froydnj
2016-12-21 13:05:56 -08:00
f40c749727
Bug 1324828 - Add the `mozilla::Result::map` method; r=froydnj
2016-12-21 13:05:56 -08:00
4c8471eb15
Bug 1310547 - Add removeAndGetNext/Previous methods to LinkedList (r=froydnj)
2016-10-30 22:04:01 -07:00
c0d229e060
Bug 1310547 - Allow LinkedList to hold RefPtr elements (r=froydnj)
2016-10-30 22:04:00 -07:00
bff4ebdec8
Backed out changeset c41a71b1c24e (bug 1310547) for failing splitText-normalize.html in reftests on Windows 7 VM debug. r=backout on a CLOSED TREE
2016-10-29 13:48:56 +02:00
b063eb49cb
Backed out changeset 721e3171510d (bug 1310547)
2016-10-29 13:45:28 +02:00
d8f4badbd6
Backed out changeset b15d4e773bdd (bug 1310547)
2016-10-29 13:44:48 +02:00
5074379555
Bug 1310547 - LinkedList compiler fixes
2016-10-28 21:27:17 -07:00
5a6e5a85cf
Bug 1310547 - Add removeAndGetNext/Previous methods to LinkedList (r=froydnj)
2016-10-28 20:11:03 -07:00
89ca6e236f
Bug 1310547 - Allow LinkedList to hold RefPtr elements (r=froydnj)
2016-10-28 20:10:37 -07:00
57db30aa76
Bug 1311088 - Part 1: Add mozilla::SpecificNaNBits and JS::detail::CanonicalizedNaNBits. r=jwalden
2016-10-29 01:47:30 +09:00
0e8929a00e
Bug 1301864 - Remove constexpr from mozilla::IsNaN. r=jwalden
2016-10-29 01:47:30 +09:00
b7ccc22970
Bug 1312620 - Add IsPositiveZero function to mfbt and use it to replace MPhi by MNaNToZero iff c is +0.0. r=nbp, r=waldo
...
--HG--
extra : rebase_source : 7adefc3370c081e17b5e0b090a008e0de0507bb9
2016-10-26 17:47:42 +02:00
3bf8f58291
Bug 1309466 - Add Test for the init value by constructor. r=froydnj
...
MozReview-Commit-ID: 9BguTY6dlRD
--HG--
extra : rebase_source : 8aef83263e8a406f6a4bb54f7cac6368cb75d904
2016-10-19 18:12:11 +08:00
6178d3ca29
Bug 1309466 - Enable Array and EnumeratedArray to be brace-initialized with initial contents. r=froydnj
...
MozReview-Commit-ID: 9sD9Rg4qsy1
--HG--
extra : rebase_source : bef928bca14e6d1a0a207359acfa56ecd93d605b
2016-10-12 15:08:47 +08:00
f36057ea28
Bug 553032 - use MOZ_FORMAT_PRINTF, not explicit attribute; r=froydnj
...
MozReview-Commit-ID: FgGin8L5oTp
--HG--
extra : rebase_source : 67f6d7ed8fc56745c66bd339013d1e9b753ec780
2016-10-12 10:03:53 -06:00
06530c20e7
Bug 553032 - document MOZ_FORMAT_PRINTF; r=froydnj
...
MozReview-Commit-ID: 4qX1nltLBxf
--HG--
extra : rebase_source : 5d82dbe8108fc5d9926cc0586a78dc753251f896
2016-10-13 13:08:39 -06:00
4fa10fe6d8
Bug 553032 - move MOZ_FORMAT_PRINTF to mfbt; r=froydnj
...
MozReview-Commit-ID: 2aC4ZUOsGPK
--HG--
extra : rebase_source : ec936e8447624653980d9168587223694a9e10c7
2016-10-11 12:42:58 -06:00
89db11bf5e
Bug 1311277 Part 4 - Convert NodeKind to be an enum class. r=froydnj
...
MozReview-Commit-ID: 2APdWxa8rZ6
--HG--
extra : rebase_source : f4fa846c6bd063afd2d1868169b676ec12f1f19a
2016-10-20 17:01:11 +08:00
96fcd3875f
Bug 1311277 Part 2 - Add move assignment for LinkedListElement and LinkedList. r=froydnj
...
MozReview-Commit-ID: 7NjbxamX87U
--HG--
extra : rebase_source : 578c72ee7eff740f7e7dcfd95f38f3ca8d1045a8
2016-10-19 13:30:51 +08:00
dcc36e9067
Bug 1311277 Part 1 - Convert |other| argument to Mozilla coding style. r=froydnj
...
MozReview-Commit-ID: JcEloAe5dlA
--HG--
extra : rebase_source : 8bc712551d1a0b8f4c1aec1dafc9e4fb2c5861e0
2016-10-19 13:24:23 +08:00
d1108c1e52
Bug 1311068 - remove InitializerList.h; r=botond
...
We needed this polyfill for <initializer_list> when some of our C++
standard libraries did not support said header. They all do now, so the
polyfill is redundant.
2016-10-19 00:33:14 -04:00
19d7f7bb03
Bug 1290337 - Part 22: Add moz_non_param annotation. r=ehsan,jwalden
2016-09-11 18:23:11 +09:00
de8974994d
Bug 1299284 - Remove js::IsPowerOfTwo in favor of mozilla::IsPowerOfTwo. r=sfink
...
--HG--
extra : rebase_source : c9d695c25c9e53d7b86d9718611718af9fea8598
2016-07-21 00:36:38 -07:00
cdcc9e20da
Bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA: main part. r=ted,Mossop
...
MozReview-Commit-ID: 1lCt0xTMV5O
2016-10-08 11:14:49 +02:00
3e934c8f5c
Bug 1305791 - Clear result.mSegments if MoveFallible failed. r=billm
...
MozReview-Commit-ID: 8UaGt1OEfhh
--HG--
extra : rebase_source : c084812d2e4d8633d049638dcd55b0b97db2c603
2016-09-30 17:37:44 +08:00
8240adec88
Bug 1230311 - add annotation to enforce that if a method is overridden also base method is called. r=nfroyd
...
MozReview-Commit-ID: AQ3Kx2qidU0
2016-10-04 17:00:17 +03:00
76b800594e
Backed out changeset d85334f696eb (bug 1285057) for implicitly depending on clang 3.8.
...
--HG--
extra : rebase_source : 472f9411c9d528d63d523c99f4842a1216bdd560
2016-09-23 15:59:55 -07:00
b605dece0c
Bug 1285057 - Blacklist UBSan detection of the GC's generic interfaces; r=sfink
...
--HG--
extra : rebase_source : f5367a8685ec462edb7e30e5ed3d274b4a9bcd0f
2016-07-07 08:59:36 -07:00
7d4ca9c88b
Bug 1303302 - Add IsDestructible trait in TypeTraits and use it for refcounted type static check. r=froydnj
...
MozReview-Commit-ID: G3YFhrJngq0
--HG--
extra : rebase_source : da0aa325eb7772c1a156440ed46be9d0d429c91e
2016-09-16 17:23:55 +10:00
6fcfa1f00e
Bug 1302233 - Introduce VsprintfLiteral to mfbt. r=froydnj
2016-09-14 20:48:45 +02:00
28d8553d1d
Bug 1299379 - Add MOZ_CONCAT for preprocessor token pasting. r=waldo
2016-09-11 15:49:50 +02:00
5cbc382303
Merge inbound to m-c a=merge
2016-09-07 17:54:24 -07:00
36e08437d0
Bug 1018486 - Part 8: Various other changes, r=smaug
...
MozReview-Commit-ID: B0dsomkWgEk
2016-09-07 10:50:45 -04:00
722ad026a3
Bug 1297306 - part4:rename IsEnumFittingWithin with EnumTypeFitsWithin and move it to mfbt/EnumTypeTraits.h. r=froydnj
...
With this change, we could share this EnumTypeTraits between files easily.
MozReview-Commit-ID: 9Q2augati7l
--HG--
extra : rebase_source : b7d9fc95d9d7722ba3eb99ec9798a64ebdbeb484
2016-09-07 10:20:16 +08:00
99748028a6
Bug 1051567 - Make sure we resend file descriptors for the first chunk of a message. r=billm
...
Check if the buffers iterator was never consumed. This is a regression
introduced when converting ipc to use BufferList in bug 1262671.
MozReview-Commit-ID: LWAoVlI5CKJ
--HG--
extra : rebase_source : c4f16f4f90f56153c10cf1d9113c4c55748595f0
2016-08-30 18:26:59 +08:00
5a1fd6c4d4
Bug 525063 - add attribute to mark functions that initialize member variables for their parent class, in order to be scanned by clang-plugin static analysis. r=froydnj
...
MozReview-Commit-ID: 5yTnTUVLpSC
2016-08-30 10:07:03 +03:00
0b2d2c0e55
Bug 1120059 - Remove unnecessary MOZ_EXPLICIT_CONVERSION macros. r=jwalden
...
MozReview-Commit-ID: 7CX1VnBRDpk
--HG--
extra : rebase_source : 36be7e6c91d2767c5a610a2806f89efa69ff1c74
2016-07-13 15:07:52 -07:00
e4eacf065d
Bug 956338 - Add checks to WeakPtr/nsWeakReference and related classes to assert single-thread usage. r=nfroyd
...
--HG--
extra : rebase_source : 140fa149eb94f027e9319a44be0bbee34648222a
2016-08-01 13:16:16 +02:00
1c0c6ec5d4
Merge m-c to inbound. a=merge
2016-08-29 12:56:19 -04:00
c49f09db99
Bug 1297981 - Delete BufferList::FlattenBytes and Pickle::FlattenBytes. r=billm
...
MozReview-Commit-ID: G3a4DN4Lovi
--HG--
extra : rebase_source : 17818efb7578117b708636d06e6a2f5d14532c94
2016-08-25 17:15:38 +08:00
34e7d5b132
Bug 1296760 - Allow Some(nullptr) and Some(Derived*) to convert to Maybe<Base*>. r=froydnj
...
--HG--
extra : rebase_source : 478e825f476a671e07a94f483b88cbc2d4ae8d13
2016-08-24 11:12:48 -07:00
b6d880aca1
Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
...
The patch is generated from following command:
rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,
MozReview-Commit-ID: AtLcWApZfES
--HG--
rename : mfbt/unused.h => mfbt/Unused.h
2016-08-24 14:47:04 +08:00
506dfe6ea3
Bug 1264642 - Part 4. Use BufferList to replace raw buffers in StructuredClone. r=baku r=billm r=jorendorff
...
In JS StructuredClone BufferList<SystemAllocPolicy> is typedef'd to
JSStructuredCloneData and use everywhere in gecko that stores structured
clone data.
This patch changed some raw pointers to UniquePtr<JSStructuredCloneData>
and some to stack allocated JSStructuredCloneData for better life time
management. Some parameters or methods are deleted because of changing
to the new data structure.
MessagePortMessage now has the exactly same structure with
ClonedMessageData. Maybe in the future they can be consolidated.
MozReview-Commit-ID: 1IY9p5eKLgv
2016-08-23 00:40:46 +08:00
3dcef6a932
Bug 1264642 - Part 3. Add BufferList::MoveFallible. r=billm
...
It works like a move constructor but it's fallible. It can also move
data to different but compatible AllocPolicy.
MozReview-Commit-ID: LAbPWCwnrr6
2016-08-23 00:40:46 +08:00
6f3e6b1234
Bug 1264642 - Part 2. Add BufferList::Extract and Pickle::ExtractBuffers. r=billm
...
These methods allow us to move some buffers out of a pickle with minimum
copying. It's useful when the IPC deserialized type uses BufferList to
store data and we want to take the buffers from IPC directly.
Borrowing is not suitable to use for IPC to hand out data because we
often want to store the data somewhere for processing after IPC has
released the underlying buffers.
MozReview-Commit-ID: F1K2ZMkACqq
2016-08-23 00:40:45 +08:00
e1fc3b1773
Bug 1159244 - Add release mode bounds checking with custom annotations to nsTArray, r=froydnj
...
MozReview-Commit-ID: Ljx9PwBCyTT
2016-08-15 13:29:45 -04:00
175543fda8
Bug 1293384 - Part 2: Rename Snprintf.h header to Sprintf.h. r=froydnj
2016-08-14 23:43:21 -07:00
a57972337d
Bug 1293384 - Part 1: Rename snprintf_literal to SprintfLiteral. r=froydnj
2016-08-14 23:44:00 -07:00
0c5ac6c90f
Bug 1294537 - Don't tag |void* p| in the don't-nullcheck placement operator new overload as MOZ_NONNULL, because that makes a double-checking assertion of non-nullness into a compiler warning. r=froydnj
...
--HG--
extra : rebase_source : b53a1c5dce924ea030f54bb41e13baf27cd3d823
2016-08-12 18:02:03 -07:00
0a6a801dc2
Bug 1294537 - introduce a non-null-checking placement operator new; r=sunfish,nbp
...
The default placement operator new is defined to always require that its
result be null-checked. A sufficiently smart compiler can remove this
check, but not all compilers are sufficiently smart. Better to have a
custom placement operator new that will remove null checks in a way
defined by the standard.
2016-08-12 22:43:49 -04:00
42824df666
Bug 1197324 - add format-string checking attribute to snprintf_literal. r=froydnj
2016-08-03 14:37:31 +02:00
23575fdec5
Bug 1248555: Introduce variants of SpecificNaN / BitwiseCast that preserve the signaling NaN bit; r=froydnj
...
MozReview-Commit-ID: 5A8p06nBqyI
--HG--
extra : rebase_source : 87ebcc9792d42c6b2e6164a639340da37b4b602c
extra : histedit_source : b4ab7c6b9f4bb7fe2cc88a3208d6fa8e6fefce08
2016-08-01 20:02:05 +02:00
489e357178
Bug 1291423: Explicitly qualify the destructor call that we invoke in Maybe::reset. r=Waldo
...
MozReview-Commit-ID: 6vQouBSxnsZ
2016-08-02 21:19:08 -07:00
9fc9590608
Bug 1289990 - Remove VS2013 workaround for TestTuple.cpp crash. r=froydnj
...
--HG--
extra : rebase_source : c5138bb0ea6a77b04030074ecebd85ba0808afa3
2016-07-27 23:13:08 -07:00
fdb4542277
Bug 1290035 - Remove the explicit Type parameter to MakeEnumeratedRange. r=Waldo
...
MozReview-Commit-ID: BtFVn9pTQpU
--HG--
extra : rebase_source : be83c74953e2fbc7ace2ce49ceebb060da394c50
2016-07-28 17:48:50 +08:00
79a0735001
Bug 1283395 - add markup functions for static analysis builds. r=froydnj
...
MozReview-Commit-ID: 6dFygYzTYfN
2016-07-25 16:57:30 +03:00
1feda59958
Backed out changeset 9c839b1d1397 (bug 1283395) for static build bustage CLOSED TREE
2016-07-25 08:54:47 -07:00
440264fed8
Bug 1283395 - add markup functions for static analysis builds. r=froydnj
...
MozReview-Commit-ID: 6dFygYzTYfN
2016-07-25 17:43:14 +03:00
6dad001d7f
Bug 1238661 - fix mozilla::SignalTrampoline to work properly with clang; r=darchons
...
mozilla::SignalTrampoline is designed to work around a bug in older ARM
kernels; it constructs a trampoline function with a NOP slide and then
calls a specified function. This feat is accomplished using inline
assembly and naked functions, which is a GCC extension where you get to
write the entire body of your function using GCC inline assembly.
Unfortunately, the particular implementation that it uses requires the
specified function's address to be loaded into a register. GCC permits
this and we use input arguments to the assembly statement to ensure that
GCC knows it shouldn't clobber the incoming argument registers when
trying to load the function's address.
clang, however, complains about the use of input parameters in naked
functions. So we need to find something that will work on both GCC and
clang.
The trick is to realize that we're a) tail-calling the specified
function and b) we don't have to worry about calling a fully-general
function. We just have to worry about calling a function inside libxul,
and we can therefore "assume" that the offset between the branch and the
called function fits into the immediate field of a Thumb (or ARM) branch
instruction. (This assumption is not strictly true; the branch range is
+/-16MB or so and libxul is actually quite a bit bigger than that. But
it works in practice, and the linker will insert branch stubs if
necessary to make things work out OK.)
The upshot is that we can use a "b" instruction instead of a "bx"
instruction, and this makes clang much happier. As a small bonus, the
stub gets ever-so-much-more efficient, which is probably the
least-significant micro-optimization ever.
2016-07-25 18:16:06 -04:00
b0efbe0ef8
Bug 1288603 - Remove NumericLimits.h because all platforms have numeric_limits<char16_t>. r=froydnj
2016-07-22 22:05:45 -07:00
336105a0de
merge mozilla-inbound to mozilla-central a=merge
2016-07-22 11:58:02 +02:00
5538d692d3
Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
...
This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
d634a99cad
Bug 1277106 - Part 4: Remove MOZ_UTF16() macro. r=Waldo
2016-07-19 21:07:53 -07:00
8949f73d27
Bug 1277106 - Part 1: Use VS2015's real char16_t instead of aliasing wchar_t. r=Waldo
...
and remove MOZ_CHAR16_IS_NOT_WCHAR #ifdefs.
2016-07-20 22:01:43 -07:00
718ce69fb7
Backed out changeset c8e5a0703821 (bug 1283395) for bustage on a CLOSED TREE
2016-07-21 08:13:06 +02:00
d2d46ad585
Bug 1283395 - add markup functions for static analysis builds. r=froydnj
...
MozReview-Commit-ID: 1F5GGpQtq4x
2016-07-20 15:45:34 +03:00
3bba9b339e
Backed out 5 changesets (bug 1287623) for static build bustage CLOSED TREE
...
Backed out changeset a48daec87ec9 (bug 1287623)
Backed out changeset 248153344e15 (bug 1287623)
Backed out changeset 8aa409c9b1ce (bug 1287623)
Backed out changeset 602d4d88e806 (bug 1287623)
Backed out changeset 114da8bdc0b0 (bug 1287623)
2016-07-20 15:40:33 -07:00
155e619376
Bug 1287623, part 3 - Add more methods involving StaticRefPtr. r=froydnj
...
This patch adds a number of standard conversions to and from RefPtr<>
and already_AddRefed<>.
2016-07-20 15:19:00 -07:00
a5a3cca3f9
Bug 1287623, part 3 - Add more methods involving StaticRefPtr. r=froydnj
...
This patch adds a number of standard conversions to and from RefPtr<>
and already_AddRefed<>.
2016-07-21 09:54:17 -07:00
efea1b6545
Bug 1287243 - Optimize the type used to store Variant's tag. r=fitzgen
...
--HG--
extra : rebase_source : c7c6fd63ea50330958ef794dc28cc8890ef59bbe
2016-07-16 02:31:45 -07:00
1fe18b25cf
Bug 1232686 - Use decltype to infer Variant::match return type; r=fitzgen
...
--HG--
extra : rebase_source : 38f280cc3014b2285a79e377f1fa8edf4c5f4661
2015-12-15 07:45:22 -08:00
c329f132b7
Bug 1276573 - Add a new constructor for Range<T>. r=Waldo
...
These new constructor accepts two RangedPtr<T> arguments.
MozReview-Commit-ID: 8a3bYserLMr
--HG--
extra : rebase_source : 216de17b7a51783fe48d604b432d4dc7df6ad6eb
2016-05-30 13:58:13 +08:00
43c2748f66
Bug 1277775 - Replace MOZ_CONSTEXPR{_VAR,_TMPL} with constexpr. r=froydnj
2016-07-08 14:39:53 -07:00
2b3b60f7b1
Bug 1277155 - Part 1: Remove snprintf() polyfills for VS2013 in Sprintf.h and #defines. r=froydnj r=mhowell
2016-06-27 20:45:03 -07:00
ab7252caa2
Bug 1267918 - Add do_AddRef(const RefPtr<T>& aObj). r=froydnj
...
This means we can return already_AddRefed<T> for any RefPtr<T>s
being held as instance variables easier.
MozReview-Commit-ID: HFHdkF8EUsK
--HG--
extra : rebase_source : df650d39c010386afcb8cb2dd48292c26fbc6501
2016-06-30 10:06:10 +12:00
e20f0f4551
Bug 1282795 - Silence warnings when MOZ_ALWAYS_{TRUE,FALSE} are passed expressions with embedded side effects, that would ordinarily trigger side effects but don't inside certain unevaluated contexts within MOZ_ASSERT, which then triggers compiler warnings with new-enough clang. You are not expected to understand this. r=froydnj
...
--HG--
extra : rebase_source : ffe6d35af74c50b04dbddc9cc3965292875c64a0
2016-06-28 17:12:14 +01:00
5e3fc1519f
Bug 525063 - renamed MOZ_INITIALIZED_OUTSIDE_CONSTRUCTOR -> MOZ_INIT_OUTSIDE_CTOR. r=nfroyd
...
MozReview-Commit-ID: GPQY8b2OM2V
2016-06-28 16:30:49 +03:00
a2712d4b0e
Bug 1255632 - Make Maybe::map and Maybe::apply support lambdas. r=waldo,njn
2016-06-22 16:32:40 -07:00
c46c20b362
Backed out changeset 7b03f23fdde5 (bug 1255632) for bustage on a CLOSED TREE
2016-06-22 08:48:25 +02:00
358b410aaa
Bug 1255632 - Make Maybe::map and Maybe::apply support lambdas. r=waldo,njn
2016-06-21 22:15:27 -07:00
fa9fafb015
Bug 1277896 - add Vector::initLengthUninitialized (r=waldo)
...
MozReview-Commit-ID: He6Kzr0giLU
2016-06-10 13:28:04 -05:00
6b6f143161
Bug 1278391 - add move constructor to EnumeratedArray (r=njn)
...
MozReview-Commit-ID: AQjH3xx9TSq
--HG--
extra : rebase_source : 599dc2bf76fa2921de6bf3b41c7d384db70a7ff9
2016-06-09 08:42:16 -05:00
12bac0f757
Bug 525063 - add attribute to mark member variables that should be skipped by clang plugin initialization checker. r=nfroyd
...
MozReview-Commit-ID: 4V1YcK2thiF
2016-06-09 09:32:11 +03:00
c735dfa442
Bug 1278201 - prevent writing |mRefCnt| after it's freed. r=Ms2ger
...
MozReview-Commit-ID: G7fZzrGWHmW
--HG--
extra : rebase_source : 6f311948a8d2222358aec860f2c6d6223862e814
2016-06-06 17:23:10 +03:00
97c2e11d8c
Bug 1273048 - Add MOZ_GCC_VERSION_AT_MOST macro. r=froydnj
...
MozReview-Commit-ID: 4VjAra5B6GM
--HG--
extra : transplant_source : %D3%C7C%05%7EB%24%90q%D3%22%C8%F5%8F%C7%C3%B4%00%A6%E2
2016-06-03 20:08:41 -07:00
acc84881a2
Bug 1277740 - Add const to RangedPtr<T>::operator+ and operator-. r=Waldo
...
MozReview-Commit-ID: FlHmq5eh5ph
--HG--
extra : rebase_source : 7e8939f0a9531426fa8fa742351d47f1d2351e72
2016-06-03 12:16:33 +08:00
4b68d2e1e4
Bug 1276550 - Support operator-> for RangedPtr. r=Waldo
...
MozReview-Commit-ID: EiOfo7ly34P
--HG--
extra : rebase_source : 6acbd9b3b6681f5c777e779713a21e8f808b89bf
2016-05-30 11:55:57 +08:00
e574e0eda0
Bug 1277377 - prevent unsafe C-style cast in Vector (r=waldo)
...
MozReview-Commit-ID: L0bTDSBHOeY
2016-06-02 14:38:02 -05:00
b3d842431f
Bug 1272203 (part 1) - Add mozilla::NotNull to MFBT. r=froydnj.
...
This patch implements mozilla::NotNull, which is similar but not identicial to
gsl::not_null.
The current draft(?) implementation of gsl::not_null is at
https://github.com/Microsoft/GSL/blob/master/include/gsl.h .
The main difference is that not_null allows implicit conversion from T to
not_null<T>. In contrast, NotNull only allows explicit conversion from T to
NotNull<T> via WrapNotNull().
The rationale for this is that when converting from a less-constrained type to
a more constrained type, implicit conversion is undesirable. For example, if I
changed a function f from this:
f(int* aPtr);
to this:
f(gsl::not_null<int*> aPtr);
no call sites would have to be modified. But if I changed it to this:
f(mozilla::NotNull<int*> aPtr);
call sites *would* need to be modified. This is a good thing! It forces the
author to audit the call sites for non-nullness, and encourages them to
back-propagate NotNull throughout the code.
The other difference between not_null and NotNull is that not_null disables
pointer arithmetic, which means it cannot be used with array pointers. I have
not implemented this restriction for NotNull because it seems arbitrary and
unnecessary.
2016-05-12 14:21:16 +10:00
11ef78ae89
Bug 1275016 - Rename Endian.h to EndianUtils.h to avoid #include confusion with Android's endian.h stdlib header. r=froydnj
...
--HG--
rename : mfbt/Endian.h => mfbt/EndianUtils.h
2016-05-22 13:31:11 -07:00
308608ab39
Bug 1262671 - Introduce MFBT BufferList class (r=froydnj)
2016-05-27 09:57:40 -07:00
eb2ea5c544
Bug 1269319 - Make AlignedStorage/AlignedStorage2 non-copyable to fix strict aliasing issues. r=Waldo
2016-05-19 20:57:36 +02:00
09a0151088
Bug 1209227 - Part 2: Mark mfbt::Variant as MOZ_INHERIT_TYPE_ANNOTATIONS_FROM_TEMPLATE_ARGS, r=froydnj
2016-05-19 09:34:01 -04:00
353ee65255
Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium
2016-05-11 00:00:01 -07:00
88fbb75f4c
Bug 1271972: wasm: Implement i64.ctz, i64.clz, i64.popcount; r=sunfish
...
MozReview-Commit-ID: 2XXloMWmbjV
--HG--
extra : rebase_source : a332d6b5c3e0cfe3d5018cdc53e4c20b80b6a52a
extra : histedit_source : d413c95a2d1bc56f8d6f0deacecf37190a612397
2016-05-11 19:00:53 +02:00
4d3ad00b0e
Bug 1269968 - Remove unnecessary deduction on RefPtr.h. r=froydnj
...
MozReview-Commit-ID: HoLyJD6oh
--HG--
extra : rebase_source : ac10cf1b3fae96ae91e7b5dd9b5a54797cec6e6d
2016-05-03 20:45:00 +02:00
df166c688f
Bug 1271022 - add Vector::podResizeToFit (r=njn)
...
MozReview-Commit-ID: 9HTY6O9GY4U
--HG--
extra : rebase_source : 55c226d23bd6dbb7b3bb21b356e64ae7499d3f0a
2016-05-09 08:59:10 -05:00
d8dc169af0
Bug 1268754 - Tweak some MFBT return values. r=Ms2ger.
...
This patch:
- Adds MOZ_MUST_USE to AllocPolicy::checkSimulatedOOM().
- Adds MOZ_MUST_USE to LZ4::decompress() (both variants) and fixes their
comments.
- Changes the return type of SplayTree::insert() from bool to void, because it
always returns true and its callers don't check the return value.
- Changes the return type of SplayTree::finishInsertion() from T* to void,
because it makes things clearer -- it was just returning the aNew argument.
- Adds MOZ_MUST_USE to a Vector::growTo() (both variants).
--HG--
extra : rebase_source : 1547cdeb9ee71d0ecec608ab474ab5e75bfc4b42
2016-04-29 13:14:34 +10:00
6b1ce5f87f
Bug 1268246 - Add a simple Poison class lifetime checker. r=froydnj
...
MozReview-Commit-ID: HpUjIaLPV7u
--HG--
extra : rebase_source : e5586cbb9d71005181671f362583a5b3b9006a4d
2016-04-29 13:54:54 -04:00
2511b2c327
Bug 1267550 (part 2) - Rename MOZ_WARN_UNUSED_RESULT as MOZ_MUST_USE. r=froydnj.
...
It's an annotation that is used a lot, and should be used even more, so a
shorter name is better.
MozReview-Commit-ID: 1VS4Dney4WX
--HG--
extra : rebase_source : b26919c1b0fcb32e5339adeef5be5becae6032cf
2016-04-27 14:16:50 +10:00
a5c843fe5f
Bug 1267550 (part 1) - Rename MOZ_MUST_USE as MOZ_MUST_USE_TYPE. r=ehsan.
...
This will allow MOZ_MUST_USE to be used for a different and more common case.
MozReview-Commit-ID: 4dQsdWjJfc6
--HG--
extra : rebase_source : 390ab56ef83d71eb6d28759a0195a79a78b153bd
2016-04-27 08:22:10 +10:00
b0359cb30b
Bug 1266404 - Allow construction of an EnumSet<T> using an initializer list r=Waldo
2016-04-28 14:25:05 +01:00
7dd2771dd7
Bug 1266402 - Add iteration to EnumSet<T> so that it can be used in range-based for loops r=Waldo
2016-04-28 14:25:05 +01:00
592be23acb
Bug 1265892 - Change Vector to use Impl::new_ consistently. r=Waldo
2016-04-26 16:26:17 -07:00
99cbfbd0dc
Bug 1259021 - Add Vector::extractRawBuffer method that doesn't copy the buffer r=Waldo
2016-04-25 13:41:25 +01:00
d5b6a661f0
Bug 1259021 - Rename Vector::extractRawBuffer to extractOrCopyRawBuffer r=Waldo
2016-04-25 13:41:25 +01:00
1999c10d91
Bug 1266294 - Remove unnecessary compiler version checks for gcc <= 4.8.0 in mfbt. r=froydnj
2016-04-17 17:08:10 -07:00
575dbe7dfd
Bug 1264827 - Part 3: Add the MOZ_NEEDS_MEMMOVABLE_MEMBERS annotation to MFBT; r=froydnj
2016-04-18 15:43:48 -04:00
558930f4e9
Backed out changeset e673dbc9848f (bug 1232686) for breaking VS2013 Builds
2016-04-16 10:57:53 +02:00
2177cca5cd
Bug 1232686 - Use decltype to infer Variant::match return type; r=fitzgen
2015-12-15 07:45:22 -08:00
67e655e4bf
Bug 1261361 - Make Vector::infallibleGrowByUninitialized check mReserved instead of mCapacity. r=Waldo
...
--HG--
extra : rebase_source : 2b6cdfae61946505b83748c016ef0b112ecf4780
2016-04-14 17:32:48 +02:00
8ed91454ea
Bug 1262663 - Clean up UniquePtr return documentation. r=Waldo
...
The prohibition against returning a UniquePtr was based on
bugs in older compilers which required an explicit Move()
to properly transfer ownership. This is no longer the case
since we now have code returning this type directly.
--HG--
extra : rebase_source : 6190b3f14b650d448f18f7611a22576701657795
2016-04-11 14:36:29 -07:00
c9a80c9abd
Bug 1263342 - don't use REFCOUNTED_VIRTUAL_TYPENAME for mfbt FunctionImplBase. r=froydnj
2016-04-08 23:14:59 -04:00
f1057b0380
Bug 1262577 - allow comparing mozilla::function with nullptr. r=froydnj
2016-04-06 15:18:01 -04:00
0ef3ab81a0
Bug 1232418 - Allow mozilla::Tuple to support equality comparison; r=Waldo
...
--HG--
extra : rebase_source : d57231f1c4a4c58715d2d552dd2e02257a73891e
2015-12-14 12:01:17 -08:00
6aeb6d5d05
Bug 1260247. In chaos mode randomly decide to start a new image load even if the image is in the image cache when allowed by spec. r=seth
...
If the image load is from the same document that cached the image we are required to use the cached version. Otherwise we should be free to ignore the cached version.
2016-04-02 13:53:12 -05:00
5790b832fa
Bug 1261452 - do_AddRef shouldn't require an rvalue-reference. r=froydnj
2016-04-01 19:14:42 -07:00
9825c57bc3
bug 1239166 - platform work to support Microsoft Family Safety functionality r=froydnj,mgoodwin,mhowell,rbarnes,vladan
...
MozReview-Commit-ID: GhpJqJB97r9
--HG--
extra : rebase_source : e943c1e4d0f008ffd6b6bb4bb63e1daf27ae2c96
2016-01-12 15:39:43 -08:00
1dd8dbc3f7
Bug 1246061. r=jandem, r=bz, r=luke, r=froydnj
...
--HG--
extra : rebase_source : 5b314d4c4c6e0b553290884be7338f8e79c22f71
2016-03-09 00:37:20 -08:00
04177e1aa2
Bug 1209100 - Back out bug 1165185 on inbound.
...
MozReview-Commit-ID: JqohyXNvjiU
--HG--
extra : rebase_source : c2165d279a6ca57a3439ebbfc081961369a42124
2016-03-21 16:16:52 -04:00
3fe18eae3b
Bug 1175546 - Update GCC to 4.8.5 and bump minimum GCC version required to build. r=froydnj
2016-03-12 09:03:37 +09:00
52f227c58b
Bug 1253678 - Rename mozilla::Function to mozilla::function. r=froydnj
...
MozReview-Commit-ID: 60RPmEsYDN2
--HG--
extra : rebase_source : 9d0bebc7362af2778d123425c56ac20553d9303b
2016-03-11 16:49:13 -05:00
30ce323e87
Bug 1255857 - Allow mozilla::UniquePtr's deleter template argument to customize the pointer type; r=froydnj
2016-03-11 15:35:43 -05:00
3508cf5f6a
Bug 1254565 - Allow passing matchers as rvalues to Variant::match. r=froydnj
...
--HG--
extra : rebase_source : 9863e7cde9ff918af22de94ca7ec29988c154bbd
2016-03-10 13:35:00 -05:00
115b647d6c
Bug 1253094, part 11 - Make DebugOnly a MOZ_STACK_CLASS. r=Waldo
...
MozReview-Commit-ID: I09tdRotoJq
--HG--
extra : rebase_source : d3a895ca6138d4e8a4ed87109434db922b9cac53
2016-02-26 15:52:08 +00:00
d75c1bad6a
Bug 1170045 - part 1 - add bulk pop support to SegmentedVector; r=erahm
...
Writing PopLastN in this way is probably a bit of a micro-optimization,
but at least it comes with tests and some comments for verifying the
goodness of the code.
2016-03-04 12:02:24 -05:00
Jeff Walden
Emanuel Hoogeveen
Tom Tromey
Masatoshi Kimura
Nicolas B. Pierron
Jonathan Watt
Steve Fink
Botond Ballo
John Paul Adrian Glaubitz
Tom Ritter
David Major
James Cheng
Nicholas Nethercote
Nathan Froyd
Jason Orendorff
Chris Peterson
Xidorn Quan
Sebastian Hengst
Luke Wagner
Carsten "Tomcat" Book
Ting-Yu Chou
Matt Woodrow
Jan de Mooij
Ting-Yu Lin
Gerald Squelart
Nick Fitzgerald
Bill McCloskey
Tooru Fujisawa
Johannes Schulte
Kan-Ru Chen
Andi-Bogdan Postelnicu
Terrence Cole
Tom Schuster
Mats Palmgren
Wes Kocher
Michael Layzell
Jeremy Chen
Michelangelo De Simone
Honza Bambas
Ryan VanderMeulen
Igor
Nathan Froyd
Benjamin Bouvier
Daniel Holbert
Cameron McCormack
Andrew McCreight
Boris Chiou
Chris Pearce
Seth Fowler
L. David Baron
Benoit Girard
Jon Coppeard
Dan Gohman
Ehsan Akhgari
Ralph Giles
Lee Salzman
Timothy Nikkel
Bobby Holley
David Keeler
Markus Stange
Mike Hommey