This patch changes this file to use the exact C++ mode lines from the
Mozilla coding style guide, available here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line
(The automated modeline.py script won't do this on its own for this one file. I
think that's because this file has the vim & emacs modelines in the reverse
order from the standard Mozilla syntax, and modeline.py is conservative and
won't change syntax that it doesn't immediately expect/understand.)
MozReview-Commit-ID: 7R1DUBEvFFh
--HG--
extra : rebase_source : eb802806375cf7d6f6fb0626220b1a510b375cdb
SetTestSampleTime is called from tests via the advanceTimeAndRefresh API
on DOMWindowUtils, and the expectation is that after it is done, the
time has been advanced and a composite has happened. So we need to
ensure that is the case with WebRender as well. This fixes the issue I
was seeing with test_group_hittest.html and makes it pass.
MozReview-Commit-ID: 86l9mTTwD2v
--HG--
extra : rebase_source : d2921fb0f9b09f4366fb516e4a6254a7f13f3e4e
This splits the FlushRendering function into sync and async versions
just for a bit more clarity. In the async version we don't want to set
the mForceRendering flag at all because we don't need to force a
rendering - if there is one already pending then that's good enough. And
anyway in practice the async version seems to only ever be invoked by
CompositorBridgeParent::SetTestSampleTime which I'll be changing in the
next patch.
MozReview-Commit-ID: 4cdU0U5B1pp
--HG--
extra : rebase_source : d7842844fca758d53121e3326d8da7fb7592ad8b
This extracts a code pattern that appears a couple of times in the code.
It occurs in CompositorBridgeParent as well but there's some extra stuff
involved there with the mOverrideComposeReadiness flag that I don't
understand so I'm leaving that as-is for now.
MozReview-Commit-ID: 2xqgaQZT4e1
--HG--
extra : rebase_source : 294727f146bbe5323a2cbdaa511dac5a4fc81571
GetGfxInfo returns an already_AddRefed, you can't just forget about its return
value.
MozReview-Commit-ID: Ia6pyJN9njf
--HG--
extra : rebase_source : 73f7f1a6a8093d6f6555fa11f784bf912e1ab616
SetNeedsComposite is only ever called from one place on the compositor
thread, but it has a bunch of generic boilerplate to handle being called
from any thread. If we inline it we don't need the extra boilerplate and
it's much simpler to follow the code.
MozReview-Commit-ID: E1AcMh80KsH
--HG--
extra : rebase_source : 717fe101a3b23e30f8443110de5b6bf1a84cddda
This function is exposed as public but only ever called from two places,
both of which are inside the class. It's confusing to have it as a
separate function because it just makes it harder to trace through the
code.
MozReview-Commit-ID: BC7mvOc9wo
--HG--
extra : rebase_source : 56e2c69e158685c106e01e78e31d2df67ea6128c
Having a resume function without a corresponding pause function seems
silly. And the implementation of the function is the same as doing a
force-compose, which is what the call site is intending to do. So we can
just remove this function and do a force-compose instead.
MozReview-Commit-ID: LimMYQhAuEk
--HG--
extra : rebase_source : f10e43c4c4a6f67162b1b473de6c23d8dbdc7a8f
This function has only one call site and there's no need to make it
public.
MozReview-Commit-ID: 5o7B9KMyVqy
--HG--
extra : rebase_source : 38a915c19d48784ce086ebecd66b9f872ae03327
OpenType font collections (*.ttc) contain multiple faces in a single file,
identified via index. When creating a font descriptor for a FreeType or
Fontconfig font, we mistakenly set the index to zero, always.
This bug became visible when layout and WebRender would disagree on the face in
use, rendering text with the metrics from the proper face but the outlines of
another. Unless, of course, the selected face was the first (or only) in the
font file.
MozReview-Commit-ID: 73qcPOD0HIr
--HG--
extra : rebase_source : b5784ff547bae99186d646dbb92b31660beb3970
To avoid future issues, this is done by combining the Render and Update methods
into a single call. As a minor side-effect, timing in the parent method now
includes the time to run update.
MozReview-Commit-ID: GJ0l049eFRj
--HG--
extra : rebase_source : f9b4ee6f34bc45d87b3df40e5a25f3bfb2ec8068
We sometimes render frames for hit-testing consistency requirements but
those frames don't need compositing. This goes with webrender PR 2358.
MozReview-Commit-ID: D6DRF040D5a
--HG--
extra : rebase_source : fd5dadc35a6f6a54b385f535d4ae9c6e34f3a779
pixman-8888-over-565.patch added a call to free(), which is apparently
not included by the other headers when using the new NDK headers.
MozReview-Commit-ID: 9fAuSano36N
--HG--
extra : rebase_source : de9a1f1c4676df9ed724ae7264ca1170b77aac52
Daniel Holbert
Kartikaya Gupta
Emilio Cobos Álvarez
sotaro
Jonathan Watt
Florian Quèze
Csoregi Natalia
Jonathan Kew
Ryan Hunt
Martin Stransky
Jan Steffens
Cameron McCormack
Alexis Beingessner
Martin Roinson
Brindusan Cristian
Bogdan Tara
Dzmitry Malyshau
Andrea Marchesini
arthur.iakab
Sebastian Hengst
Jim Chen