Nicholas Nethercote
b66a653de9
Bug 1407458 - Use nsString for Observation filenames. r=erahm.
...
This avoids some unnecessary string copying.
--HG--
extra : rebase_source : a81a5e1612be2897a4285f5f395e7cb3ed006bc8
2017-10-17 08:22:12 +11:00
Eric Rahm
4df63b1809
Bug 1403083 - Part 2: Test conditionaly enabling string functions. r=froydnj
...
--HG--
extra : rebase_source : 01e852a2cf86a71fd1842fc852f1c2cdecb67b7b
2017-10-09 13:33:16 -07:00
Eric Rahm
e0bdf23b2e
Bug 1403083 - Part 1: Properly disable string functions for invalid char types. r=froydnj
...
In order to properly disable template functions with `std::enable_if` we need
to use the resulting type. This only works if we use a dependent type in the
template params, hence the need to shadow the `T` param.
Proper usage is now of the form:
template<typename Q = T, typename EnableIfChar = CharOnlyT<Q>>
Foo();
--HG--
extra : rebase_source : da7855403d9e683d06d3858e26805e9d8e338208
2017-10-03 12:44:44 -07:00
Nathan Froyd
7c3d6e9065
Bug 1410088 - don't copy QueueEntry(ies) when calling LabeledEventQueue::GetEvent; r=erahm
...
We were extracting elements from the queue and unnecessarily refcounting
them, rather than transferring the owning reference out of the queue and
out to the caller.
2017-10-19 16:22:55 -04:00
Nathan Froyd
aeec9a0da6
Bug 1410086 - don't copy QueueEntry(ies) when checking LabeledEventQueue for ready events; r=erahm
...
There's no need to copy events in the queue to check whether they are
ready to run or not.
2017-10-19 16:22:55 -04:00
Andrea Marchesini
6626e900f9
Bug 1409327 - NS_NewBufferedInputStream should take the ownership of the inputStream, r=smaug
2017-10-19 11:39:30 +02:00
Nicholas Nethercote
78030c0e7b
Bug 1409598 - Change nsIXPCScriptable::className and nsIClassInfo::{contractID,classDescription} from string to AUTF8String. r=froydnj.
...
This lets us replace moz_xstrdup() of string literals with AssignLiteral(),
among other improvements.
--HG--
extra : rebase_source : 9994d8ccb4f196cf63564b0dac2ae6c4370defb4
2017-10-18 13:17:26 +11:00
Ryan VanderMeulen
cb612851ed
Merge inbound to m-c. a=merge
2017-10-18 21:01:34 -04:00
Blake Kaplan
22ee7f1db9
Bug 1406212 - Remove multiprocessBlockPolicy. r=Felipe
...
MozReview-Commit-ID: F6P5fUPSc7L
--HG--
extra : rebase_source : 2663c37c2dfe853adc86ba36599fed715114b812
2017-10-12 11:16:46 -07:00
Andrew McCreight
70333838d1
Bug 1403959, part 3 - Manually fix some xpcom/ eslint failures and enable it. r=froydnj
...
Renames are because another location also defined that
variable. Unused definitions are eliminated.
The .eslintrc.js file makes eslint expect XPCShell global variables.
MozReview-Commit-ID: Fafm5o45bme
--HG--
extra : rebase_source : ab71132a60e90bd30f34766bd828b18dd608f8b3
2017-09-28 16:12:52 -07:00
Andrew McCreight
4ae455cdc5
Bug 1403959, part 2 - Automatically generated eslint fixes. r=froydnj
...
These were generated with |./mach eslint --fix xpcom| with the
.eslintignore and xpcom/tests/unit/.eslintrc.js changes from the next
patch.
MozReview-Commit-ID: 8pKkICSK3JQ
--HG--
extra : rebase_source : bbc98050928f27160d8ca63d38aa0c383be95878
2017-09-28 15:49:04 -07:00
Andrew McCreight
ae916ca971
Bug 1403959, part 1 - Remove non-standard conditional catch clause. r=froydnj
...
This is non-standard, and eslint can't parse it correctly, so remove
it.
MozReview-Commit-ID: EsfZSyoECB0
--HG--
extra : rebase_source : 561d194e0c466d98d054b2303916be196f983b1b
2017-09-28 15:39:06 -07:00
Stephen A Pohl
f810e234b5
Bug 1409468: Add a property appleModelId to telemetry's environment data to collect model IDs for Apple desktop devices. r=mstange,francois
2017-10-18 14:52:06 -04:00
Nika Layzell
2e20b0d128
Bug 1377351 - Part 5: Add a workaround for gcc 4.9 compiler bug, r=froydnj
...
MozReview-Commit-ID: CHywpZ4fvXf
2017-10-18 13:00:22 -04:00
Nika Layzell
c234875cd6
Bug 1377351 - Part 4: Add tests for nsA[C]String::Assign move overload, r=froydnj
...
MozReview-Commit-ID: KJ41seMmUXt
2017-10-18 13:00:18 -04:00
Nika Layzell
4146e6b110
Bug 1377351 - Part 3: Expose nsA[C]String::Assign(nsA[C]String&&) overload as take_from to rust, r=froydnj
...
MozReview-Commit-ID: 4YNPi3iRo78
2017-10-18 13:00:15 -04:00
Nika Layzell
2ff829eabc
Bug 1377351 - Part 2: Add move overloads to nsA[C]String assignment and constructors, r=froydnj
...
MozReview-Commit-ID: 81U51pgshZI
2017-10-18 13:00:12 -04:00
Nika Layzell
1fe9edd088
Bug 1377351 - Part 1: Add move overload to nsA[C]String::Assign, r=froydnj
...
MozReview-Commit-ID: 5bloaYcvpgr
2017-10-18 13:00:09 -04:00
Nicholas Nethercote
7f098bdb9c
Bug 1409227 (part 4) - Replace nsMemory::Clone(id, sizeof(nsID)) with nsID::Clone(id). r=mccr8.
...
This change requires introducing nsID::Clone(). Because it's infallible, the
patch also removes some redundant failure-handling code. (nsMemory::Clone() is
also infallible, so this code was redundant even before this change.)
--HG--
extra : rebase_source : ef22757d3fa814320490bf7e19e822b8f0c4bdc3
2017-10-18 10:39:20 +11:00
Nicholas Nethercote
1fdf1c46d3
Bug 1409227 (part 3) - Replace nsMemory::Clone(s, sizeof(s)) with moz_xstrdup(s). r=froydnj.
...
The new code is slightly less efficient because it requires measuring the
string length, but these strings are all short so it shouldn't matter.
Note that the case in DataToString() is a little different. The std::min() that
was there appears to be excessive caution -- this code is always printf'ing
some kind of number, so 32 chars should never be reached -- but it was bogus
anyway, because if 32 was exceeded then (a) we would have overflowed `buf`, and
(b) we'd be returning a non-null-terminated string.
--HG--
extra : rebase_source : b666ad72c09d8c32b98bb9abc9dce1bd0c912c9b
2017-10-17 13:28:40 +11:00
Nicholas Nethercote
3076238153
Bug 1409227 (part 2) - Replace nsMemory::Clone(s, strlen(s)+1) with moz_xstrdup(s). r=erahm.
...
They are equivalent -- both infallible, both requiring measuring the length of
the string -- but moz_xstrdup is much more readable. (One place deals with
16-bit strings and so uses NS_strdup instead, which is also infallible.)
The patch also removes some failure-path code that will never execute due to
the infallibility.
--HG--
extra : rebase_source : 115574cf55db90b60e6bee59e5dc6ee409374159
2017-10-17 13:09:29 +11:00
Sebastian Hengst
66e04dcde6
Backed out changeset 4666cde20909 (bug 1409327)
2017-10-17 22:03:33 +02:00
Stephen A Pohl
a42ae45a57
Backout 7a6b39895ac2 and 7cb727e67531 to potentially be replaced with better solution. r=backout
2017-10-17 15:46:01 -04:00
Boris Zbarsky
fb684cc726
Bug 1409152. Add an nsTArray::ContainsSorted method. r=froydnj
2017-10-17 15:39:59 -04:00
Stephen A Pohl
a2294619d7
Bug 1409468: Add a property to telemetry's environment data to detect when a device has an Apple touchbar. r=mstange,francois
2017-10-17 15:33:22 -04:00
Andrea Marchesini
d526801916
Bug 1409327 - NS_NewBufferedInputStream should take the ownership of the inputStream, r=smaug
2017-10-17 20:38:05 +02:00
Sebastian Hengst
6cab3753eb
merge mozilla-central to mozilla-inbound. r=merge a=merge
2017-10-17 11:48:30 +02:00
Sebastian Hengst
32f7c8fec3
merge mozilla-inbound to mozilla-central. r=merge a=merge
...
MozReview-Commit-ID: 1h3kZyrtqSt
2017-10-17 11:45:16 +02:00
Matt Woodrow
d8a662f0d2
Bug 1406727. r=mstange,froydnj a=abillings
...
--HG--
extra : rebase_source : a9932eb10d3ca451e1ce3a424cd48e957801f593
2017-10-17 15:19:44 +13:00
Kris Maglione
f6ba082a01
Bug 1404198: Part 2b - Switch to NS_NewTimer* in xpcom. r=njn
...
MozReview-Commit-ID: BEtHEpOmT1E
--HG--
extra : rebase_source : dac8a182f1ad76df6715146e1da1279c02c0406f
2017-10-15 23:11:22 -07:00
Kris Maglione
3c7ea8250b
Bug 1404198: Part 2a - Add non-virtual constructors for nsITimer. r=njn
...
MozReview-Commit-ID: 3I7MAquvMHj
--HG--
extra : rebase_source : 9fb92a49fb9b89aec738aca5f77ef3a612802df6
2017-10-15 23:10:17 -07:00
Kris Maglione
3876d40960
Bug 1404198: Part 1 - Add non-virtual constructor for nsIObject(Input|Output)Stream and update existing callers. r=njn
...
MozReview-Commit-ID: 3eoh6AwDJyz
--HG--
extra : rebase_source : 92b18b6ef07d276cac79ce735ca0b592cffbf87e
2017-10-04 20:06:28 -07:00
Daosheng Mu
e41dc03f86
Bug 1392216 - Part 1: Create VR listener thread in GPU process; r=dvander,kip
...
MozReview-Commit-ID: Img0HT9ax90
--HG--
extra : rebase_source : ef3e2dac31f498454121639aa46657c0cd16f949
2017-10-05 18:12:45 +08:00
Nicholas Nethercote
f2d1f3b005
Bug 1407117
- Simplify static atom representation. r=froydnj,bz.
...
Currently nsAtom::mString points to the interior of an nsStringBuffer. For
static atoms this requires the use of nsFakeStringBuffer, which is pretty
gross.
This patch changes things so that nsAtom::mString points to a static char
buffer for static atoms. This simplifies a number of things:
- nsFakeStringBuffer and CheckStaticAtomSizes are no longer needed.
- FakeBufferRefCountHelper is no longer needed.
- nsAtom's constructor for static atoms is simpler.
- RegisterStaticAtoms() is simpler.
On the flip-side, a couple of things get more complicated.
- nsAtom::ToString() treats static and dynamic atoms differently.
- nsAtom::GetStringBuffer() is now only valid for dynamic atoms. This
function is only used in two places, both involving DOMString, so those
locations are updated appropriately. This also requires updating some other
code assigning nsStrings to DOMStrings, because we can't assume that
nsStrings are shared.
On Linux64 this change reduces the size of the binary by 8752 B, and moves
81968 B from the .data to the .rodata section, where it can be shared between
processes.
--HG--
extra : rebase_source : 0f6fcdec1c525aa66222e208b66a9f9026f69bcb
2017-10-12 10:52:17 +11:00
Kyle Machulis
1cc8b01353
Bug 1406224 - Remove nsIDOMHTMLImageElement; r=bz
...
MozReview-Commit-ID: GCATWRt6qMo
--HG--
extra : rebase_source : 29854f1374c6ad318da0b5b68be23507667c3be4
2017-10-06 13:27:23 -07:00
Xidorn Quan
2215d24611
Bug 1407843
part 1 - Introduce a global-level AtomArray type alias. r=froydnj
...
MozReview-Commit-ID: DbGkWxkPfX7
--HG--
extra : rebase_source : 4f389d544bef98dccbfa694c1b821591bdae4103
2017-10-13 11:59:23 +11:00
Sebastian Hengst
13fcf1d3fb
Backed out changeset e2a919fabb6a (bug 1408459) for build bustage on Android 4.2 x86 opt: invalid conversion. r=backout
2017-10-13 20:45:17 +02:00
Andrew McCreight
348a32c708
Bug 1408459 - Remove unused declaration of NS_MeanAndStdDev(). r=erahm
...
Also, fix up the include guard in that file.
MozReview-Commit-ID: CwQhCb5htOS
--HG--
extra : rebase_source : fc38fd6057e83d8bb3d6a48632c7871c601c6928
2017-10-13 09:47:28 -07:00
Sebastian Hengst
1c1a5cef77
Merge mozilla-inbound to mozilla-central. r=merge a=merge
...
MozReview-Commit-ID: 5oI3jfNbQVt
2017-10-13 11:12:47 +02:00
Phil Ringnalda
ecdb97c7dc
Backed out 6 changesets (bug 1406212) for mass reftest failures
...
CLOSED TREE
Backed out changeset 1c9fe35de901 (bug 1406212)
Backed out changeset 1acc4c270bf9 (bug 1406212)
Backed out changeset d9ea9cff849f (bug 1406212)
Backed out changeset 5bf2f08f01f9 (bug 1406212)
Backed out changeset 1a050da96e9e (bug 1406212)
Backed out changeset 1b5e78113f06 (bug 1406212)
MozReview-Commit-ID: LizV8CD4IY4
2017-10-12 19:45:23 -07:00
Jed Davis
b39b9e95d4
Bug 1406971 - Change nsProcess to use LaunchApp from IPC, instead of NSPR, on Unix. r=froydnj
...
This also fixes the Unix part of bug 678369, and fixes bug 147659 as a
convenient side-effect of using LaunchApp (which has the desired
fd-closing behavior already) rather than directly using fork/exec.
The main goal is to work around bug 227246, where PR_CreateProcess on
Unix interferes with anything else that tries to use child processes.
This does not fix that bug -- NSPR will still cause problems if used in
that way -- but it's an adequate workaround for that bug in Gecko in
almost all cases (the one known exception is nsAuthSambaNTLM, which uses
NSPR directly and needs to be fixed separately).
Waiting for the child process uses waitpid() directly, sharing the
existing code used for OS X.
MozReview-Commit-ID: 6zfZ1Zgk2i9
--HG--
extra : rebase_source : e8230503d82943af4563d8d63baa029d8a698683
2017-10-06 19:58:33 -06:00
Blake Kaplan
cdfbbe4c70
Bug 1406212 - Remove multiprocessBlockPolicy. r=Felipe
...
MozReview-Commit-ID: F6P5fUPSc7L
--HG--
extra : rebase_source : 78b570ba97bcb452df3c96748c453a1517843244
2017-10-12 11:16:46 -07:00
Sebastian Hengst
5c00b8540d
merge mozilla-inbound to mozilla-central. r=merge a=merge
...
MozReview-Commit-ID: AlcL6XYDkf
2017-10-12 23:58:31 +02:00
Sebastian Hengst
f7efb5fc2c
Merge mozilla-central to mozilla-inbound. r=merge a=merge on a CLOSED TREE
2017-10-12 12:03:15 +02:00
Sebastian Hengst
8ff69604ce
merge mozilla-inbound to mozilla-central. r=merge a=merge
2017-10-12 12:40:23 +03:00
Sebastian Hengst
c2f23c4622
merge mozilla-central to mozilla-inbound. r=merge a=merge
...
--HG--
rename : browser/base/content/test/general/browser_bug585558.js => browser/base/content/test/tabs/browser_positional_attributes.js
rename : devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_jsterm_dollar.js => devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_dollar.js
rename : devtools/client/webconsole/new-console-output/test/mochitest/test-bug-621644-jsterm-dollar.html => devtools/client/webconsole/new-console-output/test/mochitest/test-jsterm-dollar.html
rename : dom/media/doctor/DDLogClass.cpp => dom/media/doctor/DDLogCategory.cpp
rename : dom/media/doctor/DDLogClass.h => dom/media/doctor/DDLogCategory.h
rename : mobile/android/app/src/main/res/drawable-hdpi/find_prev.png => mobile/android/app/src/photon/res/drawable-hdpi/find_prev.png
rename : mobile/android/app/src/main/res/drawable-hdpi/url_bar_entry_default.9.png => mobile/android/app/src/photon/res/drawable-hdpi/url_bar_entry_default.9.png
rename : mobile/android/app/src/main/res/drawable-hdpi/url_bar_entry_default_pb.9.png => mobile/android/app/src/photon/res/drawable-hdpi/url_bar_entry_default_pb.9.png
rename : mobile/android/app/src/main/res/drawable-hdpi/url_bar_entry_pressed.9.png => mobile/android/app/src/photon/res/drawable-hdpi/url_bar_entry_pressed.9.png
rename : mobile/android/app/src/main/res/drawable-hdpi/url_bar_entry_pressed_pb.9.png => mobile/android/app/src/photon/res/drawable-hdpi/url_bar_entry_pressed_pb.9.png
rename : mobile/android/app/src/main/res/drawable-large-hdpi-v11/url_bar_entry_default.9.png => mobile/android/app/src/photon/res/drawable-large-hdpi-v11/url_bar_entry_default.9.png
rename : mobile/android/app/src/main/res/drawable-large-hdpi-v11/url_bar_entry_default_pb.9.png => mobile/android/app/src/photon/res/drawable-large-hdpi-v11/url_bar_entry_default_pb.9.png
rename : mobile/android/app/src/main/res/drawable-large-hdpi-v11/url_bar_entry_pressed.9.png => mobile/android/app/src/photon/res/drawable-large-hdpi-v11/url_bar_entry_pressed.9.png
rename : mobile/android/app/src/main/res/drawable-large-hdpi-v11/url_bar_entry_pressed_pb.9.png => mobile/android/app/src/photon/res/drawable-large-hdpi-v11/url_bar_entry_pressed_pb.9.png
rename : mobile/android/app/src/main/res/drawable-large-xhdpi-v11/url_bar_entry_default.9.png => mobile/android/app/src/photon/res/drawable-large-xhdpi-v11/url_bar_entry_default.9.png
rename : mobile/android/app/src/main/res/drawable-large-xhdpi-v11/url_bar_entry_default_pb.9.png => mobile/android/app/src/photon/res/drawable-large-xhdpi-v11/url_bar_entry_default_pb.9.png
rename : mobile/android/app/src/main/res/drawable-large-xhdpi-v11/url_bar_entry_pressed.9.png => mobile/android/app/src/photon/res/drawable-large-xhdpi-v11/url_bar_entry_pressed.9.png
rename : mobile/android/app/src/main/res/drawable-large-xhdpi-v11/url_bar_entry_pressed_pb.9.png => mobile/android/app/src/photon/res/drawable-large-xhdpi-v11/url_bar_entry_pressed_pb.9.png
rename : mobile/android/app/src/main/res/drawable-large-xxhdpi-v11/url_bar_entry_default.9.png => mobile/android/app/src/photon/res/drawable-large-xxhdpi-v11/url_bar_entry_default.9.png
rename : mobile/android/app/src/main/res/drawable-large-xxhdpi-v11/url_bar_entry_default_pb.9.png => mobile/android/app/src/photon/res/drawable-large-xxhdpi-v11/url_bar_entry_default_pb.9.png
rename : mobile/android/app/src/main/res/drawable-large-xxhdpi-v11/url_bar_entry_pressed.9.png => mobile/android/app/src/photon/res/drawable-large-xxhdpi-v11/url_bar_entry_pressed.9.png
rename : mobile/android/app/src/main/res/drawable-large-xxhdpi-v11/url_bar_entry_pressed_pb.9.png => mobile/android/app/src/photon/res/drawable-large-xxhdpi-v11/url_bar_entry_pressed_pb.9.png
rename : mobile/android/app/src/main/res/drawable-xhdpi/find_prev.png => mobile/android/app/src/photon/res/drawable-xhdpi/find_prev.png
rename : mobile/android/app/src/main/res/drawable-xhdpi/url_bar_entry_default.9.png => mobile/android/app/src/photon/res/drawable-xhdpi/url_bar_entry_default.9.png
rename : mobile/android/app/src/main/res/drawable-xhdpi/url_bar_entry_default_pb.9.png => mobile/android/app/src/photon/res/drawable-xhdpi/url_bar_entry_default_pb.9.png
rename : mobile/android/app/src/main/res/drawable-xhdpi/url_bar_entry_pressed.9.png => mobile/android/app/src/photon/res/drawable-xhdpi/url_bar_entry_pressed.9.png
rename : mobile/android/app/src/main/res/drawable-xhdpi/url_bar_entry_pressed_pb.9.png => mobile/android/app/src/photon/res/drawable-xhdpi/url_bar_entry_pressed_pb.9.png
rename : mobile/android/app/src/main/res/drawable-xxhdpi/url_bar_entry_default.9.png => mobile/android/app/src/photon/res/drawable-xxhdpi/url_bar_entry_default.9.png
rename : mobile/android/app/src/main/res/drawable-xxhdpi/url_bar_entry_default_pb.9.png => mobile/android/app/src/photon/res/drawable-xxhdpi/url_bar_entry_default_pb.9.png
rename : mobile/android/app/src/main/res/drawable-xxhdpi/url_bar_entry_pressed.9.png => mobile/android/app/src/photon/res/drawable-xxhdpi/url_bar_entry_pressed.9.png
rename : mobile/android/app/src/main/res/drawable-xxhdpi/url_bar_entry_pressed_pb.9.png => mobile/android/app/src/photon/res/drawable-xxhdpi/url_bar_entry_pressed_pb.9.png
extra : rebase_source : 0cff6fa99d9ea3c6ce0bfb1604d4e9533f63ce63
2017-10-13 00:55:27 +02:00
Nicholas Nethercote
1de4b467c1
Bug 1406829 (part 2) - Use initializer lists more in nsAtom constructors. r=froydnj.
2017-09-26 16:43:31 +10:00
Nicholas Nethercote
b54a014b55
Bug 1406829 (part 1) - Add a comment about nsAtom::hash(). r=froydnj.
2017-09-26 16:20:57 +10:00
Sebastian Hengst
4c169d4680
merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
2017-10-12 12:00:22 +02:00
Mike Hommey
b1f7830bc2
Bug 1407838 - Replace UniquePtr<T, NSFreePolicy> with UniqueFreePtr. r=njn
...
--HG--
extra : rebase_source : 0d356b71443896579dedd98cbd08dfe1acb4a34d
2017-10-12 11:22:05 +09:00