Jonathan Kew
0cb8df0560
Bug 1157569 - Followup to address review nits (renamings, comment updates) from parts 13 and 14.
2015-06-27 11:16:18 -07:00
Jonathan Kew
d22a7ebb8c
Bug 1157569 - part 14 - Finish conversion of border-collapse code in nsTableFrame to logical coordinates. r=dholbert
2015-06-27 11:16:10 -07:00
Jonathan Kew
f9a52f8a25
Bug 1157569 - part 13 - More conversion of physical to logical terminology in border-collapse calculations. r=dholbert
2015-06-27 11:16:03 -07:00
Xidorn Quan
ef54b4b14f
Bug 1159990 - Add TableArea struct and replace nsIntRect with it for table damage area. r=roc
...
--HG--
extra : source : bdc7bf00559b80ae6a4f9c60848e34542f438218
2015-05-01 09:46:59 +12:00
Daniel Holbert
1e4637780c
Bug 1155798: Drop end-of-line whitespace from C++ files in layout/tables. (whitespace-only, no review, DONTBUILD)
2015-04-17 11:42:05 -07:00
Nicholas Nethercote
242708cf72
Bug 1127201 (attempt 2, part 1) - Replace most NS_ABORT_IF_FALSE calls with MOZ_ASSERT. r=Waldo.
...
--HG--
extra : rebase_source : 488e401ff87e31a2074c4108c4df0572d9536667
2015-02-09 14:34:50 -08:00
Andrew McCreight
d3826daa16
Back out Bug 1127201 (part 2) for various problems.
2015-02-06 15:04:32 -08:00
Nicholas Nethercote
d34f0301b8
Bug 1127201 (part 2) - Convert all NS_ABORT_IF_FALSE calls to MOZ_ASSERT. r=Waldo.
...
--HG--
extra : rebase_source : 99182e70335d2b5ff95f8c528ae992d37294be3a
2015-02-04 20:05:36 -08:00
Mats Palmgren
3ffa9baecc
Bug 1028460 - part 3, Change the return type for Get*SkipSides(). r=roc
2014-06-28 10:13:13 +00:00
Phil Ringnalda
811c3783d4
Back out 5 changesets (bug 1028460, bug 1031444) for somehow breaking asmjscache/test/test_cachingBasic.html on Android 2.2
...
Backed out changeset 0b5918ec6521 (bug 1031444)
Backed out changeset 663ff18cd4a1 (bug 1028460)
Backed out changeset ae01b3919c8c (bug 1028460)
Backed out changeset 316c8dfeca9b (bug 1028460)
Backed out changeset e237b2c61ea2 (bug 1028460)
2014-06-28 22:01:28 -07:00
Mats Palmgren
4e879335f7
Bug 1028460 - part 3, Change the return type for Get*SkipSides(). r=roc
2014-06-28 10:13:13 +00:00
Benoit Jacob
60d536773a
Bug 1004098 - Make nsTArray use size_t in its interface (32bitness is fine as an internal detail) - r=froydnj, sr=bsmedberg
2014-05-08 21:03:35 -04:00
Ehsan Akhgari
9c3c5e4360
Bug 969883 - Remove some unneeded memory allocation failure handling code in table cell map code; r=dbaron
...
The data structures manipulated by this code use infallible memory
allocation, so the OOM handling code paths here are dead code.
2014-02-19 00:49:15 -05:00
Mats Palmgren
eb2304a29c
Bug 919318 - A few cosmetic changes after dropping the Get prefix on some methods. r=dholbert
2013-09-25 11:42:35 +00:00
Mats Palmgren
4974add798
Bug 919318 - Drop the Get prefix on the frame methods GetFirstContinuation, GetLastContinuation, GetFirstInFlow, GetLastInFlow and also on nsLayoutUtils::GetLastContinuationWithChild, because they never return null. r=dholbert
2013-09-25 11:42:34 +00:00
Ehsan Akhgari
2824b29025
Bug 895322 - Part 1: Replace the usages of MOZ_STATIC_ASSERT with C++11 static_assert; r=Waldo
...
This patch was mostly generated by running the following scripts on the codebase, with some
manual changes made afterwards:
# static_assert.sh
#!/bin/bash
# Command to convert an NSPR integer type to the equivalent standard integer type
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.cc" \
-o -iname "*.mm" \) | \
xargs -n 1 `dirname $0`/assert_replacer.py #sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_STATIC_ASSERT static_assert
hg rev --no-backup mfbt/Assertions.h \
media/webrtc/signaling/src/sipcc/core/includes/ccapi.h \
modules/libmar/src/mar_private.h \
modules/libmar/src/mar.h
# assert_replacer.py
#!/usr/bin/python
import sys
import re
pattern = re.compile(r"\bMOZ_STATIC_ASSERT\b")
def replaceInPlace(fname):
print fname
f = open(fname, "rw+")
lines = f.readlines()
for i in range(0, len(lines)):
while True:
index = re.search(pattern, lines[i])
if index != None:
index = index.start()
lines[i] = lines[i][0:index] + "static_assert" + lines[i][index+len("MOZ_STATIC_ASSERT"):]
for j in range(i + 1, len(lines)):
if lines[j].find(" ", index) == index:
lines[j] = lines[j][0:index] + lines[j][index+4:]
else:
break
else:
break
f.seek(0, 0)
f.truncate()
f.write("".join(lines))
f.close()
argc = len(sys.argv)
for i in range(1, argc):
replaceInPlace(sys.argv[i])
--HG--
extra : rebase_source : 4b4a4047d82f2c205b9fad8d56dfc3f1afc0b045
2013-07-18 13:59:53 -04:00
Nathan Froyd
ad659548e0
Bug 860457 - use uintptr_t instead of unsigned long in celldata.h; r=dholbert
2013-04-10 12:56:22 -04:00
L. David Baron
c5b9eee040
Bug 781360 patch 3: Rename {nsIFrame,nsStyleContext,nsComputedDOMStyle}::GetStyle* to Style*, since they can never return null. r=dholbert
...
Except for the changes in:
layout/generic/nsIFrame.h (part)
layout/style/nsComputedDOMStyle.h (all)
layout/style/nsRuleNode.cpp (part)
layout/style/nsStyleContext.cpp (part)
layout/style/nsStyleContext.h (part)
(see patch 3b in the bug), this patch was written with the sed script:
s/\<GetStyle\(Font\|Color\|List\|Text\|Visibility\|Quotes\|UserInterface\|TableBorder\|SVG\|Background\|Position\|TextReset\|Display\|Content\|UIReset\|Table\|Margin\|Padding\|Border\|Outline\|XUL\|SVGReset\|Column\)\>/Style\1/g
2013-02-16 13:51:02 -08:00
Mats Palmgren
b7ae90666d
Bug 786533 - Replace NS_MIN/NS_MAX with std::min/std::max and #include <algorithm> where needed. r=ehsan
2013-01-15 13:22:03 +01:00
Trevor Saunders
8d7e7dd8d7
bug 781409 - remove nsITableLayout r=roc,davidb
2012-08-08 09:05:17 -04:00
Mats Palmgren
b56d966ae4
Bug 815315 - Avoid crashing if the last row-group child frame was removed. r=bz
2012-12-01 01:10:40 +01:00
Ehsan Akhgari
e368dc9c85
Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
...
This patch was generated by a script. Here's the source of the script for
future reference:
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int
convert PRUintn unsigned
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
2012-08-22 11:56:38 -04:00
Aryeh Gregor
d0ad5a7d0c
Bug 777292 part 2 - Change all nsnull to nullptr
2012-07-30 17:20:58 +03:00
Jonathan Watt
970e60a384
Bug 767388 - Kill NS_DEBUG. r=bz.
...
--HG--
extra : rebase_source : d045208a26345712dbb4628c973c616cd9504f28
2012-06-25 20:59:42 +01:00
Gervase Markham
82ff7027aa
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
Mats Palmgren
86699a57d7
Bug 720142 - Use nsIntRect for table damage. r=bernd
2012-01-22 23:48:34 +01:00
Bernd
6f72a1c8e3
bug 710098 - use effective rowspan r=mats
2011-12-29 09:17:55 +01:00
Bernd
d4f7842058
bug 711359 - mark all subsequent rows as damaged r=mats
2011-12-27 09:31:09 +01:00
Nicholas Nethercote
24d2c81ee1
Bug 711908 - Fix a bunch of GCC warnings in layout. r=dbaron.
2011-12-19 19:46:39 -08:00
Bernd
9739f86ea0
bug 705996 - the damageArea should only be set once the columns are in shape r=mats
2011-12-03 07:21:16 +01:00
Bernd
844db3e17f
bug 460637 - the group cellmaps need to set the damageArea relative to the entire table, patch by Mats Palmgren, Randell Jesup and Bernd, r=mats, bernd
2011-10-27 09:58:44 -04:00
Ehsan Akhgari
92064e6d3f
Bug 690892 - Replace PR_TRUE/PR_FALSE with true/false on mozilla-central; rs=dbaron
...
Landing on a CLOSED TREE
2011-10-17 10:59:28 -04:00
Michael Wu
d2b70213ac
Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones
...
--HG--
rename : tools/trace-malloc/bloatblame.c => tools/trace-malloc/bloatblame.cpp
2011-09-28 23:19:26 -07:00
Mats Palmgren
f1c56f2e22
Bug 653649 - New way of getting child lists from frames. (part 4/5) r=roc
...
Remove the nsIAtom* child list names and use child list ID enum instead.
2011-08-24 22:54:30 +02:00
Ehsan Akhgari
523ebb7851
Bug 677661 - Remove nsTPtrArray and add a SafeElementAt(index_type) API to nsTArray when it's instantiated with a pointer type; r=sicking
2011-08-10 01:36:00 -04:00
Ms2ger
c1500f0f3a
Bug 670500 - Make nsCellMap::Init return void; r=roc
2011-07-15 12:18:33 +02:00
Ms2ger
27dd1dcd24
No bug - Fix assertion in nsCellMapColumnIterator::GetNextFrame; r=bz
2011-07-03 11:53:39 +02:00
timeless@mozdev.org
b88c6d4720
Bug 620259 - add fall through comments to nsTableCellMap::SetNotTopStart and rename to nsTableCellMap::ResetTopStart
...
r=bernd a=dbaron
2011-02-16 14:14:18 +01:00
Edmund Wong
c31f357639
Bug 585336: Fix "a the" in comments (for General core code). r=timeless a=NPOTB (comment-only)
2010-08-15 15:50:02 -07:00
Bernd
d071426d51
bug 564054 - rebuild cellmap if inserted rows contain a zero rowspan r=bzbarsky
2010-05-13 16:15:50 +02:00
timeless
f3cdc36c53
Bug 334571 Coverity 702, NS_SIDES array limit check - replace NS_FOR_CSS_SIDES defines with enum. r=zwol,mats
2010-04-27 18:15:02 +02:00
timeless
aa22afa674
Bug 334571 strip trailing whitespace. r=zwol
2010-04-27 18:15:01 +02:00
Ehren Metcalfe
a791e19cc4
Bug 556446: Remove dead code in layout. r=roc,bz
2010-04-03 07:36:19 -04:00
Bernd
46449bbc6e
bug 378935 the border collapse code relies on having mutliple dead cell data entries in a row r=bzbarsky
2010-03-06 10:53:04 +01:00
Bernd
2f77193c78
bug 28800 remove support for scrollable rowgroups moa=roc r=bzbarsky
2010-01-16 17:05:46 +01:00
Reed Loden
4221b4442d
Bug 506267 - [r=bzbarsky sr=dbaron]
2009-10-02 21:09:57 -05:00
Mats Palmgren
dea07412a1
Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX. b=512106 r=roc
2009-09-16 17:01:36 +02:00
Alexander Surkov
fff2439827
Bug 437980 - 9 tests fail in table_indexes.html chrome test file, r=marcoz, davidb, bernd
2009-06-29 18:54:26 +08:00
Boris Zbarsky
551370dfca
Bug 487899. Start column indices incorrect in nsCellMap::ExpandWithCells if an array with more than one cell is passed in. r=bernd, sr=roc
2009-04-13 11:31:39 -04:00
Arpad Borsos
89c2d6ac9b
Bug 481932 - use do_QueryFrame instead of IS_TABLE_CELL + cast; r+sr=roc
2009-03-24 23:10:06 +01:00