We also take this opportunity to simplify the simulateCameraFlash function by
using a simpler version of element.animate.
Differential Revision: https://phabricator.services.mozilla.com/D103457
When the selector doesn't return any node, we log a warning on the page.
A test case is added in browser_jsterm_screenshot_command_selector.js to ensure
this works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D102753
Depends on D103051.
Other browser devtools do not select the node on expand. Selecting the node can be quite slow when if many CSS rules apply to it.
This should allow exploring the tree of complex pages with less slowdowns.
An existing test is updated to assert the selected state of the node container before/after expanding it.
Differential Revision: https://phabricator.services.mozilla.com/D103052
The existing helper expandContainerByClick is modified to support the "altKey" option and reused in all tests that try to click on markup-view container expand-icons.
A similar collapseContainerByClick is also added for symmetry. Both methods will become identical once we stop selecting the node on expand and they will be merged.
Differential Revision: https://phabricator.services.mozilla.com/D103051
Now that network resources are enabled on the server, RDM is using the network actor
to control network throttling.
We can remove all the RDM client code that was still trying to call the responsive actor.
We can't remove the methods from the ResponsiveActor yet though, since the Netmonitor
will use it when there's no network resource server side support, which is still
the case for the Browser Toolbox.
Differential Revision: https://phabricator.services.mozilla.com/D102766
This patch switches all the calls to `startListeners["NetworkActivity"]` to watching
for network resources instead.
We take this opportunity to refactor them to improve readability.
Differential Revision: https://phabricator.services.mozilla.com/D102700
Now that network resources are enabled on the server, RDM is using the network actor
to control network throttling.
We can remove all the RDM client code that was still trying to call the responsive actor.
We can't remove the methods from the ResponsiveActor yet though, since the Netmonitor
will use it when there's no network resource server side support, which is still
the case for the Browser Toolbox.
Differential Revision: https://phabricator.services.mozilla.com/D102766
This patch switches all the calls to `startListeners["NetworkActivity"]` to watching
for network resources instead.
We take this opportunity to refactor them to improve readability.
Differential Revision: https://phabricator.services.mozilla.com/D102700
`generateInlinePreview` had a typo (`actorID` -> `actor`) that prevented object properties from being loaded,
so on a given line, we would show the whole object in the inline preview instead of only the property being used
(e.g. if line is `const y = x.a`, we want the preview only for `x.a`, not for the whole `x` object).
A test case is added to ensure we don't regress this in the future, and object inspector jest tests are updated
so they don't throw.
Differential Revision: https://phabricator.services.mozilla.com/D100064
This adds a navigation test for every storage type (except Extension storage) in the storage panel. They currently pass on Fission, but fail when Fission is disabled.
Differential Revision: https://phabricator.services.mozilla.com/D102412
The test is split in two to make it easier to read.
The test was quite old and still had references to the Params panel, which is
now removed.
The test was also failing when checking the stacktrace, and this was due to an
issue from the webconsole messsage reducer where we would completly replace
the `networkMessagesUpdateById` on NETWORK_MESSAGES_UPDATE, and that would lead
to the stracktrace being removed.
In the Stacktrace component, we prevent fetching the stacktrace if it's already
available.
Differential Revision: https://phabricator.services.mozilla.com/D56884
Corrected the warning about when text-overflow has no effect including different settings for overflow-x and overflow-y depending on the writing mode.
Depends on D102814
Differential Revision: https://phabricator.services.mozilla.com/D102815
In order to be able to reuse the check for whether a note has a vertical writing mode, the logic got split out from the table track parent method into its own method.
Differential Revision: https://phabricator.services.mozilla.com/D102814
The test is split in two to make it easier to read.
The test was quite old and still had references to the `Params` panel, which was
renamed to `Request`.
The test was also failing when checking the stacktrace, and this was due to an
issue from the webconsole messsage reducer where we would completely replace
the `networkMessagesUpdateById` on NETWORK_MESSAGES_UPDATE, and that would lead
to the stracktrace being removed.
In the Stacktrace component, we prevent fetching the stacktrace if it's already
available.
Differential Revision: https://phabricator.services.mozilla.com/D56884
Thread actor's options are shared across all the toolboxes,
so that when you set any type of breakpoints, they will be passed to all the thread actor.
All the thread actor, of all the toolboxes.
So that when you set a breakpoint in the content toolbox,
they may be set in the browser toolbox and also in the browser console.
Here, we avoid doing anything around the thread actor when we are in the context
of the browser console, so that we avoid setting up any type of breakpoint.
They are set when calling ThreadActor.attach().
Differential Revision: https://phabricator.services.mozilla.com/D102907
This adds a test for the :screenshot command with the --selector argument.
We're also checking that using the command while selecting another target
in the context selector works as expected.
The test is skipped on non-fission since the context selector isn't enabled
when fission is disabled.
Differential Revision: https://phabricator.services.mozilla.com/D102597
This patch modified the existing test for :screenshot ${filename} to actually
check some pixels of the resulting file.
The test document is modified to include 2 iframes, one remote and the other one
on the same origin, with different background colors so we can check in the test
that the content of the iframes are rendered in the screenshot.
We add a `fail-if=fission` annotation to the test since our screenshot support
does not support rendering remote iframe when fission is enabled. This should
be fixed with the work on Bug 1678483, and the fail-if would highlight that.
Differential Revision: https://phabricator.services.mozilla.com/D102596
A fix was made in Bug 961832 to ensure fixed elements would be rendered at the
right position in the screenshot when the page was scrolled down.
Unfortunately there wasn't any test associated, so this patch adds one.
A new helper function is added into shared-head so we can assert the color of
an image at a given position.
The test does fails if we revert the changes made in Bug 961832.
Differential Revision: https://phabricator.services.mozilla.com/D102595
We're going to use some of the function provided by this
helper in console tests, so it feels better to move the
content of the file in shared-head so all panels can benefit
from it.
Differential Revision: https://phabricator.services.mozilla.com/D102752
As we weren't waiting for pause when calling the first debugger statement,
things were very much confused in `stepOvers`. We were asserting the initial debugger statement frame,
while, in `stepOvers` waiting for the first step over "paused" event.
Differential Revision: https://phabricator.services.mozilla.com/D102896
The two "location" expressions being added, removed and re-added
are mixed up in the UI if we don't wait for the evaluation of the first,
before removing and re-adding it.
Differential Revision: https://phabricator.services.mozilla.com/D102323
This is the simple step, where we move the ThreadFront code related to pauses
from Debugger frontend to a legacy listener.
The next patch is the hard one, which will replace paused/resumed events by resources.
It may sound weird to have pause and resume to becomes resources,
as they aren't really resources. These are transcient events, which we don't
really want to record. We especially do not really care to save them in the ResourceWatcher cache.
But, by becoming resources, we benefit from the resources framework, which allows to:
* listen and emit such event as early as the page/target starts loading
* do not depend on a particular front to be ready/attached on the frontend
* once we communicate to the watcher we care about breakpoints, we do register the breakpoint listening code for all the targets.
(we no longer have to do a per-target work in the frontend)
Differential Revision: https://phabricator.services.mozilla.com/D88851
This matches other browsers, and the default themed textareas on Windows
too.
To be landed after the soft freeze, just in case, of course.
Differential Revision: https://phabricator.services.mozilla.com/D102843
Nicolas Chevobbe
Julian Descottes
Anurag Kalia
Masayuki Nakano
Sebastian Zartner
Hubert Boma Manilla
smolnar
wartmanm
Belén Albeza
Alexandre Poirot
Mark Banner
Brindusan Cristian
Daniel Holbert
Dimi Lee
Butkovits Atila
Emilio Cobos Álvarez