930543e681
Bug 1687235 - Enable ESLint rule no-setter-return for toolkit and services. r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D102153
2021-01-26 13:43:58 +00:00
70ab748bed
Backed out 5 changesets (bug 1687235) for mochitest failures at test_menulist_null_value.xhtml. CLOSED TREE
...
Backed out changeset 638c802ca1d1 (bug 16872351687235168723516872351687235
2021-01-26 10:58:43 +02:00
9cbc91833a
Bug 1687235 - Enable ESLint rule no-setter-return for toolkit and services. r=mossop
...
Depends on D102152
Differential Revision: https://phabricator.services.mozilla.com/D102153
2021-01-25 22:27:01 +00:00
fa664601db
Bug 1654684 - Add sheet-indicator and preview navigation to the print preview. r=mstriemer,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D96737
2020-12-09 20:56:28 +00:00
4eae934956
Backed out 2 changesets (bug 1654684) for browser chrome failures with .printPreviewCurrentPageNumber. CLOSED TREE
...
Backed out changeset 2fdc1b5569e1 (bug 1654684)
Backed out changeset 8ae1d037aa9c (bug 1654684)
2020-12-09 16:11:42 +02:00
0c4bb65e4d
Bug 1654684 - Add sheet-indicator and preview navigation to the print preview. r=mstriemer,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D96737
2020-12-09 02:59:26 +00:00
6474307318
Backed out 2 changesets (bug 1654684) for bc failures at browser_ext_tabs_printPreview. CLOSED TREE
...
Backed out changeset 5a0333ca8a19 (bug 1654684)
Backed out changeset 87d06a4d6ab6 (bug 1654684)
2020-12-07 12:59:10 +02:00
61cfb019d9
Bug 1654684 - Add sheet-indicator and preview navigation to the print preview. r=mstriemer,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D96737
2020-12-07 08:44:14 +00:00
a2c02d9e75
Bug 1627520 - Use keydown instead of keypress for autocomplete event listeners. r=mak,Gijs
...
This is so that we can avoid needing mozSystemGroup (to get keypress for
non-printable keys), which in turn prevents racing with the native key event
listeners, see the second patch in bug 1624657.
This turned out to be a bit tricky, because we need to guarantee the ordering of
the search one-offs handling in the searchbar with the usual autocomplete-input
handling. We could try to move this to the popup subclass but this is already a
bigger patch than what I'd like.
We can also revert the customElements.js change I did in bug 1624657, as the bug
is no longer relevant.
Differential Revision: https://phabricator.services.mozilla.com/D69743
--HG--
extra : moz-landing-system : lando
2020-04-14 20:48:26 +00:00
52f29c9810
Backed out changeset b92904ec121f (bug 1627520) for browser_searchbar_keyboard_navigation.js failures CLOSED TREE
2020-04-14 16:58:35 +03:00
d547edb535
Bug 1627520 - Use keydown instead of keypress for autocomplete event listeners. r=mak,Gijs
...
This is so that we can avoid needing mozSystemGroup (to get keypress for
non-printable keys), which in turn prevents racing with the native key event
listeners, see the second patch in bug 1624657.
This turned out to be a bit tricky, because we need to guarantee the ordering of
the search one-offs handling in the searchbar with the usual autocomplete-input
handling. We could try to move this to the popup subclass but this is already a
bigger patch than what I'd like.
We can also revert the customElements.js change I did in bug 1624657, as the bug
is no longer relevant.
Differential Revision: https://phabricator.services.mozilla.com/D69743
--HG--
extra : moz-landing-system : lando
2020-04-14 12:42:16 +00:00
a7282ce447
Bug 1590573, create a unified approach for caching fragments in our Custom Elements r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D58866
--HG--
extra : moz-landing-system : lando
2020-04-08 16:17:50 +00:00
072b678c5a
Backed out changeset 6b7c81561ecc (bug 1590573) for marionette perma failures on test_refresh_firefox.py. CLOSED TREE
2020-04-08 07:43:49 +03:00
b657384896
Bug 1590573, create a unified approach for caching fragments in our Custom Elements r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D58866
--HG--
extra : moz-landing-system : lando
2020-04-07 23:56:45 +00:00
efbf711e30
Bug 1624657 - Eagerly load autocomplete-input custom element. r=Gijs
...
My patch causes an interesting regression. We stop constructing custom elements
for the stuff inside the edit-bookmark-panel as expected. This means that the
autocomplete-input here:
https://searchfox.org/mozilla-central/rev/3f9e822318e8ec18ce673a9cb983d3608a3e2ed2/browser/components/places/content/editBookmarkPanel.inc.xhtml#81
Doesn't cause autocomplete-input.js to load. That means that it'll load by the
time the searchbar-textbox autocomplete is created, which means that it'll get
upgraded asynchronously. So far so good. However there's an interesting race due
to the way keypress event listeners are setup in autocomplete-input.js. In
particular, it uses the capture phase and the system group:
https://searchfox.org/mozilla-central/rev/3f9e822318e8ec18ce673a9cb983d3608a3e2ed2/toolkit/content/widgets/autocomplete-input.js#38
This means it'll race with the other native / system group event listeners that
get added by the editor component. This caused arrow-up / arrow-down to not work
on the searchbar because the custom element was upgraded async.
This kinda papers over the issue the same way editBookmarkPanel was papering
over it, but ideally we should figure out a way to not use the system group or
keypress there so that we don't race in this awful way. Separate bug, probably.
Differential Revision: https://phabricator.services.mozilla.com/D69730
--HG--
extra : moz-landing-system : lando
2020-04-05 18:36:00 +00:00
9f4dbeaf3c
Bug 1625982 - Rename textbox.js and textbox.css to moz-input-box.js and search-textbox.css. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D68829
--HG--
rename : toolkit/content/widgets/textbox.js => toolkit/content/widgets/moz-input-box.js
rename : toolkit/themes/linux/global/textbox.css => toolkit/themes/linux/global/search-textbox.css
rename : toolkit/themes/osx/global/textbox.css => toolkit/themes/osx/global/search-textbox.css
rename : toolkit/themes/windows/global/textbox.css => toolkit/themes/windows/global/search-textbox.css
extra : moz-landing-system : lando
2020-03-30 18:22:56 +00:00
2c4e35b0a6
Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D65509
--HG--
extra : moz-landing-system : lando
2020-03-08 21:45:16 +00:00
b7f5c4a0d2
Bug 1531455 - Don't load extra custom elements in GeckoView. r=bgrins
...
GeckoView only needs the browser element, skip loading the rest.
Differential Revision: https://phabricator.services.mozilla.com/D63360
--HG--
extra : moz-landing-system : lando
2020-02-19 20:13:42 +00:00
75ea156d47
Bug 1601093, Rename the remaining .xul files to .xhtml in toolkit/ r=marionette-reviewers,mossop,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D55857
--HG--
rename : toolkit/components/alerts/resources/content/alert.xul => toolkit/components/alerts/resources/content/alert.xhtml
rename : toolkit/components/apppicker/content/appPicker.xul => toolkit/components/apppicker/content/appPicker.xhtml
rename : toolkit/components/extensions/dummy.xul => toolkit/components/extensions/dummy.xhtml
rename : toolkit/components/passwordmgr/content/passwordManager.xul => toolkit/components/passwordmgr/content/passwordManager.xhtml
rename : toolkit/components/printing/content/printPageSetup.xul => toolkit/components/printing/content/printPageSetup.xhtml
rename : toolkit/components/printing/content/printPreviewProgress.xul => toolkit/components/printing/content/printPreviewProgress.xhtml
rename : toolkit/components/printing/content/printProgress.xul => toolkit/components/printing/content/printProgress.xhtml
rename : toolkit/components/prompts/content/commonDialog.xul => toolkit/components/prompts/content/commonDialog.xhtml
rename : toolkit/components/prompts/content/selectDialog.xul => toolkit/components/prompts/content/selectDialog.xhtml
rename : toolkit/components/viewconfig/content/config.xul => toolkit/components/viewconfig/content/config.xhtml
rename : toolkit/content/editMenuKeys.inc.xul => toolkit/content/editMenuKeys.inc.xhtml
rename : toolkit/content/resetProfile.xul => toolkit/content/resetProfile.xhtml
rename : toolkit/content/resetProfileProgress.xul => toolkit/content/resetProfileProgress.xhtml
rename : toolkit/modules/win.xul => toolkit/modules/win.xhtml
rename : toolkit/profile/content/createProfileWizard.xul => toolkit/profile/content/createProfileWizard.xhtml
rename : toolkit/profile/content/profileDowngrade.xul => toolkit/profile/content/profileDowngrade.xhtml
rename : toolkit/profile/content/profileSelection.xul => toolkit/profile/content/profileSelection.xhtml
extra : moz-landing-system : lando
2019-12-11 17:44:54 +00:00
824bc2bf90
Backed out changeset dd809e835f2a (bug 1601093) for eslint failures at alert.xhtml and commonDialog.xhtml on a CLOSED TREE.
...
--HG--
rename : toolkit/components/alerts/resources/content/alert.xhtml => toolkit/components/alerts/resources/content/alert.xul
rename : toolkit/components/apppicker/content/appPicker.xhtml => toolkit/components/apppicker/content/appPicker.xul
rename : toolkit/components/extensions/dummy.xhtml => toolkit/components/extensions/dummy.xul
rename : toolkit/components/passwordmgr/content/passwordManager.xhtml => toolkit/components/passwordmgr/content/passwordManager.xul
rename : toolkit/components/printing/content/printPageSetup.xhtml => toolkit/components/printing/content/printPageSetup.xul
rename : toolkit/components/printing/content/printPreviewProgress.xhtml => toolkit/components/printing/content/printPreviewProgress.xul
rename : toolkit/components/printing/content/printProgress.xhtml => toolkit/components/printing/content/printProgress.xul
rename : toolkit/components/prompts/content/commonDialog.xhtml => toolkit/components/prompts/content/commonDialog.xul
rename : toolkit/components/prompts/content/selectDialog.xhtml => toolkit/components/prompts/content/selectDialog.xul
rename : toolkit/components/viewconfig/content/config.xhtml => toolkit/components/viewconfig/content/config.xul
rename : toolkit/content/editMenuKeys.inc.xhtml => toolkit/content/editMenuKeys.inc.xul
rename : toolkit/content/resetProfile.xhtml => toolkit/content/resetProfile.xul
rename : toolkit/content/resetProfileProgress.xhtml => toolkit/content/resetProfileProgress.xul
rename : toolkit/modules/win.xhtml => toolkit/modules/win.xul
rename : toolkit/profile/content/createProfileWizard.xhtml => toolkit/profile/content/createProfileWizard.xul
rename : toolkit/profile/content/profileDowngrade.xhtml => toolkit/profile/content/profileDowngrade.xul
rename : toolkit/profile/content/profileSelection.xhtml => toolkit/profile/content/profileSelection.xul
2019-12-11 19:27:28 +02:00
106f09dd53
Bug 1601093, Rename the remaining .xul files to .xhtml in toolkit/ r=marionette-reviewers,mossop,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D55857
--HG--
rename : toolkit/components/alerts/resources/content/alert.xul => toolkit/components/alerts/resources/content/alert.xhtml
rename : toolkit/components/apppicker/content/appPicker.xul => toolkit/components/apppicker/content/appPicker.xhtml
rename : toolkit/components/extensions/dummy.xul => toolkit/components/extensions/dummy.xhtml
rename : toolkit/components/passwordmgr/content/passwordManager.xul => toolkit/components/passwordmgr/content/passwordManager.xhtml
rename : toolkit/components/printing/content/printPageSetup.xul => toolkit/components/printing/content/printPageSetup.xhtml
rename : toolkit/components/printing/content/printPreviewProgress.xul => toolkit/components/printing/content/printPreviewProgress.xhtml
rename : toolkit/components/printing/content/printProgress.xul => toolkit/components/printing/content/printProgress.xhtml
rename : toolkit/components/prompts/content/commonDialog.xul => toolkit/components/prompts/content/commonDialog.xhtml
rename : toolkit/components/prompts/content/selectDialog.xul => toolkit/components/prompts/content/selectDialog.xhtml
rename : toolkit/components/viewconfig/content/config.xul => toolkit/components/viewconfig/content/config.xhtml
rename : toolkit/content/editMenuKeys.inc.xul => toolkit/content/editMenuKeys.inc.xhtml
rename : toolkit/content/resetProfile.xul => toolkit/content/resetProfile.xhtml
rename : toolkit/content/resetProfileProgress.xul => toolkit/content/resetProfileProgress.xhtml
rename : toolkit/modules/win.xul => toolkit/modules/win.xhtml
rename : toolkit/profile/content/createProfileWizard.xul => toolkit/profile/content/createProfileWizard.xhtml
rename : toolkit/profile/content/profileDowngrade.xul => toolkit/profile/content/profileDowngrade.xhtml
rename : toolkit/profile/content/profileSelection.xul => toolkit/profile/content/profileSelection.xhtml
extra : moz-landing-system : lando
2019-12-11 17:02:20 +00:00
1e0a408b10
Bug 1592141, look for xul ns root element within customElement.js r=zbraniecki
...
Differential Revision: https://phabricator.services.mozilla.com/D52291
--HG--
extra : moz-landing-system : lando
2019-11-11 19:20:28 +00:00
0e30d06762
Bug 1591761 - parseXULToFragment should throw a clearer exception for non-well-formed markup. r=bgrins
...
***
Bug 1591671, revert a breaking change in calling DOMParser.
Differential Revision: https://phabricator.services.mozilla.com/D50729
--HG--
extra : moz-landing-system : lando
2019-10-29 23:04:14 +00:00
6b1e67496e
Backed out changeset 8799781bbf34 (bug 1591761) for causing mass test failures. on a CLOSED TREE
2019-10-29 01:19:11 +02:00
369ca66a21
Bug 1591761 - parseXULToFragment should throw a clearer exception for non-well-formed markup. r=bgrins
...
Differential Revision: https://phabricator.services.mozilla.com/D50729
--HG--
extra : moz-landing-system : lando
2019-10-28 21:59:59 +00:00
f6aae7a3e7
Bug 1397876 - Replace panel and arrowpanel bindings with a custom element r=bgrins
...
Differential Revision: https://phabricator.services.mozilla.com/D35040
--HG--
rename : toolkit/content/widgets/popup.xml => toolkit/content/widgets/panel.js
extra : moz-landing-system : lando
2019-10-07 21:57:04 +00:00
34fa4fa528
Bug 1514926 - Convert the arrowscrollbox binding to a Custom Element r=dao
...
This uses Shadow DOM slotting instead of XBL, and migrates styles from
using XBL anonymous traversal to using CSS Shadow Parts.
This also removes the basecontrol binding, since this was the last
binding to extend it.
Differential Revision: https://phabricator.services.mozilla.com/D43651
--HG--
rename : toolkit/content/widgets/scrollbox.xml => toolkit/content/widgets/arrowscrollbox.js
extra : moz-landing-system : lando
2019-10-03 04:21:15 +00:00
d1c4f9139e
Backed out changeset 5e221240fc1d (bug 1514926) for mochitest failures in browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js
...
--HG--
rename : toolkit/content/widgets/arrowscrollbox.js => toolkit/content/widgets/scrollbox.xml
2019-10-03 06:08:18 +03:00
98a08a3ce4
Bug 1514926 - Convert the arrowscrollbox binding to a Custom Element r=dao
...
This uses Shadow DOM slotting instead of XBL, and migrates styles from
using XBL anonymous traversal to using CSS Shadow Parts.
This also removes the basecontrol binding, since this was the last
binding to extend it.
Differential Revision: https://phabricator.services.mozilla.com/D43651
--HG--
rename : toolkit/content/widgets/scrollbox.xml => toolkit/content/widgets/arrowscrollbox.js
extra : moz-landing-system : lando
2019-10-02 22:57:39 +00:00
660aac23aa
Bug 1467970 - Unsupport cross docGroup adoption r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D43135
--HG--
extra : moz-landing-system : lando
2019-09-14 00:09:44 +00:00
e043df8d78
Bug 1534455 - Convert autocomplete binding to a customized input element. r=dao,bgrins
...
Differential Revision: https://phabricator.services.mozilla.com/D33250
--HG--
rename : toolkit/content/widgets/autocomplete.xml => toolkit/content/widgets/autocomplete-input.js
extra : moz-landing-system : lando
2019-09-17 06:22:42 +00:00
f9580519b8
Backed out changeset e859a5aebb5b (bug 1534455) for causing failures at test_bug437844.xul
...
--HG--
rename : toolkit/content/widgets/autocomplete-input.js => toolkit/content/widgets/autocomplete.xml
2019-09-17 07:51:36 +03:00
5d8a3da397
Bug 1534455 - Convert autocomplete binding to a customized input element. r=dao,bgrins
...
Differential Revision: https://phabricator.services.mozilla.com/D33250
--HG--
rename : toolkit/content/widgets/autocomplete.xml => toolkit/content/widgets/autocomplete-input.js
extra : moz-landing-system : lando
2019-09-17 01:35:25 +00:00
ea6fd457ff
Bug 1545824 - Implement a getElementForAttrInheritance function r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D39210
--HG--
extra : moz-landing-system : lando
2019-07-30 15:11:26 +00:00
0773795931
Bug 1561435 - Format toolkit/content/, a=automatic-formatting
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D36053
--HG--
extra : source : 651d8f947a29f5d80b7e833f7e6b99e2afe8bf9d
2019-07-05 11:14:49 +02:00
61cc7103cf
Bug 1544916 - migrate dialog binding to Custom Element r=bgrins,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D30289
--HG--
rename : toolkit/content/widgets/dialog.xml => toolkit/content/widgets/dialog.js
extra : moz-landing-system : lando
2019-06-04 17:28:16 +00:00
a745ec6099
Bug 1519577 Convert toolbarbutton to a custom element r=surkov
...
Differential Revision: https://phabricator.services.mozilla.com/D31941
--HG--
extra : rebase_source : 3709ef713f1a7dc9fbc2d0ac97f16bea757fcd2b
2019-05-20 10:01:02 -07:00
c1f5b7a338
Bug 1521280 - Convert search-textbox to a custom element. r=dao,bgrins
...
Differential Revision: https://phabricator.services.mozilla.com/D23045
--HG--
rename : toolkit/content/widgets/textbox.xml => toolkit/content/widgets/search-textbox.js
extra : moz-landing-system : lando
2019-05-13 18:12:37 +00:00
cc280c4be9
Backed out changeset c5798de806e2 (bug 1521280) for crashing when searching about:config for upcoming beta (bug 1551013)
...
--HG--
extra : rebase_source : 8f936159c23d09bf227ce4f5eb6f2d96d33bbff1
2019-05-13 08:50:28 +03:00
1a57aab68e
Bug 1521280 - Convert search-textbox to a custom element. r=dao,bgrins
...
Differential Revision: https://phabricator.services.mozilla.com/D23045
--HG--
rename : toolkit/content/widgets/textbox.xml => toolkit/content/widgets/search-textbox.js
extra : moz-landing-system : lando
2019-05-10 11:46:49 +00:00
444ee13e14
Merge mozilla-inbound to mozilla-central a=merge
2019-04-26 12:46:15 +03:00
4663e6262a
Bug 1448213 - Migrate label-control to a Custom Element r=surkov
...
Differential Revision: https://phabricator.services.mozilla.com/D5686
--HG--
extra : moz-landing-system : lando
2019-04-23 20:16:46 +00:00
66e382f5b2
Bug 1538983 Convert button xbl binding to a custom element r=bgrins
...
As of this change, instances of xul <button> use a custom element.
The button-base xbl binding remains for now, since it is still used
by toolbarbutton, it will be removed soon.
Differential Revision: https://phabricator.services.mozilla.com/D27742
--HG--
rename : toolkit/content/widgets/button.xml => toolkit/content/widgets/button.js
extra : rebase_source : 2be8ee3fa9bb43866013f62211d8cb3706dbf1ab
2019-04-15 14:27:32 -07:00
9835cc7787
Bug 1546024 - Clear the _inheritedElements cache on chrome custom elements when re-calling initializeAttributeInheritance r=surkov
...
Otherwise we can end up setting the proper attribute on removed children when elements get disconnected
and reconnected.
Differential Revision: https://phabricator.services.mozilla.com/D28306
--HG--
extra : moz-landing-system : lando
2019-04-22 13:52:17 +00:00
a7ca3ac30d
Bug 1545865 Handle inherited attributes overridden by derived element classes r=bgrins
...
The existing implementation of inherited attributes keeps a data
structure in a property on the class, but derived classes were
unintentionally getting that structure from their parent class,
preventing derived classes from declaring a different set of inherited
attributes.
Differential Revision: https://phabricator.services.mozilla.com/D28255
--HG--
extra : moz-landing-system : lando
2019-04-20 16:22:10 +00:00
2787623601
Bug 1545765 - Fix attribute inheritance for empty attribute values r=aswan
...
This accidentally got dropped in Bug 1528268.
Differential Revision: https://phabricator.services.mozilla.com/D28251
--HG--
extra : moz-landing-system : lando
2019-04-19 21:07:40 +00:00
9bda39c108
Bug 1519502 - Convert menu bindings to a Custom Element r=surkov
...
Differential Revision: https://phabricator.services.mozilla.com/D19593
--HG--
extra : moz-landing-system : lando
2019-04-18 16:41:46 +00:00
7621a8bf3a
Bug 1528268 - Make initializeAttributeInheritance and incremental attribute changes do less work r=aswan
...
This provides a flipped data structure based on the provided inheritedAttributes,
which looks like:
Object<selector, attrs_to_inherit_comma_separated>
To one that looks like:
Object<attr, Array<Array<selector, attr_to_inherit>>
This should improve performance because:
1) We only fetch element at connectedCallback that actually will have attributes inherited.
2) When an attribute changes we can quickly inherit only that one.
Differential Revision: https://phabricator.services.mozilla.com/D27801
--HG--
extra : moz-landing-system : lando
2019-04-18 16:41:39 +00:00
f5a2c905f4
Backed out 2 changesets (bug 1519502, bug 1528268) for Crashtest failures in toolkit/content/tests/chrome/test_popupincontent.xul. CLOSED TREE
...
Backed out changeset 904cc7903feb (bug 1519502)
Backed out changeset f8770d7eebd1 (bug 1528268)
2019-04-18 18:26:41 +03:00
d48d388df2
Bug 1519502 - Convert menu bindings to a Custom Element r=surkov
...
Differential Revision: https://phabricator.services.mozilla.com/D19593
--HG--
extra : moz-landing-system : lando
2019-04-17 15:56:41 +00:00
Mark Banner
Brindusan Cristian
Sam Foster
Csoregi Natalia
Emilio Cobos Álvarez
Bogdan Tara
Emma Malysz
Razvan Maries
Tim Nguyen
Brendan Dahl
Gurzau Raul
Alexander J. Vincent
Oana Pop Rus
Alexander Surkov
Brian Grinstead
Dorel Luca
Sean Feng
Mihai Alexandru Michis
Paul Morris
Victor Porof
Andrew Swan
Coroiu Cristina