With all of our builds in Taskcluster now, we should never be uploading
symbols from build tasks. Unfortunately Windows builds were still doing so.
This patch removes MOZ_AUTOMATION_UPLOAD_SYMBOLS from all the in-tree
mozconfigs and a few other places so that it should always default off
(per moz-automation.mk). The rest of the uploadsymbols bits will be
removed once Thunderbird fixes their automation.
This patch was mostly autogenerated by running:
rg --files-with-matches UPLOAD_SYMBOLS browser/config/mozconfigs/ mobile/android/config/mozconfigs/ | xargs sed -ri '/.*UPLOAD_SYMBOLS.*/d'
sed -ri '/.*UPLOAD_SYMBOLS.*/d' build/unix/mozconfig.linux build/mozconfig.win-common build/macosx/local-mozconfig.common build/mozconfig.automation
Then mobile/android/config/mozconfigs/common and
taskcluster/scripts/builder/build-linux.sh were hand-edited.
MozReview-Commit-ID: Cy8kSEodSg4
--HG--
extra : rebase_source : 01caf1651b4eb428313e1f371aa585f8f34c4151
Also remove related code that was only used from here including
stuff related to marketplace purchases, etc.
MozReview-Commit-ID: ESX78tVQK7M
--HG--
extra : rebase_source : 56d956168f75cdc40fd3df057e41493f80733352
This pushes all of the magic Gradle targets into gradle.configure,
which is the most accessible central place for them. Some impact the
build, so they almost certainly need to be in moz.configure; and its
better to have one central place to update than many places.
Gradle has a notion of configurations. Fennec determines many
configurations, only one of which is used in automation; and right
now, that one is "officialPhotonDebug". Evolving the "one true"
configuration is frustrating, and this helps with that. Post
Android-Gradle plugin 3.0+, we can do better and also extract the
configuration details for the :geckoview and :geckoview_example Gradle
projects, but right now they are ad-hoc and can't really be improved.
MozReview-Commit-ID: LdGE05zn2H1
--HG--
extra : rebase_source : db7e9fe90f2bd1ae5058af046a66edd0cd549141
These magic locations evolve over time. Baking them into
moz.configure is the easiest way to share them across the build
system, and pushing them into a new |mach android *| command continues
a pattern that has been very successful.
MozReview-Commit-ID: CyxVQ0LHHgl
--HG--
extra : rebase_source : 8350d71665f0126aa4ee2c8fec32c4b8e34dc772
This was in Gradle due to history. When this first landed, we invoked
Gradle directly from the mozharness, and the best way to print the
report URLs was from Gradle itself. When the Android Gradle suites
were made tier 1, little harnesses (|mach android
{checkstyle,findbugs,lint,test}|) were written and invoked locally and
in automation. This functionality should have migrated with them.
This removes the special Gradle target names from the Gradle
configuration, making it easier to change them in the future.
MozReview-Commit-ID: 1KPd3J5t82Q
--HG--
extra : rebase_source : 1da85e31c113bc9da138817bebf981af8b9b66dd
We've had good success with |mach android *| for invoking test suites
and other Gradle-related features; this was just an oversight. The
real advantage is that almost all of the magic Gradle targets are now
in mobile/android/mach_commands.py and not scattered throughout the
tree. That'll make it easier to move the actual Gradle configuration
choices forward in the future.
MozReview-Commit-ID: GI1pUHHfXeO
--HG--
extra : rebase_source : 9d7b98e968a2537f8dd1ffd0646c51ffe429bd57
This pushes all of the magic Gradle targets into gradle.configure,
which is the most accessible central place for them. Some impact the
build, so they almost certainly need to be in moz.configure; and its
better to have one central place to update than many places.
Gradle has a notion of configurations. Fennec determines many
configurations, only one of which is used in automation; and right
now, that one is "officialPhotonDebug". Evolving the "one true"
configuration is frustrating, and this helps with that. Post
Android-Gradle plugin 3.0+, we can do better and also extract the
configuration details for the :geckoview and :geckoview_example Gradle
projects, but right now they are ad-hoc and can't really be improved.
MozReview-Commit-ID: LdGE05zn2H1
--HG--
extra : rebase_source : 3cf360a814ed4927ec6c767b42448285ed2ffb35
These magic locations evolve over time. Baking them into
moz.configure is the easiest way to share them across the build
system, and pushing them into a new |mach android *| command continues
a pattern that has been very successful.
MozReview-Commit-ID: CyxVQ0LHHgl
--HG--
extra : rebase_source : 8350d71665f0126aa4ee2c8fec32c4b8e34dc772
This was in Gradle due to history. When this first landed, we invoked
Gradle directly from the mozharness, and the best way to print the
report URLs was from Gradle itself. When the Android Gradle suites
were made tier 1, little harnesses (|mach android
{checkstyle,findbugs,lint,test}|) were written and invoked locally and
in automation. This functionality should have migrated with them.
This removes the special Gradle target names from the Gradle
configuration, making it easier to change them in the future.
MozReview-Commit-ID: 1KPd3J5t82Q
--HG--
extra : rebase_source : 1da85e31c113bc9da138817bebf981af8b9b66dd
We've had good success with |mach android *| for invoking test suites
and other Gradle-related features; this was just an oversight. The
real advantage is that almost all of the magic Gradle targets are now
in mobile/android/mach_commands.py and not scattered throughout the
tree. That'll make it easier to move the actual Gradle configuration
choices forward in the future.
MozReview-Commit-ID: GI1pUHHfXeO
--HG--
extra : rebase_source : 9d7b98e968a2537f8dd1ffd0646c51ffe429bd57
On nightly and aurora we have supplemental strings about Telemetry in the About
dialog/section. However, we already open the data policy tab (Desktop) and
notification (Mobile) on nightly, aurora, -and beta- to more accurately tell
users about our data policies.
So let's remove the inconsistently-applied semi-hard-to-find strings.
MozReview-Commit-ID: 3zjXQwi9r7v
--HG--
extra : rebase_source : af9728dd1ff2161ff028f85ebf7f93c22eae0181
This patch moves us from using an old pref `general.useragent.locale`combined
with `intl.locale.matchOS` for retrieving user requested locale, to use a new
preference `intl.locale.requested` which stores a list of well-formed BCP47
language tags. If set to empty, the OS locales are used. If not set at all,
default locale is used.
We are also adding a piece of code to migrate from old to new system.
MozReview-Commit-ID: 854yQ1kC6Ee
--HG--
extra : rebase_source : c4a7171bc026f857f7878ee83d973ec01b536a84
Remove unused classes and make classes that are not used outside of the
package package-private.
MozReview-Commit-ID: 9FxcL5QsM1Q
--HG--
extra : rebase_source : d9ed39d06a0e2aadec131d06c92cb11ef342a320
Use o.m.g.util.BitmapUtils in code that use BitmapUtils.
MozReview-Commit-ID: KPM05Aqf1kW
--HG--
extra : rebase_source : ea910333fc195b329ef41bf168d0299584e63d20
I think BitmapUtils is better suited for the o.m.g.util package instead
of o.m.g.gfx, since none of the other classes in gfx actually use
BitmapUtils.
MozReview-Commit-ID: IEwSIb5h9Y7
--HG--
rename : mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/BitmapUtils.java => mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/BitmapUtils.java
extra : rebase_source : 3960fbd5172b745b3a41d1da8e855a2a539ed906
Since the readerized article content will have its class names stripped
but will retain its original IDs, and we don't want our aboutReader.css
rules targetting UI elements to match anything in the article.
MozReview-Commit-ID: JuXTo8Nth5Q
--HG--
extra : rebase_source : dde58f56e55f82ddda364ec5978e43fe71be875c
As of bug 1257362, the platform does not verify code signing certificates in
general, so anything involving the code signing trust of certificates can go.
MozReview-Commit-ID: 9g9kM62xfYZ
--HG--
extra : rebase_source : 5bec64e5f451c8433aff0de82a91f7bd54c24608
assertUrl wasn't used before and getUrlEditText().getText() returns a
SpannableStringBuilder, so we need to add a toString() conversion there in order
to successfully use it.
MozReview-Commit-ID: 9BtZWDRstdD
--HG--
extra : rebase_source : bef971f37f99f60baad4fe1c88f2ef7b6b9e6f2f
The technique for setting our icon is just a straight reimplementation
of bug 1210242.
Because of the way the new tab might be opened from within a
processActionViewIntent Runnable, we can't enter editing mode by simply
listening for an ACTION_ASSIST intent from within BrowserApp, as we need to
enter editing mode *after* the correct tab has already been opened and selected
and BrowserApp doesn't get any hint on when that Runnable might have run.
Instead, we introduce a new tab event, so we can trigger editing mode at the
right time via the tab itself.
MozReview-Commit-ID: 8Bvv5TXyhhI
--HG--
extra : rebase_source : 92f6131098e1c2a8e810431aa82e68e7e422cfd1
Remove LayerView now that it's no longer used. FullScreenState is
obsolete as well and is removed.
MozReview-Commit-ID: Jt7OMAoarOJ
--HG--
extra : rebase_source : da9285999fe093c41ea6d7693cf9255c0db1d688
Use the new CompositorController to access draw callbacks and pixel
getter. These methods now require calling on the UI thread, so the code
in Robocop now explicitly post runnables to the UI thread. Prior to
this, we were implicitly posting to the UI thread anyways, so the end
result is the same as before.
MozReview-Commit-ID: 7Mkjdc9hUNr
--HG--
extra : rebase_source : 821f72573200021604cdacf158d0989d1ecabf32
Use GeckoSession/LayerSession or GeckoView in Fennec code instead of
using LayerView.
MozReview-Commit-ID: Iod7XsqKy1e
--HG--
extra : rebase_source : 5917540422698f5526ca373f17c4358a712cdcef
Implement the setSurfaceBackgroundColor functionality in a new
coverUntilFirstPaint method. Because we no longer rely on any LayerView
functionality, GeckoView now inherits directly from FrameLayout.
MozReview-Commit-ID: 3xgWsgk64GM
--HG--
extra : rebase_source : 1185e40456ffce6c40676230e6f921dd0f3cbc3e
Add CompositorController and LayerSession.getCompositorController for
accessing miscellaneous compositor-related methods such as adding draw
callbacks and getting pixels.
A simple Runnable is used for draw callbacks instead of using the
DrawListener interface from LayerView. A first-paint callback is added
to implement the "clear surface background on first paint" requirement
when switching between documents in Fennec.
MozReview-Commit-ID: 8pE1B5HYe2w
--HG--
extra : rebase_source : abd35b189d04073c203b542fb9f9ef763027e117
Limit the number of SurfaceTextures to ensure that we do not reach the
process's fd limit. 200 was chosen as the limit because it allows for
more tiles than any reasonable page should require, yet should not
come close to the 1024 fd limit, even with 2 fds (buffer and sync
fence) per SurfaceTexture.
MozReview-Commit-ID: F21H1Rj4FVF
--HG--
extra : rebase_source : 379b460c8067cc3c5aa11a47cc66f865bae1ac64
Since the readerized article content will have its class names stripped
but will retain its original IDs, and we don't want our aboutReader.css
rules targetting UI elements to match anything in the article.
MozReview-Commit-ID: JuXTo8Nth5Q
--HG--
extra : rebase_source : a5987d80f45c3ec5192c1aa5da772a05cfda79ff
Since the readerized article content will have its class names stripped
but will retain its original IDs, and we don't want our aboutReader.css
rules targetting UI elements to match anything in the article.
MozReview-Commit-ID: JuXTo8Nth5Q
--HG--
extra : rebase_source : 87aa2f1060a1e7974610a109507a103c5366727a
ic_status_logo is what all the other notifications use, and flat_icon hasn't
been updated to the new photon logo.
MozReview-Commit-ID: Luo5ibVmXvk
--HG--
extra : rebase_source : 4e9335c177028ecdbe42bd69773494a2420f3700
Vietnamese (vi) is missing from the list of languages.
List of locales on single-locale builds is out of date.
MozReview-Commit-ID: 3zZ3MYAuBWB
--HG--
extra : rebase_source : f98d9af6d8c6db1b8195eab211576b303a18dc23
Remove NPZC references from LayerView, and add an NPZC getter in
LayerSession. Use the new APIs in GeckoView to forward events to NPZC.
MozReview-Commit-ID: 1UcJkpW0XuM
--HG--
extra : rebase_source : 6f50d1ca9398a2549678cc4e0fbb2578d284f63a
Clean up the NativePanZoomController object including,
1) Remove references to LayerView because NPZC will be created and used
by LayerSession.
2) Rename `mDestroyed` to `mAttached` because NPZC now needs to support
cases where it's used before being attached, in addition to after being
destroyed.
3) Move origin of synthesized event coordinates from the screen to the
surface in native code, so we don't need to do the same thing in Java.
4) Invoke all callbacks from native code on the UI thread.
MozReview-Commit-ID: Fu4XIY59yKw
--HG--
extra : rebase_source : cb4d432cb940cfa92f3c0a931f1f2d2991932462
There is some overscroll handling code in NativePanZoomController that
should be moved, along with other overscroll code in LayerView, to
LayerSession. LayerSession now provides a getter for
OverscrollEdgeEffect, which is cleaned up to have a public API with
documentation.
MozReview-Commit-ID: LkKHFS8OkR7
--HG--
extra : rebase_source : dc6b680b1cc7d7e2dd221091a63a208971d63c80
This should make the code slightly simpler to follow.
MozReview-Commit-ID: HrAv39eCtzb
--HG--
extra : rebase_source : 6c40a2f501705f50256dccea9534d9f8c1605c19
This uses the same anchors as the old code so should be low risk.
MozReview-Commit-ID: 7pA3SSRghv0
--HG--
extra : rebase_source : b7b4bb7afbd7569085416c5f1d74e714eef4216d
This is a regression by bug 1337078. When user selects system default for
Browser language, "locale" pref is empty. So BrowserLocaleManager.getLocale
always returns null. So, current locale is always en-US in Gecko code.
So we should return system locale when "locale" pref is empty.
Also, ReadSystemLocales expects language tag string for locale. Since
Locale.toString doesn't return language tag, so we should convert to it.
MozReview-Commit-ID: 3NhAkuA4HaH
--HG--
extra : rebase_source : 98e7c928e852391abe11b1b7ba19cc61d4924cea
AddToHomeScreenPromotion uses this for triggering the self-same promotion and
the BrowserToolbar uses it to update its progress display.
MozReview-Commit-ID: 1xrwjWP5Idh
--HG--
extra : rebase_source : 64d9ef66cf8427cccf3f84f59806cada9eddf842