55e2ac48d1
Lots and lots of bug fixes and XUL widget conversions. Work in progress, but must checkin to allow XPFE to fix bugs
2000-04-14 03:19:31 +00:00
0254b96365
Wrote RemoveAllInlineProperties() to deal with clearing out inline style, and also fixed a bunch of IME bugs.
2000-04-13 21:50:19 +00:00
af4644e7c8
making editor hip to inline style changes on collapsed selections. plus lots of removal of unused code.
2000-03-29 12:53:23 +00:00
fd8de8008f
small changes to clients of string converting APIs
2000-03-26 11:39:08 +00:00
94b179c77e
33208: Fix problem of editor not initializing on pages with JS. r=sfraser
2000-03-25 02:27:57 +00:00
0b23120401
improved paste performance in editor (WIP) (bug 28783)
set/remove inline stlye rewrite (lots of bug #s)
2000-03-24 00:26:47 +00:00
40a16fc16b
Fix miscellaneous editor leaks. r=jfrancis@netscape.com
2000-03-23 01:14:49 +00:00
901944bd23
Finished implementation of menu-driven table selection. Implemented detection of row or column selection. r=mjudge
2000-03-21 06:05:24 +00:00
6ea7fbcc1c
fix crashing bug 30120. check in for tajima@eng.sun.com since the crash is
...
verified and test on my machine. r=ftang, a=bobj. Will check into the beta
branch also.
2000-03-13 02:33:19 +00:00
ffe78e83e5
removed calls to deprecated string methods
2000-03-12 09:14:14 +00:00
3ecba57c7d
Fix for 17419. a=bobj@netscape.com, r=ftang@netscape.com
2000-03-10 01:30:07 +00:00
096edb7034
Expose the transaction manager to outside, for bug 18395. r=akkana
2000-02-16 01:36:30 +00:00
db4cd55837
27144: make sure the editor bogus node starts with _moz, and strip it out in html output. r=smfr
2000-02-12 01:58:40 +00:00
afecaab477
Table editing work (bug 20973). Fixed background colorpicker (bug 21410), disable unimplemented menu items (25137), make property bundle strings more localizable (26050). r=mjudge
2000-02-10 05:14:52 +00:00
cd6f5d237b
Prevent synchronous paints during reflows bug 20150; r=rods@netscape.com
...
Call SetTextAlign within SetupDC instead of in each DrawString on WIN32. bug 26973; r=rods@netscape.com
2000-02-09 15:48:01 +00:00
c9505c0fa5
implementing font increase/decrease size for html editor (bug 18774) r=floppy moose
2000-02-08 12:53:34 +00:00
5816b366ff
fixing warning; r=akkana
2000-02-03 23:29:09 +00:00
ac019d7deb
fix for 26299 - editor now uses reflow batching. Long live refow batching!
r=kin
2000-02-03 23:17:08 +00:00
894a83b297
More table editing work (bug 20973) and Page Properies dialog work (bug 14344). Added missing 'tbody' to nsIAtoms list. r=mjudge
2000-02-03 02:06:10 +00:00
f91098d0f6
make selection sticky across undo/redo (24573);
get bold/italic/underline toolbar feedback working (24574);
fix for 24856: unable to unbold text;
fix for 24572: cant get selection between split lists
2000-01-31 10:30:12 +00:00
ee76e82f41
Forgot to remove bogus NS_NOTREACHED line in IsMozEditorBogusNode().
2000-01-18 23:52:23 +00:00
9ef6758595
Fix for bug #24253 : [REGRESSION] Redo adds newlines instead of redoing.
...
mozilla/editor/base/nsEditor.cpp
mozilla/editor/base/nsEditor.h
- Added IsMozEditorBogusNode() method.
mozilla/editor/base/nsTextEditRules.cpp
- Modified CreateBogusNodeIfNeeded() to check if bodyChild is a
MozEditorBogusNode so that it doesn't create more than one.
- Modified DidUndo() and DidRedo() to use IsMozEditorBogusNode().
r=sfraser@netscape.com
2000-01-18 23:45:35 +00:00
a37b31dc09
WIP for 18395, various editor command handling and updating changes. r=akkana
2000-01-18 21:50:15 +00:00
634a777322
* fixed 19596;
* fixed 23597;
* fixed deletion bug that could cause to breaks to be deleted instead of one, when backspacing once. (no #)
* partial fix for current paragraph style not being properly reported in the composer toolbar. (no #)
2000-01-15 14:29:29 +00:00
698852a4f4
Converting usage of ::GetIID() to NS_GET_IID().
...
Bug #20232 , r=scc@netscape.com
2000-01-11 20:49:15 +00:00
e72a2924a8
added in some rules code for mail quoting. This
fixes bug: 19979 (extra blank line showing up in
mail that has quotes)
partial progress on block transformation work:
unlisting a list now works mostly correctly again,
instead of merging all the former list items into
one run of text (no bug number).
Moz-br's are now added in one more circumstance:
when you have a br at the end of some inline
content that is followed by a new block (like a
list, table, etc.). This is needed for the same
reason that the other moz-br's are: to generate a
blank line that the user expects after hitting
return. (no bug number)
DTD-related work to enable the editor to check if
you should be able to type given the current
selection.
fixed bug 22944: inserting an <A> in a table
splits the table.
Made some progress on text paste performance, but
it's still too slow. That's 19273, which I'm
leaving open
fixed bug 15258: selection capable of getting out
of the body element.
fixed a bug where code that merged adjacent text
nodes would merge the non-editable "formatting"
textnodes, (no bug number). Added code to prevent
selection from ending up inside a non-editable
text node.
fix for 11994, an IME bug.
2000-01-10 10:13:58 +00:00
8c236a7d13
23169: Fix uninitialized variables, including one which was disallowing splitting lines by hitting return. r=jfrancis
2000-01-06 22:35:04 +00:00
6229129616
continuing the war on the Case Of The Happy Caret
2000-01-05 12:24:10 +00:00
af019e592d
Fixing unix bustage.
2000-01-04 04:28:39 +00:00
c207257f01
adding construct-time value for an editor member bool.
2000-01-04 04:24:04 +00:00
d6e95890c8
Fix for bug 21346.
This is actually a major reworking of how the low level editor txns perturb selection. There is a mode now for telling the txns not to disturb the selection. There is also a fix for unlisting lists (sometimes list items got merged unintentionally when unlisting).
2000-01-04 03:09:41 +00:00
982fa55c82
partial fix for bug 15533 (size part). 1. change the return value from nsPiont to nsRect. Change widget code to reflect the change. In Gtk, change XIM FontSet based on the rect height. r=cata a=chofmann
1999-12-22 07:56:40 +00:00
d8c1142ecd
don't prompt to save changes to an empty/new window (bug #13933 ) fix by sfraser r=brade
1999-12-21 15:27:54 +00:00
2f7ffefaf4
21534 (part of 18033 and 18046): handle delete word and to-end functionality
...
outside of any selection batching (didn't work when inside a batch).
r=jfrancis; part of Mike's 18046 fixes which are a=chofmann.
1999-12-14 23:07:12 +00:00
121c8cdc07
bug 21378
...
r=rods
a=chofmann
changed CanUndo and CanRedo to return the right value. They were returning the opposite of what they ought to have returned.
1999-12-10 21:43:52 +00:00
4d99b4999b
fix bug 19358. r=jfrancis . Forece commit when we Undo, SelectAll or Paste
1999-12-09 22:35:17 +00:00
c5a3d00653
fix bug 12090 19358. Implement ForceCompositionEnd and add it in the beginning of AddInlineProperty/RemoveInlineProperty/InsertElement/InsertHTML
1999-12-08 03:39:36 +00:00
167f9c0b74
fix for 20457: deletion in editor pretty darn screwy. Lots of changes to improve this. Document modifying entry points in editor now go thru a standard sandwich, which allows tracking of what changed in the doc, which allows proper post-processing of what changed. Also, all deletions now go thru the rules code, if applicable. Also some bugs in tracking the changed document portion have been fixed. Finally selection setting after a delete is improved.
1999-12-07 08:30:19 +00:00
5d9824b4bd
add query composition event which get current curosor position. add timer base IME x y location query for gtk. r=erik. fix bug 17916 20550
1999-12-07 01:29:00 +00:00
520e982ed0
18033: Editor changes to use the new nsISelectionController interface.
...
Triggered from key events. Untested since the nsISelectionController
implementation isn't in yet (bug 18046), but key events do call
the stub routines. r=mjudge
1999-12-02 21:47:30 +00:00
2db26922a6
Landing no_neckoutil2_branch. Bug #11159 . Removes neckoutil_s.lib from build which helps beos and openvms.
1999-11-30 04:50:42 +00:00
3e67aed56d
removing obsolete d&d code and changing from CID's to progID's in d&d code. r=akkana.
1999-11-30 00:10:55 +00:00
757b1fce03
18033: Add editor API for delete methods, and hook up an initial
...
set of emacs key bindings for Unix. r=jfrancis
1999-11-25 04:11:51 +00:00
73aafabe8e
implemented a system to track what portion of a document is affect by an editor action. Used that system to help solve extensive whitespace handling problems, ans also problems with caret placement in response to returns (this lattter fix for html editors only - plaintext coming later). Fixed numerous list bugs involving outdenting, unlisting, and splitting lists.
Checkin addressees these bugzilla bugs:
2073 & 12337 - whitespace trouble when typing (you can end up with all nbsp's instead of spaces)
16715 - caret gone or wrong after hitting return
16988 - aim foiled by our mozDIVs
17908 - enter at end of document does nothing
16085 - 4.x mail replied foiled by mozDIVs
19368 - inline style lost after typing return
17059 - "normal" made a paragraph, but typing made a div. Now they both just use direct text in the body (or wherever)
18717 - exiting list gives UBER caret (note: this will only be fixed most of the time, not all)
17778 - cant type beside an image (it ends up above or below it) - this was a rather strange ramification of the old mozDIV
rules which are now gone.
1999-11-25 00:16:56 +00:00
e727552d0d
during CloneAttributes, delete all the nodes attached (not half of them); discovered when fixing bug #14750 ; r=kin@netscape.com
1999-11-18 20:34:15 +00:00
e7d9c4d3be
Use Recycle to free nsStrings; and fix a warning
1999-11-18 19:40:30 +00:00
3513eb0058
some fixes for deletion and also selection movement, contributed by Steve Clark. fixes bug 18537 (backspace can delete entire line); r = buster
1999-11-17 11:30:39 +00:00
54f5ef35c3
rewrote GetFirstEditableNode() / GetLastEditableNode(). This fixes bugs: 18922, 18938, 18723; r=floppy moose
1999-11-17 11:03:25 +00:00
65a3476676
pork jockey paint fixes. bug=18140, r=kmcclusk,pavlov
1999-11-14 02:51:25 +00:00
86f919a325
partial fix for bug 14599. We no longer crash. The frameset loads in the editor window,
...
but no editor is actually attached, so no editing is possible. Next step is
to detect the error case and stop the document load altogether.
1999-11-11 19:22:30 +00:00
142ac52eaf
updated xPL license boilerplate to v1.1, a=chofmann@netscape.com,r=endico@mozilla.org
1999-11-06 03:43:54 +00:00
0b73e32c85
bug 17744; a=choffman; r=floppy moose
1999-11-05 00:46:06 +00:00
bee74e223b
Removed unused NECKO ifdefs.
...
a=leaf
1999-11-02 23:34:03 +00:00
e04693d65a
Changed NS_NOTREACHED to be NS_WARN_IF_FALSE() so as to not crash everyone. r=sfraser.
1999-11-02 05:12:05 +00:00
f5c0eec556
fixes for bugs: 16361,12253,15696,15734; r=sfraser
1999-11-01 15:15:35 +00:00
ea13be0a26
Move all nsIEnumerator usage over to NS_ENUMERATOR_FALSE from NS_COMFALSE in anticipation of nixing NS_COMFALSE in the near future.
...
r=scc
1999-10-28 03:16:48 +00:00
341c8b0054
Ooops.. tree closed, better back these out for now. Sorry.
1999-10-27 21:01:37 +00:00
55276cc3c4
Move all nsIEnumerator usage over to NS_ENUMERATOR_FALSE from NS_COMFALSE
...
in anticipation of nixing NS_COMFALSE in the near future.
r=scc (please contact him should there be any build issues)
1999-10-27 20:24:21 +00:00
c89d94b9e9
reworking editor IME supoprt; r=kin; bugs: 13576, 11878, 11994, 13494, 16432
1999-10-26 18:54:47 +00:00
f53c9c41ba
Removal of calls to PR_MumbleMonitor, which were way too heavy-handed for the job. Replaced with PR_AtomicInc/Decrement. part of module sweep, r=morse, pavlov
1999-10-21 05:36:21 +00:00
6df0b49bc8
1. add asserting code to check null ptr
2. add if code and return NS_ERROR_NULL_POINTER if the ptr is null
3. add code to check return value
r=myself
1999-10-18 14:48:41 +00:00
1a165ddf9b
fixed my part of bug 15814 (Cleanup build warnings)
...
so trivial, no reviewer needed
fixed my part of bug 5403 (Services improperly released: Use NS_WITH_SERVICE)
a handful of subtle error handling bugs were fixed as a side effect
r=Akkana
1999-10-08 14:39:20 +00:00
7ac62b03ca
Whoops, backed out last check - wasn't supposed to land it
1999-10-07 20:46:50 +00:00
94df0dc557
r=kin; Added in ctor/dtor counts
1999-10-07 20:45:56 +00:00
7a638a9c93
fixed some space leaks reported by kipp. no bug #, r=tague
...
added some assertions and error checking to nsEditor::Do, no bug #, r=kin
fixed bug 14898 (implemented type-in state for any context), r=jfrancis
1999-10-06 20:27:41 +00:00
c412022f4a
revised rules system api to include "handled" parameter and ceased to overload the meaning of the "cancel" parameter; added TypedText() method to editor, editorshell, and logging, so that logging will work properly with typing; coallesce deletions for undo purposes r=buster@netscape.com
1999-10-06 19:34:09 +00:00
fa1e859619
14731: only insert formatting whitespace for block nodes
1999-09-29 20:19:20 +00:00
9a79219861
revised UNDO; introduced first cut at the "mozdiv" typing rules
1999-09-29 20:08:15 +00:00
9c7330f086
fixed bug 13887, caret in odd place at editor launch
...
a=chofmann, r=sfraser
1999-09-28 00:49:56 +00:00
ac6d0d1a0f
fixed IsEditable again, based on new info.
...
Now, only \n are held in the content model, making the original
implementation correct.
a=chofmann, r=akkana
1999-09-23 19:08:42 +00:00
4092a3c363
14602: IsEditable is broken.
...
removed optimization where we searched text strings and made our own guess about
whether it was editable or not. Now we just trust layout, if there's a frame, it's editable.
1999-09-23 00:10:51 +00:00
45452ccc0e
Fixed GetFirst/LastEditable node
1999-09-22 01:23:58 +00:00
1ee85a7538
fixed a problem with asserts trying to merge empty aggregate transactions.
...
if the aggregate transaction is empty, don't execute it. It's not technically
illegal, but it's a waste, and it causes the assert.
1999-09-21 20:46:36 +00:00
bd60cff53e
turned off a noisy debug flag
1999-09-20 04:15:36 +00:00
54d647b458
fixing a heap-o-undo problems and some mBogusNode problems
1999-09-20 01:31:44 +00:00
e8c7125690
fixed some warnings
1999-09-17 20:22:13 +00:00
2f7b8c679a
Don't show the caret initially; it will be made visible when the editor, or text widget, gets a focus event.
1999-09-16 01:16:31 +00:00
934fd4c573
Turn on whitespace insertion
1999-09-15 17:55:41 +00:00
f2c02c2f27
Changes to nsAutoStrings, and do the funky new caret thing.
1999-09-14 23:44:05 +00:00
5638b8ea91
bug fix (no #) for GetPriorNode/GetNextNode
1999-09-10 23:31:43 +00:00
332f71e329
490: infrastructure for inserting formatting whitespace. Not turned on yet except for DEBUG_akkana
1999-09-10 18:54:13 +00:00
8915071857
fix for bug 13482
1999-09-09 22:22:14 +00:00
028f11d2bf
Changes nsIAtom iterface to return a shared (non-allocated) wstring when
...
GetUnicode() is called. (thanks waterson, jband)
Also fixing 12237. (thanks jband).
1999-09-03 22:21:29 +00:00
662edc2554
Added CloneAttributes to IDL and nsIHTMLEditor. Reworked property dialogs to accomodate AdvancedEdit dialog. Preliminary version of AdvancedEdit dialog done
1999-09-02 01:47:18 +00:00
ba11acdca2
Changed IsNodeBlock to NodeIsBlock for JS. Fixed all compiler warnings. Added Advanced property Edit files
1999-09-01 19:58:25 +00:00
dff2ba2d8d
Exposed IsNodeBlock for JavaScript. Added comments for editor methods. Temporary fix for insert image bug (12917). Fixed bug 11857. Preliminary support for setting title and adding Cancel button in message dialogs.
1999-09-01 01:22:37 +00:00
743156ab31
checkpointing some deletion work
1999-08-31 13:55:18 +00:00
97b0bd802c
Added support for a reply from the StartComposition message. Necessary for XIM support on UNIX.
1999-08-31 01:20:32 +00:00
784ca3f405
removed static constructors, since they're illegal in our system
1999-08-30 22:12:11 +00:00
9c2fab8c18
Removed string bundle code from nsEditor into EditorShell and added access for JavaScript. Moved most of Save document code into EditorShell and added filetype filters to save dialog. Placed Advanced Edit functionality in an overly file. Removed redundant entity strings, that are now in overlays, from DTD files.
1999-08-28 02:40:18 +00:00
ce2856a9e0
Fixed bug 12126. Removed pref code from nsHTMLEditor - do HLine pref stuff in JS instead.
1999-08-27 04:12:47 +00:00
9ea8122814
making nsPresShell and nsDocument support weak references; using weak references to docs and pres shells within the editor
1999-08-25 10:51:55 +00:00
c2b1312912
fix for bug #12337 : not counting non-editable nodes when searching for whitespace.
1999-08-24 08:55:28 +00:00
32a9a77110
xpild-ing nsIAtom. Now nsIAtom is xpcom compliant.
1999-08-21 07:07:00 +00:00
893a484b35
Fixed bug #12052 - design changes to the implemenation of the editor charset menu. The charset information is now pushed down to the nsIDocument rather than being stored in the nsEditor component.
1999-08-20 23:52:36 +00:00
3bc5912284
Fixed a ton of errors where we were not handling error results correctly.
...
Added some comments of the form "// XXX: ERROR_HANDLING <explanation>"
wherever I saw a potential error but wasn't 100% sure of the intention of the code.
Fixed a few bugs along the way.
1999-08-19 13:30:48 +00:00
f83e42cc70
Modifications to re-enable Editor API Logging which was broken after the last editor source reorg.
...
editor/base/Makefile.in
editor/base/makefile.win
- Modified makefiles build files that were
renamed, and use new define to build the
API Logging code.
editor/base/nsEditor.cpp
editor/base/nsEditor.h
editor/base/nsHTMLEditor.cpp
- Removed all ENABLE_JS_EDITOR_LOG ifdef'd code.
- Removed all references to nsVector.h.
editor/base/nsEditorFactory.cpp
- Added ENABLE_EDITOR_API_LOG ifdef'd code
that will create an instance of nsHTMLEditorLog
instead of nsHTMLEditor.
editor/base/nsEditorTxnLog.cpp
- Initial checkin of file. File was originally named nsJSTxnLog.cpp.
editor/base/nsEditorTxnLog.h
- Initial checkin of file. File was originally named nsJSTxnLog.h.
editor/base/nsHTMLEditorLog.cpp
- Initial checkin of file. File was originally named nsJSEditorLog.cpp.
- nsHTMLEditorLog.cpp now derives from nsHTMLEditor, and only
overrides methods that modify the content tree and are publicly
available via XPIDL.
editor/base/nsHTMLEditorLog.h
- Initial checkin of file. File was originally named nsJSEditorLog.h.
- nsHTMLEditorLog.cpp now derives from nsHTMLEditor, and only
overrides methods that modify the content tree and are publicly
available via XPIDL.
1999-08-19 13:19:10 +00:00
a099b1e5b6
some reorg of block transformation code; implemented make-{header,preformatted,address,normal}; tweaked make list to honor <br> in some circumstances; rewrote "return in list item" to pop you out of list if item is empty; rewrote "return in header" to work with non-trivial headers.
1999-08-18 08:13:06 +00:00
11dad9b8c4
Fix bug #11687 - [Dogfood] Enable ender to save documents in encodings other than ISO-8859-1. Approved by chofmann@netscape.com, reviewed by buster@netscape.com.
1999-08-13 22:26:50 +00:00
f673bdb804
11552: don't hardcode the character set for saving
1999-08-10 21:22:32 +00:00
cmanske%netscape.com
jfrancis%netscape.com
scc%netscape.com
akkana%netscape.com
dbaron%fas.harvard.edu
ftang%netscape.com
rickg%netscape.com
tajima%eng.sun.com
sfraser%netscape.com
kmcclusk%netscape.com
kin%netscape.com
pp%ludusdesign.com
mcafee%netscape.com
brade%netscape.com
buster%netscape.com
warren%netscape.com
pinkerton%netscape.com
beard%netscape.com
dmose%mozilla.org
cls%seawood.org
tbogard%aol.net
braddr%puremagic.com
kipp%netscape.com
dougt%netscape.com
tague%netscape.com