d6576c5892
Remove commented out code to treat integer specially: it is not applicable any longer in any case.
2004-04-18 14:49:50 +00:00
d62ad77af5
Work on bug 238649: no more support for ClassNameHelper and friends
2004-04-18 12:15:07 +00:00
b71427a6ae
Worj on bug 238649: removal of NotAFunctionException
2004-04-18 09:30:30 +00:00
642f7ede36
deCOMtaminate nsIScriptObjectPrincipal (bug 240745). This also fixes some code in nsCrypto.cpp that sems to have been mis-braced (I don't think it was working as intended). r+sr=jst.
2004-04-18 00:28:47 +00:00
534c7d51d6
1. Change cmp_* functions to return boolean, not int, to simplify code.
...
2. Move optimizer-only functions from ScriptRuntime.java to optimizer/OptRuntime.java
3. Add ScriptRuntime.wrapBoolean to wrap boolean value and use it in the optimizer
2004-04-16 07:38:20 +00:00
483eb6656a
Fixing build and nspr links
2004-04-15 21:36:33 +00:00
65d2274604
More cloned function object fixing: don't convert a jsval to a JSFunction, then back up via fun->object -- that leads to the clone-parent, when the value may be the clone we want (240577, r=shaver).
2004-04-15 21:01:24 +00:00
f0af12bf85
Bug 240500 JS_DefineFunctions APIDoc for return is wrong
...
r=brendan
2004-04-15 16:20:34 +00:00
ab1b721b28
Fix old watchpoint function vs. clone bug (240577) and undo bogus strict warning from lazy class init (240404 in part).
2004-04-15 09:05:46 +00:00
369750021e
Hackaround for bug 240404.
2004-04-15 08:11:55 +00:00
81470d5283
1. Throw IllegalArgumentException instead of EvaluatorException when argument does not belong to JS runtime types.
...
2. Optimize eq and shallowEq in ScriptRuntime to share code with optimized versions in Interpreter.
2004-04-14 14:50:24 +00:00
cb3ccb29b3
Layout cosmetics
2004-04-14 14:46:58 +00:00
153f7be2a2
Support for Date.now()
2004-04-14 11:04:55 +00:00
f3e73b9da0
Er, let's try caillon's patch (bug 240458, r=me).
2004-04-14 02:36:37 +00:00
e4d5924763
Fix cosmetic bug pointed out by caillon, passing JS_FALSE rather than 0 to js_DecompileValueGenerator (API change wasn't tracked long ago).
2004-04-14 02:35:34 +00:00
71f5f4282a
fixing win32 bustage
2004-04-13 19:54:44 +00:00
ff71873e75
- Improve global variable performance from 3x slower to 1.2x slower than
...
locals (169559, r=shaver).
- Also fix longstanding bug where global regexps in precompiled scripts were
wrongly shared among threads/contexts (165201, r=shaver).
- Also fix strict-aliasing gcc warning causes (206599, r=bryner).
2004-04-13 01:25:17 +00:00
7e870f0884
Fix from Sterling Bates <whoelse.sterlingbates.com> for JS_ValueToInt32.
2004-04-09 23:58:26 +00:00
139d599b1a
Trivial followup fix to 127418 based on m.jseng feedback, r/a=me.
2004-04-09 01:05:56 +00:00
0156749808
Oops...
2004-04-07 00:17:44 +00:00
91961a696c
Avoid invading JS namespace with global (239122 followup).
2004-04-07 00:02:50 +00:00
2c48e8fce8
fixes bug 239661 "xpconnect.xpt should be included in dist/gre" r=cls a=chofmann
2004-04-06 04:25:48 +00:00
8a147d1bbf
Bug 239122 Liveconnect can be used to read any file on user's filesystem
...
enabling UniversalBrowserRead only during js calling applet
r=jst, sr=brendan, a=chofmann
2004-04-06 03:15:55 +00:00
786965d4a8
Fixing line endings to appease openwatcom's nmake
...
this is spidermonkey standalone
2004-04-04 19:46:38 +00:00
c29de605ca
Tolerate asymmetric/request-less lock nesting, as happens with Mozilla DOM code (229200, r=shaver, a=chofmann).
2004-04-03 22:21:03 +00:00
18dac71e1f
My edits to timeless's patch for bug 238303, to fix warnings (r/a=me).
2004-04-03 22:11:11 +00:00
df4aca062c
Bug 237183, Add FP exception handler to OS/2, r=brendan, a=mkaply
2004-03-31 16:38:54 +00:00
c685edc692
Fixing bug 58118 : long overdue commit of patch from Mike McCabe, mike+mozilla@meer.net
2004-03-30 12:48:29 +00:00
701ea21521
Since new x in Java never returns null, the check for null in date_format was redundant.
2004-03-30 10:35:42 +00:00
8dcdcb1f89
Parallel fix to SpiderMonkey's bug 238945, to automatically insert ; after do-while on any error token.
2004-03-30 03:25:17 +00:00
73ca7a66e9
Do automatic semicolon insertion after do-while loops for any error token, contrary to ECMA-262, to match almost a decade's worth of practice (238945, r=shaver, a=chofmann).
2004-03-30 03:20:03 +00:00
eef0796b8a
Faster implementation of MonthFromTime and DateFromTime:
...
1. Use day / 30 as month estimate with the following adjustment via switch()
2. Reuse year from day calculations in IsLeapYear
2004-03-29 15:19:04 +00:00
021b376688
Fixing bug 239068: proper initialization of parent scope for functions of constructors.
2004-03-29 15:15:34 +00:00
3a93fa2e8e
DaysInYear is replaced by IsLeapYear since the former was used only to determine if a particular was leap or not
2004-03-29 14:16:23 +00:00
ba8f69355a
Cosmetics: layout fixes
2004-03-29 12:30:24 +00:00
dfdd5ab46c
Starting 1.5R5.1 development
2004-03-29 12:29:11 +00:00
256c91d0ae
Fix js_LookupCompileTimeConstant to respect shadowing properties (238881, r=shaver, a=chofmann).
2004-03-29 01:11:24 +00:00
40db418d07
Fixing 238823 : throw explicit IllegalArgumentException when JS source for Context.compileFunction does not contain single JS function statement instead of producing silent empty functions or throwing obscure NullPointerExceptions
2004-03-27 09:35:22 +00:00
e229fd6ab4
Better formating
2004-03-26 13:01:17 +00:00
78ec796300
Fixing bug 238699 : refactoring to expose simpler code generation API caused to select wrong code path when compiling functions
2004-03-26 12:42:00 +00:00
f2569bca03
Bug 238393 DRefTool analysis for jsd files
...
r=rginda a=asa
2004-03-26 07:27:05 +00:00
0292a753a1
Explicit date in Context.getImplementationVersion() for 1.5R5 release
2004-03-25 20:37:32 +00:00
1aafe09612
Reflecting 1.5R5 release
2004-03-25 19:45:56 +00:00
cbce2b4745
Starting 1.5R6
2004-03-25 17:58:03 +00:00
420074b3a1
Removal of macbuild support: its Mac OS X time after all
2004-03-25 17:39:21 +00:00
afe5a6cd9d
Info about commercial support
2004-03-25 15:46:40 +00:00
abf0a3a1ac
*** empty log message ***
2004-03-25 11:04:04 +00:00
95c43eacc9
Bug 238393 DRefTool analysis for jsd files
...
r=rginda
GC_MARK_DEBUG is not part of the build...
2004-03-24 23:25:30 +00:00
37c396db64
Preparations for 1.5R5
2004-03-24 15:52:55 +00:00
533e9f8489
Updates to reflect new extension to allow to pass function to Java method expecting interface: now interface with multiple methods are allowed as long as all methods has the same signature
2004-03-24 15:44:19 +00:00
ae3df9d02a
Finalizing 223435 : function can be converted to Java interface with more then one method as long as all methods has the same signature.
2004-03-24 14:15:37 +00:00
fb10aede78
Forgot to tag JS_Lock and JS_Unlock as DEPRECATED.
2004-03-24 01:36:57 +00:00
8440730a2a
Fix typo.
2004-03-24 01:29:45 +00:00
4644d2e6ae
Fix up request model docs a bit, spurred by conversation in m.jseng with Bob Kline <bkline@rksystems.com>.
2004-03-23 21:12:28 +00:00
76316f18dd
More work on bug 223435 : pass method name for the interface as the last parameter to JS function so it can use for debug purposes
2004-03-23 16:24:32 +00:00
6eb2a3c967
Bug 238305 jsd doesn't build on windows if JS_MARK_DEBUG is set
...
r=rginda
not part of the build...
2004-03-23 05:33:09 +00:00
5c2ad29c96
Bug 238058 Crash [@js_GetStringBytes] from venkman
...
r=rginda a=brendan
2004-03-23 05:13:09 +00:00
472d45bc48
Fix broken-since-rev-3.6.4.11 forelem normal-termination stack cleanup code-gen (174709, r=shaver, a=chofmann).
2004-03-23 02:09:38 +00:00
f4ff06f911
Making BaseFunction.decompile package private: any new public function will always find its users even if the usage is broken. It was public to allow calls from debugger but simple call to Context.toString() would do the same job.
2004-03-18 13:37:29 +00:00
0cbfdabe29
RUnit Software now includes a link on their page about JS (Declaimer: I work there!)
2004-03-18 13:32:52 +00:00
f040fa2436
Added RUnit Software
2004-03-17 18:36:57 +00:00
46abef99b9
Fixing bug 237771 : allow to transfer toSource implementation to different objects
2004-03-17 18:36:39 +00:00
364bae9326
Fix function after var redeclaration to avoid overincrementing fun->nvars (237461, r=shaver, a=chofmann).
2004-03-15 03:41:49 +00:00
0c01fd4557
fixing bug 146458 - Liveconnect calls fail if applet's codebase is in different domain.
...
Use the domain of the page, like we do for script.
r=jst, sr=brendan, a=dbaron
2004-03-13 20:52:39 +00:00
422e83ce08
Bug 106386 Correct misspellings in source code
...
patch by ajvincent@juno.com r=timeless sr=alecf
2004-03-10 05:34:40 +00:00
031b1e42eb
Fix bogus error report and redundant test, enforce style fascism, eliminate warnings (227705, 230397, r=igor).
2004-03-10 03:34:59 +00:00
6b70acca26
Documenting new Context seal API and fixing obvious English mistakes.
2004-03-09 23:34:30 +00:00
4996f394d9
Better version of last fix, thanks to dbradley.
2004-03-09 04:25:12 +00:00
3fa586e97a
Detect size_t overflow (r=shaver, sr=jst, 236618).
2004-03-08 20:51:40 +00:00
ecfd54c02f
Updated file with license info from Eugene Aresteanu :
...
> Hi,
>
> Does it look right now?
>
> Regards,
> Eugene
>
> -----Original Message-----
> From: Igor Bukanov [mailto:igor@fastmail.fm]
> Sent: Friday, March 05, 2004 10:07 AM
> To: eugene aresteanu
> Subject: Re: Rhino and license for Messages_fr.properties
>
>
> eugene aresteanu wrote:
>
>>Hello,
>>
>>Here it is. I hope it is right.
>>Why do you say the default Messages.properties lacks notices?
>>I used the header of Messages.properties as a template.
>
>
> Sorry for not been clear, but what I wanted to say is that did not have
> triple MPL/GPL/LGPL but rather the old NPL/GPL pair. Could you update
> the file one more time using
> http://www.mozilla.org/MPL/boilerplate-1.1/mpl-tri-license-sh as template?
>
> Regards, Igor
2004-03-05 19:17:43 +00:00
5586a28481
Resolving bug 236117 : new API to seal Context
2004-03-03 19:59:25 +00:00
58db1d9fd5
Resolving bug 236193: require enetered Context for compilation
2004-03-03 11:20:33 +00:00
2e9230577f
Fix HasFinalReturn to cope with fall-thru in switch cases (235930, r=shaver).
2004-03-03 05:25:28 +00:00
61a1bbbb3f
Save the next end of line char pointer into userbuf in case it's far away, and avoid searching for it repeatedly, when dealing with inputs with very long lines (218511, r=shaver).
2004-03-03 01:50:46 +00:00
e0a2c2536d
Making javaToJS static to match the rest of API
2004-03-01 19:19:47 +00:00
533fdfabe2
Fiddle comment.
2004-02-25 22:34:53 +00:00
81b115d949
Bug 123584 JavaScript engine should use malloc/realloc/free consistently
...
Removing the unused JS_MALLOC macro per brendan
2004-02-25 14:05:29 +00:00
6368e4dcbc
Bug 123584 JavaScript engine should use malloc/realloc/free consistently
...
Removing the unused JS_NEW and JS_DELETE macros per brendan
2004-02-25 14:01:24 +00:00
33607fc717
Bug 123584 JavaScript engine should use malloc/realloc/free consistently
...
Replace JS_DELETE with free/JS_smprintf_free
r=rogerl
2004-02-25 13:33:42 +00:00
786239d041
Treat bug "numbers" which aren't numbers as links instead of prepending a url base
...
similar to runtests.pl:js_print_bugnumber
Problem input:
Testcase ecma_2/RegExp/properties-001.js failed Bug Number http://scopus/bugsplat/show_bug.cgi?id=346000
2004-02-25 13:01:29 +00:00
b6b0241e94
Use label local in Statement; eliminate somewhat arbitrary empty lines.
2004-02-25 09:06:36 +00:00
874aac0637
Fixing bogus assert on startup for DEBUG_xpc_hacker people. Not part of the default build.
2004-02-24 22:50:46 +00:00
0bc43fbec1
Duh.
2004-02-24 21:23:45 +00:00
40f5e70cee
Fixing JavaDoc
2004-02-24 07:20:49 +00:00
a3d001e0e8
Making NativeScript package private: if this will be controversial, then the public status can be restored
2004-02-24 07:19:56 +00:00
6cb22ac75a
Bug 200016 Crash accessing Java package from JS
...
r=xiaobin.lu, sr=brendan
Block accessing to sun.plugin package
2004-02-24 03:18:09 +00:00
df0ecadb4b
s/compile/parse/ -- compile is overgeneral, especially in light of what's next.
2004-02-24 03:04:40 +00:00
c4044d863e
Simplify consts generation slightly.
2004-02-24 03:03:33 +00:00
09acb4babf
Add ecmaStrictMode to CompilerContext.
2004-02-22 07:21:55 +00:00
e18fed3f6a
Move script_filename_table into JSRuntime where it belongs (235145, r=shaver).
2004-02-22 03:21:15 +00:00
f2dc48d241
Backing out brendan's checkin due to tinderbox orange.
2004-02-22 01:11:47 +00:00
7c602b5df7
Move script_filename_table into JSRuntime where it belongs (235145, r=shaver).
2004-02-21 19:41:52 +00:00
4e1a592115
Add support for cross-compiling to mingw.
...
Bug #222013 r=bryner
2004-02-20 22:14:14 +00:00
f2fd2d0e42
Bug 235035 change nsIRunnable.Run to nsIRunnable.run
...
r=dougt sr=darin
2004-02-20 21:34:57 +00:00
c0ad926a1b
Elaborate reference error message; fix iloop in __hasInstance__.
2004-02-20 07:35:28 +00:00
30bcec1891
Bug 234703 mClassInfoFlags is always 0 instead of using the XPCWrappedNativeProto(..., ClassInfoFlags, ...) value
...
r=jst sr=bz moa=dbradley
2004-02-19 15:20:39 +00:00
8d65e087ae
landing string defragmentation patch for bug 231995, r/sr=dbaron,jst,dougt
2004-02-19 02:44:03 +00:00
98a70b8580
Remove "pre" from a candidate build.
2004-02-18 17:28:40 +00:00
4b836891b2
Preparations for 1.5R5
2004-02-18 12:24:27 +00:00
962663d3d9
t.scanOperand should be true by default, eliminating scanForOperand bloat.
2004-02-17 08:43:48 +00:00
47c51cce71
Bug 233335 XP_PC still referenced in jssh.c
...
Use defined()
2004-02-16 18:27:06 +00:00
5632fed18a
s/this/v/g in getValue.
2004-02-16 16:55:40 +00:00
3ddaa18b05
- Add source and cursor properties to SyntaxError exceptions.
...
- Rework labeled statements to fix chicken-and-egg problem with BREAK to label
completion type targeting.
- Unify next-statement non-expression token cases and default: in Expression.
2004-02-16 02:38:19 +00:00
42c4aff0a0
- Fix global.String to convert its argument to string type when called as
...
a function.
- Rework labeled statements to fix chicken-and-egg problem with BREAK to label
completion type targeting.
- Avoid defining Function.prototype.__call__, __construct__, and
__hasInstance__ once they're set, to avoid storing host-uninterpretable
target function objects in those properties.
- Fix evaluate to throw a host exception if returning to the host interpreter.
2004-02-16 02:15:27 +00:00
02939f0679
Fully bootstrapped, but host still can't apply target functions.
2004-02-14 21:58:10 +00:00
76d7770850
Fix Expression to work with Statement's automatic semicolon insertion logic.
2004-02-14 21:56:41 +00:00
2bd6af2e37
bug 226380. backout code that breaks ActiveX plugin properties, a=chofmann
2004-02-14 01:01:08 +00:00
8f085f363e
Preparations for 15R5 release.
2004-02-13 18:50:51 +00:00
adeccbc67c
Fixing NativeGlobal.encode: it was broken for chars beyond 0xFFFF as it sb.setLength(k) was called after k was increased to consume the second char from UTF-16 encoding to build UCS-4.
2004-02-12 19:05:47 +00:00
1e3f7aaaed
Preparations for 1.5R5
2004-02-12 18:13:00 +00:00
70d3411bc0
Fix Expression to stop on : only if hookLevel is not elevated.
2004-02-11 08:30:20 +00:00
f3068c76bf
Checkpoint, still not quite metacircularly bootstrapped.
2004-02-11 07:57:19 +00:00
0eb3516470
Fix two nits in last checkin.
2004-02-11 07:51:50 +00:00
13512ddbd3
NARCISSUS ifdefs and related general fixes (r=shaver).
2004-02-11 07:21:59 +00:00
505c634885
Fixing bug 233307. deCOMtaminating nsIScript* and related interfaces. r+sr=bryner@brianryner.com.
2004-02-09 22:48:53 +00:00
ec7de43908
Fixing bug 233274: for/in loop goes through array elements in wrong order
...
Fix: populate ids array in NativeArray with dense indexes first
Since array literals in Rhino creates instances of NativeArray with the
internal dense array containing literal elements, the patch changes
NativeArray.getIds to return ids array with dense indexes coming first and
indexes for elements added later after that.
2004-02-06 20:16:36 +00:00
3ba7b938c3
Adding backward compatibility to SecurityController so it can be used with Rhino 1.5R4.1 subclasses
2004-02-05 15:10:52 +00:00
fa38efc7cf
Bug 110584 Missing call to jsj_ExitJava
...
use |break| instead of |return| in |switch|
r=xiaobin.lu, sr=brendan
2004-02-04 02:01:54 +00:00
bd08f327fb
- ECMA-prescribed {DontEnum} attributes for length on empty arg list, and on
...
<any-function>.prototype.constructor.
- Put rarely-set default properties in prototypes.
- Improve a couple of comments.
2004-02-03 23:58:03 +00:00
8f62320cc9
JS implemented in JS, initial checkin.
2004-02-03 03:28:54 +00:00
54930f7d31
Bug 137193 Debug Mozilla aborts when JSObject.call("func", args) and args is zero-length array
...
r=kyle sr=brendan
2004-02-02 19:10:33 +00:00
e25afaab16
Updating email address.
2004-01-31 01:04:51 +00:00
2b519a425f
More bug 231518 followup: non-identifier as well as reserved-id property names must be quoted/indexed, not dotted (r=shaver).
2004-01-30 20:34:23 +00:00
d3b31dac4f
Fixing bug 210605 again: for now re-throw Error instances as is without wrapping them into WrappedException so scripts would not be able to catch them.
2004-01-29 17:04:31 +00:00
39374a94f8
Updating JS_GetImplementationVersion() to date of latest JS release (67111).
2004-01-28 02:10:31 +00:00
100f1fcc33
Brace style fascism.
2004-01-24 00:36:10 +00:00
a65f571381
Fix quoting/escaping of non-ASCII chars and reserved ids in all property access cases (231518, r=shaver).
2004-01-23 17:52:03 +00:00
0511192cec
Print more information about nsXPCWrappedJS objects in GC_MARK_DEBUG. b=231384 r=brendan sr=bryner
2004-01-21 21:09:18 +00:00
a7573a8a91
Removal support for deprecated getTargetClassFileName/setTargetClassFileName: they throw exception instead of calling a special proxy to avoid having probably unused any more class. If this is not true, then the methods should be restored.
2004-01-18 21:26:34 +00:00
7d76224ac8
Fixing JavaDoc comments
2004-01-18 21:23:53 +00:00
b224c3704c
EvaluatorException and WrappedException are public API now
2004-01-18 21:21:41 +00:00
d754a6a75f
Fix bug reported by Adrian Klein <master@dragosan.net> where o['if'] is decompiled as o.if.
2004-01-18 18:31:34 +00:00
176a213396
Deprecating ClassNameHelper and ClassRepository in favor of new optimizer/ClassCompiler.
2004-01-17 21:52:30 +00:00
b629e258d7
optimizer.ClassCompiler provides new simple API for generating of class files from scripts that does not require to create Context instances.
...
The jsc tool is updated to use the new interface instead of using ClassNamehelper and friends.
2004-01-17 21:02:32 +00:00
134428fef2
1. optimizer/Codegen now just generates byte code classes, the instantiation of classes is done in a separated class optimizer/ClassCompiler. This is done to provide in future a simple interface to generate class files instead of complicated ClassNameHelper and friends implementation.
...
2. Parser now stores TokenStream instance in its field instead of having it present in each and every method signature. It allowed to simplify interaction between Parser and IRFactory where the later now uses Parser.reportError so parser van recover from syntax errors and provide better error reporting.
2004-01-16 18:20:22 +00:00
0fc143dd7c
Added setters for properties of CompilerEnvirons.java so it can be initialized
...
without having Context object.
2004-01-16 16:09:07 +00:00
34ebe5f4c1
Renaming Context.hrowAsUncheckedException to Context.throwAsScriptRuntimeEx to better reflect its purpose, providing better documentation and making sure it throws only instances of EcmaError and EvaluatorException.
2004-01-16 15:14:25 +00:00
497a0f766c
Fixing bug 228336 :
...
This is a Rhino version of Brandan's patch from attachment 138844, bug 228087
plus code to fix overflow problem reported in bug 230216.
2004-01-16 15:11:31 +00:00
a7050e5460
throwAsUncheckedException is moved from ScriptRuntime to Context as a useful API to use in external applications.
2004-01-15 20:41:57 +00:00
f26418ea3f
Fixing typo in comments
2004-01-15 20:40:56 +00:00
96ea5ea515
Patch from Alex Bitney to fix bug 230883
2004-01-15 20:10:54 +00:00
1d61995445
Unify license comment per js/src/plify_jsdhash.sed, plus comment simplification.
2004-01-15 02:00:55 +00:00
44dd443b8e
Anything that starts like a {min,max} quantifier but doesn't parse as one is taken as a flat string to match (228087, r=shaver).
2004-01-12 21:10:26 +00:00
1bba00a7fc
Bug 230522 warning C4047: 'return' : 'foo *' differs in levels of in direction from 'int'
...
rs=brendan
2004-01-11 17:26:30 +00:00
d217b68005
Adding support for WinXP (copied from Win2k)
2004-01-09 20:15:27 +00:00
d0f309943a
Continuing to land the PACKAGING_20030906_BRANCH for bug 20640. Not part of the build, yet.
2004-01-07 13:37:00 +00:00
274ef7cd49
Beginning to land the PACKAGING_20030906_BRANCH for bug 20640. Not part of the build, yet.
2004-01-07 01:22:31 +00:00
59ae0034a1
Fixing bug 229571 : code refactoring for speed optimization
2004-01-06 13:35:51 +00:00
332cc13ae5
Move details of parsing/code generation from Context to interpreter/optimizer to allow more pluggable compilation interface.
2004-01-05 13:22:40 +00:00
c98a6b4d3f
- Eliminate WellTerminated by coalescing its call sites to the end of Statement and inlining it there. This adds a tiny bit of overhead in some cases, due to
...
the ON_CURRENT_LINE check, which can be proven redundant for cases such as the
debugger statement. But the cost should be in the noise, and code size wins.
- Remove bogus lastExprType argument to WellTerminated and eliminate its only
use, in parsing an expression statement. Also eliminate the WellTerminated
check after a function "statement" (which could be a top-level declaration, or
an instance of our function statement extension, e.g. 'if (x) function f(){}',
neither of which should require semicolon termination).
The intent of the lastExprType parameter, the WellTerminated call from the
TOK_FUNCTION case, the call from the default expression-statement case, and the
#if JS_HAS_LEXICAL_CLOSURE code in WellTerminated appears to have been to allow
'function f(){} function g(){}' for JS versions < 1.2, and to forbid it as an
error otherwise, requiring a semicolon in between the function declarations.
But in fact ECMA and good sense should allow as many function declarations on
a line as you please, optionally followed by other statements, and without
requiring semicolons after function declarations.
Since this change removes an error case, I don't expect any incompatibility
bugs to be reported.
- Coalescing/inlining WellTerminated meant removing its call from MatchLabel,
called by the break and continue cases in Statement.
- The debugger keyword could be used without a semicolon terminator to make it
a statement, as in 'debugger 1 + 2;', parsed as a debugger statement followed
by an expression statement -- which seems quite wrong (ECMA reserves debugger
but does not specify its usage).
This bug arose due to the early return at the end of the TOK_DEBUGGER case.
Although that case called WellTerminated, because it returned rather than broke
from the main switch, it failed to match an explicit semicolon terminator (if
present), making 'debugger; 1 + 2;' parse as three statements, with the first
semicolon becoming an empty statement (contrary to ECMA automatic semicolon
insertion rules).
2004-01-05 07:47:49 +00:00
igor%mir2.org
bryner%brianryner.com
timeless%mozdev.org
brendan%mozilla.org
cbiesinger%web.de
darin%meer.net
kyle.yuan%sun.com
pedemont%us.ibm.com
caillon%redhat.com
jst%mozilla.jstenback.com
dbaron%dbaron.org
cls%seawood.org
nboyd%atg.com
leaf%mozilla.org
pschwartau%netscape.com
bsmedberg%covad.net