Giving all these nodes ids doesn't seem like the right fix. `buildArea` already ignores skipintoolbarset
items before doing anything else with nodes, so bailing out early seemed like the right solution here.
MozReview-Commit-ID: H3EyqoospNR
--HG--
extra : rebase_source : 6dc06d18c82e2af5024be0aba271c270f7403839
Can now crop screenshots properly, for basic cases.
Also changed behavior so that if different window types are given, the application exits.
MozReview-Commit-ID: CqmIJFufONw
--HG--
extra : rebase_source : 7cdc7c4ce62959930c55491b277923b372929bc6
Nested captions are not used, nor nested labels inside captions.
Another approach would be to just move all our captions that currently use
<caption><label> to use <caption label="">, and get rid of the <xbl:children>
element.
Let me know if that's preferred, but seems not necessary to me.
MozReview-Commit-ID: Gx7vB0tio5O
--HG--
extra : rebase_source : 752765f30aa5b0b26e57d2144bcdca2cce5d09cb
Also, once this lands, it should clean up some of the failing tests on Bugs #1403686 and #1412357.
MozReview-Commit-ID: 5rCjjlzuavq
--HG--
extra : rebase_source : 134192b98d306d8c9313ccdcfe5106b0db4dadb3
Can now crop screenshots properly, for basic cases.
Also changed behavior so that if different window types are given, the application exits.
MozReview-Commit-ID: CqmIJFufONw
--HG--
extra : rebase_source : 9b8ce0c3fc044403064676c02f810c9258e85ee4
Based on patches by Andrew Comminos [:acomminos] <andrew@comminos.com>
MozReview-Commit-ID: EJtahgBcBrf
--HG--
extra : rebase_source : 454b0a67139c680f37e5578a92d2bd383188aa6b
This line was added to the nightly macosx64 mozconfig in 9312a1903bf4
(bug 1391643). But we didn't catch it because compare-mozconfigs
only analyzes the current platform and we cross compile for MacOS
from Linux.
MozReview-Commit-ID: 35Q2c0mybPi
--HG--
extra : rebase_source : 25707037ca07ec22de283abcfe96c4faea71d55e
The mechanism by which PGO builds are kicked off is kinda wonky.
The MOZ_PGO environment variable is recognized by configure and setting
it will result in MOZ_PGO being defined in substs. In addition, the
build backend (previously client.mk, now Makefile.in) also recognizes
MOZ_PGO (from mozconfig or environment) and takes appropriate action.
In-tree mozconfigs set MOZ_PGO via mk_add_options. mk_add_options
is intended as a mechanism to inject state into client.mk and the
make-based build system.
In addition, there is code in mozharness (unchanged by this commit)
that sets MOZ_PGO if appropriate.
A PGO build configuration is different from a non-PGO build
configuration. Therefore a make-centric environment variable to
control PGO is not ideal. Instead, this should be defined as a
configure-time flag and the build invocation should key off that.
This commit normalizes in-tree mozconfigs to set MOZ_PGO via
ac_add_options and updates the PGO documentation to recommend
this method.
MozReview-Commit-ID: k6AZyJuXjs
--HG--
extra : rebase_source : b1a6348611eba08dd67ec938cca5586fbe8e6910
extra : source : 25c7ebc7c44dd253f421b6de3d0337635d0c99d0
This patch will remove printing xul dialog and related files since a caller of
this xul dialog doesn't exist.
The printjoboptions.xul is only used by printdialog.xul.
MozReview-Commit-ID: B6VZuj3Lg1b
--HG--
extra : rebase_source : 7cf2e94c491147a2cb84616ab922adeb833cb447