Patch co-authored by Emmanuele Bassi <ebassi@gmail.com>
This defines a CSSVariableDeclarations class that holds a set of
variable declarations. This is at the specified value stage, so values
can either be 'initial', 'inherit' or a token stream (which is what you
normally have). The variables are stored in a hash table. Although
it's a bit of a hack, we store 'initial' and 'inherit' using special
string values that can't be valid token streams (we use "!" and ";").
Declaration objects now can have two CSSVariableDeclarations objects
on them, to store normal and !important variable declarations. So that
we keep preserving the order of declarations on the object, we inflate
mOrder to store uint32_ts, where values from eCSSProperty_COUNT onwards
represent custom properties. mVariableOrder stores the names of the
variables corresponding to those entries in mOrder.
We also add a new nsCSSProperty value, eCSSPropertyExtra_variable, which
is used to represent any custom property name.
nsCSSProps::LookupProperty can return this value.
The changes to nsCSSParser are straightforward. Custom properties
are parsed and checked for syntactic validity (e.g. "var(a,)" being
invalid) and stored on the Declaration. We use nsCSSScanner's
recording ability to grab the unparsed CSS string corresponding to
the variable's value.
Note that this uses the method_ field of the CSS_PROP_ALIAS macro, which
is not consistent in style with the other values of nsCSSProperty.
However, these enum values are unlikely to be used explicitly, and it
avoids having to add an extra parameter to the macro. (It might even be
better to change the other values to work this way.)
Use the property list in the tables for nsRuleNode::CheckSpecifiedProperties.
To reduce heap usage, redesign the storage of properties and values in nsCSSDeclaration to allocate all property-value pairs in a declaration block in a single allocation, and use temporary structures (like the old permanent structures) during parsing and modification. Replace per-property switch statements in nsCSSDeclaration with table-based code to reduce code size.
b=125246 r+sr=bzbarsky
Cameron McCormack
L. David Baron
Gervase Markham
Boris Zbarsky
Nathan Froyd
Michael Ventnor
Zack Weinberg
Jonathan Kew
Jonathon Jongsma ext:(%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
dbaron%dbaron.org
cbiesinger%web.de
bzbarsky%mit.edu
gerv%gerv.net