Граф коммитов

457 Коммитов

Автор SHA1 Сообщение Дата
Emilio Cobos Álvarez 5502bf7db9 Bug 1846745 - Miscellaneous clean-ups to nsCSSProps. r=boris
Fixes various clang-tidy warnings and makes initialization a bit more
straight-forward.

Depends on D185154

Differential Revision: https://phabricator.services.mozilla.com/D185155
2023-08-03 08:58:07 +00:00
Andrew Osmond 5a36e3dd85 Bug 1785366 - Blocklist backdrop filter on some Ivy/Sandybridge Intel Windows drivers. r=jrmuizel,emilio
Backdrop filter crashes newer Intel drivers on Windows. This patch adds
support to the blocklist infrastructure for backdrop filter, and hooks
this up with the CSS property table.

Differential Revision: https://phabricator.services.mozilla.com/D154950
2022-08-18 12:29:20 +00:00
Emilio Cobos Álvarez 53e6d30937 Bug 1777982 - Remove invalid leftover assert. DONTBUILD
MANUAL PUSH: Remove assert that doesn't hold if aliases are disabled
but I forgot to remove from the initial patch.
2022-07-18 19:41:23 +02:00
Emily McDonough 0a018773d2 Bug 1779496 - Make more of nsCSSProps constexpr r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D151768
2022-07-15 03:12:37 +00:00
Emilio Cobos Álvarez 4910266cb7 Bug 1777982 - Some minor cleanups in nsCSSProps.h. r=jwatt
Drive-by, but might as well remove this useless namespacing.

Depends on D151594

Differential Revision: https://phabricator.services.mozilla.com/D151595
2022-07-12 22:22:18 +00:00
Emilio Cobos Álvarez 7c3737dc89 Bug 1777982 - Propagate flags from original property to aliases. r=AlaskanEmily
Even we don't have internal aliases right now (and that seems a bit
silly) we do have pref-gated aliases. An alias ID passed to IsEnabled
with the wrong EnabledState would misbehave, assert, and crash.

Though we don't have such callers in the tree because InspectorUtils
passes only arguments that make us not look at the flags, it seems more
reliable this way.

Differential Revision: https://phabricator.services.mozilla.com/D151594
2022-07-12 22:22:17 +00:00
Emilio Cobos Álvarez df34135583 Bug 1738663 - Remove unneeded special-case for backdrop-filter in GenerateCSS2PropertiesWebIDL. r=layout-reviewers,mats
This was needed when backdrop-filter-enabledness depended on
WebRender-enabledness, but now it's available everywhere.

Depends on D130027

Differential Revision: https://phabricator.services.mozilla.com/D130028
2021-11-02 14:22:08 +00:00
Erik Nordin b077117ab0 Bug 1637437 - Recompute backdrop-filter only when WebRender changes r=jrmuizel
- Add a gfxVarReceiver for nsCSSProps.
  - Recompute backdrop-filter state when notifying receivers for WebRender.
  - Remove NS_NewRunableFunction calls when we know we're on main thread.
  - Add assertion that recompute enabled state is called from main thread.

Differential Revision: https://phabricator.services.mozilla.com/D74975
2020-05-27 19:53:05 +00:00
Erik Nordin f10166a614 Bug 1635584 - Make BackdropFilter's Availability Depend on WebRender r=emilio
- Enable BackdropFilter pref by default
  - Add function IsBackdropFilterAavailable()
  - Use IsBackdropFilterAvailable for relevant WebIDL instead of pref
  - Add test for BackdropFilter availability

Differential Revision: https://phabricator.services.mozilla.com/D73967
2020-05-08 05:54:26 +00:00
Razvan Maries d52f7a898c Backed out 2 changesets (bug 1635584) for build bustages. CLOSED TREE
Backed out changeset 059ed60f23bf (bug 1635584)
Backed out changeset 876b8f443cca (bug 1635584)
2020-05-08 00:47:31 +03:00
Erik Nordin 3cd3cc6820 Bug 1635584 - Make BackdropFilter's Availability Depend on WebRender r=emilio
- Enable BackdropFilter pref by default
  - Add function IsBackdropFilterAavailable()
  - Use IsBackdropFilterAvailable for relevant WebIDL instead of pref
  - Add test for BackdropFilter availability

Differential Revision: https://phabricator.services.mozilla.com/D73967
2020-05-06 23:47:06 +00:00
Erik Nordin 9a02b00263 Bug 1633863 - Remove nsCSSProps Dependency on BoolVarCache r=emilio,KrisWright
- Add new function `nsCSSProps::RecomputeEnabledState()`
- Register callbacks to `RecomputeEnabledState` instead of using `BoolVarCache`

Differential Revision: https://phabricator.services.mozilla.com/D73356
2020-05-04 06:01:49 +00:00
Emilio Cobos Álvarez 54cc92c94d Bug 1617472 - Remove nsCSSKeywords and related infrastructure. r=heycam
Seeya

Depends on D63795

Differential Revision: https://phabricator.services.mozilla.com/D63796

--HG--
extra : moz-landing-system : lando
2020-02-24 13:30:48 +00:00
Emilio Cobos Álvarez 8d0f4ce3ca Bug 1617472 - Remove kTextDecorationStyleKTable. r=heycam
In a somewhat easy way. There are better ways to do this (moving
text-decoration-style to be a proper cbindgen enum class or such), but this
does the job for now.

Depends on D63794

Differential Revision: https://phabricator.services.mozilla.com/D63795

--HG--
extra : moz-landing-system : lando
2020-02-24 13:30:46 +00:00
Emilio Cobos Álvarez 1ff4460ea3 Bug 1617472 - Remove kTextAlignKTable. r=heycam
Depends on D63793

Differential Revision: https://phabricator.services.mozilla.com/D63794

--HG--
extra : moz-landing-system : lando
2020-02-24 13:30:44 +00:00
Emilio Cobos Álvarez 844051acc0 Bug 1617472 - Remove kFontSmoothingKTable. r=heycam
Use the more general mechanism to get a property value. We can't just remove
the getter because of the resist-fingerprinting check, but...

Depends on D63791

Differential Revision: https://phabricator.services.mozilla.com/D63792

--HG--
extra : moz-landing-system : lando
2020-02-24 13:29:45 +00:00
Emilio Cobos Álvarez 6bfbf10f25 Bug 1611711 - Remove kCursorKTable. r=jwatt
(And while at it, format the end of the other keyword tables so that
cleanup_ktables.py works).

It seems `Window.setCursor` is only used once in our code, maybe
we should remove it...

Differential Revision: https://phabricator.services.mozilla.com/D61090

--HG--
extra : moz-landing-system : lando
2020-01-26 20:17:41 +00:00
Emilio Cobos Álvarez 86a70df5d7 Bug 1607006 - Remove utf-16 versions of nsCSSProps::LookupProperty* and ServoCSSParser::ComputeColor. r=bzbarsky
Now that we have UTF8String in the WebIDL, we can remove quite a few of the
conversions. Do that, and lift the remaining string conversions up as needed.

Also deindent Servo_ComputeColor while touching it.

Most of the remaining copies are because either bug 1606994, or because they're
WebIDL attributes that we still need to serialize back as UTF-16 (bug 1606995).

Differential Revision: https://phabricator.services.mozilla.com/D58687

--HG--
extra : moz-landing-system : lando
2020-01-08 01:21:30 +00:00
Emilio Cobos Álvarez bc36653df5 Bug 1449861 - Use UTF8String for some CSSOM APIs. r=bzbarsky
In particular, the ones where we transcode unconditionally atm (property names
and such).

There are others like cssText getters and setters which are a bit harder,
because I either need to rewrite all our serialization code to work with UTF8
(which is fine, but a lot of work), or teach webidl to have a setter that takes
UTF8String as input but returns DOMString as output (which is at best hacky).

Differential Revision: https://phabricator.services.mozilla.com/D58631

--HG--
extra : moz-landing-system : lando
2020-01-04 10:36:49 +00:00
Sylvestre Ledru f12b9fa5c3 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D47737

--HG--
extra : moz-landing-system : lando
2019-10-06 18:29:55 +00:00
Emilio Cobos Álvarez 1e858d2a04 Bug 1578661 - Fix use counter test. r=boris
By reporting the properties in MappedAttrParser that we used to (the test relies
on counting those), and by adjusting the histogram name to the new thing.

Differential Revision: https://phabricator.services.mozilla.com/D44697

--HG--
extra : moz-landing-system : lando
2019-09-19 00:20:39 +00:00
Emilio Cobos Álvarez 31755a845c Bug 1578661 - Remove old CSS use counters. r=boris
We only have two counters enabled, just for testing, and they just count from
the SVG mapped attribute code. That's not great, and they mostly complicate the
next few patches.

Differential Revision: https://phabricator.services.mozilla.com/D44695

--HG--
extra : moz-landing-system : lando
2019-09-19 00:20:35 +00:00
Cosmin Sabou 2978a72248 Backed out 10 changesets (bug 1578661) for linting failures on layout/style/ServoCSSPropList.py. CLOSED TREE
Backed out changeset b1b5393b1099 (bug 1578661)
Backed out changeset b87eebb0cf6e (bug 1578661)
Backed out changeset 6ba2ee45f26e (bug 1578661)
Backed out changeset 4a1d45160d60 (bug 1578661)
Backed out changeset 7a5687bebc02 (bug 1578661)
Backed out changeset 33c306c9020a (bug 1578661)
Backed out changeset 89d7e6fb24b0 (bug 1578661)
Backed out changeset 42c4943e569b (bug 1578661)
Backed out changeset 88d988a80de1 (bug 1578661)
Backed out changeset 78c90f9e9eee (bug 1578661)
2019-09-19 01:50:03 +03:00
Emilio Cobos Álvarez 2adb14b20a Bug 1578661 - Fix use counter test. r=boris
By reporting the properties in MappedAttrParser that we used to (the test relies
on counting those), and by adjusting the histogram name to the new thing.

Differential Revision: https://phabricator.services.mozilla.com/D44697

--HG--
extra : moz-landing-system : lando
2019-09-18 15:15:26 +00:00
Emilio Cobos Álvarez 6a2a92e98a Bug 1578661 - Remove old CSS use counters. r=boris
We only have two counters enabled, just for testing, and they just count from
the SVG mapped attribute code. That's not great, and they mostly complicate the
next few patches.

Differential Revision: https://phabricator.services.mozilla.com/D44695

--HG--
extra : moz-landing-system : lando
2019-09-18 15:15:19 +00:00
Andreea Pavel 7494b360c0 Backed out 10 changesets (bug 1578661) for lints failure at ServoCSSPropList.cpp on a CLOSED TREE
Backed out changeset ed3c619100e7 (bug 1578661)
Backed out changeset 027514a2eaf6 (bug 1578661)
Backed out changeset f2e228282b20 (bug 1578661)
Backed out changeset 67c36136dce7 (bug 1578661)
Backed out changeset 2280b27cc130 (bug 1578661)
Backed out changeset 445d13a2c452 (bug 1578661)
Backed out changeset 89caaa850049 (bug 1578661)
Backed out changeset 2f8be5db1786 (bug 1578661)
Backed out changeset 51a015a9a0f8 (bug 1578661)
Backed out changeset ad8e1f27a600 (bug 1578661)
2019-09-18 18:09:30 +03:00
Emilio Cobos Álvarez 959c99b520 Bug 1578661 - Fix use counter test. r=boris
By reporting the properties in MappedAttrParser that we used to (the test relies
on counting those), and by adjusting the histogram name to the new thing.

Differential Revision: https://phabricator.services.mozilla.com/D44697

--HG--
extra : moz-landing-system : lando
2019-09-18 12:04:37 +00:00
Emilio Cobos Álvarez d880111e86 Bug 1578661 - Remove old CSS use counters. r=boris
We only have two counters enabled, just for testing, and they just count from
the SVG mapped attribute code. That's not great, and they mostly complicate the
next few patches.

Differential Revision: https://phabricator.services.mozilla.com/D44695

--HG--
extra : moz-landing-system : lando
2019-09-18 12:04:33 +00:00
Andreea Pavel 31ca3fda59 Backed out 9 changesets (bug 1578661) for lints failure at ServoCSSPropList.py a=backout
Backed out changeset d16463e5698c (bug 1578661)
Backed out changeset c6d64ac858ba (bug 1578661)
Backed out changeset db306f1467f7 (bug 1578661)
Backed out changeset 273535aab82d (bug 1578661)
Backed out changeset f643262a8c25 (bug 1578661)
Backed out changeset b0db409ada96 (bug 1578661)
Backed out changeset dc96d13728e0 (bug 1578661)
Backed out changeset 11e1e8f0a1b7 (bug 1578661)
Backed out changeset 6dd7a0d914d9 (bug 1578661)
2019-09-18 13:53:34 +03:00
Emilio Cobos Álvarez f8337abcef Bug 1578661 - Fix use counter test. r=boris
By reporting the properties in MappedAttrParser that we used to (the test relies
on counting those), and by adjusting the histogram name to the new thing.

Differential Revision: https://phabricator.services.mozilla.com/D44697

--HG--
extra : moz-landing-system : lando
2019-09-18 02:31:19 +00:00
Emilio Cobos Álvarez a9ba10a9bc Bug 1578661 - Remove old CSS use counters. r=boris
We only have two counters enabled, just for testing, and they just count from
the SVG mapped attribute code. That's not great, and they mostly complicate the
next few patches.

Differential Revision: https://phabricator.services.mozilla.com/D44695

--HG--
extra : moz-landing-system : lando
2019-09-18 02:32:52 +00:00
Emilio Cobos Álvarez f4fb9ab137 Bug 1576194 - Remove kDisplayKTable. r=mats
It doesn't represent anything useful anymore.

Differential Revision: https://phabricator.services.mozilla.com/D43262

--HG--
extra : moz-landing-system : lando
2019-08-23 15:52:05 +00:00
Mats Palmgren 09a19fcfea Bug 1038294 part 1 - Make nsCSSKTableEntry use uint16_t to represent the value. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D39753

--HG--
extra : moz-landing-system : lando
2019-08-14 14:31:34 +00:00
Emilio Cobos Álvarez 141cad6847 Bug 1519958 - Drive by, remove unused CSS keywords. r=boris
While we're at it we may as well do this.

Differential Revision: https://phabricator.services.mozilla.com/D36350
2019-06-28 21:15:01 +02:00
Emilio Cobos Álvarez fce57b44fd Bug 1552878 - Use cbindgen for filters. r=jwatt
Had to implement some OwnedSlice bits that the canvas code used.

Differential Revision: https://phabricator.services.mozilla.com/D31799
2019-05-29 21:22:07 +02:00
Brindusan Cristian 40a5b04ab5 Backed out 3 changesets (bug 1552708, bug 1552878) for build bustages and compiler issues. CLOSED TREE
Backed out changeset 9d4f178bfcbd (bug 1552878)
Backed out changeset 80db9f845237 (bug 1552708)
Backed out changeset 1bdbfbb5b342 (bug 1552708)
2019-05-27 17:00:03 +03:00
Emilio Cobos Álvarez a6bdf94e22 Bug 1552878 - Use cbindgen for filters. r=jwatt
Had to implement some OwnedSlice bits that the canvas code used.

Differential Revision: https://phabricator.services.mozilla.com/D31799

--HG--
extra : moz-landing-system : lando
2019-05-27 12:37:37 +00:00
violet 91d759f562 Bug 1553252 - Use cbindgen for text-overflow r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D32285

--HG--
extra : moz-landing-system : lando
2019-05-24 04:48:46 +00:00
Oana Pop Rus d020804eba Backed out changeset 3304277f5bde (bug 1553252) for build bustages on Windows on a CLOSED TREE 2019-05-23 17:52:21 +03:00
violet 4ab5380719 Bug 1553252 - Use cbindgen for text-overflow r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D32285

--HG--
extra : moz-landing-system : lando
2019-05-23 14:02:17 +00:00
Emilio Cobos Álvarez edde08a7cb Bug 1547985 - Use rust types for vertical-align. r=mats
The previous commit removed the dependence on the discriminant value, so we
don't need to keep discriminants different from text-align anymore.

Differential Revision: https://phabricator.services.mozilla.com/D29361

--HG--
extra : moz-landing-system : lando
2019-05-01 13:08:34 +00:00
Emilio Cobos Álvarez 11ea945833 Bug 1546697 - Use a consistent style for enum classes in layout. r=dholbert
Per the discussion in:

  https://groups.google.com/d/msg/mozilla.dev.platform/P79pwa9z5m8/iPYPAWPHCAAJ

They should be CamelCase, and that's what most of them already do. This converts
the rest, which are a few.

For the ones that already used `e` or `k` prefixes, I've mostly done:

 for file in $(rg Type::e layout | cut -d : -f 1 | sort | uniq); do sed -i 's#Type::e#Type::#g' $file; done

For the ones that used uppercase, I've removed the prefix if it was already in
the type name, and turn them into CamelCase.

Depends on D28680

Differential Revision: https://phabricator.services.mozilla.com/D28681

--HG--
extra : moz-landing-system : lando
2019-04-25 23:03:04 +00:00
Brian Birtles 86cd66683b Bug 1543304 - Add MOZ_DBG support for nsCSSPropertyID and nsCSSPropertyIDSet; r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D26856

--HG--
extra : moz-landing-system : lando
2019-04-14 23:48:05 +00:00
Emilio Cobos Álvarez 70e3f8ffcd Bug 1535165 - Use cbindgen for touch-action. r=dholbert
And rename the constants to not be prefixed by TOUCH_ACTION_, since that's part
of the type name anyway.

Differential Revision: https://phabricator.services.mozilla.com/D23413

--HG--
extra : moz-landing-system : lando
2019-03-18 18:01:55 +00:00
Emilio Cobos Álvarez e66fb8488c Bug 1535165 - Use cbindgen for text-decoration-line. r=dholbert,boris
Differential Revision: https://phabricator.services.mozilla.com/D23412

--HG--
extra : moz-landing-system : lando
2019-03-18 17:58:16 +00:00
Daniel Holbert 99a091abb7 Bug 1532833: Use servo code to serialize CSS 'contain' property. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D22260

--HG--
extra : moz-landing-system : lando
2019-03-06 16:50:05 +00:00
Emilio Cobos Álvarez e9ae3b0907 Bug 1527410 - Use Rust sizes for flex-basis, width, height, and their min/max properties. r=jwatt
Really sorry for the size of the patch :(

Only intentional behavior change is in the uses of HasLengthAndPercentage(),
where it's easier to do the right thing. The checks that used to check for
(IsCalcUnit() && CalcHasPercentage()) are wrong since bug 957915.

Differential Revision: https://phabricator.services.mozilla.com/D19553
2019-02-15 03:59:31 +01:00
Mats Palmgren 663f6ee46c Bug 1519944 - [css-logical] Implement the margin-block/inline shorthands. r=emilio 2019-01-15 02:27:44 +01:00
Daniel Holbert 7258ebe69e Bug 1514309 part 2: Remove C++ serialization code for CSS {align,justify}-{content,items,self} properties. r=emilio
(Also remove stale decl for DoGetOverflowY, which cleanup_computed_getters.py
found for me.)

Differential Revision: https://phabricator.services.mozilla.com/D14618

--HG--
extra : moz-landing-system : lando
2018-12-14 21:27:18 +00:00
Emilio Cobos Álvarez 4591031b65 Bug 1513012 - Move overflow to use cbindgen. r=heycam
It's one of the most annoying / hacky mako bits we have.

Differential Revision: https://phabricator.services.mozilla.com/D14084
2018-12-11 03:07:08 +01:00