This prevents copies and avoids the hack we have to avoid this, which
right now is using nsDependent{C,}String.
Non-virtual actors can still use `nsString` if they need to on the
receiving end.
Differential Revision: https://phabricator.services.mozilla.com/D152519
C++20 changes to direct initialization with initializer lists make FileInfoManagerGuard's default constructor inaccessible.
https://en.cppreference.com/w/cpp/language/direct_initialization
dom/indexedDB/ActorsParent.cpp:12131:21: error: calling a private constructor of class 'mozilla::dom::indexedDB::FileInfoManager<mozilla::dom::indexedDB::DatabaseFileManager>::FileInfoManagerGuard'
FileInfoManagerGuard{}, SafeRefPtrFromThis(), id,
^
dom/indexedDB/FileInfoManager.h:92:5: note: implicitly declared private here
FileInfoManagerGuard() = default;
^
Differential Revision: https://phabricator.services.mozilla.com/D149349
Transactions transition to the finished state in following cases:
1. No requests have been created and we are back at the event loop.
2. The last request has been finished.
3. A transaction has been explicitly aborted.
4. A transaction has been explicitly committed.
When a transaction is finished, we send either an abort or commit message to
the parent process.
Bug 1598164 introduced an active and inactive state, so the state can't be used
for determining if a request was created. However, this was initially
overlooked, so we ended up not sending the abort message in some cases which
led to intermittent failures.
The correct wasy to determine if the abort messages should be sent to the
parent process is to check mStarted flag only.
Differential Revision: https://phabricator.services.mozilla.com/D150937
This does a somewhat-shallow removal of the argument from the implementation
and all call-sites. Removing it from StructuredCloneData's serialization is
handled in the next part, as it is more widely used and complex.
Differential Revision: https://phabricator.services.mozilla.com/D148531
This is a complete rewrite of RemoteLazyInputStream to run off of its own
toplevel protocol, rather than being managed by other protocols like
PBackground or PContent. This should improve performance thanks to no longer
needing to operate on a main or worker thread, and due to no longer needing the
migration step for the stream actor.
This also acts as a step towards no longer requiring a manager actor to
serialize input streams, as the type is now actor-agnostic, and should support
being sent over IPC between any pair of processes.
Differential Revision: https://phabricator.services.mozilla.com/D141040
This interface should no longer be required due to the changes in part 1
limiting the complexity of IPCStream instances and limiting the number of file
descriptors which a single stream can attach to a message.
Removing this interface is necessary to serialize nsIInputStream instances over
arbitrary toplevel protocols and non-protocol IPC in the future.
Differential Revision: https://phabricator.services.mozilla.com/D141039
This gives us various positive benefits, such as using a shared memory ring
buffer for faster communication, not having data streaming being bound to the
thread which transferred the nsIInputStream (which is often the main thread),
and the ability for some backpressure to be applied to data streaming.
After this change, the "delayed start" parameter for IPCStream serialization is
less relevant, as backpressure will serve a similar purpose. It will still be
used to determine whether or not to use RemoteLazyInputStream when serializing
from the parent process.
Differential Revision: https://phabricator.services.mozilla.com/D141038
This is a complete rewrite of RemoteLazyInputStream to run off of its own
toplevel protocol, rather than being managed by other protocols like
PBackground or PContent. This should improve performance thanks to no longer
needing to operate on a main or worker thread, and due to no longer needing the
migration step for the stream actor.
This also acts as a step towards no longer requiring a manager actor to
serialize input streams, as the type is now actor-agnostic, and should support
being sent over IPC between any pair of processes.
Differential Revision: https://phabricator.services.mozilla.com/D141040
This interface should no longer be required due to the changes in part 1
limiting the complexity of IPCStream instances and limiting the number of file
descriptors which a single stream can attach to a message.
Removing this interface is necessary to serialize nsIInputStream instances over
arbitrary toplevel protocols and non-protocol IPC in the future.
Differential Revision: https://phabricator.services.mozilla.com/D141039
This gives us various positive benefits, such as using a shared memory ring
buffer for faster communication, not having data streaming being bound to the
thread which transferred the nsIInputStream (which is often the main thread),
and the ability for some backpressure to be applied to data streaming.
After this change, the "delayed start" parameter for IPCStream serialization is
less relevant, as backpressure will serve a similar purpose. It will still be
used to determine whether or not to use RemoteLazyInputStream when serializing
from the parent process.
Differential Revision: https://phabricator.services.mozilla.com/D141038
Emilio Cobos Álvarez
Thomas Wisniewski
Kagami Sascha Rosylight
criss
Cristian Tuns
Norisz Fay
Ryan VanderMeulen
Tooru Fujisawa
Chris Peterson
Jan Varga
Joel Maher
Iulian Moraru
Kris Maglione
Michael Kohler
Butkovits Atila
Nika Layzell
Jan Rio Krause
Andreea Pavel
Serge Guelton
Noemi Erli
Marian-Vasile Laza