This will remove the need to sniff class types. The 1 in-tree
consumer doing this has been converted.
MozReview-Commit-ID: I8cUa8J54VE
--HG--
extra : rebase_source : 4c24adaf7eb9d62678ac78604e819a7376d4073b
We've had 4 submissions in 2017. jgriffin and I agreed that it was a
failed experiment and we should either abandon it or figure out how
to increase participation. Since nobody is available to improve it,
I'm inclined to just delete it. If we want to bring it back, it is
always in version control.
MozReview-Commit-ID: AizkZxjQ8IJ
--HG--
extra : rebase_source : 0e29058cfc909fb51fc56fa9b46c0e0a6eef0bf9
The checking on the return of value of fetch/locate is not working as intended.
The code should be early returning, but the return value of fetch/locate is 1 in
failure cases, which will not trigger the early return. The return value has
been altered to None, which will trigger the early return.
MozReview-Commit-ID: FDCW6rbZI6T
--HG--
extra : rebase_source : 8b087174db268d7d6a0bb62e6537f82a3b15b28d
Currently the mach clang-format command is formating '-r tip^', which is
everything in the tip revision, plus changes. Often this does what you want,
but if you're using changeset evolution or history rewriting this doesn't work
so well. If you `hg up $rev` to some other revision with the intention of
clang-formating that revision, you don't get that revision formated when you
run clang-format. You get the lines touched by the changeset with the "tip"
bookmark formatted. We really want to have clang-format format '-r .^' which
means "the current revision in the working dir, plus any uncommited changes".
This results in the expected behaviour, and means clang-format can be used to
re-format commits which are work-in-progress and/or being evolved.
MozReview-Commit-ID: iv82HENxiA
--HG--
extra : rebase_source : a1d05472f499f5a68bcaab9ce260d60ecbca067d
This commit introduces the `mach rage` command. It opens a web browser
and loads a new tab with a short Google Form.
Google Forms appears to not have optional login where they capture login
info if available. So, we attempt to prepopulate the contact info
from version control or from the current login name. This field
is directly above the submit button, so it should be obvious enough
that people can clear it if they want to leave an anonymous response.
The alternative is we require a login to the Mozilla Google Apps
account. And that feels wrong.
r+ on this bug also constitutes r+ on the Google Form content.
MozReview-Commit-ID: HVAVVVva29T
--HG--
extra : rebase_source : d00aa424ffd42d8cd5d2d8a85aef8b3c24b59520
We no longer update UUIDs when changing XPIDL interfaces. `mach
update-uuids` was invented to make this process easier. Delete the
command and related code since it is no longer needed.
--HG--
extra : commitid : GLChZKelC0Q
extra : rebase_source : f4a8f9727f1213ae4fe5d17fa1a648ed8802095f
extra : amend_source : 2fdab014f16482ae82e0cc0f9b2c2f4620001657
This prevents 8 module imports from occurring at mach startup time.
As part of this, I discovered a redundant import of "sys" and eliminated
it.
--HG--
extra : commitid : AsZJHdCVbV0
extra : rebase_source : 53b1d5912ba85c7d363d9da21329a6fa65a2bce2
This removes ambiguity as to which modules are being imported, making
import slightly faster as Python doesn't need to test so many
directories for file presence.
All files should already be using absolute imports because mach command
modules aren't imported to the package they belong to: they instead
belong to the "mach" package. So relative imports shouldn't have been
used.
--HG--
extra : commitid : 6tFME1KKfTD
extra : rebase_source : 78728f82f5487281620e00c2a8004cd5e1968087
Back when mozpack.path was added, it was used as:
import mozpack.path
mozpack.path.func()
Nowadays, the common idiom is:
import mozpack.path as mozpath
mozpath.func()
because it's shorter.
$ git grep mozpath\\. | wc -l
423
$ git grep mozpack.path\\. | wc -l
123
This change was done with:
$ git grep -l mozpack.path\\. | xargs sed -i 's/mozpack\.path\./mozpath./g'
$ git grep -l 'import mozpack.path$' | xargs sed -i 's/import mozpack.path$/\0 as mozpath/'
$ (pat='import mozpack.path as mozpath'; git grep -l "$pat" | xargs sed -i "1,/$pat/b;/$pat/d")
We previous added support for RBTools in bug 943747 and bug 945577. Now
that we have MozReview, this functionality is next to useless. MozReview
is the future. So, we remove the old RBTools code.
DONTBUILD (NPOTB)
--HG--
extra : rebase_source : 2b307c31a5c484cb0bd785f582e3c248c3cb11da
The reason to use '+' prefixing was to distinguish between options to the
mach command itself, and options that are passed down to whatever the
command does (like mach run passing down args to the built application).
That makes things unnecessarily awkward, and quite non-standard.
Instead, use standard '-' prefixing, and pass all the unknown arguments
down. If there is overlap between the known arguments and arguments supported
by the underlying tool (like -remote when using mach run), it is possible to
use '--' to mark all following arguments as being targetted at the underlying
tool.
For instance:
mach run -- -remote something
would run
firefox -remote something
while
mach run -remote something
would run
firefox something
As allow_all_arguments is redundant with the presence of a argparse.REMAINDER
CommandArgument, allow_all_arguments is removed. The only mach command with a
argparse.REMAINDER CommandArgument without allow_all_arguments was "mach dmd",
and it did so because it didn't want to use '+' prefixes.
We were previously installing a pre-release of RBTools from Git. The
patches we were waiting on are now in RBTools 0.6. So, install the
released version from PyPI.
DONTBUILD (NPOTB)
--HG--
extra : rebase_source : 0c3c13c6e9ec24ae7ebcabe5b2e4fa64441b2332
RBTools as released on PyPI has a number of bugs and deficiencies with
the Mercurial implementation. These have been fixed in an unreleased
version of RBTools.
Until RBTools with the desired patches is released to PyPI, we will
install RBTools direct from its source repository.
DONTBUILD (NPOTB)
--HG--
extra : rebase_source : 8fe09b80d8dd5583ba957b4525563cde678b3b3d
extra : amend_source : b41e0d492ff7d1f78bd0462782459c3dc8e95041
Sylvestre Ledru
Xavier ALT
Rok Garbas
Gregory Szorc
Prithviraj Pawar
Bryce Van Dyk
Chris Pearce
Ting-Yu Lin
Julien Pagès
Peter Elmers
Mike Hommey
Vikrantsingh Bisen
Ed Morley
Anthony Jones
Anhad Jai Singh
Graeme McCutcheon