Граф коммитов

9501 Коммитов

Автор SHA1 Сообщение Дата
Agi Sferro a2f65accfd Bug 1644519 - Wait for permission change to settle in browser_doorhanger_installs.js. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D79382
2020-06-12 17:13:37 +00:00
Agi Sferro e97469625b Bug 1644519 - Remove code duplication in browser_doorhanger_installs.js. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D79381
2020-06-11 23:38:20 +00:00
Agi Sferro 2e7967f982 Bug 1644217 - Wait for incognito change to have effect in tests. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D79194
2020-06-11 01:08:54 +00:00
Johann Hofmann 20b1b77919 Bug 1515073 - Part 5 - Disable browser.navigation.requireUserInteraction in tests. r=Gijs
Depends on D27588

Differential Revision: https://phabricator.services.mozilla.com/D31604
2020-06-09 14:51:06 +00:00
Agi Sferro 98b2209e91 Bug 1637680 - Make softDisable setter async. r=mixedpuppy
Some tests rely on the order of execution of the blocklist code which cannot be
guaranteed if we don't wait for the enabled state to settle.

In particular, when calling `_onUpdate` in
`AddonTestUtils.loadBlocklistRawData` in [0] we implicitely assume that all the
actions deriving from updating the blocklist settle before the promise is
completed, this is not true for the enabled state.

Currently the test succedes because `ExtensionPermissions.get` is not actually
async in most cases, this is about to change in the next patch.

[0]: https://searchfox.org/mozilla-central/rev/559b25eb41c1cbffcb90a34e008b8288312fcd25/toolkit/mozapps/extensions/internal/AddonTestUtils.jsm#925

Differential Revision: https://phabricator.services.mozilla.com/D77937
2020-06-08 15:45:23 +00:00
Agi Sferro 4472fb097a Bug 1559683 - Rename STATE_CHECKING -> STATE_CHECKING_UPDATE. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D76904
2020-06-08 15:45:30 +00:00
Agi Sferro 284402fea3 Bug 1559683 - Reject install.cancel() call when loadManifest is running. r=mixedpuppy,robwu
Differential Revision: https://phabricator.services.mozilla.com/D76903
2020-06-08 15:45:38 +00:00
Rob Wu f936fcf3c4 Bug 1643854 - Avoid error on theme update r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D78592
2020-06-08 15:33:46 +00:00
Michael Kaply 5628ca6bbe Bug 1466512 - Add a policy for forcing a master password. r=fluent-reviewers,MattN,flod
Differential Revision: https://phabricator.services.mozilla.com/D70935
2020-06-04 20:01:54 +00:00
Gijs Kruitbosch 6c6ab1223a Bug 1606797 - restrict opening the 'open external protocol' dialog, r=johannh,fluent-reviewers,flod
This patch adds the following constraints:

- close the dialog when the originating context navigates;
- close the dialog when the originating context closes / goes away;
- do not allow more than 1 dialog at a time;

Differential Revision: https://phabricator.services.mozilla.com/D77029
2020-06-02 17:12:09 +00:00
Gijs Kruitbosch 728702a673 Bug 1606797 - pass the triggering principal when opening external URIs, r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D77027
2020-05-27 12:46:34 +00:00
Narcis Beleuzu 2c678de562 Backed out 3 changesets (bug 1633370, bug 613785) for mochitest failures on test_prompt_promptAuth.html . CLOSED TREE
Backed out changeset 333d10fedb1a (bug 613785)
Backed out changeset fdc328259d08 (bug 613785)
Backed out changeset 6bcd571ae2fc (bug 1633370)
2020-06-03 01:10:04 +03:00
pbz d8204e01b9 Bug 613785 - Updated http auth prompt tests to support tab prompts. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D75567
2020-05-28 11:11:52 +00:00
Andrea Marchesini 5ccae203ff Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-02 13:49:27 +00:00
Csoregi Natalia e960b9f449 Backed out 7 changesets (bug 1640405, bug 1638358) for failures on browser_webconsole_network_messages_status_code.js. CLOSED TREE
Backed out changeset ef5f7479ddf8 (bug 1640405)
Backed out changeset 286e0c83eb30 (bug 1638358)
Backed out changeset 89e396b2896e (bug 1638358)
Backed out changeset 33ad5fa05209 (bug 1638358)
Backed out changeset d213264c1379 (bug 1638358)
Backed out changeset 6bc05236afb4 (bug 1638358)
Backed out changeset 87e9d0ed3982 (bug 1638358)
2020-06-02 15:16:42 +03:00
Andrea Marchesini b4173bc59e Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-02 09:13:51 +00:00
Razvan Maries 79fe28f0d6 Backed out 6 changesets (bug 1638358) for perma failures on browser_webconsole_navigate_to_parse_error.js. CLOSED TREE
Backed out changeset beb85cf281d5 (bug 1638358)
Backed out changeset 39f2e21623aa (bug 1638358)
Backed out changeset 2c873c72bf1f (bug 1638358)
Backed out changeset e91292c7c719 (bug 1638358)
Backed out changeset 0219ef931cd9 (bug 1638358)
Backed out changeset 4ac06f3992f4 (bug 1638358)
2020-06-02 00:24:46 +03:00
Razvan Maries a36bb7751f Backed out 3 changesets (bug 1638153) for perma failures on cross-origin-objects.html. CLOSED TREE
Backed out changeset f7aedc92d396 (bug 1638153)
Backed out changeset 07ec713926c6 (bug 1638153)
Backed out changeset 5a656842e241 (bug 1638153)
2020-06-01 23:51:35 +03:00
Andrea Marchesini 848f1f0043 Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-01 17:59:13 +00:00
Kris Maglione b3fcd970ec Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Differential Revision: https://phabricator.services.mozilla.com/D75429
2020-06-01 17:59:01 +00:00
Noemi Erli e40be0aa72 Backed out 6 changesets (bug 1638358) for causing failures in test_Chrome_cookies.js CLOSED TREE
Backed out changeset 4e8fbe01aa38 (bug 1638358)
Backed out changeset 532731e94bb2 (bug 1638358)
Backed out changeset fad2ba760157 (bug 1638358)
Backed out changeset 932a3fdbd07c (bug 1638358)
Backed out changeset 05a62901a3f5 (bug 1638358)
Backed out changeset cddeada5c4a6 (bug 1638358)
2020-06-01 19:45:46 +03:00
Ricky Stewart 0bbaac721b Bug 1641693 - Replace a bunch of uses of `GENERATED_FILES` with the `GeneratedFile` template r=necko-reviewers,geckoview-reviewers,aklotz,dragana,froydnj
Also update documentation to suggest using the `GeneratedFile` template rather than directly referencing `GENERATED_FILES` where possible.

Differential Revision: https://phabricator.services.mozilla.com/D77496
2020-06-01 16:00:28 +00:00
Andrea Marchesini 165022b2c4 Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-01 11:43:19 +00:00
Dorel Luca 9574e25c80 Backed out 6 changesets (bug 1638358) for XPCShell failures in netwerk/cookie/test/unit/test_schemeMap.js. CLOSED TREE
Backed out changeset 745eab35e851 (bug 1638358)
Backed out changeset a45df1876e37 (bug 1638358)
Backed out changeset 1a85cc92d2fb (bug 1638358)
Backed out changeset 2156294cb158 (bug 1638358)
Backed out changeset 31101054c52c (bug 1638358)
Backed out changeset d284b50551ab (bug 1638358)
2020-06-01 14:38:22 +03:00
Andrea Marchesini d1c11476f6 Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-01 10:28:51 +00:00
Robert Helmer 75b624f4dc Bug 1640306 - move toggle button to shared r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D76934
2020-05-29 21:37:59 +00:00
Jared Wein fd5b93e11e Bug 1640589 - Update the mimeInfo when a download is handled internally. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D77144
2020-05-28 16:48:48 +00:00
Magnus Melin d297aa2c94 Bug 1641400 - skip Thunderbird for blocklist telemetry. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D77238
2020-05-28 12:57:06 +00:00
Molly Howell ff022d25ab Bug 1626887 Followup - Don't leave a task folder around when we fail to create a scheduled task. r=bytesized
This is needed to prevent a failed attempt to create the task from blocking
out the ability to try again later if the two attempts are run under different
user contexts, where the second is more limited than the first, because the
less privileged attempt is unlikely to have permission to write to the folder
created by the more privileged one. In particular the MSI installer runs into
this scenario, because it makes one attempt to register the task as SYSTEM,
followed by a second attempt as the unelevated interactive user.

This is also nice because it keeps us from leaving an empty folder behind
under any circumstances, not just this specific situation.

Differential Revision: https://phabricator.services.mozilla.com/D77184
2020-05-27 23:37:05 +00:00
Mark Smith 7b93c9ae97 Bug 1588549 - --disable-maintenance-service should exclude all maintenance service-related code r=bytesized,mhowell
Exclude Windows Maintenance Service-related C++ code and avoid linking
with unnecessary libraries when building with --disable-maintenance-service.

Differential Revision: https://phabricator.services.mozilla.com/D76349
2020-05-27 21:22:15 +00:00
Adam Gashlin e38a47a505 Bug 1633505 - Show refresh button within the uninstaller. r=mhowell
Detect a profile for the installation, if found offer refresh on welcome page:
- Replace text
- Add help link and button

Add a different prompt to close the browser for refresh.

When leaving the welcome page:
- via help link, launch a URL
- via Refresh button, launch Firefox with the necessary args

Add utility functions to launch the link and Firefox.

Remove the UN_CONFIRM_CLICK label and hide the subheading, this was an
addition to the design. Move down UN_CONFIRM_PAGE_TITLE to fill in the space.

Move the check for the install-specific profile to common.nsh from stub.nsi,
wrapped in stack ops to save regs and with _MOZFUNC_UN for uninstaller compat.

Move InitHashAppModelId to just after un.UninstallUnOnInitCommon (which sets
$INSTDIR correctly), so AUMID would be available in un.PreWelcome. I don't
think there's anything else that would change $INSTDIR in the uninstaller
so this should be ok.

Unrelated but adjacent cleanup: Remove inappropriate use of _MOZFUNC_UN
in CopyPostSigningData.

Differential Revision: https://phabricator.services.mozilla.com/D76435
2020-05-26 21:47:58 +00:00
Molly Howell d2fa14f4ef Bug 1638509 - Enable the limited PostUpdate to update the WDBA task. r=agashlin,bytesized
This also requires removing the registry value cleanup from the unregister-task
command and adding a new uninstall command which removes both the task and the
registry values, because this patch now runs unregister-task during updates to
remove the task before re-adding it, and that needs to leave the registry alone.

Differential Revision: https://phabricator.services.mozilla.com/D76354
2020-05-26 15:38:21 +00:00
Rob Wu 5f41144b5c Bug 1640953 - Prevent RS dumps from being loaded in some blocklist tests r=gijs CLOSED TREE
RemoteSettings helpfully falls back to loading from the JSON dumps when
the list of records is empty. This breaks tests that load an empty
blocklist, because unexpected records may appear.

Fix this by inserting a dummy value in the blocklist. Invalid records
should be ignored anyway, so this is a good way to prevent the dump from
being loaded.

Differential Revision: https://phabricator.services.mozilla.com/D76875
2020-05-26 17:05:06 +00:00
Rob Wu ed773eda20 Bug 1633466 - Record usage of blocklist v3 in telemetry r=rpl,janerik
Although the data review request granted permission to keep the probes
for 6 months, I'm using a shorter expiration (81) so that all
blocklist-related telemetry can be coverd by one update request, in the
future.

"geckoview" is not listed yet, because blocklist v3 is not yet enabled
on mobile (bug 1639050). Once enabled, "geckoview" should be added to
every scalar from this commit.

Differential Revision: https://phabricator.services.mozilla.com/D76539
2020-05-25 14:22:29 +00:00
Rob Wu 41cc31b26c Bug 1633466 - Move common test logic to test/xpcshell/rs-blocklist/head.js r=Gijs
And introduce a helper to get the ExtensionBlocklistMBLF global without
using a deprecated API, and remove the exception from eslintrc

Differential Revision: https://phabricator.services.mozilla.com/D76712
2020-05-25 17:16:53 +00:00
Emma Malysz dd847672be Bug 1636994, ensure panel is created before showing addon install notification r=Gijs,robwu
Differential Revision: https://phabricator.services.mozilla.com/D76166
2020-05-22 17:00:44 +00:00
Ricky Stewart e2fe57521b Bug 1638060 - Standardize interface of `mozfile` classes as `bytes`-based streams r=glandium
At the beginning of the Python 3 migration (circa bug 1602540), we made an update to the interface of `mozpack/files.py` in the direction of aligning with Python 3's built-in `file` support; namely, that opening a file in text mode returns a stream of `str` (text), and that opening a file in binary mode returns a stream of `bytes`. This was deemed to be more trouble than it was worth. This patch undoes all of those changes to the interface in favor of moving back to the Python 2 style, where all files are bytestreams.

Differential Revision: https://phabricator.services.mozilla.com/D75424
2020-05-22 01:11:29 +00:00
Rob Wu 27981af497 Bug 1636158 - Update the addons-mlbf.bin attachment via periodic_file_updates.sh r=sfraser
Tested by running the following code and verifying that the script runs
successfully and generates a reasonable diff with the latest metadata
and matching attachment content:

```
$ cd taskcluster/docker/periodic-updates/
$ tar -czf- -s "#$(git rev-parse --show-cdup)#topsrcdir/#" . $(awk -v d="$(git rev-parse --show-cdup)" '/^# %include/{print d$3}' Dockerfile) | docker build - -t hsts-local
$ docker run -e DO_REMOTE_SETTINGS=1 -e PRODUCT="firefox" -e BRANCH="mozilla-central" -e USE_MOZILLA_CENTRAL=1 hsts-local
```

After that, I opened a shell in the container, built Firefox and ran the
following test, to confirm that the updated records are used correctly:

```
mach test toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_mlbf_dump.js
```

Differential Revision: https://phabricator.services.mozilla.com/D76158
2020-05-22 01:37:37 +00:00
Rob Wu ac650df53f Bug 1636158 - Remove addons-bloomfilters from Android package r=agi,geckoview-reviewers,snorp
Those will be restored in bug 1639050

Differential Revision: https://phabricator.services.mozilla.com/D76157
2020-05-20 16:39:05 +00:00
Jared Wein f96350059a Bug 1610081 - Show a border between the sidebar and the content area in about:addons and about:preferences when prefers-reduced-motion is enabled to help users with visual tearing migraines. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D75319
2020-05-20 16:10:07 +00:00
Sid Stamm ca0081c5a3 Bug 1002724 - use resolvable URL in extension html_detail_view test. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D75088
2020-05-21 17:43:15 +00:00
Kirk Steuber 7355553aea Bug 1639669 - Adjust WDBA ping to make it easier to see when things have not changed r=mhowell
Currently, the default browser agent pings always look like current_browser=CURRENT,previous_browser=PREVIOUS if the default browser has ever been changed since the agent started checking. We want to change it so that that is the format only if the default browser just changed between the last two checks. After that, the pings should look like current_browser=CURRENT,previous_browser=CURRENT. This allows us to better see when the default changes.

Differential Revision: https://phabricator.services.mozilla.com/D76252
2020-05-21 17:02:02 +00:00
Rob Wu 7a02048e02 Bug 1634756 - Ensure that installDate is never null, and let updateDate fall back to installDate r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D73497
2020-05-19 00:21:49 +00:00
Frederik Braun de3412e689 Bug 1613609 - Add required loadinfo flag requests initiated with SystemPrincipal r=necko-reviewers,dragana
Adding the flag to existing channel/loadinfo object for:
- PushServices HTTP, WebSocket
- NetworkGeolocationProvider
- NetUtil.jsm's NewChannel
- NetworkConnectivityService
- OCSP
- Portal Detection
- ProductAddonChecker.jsm
- URLClassifier

Differential Revision: https://phabricator.services.mozilla.com/D75063
2020-05-19 08:54:58 +00:00
Noemi Erli c1cca03e21 Backed out 6 changesets (bug 1002724) for failing in browser_fall_back_to_https.js CLOSED TREE
Backed out changeset e487b4cd9223 (bug 1002724)
Backed out changeset 37473a8ba1fd (bug 1002724)
Backed out changeset e868f1e0af0e (bug 1002724)
Backed out changeset 1c57f8717b15 (bug 1002724)
Backed out changeset 782808a05ff8 (bug 1002724)
Backed out changeset c60c48d170e1 (bug 1002724)
2020-05-18 19:22:19 +03:00
Sid Stamm 0fb7124e1a Bug 1002724 - use resolvable URL in extension html_detail_view test. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D75088
2020-05-18 15:09:01 +00:00
Mihai Alexandru Michis a2026344a1 Backed out 2 changesets (bug 1613609) for causing bustages.
CLOSED TREE

Backed out changeset dd6e395dc342 (bug 1613609)
Backed out changeset 5bcb7b13a4ad (bug 1613609)
2020-05-18 16:38:58 +03:00
Csoregi Natalia 179b0c82b2 Backed out 6 changesets (bug 1002724) for bustage on nsDocShell.cpp. CLOSED TREE
Backed out changeset 56ba616e2644 (bug 1002724)
Backed out changeset d481cf074d3b (bug 1002724)
Backed out changeset da26540ecee5 (bug 1002724)
Backed out changeset 01cbf611158a (bug 1002724)
Backed out changeset b60ba645f1f4 (bug 1002724)
Backed out changeset 4ebad0d2ca0a (bug 1002724)
2020-05-18 16:06:55 +03:00
Sid Stamm aa2df3c53f Bug 1002724 - use resolvable URL in extension html_detail_view test. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D75088
2020-05-18 12:42:21 +00:00
Frederik Braun 3baff21cbd Bug 1613609 - Add required loadinfo flag requests initiated with SystemPrincipal r=necko-reviewers,dragana
Adding the flag to existing channel/loadinfo object for:
- PushServices HTTP, WebSocket
- NetworkGeolocationProvider
- NetUtil.jsm's NewChannel
- NetworkConnectivityService
- OCSP
- Portal Detection
- ProductAddonChecker.jsm
- URLClassifier

Differential Revision: https://phabricator.services.mozilla.com/D75063
2020-05-18 10:59:04 +00:00
Csoregi Natalia 5162f86676 Backed out 2 changesets (bug 1613609) for failures on nsXPConnect.cpp. CLOSED TREE
Backed out changeset c593a7296df4 (bug 1613609)
Backed out changeset 72199fc4ea2b (bug 1613609)
2020-05-18 13:05:12 +03:00
Frederik Braun 3b0d63cd07 Bug 1613609 - Add required loadinfo flag requests initiated with SystemPrincipal r=necko-reviewers,dragana
Adding the flag to existing channel/loadinfo object for:
- PushServices HTTP, WebSocket
- NetworkGeolocationProvider
- NetUtil.jsm's NewChannel
- NetworkConnectivityService
- OCSP
- Portal Detection
- ProductAddonChecker.jsm
- URLClassifier

Differential Revision: https://phabricator.services.mozilla.com/D75063
2020-05-18 09:19:17 +00:00
Gijs Kruitbosch 72186b2199 Bug 1638092 - do not require a browsingcontext to call the external protocol service's loadURI method, r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D75543
2020-05-17 22:54:30 +00:00
Jared Wein 6eb4c9a1b0 Bug 773942 - Add telemetry to track which PDF viewer was used from the Unknown Content Type dialog. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D73538
2020-05-16 06:00:06 +00:00
Jared Wein 9b0a889740 Bug 773942 - Hide the 'Open with Firefox' option if the download is started from the download button in pdf.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72779
2020-05-16 05:59:55 +00:00
Jared Wein 3074d7ebb9 Bug 773942 - Open PDFs using pdf.js in a new tab when the Preview option is selected from the Unknown Content Type dialog. r=Gijs
This is currently preffed off behind the "browser.helperApps.showOpenOptionForPdfJS" pref.

Differential Revision: https://phabricator.services.mozilla.com/D72776
2020-05-16 05:59:43 +00:00
Jared Wein fdcaf6c44a Bug 773942 - Add a radio button to open the PDF in Firefox. r=Gijs,flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D72774
2020-05-16 05:59:40 +00:00
Jared Wein cb8b72b2ab Bug 773942 - Remove some dead code and an old hack that isn't necessary anymore. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72773
2020-05-16 05:59:33 +00:00
Narcis Beleuzu 35b6e759f7 Backed out 9 changesets (bug 773942) for xpcshell failure on test_getMIMEInfo_pdf.js
Backed out changeset 6fb0f25b2f5d (bug 773942)
Backed out changeset 27e9fe03a549 (bug 773942)
Backed out changeset ee0ecad5e90a (bug 773942)
Backed out changeset df062e14287b (bug 773942)
Backed out changeset 7da06239ccfb (bug 773942)
Backed out changeset dfedbeeaec66 (bug 773942)
Backed out changeset 286e1be9dc46 (bug 773942)
Backed out changeset f4df0a553bc0 (bug 773942)
Backed out changeset 97f3b96b6be0 (bug 773942)
2020-05-16 08:37:53 +03:00
Jared Wein 6a71aa8029 Bug 773942 - Add telemetry to track which PDF viewer was used from the Unknown Content Type dialog. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D73538
2020-05-16 04:25:25 +00:00
Jared Wein b804d9a64f Bug 773942 - Hide the 'Open with Firefox' option if the download is started from the download button in pdf.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72779
2020-05-16 04:25:06 +00:00
Jared Wein 3ace9de33d Bug 773942 - Open PDFs using pdf.js in a new tab when the Preview option is selected from the Unknown Content Type dialog. r=Gijs
This is currently preffed off behind the "browser.helperApps.showOpenOptionForPdfJS" pref.

Differential Revision: https://phabricator.services.mozilla.com/D72776
2020-05-16 04:24:56 +00:00
Jared Wein 7030982f6a Bug 773942 - Add a radio button to open the PDF in Firefox. r=Gijs,flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D72774
2020-05-16 04:24:53 +00:00
Jared Wein 0627bbd6af Bug 773942 - Remove some dead code and an old hack that isn't necessary anymore. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72773
2020-05-16 04:24:49 +00:00
Shane Caraveo 56e61eda29 Bug 1575948 add new system-extensions location for Normandy r=aswan
Add a new extension location in the user profile that Normandy will use to install mozilla signed addons.  These are used to update builtin addons, experiments, etc. as well as take over functionality currently supported by Balrog.

Differential Revision: https://phabricator.services.mozilla.com/D70636
2020-05-15 23:10:33 +00:00
Csoregi Natalia efa2a05b53 Backed out changeset c867966e6eb8 (bug 1575948) for failures on browser_startup_mainthreadio.js. CLOSED TREE 2020-05-16 01:04:02 +03:00
Shane Caraveo c937736b00 Bug 1575948 add new system-extensions location for Normandy r=aswan
Add a new extension location in the user profile that Normandy will use to install mozilla signed addons.  These are used to update builtin addons, experiments, etc. as well as take over functionality currently supported by Balrog.

Differential Revision: https://phabricator.services.mozilla.com/D70636
2020-05-15 19:16:49 +00:00
Mark Smith 8b168c1d94 Bug 1395207 - downloads.download() should remember the last directory used. r=robwu
When the saveAs option is true, instead of always starting in the
default download directory, remember and reuse the last directory
that the user chose. Unless browser.download.lastDir.savePerSite is
set to false, the last download directory is saved on a per-extension
basis.

Differential Revision: https://phabricator.services.mozilla.com/D67060
2020-05-15 15:19:43 +00:00
Dave Townsend e5989d6961 Bug 1634719: Drop the broken extraProps argument to newAppInfo. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D73469
2020-05-14 20:34:28 +00:00
Coroiu Cristina 702c6f9694 Backed out changeset 1a271e4d8937 (bug 1610081) for assertion failures at layout/base/nsCSSFrameConstructor.cpp on a CLOSED TREE 2020-05-14 23:52:47 +03:00
Jared Wein 54398caee4 Bug 1610081 - Show a border between the sidebar and the content area in about:addons and about:preferences when prefers-reduced-motion is enabled to help users with visual tearing migraines. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D75319
2020-05-14 18:18:52 +00:00
Dorel Luca 70a532f545 Backed out changeset d53a34d54588 (bug 1610081) for Browser-chrome in test/browser/browser_sidebar_categories.js. CLOSED TREE 2020-05-14 20:53:57 +03:00
Jared Wein eda16a9a95 Bug 1610081 - Show a border between the sidebar and the content area in about:addons and about:preferences when prefers-reduced-motion is enabled to help users with visual tearing migraines. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D75319
2020-05-14 16:11:44 +00:00
Gijs Kruitbosch 228e52aebe Bug 1196151 - use BrowsingContext for external helper app handling of protocols, r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D74434
2020-05-11 13:13:03 +00:00
Andrew Swan c01f8d4891 Bug 1633396 Skip blocklist checks for system/builtin addons r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D74533
2020-05-12 01:58:03 +00:00
Agi Sferro 0536b15a7d Bug 1629952 - Remove legacy addon install.cancel() support. r=aswan,mixedpuppy
This patch removes some old code for non-restartless addons. When the code was
written, it was still possible to call `cancel()` on an addon after the addon
was installed and before it had persisted in the database.

This case is not possible anymore, and calling `cancel()` on a
`STATE_INSTALLED` install object doesn't actually do much (but makes the
calling code think it actually canceled successfully, since it doesn't throw).

After this patch, calling `cancel()` on a `STATE_INSTALLED` install will throw
an exception.

There is one spot where we still keep around the install object because we
don't call `_cleanup()`, i.e. when installing an already present disabled
addon. For this case, we can just call `_cleanup()` at the end of the
enablement process.

There are quite a few tests that exploit calling `cancel()` to mean
`uninstall()`, for those actually calling `uninstall()` works fine.

This fixes a GeckoView bug where calling `cancel()` doesn't throw (so GV thinks
the cancellation went through successfully) but then we receive an addon object
from the successfull installation.

Differential Revision: https://phabricator.services.mozilla.com/D74305
2020-05-11 23:27:04 +00:00
Andrew Swan b7637e5ef6 Bug 1571876 Test updates of builtin extensions r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D74654
2020-05-11 17:02:59 +00:00
Cosmin Sabou 0749be7712 Backed out changeset 527ed2d24327 (bug 1575948) for browser chrome failures on browser_startup_mainthreadio.js. CLOSED TREE 2020-05-11 20:05:18 +03:00
Shane Caraveo 5502746963 Bug 1575948 add new app-addons location in AddonManager r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D70636
2020-05-11 14:08:51 +00:00
Simon Giesecke bc5cc237af Bug 1626570 - Improve handling of copying arrays in toolkit/mozapps/. r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D73818
2020-05-11 08:22:25 +00:00
Luca Greco 1d21ffa905 Bug 1614653 - Remove abuse-report-frame.js and move openAbuseReport into extensions.js. r=mstriemer
Depends on D71616

Differential Revision: https://phabricator.services.mozilla.com/D74420
2020-05-08 16:08:47 +00:00
Luca Greco 927e8e1f94 Bug 1614653 - Move into browser_html_abuse_report.js all test tasks previously shared by multiple test files. r=mstriemer
Depends on D71615

Differential Revision: https://phabricator.services.mozilla.com/D71616
2020-05-08 16:04:12 +00:00
Luca Greco e7a2904b65 Bug 1614653 - Remove the extensions.abuseReports.openDialog pref and the related implementation and XUL elements from about:addons. r=mstriemer,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D71615
2020-05-08 16:03:45 +00:00
Gijs Kruitbosch ad6d0f5943 Bug 1633790 - remove unused method arguments in the external helper app service, r=jaws
This also renames `saveToDisk` to the more accurate `promptForSaveDestination`
given that it doesn't actually do the saving itself.

Differential Revision: https://phabricator.services.mozilla.com/D73507
2020-05-06 20:32:09 +00:00
Ricky Stewart 56c10c5aa2 Bug 1633037 - Remove all remaining references to $(PYTHON) across Makefiles r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D72894
2020-05-05 20:32:23 +00:00
Ricky Stewart 4d4b22b3de Bug 1599658 - Delete previous definition of py_action in Makefiles. Now py_action calls into Python 3 and py3_action doesn't exist. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D72487
2020-05-05 20:04:30 +00:00
Ricky Stewart fd72a5d35e Bug 1633016 - Remove a bunch of references to PYTHON(2) in Makefiles r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D72479
2020-05-05 19:53:22 +00:00
Agi Sferro 6122ab6818 Bug 1601067 - Implement installBuiltIn. r=mixedpuppy,owlish,snorp
Differential Revision: https://phabricator.services.mozilla.com/D72978
2020-05-05 23:02:56 +00:00
Mihai Alexandru Michis d8308aa13f Backed out 9 changesets (bug 1601067) for causing gv failures in WebExecutorTest.
CLOSED TREE

Backed out changeset a57940d6af63 (bug 1601067)
Backed out changeset d16aa7b33165 (bug 1601067)
Backed out changeset f5d8f660ba87 (bug 1601067)
Backed out changeset 3b4e20521d4b (bug 1601067)
Backed out changeset b396fa314c25 (bug 1601067)
Backed out changeset 62f5d5d34162 (bug 1601067)
Backed out changeset fe94f4277bfa (bug 1601067)
Backed out changeset b15906852fe4 (bug 1601067)
Backed out changeset 23d021ef34c4 (bug 1601067)
2020-05-06 01:58:11 +03:00
Agi Sferro 859bdae8a8 Bug 1601067 - Implement installBuiltIn. r=mixedpuppy,owlish,snorp
Differential Revision: https://phabricator.services.mozilla.com/D72978
2020-05-05 22:19:26 +00:00
Ian Moody 011b59d595 Bug 1536556 - Replace raw thrown Cr.ERRORs with Components.Exception. r=mossop,remote-protocol-reviewers,marionette-reviewers,whimboo,necko-reviewers,geckoview-reviewers,valentin,agi
Raw Cr.ERROR don't get stack information, same as throwing JS literals instead
of `new Error()`s.

This was done automatically with a new eslint rule that will be introduced in
the next commit.  One instance of a raw Cr.ERROR was not replaced since it is
used in a test that specifically checks the preservation of raw Cr values in
XPCJS.  The rule will be disabled for that instance.

Differential Revision: https://phabricator.services.mozilla.com/D28073
2020-05-05 17:41:36 +00:00
Stephen A Pohl ee3fa26401 Bug 1616404: Change macOS version detection to accommodate major versions between 10 and 255 as well as minor and bugfix versions between 0 and 255. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D73180
2020-05-04 21:11:09 +00:00
Bogdan Tara f137fa0613 Backed out 6 changesets (bug 1632916, bug 1599658, bug 1633037, bug 1633039, bug 1633016, bug 1632920) for SA bustages CLOSED TREE
Backed out changeset 332ce0963b4e (bug 1633039)
Backed out changeset a9904cbc40d9 (bug 1633037)
Backed out changeset d06b0ec349f8 (bug 1599658)
Backed out changeset 8fd300cad80f (bug 1633016)
Backed out changeset f8820941c703 (bug 1632916)
Backed out changeset ac9c2c8746ed (bug 1632920)
2020-05-02 01:49:29 +03:00
Rob Wu f7f88112a2 Bug 1634671 - Add RS dump of addons-bloomfilters blocklist to Android r=agi
These support the new implementation of the addon blocklist (bug 1620621),
which is a more space-efficient way to represent the blocklist.

A comparison of file size was given in D73159. In short, 913KB for the
old JSON-based blocklist (addons.json), 64KB for the new one.

In practice, addons.json is 273KB compressed.

The new blocklist (addons-mlbf.bin) does not compress that well since it
is already an efficiently packed binary format.

Differential Revision: https://phabricator.services.mozilla.com/D73438
2020-05-01 19:36:43 +00:00
Rob Wu eb8be1efed Bug 1634700 - Always use latest generation_time in MLBF blocklist updates r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D73464
2020-05-01 17:58:20 +00:00
Rob Wu aa423d1002 Bug 1634700 - Treat signedDate as a Date instead of a number in the blocklist r=Gijs
Emphasize that `signedDate` is a `Date` instance instead of a number,
because this is the actual type of the addon wrappers exposed by the
AddonManager.

And replace check for signedState with signedDate, because the latter
captures my intent (the original implementation checked signedState
because signedDate used to unconditionally return a `Date` instance,
even for invalid dates, but that was changed in bug 1583844).

Differential Revision: https://phabricator.services.mozilla.com/D73463
2020-05-01 17:58:17 +00:00
Ricky Stewart 69685d8ab5 Bug 1633037 - Remove all remaining references to $(PYTHON) across Makefiles r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D72894
2020-05-01 16:19:21 +00:00
Ricky Stewart 0daacc12c3 Bug 1599658 - Delete previous definition of py_action in Makefiles. Now py_action calls into Python 3 and py3_action doesn't exist. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D72487
2020-04-30 15:27:13 +00:00
Ricky Stewart bb4e86d85a Bug 1633016 - Remove a bunch of references to PYTHON(2) in Makefiles r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D72479
2020-04-30 15:25:22 +00:00
Shane Caraveo 0b1ab06c29 Bug 557710 fix precedence handling with addons installed to multiple locations r=rhelmer,aswan
This fixes and verifies precedence handling where system and builtin addons are updated in higher or lower precedence addon locations than other existing addons.

Differential Revision: https://phabricator.services.mozilla.com/D70060
2020-04-30 23:26:05 +00:00
Rob Wu 6c21ed0e5d Bug 1620621 - Add initial dump of addons blocklist r=Gijs
The MLBF (addons-mlbf.bin) itself is 64 KB.
Together with the metadata, this is 65 KB.
In contrast, the current JSON-based dump (addons.json) is 913 KB.

Differential Revision: https://phabricator.services.mozilla.com/D73159
2020-04-30 10:02:41 +00:00
Rob Wu 3ba1eb1532 Bug 1620621 - Implement blocklist stashing behind pref r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72890
2020-04-30 10:02:39 +00:00
Rob Wu 07cadc8026 Bug 1620621 - Unit tests for MLBF-based blocklist r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72631
2020-04-30 10:02:37 +00:00
Rob Wu 1d728dfd87 Bug 1620621 - Add bloomfilter-based blocklist for addons r=Gijs,aswan
NOTE: This commit does not yet include a dump of the RemoteSettings
collection and attachment. This will be added in the near future.

Differential Revision: https://phabricator.services.mozilla.com/D72418
2020-04-30 10:02:32 +00:00
Razvan Maries c92da124b3 Backed out 8 changesets (bug 1620621) for build bustages. CLOSED TREE
Backed out changeset 14a57e32c414 (bug 1620621)
Backed out changeset 56b2b19a9bc1 (bug 1620621)
Backed out changeset 6df42b7528ec (bug 1620621)
Backed out changeset c23703684254 (bug 1620621)
Backed out changeset 206ad824e1bc (bug 1620621)
Backed out changeset e0f3e057b311 (bug 1620621)
Backed out changeset 12817823a3c9 (bug 1620621)
Backed out changeset 80dcb089ce8e (bug 1620621)
2020-04-30 12:29:30 +03:00
Rob Wu 6986e261ef Bug 1620621 - Add initial dump of addons blocklist r=Gijs
The MLBF (addons-mlbf.bin) itself is 64 KB.
Together with the metadata, this is 65 KB.
In contrast, the current JSON-based dump (addons.json) is 913 KB.

Differential Revision: https://phabricator.services.mozilla.com/D73159
2020-04-30 02:48:46 +00:00
Rob Wu 978c90cbf6 Bug 1620621 - Implement blocklist stashing behind pref r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72890
2020-04-30 02:48:30 +00:00
Rob Wu 34e22a3202 Bug 1620621 - Unit tests for MLBF-based blocklist r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72631
2020-04-30 08:28:11 +00:00
Rob Wu 5047bb6dea Bug 1620621 - Add bloomfilter-based blocklist for addons r=Gijs,aswan
NOTE: This commit does not yet include a dump of the RemoteSettings
collection and attachment. This will be added in the near future.

Differential Revision: https://phabricator.services.mozilla.com/D72418
2020-04-30 02:48:35 +00:00
Dorel Luca 58186c88dc Backed out 8 changesets (bug 1620621) for XPCshell failures in xpcshell/rs-blocklist/test_blocklist_mlbf_fetch.js
Backed out changeset 06fccc75c09e (bug 1620621)
Backed out changeset 8b4e286967c0 (bug 1620621)
Backed out changeset cfde27a748fd (bug 1620621)
Backed out changeset 7abf836343be (bug 1620621)
Backed out changeset 1a28d1de8f76 (bug 1620621)
Backed out changeset 90c08438be0a (bug 1620621)
Backed out changeset 723a3b4e7bbf (bug 1620621)
Backed out changeset bbc991f09d5d (bug 1620621)
2020-04-30 05:44:28 +03:00
Rob Wu 8962b5b5c1 Bug 1620621 - Add initial dump of addons blocklist r=Gijs
The MLBF (addons-mlbf.bin) itself is 64 KB.
Together with the metadata, this is 65 KB.
In contrast, the current JSON-based dump (addons.json) is 913 KB.

Differential Revision: https://phabricator.services.mozilla.com/D73159
2020-04-30 00:34:54 +00:00
Rob Wu 986f0753c6 Bug 1620621 - Implement blocklist stashing behind pref r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72890
2020-04-30 00:33:39 +00:00
Rob Wu c264c29f1e Bug 1620621 - Unit tests for MLBF-based blocklist r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72631
2020-04-29 23:08:18 +00:00
Rob Wu 03ec908820 Bug 1620621 - Add bloomfilter-based blocklist for addons r=Gijs,aswan
NOTE: This commit does not yet include a dump of the RemoteSettings
collection and attachment. This will be added in the near future.

Differential Revision: https://phabricator.services.mozilla.com/D72418
2020-04-29 23:08:15 +00:00
Neil Deakin f22197fbf1 Bug 1614747, convert about:plugins to JSWindowActor-based remote page manager, r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D71025
2020-04-30 00:14:56 +00:00
Shane Caraveo a1af8a6df8 Bug 1628239 fix extension permission migration for permissionless extensions r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D72221
2020-04-29 19:45:42 +00:00
jayati 5e5f758c61 Bug 1496062 - Remove add-on type specific search labels. r=mstriemer,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D72390
2020-04-28 21:00:44 +00:00
Kirk Steuber 01623391ec Bug 1627805 - Allow the update agent to link against updatecommon r=glandium
Linking Rust code against the updatecommon library is not well supported by our build system, but it should be possible. The changes to updatecommon's moz.build will cause updatecommon.lib to be created, which Rust can link against. The build.rs script tells cargo which shared Windows libraries are needed for linking, and where updatecommon.lib can be found. The change to config/recurse.mk enforces the dependency of the update agent on updatecommon, so that we do not attempt to link the agent before updatecommon has been built.

Differential Revision: https://phabricator.services.mozilla.com/D70207
2020-04-24 19:23:08 +00:00
Kirk Steuber dd28e487d6 Bug 1627805 - Obtain path for the download XML r=agashlin
Differential Revision: https://phabricator.services.mozilla.com/D69875
2020-04-28 20:50:51 +00:00
Shane Caraveo 3ac9a746ee Bug 1630694 fix maintaining enabled state of themes on app update r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D72885
2020-04-28 15:01:14 +00:00
Jean-Yves Avenard 071771cdc7 Bug 1633319 - Wait for load before resolving promise. r=Gijs,zombie
Differential Revision: https://phabricator.services.mozilla.com/D72593
2020-04-27 22:42:25 +00:00
jayati 0881978969 Bug 1620438 - Remove references to extensions.webservice.discoverURL. r=robwu,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,whimboo,sparky
Differential Revision: https://phabricator.services.mozilla.com/D71203
2020-04-27 14:36:04 +00:00
Adam Gashlin d7e841caa2 Bug 1316136 - Support post-signing/attribution data in full installer. r=mhowell
This reuses some logic from the stub installer, moved into common.nsh.

Differential Revision: https://phabricator.services.mozilla.com/D72078
2020-04-23 21:16:20 +00:00
Matt Woodrow da1d258df5 Bug 1602318 - Make xpihandler tests wait for load before starting the test. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D70623
2020-04-26 00:51:48 +00:00
Matt Woodrow 7cd45734ca Bug 1602318 - Make download tests wait for the STOP progress event instead of load. r=kmag
When we initiate URL bar loads from the parent, loads that are handled externally won't fire a load event from the content process docshell, so we should use the progress listener instead.

Differential Revision: https://phabricator.services.mozilla.com/D67100
2020-04-26 00:50:14 +00:00
Stephen A Pohl 4be18f0f0e Bug 1578917: Force macOS Aqua appearance on for content processes, crash reporter and updater. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D70783
2020-04-24 18:37:57 +00:00
Molly Howell 1136bd5c62 Bug 1632659 - Don't send the default browser ping in non-official builds. r=bytesized
Differential Revision: https://phabricator.services.mozilla.com/D72246
2020-04-24 17:39:36 +00:00
Cosmin Sabou 0f970fbb19 Backed out 20 changesets (bug 1602318) for causing multiple types of failures. CLOSED TREE
Backed out changeset f71e3eff7a8c (bug 1602318)
Backed out changeset 0e0bdebf223b (bug 1602318)
Backed out changeset 44e82f4339a1 (bug 1602318)
Backed out changeset 5f341ebd8591 (bug 1602318)
Backed out changeset 088ea9d20617 (bug 1602318)
Backed out changeset 5de6321939f2 (bug 1602318)
Backed out changeset f5742e84912b (bug 1602318)
Backed out changeset 13bec3079540 (bug 1602318)
Backed out changeset 6c24ba022911 (bug 1602318)
Backed out changeset 5d0fc0102a7f (bug 1602318)
Backed out changeset fc4efd11e643 (bug 1602318)
Backed out changeset 028bd63e710d (bug 1602318)
Backed out changeset 21ad350f9617 (bug 1602318)
Backed out changeset 8f27319f2c34 (bug 1602318)
Backed out changeset db2832973382 (bug 1602318)
Backed out changeset 1756c7584491 (bug 1602318)
Backed out changeset 983e5a9abe02 (bug 1602318)
Backed out changeset a1b9429b3298 (bug 1602318)
Backed out changeset 7d1c0d968a09 (bug 1602318)
Backed out changeset a3b056ec6be3 (bug 1602318)
2020-04-24 11:15:12 +03:00
Matt Woodrow f9c3d901f9 Bug 1602318 - Make xpihandler tests wait for load before starting the test. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D70623
2020-04-24 06:58:08 +00:00
Matt Woodrow 9bd5b11714 Bug 1602318 - Make download tests wait for the STOP progress event instead of load. r=kmag
When we initiate URL bar loads from the parent, loads that are handled externally won't fire a load event from the content process docshell, so we should use the progress listener instead.

Differential Revision: https://phabricator.services.mozilla.com/D67100
2020-04-24 06:56:39 +00:00
Tomislav Jovanovic 50139dfc2e Bug 1624235 - Simplify handling of persistent listeners for runtime messaging r=robwu
Persistent listeners for onMessage and onConnect are special because they
don't have parent EventManagers, so we have a lot of custom code just to keep
track of which extensions have registered them during previous runs.

In this patch, I simplify all that logic to always assume that any extension
which sends messages from content scripts has those listeners setup properly.

The only observable difference is that some poorly written extensions which
were previously broken by delayed startup will now "work" by being started
earlier if a message from a content script arrives during browser startup.

Additionally, unconfuse two different meanings of the "startup" event.
Bonus, avoid some logspam during tests.

Differential Revision: https://phabricator.services.mozilla.com/D70955
2020-04-22 20:03:28 +00:00
Noemi Erli c0bd1834c8 Backed out 19 changesets (bug 1602318) for causing multiple failures
Backed out changeset 4b3345b2e33b (bug 1602318)
Backed out changeset 7240b27afe28 (bug 1602318)
Backed out changeset a7091729d8c9 (bug 1602318)
Backed out changeset e496ab6c0857 (bug 1602318)
Backed out changeset 184da6309f0c (bug 1602318)
Backed out changeset 79b540f8619d (bug 1602318)
Backed out changeset b298015ee960 (bug 1602318)
Backed out changeset 6d0783cd5e01 (bug 1602318)
Backed out changeset cbc308486b17 (bug 1602318)
Backed out changeset 94142944fb54 (bug 1602318)
Backed out changeset 7c1eeb299b78 (bug 1602318)
Backed out changeset 0fc27502503a (bug 1602318)
Backed out changeset 0fc27c2e09d9 (bug 1602318)
Backed out changeset b5e2aa4741b2 (bug 1602318)
Backed out changeset 57d568114c5a (bug 1602318)
Backed out changeset 8f7360d827dc (bug 1602318)
Backed out changeset 78930a97c2df (bug 1602318)
Backed out changeset 8015780587cd (bug 1602318)
Backed out changeset bc9da03cb3a3 (bug 1602318)
2020-04-21 03:46:41 +03:00
Matt Woodrow e142c31312 Bug 1602318 - Make xpihandler tests wait for load before starting the test. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D70623
2020-04-20 23:01:22 +00:00
Matt Woodrow 12b5342377 Bug 1602318 - Make download tests wait for the STOP progress event instead of load. r=kmag
When we initiate URL bar loads from the parent, loads that are handled externally won't fire a load event from the content process docshell, so we should use the progress listener instead.

Differential Revision: https://phabricator.services.mozilla.com/D67100
2020-04-20 22:59:55 +00:00
Stephen A Pohl 2cd9e294ac Bug 1574139: Fix an issue that prevented updates from completing if usernames contained a dot at the end of the username and general hardening of our file path verification. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D71607
2020-04-20 20:18:37 +00:00
Molly Howell 8975fd16ef Bug 1596812 Part 6 - Replace the stub installer UI code with calls to the web plugin. r=agashlin
Depends on D56581

Differential Revision: https://phabricator.services.mozilla.com/D56582
2020-04-20 03:06:08 +00:00
Molly Howell ac9a11a37a Bug 1596812 Part 4 - Add the WebBrowser plugin to the installer build files. r=agashlin,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D56580
2020-04-20 03:06:07 +00:00
Sebastian Streich 09ee22a251 Bug 1621315 - Refactor Geturi Usage in AddonContentPolicy.cpp r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D66595
2020-04-20 15:57:51 +00:00
Bingjing Yan 907c0653c5 Bug 1523736 - migrate updates.dtd to fluent r=fluent-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69490
2020-04-20 10:41:41 +00:00
Stefan Hindli 996d12f63a Backed out changeset 08427d711342 (bug 1621315) for causing mass build bustages CLOSED TREE 2020-04-20 13:33:09 +03:00
Sebastian Streich 229ba8c0de Bug 1621315 - Refactor Geturi Usage in AddonContentPolicy.cpp r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D66595
2020-04-20 09:53:38 +00:00
Daniel Varga 60946bafd9 Backed out changeset afe014a1b475 (bug 1523736) for causing build bustages
CLOSED TREE
2020-04-17 19:12:57 +03:00
Bingjing Yan 592cd1dc88 Bug 1523736 - migrate updates.dtd to fluent r=fluent-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69490
2020-04-17 15:51:22 +00:00
William Durand 90dd607279 Bug 1613796 - Make the permission popup queue browser-specific. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D70445
2020-04-16 19:38:17 +00:00
Tim Nguyen 55d9542872 Bug 1630615 - Remove duplicate settings icons. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D71185
2020-04-16 18:48:33 +00:00
jayati 076967aa38 Bug 1571412 - Update addon manager browser tests to use pushPrefEnv where appropriate. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D70404
2020-04-16 17:38:14 +00:00
Andreea Pavel 3cd455d5ca Backed out changeset 7749765974c1 (bug 1630615) for failing browser_primaryUI.js on a CLOSED TREE 2020-04-16 20:12:17 +03:00
Tim Nguyen 8bc7539203 Bug 1630615 - Combine toolkit/themes/shared/extensions/utilities.svg and browser/themes/shared/icons/settings.svg. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D71185
2020-04-16 14:30:20 +00:00
Luca Greco 6890a753ef Bug 1544890 - Disable addon-abuse-report-xulframe if AbuseReporter.openDialogDisabled is false. r=mstriemer
This patch prevents the addon-abuse-report-xulframe custom element from being defined
when AbuseReporter.openDialogDisabled is false (which is the default on all channels
starting from Firefox >= 73).

This change is also preventing the addon-abuse-report-xulframe custom element from
triggering an assertion failure in PresShell::ScrollContentIntoView, which seems to
be due to marionette calling browser.focus() while the custom element has just
injected the browser element that would contain the abuse report panel subframe.

This single-line patch is enough to prevent the assertion failure and still pass
all the existing tests. The addon-abuse-report-xulframe will be removed completely
as part of Bug 1614653.

Depends on D68805

Differential Revision: https://phabricator.services.mozilla.com/D71005

--HG--
extra : moz-landing-system : lando
2020-04-15 14:54:45 +00:00
Luca Greco 072f879ac7 Bug 1544890 - Fix missing extension icon and permission prompt when installing an updated xpi found by backgroundUpdateCheck. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D68805

--HG--
extra : moz-landing-system : lando
2020-04-15 09:20:46 +00:00
William Durand ad19156ae2 Bug 1594392 - Disable back button when there is no history in about:addons. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D70676

--HG--
extra : moz-landing-system : lando
2020-04-15 14:50:21 +00:00
ajitesh 2826a2e73c Bug 1583844 - "Last updated" field on Mozilla themes shows invalid date r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D61057

--HG--
extra : moz-landing-system : lando
2020-04-14 13:04:32 +00:00
Mark Striemer c34d93b70f Bug 1626381 - Include a title on about:addons categories r=rpl,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D69571

--HG--
extra : moz-landing-system : lando
2020-04-10 06:03:35 +00:00
Shane Caraveo 66f0591df1 Bug 1628883 reduce logging noise from addonmanager r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D70446

--HG--
extra : moz-landing-system : lando
2020-04-10 18:48:35 +00:00
Mike Hommey ac5b6e6cd0 Bug 1628200 - Fix config/tests/test_mozbuild_reading.py. r=rstewart
Since the test goes through all moz.build files disregarding DIRS and
the conditions that may disable directories, in some cases, moz.builds
can fail to be evaluated properly because of missing variables in
config.status. This time (because it's not the first), it's
LLVM_DLLTOOL.

After fixing that, it turns out many of the files/directories pointed to
by Files() directives were removed or moved.

While here, make the test script python3-ready.

Differential Revision: https://phabricator.services.mozilla.com/D70157

--HG--
extra : moz-landing-system : lando
2020-04-09 00:24:29 +00:00
Narcis Beleuzu 83508f8631 Backed out changeset 798aaee84ad1 (bug 557710) for xpcshell failures on test_system_upgrades.js. CLOSED TREE 2020-04-09 05:30:45 +03:00
Shane Caraveo 73993b29c4 Bug 557710 test behavior with addons installed to multiple locations r=rhelmer
Differential Revision: https://phabricator.services.mozilla.com/D70060

--HG--
extra : moz-landing-system : lando
2020-04-08 23:48:39 +00:00
Emma Malysz 1932ea0454 Bug 1590573 - Followup: Revert changes on elements that don't use MozXULElement. CLOSED TREE
CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D70261

--HG--
extra : histedit_source : 02e207270852df2de6e07100aa7632c179a6e5dc
2020-04-08 21:38:56 +00:00
Emma Malysz a7282ce447 Bug 1590573, create a unified approach for caching fragments in our Custom Elements r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D58866

--HG--
extra : moz-landing-system : lando
2020-04-08 16:17:50 +00:00
William Durand b90b5b3778 Bug 1489430 - Add "Remove Extension" context menu item for pageAction. r=robwu,mstriemer,fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69831

--HG--
extra : moz-landing-system : lando
2020-04-08 14:18:53 +00:00
Razvan Maries 072b678c5a Backed out changeset 6b7c81561ecc (bug 1590573) for marionette perma failures on test_refresh_firefox.py. CLOSED TREE 2020-04-08 07:43:49 +03:00
Emma Malysz b657384896 Bug 1590573, create a unified approach for caching fragments in our Custom Elements r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D58866

--HG--
extra : moz-landing-system : lando
2020-04-07 23:56:45 +00:00
Mark Striemer 8a57973444 Bug 1623310 - Only open about:addons menus on primary mouse button r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D67708

--HG--
extra : moz-landing-system : lando
2020-04-07 18:58:10 +00:00
Mark Striemer 03def4e38c Bug 1532077 - Clarify browserAction message in shortcuts UI r=fluent-reviewers,rpl
Differential Revision: https://phabricator.services.mozilla.com/D69856

--HG--
extra : moz-landing-system : lando
2020-04-07 09:16:39 +00:00
Andrew Swan d99492aca4 Bug 1625181 Skip over unneeded work when installing system/builtin addons r=zombie
We don't put system addons on the blocklist so there's no need to compute
blocklist state for them.  The immediate motivation for this is to avoid
initializing the blocklist early in startup for the initial startup in a
new profile or after a browser upgrade when we're installing/udpating
system and builtin addons.

Differential Revision: https://phabricator.services.mozilla.com/D68443

--HG--
extra : moz-landing-system : lando
2020-04-07 13:31:29 +00:00
Molly Howell e35b796e72 Bug 1626020 followup - fix a default browser ping field name to match the schema. r=bytesized
Differential Revision: https://phabricator.services.mozilla.com/D69869

--HG--
extra : moz-landing-system : lando
2020-04-06 20:39:14 +00:00
sonakshi c2aaee8a41 Bug 1584797 - Remove unused aProxyService parameter from applyFilter method r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D69679

--HG--
extra : moz-landing-system : lando
2020-04-06 20:21:03 +00:00
Brian Grinstead 30b9da5519 Bug 1623992 - Automated rewrite from chrome://global/skin/ to chrome://global/skin/global.css in markup r=marionette-reviewers,perftest-reviewers,mossop,whimboo,sparky
This was generated with

```
cp .gitignore .rgignore
rg -l -g '*.{html,xhtml}' 'href="chrome://global/skin/"' | xargs sed -i "" 's/href\="chrome:\/\/global\/skin\/"/href\="chrome:\/\/global\/skin\/global.css"/g'
```

Differential Revision: https://phabricator.services.mozilla.com/D67687

--HG--
extra : moz-landing-system : lando
2020-04-03 22:23:23 +00:00
Emilio Cobos Álvarez 4b9fdf3d73 Bug 1627707 - Rename LoadInfo::LoadingPrincipal to GetLoadingPrincipal as it can return null. r=ckerschb
Mostly a matter of:

  rg -l '\->LoadingPrincipal' | xargs sed -i 's/->LoadingPrincipal/->GetLoadingPrincipal/g'

And then clang-format. But I tweaked manually nsHttpChannelAuthProvider (move
the variable where it's used, don't take a useless strong ref),
AddonContentPolicy (move the declaration of the variable to the if condition),
and BackgroundUtils (same).

Differential Revision: https://phabricator.services.mozilla.com/D69828

--HG--
extra : moz-landing-system : lando
2020-04-06 18:57:36 +00:00
Cosmin Sabou d557e2ed22 Backed out 3 changesets (bug 1627707) for build bustages @ mozilla::net::LoadInfo.
Backed out changeset 65d6a90651ce (bug 1627707)
Backed out changeset 378ec30d9979 (bug 1627707)
Backed out changeset 058a19e11b06 (bug 1627707)
2020-04-06 20:07:04 +03:00
Molly Howell cd0731f708 Bug 1626020 - Fix default browser agent telemetry URL. r=bytesized
Differential Revision: https://phabricator.services.mozilla.com/D69834

--HG--
extra : moz-landing-system : lando
2020-04-06 16:26:04 +00:00
Emilio Cobos Álvarez 97872f2fee Bug 1627707 - Rename LoadInfo::LoadingPrincipal to GetLoadingPrincipal as it can return null. r=ckerschb
Mostly a matter of:

  rg -l '\->LoadingPrincipal' | xargs sed -i 's/->LoadingPrincipal/->GetLoadingPrincipal/g'

And then clang-format. But I tweaked manually nsHttpChannelAuthProvider (move
the variable where it's used, don't take a useless strong ref),
AddonContentPolicy (move the declaration of the variable to the if condition),
and BackgroundUtils (same).

Differential Revision: https://phabricator.services.mozilla.com/D69828

--HG--
extra : moz-landing-system : lando
2020-04-06 16:00:43 +00:00
Itiel 8b6e89a718 Bug 1627036 - Convert all relevant uses of left/right to logical properties in the remaining files in toolkit/ r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69447

--HG--
extra : moz-landing-system : lando
2020-04-03 19:17:34 +00:00
Sylvestre Ledru 0aa6f03cf3 Bug 1519636 - Reformat recent changes to the Google coding style r=jgilbert
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D67574

--HG--
extra : moz-landing-system : lando
2020-04-05 13:34:58 +00:00
Cosmin Sabou a395d07103 Backed out changeset a62adf9c09cc (bug 1625181) for turning bug 1591590 into near permafail. 2020-04-04 15:13:48 +03:00
Andrew Swan a29862a4ec Bug 1625181 Skip over unneeded work when installing system/builtin addons r=zombie
We don't put system addons on the blocklist so there's no need to compute
blocklist state for them.  The immediate motivation for this is to avoid
initializing the blocklist early in startup for the initial startup in a
new profile or after a browser upgrade when we're installing/udpating
system and builtin addons.

Differential Revision: https://phabricator.services.mozilla.com/D68443

--HG--
extra : moz-landing-system : lando
2020-04-03 17:41:58 +00:00
Mark Striemer 1c02573b38 Bug 1626937 - Explicitly connect the addon-updates-message shadow DOM r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D69460

--HG--
extra : moz-landing-system : lando
2020-04-03 22:04:39 +00:00
Mark Striemer 98d569e7dd Bug 1626426 - Always have a dark about:addons page in dark mode r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69103

--HG--
extra : moz-landing-system : lando
2020-04-02 22:15:45 +00:00
Razvan Maries 2fcb2a30f0 Backed out changeset fe77998cc746 (bug 1626426) for bc failures on browser_history_navigation.js. CLOSED TREE 2020-04-02 21:25:49 +03:00
jayati d4e5020533 Bug 1592324 - Add button to extensions and themes page. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D66371

--HG--
extra : moz-landing-system : lando
2020-04-02 16:36:39 +00:00
Mark Striemer 3ace51c189 Bug 1626426 - Always have a dark about:addons page in dark mode r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69103

--HG--
extra : moz-landing-system : lando
2020-04-02 16:29:56 +00:00
Mark Striemer 71bcb7f89c Bug 1559392 - Support drag+drop of add-ons into HTML about:addons r=rpl
Depends on D65834

Differential Revision: https://phabricator.services.mozilla.com/D65835

--HG--
extra : moz-landing-system : lando
2020-04-02 02:06:25 +00:00
jayati fa65d02109 Bug 1626619 - Remove `browser.in-content.dark-mode` preference. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D69234

--HG--
extra : moz-landing-system : lando
2020-04-01 16:31:27 +00:00
Mark Striemer d37e1fec1c Bug 1626378 - Set role="tab" on about:addons categories r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D69095

--HG--
extra : moz-landing-system : lando
2020-03-31 21:59:38 +00:00
Kirk Steuber 2ece0deebf Bug 1625432 - Fix failing test by adding processID to the mock appinfo created by shared.js r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D69009

--HG--
extra : moz-landing-system : lando
2020-03-31 14:59:06 +00:00
Christoph Kerschbaumer 4b9c5814af Bug 1571461 - Change accessibility of search widget to look for all event handlers and remove hack to hide.r=surkov,MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D68023

--HG--
extra : moz-landing-system : lando
2020-03-31 11:06:38 +00:00
Mark Striemer 8b5461f86a Bug 1525178 - Part 6: Change about:addons category on keyboard nav r=rpl
Depends on D60426

Differential Revision: https://phabricator.services.mozilla.com/D65834

--HG--
extra : moz-landing-system : lando
2020-03-30 19:45:09 +00:00
Mark Striemer acef713181 Bug 1525178 - Part 5: Remove XUL about:addons CSS files r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D60426

--HG--
extra : moz-landing-system : lando
2020-03-30 19:45:12 +00:00
Mark Striemer 4f228fe0a0 Bug 1525178 - Part 4: Use the HTML sidebar r=fluent-reviewers,rpl
Differential Revision: https://phabricator.services.mozilla.com/D60425

--HG--
rename : toolkit/mozapps/extensions/test/browser/browser_bug577990.js => toolkit/mozapps/extensions/test/browser/browser_sidebar_hidden_categories.js
rename : toolkit/mozapps/extensions/test/browser/browser_bug567137.js => toolkit/mozapps/extensions/test/browser/browser_sidebar_restore_category.js
extra : moz-landing-system : lando
2020-03-30 19:45:01 +00:00
Mark Striemer 21205b994f Bug 1525178 - Part 3: Add second about:addons sidebar in HTML r=fluent-reviewers,rpl,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D60424

--HG--
extra : moz-landing-system : lando
2020-03-30 19:45:05 +00:00
Mark Striemer 1a49c36c2c Bug 1525178 - Part 2: Refactor AddonCardListenerHandler r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D60423

--HG--
extra : moz-landing-system : lando
2020-03-30 19:44:54 +00:00
Mark Striemer 541c10fc2d Bug 1525178 - Part 1: Extract common tab focus from named-deck components r=Gijs,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D60422

--HG--
extra : moz-landing-system : lando
2020-03-30 19:44:49 +00:00
Stephen A Pohl b955a31d60 Bug 1625354: Two more switches to a non-deprecated API to load .nib files. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D68486

--HG--
extra : moz-landing-system : lando
2020-03-30 23:17:27 +00:00
Tim Nguyen 047089c8e6 Bug 1625314 - Followup: Fix add-on manager tests. CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D68896

--HG--
extra : histedit_source : 9abbb7e5847e93671db15cc1ec516e5d6eeb8887
2020-03-30 21:27:02 +00:00
Tim Nguyen 4447b7118b Bug 1625314 - Scope search-textbox.css to search-textbox custom element. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D68810

--HG--
extra : moz-landing-system : lando
2020-03-30 19:59:45 +00:00
Tim Nguyen 9f4dbeaf3c Bug 1625982 - Rename textbox.js and textbox.css to moz-input-box.js and search-textbox.css. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D68829

--HG--
rename : toolkit/content/widgets/textbox.js => toolkit/content/widgets/moz-input-box.js
rename : toolkit/themes/linux/global/textbox.css => toolkit/themes/linux/global/search-textbox.css
rename : toolkit/themes/osx/global/textbox.css => toolkit/themes/osx/global/search-textbox.css
rename : toolkit/themes/windows/global/textbox.css => toolkit/themes/windows/global/search-textbox.css
extra : moz-landing-system : lando
2020-03-30 18:22:56 +00:00
sonakshi b204bf50aa Bug 1551306 - Remove context parameter from nsIProgressEventSink.onProgress() and nsIProgressEventSink.onStatus() r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D68235

--HG--
extra : moz-landing-system : lando
2020-03-29 19:18:56 +00:00
Bingjing Yan e55f6eaf40 Bug 1608188 - blocklist.dtd to Fluent r=mconley,Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D59633

--HG--
extra : moz-landing-system : lando
2020-03-27 21:32:43 +00:00
Cosmin Sabou 79929c6462 Backed out changeset ad4847d17298 (bug 1551306) for causing build bustages. CLOSED TREE 2020-03-27 20:24:17 +02:00
sonakshi 145046fde2 Bug 1551306 - Remove context parameter from nsIProgressEventSink.onProgress() and nsIProgressEventSink.onStatus() r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D68235

--HG--
extra : moz-landing-system : lando
2020-03-27 17:57:10 +00:00
JulianWels b9a66ff272 Bug 1622028 - Log failed upgrades for HTTPS Only Mode. r=ckerschb,dragana
Differential Revision: https://phabricator.services.mozilla.com/D68026

--HG--
extra : moz-landing-system : lando
2020-03-27 17:09:15 +00:00
Oana Pop Rus 679f10ce5f Backed out changeset 9d3487044f9a (bug 1622028) for build bustages in nsHTTPSOnlyStreamListener.h on a CLOSED TREE 2020-03-27 17:47:07 +02:00
JulianWels 8d65d4a658 Bug 1622028 - Log failed upgrades for HTTPS Only Mode. r=ckerschb,dragana
Differential Revision: https://phabricator.services.mozilla.com/D68026

--HG--
extra : moz-landing-system : lando
2020-03-27 14:35:33 +00:00
Mihai Alexandru Michis c1256a18a6 Backed out changeset d91e4acdd63c (bug 1551306) for causing bustages in request::InitBitsRequest
CLOSED TREE
2020-03-27 16:12:47 +02:00
sonakshi b5f7fb3be7 Bug 1551306 - Remove context parameter from nsIProgressEventSink.onProgress() and nsIProgressEventSink.onStatus() r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D68235

--HG--
extra : moz-landing-system : lando
2020-03-27 14:05:02 +00:00
Christian Holler c248943491 Bug 1620326 - Add a separate TSan suppression list for the updater. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D67125

--HG--
extra : moz-landing-system : lando
2020-03-26 21:19:24 +00:00
Kirk Steuber 2b3d684f4e Bug 1568994 - Convert Enterprise policy AppUpdateURL to work with the new update url mechanism r=mkaply,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D45869

--HG--
extra : moz-landing-system : lando
2020-03-24 22:03:27 +00:00
Kirk Steuber b7a4f22235 Bug 1568994 - Convert usage of app.update.url pref to Services.appinfo.updateURL r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D45868

--HG--
extra : moz-landing-system : lando
2020-03-24 22:02:49 +00:00
Ciure Andrei 5e253e2fa2 Backed out changeset 75c75ac98d86 (bug 1592324) for causing bc failures CLOSED TREE 2020-03-25 19:02:06 +02:00
jayati 40d1f772cb Bug 1592324- Add button to extensions and themes page. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D66371

--HG--
extra : moz-landing-system : lando
2020-03-25 15:34:03 +00:00
ajitesh 74c011887b Bug 1421039 - Remove duplicate extension icons r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D63288

--HG--
rename : browser/themes/shared/controlcenter/extension.svg => toolkit/themes/shared/extensions/extension.svg
extra : moz-landing-system : lando
2020-03-23 15:24:24 +00:00
aarushivij c7d4000c3b Bug 1596858 - Different spacing above Enabled and Disabled headers while there is no enabled add-on r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D67270

--HG--
extra : moz-landing-system : lando
2020-03-23 15:19:14 +00:00
jayati d0ec94b559 Bug 1623034 - Changed sQuit from gboolean to mozilla::Atomic<gboolean>. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D67666

--HG--
extra : moz-landing-system : lando
2020-03-20 22:31:35 +00:00
Simon Giesecke 7e9a7de895 Bug 1620632 - Rename confusingly named types/macros for relocation handling of nsTArray. r=froydnj
Specifically, this renames
* nsTArray_CopyChooser to nsTArray_RelocationStrategy
* the Copy template argument of nsTArray_base to RelocationStrategy
* nsTArray_CopyWithConstructors to nsTArray_RelocateUsingMoveConstructor
* nsTArray_CopyWithMemutils to nsTArray_RelocateUsingMemutils
* DECLARE_USE_COPY_CONSTRUCTORS to MOZ_DECLARE_RELOCATE_USING_MOVE_CONSTRUCTOR

Differential Revision: https://phabricator.services.mozilla.com/D66243

--HG--
extra : moz-landing-system : lando
2020-03-20 17:04:27 +00:00
Sylvestre Ledru be18fd4dba Bug 1622328 - add license info to all eslintrc files r=Standard8,webcompat-reviewers,miketaylr
Differential Revision: https://phabricator.services.mozilla.com/D67319

--HG--
extra : moz-landing-system : lando
2020-03-19 13:47:51 +00:00
Emma Malysz 0faecc91b5 Bug 1522930, delay GMP initialization until after first point to improve perceived performance. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D67165

--HG--
extra : moz-landing-system : lando
2020-03-18 22:33:01 +00:00
jayati 0eac3c871d Bug 1466357 - Use RefreshShellIcons instead of manually reimplementing it for Windows installer. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D67379

--HG--
extra : moz-landing-system : lando
2020-03-18 20:33:19 +00:00
Shane Caraveo 1c7aac9c88 Bug 1622117 load old addon manifest during update if necessary, to migrate permissions r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D66690

--HG--
extra : moz-landing-system : lando
2020-03-18 18:22:56 +00:00
William Lachance e4da848fd8 Bug 1623132 - Rewrite printconfigsetting to use configparser, python 3 r=rstewart
Differential Revision: https://phabricator.services.mozilla.com/D67210

--HG--
extra : moz-landing-system : lando
2020-03-18 15:07:24 +00:00
Agi Sferro 3342f3308e Bug 1623173 - Preserve embedderDisabled when rebuilding addon DB. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D67226

--HG--
extra : moz-landing-system : lando
2020-03-17 22:50:04 +00:00
Mathieu Leplatre bc6e54afaa Bug 1620185 - Remove usage of .openCollection() in other modules r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D66749

--HG--
extra : moz-landing-system : lando
2020-03-17 20:21:54 +00:00
JulianWels e5c3036681 Bug 1620242 - Basic implementation for HTTPS Only Mode. r=ckerschb,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D62590

--HG--
rename : dom/security/test/csp/file_redirect_report.sjs => dom/security/test/https-only/file_redirect.sjs
rename : dom/security/test/csp/file_upgrade_insecure.html => dom/security/test/https-only/file_upgrade_insecure.html
rename : dom/security/test/csp/file_upgrade_insecure_server.sjs => dom/security/test/https-only/file_upgrade_insecure_server.sjs
rename : dom/security/test/csp/file_upgrade_insecure_wsh.py => dom/security/test/https-only/file_upgrade_insecure_wsh.py
extra : moz-landing-system : lando
2020-03-17 19:24:31 +00:00
Noemi Erli f10f67e74c Backed out changeset 21f62488a5b5 (bug 1620242) for causing bustages in nsMixedContentBlocker.cpp CLOSED TREE 2020-03-16 23:11:00 +02:00
JulianWels c2c4e65115 Bug 1620242 - Basic implementation for HTTPS Only Mode. r=ckerschb,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D62590

--HG--
rename : dom/security/test/csp/file_redirect_report.sjs => dom/security/test/https-only/file_redirect.sjs
rename : dom/security/test/csp/file_upgrade_insecure.html => dom/security/test/https-only/file_upgrade_insecure.html
rename : dom/security/test/csp/file_upgrade_insecure_server.sjs => dom/security/test/https-only/file_upgrade_insecure_server.sjs
rename : dom/security/test/csp/file_upgrade_insecure_wsh.py => dom/security/test/https-only/file_upgrade_insecure_wsh.py
extra : moz-landing-system : lando
2020-03-16 16:47:54 +00:00
Molly Howell e13554f0e7 Bug 1602463 Part 4 - Register/unregister the default browser agent scheduled task during install/uninstall. r=agashlin,bytesized,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D61891

--HG--
extra : moz-landing-system : lando
2020-03-16 18:32:58 +00:00
Molly Howell 06f1209768 Bug 1602463 Part 3 - Windows default browser agent. r=agashlin,bytesized,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D61889

--HG--
extra : moz-landing-system : lando
2020-03-16 20:16:25 +00:00
Mihai Alexandru Michis 12c2ba4b56 Backed out 5 changesets (bug 1602463) for causing diffoscope failures.
CLOSED TREE

Backed out changeset ff565862e785 (bug 1602463)
Backed out changeset 2583a2703658 (bug 1602463)
Backed out changeset 8f3de97c5d50 (bug 1602463)
Backed out changeset be11972a8149 (bug 1602463)
Backed out changeset 5a6058d8266c (bug 1602463)
2020-03-16 20:29:20 +02:00
Molly Howell be2e8b6844 Bug 1602463 Part 4 - Register/unregister the default browser agent scheduled task during install/uninstall. r=agashlin,bytesized,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D61891

--HG--
extra : moz-landing-system : lando
2020-03-16 15:12:33 +00:00
Molly Howell 3964971fc6 Bug 1602463 Part 3 - Windows default browser agent. r=agashlin,bytesized,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D61889

--HG--
extra : moz-landing-system : lando
2020-03-16 15:11:17 +00:00
Ed Lee acb960676c Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128

--HG--
extra : moz-landing-system : lando
2020-03-13 23:38:52 +00:00
Brendan Dahl 1f6bb7fb21 Bug 1620083 - Make web extensions re-bundle when dependent files change. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D65416

--HG--
extra : moz-landing-system : lando
2020-03-13 22:22:15 +00:00
Mike Shal fb3b0075d1 Bug 1607193 - Remove l10n-check; r=firefox-build-system-reviewers,rstewart
Depends on D66715

Differential Revision: https://phabricator.services.mozilla.com/D66716

--HG--
extra : moz-landing-system : lando
2020-03-13 18:34:28 +00:00
Mihai Alexandru Michis 75355611d1 Backed out changeset 46dfbb4de902 (bug 1620242) for causing failures in test_x-frame-options.html
CLOSED TREE
2020-03-13 18:24:03 +02:00
JulianWels d5b073f588 Bug 1620242 - Basic implementation for HTTPS Only Mode. r=ckerschb,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D62590

--HG--
rename : dom/security/test/csp/file_redirect_report.sjs => dom/security/test/https-only/file_redirect.sjs
rename : dom/security/test/csp/file_upgrade_insecure.html => dom/security/test/https-only/file_upgrade_insecure.html
rename : dom/security/test/csp/file_upgrade_insecure_server.sjs => dom/security/test/https-only/file_upgrade_insecure_server.sjs
rename : dom/security/test/csp/file_upgrade_insecure_wsh.py => dom/security/test/https-only/file_upgrade_insecure_wsh.py
extra : moz-landing-system : lando
2020-03-13 14:25:08 +00:00
Ben Hearsum 644c3e8d4f Bug 1619985: use a unique package platform for aarch64 windows builds r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D66278

--HG--
extra : moz-landing-system : lando
2020-03-10 18:31:16 +00:00
Ian Neal 7ccd5729a2 Bug 1621564 - 75.0beta source tarballs dont contain third_party/rust/failure/.github-ci.yml -> failure to build r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D66373

--HG--
extra : moz-landing-system : lando
2020-03-11 10:35:48 +00:00
Mike Shal 211c2b2745 Bug 1620744 - Convert gen_built_in_addons.py to py3; r=firefox-build-system-reviewers,rstewart
Depends on D65858

Differential Revision: https://phabricator.services.mozilla.com/D66298

--HG--
extra : moz-landing-system : lando
2020-03-10 20:22:13 +00:00
Mike Shal d6e9df170e Bug 1620744 - Convert test_archive action to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65858

--HG--
extra : moz-landing-system : lando
2020-03-10 20:19:49 +00:00
Mike Shal 4017368b2f Bug 1620744 - Use py3_action for cases that already support it; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65846

--HG--
extra : moz-landing-system : lando
2020-03-10 20:19:13 +00:00
Daniel Varga 09acd57d19 Backed out 13 changesets (bug 1620744) for causing diffoscope failures firefox/browser/chrome/browser/content/browser/built_in_addons.json
CLOSED TREE

Backed out changeset 6beda54bcb9b (bug 1620744)
Backed out changeset a1e97f0b91ef (bug 1620744)
Backed out changeset b8faa0184d4f (bug 1620744)
Backed out changeset 3bc8fda68107 (bug 1620744)
Backed out changeset 8e95b21b2ae3 (bug 1620744)
Backed out changeset 1de09de1a802 (bug 1620744)
Backed out changeset 622a2f7414fa (bug 1620744)
Backed out changeset 3372c9ab721c (bug 1620744)
Backed out changeset 0997313a9f99 (bug 1620744)
Backed out changeset 2fa34749bbfa (bug 1620744)
Backed out changeset 6d597d2eb792 (bug 1620744)
Backed out changeset 78e78f7c7b26 (bug 1620744)
Backed out changeset 6e4d85b19f88 (bug 1620744)
2020-03-10 21:13:18 +02:00
Mike Shal d181929c22 Bug 1620744 - Convert test_archive action to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65858

--HG--
extra : moz-landing-system : lando
2020-03-09 22:02:50 +00:00
Mike Shal a1ea58eb94 Bug 1620744 - Use py3_action for cases that already support it; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65846

--HG--
extra : moz-landing-system : lando
2020-03-09 22:02:22 +00:00
Simon Giesecke 8ad76c7e47 Bug 1613985 - Use default for equivalent-to-default constructors/destructors in toolkit. r=mossop
Depends on D66008

Differential Revision: https://phabricator.services.mozilla.com/D66010

--HG--
extra : moz-landing-system : lando
2020-03-10 08:48:24 +00:00
Gijs Kruitbosch f1a04bd343 Bug 1618188 - remove XML backend for plugin and add-on blocklisting, r=mconley,perftest-reviewers,whimboo
This removes the obsolete backend. Notes on some of the less obvious changes
made as part of this patch:

- some of the gFoo style getters in Blocklist.jsm were only used by the XML
  version of the blocklist; I've removed them and tried to remove spurious
  settings of those properties in the remaining tests.
- some utility methods (e.g. distribution information getters) were also only
  used for the XML version (for the update URL).
- it's no longer necessary to test switching implementations.
- in browser/base/content/test/plugins/, we ran some tests from two manifests
  in order to run them with both blocklist backends. The simplest way of
  reducing this back down to one was to remove the remote-settings one. If I'd
  been more future-oriented when I created the duplication, perhaps I would
  have moved the XML version out into a different manifest instead, but I
  didn't, so now it looks like we're removing the modern one, whereas really
  we're going to be running the modern one as part of the "normal" tests and
  we're no longer running the "old" tests.
- removed all mentions I could see of extensions.blocklist.url which is no
  longer used for anything.
- per https://bugzilla.mozilla.org/show_bug.cgi?id=1016555#c23, updated
  references for the OneCRL timing and how it relates to blocklist updates.

Differential Revision: https://phabricator.services.mozilla.com/D64933

--HG--
extra : moz-landing-system : lando
2020-03-09 12:02:17 +00:00
Mark Banner 2c4e35b0a6 Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65509

--HG--
extra : moz-landing-system : lando
2020-03-08 21:45:16 +00:00
Shane Caraveo d51b1be41f Bug 1618500 handle permissions and preferences changes on addon update r=aswan
If an addon is updated and moves permissions between required to optional, we
want to retain the previously granted permission so the extension does not have to
request the permission from the user again. We also handle permission removal
and changes to preferences based on permissions.

Differential Revision: https://phabricator.services.mozilla.com/D64696

--HG--
extra : moz-landing-system : lando
2020-03-08 19:29:55 +00:00
Ian Neal 5a836d5e08 Bug 1620854 - Tarball generation should also exclude git files. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D65906

--HG--
extra : moz-landing-system : lando
2020-03-08 19:12:35 +00:00
Mark Banner 15cfe23b88 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703

--HG--
extra : moz-landing-system : lando
2020-03-07 10:09:44 +00:00
Mike Shal 6133e75b71 Bug 1620449 - Convert gen_cert_header.py to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65632

--HG--
extra : moz-landing-system : lando
2020-03-06 17:31:15 +00:00
James Willcox 6a100ba3a0 Bug 1620415 - Don't include GMP in GeckoView r=geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D65644

--HG--
extra : moz-landing-system : lando
2020-03-06 00:45:52 +00:00