This change adds and integrates a Preferences UI for Firefox Reality on Desktop. This simple page supports 3 behaviors:
- Viewing the privacy policy
- Toggly Telemetry
- Clearing User Data
The latter two have an impact on the desktop install of Firefox associated with this instance of FxR.
Subsequent changes will update the UI to design specifications as well as migrate the strings to Fluent.
Differential Revision: https://phabricator.services.mozilla.com/D48186
--HG--
extra : moz-landing-system : lando
This reverts part of bug 1576158, so that all current and future in-content pages share the same implementation.
Differential Revision: https://phabricator.services.mozilla.com/D49559
--HG--
extra : moz-landing-system : lando
1. Previously, the label and tooltip for all recommendations was just "Recommendation", even though the icon was different for extension and feature recommendations.
Because users might not be able to see the icon and/or determine its meaning, it is important that this is communicated in the tooltip and a11y label.
2. Screen reader users won't know this has appeared, even though this attracts some attention visually.
Therefore, provide a specific announcement for screen reader users when the recommendation appears.
Differential Revision: https://phabricator.services.mozilla.com/D47718
--HG--
extra : moz-landing-system : lando
Split the SEARCH source into SEARCH_NETWORK or SEARCH_LOCAL to distinguish
search results coming from a remote source, from those generated locally.
browser.urlbar.suggest.searches will only affect SEARCH_NETWORK results.
Differential Revision: https://phabricator.services.mozilla.com/D49172
--HG--
extra : moz-landing-system : lando
All but browser_bug744745.js seem to pass even without the fixes I
made, which seems odd.
browser_bug1058164.js is a little odd because it passes in {} instead
of a boolean for the useCapture argument. I think this ends up calling
addEventListener(..., {}, false), which should be the equivalent of
addEventListener(..., {}).
Differential Revision: https://phabricator.services.mozilla.com/D49453
--HG--
extra : moz-landing-system : lando
This avoids a JS error when the tab has been removed before this function
has a chance to run.
Differential Revision: https://phabricator.services.mozilla.com/D48993
--HG--
extra : moz-landing-system : lando
We extract tags from the result title only when `info.style.includes("bookmark")`, but that only captures one of the two cases where we include tags in the title: the "bookmark" style. We also include tags for the "tag" style. So the bug reports in this bug are hitting that "tag" case. It doesn't have anything to do with non-Latin tags afaict (see the bug summary).
I took the opportunity to streamline `UnifiedComplete._addFilteredQueryMatch`, which was a little hard to follow. I had to look at it to make sure I captured all the cases where tags are included in the title. I think I've made it easier to follow.
Differential Revision: https://phabricator.services.mozilla.com/D49223
--HG--
extra : moz-landing-system : lando
This changes the either-or semantics to one-after between the local and remote fluent files for ASRouter.
Differential Revision: https://phabricator.services.mozilla.com/D49068
--HG--
extra : moz-landing-system : lando
Note - This change is only visible in the light variation of the default theme.
Differential Revision: https://phabricator.services.mozilla.com/D49179
--HG--
extra : moz-landing-system : lando
Note - I did not edit the refernces to `--in-content-box-border-color` across the following refernces:
login-list:
:host (Also contained references to backround color: `--in-content-box-background`)
.meta (Also contained references to backround color: `--in-content-box-background`)
.create-login-button-container (Shadow color property)
menu-button:
.menu (Also contained references to backround color: `--in-content-box-background`)
Differential Revision: https://phabricator.services.mozilla.com/D49188
--HG--
extra : moz-landing-system : lando
This flips the direction in which the BrowserBridge actor is generally created
such that it is generally created in the parent and sent down to a child
process.
This is done by making the decision about what kind of switch to perform in the
parent, and sending messages down to child processes async to orchestrate these
process changes.
Process launching is changed to use an async `MozPromise`-returning API in this
patch, though the actual process launching still occurs synchronously. A future
patch will enable performing async process launching through the
NewOrUsedBrowserProcess mechanism.
I know of at least a few timing issues which exist with the new logic,
especially around the state of the BrowsingContext during the process
transition. I decided to not try to fix all of these issues in this patch, as
many are complex and will require changing how we manage the lifecycle of
BrowsingContext substantially. I do, however, think that the new logic is more
reliable and has fewer timing issues than the previous logic.
Differential Revision: https://phabricator.services.mozilla.com/D47310
--HG--
extra : moz-landing-system : lando
Abdoulaye Oumar Ly
Mark Banner
ffxbld
thomasmo
Oana Pop Rus
Mike de Boer
Harry Twyford
Marco Bonardo
Bogdan Tara
James Teh
Dão Gottwald
Mihai Alexandru Michis
Jan-Ivar Bruaroey
Andrew McCreight
Erica Wright
Jared Wein
Nihanth Subramanya
Cosmin Sabou
Gijs Kruitbosch
Brad Werth
Marcos Cáceres
Drew Willcoxon
Razvan Maries
Nan Jiang
mcrawford@mozilla.com
Edouard Oger
Nika Layzell