Bug 1615026 introduced some coordinate space change which I didn't intend.
NSRectToSnappedRect does what we want instead.
Differential Revision: https://phabricator.services.mozilla.com/D65519
--HG--
extra : moz-landing-system : lando
There is a logic error in the code that is not catching missing tests. Also, the manifest path for each test needs to be added along with the test name so the logger can be able to print it.
Differential Revision: https://phabricator.services.mozilla.com/D65473
--HG--
extra : moz-landing-system : lando
After removing Fennec-specific media control and audio focus related code, now no one is using `mediaSuspend` attribute, so we can remove it as well.
Differential Revision: https://phabricator.services.mozilla.com/D65402
--HG--
extra : moz-landing-system : lando
We won't need these suspend states anymore which were used for media control and audio focus on Fennec.
Differential Revision: https://phabricator.services.mozilla.com/D65265
--HG--
extra : moz-landing-system : lando
Those suspend and resume related logic were used for implemeting media control and audio focus on Fennec. After removing those things, the only purpose of `AudioChannelAgentCallback` would be muting and unmuting media element from audio channel (eg. clicking sound indicator to mute/unmute tab)
Differential Revision: https://phabricator.services.mozilla.com/D65264
--HG--
extra : moz-landing-system : lando
This attribute is used to expose the internal suspend state of media element to see if we set `SUSPENDED_PAUSE` and `SUSPENDED_PAUSE_DISPOSABLE` correctly. As we don't use those suspend state anymore and have removed the related tests, no need to keep this attribute anymore.
Differential Revision: https://phabricator.services.mozilla.com/D65263
--HG--
extra : moz-landing-system : lando
These methods were used for media control and audio focus on Fennec, and we don't need them anymore.
Differential Revision: https://phabricator.services.mozilla.com/D65262
--HG--
extra : moz-landing-system : lando
These tests are used to test `SUSPENDED_PAUSE`, which is used for the old audio focus mechanism on Fennec, and `SUSPENDED_PAUSE_DISPOSABLE`, which is used for the media control on Fennec.
As we don't use them anymore, we can remove these tests.
Differential Revision: https://phabricator.services.mozilla.com/D65261
--HG--
extra : moz-landing-system : lando
These attribute and method were added for media control in Fennec and it seems we forgot to clean them.
Differential Revision: https://phabricator.services.mozilla.com/D65259
--HG--
extra : moz-landing-system : lando
`media-playback-resumed` was a notification we used on Fennec to indicate media playback state changes and we should update the UI button on the virtual control interface. As it's not being used by anyone since we deprecate Fennec, we can remove all related code.
Differential Revision: https://phabricator.services.mozilla.com/D65258
--HG--
extra : moz-landing-system : lando
`media-playback` was a notification which we used for Fennec to indicate media has started playing and we should show the virtual controller interface. As it's not being used by anyone since we deprecate Fennec, we can remove all related code.
Differential Revision: https://phabricator.services.mozilla.com/D65257
--HG--
extra : moz-landing-system : lando
We were stroking the ellipse which strokes through the middle of the path,
meaning that it overflowed by one css pixel around the circle.
Differential Revision: https://phabricator.services.mozilla.com/D65633
--HG--
extra : moz-landing-system : lando
Changes:
Replaces all instances of `itervlaues` and `iteritems` with `six` variant.
Differential Revision: https://phabricator.services.mozilla.com/D61055
--HG--
extra : moz-landing-system : lando
While here, change ${TOOLTOOL_DIR}/vs2017_15.8.4 to ${VSPATH} which
expands to the same thing without depending on the version of MSVC.
Differential Revision: https://phabricator.services.mozilla.com/D65475
--HG--
extra : moz-landing-system : lando
Also, set the target explicitly, rather than get it implicitly from
MozillaBuild being 32-bits.
Differential Revision: https://phabricator.services.mozilla.com/D65471
--HG--
extra : moz-landing-system : lando
With this and all the previous changes, the necessary mozconfig for
local cross-builds only contains DIA_SDK_PATH, WINDOWSSDKDIR and
--target.
Differential Revision: https://phabricator.services.mozilla.com/D65295
--HG--
extra : moz-landing-system : lando
This was cargo culted from the autoconf equivalent, and while it makes a
command that does "$(PROG) foo" work because it becomes ": foo", that
may or may not actually be a desirable outcome.
OTOH, we do have some places where there are some "ifdef PROG" that are
just plain wrong when PROG is always actually set.
One place I do know that does check if the value is not ":" is for
OBJCOPY, which is still set from autoconf.
All in all, looking at all the check_prog(allow_missing=True) we have in
python configure, it doesn't seem anything is checking for ":", and that
doesn't seem like the right status quo.
Differential Revision: https://phabricator.services.mozilla.com/D65276
--HG--
extra : moz-landing-system : lando
This also removes nsPrintJob::mFallbackDocTitle since there really is no point
in blindly calculating it ahead of time when we will virtually never use it,
and even if there was there's no reason to store in on the nsPrintJob given
that we create a new nsPrintJob every time we print!
Differential Revision: https://phabricator.services.mozilla.com/D65014
--HG--
extra : moz-landing-system : lando
Tom Prince
Logan Smyth
Kershaw Chang
Christoph Kerschbaumer
Simon Giesecke
Cosmin Sabou
Ted Campbell
Ehsan Akhgari
Christian Holler
Tom Ritter
Andrei Oprea
Emilio Cobos Álvarez
Simon Fraser
alexandru.ionescu
Alastor Wu
Jeff Walden
Edwin Takahashi
Mathieu Leplatre
James Willcox
Nicholas Nethercote
Tooru Fujisawa
Mike Hommey
Andreea Pavel
Jason Laster
Jonathan Watt