Simon Giesecke
1ca11f861a
Bug 1626973 - Make attempt to increase the file size via IDBFileHandle.truncate an error. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69580
--HG--
extra : moz-landing-system : lando
2020-04-06 13:56:47 +00:00
Eric Rahm
223ce1e031
Bug 1626435 - Remove nsAutoPtr usage from dom/filehandle. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D69105
--HG--
extra : moz-landing-system : lando
2020-04-03 21:04:53 +00:00
Simon Giesecke
8be644ba9e
Bug 1614360 - Signal error to child on attempts to read beyond EOF instead of asserting. r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D62774
--HG--
extra : moz-landing-system : lando
2020-02-18 14:45:59 +00:00
Simon Giesecke
31ca390597
Bug 1499099 - Clamp result codes to NS_ERROR_MODULE_DOM_FILEHANDLE result codes in ActorsParent. r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D63155
--HG--
extra : moz-landing-system : lando
2020-02-20 11:39:51 +00:00
Simon Giesecke
b50347f917
Bug 1611415 - Prefer using std::move over forget. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D60980
--HG--
extra : moz-landing-system : lando
2020-02-13 14:38:48 +00:00
shindli
91aa0518dd
Backed out changeset 0c982bc69cb3 (bug 1611415) for causing build bustages in /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr CLOSED TREE
2020-02-12 20:13:29 +02:00
Simon Giesecke
f604a47fa5
Bug 1611415 - Applied FixItHints from mozilla-non-std-move. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D60980
--HG--
extra : moz-landing-system : lando
2020-02-12 17:24:41 +00:00
Simon Giesecke
3d3a547551
Bug 1613985 - Use default for equivalent-to-default constructors/destructors in dom/filehandle. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D62561
--HG--
extra : moz-landing-system : lando
2020-02-12 10:34:43 +00:00
Andrea Marchesini
ce6465d9ea
Bug 1607791 - Get rid of IDBMutableFile.getFile() - part 1, r=asuth,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D59140
--HG--
extra : moz-landing-system : lando
2020-01-15 12:02:21 +00:00
Mihai Alexandru Michis
4345a38d0d
Backed out 9 changesets (bug 1607791, bug 1605566) for causing multiple wpt failures.
...
CLOSED TREE
Backed out changeset 39f34852842e (bug 1605566)
Backed out changeset 3427a92445c8 (bug 1605566)
Backed out changeset 36631ec96f1f (bug 1605566)
Backed out changeset 554b2bdce66c (bug 1605566)
Backed out changeset 37026beadbd8 (bug 1605566)
Backed out changeset f15835338319 (bug 1607791)
Backed out changeset 4c92f506cf62 (bug 1607791)
Backed out changeset 80707bcc8427 (bug 1607791)
Backed out changeset 75bc7533c899 (bug 1607791)
2020-01-15 13:45:33 +02:00
Andrea Marchesini
6c05c922e3
Bug 1607791 - Get rid of IDBMutableFile.getFile() - part 1, r=asuth,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D59140
--HG--
extra : moz-landing-system : lando
2020-01-15 09:58:39 +00:00
ssengupta
ce59756fd9
Bug 1499105 - P1 - IDBFileHandle::Read() now throws error and returns nullptr if read size larger than 4GB r=janv,sg
...
IDBFileHandle::Read() calls CheckStateAndArgumentsForRead(), where the size of data to be read is also checked. If the size is larger than [[ https://www.qnx.com/developers/docs/6.4.1/dinkum_en/c99/stdint.html#INT32_MAX | INT32_MAX ]], JavaScript exception is thrown and Read() returns **nullptr**.
Since a compromised sender could send data of a larger size, size is checked again in FileHandle::VerifyRequestParams().
Please also check: [[ https://phabricator.services.mozilla.com/D59326 | D59326 ]] and [[ https://phabricator.services.mozilla.com/D59515 | D59515 ]].
Differential Revision: https://phabricator.services.mozilla.com/D58961
--HG--
extra : moz-landing-system : lando
2020-01-14 13:01:18 +00:00
Mihai Alexandru Michis
69c58429da
Backed out changeset 874ea520c496 (bug 1499105) for causing bustages in dom/filehandle/ActorsParent.cpp
...
CLOSED TREE
2020-01-13 16:01:03 +02:00
ssengupta
1348b032ac
Bug 1499105 - P1 - IDBFileHandle::Read() now throws error and returns nullptr if read size larger than 4GB r=janv,sg
...
IDBFileHandle::Read() calls CheckStateAndArgumentsForRead(), where the size of data to be read is also checked. If the size is larger than [[ https://www.qnx.com/developers/docs/6.4.1/dinkum_en/c99/stdint.html#INT32_MAX | INT32_MAX ]], JavaScript exception is thrown and Read() returns **nullptr**.
Since a compromised sender could send data of a larger size, size is checked again in FileHandle::VerifyRequestParams().
Please also check: [[ https://phabricator.services.mozilla.com/D59326 | D59326 ]] and [[ https://phabricator.services.mozilla.com/D59515 | D59515 ]].
Differential Revision: https://phabricator.services.mozilla.com/D58961
--HG--
extra : moz-landing-system : lando
2020-01-13 13:34:24 +00:00
ssengupta
f026ab19d2
Bug 1499105 - P2 - NormalFileHandleOp::Cleanup() no longer asserts mResponseSent when called after failed initialization r=janv
...
If NormalFileHandleOp's initialisation fails, it is not possible to send a failure response, which is why mResponseSent remains `false`. To not assert the value of mResponseSent in such cases, check for a new Boolean member mEnqueued has been introduced. If mEnqueued is `false`, that suggests initialization failure.
Differential Revision: https://phabricator.services.mozilla.com/D59326
--HG--
extra : moz-landing-system : lando
2020-01-10 16:16:13 +00:00
Anne van Kesteren
c9d5a9bd8a
Bug 1594981 - improve BUG_COMPONENT in various moz.build files r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D53024
--HG--
extra : moz-landing-system : lando
2019-11-14 15:44:32 +00:00
Andrea Marchesini
69fd7c57d7
Bug 1545758 - Move dom/file IPC components into mozilla::dom namespace - PendingIPCBlob actors, r=qdot
...
Differential Revision: https://phabricator.services.mozilla.com/D28189
--HG--
extra : moz-landing-system : lando
2019-04-26 18:01:08 +00:00
Bogdan Tara
240b24fbe1
Backed out 5 changesets (bug 1534712, bug 1545758) for test_ext_webrequest_upload.html failures CLOSED TREE
...
Backed out changeset 447b0f5a5802 (bug 1545758)
Backed out changeset 0528f8f11814 (bug 1545758)
Backed out changeset d85c68071b54 (bug 1545758)
Backed out changeset 10b380bc5b0c (bug 1545758)
Backed out changeset 57136f4e7b54 (bug 1534712)
2019-04-25 12:36:51 +03:00
Andrea Marchesini
50fa1de562
Bug 1545758 - Move dom/file IPC components into mozilla::dom namespace - PendingIPCBlob actors, r=qdot
...
Differential Revision: https://phabricator.services.mozilla.com/D28189
--HG--
extra : moz-landing-system : lando
2019-04-25 07:44:03 +00:00
Sebastian Hengst
cee711baf9
Bug 1535353 - update Core :: DOM: * bugzilla product and component meta data in moz.build files after reorganization in bug 1533440 r=hsinyi
...
Differential Revision: https://phabricator.services.mozilla.com/D23546
--HG--
extra : moz-landing-system : lando
2019-03-17 23:13:22 +00:00
Alex Gaynor
e226477611
Bug 1535397 - Part 3 - use native Maybe syntax in place of FileRequestSize and FileRequestLastModified in IDPL; r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D23560
--HG--
extra : moz-landing-system : lando
2019-03-15 17:10:13 +00:00
Alex Gaynor
0f01791ffc
Bug 1512990
- Part 4 - remove declarations of Recv/Answer methods from IPDL protocol base class; r=froydnj
...
For cases where the class has direct calls (that is, we cast `this` to the
subclass before making the call) no longer declare Recv/Answer methods on the
base class at all. This should ensure that slots for them are not generated in
vtables, and also allow the derived class to choose the method signature (e.g.
whether it wants to take something by reference or by value).
Differential Revision: https://phabricator.services.mozilla.com/D18132
--HG--
extra : moz-landing-system : lando
2019-02-06 15:58:43 +00:00
Alex Gaynor
984f0333ea
Bug 1512990
- Part 3 - remove declarations of Alloc/Dealloc methods from IPDL protocol base class; r=froydnj
...
For cases where the class has direct calls (that is, we cast `this` to the
subclass before making the call) no longer declare Alloc/Dealloc methods on the
base class at all. This should ensure that slots for them are not generated in
vtables, and also allow the derived class to choose the method signature (e.g.
whether it wants to take something by reference or by value).
Differential Revision: https://phabricator.services.mozilla.com/D18131
--HG--
extra : moz-landing-system : lando
2019-02-06 15:58:07 +00:00
Alex Gaynor
75c7d1fa76
Bug 1512990
- Part 2 - implement direct calls in the IPDL compiler; r=froydnj
...
When calling a Recv/Alloc/Dealloc method on most types, cast `this` to the
derived class.
There is a heuristic to figure out what the correct derived type is. There is a
blacklist of types which we can't do direct calls on for the moment, as well as
an override for types that do work with direct calls but which don't match the
heuristic.
Differential Revision: https://phabricator.services.mozilla.com/D16492
--HG--
extra : moz-landing-system : lando
2019-02-06 15:57:37 +00:00
Ehsan Akhgari
e5e885ae31
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
Alex Gaynor
55e3f21b2b
Bug 1515437 - mark several IPC methods as final; r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D15011
--HG--
extra : moz-landing-system : lando
2018-12-19 21:46:49 +00:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Ehsan Akhgari
fa81a39327
Bug 1491558 - Remove the XPCOM registration for nsThreadPool; r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D5943
2018-09-15 12:13:57 -04:00
Jan Varga
b277f1385d
Bug 1361330 - Part 2: Move MemoryOutputStream to a generic place; r=asuth
2018-08-20 14:32:48 +02:00
Emilio Cobos Álvarez
fffb25b74f
Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
...
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Andrew McCreight
298aa82710
Bug 1412125, part 2 - Fix dom/ mode lines. r=qdot
...
This was automatically generated by the script modeline.py.
MozReview-Commit-ID: BgulzkGteAL
--HG--
extra : rebase_source : a4b9d16a4c06c4e85d7d85f485221b1e4ebdfede
2017-10-26 15:08:41 -07:00
Andrea Marchesini
9067ec472c
Bug 1404845 - Renaming BlobImpl::GetInternalStream to BlobImpl::CreateInputStream, r=smaug
2017-10-02 13:53:12 +02:00
Bill McCloskey
f115503a0b
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book
8a1350b5a6
Backed out changeset 4f6302a98ae4 (bug 1372405
)
...
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey
6b3e84ed5f
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
ea1b86680c
Backed out changeset 9846de3bd954 (bug 1372405
)
...
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey
4592152411
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Bill McCloskey
aefa2aa5da
Bug 1365097 - Convert NS_GetCurrentThread uses in dom (except for dom/media) (r=smaug)
...
For the Quatum DOM project, it's better to work in terms of event targets than
threads. This patch converts DOM code to operate on event targets rather than
threads, when possible.
MozReview-Commit-ID: 5FgvpKadUA2
2017-06-12 20:20:08 -07:00
Jan Varga
fecbc27222
Bug 1370519 - Part 4: Get rid of FileHandleCommon.h/cpp; r=btseng
2017-06-07 12:36:58 +02:00
Jan Varga
d0c12b86b4
Bug 1370519 - Part 3: Remove unused files; r=btseng
2017-06-07 12:36:51 +02:00
Jan Varga
4cc459c1a1
Bug 1370519 - Part 2: Merge FileHandle base classes with IndexedDB specific classes (except parent actors); r=btseng
2017-06-07 12:36:42 +02:00
Nathan Froyd
c1d1748428
Bug 1359490 - add an event loop spinning abstraction function; r=gerald
...
This function is arguably nicer than calling NS_ProcessNextEvent
manually, is slightly more efficient, and will enable better auditing
for NS_ProcessNextEvent when we do Quantum DOM scheduling changes.
2017-05-15 09:34:19 -04:00
Andrea Marchesini
13532cc30e
Bug 1359087 - Use IPCBlob in FileHandle - part 2 - FileHandle and IPCBlob, r=janv
2017-05-09 22:35:42 +02:00
Joel Maher
f297f17181
Bug 1339232 - annotate more dom/* moz.build files with BUG_COMPONENT. r=overholt
...
MozReview-Commit-ID: 2HbPxGkrVfv
2017-03-01 08:20:25 -05:00
Kartikaya Gupta
1af1a82edf
Bug 1312319 - Add a NS_INLINE_DECL_PURE_VIRTUAL_REFCOUNTING macro and replace existing pure-virtual AddRef/Release declarations. r=froydnj
...
MozReview-Commit-ID: 5yt3O4Hoois
--HG--
extra : rebase_source : 5dad12cd8400b8a783e8407de874d4b7c75cb645
2017-01-25 14:51:34 -05:00
Kan-Ru Chen
c649cfaa98
Bug 1319271 - Use actor's manager in case actor is already deleted (r=billm)
...
MozReview-Commit-ID: 3Dr2POjqNft
2016-12-13 16:46:33 -08:00
Kan-Ru Chen
f8100451db
Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm
...
We will use the new type for the generated IPDL message handler
prototype to make sure correct error handling method is called.
MozReview-Commit-ID: AzVbApxFGZ0
2016-11-15 04:26:00 +01:00
John Dai
afa50be601
Bug 1294100 - Part 3: Modify Codegen to generate including FakeString's binding files and fix build errors. r=bz
...
--HG--
rename : dom/bindings/BindingUtils.h => dom/bindings/FakeString.h
2016-09-01 18:10:54 +08:00
Kan-Ru Chen
b6d880aca1
Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
...
The patch is generated from following command:
rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,
MozReview-Commit-ID: AtLcWApZfES
--HG--
rename : mfbt/unused.h => mfbt/Unused.h
2016-08-24 14:47:04 +08:00
Andrea Marchesini
60ab8339e0
Bug 1288736 - Add some missing rv.SuppressException(), r=smaug
2016-07-22 16:50:10 +02:00