Tom Prince
5cacb2dfc9
Bug 1509962: [mozrelease] Add mozrelease to in-tree lint config; r=mtabara
...
Differential Revision: https://phabricator.services.mozilla.com/D12975
--HG--
extra : moz-landing-system : lando
2018-12-03 06:44:08 +00:00
Tom Prince
2819b8db83
Bug 1403131: [mozharness] Run lint against tests; r=mtabara
...
Differential Revision: https://phabricator.services.mozilla.com/D10250
--HG--
extra : moz-landing-system : lando
2018-10-30 17:02:10 +00:00
Tom Prince
f777c1d551
Bug 1494091: [mozharness] Lint mozharness package; r=Callek
...
Differential Revision: https://phabricator.services.mozilla.com/D6837
--HG--
extra : moz-landing-system : lando
2018-10-02 18:32:03 +00:00
Tom Prince
bced66e3b0
Bug 1493997: [mozharness] Ensure that `MOZ_TOOLCHAINS` isn't specified if `mach` isn't available; r=ahal
...
Differential Revision: https://phabricator.services.mozilla.com/D6800
--HG--
extra : moz-landing-system : lando
2018-09-25 18:26:10 +00:00
Sylvestre Ledru
d8204af9c6
Bug 1468273 - Add intl/, gfx/ and ipc/ directories in flake8 r=ahal
...
MozReview-Commit-ID: Bw5s51ao3oZ
--HG--
extra : rebase_source : bb6a2cd7e830226444512e5a0db25c7b7ceec8ca
2018-07-17 16:51:15 +02:00
Sylvestre Ledru
6c3c26c3f7
Bug 1468273 - Fix flake8/pep8 issues by hand in gfx/ r=ted
...
MozReview-Commit-ID: BFnq9JpWZxq
--HG--
extra : rebase_source : d56375d1ff0f183f95e0565851191190fe41e34b
2018-06-10 14:15:18 +02:00
Sylvestre Ledru
13b20f9b86
Bug 1468273 - autopep8 on gfx/ r=ted
...
MozReview-Commit-ID: 8j8EU3E08GP
--HG--
extra : rebase_source : 1f38ac0b7283505622cc95a120a0a0d4cea96803
2018-06-10 14:13:44 +02:00
Simon Fraser
1c95120d44
Bug 1468394 mach python-safety command for checking requirements files r=mtabara,tomprince
...
Added `./mach python-safety`, distinct from python-test so it doesn't have
to be run on every CI job - its errors may not depend on the area the push has changed.
Added the python/safety directory to ensure a different Pipfile is used, avoiding
conflicts with python-test.
Differential Revision: https://phabricator.services.mozilla.com/D1825
--HG--
extra : moz-landing-system : lando
2018-06-29 16:56:51 +00:00
Tom Prince
105275c010
No bug: Add `mozharness.mozilla.l10n.locales` to flake8 whitelist; r=Callek
...
Differential Revision: https://phabricator.services.mozilla.com/D1654
2018-06-14 16:15:49 +00:00
Sylvestre Ledru
074273d40e
Bug 1464869 - Add accessible/, js/, mobile/, memory/, mozglue/, security/, testing/mozharness/mozharness/mozilla/testing/ and xpcom/ to the list of checked directory for flake8 r=ahal
...
MozReview-Commit-ID: 5MJZSdHDKo4
--HG--
extra : rebase_source : 024284c1646e9f014aa7fb45bcc7c5d896ffa456
2018-05-26 06:46:11 -07:00
Sylvestre Ledru
8f2319cae3
bug 1463425 - Add more directories to the flake8 list r=ahal
...
MozReview-Commit-ID: JMZQonceq8W
--HG--
extra : rebase_source : 1d8d0218f128dede197fa99e5cba1f0101a80384
2018-05-22 06:26:22 -07:00
Rob Wood
4af496d7f2
Bug 1454466 - Move raptor in-tree; r=ahal
...
MozReview-Commit-ID: AkqbROfvmbu
--HG--
extra : rebase_source : bf30030a333852d6d81c4278e91b1ac9fef237fe
2018-04-16 17:15:38 -04:00
Andrew Halberstadt
0515e13234
Bug 1373368 - [lint] Add support-files to all of the lint configs, r=standard8
...
MozReview-Commit-ID: ChOVmTFTmha
--HG--
extra : rebase_source : 41e4666401cd58b1022aa4eed936987300213b6a
2018-02-16 17:46:46 -05:00
Dave Hunt
057d540744
Bug 1438250 - Make mozunit pip installable; r=ahal
...
MozReview-Commit-ID: BT4ciGT82bp
--HG--
rename : config/mozunit.py => config/mozunit/mozunit/mozunit.py
extra : rebase_source : a68fa4f5dce77ccf7c55184c555bb37b3a876278
2018-03-29 14:18:00 +01:00
Sylvestre Ledru
fa08b7ce18
Bug 1438839 - Add tools/ as part of the whitelist of flake8 r=ahal
...
MozReview-Commit-ID: 3J44Yz7rV63
--HG--
extra : rebase_source : 4a270af9cc6c4fa37aba9f328643c66d165df2c3
extra : histedit_source : 5f092731ec6a420efccefbd850bdc937acd24b85
2018-02-16 11:48:12 +01:00
Andrew Halberstadt
aaea466286
Bug 1436725 - [lint] Remove obsolete eslintvalidate files, r=standard8
...
As the eslintvalidate linters haven't been doing anything but printing
an error message for a month, this is just cleanup.
MozReview-Commit-ID: 5dhrSmEv0Gi
--HG--
extra : rebase_source : 30e588f47a69b152f72d29e6aaab7efbd59fbf09
2018-02-08 09:25:14 -05:00
Andrew Halberstadt
eb84bf741c
Bug 1429457 - [mozlint] Create formal 'setup' mechanism for bootstrapping lint dependencies, r=gbrown
...
This allows linters to define a 'setup' method which will automatically be
called by |mach lint| before running the linter. Users can also explicitly run
these methods (without doing any actual linting) by running |mach lint --setup|.
MozReview-Commit-ID: 74aY1pfsaX1
--HG--
extra : rebase_source : e6a7d769ba14c996c7a77316928063fa46358c5a
2018-01-25 13:40:02 -05:00
Tom Prince
946b7e38eb
Bug 1430316: Lint the mozharness configs; r=jlund
...
Differential Revision: https://phabricator.services.mozilla.com/D385
--HG--
extra : rebase_source : c4c6e2a4c28c29cc6906d2b757063ef38ac2209a
2018-01-12 16:54:17 -07:00
Tom Prince
24b745390b
Bug 1424967: Fix remaining lint error in upload_symbols.py; r=ted.mielczarek
...
MozReview-Commit-ID: LsvBXNy1SA6
--HG--
extra : rebase_source : a799e7907dd1fe21f3f5a4996b1ee83ba8f314e7
2017-12-12 22:42:23 -07:00
Noemi Erli
8e22628788
Backed out 2 changesets (bug 1424967) for f8 lint failures in /builds/worker/checkouts/gecko/toolkit/crashreporter/tools/upload_symbols.py:78:5 on a CLOSED TREE
...
Backed out changeset 02a7d3b84dcd (bug 1424967)
Backed out changeset e027f4bf3ed2 (bug 1424967)
2018-01-17 02:07:20 +02:00
Tom Prince
507b5088d1
Bug 1424967: Fix remaining lint error in upload_symbols.py; r=ted.mielczarek
...
MozReview-Commit-ID: LsvBXNy1SA6
--HG--
extra : rebase_source : 265b83adbb75eb644bcd530169a4e32c943008c1
2017-12-12 22:42:23 -07:00
Tom Prince
739a0defb2
Bug 1427213: Clean up docstrings in mozpack.path; r=glandium
...
MozReview-Commit-ID: 91cm9XJROy0
--HG--
extra : rebase_source : 1ab1ce1063096651f9095fd221656c852b6892d8
2017-12-27 15:57:32 -07:00
Andrew Halberstadt
0e697ce235
Bug 1422302 - Create python/mozterm for sharing terminal blessings across modules r=gps
...
This is a new module that will provide a place to store some common
abstractions around the 'blessings' module. The main entrypoint is:
from mozterm import Terminal
term = Terminal()
If blessings is available, this will return a blessings.Terminal()
object. If it isn't available, or something went wrong on import,
this will return a NullTerminal() object, which is a drop-in
replacement that does no formatting.
MozReview-Commit-ID: 6c63svm4tM5
--HG--
extra : rebase_source : 9ab221774d92a418d9b098d79bb2c88f75d937f8
2017-12-04 09:38:24 -05:00
Tom Prince
615d82c39d
Bug 1421162: Remove some dead mozharness `mar` code; r=jlund
...
MozReview-Commit-ID: JvkQ713z1eW
--HG--
extra : rebase_source : 25329f9d189cc1ca1c5823bfa0c15966417ff841
extra : source : d768123592505cb15bcb03f86b62e244c066626a
2017-11-27 22:50:31 -07:00
Attila Craciun
a323e78c2b
Merge mozilla-central to mozilla-inbound. r=merge a=merge CLOSED TREE
2017-10-25 12:36:59 +03:00
Steve Armand
df510b4622
Bug 1403131 - Run linters against mozharness scripts and configs. r=rail
...
MozReview-Commit-ID: 3dkx1SQiIns
--HG--
extra : rebase_source : 45f049032243b8bbae7d052a89cefcdb2b7e1f60
2017-10-24 20:21:41 -04:00
Sylvestre Ledru
e0bda6ceaf
Bug 1410938 - Make mach_commands.py flake8/pep8 compatible and add it the list of flake8 files r=gps
...
MozReview-Commit-ID: HKWsDehR0vZ
--HG--
extra : rebase_source : 1e77f8aee5f909dd7b4cfaace6014015c51cf589
2017-10-23 18:40:22 +02:00
Sebastian Hengst
a79a507dc2
Backed out changeset 6fa6cfe0199c (bug 1403131) for mass reftest failures. r=backout on a CLOSED TREE
...
--HG--
extra : amend_source : 4d399778793d9239e5c441fe237a15d12c4f1360
2017-10-23 16:39:24 +02:00
Steve Armand
3be377b84e
Bug 1403131 - Run linters against mozharness scripts and configs. r=rail
...
--HG--
extra : rebase_source : 4d9458f1819de0a73af9191d560557ab01ffa32e
extra : histedit_source : 1a3c743a9a1c6a3304e4a924be90164fcf882e1f%2C440a79ff12f256a2a79aff6b592fe838c1c9e6e3
2017-10-23 09:46:15 -04:00
Steve Armand
82b69a173f
Bug 1408365 - Enable flake8/py2/py3 linters on python/mozboot. r=ahal
...
MozReview-Commit-ID: 3koZq509bjP
--HG--
extra : rebase_source : 9accfc2b727fd7c1f4fad97d1a244d62f4fae714
2017-10-13 23:33:00 -04:00
Sylvestre Ledru
358507fde2
Bug 1406650 - Make build/*.py and a few other files flake8 compatible and add them to the list of files to check r=chmanchester
...
MozReview-Commit-ID: icmFJtbWdN
--HG--
extra : rebase_source : 7b2ef783822bcad7f955bad8cbd6cea6df588f92
2017-10-07 16:45:22 +02:00
Sylvestre Ledru
816ba0c177
Bug 1406668 - Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium
...
MozReview-Commit-ID: 89NxxGUVjHV
--HG--
extra : rebase_source : 278ceb2d7d31da086216288bd54688fe25faa03b
2017-10-12 15:22:59 +02:00
Sebastian Hengst
3980c1732a
Backed out changeset 4dc78384cb58 (bug 1406668) for flake8 linting failures. r=backout
...
--HG--
extra : rebase_source : 20f93207038c76e2804f255e4ebfdd5e03a8f7cc
2017-10-12 15:08:35 +02:00
Sylvestre Ledru
a102c9f46a
Bug 1406668 - Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium
...
MozReview-Commit-ID: 89NxxGUVjHV
--HG--
extra : rebase_source : 658301cb32e9c042cd1931456e4e7b8f475900bd
2017-10-11 16:28:29 +02:00
Sebastian Hengst
7a40cdf1bb
Backed out changeset b526011049ee (bug 1406668) for linting failures. r=backout
...
--HG--
extra : amend_source : fe8373f9572300c7fd090f529c6957fbf905d9ef
2017-10-12 14:41:28 +02:00
Sylvestre Ledru
4e4de3339f
Bug 1406668 - Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium
...
MozReview-Commit-ID: 89NxxGUVjHV
--HG--
extra : rebase_source : 3d22007ea6793961e7031603efe58cdc66e3c6c9
2017-10-11 16:28:29 +02:00
Sylvestre Ledru
20dc07df5f
Bug 1406672 - check_macroassembler_style.py: add to the list of file to check r=ahal
...
MozReview-Commit-ID: 8BzsrTLcEY6
--HG--
extra : rebase_source : 7b01271fed086771df1720665ad1532ef8252812
2017-10-11 16:15:18 +02:00
Sylvestre Ledru
d1799c5b65
Bug 1406669 - Add the .configure extension to flake8 support r=ahal
...
MozReview-Commit-ID: ErnYnQMv5pj
--HG--
extra : rebase_source : 0ee34dd517f735220a950c1a1df1213625d7e417
2017-10-11 16:03:32 +02:00
Sylvestre Ledru
61e0724a88
Bug 1406666 - Add testing/*cppun*.py to the list of flake8 compliant code r=ahal
...
MozReview-Commit-ID: KWsXMRgy4XG
--HG--
extra : rebase_source : b6e82fcd6f5dfb9f823ac5d00c623387b7e95632
2017-10-07 19:45:12 +02:00
Andrew Halberstadt
8dd527bf64
Bug 1401309 - Add python/mozversioncontrol to flake8 linter, r=gps
...
MozReview-Commit-ID: KuyEYa3Mbgd
--HG--
extra : rebase_source : cd3c111432de83d19004946c491f10959fd6d675
2017-09-20 10:02:26 -04:00
Steve Armand
d11ffd18db
Bug 1399989 - Add python/mach to flake8 linter. r=gps
...
MozReview-Commit-ID: KKnBgYFwpfT
--HG--
extra : rebase_source : 4e4b3453a91970366dba0073853ad3ab62738c81
2017-09-17 22:41:17 -04:00
Steve Armand
5d8117b9de
Bug 1397852 - Enable flake8 linter on testing/xpcshell. r=ahal
...
MozReview-Commit-ID: CvZVXQPx8jF
--HG--
extra : rebase_source : 359f148397ef5584028e343080c6774407f74db6
2017-09-14 09:51:27 -04:00
Andrew Halberstadt
3c2a0965ed
Bug 1391019 - Move tools/lint/flake_/__init__.py to tools/lint/python/flake8.py, r=gps
...
This will allow us keep python related linting files in the same place.
MozReview-Commit-ID: ABtq9dnPo9T
--HG--
rename : tools/lint/flake8_/__init__.py => tools/lint/python/__init__.py
rename : tools/lint/flake8_/__init__.py => tools/lint/python/flake8.py
rename : tools/lint/flake8_/flake8_requirements.txt => tools/lint/python/flake8_requirements.txt
extra : rebase_source : 2568bc0bf8f4adbf8e0be73a54d5da068a8d81b0
2017-08-31 10:06:08 -04:00
Andrew Halberstadt
74afe80557
Bug 1339178 - Add python/mach_commands.py and config/mozunit.py to flake8 linter, r=davehunt
...
MozReview-Commit-ID: Gcsz6z8MeOi
--HG--
extra : rebase_source : 121c9007d336cecbd068075dc54d66cc06e8334e
2017-08-29 14:41:38 -04:00
Andrew Halberstadt
2255a9eed7
Bug 1395126 - Support cascading configuration for flake8, r=bc
...
This allows .flake8 files to override one another, and fixes a pretty bad known
bug with our flake8 implementation. For example, say we have a .flake8 file at:
/foo/.flake8
Before this patch, if we ran |mach lint foo/bar|, the configuration defined in
that .flake8 file wouldn't get picked up. It would only work if running the
specific directory that contains it, e.g |mach lint foo|.
This change additionally allows multiple .flake8 files to be used. So if
there's one defined at both:
/.flake8
/foo/.flake8
Then running |mach lint foo/bar| will first apply the root .flake8, then the
one under /foo (overriding earlier configuration).
This bug still doesn't make flake8 configuration perfect though. Any directory
containing a .flake8 file still needs to be explicitly listed in the "include"
section of /tools/lint/flake8.yml. Otherwise in the example above, if running
|mach lint /|, it wouldn't be able to find /foo/.flake8. This is a hard problem
and is likely best solved by fixing flake8's upstream configuration handling.
Unfortunately this means we still can't switch from a whitelist to a blacklist.
MozReview-Commit-ID: 3DZAi1QHYYo
--HG--
extra : rebase_source : 51298c5847f6c2792581d9b312c87b70fa716ee1
2017-08-29 17:32:31 -04:00
Andrew Halberstadt
57303dc36f
Bug 1311991 - Add testing/mach_commands.py to flake8 linter, r=gps
...
This was mostly generated with autopep8 v1.3.2. A few left over errors
were fixed by hand.
MozReview-Commit-ID: 5crfUz0xj3O
--HG--
extra : rebase_source : 1fa9f550dbdca35ce4f2d8f9848dc3061b7fe01b
2017-08-17 15:50:39 -04:00
Justin Wood
20a660940c
Bug 1387862 - Lint the linter config yaml files themselves. r=ahal
...
We should have CI Lint YAML files in the tree.
MozReview-Commit-ID: F8hTBerSNIj
--HG--
extra : rebase_source : 87f84b855f29b5625bacae5c199d99d144c02bc8
2017-08-06 13:47:03 -04:00
Sebastian Hengst
ce4158f736
Backed out changeset 57176d7ff82a (bug 1387862)
2017-08-10 14:29:37 +02:00
Justin Wood
1a5e403ed2
Bug 1387862 - Lint the linter config yaml files themselves. r=ahal
...
We should have CI Lint YAML files in the tree.
MozReview-Commit-ID: F8hTBerSNIj
--HG--
extra : rebase_source : 2d1d3d8d98fd3f0abe3494c49ad01072181c4e08
2017-08-06 13:47:03 -04:00
Ryan VanderMeulen
24396489e3
Backed out 7 changesets (bug 1387862) for yaml linting failures.
...
Backed out changeset 63f87f6db7d6 (bug 1387862)
Backed out changeset a85b7e7d9f24 (bug 1387862)
Backed out changeset 3713ea9672e8 (bug 1387862)
Backed out changeset 22c1094e387f (bug 1387862)
Backed out changeset e0bfb35b0eec (bug 1387862)
Backed out changeset 5bb5dc7655ec (bug 1387862)
Backed out changeset cc4c01794114 (bug 1387862)
2017-08-09 21:31:30 -04:00