C5038 is a new warning in VS2017, similar to gcc and clang's -Wreorder, which is enabled by -Wall. We should enable C5038 so Windows developers can see these warnings locally instead of when gcc and clang fail with warnings-as-errors on Try.
https://blogs.msdn.microsoft.com/vcblog/2017/07/21/diagnostic-improvements-in-vs2017-15-3-0/
We need to suppress C5038 warnings from Windows Runtime Library header files (wrl.h) included in ANGLE and widget/windows:
z:\build\build\src\vs2017_15.4.2\SDK\Include\10.0.15063.0\winrt\wrl\wrappers\corewrappers.h(515): error C5038: data member 'Microsoft::WRL::Wrappers::Details::SyncLockWithStatusT<Microsoft::WRL::Wrappers::HandleTraits::SemaphoreTraits>::sync_' will be initialized after data member 'Microsoft::WRL::Wrappers::Details::SyncLockWithStatusT<Microsoft::WRL::Wrappers::HandleTraits::SemaphoreTraits>::status_'
...
And suppress C5038 warnings in upstream webrtc code:
media/webrtc/trunk/webrtc/modules/video_capture/windows/BaseFilter.cpp(176): error C5038: data member 'mozilla::media::BaseFilter::mClsId' will be initialized after data member 'mozilla::media::BaseFilter::mState'
media/webrtc/trunk/webrtc/modules/video_capture/windows/BasePin.cpp(169): error C5038: data member 'mozilla::media::BasePin::mFilter' will be initialized after data member 'mozilla::media::BasePin::mLock'
media/webrtc/trunk/webrtc/modules/video_capture/windows/BasePin.cpp(170): error C5038: data member 'mozilla::media::BasePin::mLock' will be initialized after data member 'mozilla::media::BasePin::mName'
media/webrtc/trunk/webrtc/modules/video_capture/windows/BasePin.cpp(172): error C5038: data member 'mozilla::media::BasePin::mDirection' will be initialized after data member 'mozilla::media::BasePin::mQualitySink'
MozReview-Commit-ID: BMDVkvQXNoq
--HG--
extra : rebase_source : 0d5ede9530d0d0750b8fffdc1cdfdc646ec8f22a
It's illegal to use a method of a forward declared class
libANGLE/renderer/d3d/d3d11/renderer11_utils.h:207:31: error: invalid use of incomplete type 'class rx::Renderer11'
ANGLE_TRY(renderer->allocateResource(desc, initData, &mResource));
However we cannot simply include Renderer11.h because Renderer11.h includes renderer11_utils.h
If we put the LazyX classes into Renderer11.h however, we can
change the include on the few places they are used with minimal impact.
MozReview-Commit-ID: 8Wf4Xbi7vAP
--HG--
extra : rebase_source : 984601e08f88342c8f5b75f9d43af3e666598855
Bug 1363216 - Turn off std::future for MinGW.
Bug 1331335 - Add SSE2 Flags to all of libANGLE.
Bug 1364169 - on ANGLE context creation asks for robustness but does not get it.
Bug 1370865 - Suppress more MSVC warnings in gfx/angle.
Bug 1373525 - gfx/angle: Suppress -Wimplicit-fallthrough warnings in third-party code.
Bug 1347866 - Part3: ANGLE patch uplift for bug1325733.
Bug 1347866 - Part4: ANGLE patch uplift for bug1325741.
Bug 1322746 - Add general ID3D11Texture2D to EGLStream support to ANGLE.
Bug 1366425 - Avoid losing context on out of memory error for ANGLE.
--HG--
extra : source : 9aa8f8c7fe616638dd496bdf771d158586732056
Bug 1363216 - Turn off std::future for MinGW.
Bug 1331335 - Add SSE2 Flags to all of libANGLE.
Bug 1364169 - on ANGLE context creation asks for robustness but does not get it.
Bug 1370865 - Suppress more MSVC warnings in gfx/angle.
Bug 1373525 - gfx/angle: Suppress -Wimplicit-fallthrough warnings in third-party code.
Bug 1347866 - Part3: ANGLE patch uplift for bug1325733.
Bug 1347866 - Part4: ANGLE patch uplift for bug1325741.
Bug 1322746 - Add general ID3D11Texture2D to EGLStream support to ANGLE.
Bug 1366425 - Avoid losing context on out of memory error for ANGLE.
--HG--
extra : rebase_source : 2d422e188797b07194b8df0f0f1f3fd435c710e4
XPCOM's string API doesn't have the notion of a "null string". But it does have
the notion of a "void string" (or "voided string"), and that's what these
functions are returning. So the names should reflect that.
--HG--
extra : rebase_source : 4e3f982e0873877174a08a25413595ff66f7d20e
MinGW doesn't support std::thread without an emulation library (See Bug 1349912)
We haven't integrated that (yet) so disable std::future for Angle until we do.
MozReview-Commit-ID: 7hxDL3QURdW
--HG--
extra : rebase_source : 152d1b88e602b430a4eaf4e5212f90d756ca8a46
This patch has a few parts to make this work:
1) more tests pass on ubuntu 16, so remove old fail-if conditions
2) no support for GL_ARB_gpu_shader5, we cherry pick from updated ANGLE code
3) disable test_capture.html as it leaks on ASAN
MozReview-Commit-ID: BSSiTFvF9jN
Chris Peterson
Chih-Yi Leu
Tom Ritter
Chris Manchester
sotaro
Chih-Yi Leu
Sebastian Hengst
Nicholas Nethercote
Jeff Gilbert
Samuel Vargas
Masatoshi Kimura
Wes Kocher
Petr Cerny
Milan Sreckovic
Joel Maher
Edwin Flores
Ethan Lin