In bug 1804140, we shipped SHIP everywhere on desktop. Unfortunately, we
never removed the now-dead code from SessionStore.
This patch removes the easy to identify SessionStore code for non-SHIP,
now that it is a fully unsupported configuration.
Differential Revision: https://phabricator.services.mozilla.com/D205479
Patch invokes `import-rollouts` script that import Nimbus Rollout messages into NimbusRolloutMessageProvider.sys.mjs when running test using ` ./mach npm run test --prefix browser/components/asrouter`
Differential Revision: https://phabricator.services.mozilla.com/D205777
This patch adds code for using the JitEntry mechanism for native builtins.
The TrampolineNative JSJitInfo mechanism is very similar to what we do for
InlinableNative. For each trampoline native, a JIT trampoline is generated and
we use this as the function's JitEntry when creating the native JSFunction.
Differential Revision: https://phabricator.services.mozilla.com/D204625
As chromium is no longer used and chromium as release is replacing it, we are removing all references to it to not confuse people
Differential Revision: https://phabricator.services.mozilla.com/D204821
This patch adds a new category for the tp6-bench test called `Pageload Lite` that will provie a minimum set of tests that should be run for checking pageload performance.
Differential Revision: https://phabricator.services.mozilla.com/D203820
The bulk of these fixes were done by applying a patch from `shellcheck -f diff`. The changes that weren't are:
* The setting of the default interpreter
* The new `product` argument needed to fix some undefined variable errors
* Any places where we're ignoring errors (because we're relying on the flagged behaviour for functionality)
* Dead code removal (eg: `MY_DIR` in some places)
Remaining errors are being dealt with in subsequent patches.
For posterity, these are the errors that got fixed:
In cached_download.sh line 1:
^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
In cached_download.sh line 5:
pushd `dirname $0` &>/dev/null
^----------------------------^ SC2164 (warning): Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails.
^----------^ SC2046 (warning): Quote this to prevent word splitting.
^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
pushd $(dirname "$0") &>/dev/null || exit
In cached_download.sh line 7:
popd &>/dev/null
^--------------^ SC2164 (warning): Use 'popd ... || exit' or 'popd ... || return' in case popd fails.
Did you mean:
popd &>/dev/null || exit
In cached_download.sh line 15:
rm -rf "${cache_dir}/*"
^--------------^ SC2115 (warning): Use "${var:?}" to ensure this never expands to /* .
In cached_download.sh line 23:
if fgrep -x "${url}" "${cache_dir}/urls.list" >/dev/null; then
^---^ SC2197 (info): fgrep is non-standard and deprecated. Use grep -F instead.
In cached_download.sh line 25:
local line_number="$(fgrep -nx "${url}" "${cache_dir}/urls.list" | sed 's/:.*//')"
^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
^---^ SC2197 (info): fgrep is non-standard and deprecated. Use grep -F instead.
In cached_download.sh line 30:
$retry wget -O "${output_file}" --progress=dot:giga --server-response "${url}" 2>&1
^----^ SC2154 (warning): retry is referenced but not assigned.
In cached_download.sh line 34:
local line_number="$(fgrep -nx "${url}" "${cache_dir}/urls.list" | sed 's/:.*//')"
^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
^---^ SC2197 (info): fgrep is non-standard and deprecated. Use grep -F instead.
In check_updates.sh line 1:
check_updates () {
^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
In check_updates.sh line 25:
unpack_build $update_platform source "$source_package" $locale '' "$mar_channel_IDs" $mac_update_settings_dir_override
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
unpack_build "$update_platform" source "$source_package" "$locale" '' "$mar_channel_IDs" "$mac_update_settings_dir_override"
In check_updates.sh line 26:
if [ "$?" != "0" ]; then
^--^ SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
In check_updates.sh line 37:
unpack_build $update_platform target "$target_package" $locale '' '' $mac_update_settings_dir_override
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
unpack_build "$update_platform" target "$target_package" "$locale" '' '' "$mac_update_settings_dir_override"
In check_updates.sh line 38:
if [ "$?" != "0" ]; then
^--^ SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
In check_updates.sh line 51:
platform_dirname=`echo $product | tr '[A-Z]' '[a-z]'`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^------^ SC2154 (warning): product is referenced but not assigned.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----^ SC2021 (info): Don't use [] around classes in tr, it replaces literal square brackets.
^-----^ SC2021 (info): Don't use [] around classes in tr, it replaces literal square brackets.
Did you mean:
platform_dirname=$(echo "$product" | tr '[A-Z]' '[a-z]')
In check_updates.sh line 58:
if [ -d source/$platform_dirname ]; then
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -d source/"$platform_dirname" ]; then
In check_updates.sh line 59:
if [ `uname | cut -c-5` == "MINGW" ]; then
^----------------^ SC2046 (warning): Quote this to prevent word splitting.
^----------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
if [ $(uname | cut -c-5) == "MINGW" ]; then
In check_updates.sh line 62:
four_backslash_pwd=$(echo $PWD | sed -e 's,^/\([a-zA-Z]\)/,\1:/,' | sed -e 's,/,\\\\,g')
^----------------^ SC2034 (warning): four_backslash_pwd appears unused. Verify use (or export if used externally).
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
four_backslash_pwd=$(echo "$PWD" | sed -e 's,^/\([a-zA-Z]\)/,\1:/,' | sed -e 's,/,\\\\,g')
In check_updates.sh line 63:
two_backslash_pwd=$(echo $PWD | sed -e 's,^/\([a-zA-Z]\)/,\1:/,' | sed -e 's,/,\\,g')
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
two_backslash_pwd=$(echo "$PWD" | sed -e 's,^/\([a-zA-Z]\)/,\1:/,' | sed -e 's,/,\\,g')
In check_updates.sh line 69:
cwd=$(ls -d $PWD/source/$platform_dirname)
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cwd=$(ls -d "$PWD"/source/"$platform_dirname")
In check_updates.sh line 73:
cd_dir=$(ls -d ${PWD}/source/${platform_dirname})
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cd_dir=$(ls -d "${PWD}"/source/"${platform_dirname}")
In check_updates.sh line 74:
cd "${cd_dir}"
^------------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
Did you mean:
cd "${cd_dir}" || exit
In check_updates.sh line 85:
update_status=`cat update/update.status`
^------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
update_status=$(cat update/update.status)
In check_updates.sh line 102:
cd `echo "source/$platform_dirname"`
^-- SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
^-- SC2046 (warning): Quote this to prevent word splitting.
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-- SC2116 (style): Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'.
Did you mean:
cd $(echo "source/$platform_dirname") || exit
In check_updates.sh line 108:
cd `echo "target/$platform_dirname"`
^-- SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
^-- SC2046 (warning): Quote this to prevent word splitting.
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-- SC2116 (style): Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'.
Did you mean:
cd $(echo "target/$platform_dirname") || exit
In check_updates.sh line 140:
../compare-directories.py source/${platform_dirname} target/${platform_dirname} ${channel} ${ignore_coderesources} > "${diff_file}"
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
../compare-directories.py source/"${platform_dirname}" target/"${platform_dirname}" "${channel}" "${ignore_coderesources}" > "${diff_file}"
In download_builds.sh line 1:
pushd `dirname $0` &>/dev/null
^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
^----------------------------^ SC2164 (warning): Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails.
^----------^ SC2046 (warning): Quote this to prevent word splitting.
^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
pushd $(dirname "$0") &>/dev/null || exit
In download_builds.sh line 3:
popd &>/dev/null
^--------------^ SC2164 (warning): Use 'popd ... || exit' or 'popd ... || return' in case popd fails.
Did you mean:
popd &>/dev/null || exit
In download_builds.sh line 4:
retry="$MY_DIR/../../../../mach python -m redo.cmd -s 1 -a 3"
^---^ SC2034 (warning): retry appears unused. Verify use (or export if used externally).
In download_builds.sh line 16:
"download_builds usage: <source_url> <target_url>"
^-- SC2288 (warning): This is interpreted as a command name ending with '>'. Double check syntax.
In download_builds.sh line 22:
source_file=`basename "$url"`
^---------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
source_file=$(basename "$url")
In download_builds.sh line 24:
cd downloads
^----------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
Did you mean:
cd downloads || exit
In download_mars.sh line 1:
download_mars () {
^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
In download_mars.sh line 26:
try=$(($try+1))
^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
In download_mars.sh line 31:
update_line=`fgrep "<update " update.xml`
^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^---^ SC2197 (info): fgrep is non-standard and deprecated. Use grep -F instead.
Did you mean:
update_line=$(fgrep "<update " update.xml)
In download_mars.sh line 37:
command=`echo $update_line | sed -e 's/^.*<update //' -e 's:>.*$::' -e 's:\&:\&:g'`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
command=$(echo "$update_line" | sed -e 's/^.*<update //' -e 's:>.*$::' -e 's:\&:\&:g')
In download_mars.sh line 56:
if [ -z $only ]; then
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -z "$only" ]; then
In download_mars.sh line 61:
line=`fgrep "patch type=\"$patch_type" update.xml`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^---^ SC2197 (info): fgrep is non-standard and deprecated. Use grep -F instead.
Did you mean:
line=$(fgrep "patch type=\"$patch_type" update.xml)
In download_mars.sh line 69:
command=`echo $line | sed -e 's/^.*<patch //' -e 's:/>.*$::' -e 's:\&:\&:g'`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
command=$(echo "$line" | sed -e 's/^.*<patch //' -e 's:/>.*$::' -e 's:\&:\&:g')
In download_mars.sh line 75:
curl -s -I -L $URL
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
curl -s -I -L "$URL"
In download_mars.sh line 80:
if [ "$?" != 0 ]; then
^--^ SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
In download_mars.sh line 84:
actual_size=`perl -e "printf \"%d\n\", (stat(\"update/$patch_type.mar\"))[7]"`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
actual_size=$(perl -e "printf \"%d\n\", (stat(\"update/$patch_type.mar\"))[7]")
Did you mean:
actual_hash=$(openssl dgst -"$hashFunction" update/"$patch_type".mar | sed -e 's/^.*= //')
In download_mars.sh line 87:
if [ $actual_size != $size ]; then
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$actual_size" != "$size" ]; then
In download_mars.sh line 94:
if [ $actual_hash != $hashValue ]; then
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$actual_hash" != "$hashValue" ]; then
In download_mars.sh line 101:
cp update/$patch_type.mar update/update.mar
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cp update/"$patch_type".mar update/update.mar
In download_mars.sh line 102:
echo $actual_size > update/$patch_type.size
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$actual_size" > update/"$patch_type".size
In unpack-diskimage.sh line 56:
if [ -d $MOUNTPOINT ]; then
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -d "$MOUNTPOINT" ]; then
In unpack-diskimage.sh line 58:
hdiutil detach $MOUNTPOINT -force
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
hdiutil detach "$MOUNTPOINT" -force
In unpack-diskimage.sh line 59:
rm -rdfv $MOUNTPOINT
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -rdfv "$MOUNTPOINT"
In unpack-diskimage.sh line 63:
trap "{ if [ -d $MOUNTPOINT ]; then hdiutil detach $MOUNTPOINT -force; rm -rdfv $MOUNTPOINT; fi; }" EXIT
^---------^ SC2064 (warning): Use single quotes, otherwise this expands now rather than when signalled.
^---------^ SC2064 (warning): Use single quotes, otherwise this expands now rather than when signalled.
^---------^ SC2064 (warning): Use single quotes, otherwise this expands now rather than when signalled.
In unpack-diskimage.sh line 65:
mkdir -p $MOUNTPOINT
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "$MOUNTPOINT"
In unpack-diskimage.sh line 67:
hdiutil attach -verbose -noautoopen -mountpoint $MOUNTPOINT "$DMG_PATH" &> $LOGFILE
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
hdiutil attach -verbose -noautoopen -mountpoint "$MOUNTPOINT" "$DMG_PATH" &> $LOGFILE
In unpack-diskimage.sh line 73:
while [ "$(echo $MOUNTPOINT/*)" == "$MOUNTPOINT/*" ]; do
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
while [ "$(echo "$MOUNTPOINT"/*)" == "$MOUNTPOINT/*" ]; do
In unpack-diskimage.sh line 74:
if [ $i -gt $TIMEOUT ]; then
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$i" -gt $TIMEOUT ]; then
In unpack-diskimage.sh line 79:
i=$(expr $i + 1)
^--^ SC2003 (style): expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]].
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
i=$(expr "$i" + 1)
In unpack-diskimage.sh line 82:
rsync -av $MOUNTPOINT/* $MOUNTPOINT/.DS_Store $MOUNTPOINT/.background $MOUNTPOINT/.VolumeIcon.icns $TARGETPATH/ > $LOGFILE
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rsync -av "$MOUNTPOINT"/* "$MOUNTPOINT"/.DS_Store "$MOUNTPOINT"/.background "$MOUNTPOINT"/.VolumeIcon.icns "$TARGETPATH"/ > $LOGFILE
In unpack-diskimage.sh line 84:
hdiutil detach $MOUNTPOINT || { sleep 10; \
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
hdiutil detach "$MOUNTPOINT" || { sleep 10; \
In unpack-diskimage.sh line 85:
if [ -d $MOUNTPOINT ]; then hdiutil detach $MOUNTPOINT -force; fi; }
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -d "$MOUNTPOINT" ]; then hdiutil detach "$MOUNTPOINT" -force; fi; }
In unpack-diskimage.sh line 87:
while [ "$(echo $MOUNTPOINT/*)" != "$MOUNTPOINT/*" ]; do
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
while [ "$(echo "$MOUNTPOINT"/*)" != "$MOUNTPOINT/*" ]; do
In unpack-diskimage.sh line 88:
if [ $i -gt $TIMEOUT ]; then
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$i" -gt $TIMEOUT ]; then
In unpack-diskimage.sh line 93:
i=$(expr $i + 1)
^--^ SC2003 (style): expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]].
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
i=$(expr "$i" + 1)
In unpack-diskimage.sh line 95:
rm -rdf $MOUNTPOINT
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -rdf "$MOUNTPOINT"
In unpack.sh line 4:
hdiutil detach ${DEV_NAME} ||
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
hdiutil detach "${DEV_NAME}" ||
In unpack.sh line 5:
{ sleep 5 && hdiutil detach ${DEV_NAME} -force; };
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
{ sleep 5 && hdiutil detach "${DEV_NAME}" -force; };
In unpack.sh line 6:
return $1 && $?;
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
Did you mean:
return "$1" && $?;
In unpack.sh line 26:
mkdir -p $dir_name
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "$dir_name"
In unpack.sh line 27:
pushd $dir_name > /dev/null
^-------------------------^ SC2164 (warning): Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
pushd "$dir_name" > /dev/null || exit
In unpack.sh line 33:
os=`uname`
^-----^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
os=$(uname)
In unpack.sh line 39:
../common/unpack-diskimage.sh "$pkg_file" mnt $dir_name
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
../common/unpack-diskimage.sh "$pkg_file" mnt "$dir_name"
In unpack.sh line 42:
if [ `ls -1 | wc -l` -ne 1 ]
^-------------^ SC2046 (warning): Quote this to prevent word splitting.
^-------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^---^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.
Did you mean:
if [ $(ls -1 | wc -l) -ne 1 ]
In unpack.sh line 52:
appdir=$(ls -d *.app)
^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.
In unpack.sh line 77:
if [ $(find optional/ | wc -l) -gt 1 ]
^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
In unpack.sh line 90:
unzip -o $file > /dev/null
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
unzip -o "$file" > /dev/null
In unpack.sh line 92:
unzip -o ${locale}.xpi > /dev/null
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
unzip -o "${locale}".xpi > /dev/null
In unpack.sh line 97:
if `echo $pkg_file | grep -q "tar.gz"`
^-- SC2092 (warning): Remove backticks to avoid executing output (or use eval if intentional).
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if $(echo "$pkg_file" | grep -q "tar.gz")
In unpack.sh line 100:
elif `echo $pkg_file | grep -q "tar.bz2"`
^-- SC2092 (warning): Remove backticks to avoid executing output (or use eval if intentional).
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
elif $(echo "$pkg_file" | grep -q "tar.bz2")
In unpack.sh line 107:
update_settings_file=`echo $product | tr '[A-Z]' '[a-z]'`'/update-settings.ini'
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----^ SC2021 (info): Don't use [] around classes in tr, it replaces literal square brackets.
^-----^ SC2021 (info): Don't use [] around classes in tr, it replaces literal square brackets.
Did you mean:
update_settings_file=$(echo "$product" | tr '[A-Z]' '[a-z]')'/update-settings.ini'
In unpack.sh line 114:
if [ ! -z $unpack_jars ]; then
^-- SC2236 (style): Use -n instead of ! -z.
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ ! -z "$unpack_jars" ]; then
In unpack.sh line 115:
for f in `find . -name '*.jar' -o -name '*.ja'`; do
^-- SC2044 (warning): For loops over find output are fragile. Use find -exec or a while read loop.
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
for f in $(find . -name '*.jar' -o -name '*.ja'); do
In unpack.sh line 120:
if [ ! -z $update_settings_string ]; then
^-- SC2236 (style): Use -n instead of ! -z.
^---------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ ! -z "$update_settings_string" ]; then
In unpack.sh line 122:
cat "${update_settings_file}" | sed -e "s/^ACCEPTED_MAR_CHANNEL_IDS.*/ACCEPTED_MAR_CHANNEL_IDS=${update_settings_string}/" > "${update_settings_file}.new"
^-----------------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
In unpack.sh line 129:
popd > /dev/null
^--------------^ SC2164 (warning): Use 'popd ... || exit' or 'popd ... || return' in case popd fails.
Did you mean:
popd > /dev/null || exit
In verify.sh line 23:
if [ -e ${diff_summary_log} ]; then
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -e "${diff_summary_log}" ]; then
In verify.sh line 24:
rm ${diff_summary_log}
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm "${diff_summary_log}"
In verify.sh line 26:
touch ${diff_summary_log}
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
touch "${diff_summary_log}"
In verify.sh line 28:
pushd `dirname $0` &>/dev/null
^----------------------------^ SC2164 (warning): Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails.
^----------^ SC2046 (warning): Quote this to prevent word splitting.
^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
pushd $(dirname "$0") &>/dev/null || exit
In verify.sh line 30:
popd &>/dev/null
^--------------^ SC2164 (warning): Use 'popd ... || exit' or 'popd ... || return' in case popd fails.
Did you mean:
popd &>/dev/null || exit
In verify.sh line 85:
pass_arg_count=`expr $pass_arg_count + 1`
^------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]].
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
pass_arg_count=$(expr "$pass_arg_count" + 1)
In verify.sh line 103:
while read entry
^--^ SC2162 (info): read without -r will mangle backslashes.
In verify.sh line 118:
eval $entry
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
eval "$entry"
In verify.sh line 121:
major_version=`echo $release | cut -f1 -d.`
^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
major_version=$(echo "$release" | cut -f1 -d.)
In verify.sh line 123:
minor_version=`echo $release | cut -f2 -d.`
^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
minor_version=$(echo "$release" | cut -f2 -d.)
In verify.sh line 148:
download_mars "${aus_server}/update/3/${update_path}/default/update.xml?force=1" ${patch_type} 1 \
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
download_mars "${aus_server}/update/3/${update_path}/default/update.xml?force=1" "${patch_type}" 1 \
In verify.sh line 152:
download_mars "${aus_server}/update/3/${update_path}/update.xml?force=1" ${patch_type} 0 \
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
download_mars "${aus_server}/update/3/${update_path}/update.xml?force=1" "${patch_type}" 0 \
In verify.sh line 161:
mkdir -p updates/${update_path}/complete
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p updates/"${update_path}"/complete
In verify.sh line 162:
mkdir -p updates/${update_path}/partial
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p updates/"${update_path}"/partial
In verify.sh line 163:
$retry wget -q -O ${patch_type} updates/${update_path}/${patch_type}/update.xml "${aus_server}/update/3/${update_path}/update.xml?force=1"
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
$retry wget -q -O "${patch_type}" updates/"${update_path}"/"${patch_type}"/update.xml "${aus_server}/update/3/${update_path}/update.xml?force=1"
In verify.sh line 174:
updater_package_url=`echo "${ftp_server_from}${updater_package}" | sed "s/%locale%/${locale}/"`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
updater_package_url=$(echo "${ftp_server_from}${updater_package}" | sed "s/%locale%/${locale}/")
In verify.sh line 175:
updater_package_filename=`basename "$updater_package_url"`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
updater_package_filename=$(basename "$updater_package_url")
In verify.sh line 184:
updater_package_url=`echo "${updater_package_url}" | sed "s/ja-JP-mac/ja/"`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-- SC2001 (style): See if you can use ${variable//search/replace} instead.
Did you mean:
updater_package_url=$(echo "${updater_package_url}" | sed "s/ja-JP-mac/ja/")
In verify.sh line 198:
updater_package_url=`echo "${updater_package_url}" | sed "s/ja-JP-mac/ja/"`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-- SC2001 (style): See if you can use ${variable//search/replace} instead.
Did you mean:
updater_package_url=$(echo "${updater_package_url}" | sed "s/ja-JP-mac/ja/")
In verify.sh line 199:
platform_dirname=`echo $product | tr '[A-Z]' '[a-z]'`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----^ SC2021 (info): Don't use [] around classes in tr, it replaces literal square brackets.
^-----^ SC2021 (info): Don't use [] around classes in tr, it replaces literal square brackets.
Did you mean:
platform_dirname=$(echo "$product" | tr '[A-Z]' '[a-z]')
In verify.sh line 222:
cwd=$(\ls -d $PWD/updater/$platform_dirname)
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cwd=$(\ls -d "$PWD"/updater/"$platform_dirname")
In verify.sh line 235:
if [ ! -z "$override_certs" ]; then
^-- SC2236 (style): Use -n instead of ! -z.
In verify.sh line 253:
python3 "${cert_replacer}" "${MY_DIR}/../mar_certs" "${updater}.orig" "${updater}" ${overrides}
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python3 "${cert_replacer}" "${MY_DIR}/../mar_certs" "${updater}.orig" "${updater}" "${overrides}"
In verify.sh line 263:
from_path=`echo $from | sed "s/%locale%/${locale}/"`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-- SC2001 (style): See if you can use ${variable//search/replace} instead.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
from_path=$(echo "$from" | sed "s/%locale%/${locale}/")
In verify.sh line 264:
to_path=`echo $to | sed "s/%locale%/${locale}/"`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-- SC2001 (style): See if you can use ${variable//search/replace} instead.
^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
to_path=$(echo "$to" | sed "s/%locale%/${locale}/")
In verify.sh line 271:
source_file=`basename "$from_path"`
^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
source_file=$(basename "$from_path")
In verify.sh line 272:
target_file=`basename "$to_path"`
^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
target_file=$(basename "$to_path")
In verify.sh line 277:
check_updates "${platform}" "downloads/${source_file}" "downloads/${target_file}" ${locale} ${use_old_updater} ${updater} ${diff_file} ${channel} "${mar_channel_IDs}" ${update_to_dep} ${mac_update_settings_dir_override}
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
check_updates "${platform}" "downloads/${source_file}" "downloads/${target_file}" "${locale}" "${use_old_updater}" "${updater}" ${diff_file} "${channel}" "${mar_channel_IDs}" ${update_to_dep} "${mac_update_settings_dir_override}"
In verify.sh line 289:
if [ -s ${diff_file} ]; then
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ -s "${diff_file}" ]; then
In verify.sh line 290:
echo "Found diffs for ${patch_type} update from ${aus_server}/update/3/${update_path}/update.xml?force=1" >> ${diff_summary_log}
^-- SC2129 (style): Consider using { cmd1; cmd2; } >> file instead of individual redirects.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "Found diffs for ${patch_type} update from ${aus_server}/update/3/${update_path}/update.xml?force=1" >> "${diff_summary_log}"
In verify.sh line 291:
cat ${diff_file} >> ${diff_summary_log}
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cat "${diff_file}" >> "${diff_summary_log}"
In verify.sh line 292:
echo "" >> ${diff_summary_log}
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "" >> "${diff_summary_log}"
In verify.sh line 297:
partial_size=`cat update/partial.size`
^-----------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
partial_size=$(cat update/partial.size)
In verify.sh line 298:
complete_size=`cat update/complete.size`
^------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
complete_size=$(cat update/complete.size)
In verify.sh line 299:
if [ $partial_size -gt $complete_size ]; then
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$partial_size" -gt "$complete_size" ]; then
In verify.sh line 301:
elif [ $partial_size -eq $complete_size ]; then
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
elif [ "$partial_size" -eq "$complete_size" ]; then
In verify.sh line 308:
done < $config_file
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
done < "$config_file"
Differential Revision: https://phabricator.services.mozilla.com/D203989
This patch undoes the changes required for the `--fenix` flag. This will enable fenix tests to be scheduled without supplying an additional flag, and will be visible/schedule-able when only `--android` is supplied.
Differential Revision: https://phabricator.services.mozilla.com/D203649
When we talk about form autocomplete, it could mean "address/credit card autocomplete", "login autocomplete", and
"form history autocomplete. In order to improve code readability, this patch changes the following naming:
1. FormAutoComplete to FormHisotryAutoComplete
2. nsIFormAutoCompleteObserver to nsIFormFillCompleteObserver
- This is because this interface is used by FormFillController, not by
FormHistory
Differential Revision: https://phabricator.services.mozilla.com/D204601
Adds a new chooser section for firefox-android builds and tests. This was easier than trying to add to the existing Build and Test sections ... and might be more convenient for users?
Because some of the test labels depend on the build-type, and that attribute was not being used consistently, I needed to define that attribute for several tasks; I don't think that will affect anything else.
Differential Revision: https://phabricator.services.mozilla.com/D204205
This check was in early versions of D197618, but got lost in a refactoring.
Apparently xpctest idls don't include [noscript] members, so I added some.
Differential Revision: https://phabricator.services.mozilla.com/D204752
* Initial tools/ts setup.
* Mach commands for buidling xpcom related typelibs.
* Mach command for updating the typelib references.
* Mach command for type-checking js projects.
Also included the dom typelib for reference.
Differential Revision: https://phabricator.services.mozilla.com/D197620
This intermittent happens for Test-Verify only, since Bug 1884171 was
merged, that made that the test uses HTTPS connections instead of HTTP.
The properties related to the TCP connection can be missing. If for some
reason it doesn't need to be established (because it already exists most
probably), then they won't be in the resulting marker.
Interestingly, in the test itself this comment was present before:
// These properties are present when a connection is fully opened. This is
// most often the case, unless we're in verify mode, because in that case
// we run the same tests several times in the same Firefox and they might be
// cached, or in chaos mode Firefox may make all requests sequentially on
// the same connection.
// In these cases, these properties won't always be present.
But the test didn't seem do do something special for this, probably
because this was passing for HTTP at that time. But now it may be
that we have different connection heuristics for HTTPS...
After trying to reset the connection before the test, which didn't work,
finally I decided to relax the checks by not checking for these
sometimes-present-sometimes-absent properties for the second stop marker only.
Because we still check them for the first stop marker, we're still
covering them.
The object `expectedConnectionProperties` was containing requestStart,
responseStart and responseEnd, which was incorrect because these ones
are always present, so I moved them also in the process.
Differential Revision: https://phabricator.services.mozilla.com/D204589
Geoff Brown
Adam Brouwers-Harries
Alexandre Lissy
Sandor Molnar
Kelly Cochrane
Iulian Moraru
Mark Banner
Cristian Tuns
Butkovits Atila
Nika Layzell
florin.bilt
Julien Cristau
Punam Dahiya
Luca Greco
Jan de Mooij
Mike Hommey
andrej
Andrew Erickson
Greg Mierzwinski
Heitor Neiva
Cosmin Sabou
Logan Rosen
Paul Adenot
Dave Townsend
Ben Hearsum
Dimi
Gijs Kruitbosch
Tomislav Jovanovic
Nazım Can Altınova
Julien Wajsberg
Malte Juergens