This allows .flake8 files to override one another, and fixes a pretty bad known
bug with our flake8 implementation. For example, say we have a .flake8 file at:
/foo/.flake8
Before this patch, if we ran |mach lint foo/bar|, the configuration defined in
that .flake8 file wouldn't get picked up. It would only work if running the
specific directory that contains it, e.g |mach lint foo|.
This change additionally allows multiple .flake8 files to be used. So if
there's one defined at both:
/.flake8
/foo/.flake8
Then running |mach lint foo/bar| will first apply the root .flake8, then the
one under /foo (overriding earlier configuration).
This bug still doesn't make flake8 configuration perfect though. Any directory
containing a .flake8 file still needs to be explicitly listed in the "include"
section of /tools/lint/flake8.yml. Otherwise in the example above, if running
|mach lint /|, it wouldn't be able to find /foo/.flake8. This is a hard problem
and is likely best solved by fixing flake8's upstream configuration handling.
Unfortunately this means we still can't switch from a whitelist to a blacklist.
MozReview-Commit-ID: 3DZAi1QHYYo
--HG--
extra : rebase_source : 51298c5847f6c2792581d9b312c87b70fa716ee1
In some cases the registration of the frame script takes longer and as
result the page load events for DOMContentLoaded and pageshow are
missed. With that the current command waits forever and causes a page
load timeout error after 300s.
By checking the readyState of the document before the listeners are
getting attached, we can ensure to return immediately if the document
has already been finished loading.
MozReview-Commit-ID: 17f6jVz7sZZ
--HG--
extra : rebase_source : 1cc27fc9bd4d9b4a39607f8d44692dfc7095b2d7
To support webextensions in Puppeteer the current restartless
extension gets replaced by a webextension. It allow us to test
at least the permission notification. This patch only adds basic
support.
MozReview-Commit-ID: FKq76qcOxKu
--HG--
extra : rebase_source : 1dc81e80c43d3ec61f3ff405fa7807a08ab1d45e
Ensure that we only wait for the providers that are enabled (i.e. have active lists) to avoid waiting forever
and timing out.
In order to check whether or not the google and google4 providers are enabled, we look for lists that start
with "goog" in both the V2 files and the V4 files. We use 'goog' here instead of 'goog-' because there are
both 'goog-xxx-xxx' and 'googpub-xxx-xxx' tables
MozReview-Commit-ID: 72JWZRs3Qxd
--HG--
extra : rebase_source : 93e970ab43c22f41962996f4daf1d4e0a9506923
Bug 1370576 disabled staging of application updates, which is not yet
supported in our firefox-ui update tests. As result there is a hang and
the restart button is never clicked on.
This is just a wallpaper fix and full support might still have to
be integrated if wanted.
MozReview-Commit-ID: 8LF1RKxnMEb
--HG--
extra : rebase_source : 5a268cd891a6577eda163c86fe6ef94fe767fbff
This is needed before we can upgrade to flake8 3.3.0, as that version starts flagging these errors.
These files were modified by running:
autopep8 --select E305 --in-place -r <dir>
on the affected directories. I did it one dir at a time and verified the result after each.
MozReview-Commit-ID: FmlsfiKIbtr
--HG--
extra : rebase_source : 9df32258cadff5d27a0e72113c57f782756c0b18
Instead of 'itemCount' the 'maxResults' property of the autocomplete popup
has to be used, because it doens't get increased similar to 'itemCount' but
stays the same all the time.
Further we cannot do an equal check in the puppeteer unit test but only do
a check for 0 < visible results <= maxResults, to ensure that items are
visible. Using the dot instead, should also give us more and more accurate
results across different locales.
MozReview-Commit-ID: KZEhq87kvx7
--HG--
extra : rebase_source : f429730d3f4a8da28b481b42c916145ae82e6bb5
All connections to mozqa.com which do not use SSL have to be done
to a unique subdomain. This was requested to lower the amount of
active HTTP endpoints.
MozReview-Commit-ID: JAFjQFhTCxT
--HG--
extra : rebase_source : 7f584f4a3848b122eadd6e25799d43718352a03d
To allow update tests to use source builds of Firefox before bug 1355888
was landed, the MOZ_MARIONETTE environment variable has to be be
pre-emptively set. Otherwise Marionette will not be activated after
the update has been applied.
MozReview-Commit-ID: Hqb6SjYtOPR
--HG--
extra : rebase_source : 10f9b4d2545198fc95294381ec1db63f1445c736
Continue to allow non-multiprocessCompatible extensions in automation.
There are a ton of places that would need to be changed, many of which
will be changing soon anyway with the non-webextensions change in 57
so this is mostly the expedient route to keeping the tree green.
MozReview-Commit-ID: EZZoDVdhLfy
--HG--
extra : rebase_source : f83472bc1c88dd0deadbe485d9002499027ff07f
Continue to allow non-multiprocessCompatible extensions in automation.
There are a ton of places that would need to be changed, many of which
will be changing soon anyway with the non-webextensions change in 57
so this is mostly the expedient route to keeping the tree green.
MozReview-Commit-ID: EZZoDVdhLfy
--HG--
extra : rebase_source : 34aa762917566b052ade6372280caed72fbfbe9a
The unit tests for the software update class should not rely on
the remote update URL being reachable. Instead a locally served
URL has to be used.
MozReview-Commit-ID: 8WNoEb0PUWz
--HG--
extra : rebase_source : 85900716de5c868efd8f0411e0c577f317d98d25
To ensure that we correctly restart Firefox for update tests, the restart
button in the about window or the old software update window have to be
clicked.
MozReview-Commit-ID: 7acl1DcA85d
--HG--
extra : rebase_source : 8af6c300ae34befc2c05e801ea4b5901659c1c2a
Updates consumers to the new behavior.
Some consumers are changed to use the "page-icon:" protocol, since it's not
trivial to join the icons table and get a single result out of it. In most cases
the join would return multiple results since a page can have multiple icon payloads.
These consumers for now will return the biggest payload, bug 1347532 will fix
some of them to properly pass a #size=NN fragment.
Note that, even before, these were just "moz-anno:favicon:" uris, and the
payload had to be fetched from the database.
Some other consumers for now just fallback to the largest payload, by passing 0
to GetFaviconURLForPage.
The favicon optimization still happens on the main-thread, bug 1346139 will
handle that problem.
Most of the changes involve handling the modified IconData objects, that now
retain an array of payloads, rather than just one. But note that .ico files are
not yet split into single frames, due to imagelib missing APIs that will be handled
in bug 1337402.
The other changes involve fixing queries to properly join with the new tables.
Finally, note that thanks to the FOREIGN KEYS support, removing from moz_icons or
moz_pages_w_icons will also remove relations from moz_icons_to_pages.
The system only supports square icons, so icons are resized based on their larger side.
This doesn't include new tests, those will be in a following changeset.
MozReview-Commit-ID: JUkpquhpS8y
--HG--
rename : toolkit/components/places/tests/unit/test_svg_favicon.js => toolkit/components/places/tests/favicons/test_svg_favicon.js
extra : rebase_source : fa49c4a81d6ab6b34a2f19ee4175e889a6e9d734
As long as update tests do not support the new simplified update ui
it has to be kept disabled.
MozReview-Commit-ID: 4fC0CYhp7Pc
--HG--
extra : rebase_source : f3558973b0153fe2104f0e612120298d711fc491
To ensure better failure messages a refactoring of checks has to be done. It
includes the following changes:
* No further checks for a follow-up (watershed) update. It's not supported
and as such doesn't need assertions (bug 1353717)
* Checks for fallback updates have to be made to ensure that an invalidated
partial/complete update does not cause an upgrade of Firefox during the restart.
MozReview-Commit-ID: CLb0aXoIur2
--HG--
extra : rebase_source : e41f2463cef695f6f9984ea2ee6f7d43196a9138
There was never a need to run a multiple-update step in the past, and as
we agreed a while ago it is not something we want to do in the future.
It means that watershed releases will have to be tested by issuing
multiple update tests.
MozReview-Commit-ID: 7cmK3gEOkv1
--HG--
extra : rebase_source : dac6bcf5d4505febc9b6ffb6333cf77b41d4dc4a
There is no need to close this dialog given that a restart happens anyway.
But doing that as right now, and trying to invoke execute_script() on it,
will end up with a unlocatable window.
MozReview-Commit-ID: 53yBLYsWX4o
--HG--
extra : rebase_source : 21b02231c845cf994c7c75d10bd91e0911114998
We have to ensure to switch to the current browser window after closing all the windows
in tearDown.
MozReview-Commit-ID: 3sYwmbew43d
--HG--
extra : rebase_source : 6afb6430c40d7b248320cae95ddef4ace86b0042
Prathiksha
Andrew Halberstadt
Wes Kocher
Ganti Sai Sarath Chandra
Erica Wright
Francois Marier
David Burns
Thomas Nguyen
Junior Hsu
Henrik Skupin
Gijs Kruitbosch
Joel Maher
dimi
Sebastian Hengst
Geoff Brown
Ryan VanderMeulen
CuriousLearner
Raajit Raj
Andrew Swan
Marco Bonardo
ui.aseem_yadav