47d81ff540
Bug 1373788 - Reset the cached blink rate when the caret stops blinking; r=mats
...
Otherwise the next time in ResetBlinking() we mistakenly think
we already have the blinking timer set.
2017-06-17 16:19:03 -04:00
02b2136122
Bug 1372761 - Avoid needlessly grabbing the timer thread lock when selections change in order to reset the caret timer; r=mats
2017-06-14 17:53:48 -04:00
23bce99ae1
Bug 1361051: rename mozilla::FrameType to mozilla::LayoutFrameType. r=xidorn
...
This avoids conflicts with mozilla::dom::FrameType.
MozReview-Commit-ID: 7aEMbHRaTFk
--HG--
extra : rebase_source : 2d01321f5ce0ec8c0e3f70984674f82678034b3c
2017-05-01 19:32:52 +02:00
e44543aad4
Bug 1360241: Devirtualize nsIFrame::GetType. r=heycam
...
MozReview-Commit-ID: 5Nzhyta5Hle
--HG--
extra : rebase_source : c2e9d4bfb9239f5e851d110cd7dff98c1e1a8d8b
2017-04-30 17:30:08 +02:00
dca4d0e0df
Bug 1354478 - Adjust caret rect to paint on the opposite side of the nominal caret position in "upstream" text, for more visually consistent placement. r=dholbert
2017-04-12 11:32:19 +01:00
f62b8b3b3f
Merge m-c to graphics
...
MozReview-Commit-ID: IN2hMCjMHLL
--HG--
rename : browser/components/extensions/test/browser/browser_ext_url_overrides.js => browser/components/extensions/test/browser/browser_ext_url_overrides_newtab.js
rename : browser/extensions/formautofill/content/FormAutofillContent.js => browser/extensions/formautofill/FormAutofillContent.jsm
rename : browser/extensions/formautofill/content/FormAutofillContent.js => browser/extensions/formautofill/FormAutofillHandler.jsm
rename : browser/extensions/formautofill/content/FormAutofillContent.js => browser/extensions/formautofill/FormAutofillHeuristics.jsm
rename : browser/extensions/formautofill/content/FormAutofillContent.js => browser/extensions/formautofill/content/FormAutofillFrameScript.js
rename : browser/themes/shared/devedition/urlbar-history-dropmarker.svg => browser/themes/shared/compacttheme/urlbar-history-dropmarker.svg
rename : config/tests/makefiles/autodeps/check_mkdir.tpy => config/tests/makefiles/autodeps/check_mkdir.py
rename : dom/bindings/MozMap.h => dom/bindings/Record.h
rename : dom/bindings/parser/tests/test_mozmap.py => dom/bindings/parser/tests/test_record.py
rename : dom/file/File.cpp => dom/file/BaseBlobImpl.cpp
rename : dom/file/File.h => dom/file/BaseBlobImpl.h
rename : dom/file/File.cpp => dom/file/Blob.cpp
rename : dom/file/File.h => dom/file/Blob.h
rename : dom/file/File.cpp => dom/file/BlobImpl.cpp
rename : dom/file/File.h => dom/file/BlobImpl.h
rename : dom/file/File.cpp => dom/file/EmptyBlobImpl.cpp
rename : dom/file/File.h => dom/file/EmptyBlobImpl.h
rename : dom/file/File.cpp => dom/file/FileBlobImpl.cpp
rename : dom/file/File.h => dom/file/FileBlobImpl.h
rename : dom/file/File.cpp => dom/file/MemoryBlobImpl.cpp
rename : dom/file/File.h => dom/file/MemoryBlobImpl.h
rename : dom/file/File.cpp => dom/file/StreamBlobImpl.cpp
rename : dom/file/File.h => dom/file/StreamBlobImpl.h
rename : dom/file/File.h => dom/file/StringBlobImpl.h
rename : dom/file/File.h => dom/file/TemporaryBlobImpl.h
rename : dom/media/platforms/agnostic/gmp/MediaDataDecoderProxy.cpp => dom/media/platforms/wrappers/MediaDataDecoderProxy.cpp
rename : dom/media/platforms/agnostic/gmp/MediaDataDecoderProxy.h => dom/media/platforms/wrappers/MediaDataDecoderProxy.h
rename : dom/tests/mochitest/general/test_interfaces.html => dom/tests/mochitest/general/test_interfaces.js
rename : dom/workers/test/test_navigator.html => dom/workers/test/test_navigator.js
rename : js/src/jsautokw.py => js/src/frontend/GenerateReservedWords.py
rename : js/src/vm/Keywords.h => js/src/frontend/ReservedWords.h
rename : layout/base/RestyleManager.cpp => layout/base/GeckoRestyleManager.cpp
rename : layout/base/RestyleManager.h => layout/base/GeckoRestyleManager.h
rename : layout/reftests/w3c-css/submitted/ui3/box-sizing-replaced-002-ref.xht => layout/reftests/bugs/1313772-ref.xhtml
rename : layout/reftests/w3c-css/submitted/ui3/box-sizing-replaced-002.xht => layout/reftests/bugs/1313772.xhtml
rename : servo/components/jstraceable_derive/Cargo.toml => servo/components/deny_public_fields/Cargo.toml
rename : servo/components/jstraceable_derive/Cargo.toml => servo/components/domobject_derive/Cargo.toml
rename : servo/components/plugins/lints/ban.rs => servo/components/script_plugins/ban.rs
rename : servo/components/plugins/jstraceable.rs => servo/components/script_plugins/jstraceable.rs
rename : servo/components/plugins/lib.rs => servo/components/script_plugins/lib.rs
rename : servo/components/plugins/lints/unrooted_must_root.rs => servo/components/script_plugins/unrooted_must_root.rs
rename : servo/components/plugins/utils.rs => servo/components/script_plugins/utils.rs
rename : testing/web-platform/tests/old-tests/submission/Infraware/Forms/contents/Forms/Not_Use/input_autocomplete.html => testing/web-platform/tests/old-tests/submission/Infraware/Forms/contents/Forms/Not_Use/input_autocomplete-manual.html
rename : testing/web-platform/tests/old-tests/submission/Infraware/Forms/contents/Forms/Not_Use/input_list.html => testing/web-platform/tests/old-tests/submission/Infraware/Forms/contents/Forms/Not_Use/input_list-manual.html
rename : testing/web-platform/tests/old-tests/submission/Infraware/Forms/contents/Forms/Not_Use/input_valueasdate.html => testing/web-platform/tests/old-tests/submission/Infraware/Forms/contents/Forms/Not_Use/input_valueasdate-manual.html
rename : testing/web-platform/tests/old-tests/submission/Infraware/Forms/contents/Forms/Not_Use/input_valueasnumber.html => testing/web-platform/tests/old-tests/submission/Infraware/Forms/contents/Forms/Not_Use/input_valueasnumber-manual.html
rename : testing/web-platform/tests/old-tests/submission/Infraware/Forms/contents/Forms/Not_Use/select_length.html => testing/web-platform/tests/old-tests/submission/Infraware/Forms/contents/Forms/Not_Use/select_length-manual.html
rename : testing/web-platform/tests/old-tests/submission/Infraware/Forms/contents/Forms/Not_Use/select_selectedindex.html => testing/web-platform/tests/old-tests/submission/Infraware/Forms/contents/Forms/Not_Use/select_selectedindex-manual.html
rename : testing/web-platform/tests/preload/link_header_preload_delay_onload.html.headers => testing/web-platform/tests/preload/link-header-preload-delay-onload.html.headers
rename : testing/web-platform/tests/preload/link_header_preload.html.headers => testing/web-platform/tests/preload/link-header-preload.html.headers
rename : services/sync/tests/unit/test_extension_storage_crypto.js => toolkit/components/extensions/test/xpcshell/test_ext_storage_sync_crypto.js
rename : toolkit/components/telemetry/TelemetryComms.h => toolkit/components/telemetry/ipc/TelemetryComms.h
rename : toolkit/components/telemetry/TelemetryIPCAccumulator.cpp => toolkit/components/telemetry/ipc/TelemetryIPCAccumulator.cpp
rename : toolkit/components/telemetry/TelemetryIPCAccumulator.h => toolkit/components/telemetry/ipc/TelemetryIPCAccumulator.h
extra : amend_source : 7411c39541f0b530b4b94cf359dc73e385abea4d
2017-02-17 23:33:24 -05:00
ef3d9a921c
Bug 1337130 - Create a DisplayItemLayer type. r=mattwoodrow
2017-02-14 13:49:27 -08:00
0cda76d680
Bug 1339289 - Give names to a lot of common timers (r=ehsan)
...
MozReview-Commit-ID: IMsv5bkyjBL
2017-02-15 12:30:01 -08:00
9260566b60
Bug 1313565 - Convert NS_STYLE_USER_MODIFY_* to enum class ; r=manishearth,xidorn
...
MozReview-Commit-ID: IA4bGLgRxd6
--HG--
extra : rebase_source : 6632c53a96df170e8604d65b351f7ee2717ec9ec
2016-10-23 22:41:49 +02:00
e7dddd42f0
Bug 1312173 - Convert NS_STYLE_USER_INPUT_* to an enum class; r=manishearth,xidorn
...
MozReview-Commit-ID: sYiJrZryrA
--HG--
extra : rebase_source : dbb7bae56bea6203176097af8de119cae0a6391c
2016-10-23 00:08:18 +02:00
3cc319fde5
Bug 924851 - patch 1 - Move definition of nsBidiLevel/nsBidiDirection and frame bidi properties from nsBidi.h to nsIFrame.h, in preparation for removal of nsBidi. r=xidorn
2016-10-06 09:49:14 +01:00
c81ed5494f
Bug 1281099 part 1 - Convert some macros to functions to help later change. r=jfkthame
...
MozReview-Commit-ID: 2OS5eIsNAYN
--HG--
extra : rebase_source : 345e33f986aa950eb122c1cc7451c7a59a8f84cb
2016-06-21 17:21:09 +10:00
13d4f396fe
Bug 1185307 part.2 Replace upcast from nsISelection to mozilla::dom::Selection with nsISelection::AsSelection() r=smaug
...
MozReview-Commit-ID: Gs3oiAgJFG9
--HG--
extra : rebase_source : a136405d99ff3361a595157986b3a33026bcd5f5
2016-06-17 22:32:49 +09:00
60bcaa5c0b
Bug 1257121 part 4 - Use return value rather than out param to return font metrics. r=jfkthame
...
MozReview-Commit-ID: 6xrHYbgHGVd
--HG--
extra : rebase_source : 4d0cea24689588d8a1daa1869502e31ac7c3dc56
2016-03-17 13:55:48 +08:00
8acf32453c
Bug 1257121 part 3 - Add GetInflatedFontMetricsForFrame function to simplify a common use pattern. r=jfkthame
...
MozReview-Commit-ID: 4KMLCz6wQHQ
--HG--
extra : rebase_source : 08964aef3b335163985dd6818b4a6ae3a4e34fce
2016-03-17 12:07:47 +08:00
2d02ad0652
Bug 1227927 Part 3 - Use ranged-based for-loop to rewrite some simple loops in part 2. r=mats
...
--HG--
extra : commitid : CcdpGdlMNIk
extra : rebase_source : 9c184cb8107bf6276c237d03d240f8755fd61553
2016-01-29 22:42:15 +08:00
1889f6bc41
Bug 1227927 Part 2 - Remove nsIFrame::GetFirstPrincipalChild(). r=mats
...
--HG--
extra : commitid : 5qtaK1nS8RC
extra : rebase_source : dcc98f423b2446269beb6fa6a9d092ae8213f38e
2016-01-29 22:42:14 +08:00
fd7ca876ef
Bug 1232852 (part 4) - Remove some unused parameters in and around layout/base/. r=heycam.
...
--HG--
extra : rebase_source : 68642322a9fc78bb7eace1501b75003241a44507
2016-01-05 16:08:17 -08:00
caaac41610
Bug 1215959 - (GeckoCaret2) Remove experimental bits added to Touch/Selection carets, r=tylin
2015-12-01 15:25:06 -05:00
3457b582d2
Bug 1216096: restore previous RTL caret behaviour by backout of bug 1164963, bug 1177505, and bug 1180417. r=jfkthame
2015-11-10 04:42:23 -08:00
01583602a9
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
c9565000fb
Bug 1193519 pt 6 - Adjust the position of the caret bidi indicator appropriately for sideways-lr mode. r=dholbert
2015-09-24 10:23:34 +01:00
4c1ccfafa3
Bug 1200194 - Expose nsCaret::GetFrameAndOffset for reuse. r=roc
...
This function can be reused by AccessibleCaret.
--HG--
extra : commitid : KCG4QMsPhdY
extra : rebase_source : ec6bb5f771f14d5b39c598c51bccced48909945d
2015-09-09 16:47:20 +08:00
3645c1dbaf
Bug 555642 part.1 nsCaret should have a way to override the caret visible state for hiding caret temporarily and nsEditor should hide caret if composition string doesn't have caret information r=roc
2015-08-17 20:58:38 +09:00
b1d966b6e0
Bug 1164693 - Part 1: Directional caret should point in caret direction in bidi paragraphs. r=smontagu
2015-06-05 21:44:54 -04:00
210b7857e8
Bug 1067788 - Part 2: Fixes to caret positioning in bidi text. r=smontagu
...
--HG--
extra : rebase_source : 7c6c8cc606bfdca24b34c906e799b0bdceb2a198
2015-05-28 08:05:25 -04:00
27ef7c7715
Bug 988143 - Enable Gecko Touch in Fennec, Android specific nsCaret mods, r=ehsan
2015-05-14 22:06:13 -04:00
ea1ba80c9b
Bug 1159263 - Add support to nsCaret to stop blinking after a set of cycles r=roc r=snorp
2015-04-29 10:23:19 -04:00
4de81417ac
Bug 1141926 - Check nsCaret visibility when NotifySelectionChanged. r=roc
2015-03-10 23:01:00 -04:00
4d42b88e0b
Bug 989012 - Part 1: Stop after passing over a non-selectable frame if one is found during the frame traversal; r=roc
...
The caret movement code already handles unselectable text frames if we
happen to land in the middle of one in nsTextFrame::PeekOffsetCharacter/Word.
However, when performing frame traversal to find the next frame to jump
to, we don't remember if we skipped over an unselectable frame, which causes
us to jump one offset too much when the caret is on the boundary of
selectable and unselectable content. The test cases demonstrate the
scenario. Note that an <img alt=foo> is implemented by adding a
generated content to the inline frame representing it, so as far as
the caret movement code is concerned, both test cases are treated similarly.
Note that we need to do this only when moving the selection, and not
when extending it. We are adding an aExtend argument to
nsPeekOffsetStruct's constructor in order to be able to special case
that.
2015-01-27 23:11:26 -05:00
fa44e7387c
Backed out 2 changesets (bug 989012) because of test failure on Linux32 opt mochitest-a11y on a CLOSED TREE
...
Backed out changeset 9698f6f3f72e (bug 989012)
Backed out changeset 22fb05349a10 (bug 989012)
2015-01-27 16:40:30 -05:00
084e7e0b3c
Bug 989012 - Part 1: Stop after passing over a non-selectable frame if one is found during the frame traversal; r=roc
...
The caret movement code already handles unselectable text frames if we
happen to land in the middle of one in nsTextFrame::PeekOffsetCharacter/Word.
However, when performing frame traversal to find the next frame to jump
to, we don't remember if we skipped over an unselectable frame, which causes
us to jump one offset too much when the caret is on the boundary of
selectable and unselectable content. The test cases demonstrate the
scenario. Note that an <img alt=foo> is implemented by adding a
generated content to the inline frame representing it, so as far as
the caret movement code is concerned, both test cases are treated similarly.
Note that we need to do this only when moving the selection, and not
when extending it. We are adding an aExtend argument to
nsPeekOffsetStruct's constructor in order to be able to special case
that.
2015-01-27 15:35:32 -05:00
9a00763a7b
Bug 1077515 - part 3 - Change desiredX (nscoord) to desiredPos (nsPoint) in nsPeekOffsetStruct, to support maintaining either vertical or horizontal position on inter-line moves. r=roc
2014-11-22 14:39:03 +00:00
ad766a1fcb
Bug 1100071 patch 2: add macros for common tests whether bidi level is odd and whether two bidi levels have the same parity, r=dholbert
2014-11-20 12:45:22 +02:00
aafee71bb6
Bug 1100071 patch 1: change uint8_t to nsBidiLevel in a few more places, r=dholbert
2014-11-20 12:45:22 +02:00
e67266e10b
Bug 1098558: Remove unused constant NS_STYLE_DIRECTION_INHERIT. r=smontagu
2014-11-13 15:50:39 -08:00
5182bb2e02
Bug 1093553 - Followup to fix positioning of the caret with writing-mode:vertical-lr and text-orientation:sideways-right. r=smontagu
2014-11-13 08:58:06 +00:00
bfe784d925
Bug 1090611 - Make nsCaret::PaintCaret take a Moz2D DrawTarget instead of nsRenderingContext. r=Bas
2014-10-29 17:07:11 +00:00
a0f005a778
Bug 1088625, part 1 - Add lots of missing nsFontMetrics.h and gfxTextRun.h includes
2014-10-24 16:28:14 +01:00
09f54bbbb9
Bug 1086708 - Rename the snapping variant of NSRectToRect to NSRectToSnappedRect. r=mattwoodrow
2014-10-22 12:29:06 +01:00
b8b833765e
Bug 1083753, part 2 - Port the code that uses nsRenderingContext::FillRect(nsRect) to Moz2D. r=mattwoodrow
2014-10-19 13:22:22 +01:00
668168cb49
Bug 902762 pt 7 - Draw caret appropriately for vertical textruns. r=smontagu
2014-10-01 20:25:50 +01:00
86e7644d1a
Bug 1063265 - Stop Blinking the Text Caret when it isn't visible. r=roc
2014-09-06 12:25:00 +02:00
139b358c46
Bug 1048752. Part 39: Call SelectionLanguageChange even when bidi keyboard is not available, for consistency, and fix broken tests. r=jfkthame
...
--HG--
extra : rebase_source : c25d92fbc1d2237c35de80f0273dc00e81d0444d
2014-08-13 01:27:02 +12:00
96711a9de4
Bug 1048752. Part 37: GetGeometryForFrame should return a rect instead of an nsresult. r=tn
...
--HG--
extra : rebase_source : f49846cc50de2a3a616a991d81b38bf6c1d9a2c5
2014-08-06 17:19:32 +12:00
98d88074ed
Bug 1048752. Part 36: Remove ancient horizontal rules. r=tn
...
--HG--
extra : rebase_source : 7537ad3060b7703565d2a259109fae96e238e0a4
2014-08-06 17:19:31 +12:00
754d094377
Bug 1048752. Part 35: Remove GetFrameSelection (unused). r=tn
...
--HG--
extra : rebase_source : 4b528b7de79bf3f1e03891cb093d16a111605c2c
2014-08-06 17:19:31 +12:00
80f5312883
Bug 1048752. Part 34: Handle null selection returned by GetSelection(). r=tn
...
Previous changes broke this. Tests caught it.
--HG--
extra : rebase_source : 20f365b3f6074fe18d4aaa7f81baf64f3b64e8de
2014-08-06 17:19:31 +12:00
25c1a49e6d
Bug 1048752. Part 33: A zero blink rate should mean the caret is always on. r=tn
...
Previous changes broke this.
--HG--
extra : rebase_source : d0dc9bd22f93f40465b3448cf20050ac725ee560
2014-08-06 17:19:31 +12:00
967ecc3283
Bug 1048752. Part 32: Rename DrawAtPosition to SetCaretPosition and don't make it turn off blinking. r=tn
...
There's no need for this method to turn off blinking anymore. Its only
caller already calls SetCaretReadOnly to achieve the same effect. That
means we don't actually need the mIsBlinking flag after all.
--HG--
extra : rebase_source : 9d4c31282ed280c0f822f1d9f7fa8ae1c2ba6cab
2014-08-06 17:19:31 +12:00
Ehsan Akhgari
Emilio Cobos Álvarez
Jonathan Kew
Kartikaya Gupta
Mason Chang
Bill McCloskey
Adam Velebil
Xidorn Quan
Masayuki Nakano
Xidorn Quan
Ting-Yu Lin
Nicholas Nethercote
Mark Capella
Simon Montagu
Nathan Froyd
Ted Clancy
Mark Finkle
Ethan Lin
Daniel Holbert
Jonathan Watt
Robert O'Callahan