Introduce functions which create and invoke the Windows file-picker in a
separate thread. This thread is created with a new single-threaded COM
apartment to avoid implicitly creating a nested modal loop on the main
STA thread.
Technically, no functional changes: these functions aren't actually
invoked yet. (That will occur in an upcoming commit.)
Differential Revision: https://phabricator.services.mozilla.com/D193735
The async file-picker creates a new thread, but the thread name was not
added to the permitted-thread-names list. Amended.
Differential Revision: https://phabricator.services.mozilla.com/D195170
Clang trunk started to warn about uses of snprintf that always lead to
truncation. The warning is hit in the test, but it's not really an
interesting part of the test, so prevent clang from warning by making
the format string smaller.
Differential Revision: https://phabricator.services.mozilla.com/D186990
clang 17 is making void* deref a non-disablable error, and this tests
relies on the deref "error" being disablable. Arranging things to make
it not deref makes not different from test_ref_9, so remove it.
Differential Revision: https://phabricator.services.mozilla.com/D179031
For preparation of bug 1620312, CanRunScriptChecker needs to allow references
which are initialized with safe instance(s) to run script. Unfortunately,
this does not allow references which are initialized with safe references
recursively because it requires more complicated checks but it must be not
used in many places.
Differential Revision: https://phabricator.services.mozilla.com/D174436
VideoCapture used to be a base::Thread called VideoCapture.
DesktopCapture used to be a rtc::PlatformThread/PlatformUIThread called ScreenCaptureThread.
Differential Revision: https://phabricator.services.mozilla.com/D166061
C++20 allows non-trivial constexpr constructors, so this BadUnfortunateError check passes unexpectedly when compiled as C++20:
> error: 'error' diagnostics expected but not seen: build/clang-plugin/tests/TestTrivialCtorDtor.cpp Line 81: class 'BadUnfortunateError' must have trivial constructors and destructors
This constexpr constructor check was added in bug 1226376.
Differential Revision: https://phabricator.services.mozilla.com/D161951
The UpdateWatcher thread might not be shut down if `ProcessUpdates`
returned an error. Rework `StartStagedUpdate` so that the thread will be
shut down after any early return.
More cosmetically, rename the updater thread to "Updater Thread": it's
not limited to being a watcher-thread, but is also used for the initial
update checks.
Differential Revision: https://phabricator.services.mozilla.com/D159560
Remove all the thread names only used in tests from ThreadAllows.txt.
Instead, list the test files that create them in ThreadFileAllows.txt.
Differential Revision: https://phabricator.services.mozilla.com/D157762
Filenames alone do not uniquely identify files in the Mozilla codebase.
Allow specification of path-elements alongside filenames.
Differential Revision: https://phabricator.services.mozilla.com/D157761
Expand the processor for ThreadAllows.txt and ThreadFileAllows.txt to
also recognize and permit comments prefixed by `#`.
Differential Revision: https://phabricator.services.mozilla.com/D157760
Remove all the thread names only used in tests from ThreadAllows.txt.
Instead, list the test files that create them in ThreadFileAllows.txt.
Differential Revision: https://phabricator.services.mozilla.com/D157762
Filenames alone do not uniquely identify files in the Mozilla codebase.
Allow specification of path-elements alongside filenames.
Differential Revision: https://phabricator.services.mozilla.com/D157761
Expand the processor for ThreadAllows.txt and ThreadFileAllows.txt to
also recognize and permit comments prefixed by `#`.
Differential Revision: https://phabricator.services.mozilla.com/D157760
Whenever some activity starts on the thread we are monitoring, we create a timer that targets the BHMgr Monitor thread (where we capture hang stacks).
Whenever the activity stops, we cancel the timer.
In the past, this would have been very expensive because the Timer thread used to wake-up every time a timer was added or removed. This is no longer true, as we optimized the wake-up behavior of the timer thread to only wake-up when it actually needs to.
Differential Revision: https://phabricator.services.mozilla.com/D154141
A change in LLVM trunk (that was backed out but will reland later on trunk)
unveiled a longstanding issue in the NoPrincipalGetURI matcher, which
would make it fail to catch issues under some conditions.
Differential Revision: https://phabricator.services.mozilla.com/D152359
If dedicated thread for out-of-process WebGL exists, compositor thread tasks are not delayed by WebGL tasks.
And Bug 1712486 requests that WebGL run on non-compositor thread.
Differential Revision: https://phabricator.services.mozilla.com/D151210
Logan Rosen
Ray Kraesig
Cosmin Sabou
Nicolas Guichard
Mike Hommey
Botond Ballo
Masayuki Nakano
serge-sans-paille
Andi-Bogdan Postelnicu
Stanca Serban
Andreas Pehrson
John Lin
Csoregi Natalia
Mike Hommey
Marco Castelluccio
Chris Peterson
Butkovits Atila
Sandor Molnar
Florian Quèze
Ryan VanderMeulen
Kagami Sascha Rosylight
sotaro