c3972efec6
Bug 1368393 - Handle already synced commands in clients collection duplicate checking r=eoger,markh
...
MozReview-Commit-ID: Hs0Jh8mMlOp
--HG--
extra : rebase_source : 8a8bae7330210547d128c322abed773cb73895e5
2017-06-09 12:07:43 -04:00
b599411285
Bug 1369119 - Refresh known stale devices list on FxA device disconnect. r=markh
...
MozReview-Commit-ID: A2iqas0kP20
--HG--
extra : rebase_source : 15db886e4751885e173a55c561df7ea1a3b2871b
2017-06-06 14:28:00 -04:00
ea1b86680c
Backed out changeset 9846de3bd954 (bug 1372405)
...
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
4592152411
Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
d1637b9c5a
Bug 1372453 - Part 2: Name the caller of ProxyReleaseEvent. r=billm
...
MozReview-Commit-ID: LYhSWnZkq0i
2017-06-14 09:27:17 +08:00
d030707609
Bug 1095426 - Convert JSON backups code to the new async Bookmarks.jsm API. r=mak
...
MozReview-Commit-ID: FNZZGwWVSI2
--HG--
extra : rebase_source : dacb3c5ddb439d074c66e0baaa7e73044c5dcd46
2017-05-12 08:04:51 +01:00
1d88de7d2f
Bug 1371945 - Avoid a possible thread-safety problem with unfinalized statements. r=asuth
...
Avoids a thread-safety race condition on shutdown where we could try to finalize a statement twice.
Allows the async thread to be referenced until ShutdownAsyncThread, so async finalizers can make use of it.
Removes the no more useful mAsyncExecutionThreadIsAlive.
Nullifies the sqlite3_mutex pointer when the connection is closed, since it would be a dangling pointer.
Use a ScopeExit to ensure the connection and the mutex pointers are always nullified on failure.
Makes asyncClose bailout early if a Close method was already invoked before.
Makes AsyncInitDatabase not use AsyncClose to just shutdown the async thread.
Fixes various unfinalized statements in consumers code.
Makes mConnectionClosed better follow mDBConn status.
Replaces some mutex locking isClosed() calls with lockless isConnectionReadyOnThisThread.
MozReview-Commit-ID: 6sftFehsQTt
--HG--
extra : rebase_source : 2bf3088b500376e58e62e8f078d9950588adc649
2017-06-16 17:43:23 +02:00
6b3e84ed5f
Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
3231cb3535
Bug 1372886 - Remove dead parameters from nsIConverterInputStream.init(). r=hsivonen
...
MozReview-Commit-ID: GliLHLsUWjt
--HG--
extra : rebase_source : 50d3f4680a498125ddf600b0d64f6740b0229f80
2017-06-17 19:30:09 +09:00
a1f2f47f82
Bug 1363412 - Notify other clients when uploading the local clients record for the first time. r=markh
...
MozReview-Commit-ID: Ldc3Jrj8RhV
--HG--
extra : rebase_source : 44bdeaa962ddbcb748f9e5a01871fd2ff7d6a676
2017-06-12 14:51:17 -04:00
1826fefb4c
Bug 1370985 - Change getBatched() to return records directly instead of using a callback. r=markh,tcsc
...
MozReview-Commit-ID: HfwPe8jSH66
--HG--
extra : rebase_source : 12c8800f1fcc090589c2a94a0fc1608b36c54181
2017-05-30 13:23:57 -04:00
120e57745f
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
2017-06-12 13:48:15 +01:00
adde19d4f4
Bug 1369855 - Update sinon.js to version 2.3.2. r=markh
...
MozReview-Commit-ID: FPB4HebP3g7
--HG--
extra : rebase_source : 1e55c1dbc8bff59e1a7a097e4a6a58a19bc95688
2017-06-02 15:50:30 -04:00
96faa14e58
Bug 1370736 - reset the sync login status after an FxA login event. r=eoger
...
MozReview-Commit-ID: 6BLj6q8z79i
--HG--
extra : rebase_source : 350bc8d6c6e5581082c9b1a50b3517b93d70db52
2017-06-07 16:41:18 +10:00
1fdf6c19a7
Bug 1356281 - Remove bookmark contents from sync debug logs. r=tcsc
...
MozReview-Commit-ID: HsMH5mpCK8C
--HG--
extra : rebase_source : 26853fa867257a6c0a914ed903f9d8e253c86e8f
2017-05-19 04:40:15 -03:00
7d9c066f35
Bug 1254099 - Add Telemetry to settings update r=bsmedberg,glasserc,mgoodwin,rhelmer
...
MozReview-Commit-ID: 8vAuTImx7IH
--HG--
extra : rebase_source : 15995e30bd1fdb697eb2374a0c28c68e0828e1e6
2017-03-22 11:27:17 +01:00
19362d0bfa
Bug 1354016 - Forms validator ignore clientMissing. r=tcsc
...
MozReview-Commit-ID: C2FD58C9HzS
--HG--
extra : rebase_source : f5b627342e7fa4915914cbfd3e54003fe6d94c1e
2017-06-01 22:32:23 -03:00
dc01c77702
Bug 1369285 - update how we build the default sync device name. r=tcsc
...
MozReview-Commit-ID: 6eY8IzKg9kd
--HG--
extra : rebase_source : ae321d48de0144c29fa4f40fd16a02c44539d795
2017-06-01 16:57:02 +10:00
9d1dc7c4a7
Bug 1368560 part 2 - Move Svc.Crypto to Weave.Crypto. r=markh
...
MozReview-Commit-ID: 74IFsVjZSgz
--HG--
extra : rebase_source : 00f77b7a24a509d5e9fabb8ee7793a59b38f639f
2017-05-29 13:24:01 -04:00
2c61cf7eb4
Bug 1368560 part 1 - Remove un-used legacy crypto methods. r=markh
...
MozReview-Commit-ID: JbzweOMFLpR
--HG--
extra : rebase_source : f7cece36dce26c96a740aede6c696deb08345a90
2017-05-29 17:27:13 -04:00
0c6026b415
Bug 1369092 - Listen to onverified events in UIState. r=markh
...
MozReview-Commit-ID: 8nfmpaz9obF
--HG--
extra : rebase_source : 736673d0c1245b81ea9f419f08b943c3ce26a8e6
2017-05-31 12:02:28 -04:00
9768267be1
Backed out changeset bf392a1d0c5a (bug 1368560) for failing xpcshell's test_ext_storage_sync.js and test_ext_storage_sync_crypto.js on Linux. r=backout on a CLOSED TREE
2017-05-31 22:53:16 +02:00
a9f8675d96
Backed out changeset c2d00a8b897b (bug 1368560)
2017-05-31 22:52:14 +02:00
275b48a53e
Bug 1368560 part 2 - Move Svc.Crypto to Weave.Crypto. r=markh
...
MozReview-Commit-ID: 74IFsVjZSgz
--HG--
extra : rebase_source : 29833856a9cca178a2b508b6401cdb6bd8ca1bb9
2017-05-29 13:24:01 -04:00
198e8ab1d1
Bug 1368560 part 1 - Remove un-used legacy crypto methods. r=markh
...
MozReview-Commit-ID: JbzweOMFLpR
--HG--
extra : rebase_source : f7cece36dce26c96a740aede6c696deb08345a90
2017-05-29 17:27:13 -04:00
71a24b858a
Bug 1366994 - prevent appDisabled addons from hanging sync. r=tcsc
...
MozReview-Commit-ID: 4RRCPlwUZrG
--HG--
extra : rebase_source : 8ab03af402dc15432252b74a120da286b810302f
2017-05-26 12:42:10 +10:00
f8e13dd94c
Bug 1353645 - Record account verification status determination method telemetry. r=bsmedberg,gfritzsche,markh
...
MozReview-Commit-ID: GETlknx8Fse
--HG--
extra : rebase_source : b56da3d0309b91ee7d908e9246d7921ebd7ed03d
2017-05-16 16:59:51 -04:00
7386600327
Bug 1366081 - Excise 'mobileGUIDFetchBatchSize' and other mobile sync-related constants. r=kitcambridge
...
MozReview-Commit-ID: 6JTtpWFFyvD
--HG--
extra : rebase_source : f6ca75e91ca38d0d1ba18ff79a0872d96a878954
2017-05-24 03:28:22 -03:00
f9f6f160da
Bug 1364135: Clean up detection/handling of deleted keyrings, r=kmag,MattN
...
MozReview-Commit-ID: CoOwUazDRSL
--HG--
extra : rebase_source : d027c47f1b5740fa9916420b5dafdac935264ff8
2017-05-11 13:15:20 -04:00
fc8d285e3d
Bug 1036440 - Fix tests and consumers for rewritten `PlacesDBUtils`, r=mak
...
This includes 2 things:
1. Replacing the parts which test the logs for the presence of prefixes by testing
the returned map for `suceeded`.
2. We don't need to wait to observe the topic anymore, we can simply await methods
from `PlacesDBUtils` to know when they are done.
MozReview-Commit-ID: Ct9l9pzUW5x
--HG--
extra : rebase_source : 657e4ac53f8b3785740a5b732d483fad9600f73d
2017-05-24 11:00:47 +05:30
85291791fd
Bug 1367585 - Add the 'load' event listener before adding the new tab in sync's TPS tests r=markh
...
MozReview-Commit-ID: HUUHYnLf4m8
--HG--
extra : rebase_source : f0ac2cadf4f5345f854e8ad8ca3e7be37485a0cf
2017-05-24 17:58:55 -04:00
1e07d66113
Bug 1367543 - Make sync's TPS tests handle cases where resyncs are triggered r=kitcambridge
...
MozReview-Commit-ID: 4owlGyLw5jU
--HG--
extra : rebase_source : bdfca8806ed76c2398c845880f4b7c65bd3dffd3
2017-05-24 16:16:23 -04:00
d53c05ca28
Bug 1367525 - Remove extra error logging during device disconnect. r=eoger
...
MozReview-Commit-ID: JgFvBlGwsxZ
--HG--
extra : rebase_source : ef9cfb41112d8974f8e1ef5a138e4cfddfdc6386
2017-05-24 15:19:35 -04:00
99947c9c38
Bug 1353307 - Add main process start time to sync ping. r=gfritzsche,markh
...
MozReview-Commit-ID: DbSZUmO0tuf
--HG--
extra : rebase_source : e13afbd5829b86b7bee5c82a7a1ff09263e9dc3f
2017-05-16 17:43:49 -04:00
c4e6a8f382
Bug 1365375 - Disconnect Sync on account destroyed. r=markh
...
MozReview-Commit-ID: EVySp2JOgsT
--HG--
extra : rebase_source : e60612d8dedcf46170cf58f47bde2c979ab99d3f
2017-05-23 19:22:49 -04:00
4202c4feab
Merge m-c to autoland. a=merge
2017-05-23 18:13:54 -04:00
df2d03a198
Bug 973166 - Only track passwords with changes to synced fields. r=eoger
...
MozReview-Commit-ID: 8ZOyVCaZIi8
--HG--
extra : rebase_source : 8252c5a9ad718594872d5bda38e04528cd227f44
2017-05-22 17:21:20 -07:00
c92175874c
Backed out changeset d11aec13b38e (bug 1365375) for eslint failures.
2017-05-23 13:36:50 -04:00
69602ba5f2
Bug 1365375 - Disconnect Sync on account destroyed. r=markh
...
This connects to the fxa-auth-server PR:
https://github.com/mozilla/fxa-auth-server/pull/1900
MozReview-Commit-ID: IIYnytYGIpw
--HG--
extra : rebase_source : 04a6adb81252c0c4aa0eaaa01b68e3943791aadc
2017-05-17 16:25:00 -04:00
d2833635e1
Bug 1352233 - Try to preserve synced folder child order in case of conflicts. r=tcsc
...
For folders, we resolve conflicts by taking the chronologically newer
list, then appending any missing items from the older list. This
preserves the order of those missing items relative to each other, but
not relative to those appearing in the newer list.
MozReview-Commit-ID: 6rimXpV7vLg
--HG--
extra : rebase_source : 10cda7f529cec3f71d9d45d253285d35788cb0b5
2017-04-28 14:08:11 -07:00
1734a80650
Merge m-c to inbound. a=merge
2017-05-23 11:15:49 -04:00
7a827756f9
Bug 1308038 - Add handshake capability to share state with FxA. r=markh, r=rkelly
2017-02-02 09:16:54 +00:00
7d0f361ba0
Bug 1356282 - Change Sync's Utils.arraySub to be O(n) using Set. r=tcsc
...
Sync's Utils.arrayUnion and Utils.arraySub are O(n^2) because Utils.arraySub uses indexOf inside a loop. This patch makes Utils.arraySub use a Set, and by doing so, Utils.arrayUnion and Utils.arraySub become O(n).
MozReview-Commit-ID: DDqjRWalfP9
--HG--
extra : rebase_source : ec90092244e16d3651f0d69ea8db1944301c13fb
2017-05-05 03:16:30 -03:00
0ce286101c
Bug 1359011 - Make the mozilla/recommended eslint configuration the default for the whole tree. r=mossop
...
MozReview-Commit-ID: HtUW43tCli1
--HG--
extra : rebase_source : 6496bc47860d9c1ab522a78e73b41550700021cb
2017-04-25 20:12:21 +01:00
4fc3418733
Bug 1357116 - Load the blocklist updater module lazily r=florian,mgoodwin
...
Importing the blocklist-updater module on each notification in nsBlocklistService
could cause us to periodically jank the browser UI.
This patch now lazy loads as many dependencies as possible.
MozReview-Commit-ID: HBGjSJi5PwE
--HG--
extra : rebase_source : 4a7c18fe64b810f54d52eee07883d67837b297d3
2017-04-20 10:35:04 +02:00
274ba1a154
Merge inbound to central, a=merge
...
MozReview-Commit-ID: AFMOzsYBEjc
2017-05-15 16:22:21 -07:00
fab6e7f663
Bug 1362510 - Remove errors.properties and references. r=eoger
...
MozReview-Commit-ID: 27kIRQdEHsE
2017-05-15 12:03:55 -04:00
45fdbb5730
Bug 1355663 - Don't de-duplicate tabs from multiple devices. r=eoger
...
MozReview-Commit-ID: AciCTECtXJc
--HG--
extra : rebase_source : 82f81f227cf27cf03c4672f0402641010434e74e
2017-05-12 20:54:54 -03:00
3d2e65ee7e
Bug 1364571 - Delay Weave startup. r=kitcambridge
...
MozReview-Commit-ID: 4bm1LXLD7lV
--HG--
extra : rebase_source : c1b14b70e4d952870800387f16c7fecab9667b49
2017-05-12 17:01:25 -04:00
d6d727a69e
backout of f9abb9c83452 (bug 1319111) for crashes, r=bz
2017-05-13 13:55:11 +02:00
0a1e1fe23b
Backed out changeset 95ff98f1c2e5 (bug 1319111) for talos failures a=backout
...
MozReview-Commit-ID: Gs09moFm5rQ
2017-05-12 18:24:42 -07:00
70f62bdec1
backout of f9abb9c83452 (bug 1319111) for crashes, r=bz
2017-05-12 22:13:49 +02:00
4e937e42a2
Bug 1353542 - Cleanup the script output and fix tests, r=Mossop.
2017-05-12 14:54:05 +02:00
65e959c068
Bug 1357814 - Changes to sync's TPS tests to allow running from automation r=markh
...
1. Ensure we wait for browser-delayed-startup-finished
2. Parse the profile we're cleaning up from the cleanup phase name instead of
using the selectedProfile.
3. Ensure that bookmark repair doesn't run randomly (this isn't necessary, but
the repair code can make the actual reason for failure much more difficult to
debug, and could probably cause a test to pass when it should not).
4. Add multiprocessCompatible flags so that TPS can still start in nightly (and
because it is).
MozReview-Commit-ID: 98UvRoFOdzv
--HG--
extra : rebase_source : ff1f199eafdcc569cfdf9cb373ee4d059b37ec35
2017-05-05 14:54:03 -04:00
103b72ff2f
Bug 1335891 - Ensure and test that Sync changes don't bump the score. r=markh
...
MozReview-Commit-ID: 4dP5oZS3pm
--HG--
extra : rebase_source : ebada671d4aa5feba290f118e370fd7def093c4a
2017-05-09 13:04:50 -07:00
2401fa0477
Bug 1335891 - Trigger another sync if tracked items have changed during the last sync. r=markh
...
MozReview-Commit-ID: 7EcIX7QrsN4
--HG--
extra : rebase_source : 41f0886f5e40b9b8aaaebc5ebaa40a247bba13ef
2017-05-10 19:21:16 -07:00
3abedf0d48
Bug 1363430: Update kinto-http.js to 4.3.4, r=MattN
...
MozReview-Commit-ID: BenayrfXlKC
--HG--
extra : rebase_source : d8b09f46532eba84adbca253f47f434b3fff918e
2017-05-09 12:27:11 -04:00
0c6fcd0d50
Bug 1362099 - Make RESTRequest handle GET's where the response is > 8192 bytes and we know the charset r=markh
...
MozReview-Commit-ID: 6g8hCvr7ZbJ
--HG--
extra : rebase_source : 740e44f4cf6be265e2c04a78d4737a118f0a1b3f
2017-05-05 16:29:01 -04:00
cd1cbcef0f
Bug 1359350: Add no-eval rule to eslint config (and whitelist failures in tests) r=standard8
...
MozReview-Commit-ID: 4nYlX4sSdbF
--HG--
extra : rebase_source : cf610e7d8bf2b8dbd5a0d40c5b835bc6620c3bba
2017-05-08 14:50:50 +02:00
5fc76a861d
Bug 1361171 - Remove CloudSync. r=markh
...
MozReview-Commit-ID: CjBsEZa6oIP
--HG--
extra : rebase_source : 965db37197242acf63e77dbcca74a2984532b4ff
2017-05-01 14:43:00 -07:00
fdc689ba16
merge mozilla-inbound to mozilla-central a=merge
2017-05-05 15:17:26 +02:00
a1b64b4694
Bug 1319111 - Expose URI to make security check against on LoadInfo (no LOAD_REPLACE flag). r=bz
2017-01-27 19:10:01 +01:00
b3b3ff9cc5
Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
...
MozReview-Commit-ID: K790Ag8WZgv
--HG--
rename : browser/base/content/test/general/accounts_testRemoteCommands.html => browser/base/content/test/sync/accounts_testRemoteCommands.html
rename : browser/base/content/test/general/browser_fxa_web_channel.html => browser/base/content/test/sync/browser_fxa_web_channel.html
rename : browser/base/content/test/general/content_aboutAccounts.js => browser/base/content/test/sync/content_aboutAccounts.js
extra : rebase_source : dcba087df94d06b15c9f073ff2df3324fd646c57
2017-04-18 14:15:43 -04:00
1df337c9ce
Bug 1361572 - Remove Task.jsm/Promise.jsm from services/. r=kitcambridge
...
MozReview-Commit-ID: BBIkpIkWIYc
--HG--
extra : rebase_source : a0f10b07bad20789e2d1c2c2bca133b32bf671aa
2017-05-02 19:29:33 -04:00
18253e3fa2
Backed out changeset 0a0138825fb5 (bug 1353571)
...
--HG--
rename : browser/base/content/test/sync/accounts_testRemoteCommands.html => browser/base/content/test/general/accounts_testRemoteCommands.html
rename : browser/base/content/test/sync/browser_fxa_web_channel.html => browser/base/content/test/general/browser_fxa_web_channel.html
rename : browser/base/content/test/sync/content_aboutAccounts.js => browser/base/content/test/general/content_aboutAccounts.js
2017-05-03 21:56:44 +02:00
c11e66021d
Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
...
MozReview-Commit-ID: K790Ag8WZgv
--HG--
rename : browser/base/content/test/general/accounts_testRemoteCommands.html => browser/base/content/test/sync/accounts_testRemoteCommands.html
rename : browser/base/content/test/general/browser_fxa_web_channel.html => browser/base/content/test/sync/browser_fxa_web_channel.html
rename : browser/base/content/test/general/content_aboutAccounts.js => browser/base/content/test/sync/content_aboutAccounts.js
extra : rebase_source : aa6cb209d312c6ef3f45589b0fd8fa8a39c612e3
2017-04-18 14:15:43 -04:00
b80261a3ec
Bug 1358648 part 3 - Remove Async, Services and XPCOMUtils from util.js. r=markh
...
MozReview-Commit-ID: 8na204K9cXp
--HG--
extra : rebase_source : 96e7738aa6612cf67543d50053f50c2bccf1ab7e
2017-05-02 16:57:37 -04:00
abba8c5b31
Bug 1358648 part 2 - Remove util.js Svc.{DefaultPrefs,Session,Idle, FormHistory} and Str. r=markh
...
MozReview-Commit-ID: Jc1th8Snvhv
--HG--
extra : rebase_source : dd950a5d7bb0f2cb2ea4f32c7b61eb2a15ae327d
2017-05-02 18:30:23 -04:00
712abbc07a
Bug 1358648 part 1 - Clean-up some Weave imports. r=markh
...
MozReview-Commit-ID: 2NK4Mew65UT
--HG--
extra : rebase_source : f515a4c26f2ac515c67d37f4cf01f79427b38221
2017-05-02 18:27:49 -04:00
43a868766b
Backed out changeset 83fe6517d5be (bug 1357116) for eslint failures in blocklist-clients.js. r=backout
2017-05-02 19:59:32 +02:00
ec15502b47
Bug 1357116 - Load the blocklist updater module lazily r=florian,mgoodwin
...
MozReview-Commit-ID: IjdpY9JZQPL
--HG--
extra : rebase_source : 1c2968fff0c0a11f0adf68f0bc9b0905ed4ac457
2017-04-27 14:45:57 +02:00
f2a6a685fe
Bug 1359540 - Enable the Mozilla ESlint recommended rules for services/. r=markh
...
MozReview-Commit-ID: D6qH5XtEtHO
--HG--
extra : rebase_source : 8e4c319c7fb8b727ac0193e5dd78411e1ec2785c
2017-04-27 17:24:18 +01:00
250807ae85
Bug 1347728 - Fix JSON dump of blocklists r=kjozwiak,mgoodwin
...
MozReview-Commit-ID: rwX5Nn9d6b
--HG--
extra : rebase_source : ad24a54d4be06028d1af93cfdb31beb3e4124b1b
2017-03-22 15:46:55 +01:00
8cb9279791
Backed out changeset e6177d883f37 (bug 1359540) for eslint failures
2017-05-02 09:25:45 +02:00
0c2aa823c9
Bug 1359540 - Enable the Mozilla ESlint recommended rules for services/. r=markh
...
MozReview-Commit-ID: D6qH5XtEtHO
--HG--
extra : rebase_source : 3d8d878810c60dc339e196eaac0215f9f72cc829
2017-04-27 17:24:18 +01:00
dcce7ae769
Bug 1348699 - Add test to ensure we don't track left pane queries. r=mak,markh
...
MozReview-Commit-ID: LFoCpvz2rAn
--HG--
extra : rebase_source : c2e927100899b5856d0fc2350efdf0e1ffb52e77
2017-03-20 19:22:15 -07:00
5b32e800fa
Bug 1350030 - Extract `serverForEngine` into `serverForEnginesWithKeys`. r=tcsc
...
MozReview-Commit-ID: 3D1xwv9k76m
--HG--
extra : rebase_source : a27836cea6100fd90e15ed95b08c9f02e6c79605
2017-03-30 18:01:19 -07:00
20f27ffe75
Bug 1361818 - Make sure TPS is aware sync's collection.get method is asynchronous now r=markh
...
Ideally we'd convert this to promises, but this function is already full of
promiseSpinningly's and removing them all is too much work for this bug.
MozReview-Commit-ID: 144JFRwejTb
--HG--
extra : rebase_source : 40371c6cfeee9fddffe4b737cbb98fecb424b719
2017-05-03 15:12:30 -04:00
c90bccb53a
Bug 1356231 - Use toolkit EventEmitter.jsm instead of devtools module. r=mossop
...
MozReview-Commit-ID: 49JI7NtLwKK
--HG--
extra : rebase_source : 7fb015f56be94c4bbe2d56506653f069c9ad8dd3
2017-04-27 17:58:09 +02:00
4b1556a5f2
Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws.
2017-04-27 00:25:45 +02:00
29c680ad80
Bug 1359140 - Fix various ESLint issues in services/ (mostly automatic). r=markh
...
This fixes various errors raised in services for the rules: key-spacing, quotes, no-else-return, no-extra-semi, comma-spacing, object-shorthand.
MozReview-Commit-ID: IClwG5rfXfW
--HG--
extra : rebase_source : 81c059dacfc39b5cf8bc85b9b746dcdd494a3629
2017-04-24 18:52:57 +01:00
1b936ebd82
Bug 1356112 - Set identity.fxaccounts.settings.devices.uri when using the FxA well-known configuration. r=tcsc
...
MozReview-Commit-ID: IJaMuIorXHg
--HG--
extra : rebase_source : 9dc1e723632c1821af5299e6f91c54471c4855f6
2017-04-20 13:57:23 -04:00
00431016d0
Bug 1355677 - Make all Sync network requests promise based. r=kitcambridge,rnewman,tcsc
...
MozReview-Commit-ID: JSwAS4Xd1uy
--HG--
extra : rebase_source : 95724c3b59576d40cafd2f380ff42acb4fc3d553
2017-04-11 23:40:53 +10:00
ceb65c045e
Backed out changeset 816a2cc1254a (bug 1347728) for failing xpcshell's test_blocklist_certificates.js on Windows r=backout
2017-04-20 19:11:04 +02:00
04cf765d30
Bug 1347728 - Fix JSON dump of blocklists r=kjozwiak,mgoodwin
...
MozReview-Commit-ID: rwX5Nn9d6b
--HG--
extra : rebase_source : 5df03011e57211e6cf2d67f1bda3f71d188c7f91
2017-03-22 15:46:55 +01:00
8b9281c90a
Bug 1350135 - Fix failing TPS test_history_collision.js test r=markh
...
There were three issues here: The first is that the TPS's history module didn't
wait for PlacesUtils.history.remove's promise to resolve.
The second is that the SYNC_WIPE_REMOTE in the previous client would cause a
write to the clients collection, which would cause the next client to get a
"sync:collection_changed" push. This caused a sync of *only* the clients
collection upon reciept, which would prevent TPS from explicitly syncing all
engines.
The third is that TPS wasn't correctly handling the cases where logIn would
trigger a sync, which would cause a failure during the first sync of a session.
This would cause failures on other TPS tests as well.
MozReview-Commit-ID: LpqZ7Kt9fyy
--HG--
extra : rebase_source : f1d3c40e2ef4e09cce4d2ce8ae25f2c86ddfee45
2017-04-19 14:38:00 -04:00
0bb64306d4
Bug 1346175 - Record AsyncResource.serverTime in sync telemetry events. r=bsmedberg,markh
...
MozReview-Commit-ID: DG43B9zEHaO
--HG--
extra : rebase_source : 9b16fe1dff50574036fb2e10224d8056fe415ecd
2017-04-04 13:51:16 -04:00
12dcd10d01
Bug 1356567 - root icons should still create a page association if the domain differs. r=adw,kitcambridge
...
Root domain icons are no more associated with their pages, BUT if the page uses
a root domain icon from another domain, it should still get an association with it
or we couldn't relate the two.
This also fixes an overlooked problem in PlacesTestUtils where Date objects
cross a boundary and fail instanceof checks. This causes failures in the same
test that this patch is modifying.
To protect from future similar issues some protection has been added to updatedPlaces
so that it will crash in debug builds.
MozReview-Commit-ID: 3MTKhGj3ehj
--HG--
extra : rebase_source : 55120252e7ea8abb91f21ca2486deddc43795142
2017-04-14 20:34:27 +02:00
16969b40e2
Backed out changeset eb94759f0fcf (bug 1356567) for test failures in own test
2017-04-18 12:58:09 +02:00
5238755b71
Bug 1356567 - root icons should still create a page association if the domain differs. r=adw,kitcambridge
...
Root domain icons are no more associated with their pages, BUT if the page uses
a root domain icon from another domain, it should still get an association with it
or we couldn't relate the two.
This also fixes an overlooked problem in PlacesTestUtils where Date objects
cross a boundary and fail instanceof checks. This causes failures in the same
test that this patch is modifying.
To protect from future similar issues some protection has been added to updatedPlaces
so that it will crash in debug builds.
MozReview-Commit-ID: 3MTKhGj3ehj
--HG--
extra : rebase_source : e36ba1ab41649927f92fee053c10bf43474a0bcf
2017-04-14 20:34:27 +02:00
c05723ef0c
Bug 986501 - Avoid unnecessary compartments on Sync startup r=markh
...
MozReview-Commit-ID: 8Rr3JD4dfVy
--HG--
extra : rebase_source : b18f24229bbd1caf80d9f175a79c1fdb0aeccd0d
2017-04-13 20:36:08 -03:00
c8bcf1e705
Bug 1351915 - Fire onItemChanged when deduping sync bookmarks. r=kitcambridge
...
MozReview-Commit-ID: JHaCz42aRwx
--HG--
extra : rebase_source : 38361447a7900c55dc56cc5b528be5045181fee2
2017-04-08 19:57:39 -04:00
4c6a68d1c9
Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj.
2017-04-14 18:29:12 +02:00
f935ddc4b3
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
37ff4fc7cc
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
159215e6f4
Backed out changeset 18d45aa984d6 (bug 1355161)
2017-04-14 23:39:23 +02:00
a07223d699
Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout
2017-04-14 23:39:22 +02:00
738d097aae
Backed out changeset 55f3df15eaa6 (bug 1356569)
2017-04-14 23:39:17 +02:00
3c564a2b02
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
95d4d20c17
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
a363fb8c8b
Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj.
2017-04-14 18:29:12 +02:00
daf505ef20
Bug 595314 - Add TPS test ensuring that new changes to existing bookmarks are respected by sync r=markh
...
MozReview-Commit-ID: B2A60B3ufYb
--HG--
extra : rebase_source : bc30afdc09497f9bcdda85493f02faa8fe8afb17
2017-04-05 12:39:00 -04:00
3c9fc16ebc
Bug 1345744 - Ensure an error log is written when sync (newly) fails to apply records. r=markh
...
MozReview-Commit-ID: 586faUBtX6n
--HG--
extra : rebase_source : 7e1d0eab656838f3718260a11ef8cd2d9b501d17
2017-04-04 14:18:09 -04:00
ea83c7b70d
Bug 1351906 - Moved log.trace before return statement to fix unreachable code issue in history.js. r=Standard8
2017-04-05 11:03:01 +05:30
1a5c10bc46
Bug 1348454 - use a single thread for IdentityCryptoService; r=jesup
...
Rather than starting a single thread for every key generation and key
signing operation started by IdentityCryptoService, and then leaking
those threads, we can at least start a single thread to be used by all
operations and leak that instead.
2017-04-03 15:41:54 -04:00
d09f746bfb
Bug 1345955 - Update FxA profile when push notification received. r=markh
...
MozReview-Commit-ID: 4LL6F5Qnnj4
--HG--
extra : rebase_source : 00bc6a445d22fdfb626e7af6ad62fb750f444460
2017-03-16 17:15:18 -04:00
74e36e1adb
Merge mozilla-central to autoland on a CLOSED TREE
...
--HG--
extra : amend_source : 5026c19958cdc458c0f0887582fd00b8038fe93e
2017-03-30 16:48:10 +02:00
0ac961905a
Bug 1351659 - Use jwcrypto.jsm with the resource://services-crypto prefix, r=markh.
2017-03-30 09:18:45 +02:00
557fa7b36a
Bug 1350665 - Disable sync repair tests on beta and release. r=kitcambridge
...
MozReview-Commit-ID: 6anD2FJ2aQ2
--HG--
extra : rebase_source : 708b1c52d0ecbad5407d3d27db0c5d14c8bfa73e
2017-03-29 15:27:25 -04:00
f189ba9211
Bug 1349703 - (part 3) Delete a test from TPS that was testing that we made the wrong decision during reconciliation r=kitcambridge
...
MozReview-Commit-ID: KVRcVNJAKfg
--HG--
extra : rebase_source : c37b394f0a97488f783db0b751ea2f5f9c454f8d
2017-03-23 17:18:32 -04:00
250adc135f
Bug 1349703 - (part 2) Fix intermittent TPS failures caused by failing cleanup by waiting longer before starting r=kitcambridge
...
MozReview-Commit-ID: D07eRgqHVOu
--HG--
extra : rebase_source : e08a57c3340cfd22bde9009c8cc960859b719eed
2017-03-23 16:34:04 -04:00
908a695b92
Bug 1349703 - (part 1) Fix issue where sync would fail misreconcile special folders in fresh syncs r=kitcambridge
...
MozReview-Commit-ID: Izy9JgMYpom
--HG--
extra : rebase_source : b740e81aafbabae2947fd26888c677065742db96
2017-03-23 16:32:40 -04:00
2f0a83abc1
Bug 1339340 - Repair items the bookmark validator reports as missing on the client or server. r=tcsc
...
MozReview-Commit-ID: 9Wxq2wfUnkb
--HG--
extra : rebase_source : 133133eb765a403a77ca3bbd0d8302c0a0be49a0
2017-03-24 11:12:48 -04:00
7ebbcc1624
Backed out changeset 16d562074791 (bug 1339340) for failing xpcshell test services/sync/tests/unit/test_doctor.js. r=backout
2017-03-24 00:52:29 +01:00
125d3015c3
Bug 1339340 - Repair items the bookmark validator reports as missing on the client or server. r=tcsc
...
MozReview-Commit-ID: 9Wxq2wfUnkb
--HG--
extra : rebase_source : 8dfe36e5c2d75291e07d61341648dec95b5dd213
2017-03-14 18:02:20 -04:00
55c8025ae4
Bug 1349709 - Ensure `PasswordEngine` conforms to the new `pullAllChanges` interface. r=tcsc
...
This was a regression from bug 1317223. This commit also adds a
password engine sync test to catch future regressions.
MozReview-Commit-ID: 9dq8K39jLwB
--HG--
extra : rebase_source : 346c4abaf639f7781426f4e06e988c76cf552422
2017-03-22 19:21:08 -07:00
d20541b101
Bug 692700 part 2 - Set X-If-Unmodified-Since when uploading crypto/keys. r=markh
...
MozReview-Commit-ID: 9qrr8vuvy1I
--HG--
extra : rebase_source : 9c20bdec7a33d0cde2e31c3109bf3cb9665352ba
2017-03-14 15:56:08 -04:00
1ee65dc313
Bug 692700 part 1 - Set X-If-Unmodified-Since when uploading meta/global. r=markh
...
MozReview-Commit-ID: IoiThiDlvCj
--HG--
extra : rebase_source : f78434e661810f9b42da6d58422713fd20687e28
2017-03-14 14:42:24 -04:00
3d91da8726
Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
...
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.
This allows us to remove a lot of calls for the app locale.
The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.
MozReview-Commit-ID: DzmFEUvMq3N
--HG--
extra : rebase_source : 513ed31d995864939aa893e73c81ffdf591a6617
2017-03-14 16:09:54 -07:00
0a04f3b9e2
Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout
2017-03-22 18:20:26 +01:00
c2cd68a689
Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
...
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.
This allows us to remove a lot of calls for the app locale.
The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.
MozReview-Commit-ID: DzmFEUvMq3N
--HG--
extra : rebase_source : 13fa4c397ba4c79303a2cd76684b5b8c4bd17331
2017-03-14 16:09:54 -07:00
c4565c993a
Bug 1343093 - Add integration test for bookmark repair. r=markh
...
This test replaces the clients engine to simulate two different
clients, and uses `SOURCE_SYNC` to bypass change tracking.
MozReview-Commit-ID: IF3b3WZtain
--HG--
extra : rebase_source : deff5eb74dcbc29d7e7556b4ce6e15590ee4d4a0
2017-03-21 11:54:06 -07:00
bd625e4e9f
Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
...
MozReview-Commit-ID: LH0CQOPfoe6
--HG--
extra : rebase_source : 83eaf40c5cbb5e25cfb3f3b5afadf4fbf0422c92
2017-03-20 12:36:37 +01:00
f38275a306
Bug 1339163 - Make TPS tests attempt to automatically verify fxa emails when using a restmail account r=markh
...
MozReview-Commit-ID: LwBrVSXFqyc
--HG--
extra : rebase_source : c09b6afe7ea3827760618d7fa6421bf36bc601bf
2017-03-17 16:41:58 -04:00
130ff3a299
Bug 1345754 - Skip sync bookmark repair and validation if we have pending changes r=markh
...
MozReview-Commit-ID: ClQRXGZGV9p
--HG--
extra : rebase_source : 4ae8ead7a9121dc383fcfc5ebf757f44e46f5679
2017-03-14 14:26:20 -04:00
6fd1303c2a
merge mozilla-inbound to mozilla-central a=merge
2017-03-21 12:04:43 +01:00
5d7c0bee97
Merge m-c to inbound a=merge
...
MozReview-Commit-ID: 860fBgcgHiy
2017-03-20 18:28:24 -07:00
25f26ab751
Bug 1348570 - Make chrome://weave/locale/ point to the correct folder, r=markh.
2017-03-21 01:31:21 +01:00
4f8d16041f
Bug 1342320 - Use PlacesUtils and not PlacesSyncUtils in sync bookmark decline/undecline test r=markh
...
MozReview-Commit-ID: DgbCeKgSxoE
--HG--
extra : rebase_source : d7a73f871436a3c557e3ea921439da3e6f55e13c
2017-03-14 13:01:10 -04:00
e4ec1eb1d3
Bug 1343735 - Respect max_record_payload_bytes limit. r=markh
...
MozReview-Commit-ID: 1aDwl1cq2Hh
--HG--
extra : rebase_source : a29abc5c1f3b9eefea26fe93b5ee82f4b3d12924
2017-03-15 17:12:17 -04:00
dfa642bc63
Bug 1348743 - avoid running a bookmark validation on every sync. r=tcsc
...
MozReview-Commit-ID: 49sWR56kfrj
--HG--
extra : rebase_source : f13d7ef61b343820347579b76352cd65a322c8eb
2017-03-20 19:13:42 +11:00
1a61788cb8
Backed out changeset a2ec162fa051 (bug 1348743) for eslint failures a=backout
...
MozReview-Commit-ID: 2rfgqYueacf
2017-03-20 16:32:06 -07:00
10c7be4d14
Bug 1348743 - avoid running a bookmark validation on every sync. r=tcsc
...
MozReview-Commit-ID: 49sWR56kfrj
--HG--
extra : rebase_source : e68d0050fb3b6b48e5c61abed98827dbbf449923
2017-03-20 19:13:42 +11:00
d4d95b1155
Bug 1087255 - Convert Sync JS clients of RemovePage(s) to History.remove;r=rnewman
2014-10-31 12:36:19 +01:00
3e0a5441c6
Merge mozilla-central to mozilla-inbound
2017-03-17 14:55:15 +01:00
f13f9ed085
Bug 1347373 - better handling of requests that have only non-existing items and of errors. r=kitcambridge
...
MozReview-Commit-ID: 7kcky3wJb4j
--HG--
extra : rebase_source : 108dde9145e323410e8799053581dc9bb4b80e42
2017-03-16 20:53:06 +11:00
9c4d40bb54
Bug 1345294 - script generated patch (+ some hand cleanup) to replace {get,set}ComplexValue for nsISupportsString by {get,set}StringPref, r=Mossop.
2017-03-16 19:26:01 +01:00
4ad85c5308
Bug 1345023 - Changed SYNC_API_VERSION to 1.5 and updated SUPPORTED_PROTOCOL_VERSIONS to reflect this change. r=markh
...
MozReview-Commit-ID: 98knOLicr9E
--HG--
extra : rebase_source : 1acbb125c0512842abdfab068094cc744ce2d329
2017-03-15 22:18:43 -04:00
2508d8532a
Bug 1086549 - Converting Sync tests from removePage to History.remove. Patch by Yoric, updated by Standard8. r=markh
...
MozReview-Commit-ID: 3dZljFrvJUA
--HG--
extra : rebase_source : 355265e0dbdc169df308ba15212997373f781ea3
2014-10-24 14:57:02 +02:00
a014194719
Bug 1269277 - Add Manage Device button in Synced Tabs menu/sidebar. r=markh
...
MozReview-Commit-ID: 2BMgLeI0DNF
--HG--
extra : rebase_source : d8e1bb4f52723071d395db3ac3c896096ca6df2a
2017-03-10 20:14:51 -05:00
c1edc7067d
merge mozilla-inbound to mozilla-central a=merge
2017-03-13 15:22:26 +01:00
77632ccd1b
Merge m-c to inbound, a=merge
...
MozReview-Commit-ID: JXQqoTEXxwz
2017-03-10 17:22:54 -08:00
4e41b48a97
Bug 1332557 - Enable sync success logs by default on Nightly. r=markh
...
MozReview-Commit-ID: 3c0iIF1ZLr0
--HG--
extra : rebase_source : f074f570dcf2da93ccd73bf4dea3d3a8597d3b54
2017-03-10 15:33:58 +05:30
d1d17eb800
Bug 1345556 - adjust BUG_COMPONENT for services/blocklist/* files. r=leplatrem
...
MozReview-Commit-ID: LmfXawUVhIn
2017-03-10 12:26:58 -05:00
65140a44e3
Merge inbound to central, a=merge CLOSED TREE
...
MozReview-Commit-ID: Gj4s6DtqKmw
2017-03-09 16:33:31 -08:00
682b54d712
Bug 1339861 - Mark Sync clients as stale if not in the FxA device list. r=markh
...
MozReview-Commit-ID: 84Tl3QTHInO
--HG--
extra : rebase_source : c05a5462be71b9eb0bc1bddc6a6a74f1b13088b7
2017-02-28 16:35:01 -05:00
db142ded6a
Bug 1329069: Upgrade kinto-http-client.js to v4.0.0, r=MattN
...
Version 4.0.0 removes the default five-second timeout for all HTTP
requests. This should hopefully fix bug 1329069, bug 1335519, and bug
1333677. It should also make us more robust "in the wild" against
laggy connections or slow servers. We don't need to worry too much
about instituting our own timeout because Necko will impose a timeout
for us according to the preferences network.http.response.timeout and
network.http.keep-alive.timeout.
Version 3.0.0 updates some dependencies and changes some polyfills
around. See https://github.com/Kinto/kinto-http.js/pull/158 for more
details.
MozReview-Commit-ID: 4eAwghOpqfE
--HG--
extra : rebase_source : 9657c3b3f9f0e905845933c123fe099c4408dd29
2017-03-02 17:44:18 -05:00
56b41b115e
Bug 1345009 - remove _migratePrefs() function and related test and references in xpcshell.ini r=markh
...
MozReview-Commit-ID: CbXXPLNXUet
--HG--
extra : rebase_source : 81ace434bc1ecdff3a84b9c8a978343d052ad1ea
2017-03-07 14:41:46 +05:30
35e400d22b
Bug 1345005 - Ensure validation prefs are set for all tests that run a full sync. r=tcsc
...
Some of our tests call `Svc.Prefs.resetBranch("")` or
`Service.startOver()`, which resets the validation prefs to their
default values. This patch makes it a bit more explicit which tests
perform a full sync, and should run validation.
MozReview-Commit-ID: 7a0wR8nuJeW
--HG--
extra : rebase_source : 18ff025671c9dd5e2e30d441940f5c2fb804cae3
2017-03-06 11:29:19 -08:00
7f1b926f29
Bug 1344711 - hand cleanup of cases that were ignored by the script to remove try blocks around get*Pref calls, r=jaws.
...
--HG--
extra : rebase_source : 4da1e10b87ac37de19e0ca6f79996e8a12492db9
2017-03-07 15:29:48 +01:00
Thom Chiovoloni
Edouard Oger
Carsten "Tomcat" Book
Bill McCloskey
Bevis Tseng
Mark Banner
Marco Bonardo
Masatoshi Kimura
ffxbld
Mark Hammond
tiago
Mathieu Leplatre
Sebastian Hengst
Ethan Glasser-Camp
milindl
udara
Ryan VanderMeulen
Kit Cambridge
Shane Tomlinson
Wes Kocher
jomer14
Honza Bambas
Florian Quèze
Frederik Braun
Dan Banner
Alexandre Poirot
hrishikesh
Nathan Froyd
Zibi Braniecki
David Rajchenbach-Teller
Joseph Cameron
BharatR123
Joel Maher