3b4eeee788
Bug 1264192 - Adjust cookie eviction heuristics when exceeding the maximum cookies allowed per host. r=ehsan
...
If no expired cookies exist, in order of preference, evict the oldest:
* session cookie with a non-matching path
* session cookie with a matching path
* non-session cookie with a non-matching path
* non-session cookie with a matching path
This replaces the previous heuristic of evicting the oldest cookie, irregardless of any other attributes,
if no expired cookies were present. This ensures that cookies that are already considered transient by
web applications will be removed first, followed by cookies that are unrelated to the response that is
adding new cookies.
* * *
Bug 1264192 - Interdiff
2016-09-09 16:29:15 -04:00
80e39088f2
Backed out changeset 2ecd402d3934 (bug 1264192) for frequent failure in netwerk/cookie/test/unit/test_eviction.js. r=backout
2016-09-04 15:07:24 +02:00
55292e77a0
Bug 1278037 - Part 1: Modify the getCookiesWithOriginAttributes of the nsICookieManager2 to take the host as an optional argument. r=jdm
...
--HG--
extra : rebase_source : 918c1f81dedb5dfa6ddb9a78b613ace6f34f4758
extra : histedit_source : f28df59c4b608f7311e04dc00bce286624d7ad81
2016-07-28 11:46:04 +08:00
64a98fc3b7
Bug 1264192 - Adjust cookie eviction heuristics when exceeding the maximum cookies allowed per host. r=ehsan
...
If no expired cookies exist, in order of preference, evict the oldest:
* session cookie with a non-matching path
* session cookie with a matching path
* non-session cookie with a non-matching path
* non-session cookie with a matching path
This replaces the previous heuristic of evicting the oldest cookie, irregardless of any other attributes,
if no expired cookies were present. This ensures that cookies that are already considered transient by
web applications will be removed first, followed by cookies that are unrelated to the response that is
adding new cookies.
--HG--
extra : amend_source : f79ba9dd393a3f37760e643b10b7137e37a6397a
2016-08-26 18:04:47 -04:00
054b2202b0
Bug 1298512 - Remove aRequireHostMatch to nsCookieService::CheckPrefs; r=jdm
...
MozReview-Commit-ID: 2SdJhbJtBDO
--HG--
extra : rebase_source : 1c19d0de7f2c8052a7691d474a864e260c35daba
2016-08-26 21:42:04 -04:00
d6202de12b
Bug 1283368 - Implement cookie prefixes spec, r=valentin r=amchung
2016-06-29 22:42:36 -07:00
704a204aff
Bug 1276442 - Backout 6647b13a6ad9 (Bug 219157) a=backout
2016-05-30 16:05:21 +02:00
ce5b229c18
Bug 219157 - Fix to prevent 3rd party sites from getting cookies r=valentin
...
MozReview-Commit-ID: A0ltsuDnxnf
2016-05-20 16:48:00 +02:00
7bf2d7f142
Bug 1214071 - Replace Get/RemoveCookiesForApp() with Get/RemoveCookiesWithOriginAttributes() r=ehsan
...
MozReview-Commit-ID: JTi1BwBVvyA
2016-01-08 17:58:56 +08:00
b88bc4f2a4
Bug 1199466 - part 1 - Expose originAttributes in nsICookie, r=jduell
2016-01-14 08:03:50 +00:00
4b500464f5
Bug 1209162 - Create OriginAttributes subtypes. IGNORE IDL r=sicking.
2015-11-03 09:50:54 +08:00
8364215e41
Bug 1220570 - Potential cookie lost while downgrading from Aurora 44 to 43. r=jduell
...
--HG--
extra : rebase_source : f5fdca0cca8b67dd2ffb702993dfa3559cab08b9
2015-11-03 18:40:58 +08:00
01583602a9
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
bb095c04f4
Bug 1165267 - Part 1: Replace appId and inBrowser by originAttributes v2. r=honzab
2015-09-03 18:22:51 +08:00
01846026c1
Bug 1182961 (part 5, attempt 2) - Use nsTHashtable::Iterator in nsCookieService. r=michal.
2015-07-26 23:40:51 -07:00
daab3fdaf7
Backout bff74cecc67c, ffe0edb2aae7, b60b7c267cef, 6da154b43265, bcf6fd3ab9bb (bug 1182961 parts 1--5) for possible intermittent failures and performance problems.
...
--HG--
extra : rebase_source : 97ab1452e462b1ff24cc77bdadf2a6e82800690d
2015-08-06 16:30:47 -07:00
b32aa53dc2
Bug 1182961 (part 5) - Use nsTHashtable::Iterator in nsCookieService. r=michal.
...
--HG--
extra : rebase_source : a43f8ec3918bbdb226079f6d4503a0b117639863
2015-07-26 23:40:51 -07:00
605f42ffc0
Bug 1184395 - Remove nsCookieService::mObserverService; r=jdm
...
This is done to ensure that the cookie service cannot hold the observer
service alive.
2015-07-17 21:09:04 -04:00
a8939590de
Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
...
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
2015-07-13 08:25:42 -07:00
8fe0ce4a62
Bug 1155169 - Avoid restoring the same cookie twice if the previous version of the cookie is not stale; r=jdm
2015-07-09 08:54:25 -04:00
7d1e52f2ff
Bug 905127 - Part 1 - Make some functions from nsNetUtil not inline. r=jduell
2015-07-07 04:17:00 +02:00
cb54385682
Bug 1156632 - Remove unused forward class declarations - patch 4 - netwerk image and dom, r=ehsan
2015-04-22 08:29:20 +02:00
e6f385fb3d
Bug 1148527 - Indentation fix after bug 1145631, r=ehsan
2015-03-27 18:52:19 +00:00
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
1a013270b5
bug 1105074 - make more stuff final r=froydnj
2014-11-25 13:56:07 -05:00
748c8aca19
Bug 1048271 - Fix more bad implicit constructors in netwerk; r=mcmanus
2014-08-05 09:20:24 -04:00
ff32bb14c1
Bug 1028588 - Fix dangerous public destructors in netwerk/ - r=mcmanus
2014-06-24 12:36:44 -04:00
59b969f7f4
Bug 869836 - Part 8: Use `Append('c')` instead of `Append("c")`. r=ehsan
2014-05-22 06:48:52 +03:00
826df07705
Bug 984786 part 7: Give NS_INLINE_DECL_*REFCOUNTING classes private destructor & MOZ_FINAL annotation where appropriate, in /netwerk. r=hurley
2014-04-02 11:20:46 -07:00
10664c28e1
Bug 989676: Remove redundant 'const' qualifier applied to already-'const' typedefs in nsCookieService.h. r=hurley
2014-04-01 18:18:36 -07:00
1b83407ce9
Bug 927728 - Part 1: Replace PRUnichar with char16_t; r=roc
...
This patch was automatically generated by the following script:
#!/bin/bash
# Command to convert PRUnichar to char16_t
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*modules/libmar*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name prtypes.h \
! -name Char16.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRUnichar char16_t
2014-01-04 10:02:17 -05:00
91175eb896
Bug 955942 (part 2) - Remove MemoryUniReporter. r=mccr8.
...
--HG--
extra : rebase_source : 9d70016cb19637ffece6409a184bf41d574cc6b4
2013-12-07 22:09:10 -08:00
67bb073574
Bug 946870 - make the cookie service report its memory; r=ehsan,njn
2013-12-03 16:58:41 -05:00
8975ae03b9
Bug 784739 - Switch from NULL to nullptr in netwerk/ (1/2); r=ehsan
2013-09-19 15:28:26 -04:00
03e7828db2
Bug 910989. Remove nsTHashtable::Init, fallible allocation, and MT hashtables. r=ehsan,bsmedberg
...
--HG--
extra : rebase_source : 0787130b1814c74bfb38dc178de94022f0b2e64e
2013-09-02 20:41:57 +12:00
a4528c0dc2
Bug 897033 - Fix nsCookieService's statement finalization. r=ehsan
2013-07-23 16:41:23 -04:00
1cebff6f78
Bug 837326 - Informing observers upon accept/reject of a third-party cookie;r=ehsan
2013-06-22 07:11:12 +02:00
72a9f29c5d
Backout 65804eae62b1, a0b216d3be12, 68e5d9fe91fc (bug 837326) for impending bustage that would make this CLOSED TREE worse than it already is
2013-06-21 15:39:45 -04:00
6de9b437ab
Bug 837326 - Informing observers upon accept/reject of a third-party cookie;r=ehsan
2013-06-21 21:18:59 +02:00
ca0201607a
Backed out changeset 75fa13b20c1d (bug 837326)
2013-06-21 18:21:08 +01:00
7b8194e587
Bug 837326 - Informing observers upon accept/reject of a third-party cookie;r=ehsan
2013-06-21 17:48:31 +02:00
529b037b7c
Bug 818340 - change third party cookie handling to block third party cookies from sites I haven't visited. (r=jdm, r=dolske)
...
--HG--
extra : rebase_source : f486f39feac1fb743edc920618bec29884d515f1
2013-02-22 08:16:01 -08:00
b4fc8f6d3a
Bug 722850 - Part 3: Check the private browsing status of channels when checking cookie permissions. r=mconnor
2012-02-01 05:20:01 -05:00
a7cb2b3434
Bug 722850 - Part 2: Query the private browsing status of channels used to manipulate cookies. r=mconnor
2012-02-08 13:37:07 -05:00
fd965f5f0b
Backout 7a0fe388a24b, 2a9fbd15cad4, 320c1567e431 & d907ac7bf669 (bug 722850) for xpcshell & browser-chrome failures
2012-11-16 14:18:41 +00:00
de3382698e
Bug 722850 - Part 3: Check the private browsing status of channels when checking cookie permissions. r=mconnor
2012-02-01 05:20:01 -05:00
624e9dce37
Bug 722850 - Part 2: Query the private browsing status of channels used to manipulate cookies. r=mconnor
2012-02-08 13:37:07 -05:00
a54c38a647
Bug 795203 - B2g: clear private data: cookies. r=mconnor,jduell
2012-09-28 17:03:00 -07:00
b95ab79e45
Bug 795351: Replace LL_MAXINT, LL_MININT, LL_MAXUINT with stdint versions; r=ehsan
2012-09-28 14:55:23 -05:00
599443f29a
Bug 783408 - 3/4 - Delete app's cookies when uninstalled. r=jlebar,mconnor
2012-09-27 22:37:28 +01:00
Josh Matthews
Sebastian Hengst
Tim Huang
Sumit Tiwari
Daniel Veditz
Valentin Gosu
mitchdevel
Ethan Tseng
Andrea Marchesini
Yoshi Huang
Nathan Froyd
Nicholas Nethercote
Ehsan Akhgari
Birunthan Mohanathas
Emanuel Hoogeveen
Trevor Saunders
Benoit Jacob
Daniel Holbert
Robert O'Callahan
David Rajchenbach-Teller
Ed Morley
Jonathan Mayer
Jason Duell
Isaac Aggrey
Mounir Lamouri