Tom Tung
8e88ce043f
Bug 1528690 - P1 - Mitigate the issue by checking the pointer before accessing it; r=asuth
...
The real problem is because the connection was closed for some reason. This
patch won't resolve the issue by only let the operation and the transaction fail
to escape from the crash. Note that it also changing an assertion when the
transaction is either commiting or aborting. This is prevent the problem for
closing connection is worser than we expected.
Differential Revision: https://phabricator.services.mozilla.com/D28148
--HG--
extra : moz-landing-system : lando
2019-04-19 14:32:53 +00:00
Andreea Pavel
e5b695eefd
Merge mozilla-inbound to mozilla-central. a=merge
2019-04-19 00:36:23 +03:00
Brian Grinstead
7ab932d712
Bug 1544051 - Part 2 - Remove some references to AddTask.js that aren't caught by the script in part 3 r=ahal
...
Differential Revision: https://phabricator.services.mozilla.com/D27760
--HG--
extra : moz-landing-system : lando
2019-04-18 16:50:39 +00:00
Bogdan Tara
a14816abd2
Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE
2019-04-18 00:49:46 +03:00
violet
10f7f3704a
Bug 1509168 - Use JS_GetObjectAsArrayBufferView() to retrieve ArrayBufferView data r=asuth
...
When using JS_IsArrayBufferViewObject() to check ArrayBufferView object,
we should use JS_GetObjectAsArrayBufferView() to get its length and data.
Because in rare case there might be a wrapper on the object, JS_GetObjectAsArrayBufferView()
will handle it, js::GetArrayBufferViewLengthAndData() won't.
Differential Revision: https://phabricator.services.mozilla.com/D24009
--HG--
extra : moz-landing-system : lando
2019-04-17 12:59:20 +00:00
violet
0a2e5d2dc2
Bug 1505821 - DeserializeFromString should append an empty string for a trailing comma r=asuth
...
KeyPath [..., ''] will be serialized to have a trailing comma, when deserializing it, we should
append back the empty string. Otherwise we will get inconsistent result with the KeyPath::Parse() method, causing assertions failure.
Differential Revision: https://phabricator.services.mozilla.com/D24724
--HG--
extra : moz-landing-system : lando
2019-04-17 12:52:46 +00:00
Jan Varga
bb200f7d87
Bug 1541771
- LSNG: Don't cache usage in InitOrigin if it's not for temporary storage initialization; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D27490
2019-04-15 13:35:38 +02:00
Brian Grinstead
c4fa4cfc0c
Bug 1544322 - Part 4 - Remove the [type] attribute for multiline <script> tags loading files in /tests/SimpleTest/ r=bzbarsky
...
This is an autogenerated commit to handle scripts loading mochitest harness files, in
the case where the script src is on the line below the script tag.
This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 4` argument.
Differential Revision: https://phabricator.services.mozilla.com/D27459
--HG--
extra : moz-landing-system : lando
2019-04-16 04:01:46 +00:00
Brian Grinstead
911776d674
Bug 1544322 - Part 3 - Remove the [type] attribute for multiline <script> tags loading files in chrome://mochikit/content/ r=bzbarsky
...
This is an autogenerated commit to handle scripts loading mochitest harness files, in
the case where the script src is on the line below the script tag.
This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 3` argument.
Differential Revision: https://phabricator.services.mozilla.com/D27458
--HG--
extra : moz-landing-system : lando
2019-04-16 03:59:25 +00:00
Brian Grinstead
0d460e3432
Bug 1544322 - Part 2.2 - Remove the [type] attribute for one-liner <script> tags loading files in /tests/SimpleTest/ in dom/ r=bzbarsky
...
This is split from the previous changeset since if we include dom/ the file size is too
large for phabricator to handle.
This is an autogenerated commit to handle scripts loading mochitest harness files, in
the simple case where the script src is on the same line as the tag.
This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 2` argument.
Differential Revision: https://phabricator.services.mozilla.com/D27457
--HG--
extra : moz-landing-system : lando
2019-04-16 03:53:28 +00:00
Jan Varga
4a63e6637b
Bug 1539393 - TransactionDatabaseOperationBase::ActorDestroy doesn't check if we are waiting for the Continue message; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D27429
2019-04-13 16:52:29 +02:00
Andrea Marchesini
bd74d6c75d
Bug 1536411 - StoragePrincipal - part 3 - IDBFactory, r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D24027
--HG--
extra : moz-landing-system : lando
2019-04-12 05:31:13 +00:00
Jan Varga
9581f4b34a
Bug 1543089 - IDB: Detect missing unregister calls for live databases and factory ops using CheckedUnsafePtr; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D26716
2019-04-09 15:48:20 +02:00
Jan Varga
2001874a68
Bug 1542541 - FactoryOp::ActorDestroy needs to do cleanup if the actor was waiting for the PermissionRetry message; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D26433
2019-04-06 23:27:07 +02:00
Sylvestre Ledru
03c8e8c2dd
Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
...
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D26098
--HG--
extra : moz-landing-system : lando
2019-04-05 21:41:42 +00:00
Jan Varga
d99e1a2b0c
Bug 1538619 - TransactionDatabaseOperationBase::SendFailureResult not called if the actor has been destroyed; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D24744
2019-03-25 19:11:01 +01:00
Jan Varga
0269846741
Bug 1540668 - IDB: Add a timer for ShutdownWorkThreads; r=asuth, dr=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D25745
2019-04-02 13:16:55 +02:00
Eden Chuang
72b79c6fbd
Bug 1442778 - Add "chromeContext" parameter to console API and console service messages. r=smaug
...
1. Adding a new attribute chromeContext in ConsoleEvent
2. Adding a new boolean attribute isFromChromeContext in nsIConsoleMessage
3. Sending IsFromChromeContext to the parent process
Differential Revision: https://phabricator.services.mozilla.com/D23330
--HG--
extra : moz-landing-system : lando
2019-04-01 22:42:34 +00:00
Andrea Marchesini
484db81418
Bug 1455020 - Extend CheckInnerWindowCorrectness() to check the state of the worker, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D25486
--HG--
extra : moz-landing-system : lando
2019-04-01 16:46:46 +00:00
Andrea Marchesini
da174a4757
Bug 1539407
- Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D25041
--HG--
extra : moz-landing-system : lando
2019-03-29 18:05:11 +00:00
Daniel Varga
7af208ab28
Backed out changeset 98452610cfcc (bug 1539407
) for browser-chrome failure at /builds/worker/workspace/build/src/dom/indexedDB/IDBRequest.cpp:284. On a CLOSED TREE
...
--HG--
extra : histedit_source : 236c5d6a7a4440a7b545c1ec5a0a72a8c5777b6b
2019-03-29 18:01:58 +02:00
Andrea Marchesini
788d12712b
Bug 1539407
- Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D25041
--HG--
extra : moz-landing-system : lando
2019-03-29 14:12:04 +00:00
Oana Pop Rus
226e6c59d9
Merge mozilla-central to autoland. a=merge CLOSED TREE
2019-03-28 12:23:56 +02:00
Oana Pop Rus
47e94b5d6e
Merge inbound to mozilla-central. a=merge
2019-03-28 12:11:35 +02:00
Mark Banner
dba6983e75
Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D23850
--HG--
extra : moz-landing-system : lando
2019-03-28 09:38:14 +00:00
Andrew McCreight
dcf186c6a2
Bug 1539261, part 1 - IndexedDB changes. r=asuth
...
The second place doesn't return an error because that's what some
earlier code in the method does. Hopefully that is ok.
Differential Revision: https://phabricator.services.mozilla.com/D24991
--HG--
extra : moz-landing-system : lando
2019-03-27 20:41:10 +00:00
arthur.iakab
7ae8fb76e1
Backed out 2 changesets (bug 1539261) for multiple build bustages on /fuzz-tests/testStructuredCloneReader.cpp CLOSED TREE
...
Backed out changeset 526daf87fff9 (bug 1539261)
Backed out changeset 5b070b6ae224 (bug 1539261)
2019-03-27 21:59:29 +02:00
Andrew McCreight
bef5751910
Bug 1539261, part 1 - IndexedDB changes. r=asuth
...
The second place doesn't return an error because that's what some
earlier code in the method does. Hopefully that is ok.
Differential Revision: https://phabricator.services.mozilla.com/D24991
--HG--
extra : moz-landing-system : lando
2019-03-27 19:34:44 +00:00
Jan Varga
2b16bbc8e9
Bug 1534202 - Don't schedule a file deletion after quota client shutdown; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D24970
2019-03-26 21:49:40 +01:00
Cosmin Sabou
78fc71e3c3
Backed out changeset 7fa7d6e6dedc (bug 1442778) for devtools failures on browser_webconsole_check_stubs_console_api.js CLOSED TREE
2019-03-26 20:27:55 +02:00
Eden Chuang
5e4df764d9
Bug 1442778 - Add "chromeContext" parameter to console API and console service messages. r=smaug
...
1. Adding a new attribute chromeContext in ConsoleEvent
2. Adding a new boolean attribute isFromChromeContext in nsIConsoleMessage
3. Sending IsFromChromeContext to the parent process
Differential Revision: https://phabricator.services.mozilla.com/D23330
--HG--
extra : moz-landing-system : lando
2019-03-26 15:18:20 +00:00
Ian Moody
fe4fab15e3
Bug 1537776 - dom/ automated ESLint no-throw-literal fixes. r=asuth,mccr8
...
Result of running:
$ mach eslint -funix dom/ | sed -Ee 's/:.+//' - | xargs sed -E \
-e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
-e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
-e 's/throw \(/throw new Error(/g' -i
Differential Revision: https://phabricator.services.mozilla.com/D24369
--HG--
extra : moz-landing-system : lando
2019-03-25 16:03:38 +00:00
violet
44ea792130
Bug 1507229 - Argument sanity check at CreateMutableFile() to avoid assertion failure r=janv
...
CreateMutableFile() doesn't allow empty name, we should check it before
further processing to avoid assertion failure.
Differential Revision: https://phabricator.services.mozilla.com/D23999
--HG--
extra : moz-landing-system : lando
2019-03-22 14:01:31 +00:00
Alex Gaynor
6039e80432
Bug 1513911 - Part 3 - replace PIndexedDBPermissionRequest with async returns in IPC; r=asuth
...
This removes the only case of an IPDL protocol which has two implementors.
Differential Revision: https://phabricator.services.mozilla.com/D14468
--HG--
extra : moz-landing-system : lando
2019-03-22 19:14:01 +00:00
Tom Tung
e51da80607
Bug 1423917 - P10 - Remove .tmp file in idb drectories in the 2_1to2_2 upgrade; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D21733
--HG--
extra : moz-landing-system : lando
2019-03-20 13:32:49 +00:00
Mihir
a24deb683c
Bug 1532944 - Remove unnecessary ESLint disabling mozilla/no-cpows-in-tests comments. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D24148
--HG--
extra : moz-landing-system : lando
2019-03-20 13:58:47 +00:00
Edwin Gao
bb0492c3e0
Bug 1535784 - disable all instances of test_event_listener_leaks.html r=jmaher
...
Disabled all instances of test_event_listener_leaks.html scattered across the `dom/` test suite.
There exists a bug, 1530894 to track the failures, which has seen no movement for the 3 weeks it has been on file for.
Differential Revision: https://phabricator.services.mozilla.com/D23755
--HG--
extra : moz-landing-system : lando
2019-03-18 18:15:46 +00:00
Alex Gaynor
0547854c42
Bug 1535397 - Part 5 - use native Maybe syntax in place of OptionalKeyRange in IDPL; r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D23562
--HG--
extra : moz-landing-system : lando
2019-03-15 17:39:59 +00:00
Alex Gaynor
d3444f6ef7
Bug 1535397 - Part 4 - use native Maybe syntax in place of NullableVersion in IDPL; r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D23561
--HG--
extra : moz-landing-system : lando
2019-03-15 17:10:29 +00:00
Alex Gaynor
e226477611
Bug 1535397 - Part 3 - use native Maybe syntax in place of FileRequestSize and FileRequestLastModified in IDPL; r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D23560
--HG--
extra : moz-landing-system : lando
2019-03-15 17:10:13 +00:00
Andrea Marchesini
6b7df33f3a
Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 10 - Fix existing tests, r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D18958
--HG--
extra : moz-landing-system : lando
2019-03-08 09:03:15 +00:00
Jan Varga
863112a0eb
Bug 1526891 - Part 11: Initiate asynchronous deletion of unreferenced files in IDB databases directly on the PBackground thread instead of going through the main thread; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D20920
2019-02-23 17:25:48 +01:00
Jan Varga
dea641b977
Bug 1526891 - Part 4: Add QuotaManager::IsPrincipalInfoValid checks to all quota clients; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D20913
2019-02-23 17:03:40 +01:00
Dorel Luca
ac34e1d973
Backed out 16 changesets (bug 1525245) for Android failures. CLOSED TREE
...
Backed out changeset 9f8a1b410320 (bug 1525245)
Backed out changeset 0ef284a9a1d5 (bug 1525245)
Backed out changeset 835e5f642a03 (bug 1525245)
Backed out changeset 362f5a8d033c (bug 1525245)
Backed out changeset 9da3ab33cf67 (bug 1525245)
Backed out changeset 6aacd2d6e835 (bug 1525245)
Backed out changeset 8ff9e8f45e02 (bug 1525245)
Backed out changeset 2020227181cc (bug 1525245)
Backed out changeset fc3c64c330b9 (bug 1525245)
Backed out changeset 2762bf88e050 (bug 1525245)
Backed out changeset ffc10fdc50a6 (bug 1525245)
Backed out changeset bb6ade1207d7 (bug 1525245)
Backed out changeset 1875eb5085e4 (bug 1525245)
Backed out changeset 7e4f67a6d6f1 (bug 1525245)
Backed out changeset e671fc9581eb (bug 1525245)
Backed out changeset b89f5def8d0d (bug 1525245)
2019-03-06 21:07:49 +02:00
Andrea Marchesini
cc69a8960f
Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 10 - Fix existing tests, r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D18958
--HG--
extra : moz-landing-system : lando
2019-03-06 17:03:08 +00:00
Jeff Walden
3f385ffa33
Bug 1532005 - Implement a new js/public/ArrayBuffer.h header to centralize functionality for creating and interacting with ArrayBuffers. r=sfink
...
Differential Revision: https://phabricator.services.mozilla.com/D21827
--HG--
extra : rebase_source : 833bbfce12d90bcb92f7cd88ec65247e48c024c0
2019-03-04 15:19:16 -08:00
Razvan Maries
65e4948ca0
Backed out 4 changesets (bug 1532005, bug 1531638) for causing perma fails and Spidermonkey fail. CLOSED TREE
...
Backed out changeset 4913d941de92 (bug 1532005)
Backed out changeset 9635abe5bf24 (bug 1532005)
Backed out changeset 738cf4b1126a (bug 1532005)
Backed out changeset e5d9f2ee7ac7 (bug 1531638)
2019-03-05 01:07:28 +02:00
Jeff Walden
ecb4e10bda
Bug 1532005 - Implement a new js/public/ArrayBuffer.h header to centralize functionality for creating and interacting with ArrayBuffers. r=sfink
...
Differential Revision: https://phabricator.services.mozilla.com/D21827
--HG--
extra : rebase_source : 36c43233ad6d804bd691c8c40d6a6984331c7162
2019-02-28 17:00:56 -08:00
Ryan Hunt
00e98538aa
Bug 1523969 part 6 - Move method definition inline comments to new line in 'dom/'. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D21106
--HG--
extra : rebase_source : ea3f51c2c11247114deccbc86e90fb02b8a97257
2019-02-25 16:05:29 -06:00
Boris Zbarsky
22300625a2
Bug 1489308 part 10. Remove some document.open handling in outer window that's no longer needed. r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D18077
--HG--
extra : moz-landing-system : lando
2019-02-27 05:36:38 +00:00