Dorel Luca
1ff59cb7a3
Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE
2020-10-22 03:51:06 +03:00
Ricky Stewart
50762dacab
Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
...
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Dimi Lee
d56e33dd5e
Bug 1669731 - P1. Rename STATE_UNBLOCKED_UNSAFE_CONTENT to STATE_UNBLOCKED_TRACKING_CONTENT r=timhuang
...
unsafe content is for Safe Browsing(phishing, malware, etc), we should use tracking content instead.
Differential Revision: https://phabricator.services.mozilla.com/D93269
2020-10-14 09:16:39 +00:00
julianwels
341416588c
Bug 1653026 - Added HTTPS-Only Mode upgrade info to browser UI state. r=mattwoodrow,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D86566
2020-10-06 00:34:55 +00:00
Brindusan Cristian
2a9b39efce
Backed out 2 changesets (bug 1653026) for mochitest failures at WindowGlobalParent.cpp. CLOSED TREE
...
Backed out changeset 54c69c99b241 (bug 1653026)
Backed out changeset e70649f78910 (bug 1653026)
2020-10-03 10:49:04 +03:00
julianwels
30a6225652
Bug 1653026 - Added HTTPS-Only Mode upgrade info to browser UI state. r=mattwoodrow,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D86566
2020-10-03 01:22:19 +00:00
Dimi Lee
f3da525903
Bug 1662362 - Record STATE_UNBLOCKED_UNSAFE_CONTENT event to content blocking log when unblock API of URL Classifier is called r=nhnt11,timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D88957
2020-09-11 17:48:29 +00:00
Henri Sivonen
76563e652c
Bug 1606499 - Abort document on location.reload(). r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D89439
2020-09-10 14:37:16 +00:00
Matt Woodrow
27bb5a7ac9
Bug 1643204 - Fire pageshow event when we finish loading a Document.open load, if we haven't already fired one for the Document. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D84934
2020-08-27 03:51:22 +00:00
Narcis Beleuzu
a502871f99
Backed out changeset da1424ee1d11 (bug 1643204) for wpt failure on reload.window.html CLOSED TREE
2020-08-27 04:56:35 +03:00
Matt Woodrow
5193267988
Bug 1643204 - Fire pageshow event when we finish loading a Document.open load, if we haven't already fired one for the Document. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D84934
2020-08-26 10:11:13 +00:00
Sebastian Streich
27e2164c57
Bug 1656296 - Pass Blocked Downloads to the DownloadsUI r=ckerschb,Gijs
...
***
***
Added Better Testing
Differential Revision: https://phabricator.services.mozilla.com/D85439
2020-08-24 15:29:23 +00:00
Cosmin Sabou
05ab468b46
Backed out changeset 388c153da388 (bug 1656296) for causing default process leaks. CLOSED TREE
2020-08-19 21:58:03 +03:00
Sebastian Streich
b578e23a52
Bug 1656296 - Pass Blocked Downloads to the DownloadsUI r=ckerschb,Gijs
...
***
***
Added Better Testing
Differential Revision: https://phabricator.services.mozilla.com/D85439
2020-08-19 17:58:57 +00:00
Narcis Beleuzu
0e759593c7
Backed out changeset 1b7eb33c8ec9 (bug 1656296) for bc failure on browser_test_mixed_content_download.js . CLOSED TREE
2020-08-19 16:39:33 +03:00
Sebastian Streich
a797186639
Bug 1656296 - Pass Blocked Downloads to the DownloadsUI r=ckerschb,Gijs
...
***
***
Added Better Testing
Differential Revision: https://phabricator.services.mozilla.com/D85439
2020-08-19 12:45:55 +00:00
Simon Giesecke
9364b353d4
Bug 1648010 - Remove NS_NAMED_LITERAL_CSTRING and NS_NAMED_LITERAL_STRING macros. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80631
2020-07-01 08:42:31 +00:00
Simon Giesecke
cd8b8939b9
Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Matt Woodrow
213fab51e4
Bug 1646892 - Allow DocumentChannel process switches into the parent process. r=jya,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80327
2020-06-27 04:10:23 +00:00
Matt Woodrow
9e57de431f
Bug 1626362 - Don't return a failure from nsDocumentOpenInfo::OnStartRequest if we decide to handle the response with the external helper app and then fail. r=nika
...
The WPT a-download-click-404.html requires this behaviour for links with the download attribute, and this is also the current behaviour for Content-Disposition: Attachment (see bug 1604308).
This previously worked because the parent process version of nsDocumentOpenInfo failed (with NS_ERROR_FILE_NOT_FOUND), but the error code was discarded and we forwarded the channel to the content process. The content process version then would then return NS_ERROR_WONT_HANDLE_CONTENT since the load requires downloading, but we don't allow that in the content process. This new error code is one that doesn't have an associated error page (unlilke the original error), so was silently discarded.
Differential Revision: https://phabricator.services.mozilla.com/D81014
2020-06-25 22:13:31 +00:00
Matt Woodrow
00dc8d3d73
Bug 1646582 - Remove DOM(Inner)WindowID from nsIWebProgress. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80128
2020-06-24 19:58:15 +00:00
Dorel Luca
90a64f0da1
Backed out 4 changesets (bug 1646582) for Browser-chrome failures on nsIWebProgress.addProgressListener. CLOSED TREE
...
Backed out changeset 2111dd0d6dc0 (bug 1646582)
Backed out changeset e6c496c5a4b1 (bug 1646582)
Backed out changeset 49b4ae8c8be0 (bug 1646582)
Backed out changeset 9d42ec89240c (bug 1646582)
2020-06-24 07:50:07 +03:00
Matt Woodrow
21ac707a3b
Bug 1646582 - Remove DOM(Inner)WindowID from nsIWebProgress. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80128
2020-06-24 03:24:21 +00:00
Narcis Beleuzu
b894acb874
Backed out 4 changesets (bug 1646582) for mochitest failures on test_ext_tabs_create.html . CLOSED TREE
...
Backed out changeset ce5cdfc5d7cf (bug 1646582)
Backed out changeset 2ac69a2b6708 (bug 1646582)
Backed out changeset 74d89cb24414 (bug 1646582)
Backed out changeset 7de0ff1af560 (bug 1646582)
2020-06-23 06:30:03 +03:00
Matt Woodrow
79562a2ca1
Bug 1646582 - Remove DOM(Inner)WindowID from nsIWebProgress. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80128
2020-06-23 01:23:57 +00:00
Kris Maglione
79760bfbb6
Bug 1642425: Part 3 - Fix nsDocLoader::GetIsTopLevel under Fission. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D77702
2020-06-17 18:01:10 +00:00
Nika Layzell
cde53b3bec
Bug 1508306 - Part 1: Migate the Large-Allocation handler to DocumentLoadListener, r=mattwoodrow,necko-reviewers,geckoview-reviewers,agi,valentin
...
This removes the diagnostic warnings which used to be logged when the
Large-Allocation header was present, but failed to switch into a
Large-Allocation process. Due to the low adoption of the header, this shouldn't
be too large of a problem, but we can look into re-adding the diagnostics if
needed in the future.
The new codepath no longer performs multiple network requests for
Large-Allocation resources, and now relies on the battle-tested
DocumentLoadListener codepath for process switching.
Differential Revision: https://phabricator.services.mozilla.com/D78998
2020-06-15 23:24:07 +00:00
Simon Giesecke
0735ecafd8
Bug 1645382 - Remove unnecessary arguments from NS_OBSERVER_ARRAY_NOTIFY_* macros. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D79485
2020-06-15 09:05:00 +00:00
Narcis Beleuzu
a8dde16e58
Backed out 10 changesets (bug 1508306, bug 1640019) for bc failures on browser_autoOpen.js . CLOSED TREE
...
Backed out changeset 8844170ff408 (bug 1508306)
Backed out changeset b750f1d873cf (bug 1508306)
Backed out changeset c7170e76e676 (bug 1640019)
Backed out changeset 5905995e4815 (bug 1640019)
Backed out changeset 7bf86513348e (bug 1640019)
Backed out changeset f7d0605295f7 (bug 1640019)
Backed out changeset 521b4d5a9a89 (bug 1640019)
Backed out changeset 8542edc564bc (bug 1640019)
Backed out changeset 4f6a03152526 (bug 1640019)
Backed out changeset 30d2bf04719b (bug 1640019)
2020-06-12 22:47:50 +03:00
Nika Layzell
47c0aeb539
Bug 1508306 - Part 1: Migate the Large-Allocation handler to DocumentLoadListener, r=mattwoodrow,necko-reviewers,geckoview-reviewers,agi,valentin
...
This removes the diagnostic warnings which used to be logged when the
Large-Allocation header was present, but failed to switch into a
Large-Allocation process. Due to the low adoption of the header, this shouldn't
be too large of a problem, but we can look into re-adding the diagnostics if
needed in the future.
The new codepath no longer performs multiple network requests for
Large-Allocation resources, and now relies on the battle-tested
DocumentLoadListener codepath for process switching.
Differential Revision: https://phabricator.services.mozilla.com/D78998
2020-06-12 16:52:13 +00:00
Alexis Beingessner
5ea808f2bd
Bug 1642722 - convert the nsURILoader.cpp VarCache prefs to StaticPrefs. r=KrisWright
...
converts:
* dom.largeAllocationHeader.enabled
* general.document_open_conversion_depth_limit
Differential Revision: https://phabricator.services.mozilla.com/D78916
2020-06-09 23:03:55 +00:00
Matt Woodrow
7adf95e964
Bug 1620679 - Don't fire load event from within Stop(). r=smaug
...
This matches what the spec says, and what blink does.
Differential Revision: https://phabricator.services.mozilla.com/D73994
2020-05-30 17:19:54 +00:00
Matt Woodrow
38ffa87e05
Bug 1640160 - Serialize mRequestContextId with BrowsingContext's IPCInitializer to ensure that we don't try to create a request context with an id of 0. r=nika
...
This was a bit of pain to track down, because some code was allowing an ID of 0, and creating a request context to match, but other code was treating 0 as invalid.
Differential Revision: https://phabricator.services.mozilla.com/D76652
2020-05-26 21:14:27 +00:00
Butkovits Atila
1d2238af48
Backed out 2 changesets (bug 1620679) for perma Reftest failure. CLOSED TREE
...
Backed out changeset 8190c67514cc (bug 1620679)
Backed out changeset 4ca2912d7421 (bug 1620679)
2020-05-26 10:58:42 +03:00
Matt Woodrow
d347ab0ef5
Bug 1620679 - Don't fire load event from within Stop(). r=smaug
...
This matches what the spec says, and what blink does.
Differential Revision: https://phabricator.services.mozilla.com/D73994
2020-05-26 03:08:40 +00:00
Matt Woodrow
b7105cc963
Bug 1627533 - Create LoadGroups for docshells using the BrowsingContext's request context id. r=dragana,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D75885
2020-05-21 03:38:37 +00:00
Noemi Erli
3adaaeb800
Backed out 3 changesets (bug 1627533) for causing assertions in RequestContextService.cpp CLOSED TREE
...
Backed out changeset 3b35a1852a60 (bug 1627533)
Backed out changeset 70fa5e075269 (bug 1627533)
Backed out changeset 0d1046670534 (bug 1627533)
2020-05-21 04:16:21 +03:00
Matt Woodrow
f8b14e22ba
Bug 1627533 - Create LoadGroups for docshells using the BrowsingContext's request context id. r=dragana,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D75885
2020-05-20 23:41:36 +00:00
Mihai Alexandru Michis
19a4744fcc
Backed out 2 changesets (bug 1620679) for causing failures in nsDocShell.cpp
...
CLOSED TREE
Backed out changeset 2957142243c5 (bug 1620679)
Backed out changeset 60df74b03f34 (bug 1620679)
2020-05-18 14:47:37 +03:00
Matt Woodrow
2f95a6ac80
Bug 1620679 - Don't fire load event from within Stop(). r=smaug
...
This matches what the spec says, and what blink does.
Differential Revision: https://phabricator.services.mozilla.com/D73994
2020-05-18 07:30:14 +00:00
Jared Wein
2c619e2a98
Bug 773942 - Create a new init method in nsITransfer that accepts a BrowsingContext and if the download should be handled internally for backwards-compat. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D75186
2020-05-16 06:00:08 +00:00
Jared Wein
3ab25176e5
Bug 773942 - Use the browsingContext to open the new tab with correct userContextId, private-ness, and ownerTab. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D72778
2020-05-16 05:59:53 +00:00
Jared Wein
3074d7ebb9
Bug 773942 - Open PDFs using pdf.js in a new tab when the Preview option is selected from the Unknown Content Type dialog. r=Gijs
...
This is currently preffed off behind the "browser.helperApps.showOpenOptionForPdfJS" pref.
Differential Revision: https://phabricator.services.mozilla.com/D72776
2020-05-16 05:59:43 +00:00
Narcis Beleuzu
35b6e759f7
Backed out 9 changesets (bug 773942) for xpcshell failure on test_getMIMEInfo_pdf.js
...
Backed out changeset 6fb0f25b2f5d (bug 773942)
Backed out changeset 27e9fe03a549 (bug 773942)
Backed out changeset ee0ecad5e90a (bug 773942)
Backed out changeset df062e14287b (bug 773942)
Backed out changeset 7da06239ccfb (bug 773942)
Backed out changeset dfedbeeaec66 (bug 773942)
Backed out changeset 286e1be9dc46 (bug 773942)
Backed out changeset f4df0a553bc0 (bug 773942)
Backed out changeset 97f3b96b6be0 (bug 773942)
2020-05-16 08:37:53 +03:00
Jared Wein
788718620f
Bug 773942 - Create a new init method in nsITransfer that accepts a BrowsingContext and if the download should be handled internally for backwards-compat. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D75186
2020-05-16 04:26:12 +00:00
Jared Wein
58822bff64
Bug 773942 - Use the browsingContext to open the new tab with correct userContextId, private-ness, and ownerTab. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D72778
2020-05-16 04:25:03 +00:00
Jared Wein
3ace9de33d
Bug 773942 - Open PDFs using pdf.js in a new tab when the Preview option is selected from the Unknown Content Type dialog. r=Gijs
...
This is currently preffed off behind the "browser.helperApps.showOpenOptionForPdfJS" pref.
Differential Revision: https://phabricator.services.mozilla.com/D72776
2020-05-16 04:24:56 +00:00
Chris Peterson
4a38e89842
Bug 1628961
- Replace "clang-format off" with semicolon workaround for clang-format bug 1629756. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D71138
2020-04-16 09:49:35 +00:00
Matt Woodrow
a27cfc760b
Bug 1627971 - Add option to MaybeFireEmbedderLoadEvents to also fire the error event to the embedder element. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D70585
--HG--
extra : moz-landing-system : lando
2020-04-15 22:30:13 +00:00
Chris Peterson
72e3388f74
Bug 1628961
- Replace MOZ_MUST_USE with [[nodiscard]] in docshell and uriloader. r=smaug
...
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
I also needed to wrap the nsDocLoader::RemoveChildLoader() function declaration with // clang-format off and // clang-format on. clang-format insists on indenting the function declaration because it is confused by the NS_DECL_ macros without trailing semicolons before the [[nodiscard]] attribute.
Differential Revision: https://phabricator.services.mozilla.com/D70478
--HG--
extra : moz-landing-system : lando
2020-04-14 06:41:42 +00:00