5dec0e0beb
Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
...
This patch was autogenerated by my decomponents.py
It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.
It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.
It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)
MozReview-Commit-ID: DeSHcClQ7cG
--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
bb16936244
Merge mozilla-central to autoland. a=merge CLOSED TREE
2018-02-02 00:25:44 +02:00
2b1c8dccb6
Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop.
2018-02-01 20:45:22 +01:00
e3f37a97a4
Bug 633062 p8 - Add Async observers. r=kitcambridge,markh,tcsc
...
MozReview-Commit-ID: IvwyleXBcNH
--HG--
extra : rebase_source : eb8f5db734cedb2810642723ed1652defeb16d88
2018-01-04 18:07:10 -05:00
815460e8cf
Bug 633062 p7 - Make most of the addon reconciler async. r=markh
...
Except observers, which will be handled in the last commit of this series.
MozReview-Commit-ID: IvwyleXBcNH
--HG--
extra : rebase_source : 8054777b015c3b07c6599bdb00c9d32572313395
2017-12-07 17:56:50 -05:00
71ff2629c2
Bug 633062 p6 - Remove event loop spinning from head_helper.js addon-related methods. r=markh
...
MozReview-Commit-ID: 4Be253tJlXq
--HG--
extra : rebase_source : 461b2c5ad4076d39933b491a6d7a0065e2eb75b3
2017-12-08 16:07:49 -05:00
4bc7feea45
Bug 633062 p5 - Remove event loop spinning from addonutils.js. r=markh
...
MozReview-Commit-ID: 1PSX4tOieEH
--HG--
extra : rebase_source : c68d862761e9704e8cbb3235ce5491cb6d091c59
2017-12-08 15:34:29 -05:00
825e2fa2b1
Bug 633062 p4 - Remove miscellaneous uses of event loop spinning in services/. r=markh
...
MozReview-Commit-ID: IDGWJevEHLK
--HG--
extra : rebase_source : 0db05e713e55d680a85a1280d6540eec8c39f96c
2017-12-08 14:41:02 -05:00
5568486701
Bug 633062 p3 - Remove event loop spinning from the EngineManager. r=markh
...
MozReview-Commit-ID: 7tdKT8Wo3t4
--HG--
extra : rebase_source : 49b36a171f0bedf3ca04255af478bcec733d991b
2017-12-08 13:10:25 -05:00
01342b993b
Bug 633062 p2 - Make getTokenFromBrowserIDAssertion async. r=markh
...
Also move promiseStopServer to the common/ head_helpers.js
MozReview-Commit-ID: B3Idnj6rPAZ
--HG--
extra : rebase_source : adb07d381aca118b9b49971f87e68a239dbcfb70
2017-12-07 14:45:15 -05:00
9df7ea51ac
Backed out 8 changesets (bug 633062) as requested by eoger on a CLOSED TREE
...
Backed out changeset 590656f7b5c5 (bug 633062)
Backed out changeset 0888aa122056 (bug 633062)
Backed out changeset 0780cf391c52 (bug 633062)
Backed out changeset 9798cbd03027 (bug 633062)
Backed out changeset 4b31c73a585f (bug 633062)
Backed out changeset 0a8866062136 (bug 633062)
Backed out changeset 20ff83289564 (bug 633062)
Backed out changeset 5e52125316e1 (bug 633062)
2018-01-31 22:09:30 +02:00
6991ad1d07
Bug 633062 p8 - Add Async observers. r=kitcambridge,markh,tcsc
...
MozReview-Commit-ID: IvwyleXBcNH
--HG--
extra : rebase_source : 30b4e09cb2a5f0da1845c842a464a277554f61a4
2018-01-04 18:07:10 -05:00
a636cbd98f
Bug 633062 p7 - Make most of the addon reconciler async. r=markh
...
Except observers, which will be handled in the last commit of this series.
MozReview-Commit-ID: IvwyleXBcNH
--HG--
extra : rebase_source : 8054777b015c3b07c6599bdb00c9d32572313395
2017-12-07 17:56:50 -05:00
1cf9cd890d
Bug 633062 p6 - Remove event loop spinning from head_helper.js addon-related methods. r=markh
...
MozReview-Commit-ID: 4Be253tJlXq
--HG--
extra : rebase_source : 461b2c5ad4076d39933b491a6d7a0065e2eb75b3
2017-12-08 16:07:49 -05:00
8a13eb4d47
Bug 633062 p5 - Remove event loop spinning from addonutils.js. r=markh
...
MozReview-Commit-ID: 1PSX4tOieEH
--HG--
extra : rebase_source : c68d862761e9704e8cbb3235ce5491cb6d091c59
2017-12-08 15:34:29 -05:00
7f72c53748
Bug 633062 p4 - Remove miscellaneous uses of event loop spinning in services/. r=markh
...
MozReview-Commit-ID: IDGWJevEHLK
--HG--
extra : rebase_source : 0db05e713e55d680a85a1280d6540eec8c39f96c
2017-12-08 14:41:02 -05:00
9a26bd581d
Bug 633062 p3 - Remove event loop spinning from the EngineManager. r=markh
...
MozReview-Commit-ID: 7tdKT8Wo3t4
--HG--
extra : rebase_source : 49b36a171f0bedf3ca04255af478bcec733d991b
2017-12-08 13:10:25 -05:00
ea2b2a9409
Bug 633062 p2 - Make getTokenFromBrowserIDAssertion async. r=markh
...
Also move promiseStopServer to the common/ head_helpers.js
MozReview-Commit-ID: B3Idnj6rPAZ
--HG--
extra : rebase_source : adb07d381aca118b9b49971f87e68a239dbcfb70
2017-12-07 14:45:15 -05:00
204f9ceae9
Bug 1433983 - Remove deprecated PlacesUtils.setPostDataForBookmark/getPostDataForBookmark functions. r=mak
...
MozReview-Commit-ID: 9WD2A4jA761
--HG--
extra : rebase_source : 63a66fe95f29102db6a8486525bd430985a8f8ed
2018-01-29 18:31:42 +00:00
2ebbd41c08
Backed out 8 changesets (bug 633062) for failing xpcshell on Windows at services/sync/tests/unit/test_hmac_error.js on a CLOSED TREE
...
Backed out changeset b4e9cd0d61ab (bug 633062)
Backed out changeset ee294cebe485 (bug 633062)
Backed out changeset 3d1ad6b3bbee (bug 633062)
Backed out changeset c053f43da9e8 (bug 633062)
Backed out changeset 549e1282ae8e (bug 633062)
Backed out changeset 35058a83dab0 (bug 633062)
Backed out changeset 2e9dc98eabf0 (bug 633062)
Backed out changeset dbbacd08392c (bug 633062)
2018-01-31 10:07:34 +02:00
4c8c0752bd
Bug 633062 p8 - Add Async observers. r=kitcambridge,markh,tcsc
...
MozReview-Commit-ID: IvwyleXBcNH
--HG--
extra : rebase_source : a517b2fbaede8e8b7566d127710f0dceb8e7d4f2
2018-01-04 18:07:10 -05:00
c44950332a
Bug 633062 p7 - Make most of the addon reconciler async. r=markh
...
Except observers, which will be handled in the last commit of this series.
MozReview-Commit-ID: IvwyleXBcNH
--HG--
extra : rebase_source : b5f9fe43ac2fd956253c571f4cc7b68eb1d928ec
2017-12-07 17:56:50 -05:00
072adbdabf
Bug 633062 p6 - Remove event loop spinning from head_helper.js addon-related methods. r=markh
...
MozReview-Commit-ID: 4Be253tJlXq
--HG--
extra : rebase_source : f0f094132beb18960fc1115adfa82bfb15caae28
2017-12-08 16:07:49 -05:00
b6df353d2b
Bug 633062 p5 - Remove event loop spinning from addonutils.js. r=markh
...
MozReview-Commit-ID: 1PSX4tOieEH
--HG--
extra : rebase_source : e8804e1428c78d47fbc776e74da61d5de4e5f402
2017-12-08 15:34:29 -05:00
b8cb936b01
Bug 633062 p4 - Remove miscellaneous uses of event loop spinning in services/. r=markh
...
MozReview-Commit-ID: IDGWJevEHLK
--HG--
extra : rebase_source : 8471048a68b9b6204402f3ea9039a21af8c3740c
2017-12-08 14:41:02 -05:00
b2c2739a4d
Bug 633062 p3 - Remove event loop spinning from the EngineManager. r=markh
...
MozReview-Commit-ID: 7tdKT8Wo3t4
--HG--
extra : rebase_source : a99f8f1f30010829bf2d4ebd7590953c46b244e2
2017-12-08 13:10:25 -05:00
ffdd8c898f
Bug 633062 p2 - Make getTokenFromBrowserIDAssertion async. r=markh
...
Also move promiseStopServer to the common/ head_helpers.js
MozReview-Commit-ID: B3Idnj6rPAZ
--HG--
extra : rebase_source : 0c3ee2b37448467fdd7fec04dbdf39255608901b
2017-12-07 14:45:15 -05:00
9f8b519dae
Backed out 8 changesets (bug 633062) for xpcshell failures on browser/extensions/formautofill/test/unit/test_sync.js on a CLOSED TREE
...
Backed out changeset d60ca66f2b62 (bug 633062)
Backed out changeset d80494d5bc36 (bug 633062)
Backed out changeset 33f832b59e86 (bug 633062)
Backed out changeset 968db19986aa (bug 633062)
Backed out changeset a55a3647ea49 (bug 633062)
Backed out changeset bb1030bdab48 (bug 633062)
Backed out changeset 9c4cd2a6965c (bug 633062)
Backed out changeset 669c76bd2618 (bug 633062)
--HG--
extra : amend_source : cf95d15507de46de393cdef797a5808c4e0407ff
2018-01-31 07:28:06 +02:00
65e746d5d2
Bug 633062 p8 - Add Async observers. r=kitcambridge,markh,tcsc
...
MozReview-Commit-ID: IvwyleXBcNH
--HG--
extra : rebase_source : 254006b5d64f425e4cabca6c02e8b20dce983d8e
2018-01-04 18:07:10 -05:00
bd9720e7f2
Bug 633062 p7 - Make most of the addon reconciler async. r=markh
...
Except observers, which will be handled in the last commit of this series.
MozReview-Commit-ID: IvwyleXBcNH
--HG--
extra : rebase_source : b5f9fe43ac2fd956253c571f4cc7b68eb1d928ec
2017-12-07 17:56:50 -05:00
3b8568a77b
Bug 633062 p6 - Remove event loop spinning from head_helper.js addon-related methods. r=markh
...
MozReview-Commit-ID: 4Be253tJlXq
--HG--
extra : rebase_source : f0f094132beb18960fc1115adfa82bfb15caae28
2017-12-08 16:07:49 -05:00
5491e15085
Bug 633062 p5 - Remove event loop spinning from addonutils.js. r=markh
...
MozReview-Commit-ID: 1PSX4tOieEH
--HG--
extra : rebase_source : e8804e1428c78d47fbc776e74da61d5de4e5f402
2017-12-08 15:34:29 -05:00
3e4633d6e3
Bug 633062 p4 - Remove miscellaneous uses of event loop spinning in services/. r=markh
...
MozReview-Commit-ID: IDGWJevEHLK
--HG--
extra : rebase_source : 8471048a68b9b6204402f3ea9039a21af8c3740c
2017-12-08 14:41:02 -05:00
d3a0ee9183
Bug 633062 p3 - Remove event loop spinning from the EngineManager. r=markh
...
MozReview-Commit-ID: 7tdKT8Wo3t4
--HG--
extra : rebase_source : a99f8f1f30010829bf2d4ebd7590953c46b244e2
2017-12-08 13:10:25 -05:00
546a23d489
Bug 633062 p2 - Make getTokenFromBrowserIDAssertion async. r=markh
...
Also move promiseStopServer to the common/ head_helpers.js
MozReview-Commit-ID: B3Idnj6rPAZ
--HG--
extra : rebase_source : 0c3ee2b37448467fdd7fec04dbdf39255608901b
2017-12-07 14:45:15 -05:00
1acce175af
Bug 1356331 Remove hotfix code from addons manager and related tests r=rhelmer
...
MozReview-Commit-ID: EjCOOgmXvVH
--HG--
extra : rebase_source : 051c618bd73e7bac41d5dc9339972742b029a879
extra : source : 9af7407fa9309e1fa2dc590309ed2329f02dc61e
2017-12-13 12:33:52 -08:00
918ed6c474
Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
...
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
2018-01-29 15:20:18 -08:00
9a65a40178
Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
...
Backed out changeset a1eca62826a1 (bug 143153314315331431533
2018-01-30 07:17:48 +02:00
6476f95b13
Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
...
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
2018-01-29 15:20:18 -08:00
af8879d1eb
Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
...
Backed out changeset 6e56f4c8843e (bug 14315331431533
2018-01-30 02:32:43 +02:00
c276bb9375
Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
...
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
2018-01-29 15:20:18 -08:00
970b471265
Bug 1433234 - Replace do_check_array_eq by Assert.deepEqual. r=eoger
...
MozReview-Commit-ID: 7goh46IkVrW
***
--HG--
extra : rebase_source : 2ffdacce0843341c23d43354c135c21ca3d3ec14
2018-01-27 19:29:55 -02:00
2449a744b8
Bug 1305563 - Add a `BufferedBookmarksEngine` that can be toggled with a pref. r=markh,tcsc
...
This patch adds a new bookmarks engine, pref'd off, that writes to the
buffer instead of Places.
MozReview-Commit-ID: 7idBa03kOzm
--HG--
extra : rebase_source : 671ebeb3de824dc43c0ef14b2dfe065a33e2911a
2017-12-19 17:10:54 -08:00
6321345295
Bug 1429250 - Avoid repeated traversals of toFetch in _processIncoming. r=eoger,kitcambridge
...
MozReview-Commit-ID: N1Zr8iT7da
--HG--
extra : rebase_source : ddaa51704c93985219d15b31aec7ff7e19b2832f
2018-01-09 19:22:33 -05:00
592194dc76
Bug 1432437 - Remove synchronous changeBookmarkURI. r=standard8
...
MozReview-Commit-ID: Jy76eKCN7wp
--HG--
extra : rebase_source : 84958fcaaacdcdd9a400a546b14eb49fc897752c
2018-01-24 12:13:02 +01:00
7831647b90
Backed out changeset 8ebfca2b0c21 (bug 1432437) for Xpcshell test failure on toolkit/components/places/tests/unit/test_sync_utils.js
2018-01-26 01:43:17 +02:00
86b21609be
Bug 1432437 - Remove synchronous changeBookmarkURI. r=standard8
...
MozReview-Commit-ID: Jy76eKCN7wp
--HG--
extra : rebase_source : 2d453281eb9c77c3f23f15a5a390a17e7b880c34
2018-01-24 12:13:02 +01:00
df042c21a8
Bug 1370881 - Replace calls to asyncHistory.isURIVisited and promiseIsURIVisited with PlacesUtils.history.hasVisits r=standard8
...
MozReview-Commit-ID: BHWkJpdYA0g
--HG--
extra : rebase_source : 927cd89c69ed2cdbf6ebf8e954c38238ebbdd273
2018-01-24 20:58:57 +05:30
95b5e3bd0e
Bug 1405205 - Report bookmark engine as bookmarks-buffered in the sync ping r=kitcambridge
...
MozReview-Commit-ID: 490KcmRZkfY
--HG--
extra : rebase_source : d3fe0f03c8ed3607c3c0b0ce2a063645dc0d9a70
2017-10-11 17:13:04 -04:00
d149a0176b
Bug 1426306 - Store only derived keys instead of storing kB/kA. r=glasserc,markh,rfkelly
...
MozReview-Commit-ID: Hgv5hxSH4qX
--HG--
extra : rebase_source : fa6d45480a2078e841c72b2c8c92541811633737
2018-01-05 15:56:00 -05:00
a773c73dbb
Bug 1131491 - Remove old synchronous Place's transactions. r=mak
...
MozReview-Commit-ID: FNCijeajgeh
--HG--
extra : rebase_source : 4207cdd7b789fbbcce3b2117324ea22e1a313fe6
2018-01-22 15:41:12 +00:00
6e3bb55bb8
Bug 1412083 - Avoid syncing preferences that refer to moz-extension or blob urls. r=eoger
...
MozReview-Commit-ID: 9Ipq5z1dykr
--HG--
extra : rebase_source : a8616485879268ce31ef74f4b3fdbc3f4dc5a585
2018-01-09 17:46:24 -05:00
1e3446b9cc
Bug 1421703 - Fix tests to use onVisits r=mak
...
Fairly straightforward. Fixes the tests that were broken due to
the changes introduced in part 1.
MozReview-Commit-ID: GbZ9ZpmG9nE
--HG--
extra : rebase_source : ebb2088288718631a941139d5a4d945259aaa0c6
2017-12-14 16:55:31 -06:00
4f926a87dd
Bug 1427835 - Remove redundant TPS addon test and disable validation on the non-restartless XPI test r=markh
...
MozReview-Commit-ID: JxNw7qIOheo
--HG--
extra : rebase_source : 33bf748394a248178c85292464c8acccf9e106b8
2018-01-03 15:01:49 -05:00
3e7a2e240e
Bug 1425544 - Ensure trace level logging is used throughout sync tests. r=markh
...
MozReview-Commit-ID: Icl1qk07LKm
--HG--
extra : rebase_source : c0e35f3e435e720f0375b3826ee4ba745d1e134b
2017-12-20 18:29:21 -05:00
0f55cd45be
Bug 1421992 - script-generated patch to replace do_execute_soon, do_print and do_register_cleanup with executeSoon, info and registerCleanupFunction, rs=Gijs.
2017-12-21 11:10:23 +01:00
e0f995ea08
Bug 1421992 - hand written cleanup patch to make xpcshell tests pass after replacing do_check_* with Assert.*, r=Gijs.
2017-12-21 11:08:19 +01:00
032c961e0a
Bug 1421992 - script-generated patch to replace do_check_* functions with their Assert.* equivalents, rs=Gijs.
2017-12-21 11:08:17 +01:00
4e773dd17f
Bug 1423399 - Avoid duplicating synced history visits older than your most recent 20 r=kitcambridge
...
MozReview-Commit-ID: 2CAutmuJWhb
--HG--
extra : rebase_source : b145ebe8525fa6cb045f99adabfc5ce3d0984f3a
2017-12-18 19:40:38 -05:00
9aa875bf0b
Bug 664590 - Do not track file:/// visits. r=markh
...
MozReview-Commit-ID: 6oVDkJU7kai
--HG--
extra : rebase_source : 0d184abb2ba1babc6c6c3ef6ebbb3024a26f81a8
2017-12-06 16:55:45 -05:00
208554ebe1
Bug 1423395 - Clamp and truncate microseconds from incoming history visit dates when deduping r=markh
...
MozReview-Commit-ID: H1lljWcSZLZ
--HG--
extra : rebase_source : c64f20dd38bf4b17f05885df1f6b3ba112efdcb6
2017-12-05 19:40:37 -05:00
81ef0051dc
Bug 1415560 - ignore insertMany result and add an onError handler to log errors. r=tcsc
...
MozReview-Commit-ID: 8aJkRL8WCPr
--HG--
extra : rebase_source : dceb94744eef3ac50253594a70cec9f32f4cf8d3
2017-12-04 12:49:06 +11:00
b5876a8b65
Bug 1407116 - Sync now enters the "please reconnect" state if Sync is configured but FxA is not. r=eoger
...
MozReview-Commit-ID: LuAdYkpe0b7
--HG--
extra : rebase_source : 0fb3ca9ef0912e61354df5ca111a169df3777526
2017-12-04 15:48:45 +11:00
788c2ca211
Bug 1421817 - Send a sync ping on shutdown if we have events but no syncs. r=markh
...
MozReview-Commit-ID: ExxN6UXs2Ip
--HG--
extra : rebase_source : 356d2f7bbfc856859e7b6246939b785f0984fa82
2017-11-29 17:41:59 -05:00
302308a0a1
Bug 1336257 - Use HTTPS for mozqa url in TPS. r=markh
...
MozReview-Commit-ID: Admw1iKeW24
--HG--
extra : rebase_source : 836f3efb3aea6eb2a089c5aecd0f7a10a0bd6787
2017-11-29 18:35:28 -05:00
39bf8149a6
Bug 1416788 - limit number of visits we pass to PlacesUtils.history.insertMany to prevent shutdown hangs. r=kitcambridge
...
MozReview-Commit-ID: AU9AMUAD1Rw
--HG--
extra : rebase_source : 205ec0f17f94bd399f4663e552bd75e7b63f7da5
2017-11-23 16:18:55 +11:00
dc2fe37c66
Bug 1421452 - Fix deprecation warning in test_bookmark_engine by passing an osfile path instead of nsifile. r=markh
...
MozReview-Commit-ID: 4XrzA0kUXzE
--HG--
extra : rebase_source : bed7a594b854969dd1932449f43ade4dc068ffeb
2017-11-28 17:35:51 -05:00
efaca11893
Bug 1420422 - Enable ESLint rule mozilla/use-services for services/. r=markh
...
MozReview-Commit-ID: LQiMr3ppDuG
--HG--
extra : rebase_source : f509b5360e92db58f14b0f6a41c06e10fe7dd170
2017-11-24 14:46:33 +00:00
9f071e2083
Bug 1409534 - Replace Resource impl by fetch. r=kitcambridge,markh,tcsc
...
MozReview-Commit-ID: 5mmVeHeMQKf
--HG--
extra : rebase_source : 84c20e3b90b5bed43e511158270761e2e1da6b15
2017-11-06 16:24:40 -05:00
b2e847755c
Bug 1367704 - Enable the semi ESLint rule across the tree. r=standard8
...
MozReview-Commit-ID: GrlcOI9K2hJ
--HG--
extra : rebase_source : 6574cf3c67eb11733ffd9999c260f71c8551abc4
2017-05-28 19:57:46 +01:00
0648f86b7f
Bug 1304898 - Include why in sync ping. r=tcsc
...
MozReview-Commit-ID: G9WnHhuWD7Z
--HG--
extra : rebase_source : 27cb3c2bdf7432e0db1e6a8431d348be50c2afd8
2017-11-15 17:10:45 -05:00
d6c28d0200
Bug 1417590 - Check for client duplicates in the Sync collection validator. r=tcsc
...
MozReview-Commit-ID: LcPnTEDhbis
--HG--
extra : rebase_source : 5070eebbb1495ac14cc140862dd78d46e638615f
2017-11-10 22:27:30 -08:00
43771ba19d
Bug 1414892 - Optimize moz_places_afterinsert_trigger r=mak
...
This uses a similar strategy as that employed by moz_places_afterdelete_trigger,
creating a temp table which we write host inserts into, and then deleting all
the rows from it when we're done inserting, effectively resulting in a per-
statement trigger to only do the significant work per host.
MozReview-Commit-ID: 5TUueknq3ng
--HG--
extra : rebase_source : 1892edfcaa7b6afd29ce794a93d6ab3d46c48895
2017-11-07 12:01:53 -08:00
9e62cc5726
Bug 1416313 - Drop old or low priority commands rather than failing to sync the clients engine if too many commands are sent. r=eoger,markh
...
MozReview-Commit-ID: 6BJGmUL28hp
--HG--
extra : rebase_source : 894cafb34f193b802c90052142174ea3187b8396
2017-11-10 15:57:33 -05:00
892f157456
Bug 1416902 - Fix missing await in test_service_sync_updateEnabledEngines and test_interval_triggers r=kitcambridge
...
MozReview-Commit-ID: 6rFOWPsxxxj
--HG--
extra : rebase_source : 62e37062876d4dd38cc43f532df622c09b94cf1b
2017-11-13 16:53:15 -05:00
93a711ae04
Bug 1416374 - Handle getting an abortincoming error in sync telemetry r=markh
...
MozReview-Commit-ID: LFmbkGa4ypu
--HG--
extra : rebase_source : 93e7e9fcfbdf141c86cede055b58d82985fea370
2017-11-10 18:02:58 -05:00
31aa407113
Bug 1383623 - Remove synchronous Places API usage from the Sync unit tests. r=tcsc
...
MozReview-Commit-ID: Cip7LSSi2fE
--HG--
extra : rebase_source : deaff010d15d7ae9812d1d38f3b39c1100c62cf3
2017-11-09 15:46:27 -08:00
7e070192d7
Merge inbound to mozilla-central r=merge a=merge
2017-11-10 11:55:43 +02:00
207b8d909e
Bug 1347515 - Get rid of nsIJSON.decodeFromStream, r=qdot
2017-11-10 00:27:22 +01:00
1873a289f7
Bug 1415957 - Remove MozMill from TPS. r=tcsc
...
MozReview-Commit-ID: HyBXrNqhzIf
--HG--
extra : rebase_source : da197fa045f70621d5549e961876cfc6ce15264b
2017-11-09 15:34:06 -05:00
edeaf1bc14
Bug 1415012 - Don't trigger a resync if the previous sync wasn't completely successful r=kitcambridge
...
MozReview-Commit-ID: DcNsFUxXR1O
--HG--
extra : rebase_source : 2632aa8d6db8e9e101e949c237b559015444f808
2017-11-06 20:56:57 -05:00
53383c5b3f
Bug 1408108 - Rename "Sync ID" to "record ID" in the bookmarks engine and `PlacesSyncUtils`. r=kitcambridge
...
--HG--
extra : rebase_source : da3acfc4f7393a615c44f238c624bb826ff5b766
2017-11-06 12:17:07 -08:00
d61954557d
merge mozilla-inbound to mozilla-central. r=merge a=merge
...
MozReview-Commit-ID: Ai6Y5GGfkfT
2017-11-04 10:58:24 +01:00
b9c6a1d730
Bug 1413413 (part 2) - Remove support for extensions having their own prefs file. r=glandium,kmag.
...
It's no longer needed, now that legacy extensions aren't supported.
Pieces removed include the following.
- The "load-extension-default" observer notification.
- The code for reading defaults/preferences/*.js from extensions.
- The unit test for this stuff.
- A crash reporter annotation relating to very long prefs set by add-ons.
- All references to "ExtPrefDL".
MozReview-Commit-ID: KMBoYn3uZ3x
--HG--
extra : rebase_source : 4dc8ffd425c6cdf06806409090c4f9d04a64930b
2017-10-31 16:34:57 +11:00
e4007fdbe7
Bug 1375223 - Remove Async.querySpinningly. r=kitcambridge
...
MozReview-Commit-ID: bMo1jyIY5g
--HG--
extra : rebase_source : ac69fde2cb8216300bdb9e7d19528c15cdceb7c8
2017-10-31 18:50:31 -04:00
604673b3d3
Bug 1366067 - Use `JSONFile.jsm` to persist the backlog and previously failed IDs. r=tcsc
...
MozReview-Commit-ID: DAwMrtWI8eh
--HG--
extra : rebase_source : f6713745b09de2e6b0993539cce9ed4e8226dbbf
2017-11-01 11:10:47 -07:00
4a77d5a93f
Bug 1388224 - Remove SyncStorageRequest HTTP wrapper class, which is no longer used r=kitcambridge
...
MozReview-Commit-ID: EgExfizNll5
--HG--
extra : rebase_source : 85a6098a5b985990bd3a8483936bf6cf768f1f0b
2017-11-01 17:17:46 -04:00
064ed56076
Bug 1368209 - Refactor `Engine::_processIncoming` into three stages. r=eoger,tcsc
...
* In the first stage, we fetch changed records, newest first, up to the
download limit. We keep track of the oldest record modified time we
see.
* Once we've fetched all records, we reconcile, noting records that
fail to decrypt or reconcile for the next sync. We then ask the store
to apply all remaining records. Previously, `applyIncomingBatchSize`
specified how many records to apply at a time. I removed this because
it added an extra layer of indirection that's no longer necessary,
now that download batching buffers all records in memory, and all
stores are async.
* In the second stage, we fetch IDs for all remaining records changed
between the last sync and the oldest modified time we saw in the
first stage. We *don't* set the download limit here, to ensure we
add *all* changed records to our backlog, and we use the `"oldest"`
sort order instead of `"index"`.
* In the third stage, we backfill as before. We don't want large deltas
to delay other engines from syncing, so we still only take IDs up to
the download limit from the backlog, and include failed IDs from the
previous sync. On subsequent syncs, we'll keep fetching from the
backlog until it's empty.
Other changes to note in this patch:
* `Collection::_rebuildURL` now allows callers to specify both `older`
and `newer`. According to :rfkelly, this is explicitly and
intentionally supported.
* Tests that exercise `applyIncomingBatchSize` are gone, since that's
no longer a thing.
* The test server now shuffles records if the sort order is
unspecified.
MozReview-Commit-ID: 4EXvNOa8mIo
--HG--
extra : rebase_source : f382f0a883c5aa1f6a4466fefe22ad1a88ab6d20
2017-11-01 11:09:57 -07:00
96593594d3
Bug 1368209 - Add a test for fetching backlogged history records. r=tcsc
...
The test captures the existing logic in `_processIncoming`, even though
it's not quite correct:
* First, we fetch all records changed since the last sync, up to the
download limit, and without an explicit sort order. This happens to
work correctly now because the Python server uses "newest" by
default, but can change in the future.
* If we reached the download limit fetching records, we request
IDs for all records changed since the last sync, also up to the
download limit, and sorted by index. This is likely to return IDs
for records we've already seen, since the index is based on the
frecency. It's also likely to miss IDs for other changed records,
because the number of changed records might be higher than the
download limit.
* Since we then fast-forward the last sync time, we'll never download
any remaining changed records that we didn't add to our backlog.
* Finally, we backfill previously failed and backlogged records.
MozReview-Commit-ID: 7uQLXMseMIU
--HG--
extra : rebase_source : 719ee2d9e46102195251b410f093da3247095c22
2017-10-27 17:54:48 -07:00
432850c0aa
Bug 1368209 - Add support for `sortindex` and `older` to the mock Sync server. r=tcsc
...
MozReview-Commit-ID: 6YI1OEE8x7R
--HG--
extra : rebase_source : 2f0da0cd2a1554685fff5af3de100e4b01564447
2017-10-27 17:55:30 -07:00
3e7662202d
Bug 1413685 - Unify AsyncResource and Resource. r=tcsc
...
MozReview-Commit-ID: 1yEeAwpbGxJ
--HG--
extra : rebase_source : 8c87b0d16138acf2b55be70767fe0547f4ac1d42
2017-11-02 14:30:59 -04:00
1b5408583f
Backed out 3 changesets (bug 1368209)xpcshell failures services/sync/tests/unit/test_syncengine_sync.js on CLOSED TREE
...
Backed out changeset 1b868efa368f (bug 1368209)
Backed out changeset b88c681ccdc1 (bug 1368209)
Backed out changeset 4b8e56844ae9 (bug 1368209)
2017-11-03 11:40:06 +02:00
4105f1cb3a
Bug 1368209 - Refactor `Engine::_processIncoming` into three stages. r=eoger,tcsc
...
* In the first stage, we fetch changed records, newest first, up to the
download limit. We keep track of the oldest record modified time we
see.
* Once we've fetched all records, we reconcile, noting records that
fail to decrypt or reconcile for the next sync. We then ask the store
to apply all remaining records. Previously, `applyIncomingBatchSize`
specified how many records to apply at a time. I removed this because
it added an extra layer of indirection that's no longer necessary,
now that download batching buffers all records in memory, and all
stores are async.
* In the second stage, we fetch IDs for all remaining records changed
between the last sync and the oldest modified time we saw in the
first stage. We *don't* set the download limit here, to ensure we
add *all* changed records to our backlog, and we use the `"oldest"`
sort order instead of `"index"`.
* In the third stage, we backfill as before. We don't want large deltas
to delay other engines from syncing, so we still only take IDs up to
the download limit from the backlog, and include failed IDs from the
previous sync. On subsequent syncs, we'll keep fetching from the
backlog until it's empty.
Other changes to note in this patch:
* `Collection::_rebuildURL` now allows callers to specify both `older`
and `newer`. According to :rfkelly, this is explicitly and
intentionally supported.
* Tests that exercise `applyIncomingBatchSize` are gone, since that's
no longer a thing.
* The test server now shuffles records if the sort order is
unspecified.
MozReview-Commit-ID: 4EXvNOa8mIo
--HG--
extra : rebase_source : 13605dd3a43569a6d83dc2eb15a578a7bbd5c1ca
2017-11-01 11:09:57 -07:00
481bdb6dd6
Bug 1368209 - Add a test for fetching backlogged history records. r=tcsc
...
The test captures the existing logic in `_processIncoming`, even though
it's not quite correct:
* First, we fetch all records changed since the last sync, up to the
download limit, and without an explicit sort order. This happens to
work correctly now because the Python server uses "newest" by
default, but can change in the future.
* If we reached the download limit fetching records, we request
IDs for all records changed since the last sync, also up to the
download limit, and sorted by index. This is likely to return IDs
for records we've already seen, since the index is based on the
frecency. It's also likely to miss IDs for other changed records,
because the number of changed records might be higher than the
download limit.
* Since we then fast-forward the last sync time, we'll never download
any remaining changed records that we didn't add to our backlog.
* Finally, we backfill previously failed and backlogged records.
MozReview-Commit-ID: 7uQLXMseMIU
--HG--
extra : rebase_source : 5742474889845b934c3d2e8b479d26d719cd03c0
2017-10-27 17:54:48 -07:00
8f60eeed17
Bug 1368209 - Add support for `sortindex` and `older` to the mock Sync server. r=tcsc
...
MozReview-Commit-ID: 6YI1OEE8x7R
--HG--
extra : rebase_source : 2f0da0cd2a1554685fff5af3de100e4b01564447
2017-10-27 17:55:30 -07:00
4de6bf22b1
Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop
...
MozReview-Commit-ID: H5YVp3rnzGo
--HG--
extra : rebase_source : 5b45b6c0df834131812d094e975047eaad374e06
2017-10-26 11:47:01 +01:00
3b78d2f449
Bug 1412139 - Prepare existing bookmark engine tests for new buffered engine. r=kitcambridge
...
MozReview-Commit-ID: 2HIkdPOuWOy
--HG--
extra : rebase_source : 6c8108f707f59e8d795dfd489453c614f00fd096
2017-09-11 14:17:24 -07:00
c31dc99e96
Bug 890217 - Add a test for syncing bookmarks with IMAP URLs. r=tcsc
...
MozReview-Commit-ID: KBVInzYk1Rr
--HG--
extra : rebase_source : 9ba1b55c154a9a19f24dcf8b859189123abcad1c
2017-10-20 08:55:52 -07:00
7caa92d5d8
Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
...
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
2c51427c6d
Bug 1408180 - Ensure LoginRec.toString doesn't contain the password. r=kitcambridge
...
MozReview-Commit-ID: 5mV0g9LH4vE
--HG--
extra : rebase_source : 33a9c246053448450e6107c3b244d0bf86f7decb
2017-10-12 18:15:48 -04:00
7555b605f1
Bug 1407082 - Handle more kinds of errors in SyncTelemetry.transformError. r=kitcambridge
...
MozReview-Commit-ID: CjwY7w7vUqs
--HG--
extra : rebase_source : 4030ab88c3eccd755272499ff0527e9e316998b1
2017-10-10 12:31:42 -04:00
d8c3cc3c0b
Bug 1401700 - Prevent incoming tabs from opening multiple times if client sync fails. r=tcsc
...
MozReview-Commit-ID: DhrZ1oFY2WG
--HG--
extra : rebase_source : d8d35bdb08edbad9412d6953a671c3e38e75711c
2017-10-03 14:45:11 -04:00
30ccd917b0
Backed out changeset 8d5cc47b248f (bug 1401700) for failing xpcshell services/sync/tests/unit/test_bookmark_repair.js on OS X 10.10 opt. r=backout
2017-10-11 23:44:26 +02:00
51d18ff941
Bug 1401700 - Prevent incoming tabs from opening multiple times if client sync fails. r=tcsc
...
MozReview-Commit-ID: DhrZ1oFY2WG
--HG--
extra : rebase_source : e98e4ee0a3e376840ce89f0908d7210b167154fa
2017-10-03 14:45:11 -04:00
da5797466a
Bug 1403276 - Dedupe sync devices with the same fxaDeviceId by picking the one with the newer last modified date r=eoger
...
MozReview-Commit-ID: 3Lq7vuPpF6
--HG--
extra : rebase_source : f16c5fe0d29551ab829ba8f0c8c92e78109ace07
2017-10-10 13:41:32 -04:00
0c48a189bc
Bug 1405833 - Ensure SyncEngine uses CommonUtils.namedTimer properly. r=kitcambridge
...
MozReview-Commit-ID: 6YnhcSjKW9U
--HG--
extra : rebase_source : 3e0e520516f06efa50aa8e3fccb77214daca419a
2017-10-04 17:26:20 -04:00
e9d579fe2a
Bug 1405566 - Clamp future and far past synced history visit dates. r=markh
...
MozReview-Commit-ID: Gs0DpTTu1Ab
--HG--
extra : rebase_source : b836f4ae366eaf127935dee593dc51d2222e3aca
2017-10-04 14:16:29 -07:00
c42f57923a
Bug 1348981 - only load system add-ons from a built-in list r=kmag
...
MozReview-Commit-ID: A6c5kaLmNPP
--HG--
extra : rebase_source : e20ec54eabb5ecb2cc0b85efb687dbed06f1d16a
2017-10-02 18:41:20 -07:00
e6050e53aa
Bug 1401990 - Use max_request_bytes instead of max_post_bytes if sync server provides both r=markh
...
MozReview-Commit-ID: GJadUIuSGKt
--HG--
extra : rebase_source : be8da0b14c0e1522bc1dc025871fc34830d9ae58
2017-10-02 16:42:22 -04:00
bd61777c6b
Backed out changeset fe9b8761d51f (bug 1348981)
2017-10-04 15:43:46 +02:00
8d488926ef
Bug 1348981 - only load system add-ons from a built-in list r=kmag
...
MozReview-Commit-ID: A6c5kaLmNPP
--HG--
extra : rebase_source : 9ad775a652affc0d8d6c7ce4153dddc8a13c4ca4
2017-10-02 18:41:20 -07:00
d8e232c88a
Backed out changeset 8dda8bbcf385 (bug 1348981)
2017-10-04 01:00:09 +02:00
c8714b1c7d
Bug 1348981 - only load system add-ons from a built-in list r=kmag
...
MozReview-Commit-ID: A6c5kaLmNPP
--HG--
extra : rebase_source : 058e6011c8ce953059e674eea032ba79c19f8eb8
2017-10-02 18:41:20 -07:00
d39e820403
Bug 1403052 - Limit tab sync max_record_payload_size to 512k. r=markh
...
Also fixes an issue where we wouldn't encode to utf8 when comparing the actual
size to the limit after the first time.
MozReview-Commit-ID: Cf3byjI1FTZ
--HG--
extra : rebase_source : 272ec3b3ad85f8b44c4d69950be83419054abdab
2017-10-02 19:27:54 -04:00
9f708fd861
Bug 1400467 - Ensure services/common/logmanager.js awaits it's cleanup function r=markh
...
MozReview-Commit-ID: thQph1UUA0
--HG--
extra : rebase_source : 705cdd9d07a1a26b568554e07638c0415789b404
2017-09-22 11:57:13 -04:00
76a3991796
Bug 1400467 - Make WeaveCrypto use promises instead of spinning event loops r=eoger,markh
...
MozReview-Commit-ID: 64dewKKaAOJ
--HG--
extra : rebase_source : e8d48e05ad8dac214358b0a9979b011a65ed07a8
2017-09-15 19:21:31 -07:00
1df9d06245
Bug 1395427 p4 - Add form history items deletions to TPS tests. r=markh,tcsc
...
MozReview-Commit-ID: 3oUBqLuHpoG
--HG--
extra : rebase_source : 303c40b6fc5a41a7b2f2e9edc9f275228ccbbe47
2017-09-22 15:19:44 -04:00
e08e4f2f41
Backed out changeset d86f2704b27a (bug 1395427)
2017-09-27 17:10:15 +02:00
7d0ecfa428
Bug 1395427 p4 - Add form history items deletions to TPS tests. r=markh,tcsc
...
MozReview-Commit-ID: 3oUBqLuHpoG
--HG--
extra : rebase_source : 19f4c4c21c35d9d604e17d3e1df862bc700773bd
2017-09-22 15:19:44 -04:00
216b709c48
Backed out 4 changesets (bug 1348981) for Linux debug timeouts in test_system_update.js
...
Backed out changeset b1fe39ea6d5c (bug 1348981)
Backed out changeset 47866f942752 (bug 1348981)
Backed out changeset 5e93d8760487 (bug 1348981)
Backed out changeset 58431e2c37d7 (bug 1348981)
MozReview-Commit-ID: 2WjZKztxyVs
2017-09-23 06:20:56 -07:00
70071e128b
Bug 1348981 - only load system add-ons from a built-in list r=kmag
...
MozReview-Commit-ID: A6c5kaLmNPP
--HG--
extra : rebase_source : 8a98ba4a36f2717c1b733b661e9d8621a9bbfec0
2017-09-14 00:36:04 -07:00
6348cd2190
Bug 1393659 - Fix inconsistent handling of max_post_bytes and max_request_bytes r=markh
...
MozReview-Commit-ID: 4jwpAYNuoQj
--HG--
extra : rebase_source : f32ecbd9740f7d8647fdf37ad6bbb53e332320ac
2017-09-13 18:02:41 -07:00
daf87f8b3b
Bug 1383663 part 1 - Revert bug 1385191 changes. r=markh
...
This reverts commit 3f279247b875becd0c617fa6dc31cdf9f1349374.
MozReview-Commit-ID: FuCMewhO20z
--HG--
extra : rebase_source : cbeb2b30a425020e2379d3f5d21affabe610a20b
2017-08-21 17:06:06 -04:00
e6c038d6ee
Backed out 3 changesets (bug 1383663) for timeouts in browser_aboutAccounts.js and failures in test_web_channel.js
...
Backed out changeset f384a524cac6 (bug 1383663)
Backed out changeset 9d26a627e2f8 (bug 1383663)
Backed out changeset c7d46e2e8ddc (bug 1383663)
MozReview-Commit-ID: 88xbdeVJtK2
2017-09-16 10:40:00 -07:00
11875727be
Bug 1383663 part 1 - Revert bug 1385191 changes. r=markh
...
This reverts commit 3f279247b875becd0c617fa6dc31cdf9f1349374.
MozReview-Commit-ID: FuCMewhO20z
--HG--
extra : rebase_source : f071fe7d8b67d84a0b2836b7dae3883e8c85c46a
2017-08-21 17:06:06 -04:00
95856672f4
Bug 1400394 - Remove `TestingUtils.deepCopy`. r=markh
...
MozReview-Commit-ID: 3ZZpA3inWSF
--HG--
extra : rebase_source : 506d1bb5bba484e65bcd5abed196c3ecc751fb1b
2017-09-15 13:46:21 -07:00
f829523282
Bug 1371065: Part 0 - Fix unit tests that use the SDK loader :/ r=Mossop
...
MozReview-Commit-ID: 4ewrbY0FS09
--HG--
extra : rebase_source : 390256a9eb0d303d8582c24d69fff189b0e0ab4d
2017-09-08 18:16:50 -07:00
d6cced9ca1
Bug 1394525 - Reset tracker scores before syncing. r=markh
...
MozReview-Commit-ID: 1wHdOeiZOyl
--HG--
extra : rebase_source : 765094feecdbe79cfa30f5c5a2886f8113890077
2017-08-28 11:24:26 -07:00
0d29ca233e
Bug 1393904 - Ensure `insertTree` removes Sync tombstones for restored bookmarks. r=mak
...
MozReview-Commit-ID: EbGybRbhWKJ
--HG--
extra : rebase_source : 596389e1ffc111f26cc10f014da6d74202f988eb
2017-08-25 12:04:22 -07:00
5317324bec
Bug 1397537 - check FxA has a session token and enter a needs-reauth state even when the user is unverified. r=eoger
...
MozReview-Commit-ID: KuldXySDvt4
--HG--
extra : rebase_source : 9b33265b341e7fcd5be9dc6e3b01d218ce1aabca
2017-09-07 11:13:53 +10:00
27afdd11e1
Bug 1396544 - don't schedule syncs when Sync isn't configured. r=rnewman
...
MozReview-Commit-ID: AM0G43vFyty
--HG--
extra : rebase_source : 9888cfd079f4761debb710d1bbe064956aec1093
2017-09-05 12:40:53 +10:00
2dad858a21
Bug 1375635 - Add telemetry for how often and long users are in bad authentication states. r=Dexter,rweiss+418169,tcsc
...
MozReview-Commit-ID: BW8ixM3wmxJ
--HG--
extra : rebase_source : 6872e86fbd6ff00c4ab65ef4bf8c6195e06de54b
2017-07-27 11:59:24 +10:00
e16b402acf
Bug 1395148 - Run some services/sync xpcshell tests sequentially; r=markh
...
These tests normally pass when run sequentially but often timeout when run
in parallel, especially on debug builds.
2017-08-31 07:50:25 -06:00
5a0bb50ea8
Bug 1392148 - Remove aliases to CommonUtils in util.js r=markh
...
MozReview-Commit-ID: 1fv6AN0TMNW
--HG--
extra : rebase_source : 083c73e50bfdb2dd121aa483e5aa53ae0e35768d
2017-08-24 22:41:44 -07:00
c204098ad4
Bug 1392409 - set engine.lastModified to avoid intermittent orange. r=tcsc
...
MozReview-Commit-ID: 4kPzk9nSWxw
--HG--
extra : rebase_source : 6f4ef917001e2565dd00eefa12876fc897705ca1
2017-08-23 13:59:16 +10:00
a53020d022
Bug 1392098 - Enable the new ESLint no-useless-run-test rule across the tree. r=mossop
...
MozReview-Commit-ID: 35MaseieNUk
--HG--
extra : rebase_source : 98eaec6a67fd3b30ea6b0be641f26c3911012fab
2017-08-20 18:52:05 +01:00
34e7a1eb17
Bug 1355766 - don't treat a 412 response as a sync error. r=kitcambridge
...
MozReview-Commit-ID: 4IL6RJcP9PC
--HG--
extra : rebase_source : 2e0c3143da1f01eaeb5a30efab2becd367ded36c
2017-08-08 12:02:28 +10:00
fa4625acc7
Bug 1368951 - add x-if-unmodified-since support to the sync test server. r=tcsc
...
MozReview-Commit-ID: FF7smwdeQ0k
--HG--
extra : rebase_source : 82f8706d6a27f1bf93b95b93572a2fa37b268b3d
2017-05-31 18:42:45 +10:00
b242392e7d
Bug 1353217 - importing bookmarks from html doesn't need to reset the bookmarks engine. r=markh
...
MozReview-Commit-ID: 4F7KF5ZkNuX
--HG--
extra : rebase_source : 521510fe074fa0f84f28212fa8a230a74dfd2ce8
2017-08-11 00:19:01 +00:00
3e1366bdf6
Bug 1388149 - Make PlacesUtils.history.insertMany respect provided GUIDs r=markh
...
MozReview-Commit-ID: 7g6uABtHKg2
--HG--
extra : rebase_source : 0b43e026ad3de514d2ffbc56568bf3f4e3e17126
2017-08-07 16:01:10 -04:00
8b713b2b0f
Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj
...
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.
MozReview-Commit-ID: 4ecl3RZhOwC
--HG--
extra : rebase_source : 412880ea27766118c38498d021331a3df6bccc70
2017-08-04 17:49:22 +09:00
4f08809c1f
Bug 1387303 - fix test_places_guid_downgrade.js to work correctly in the new async-sync world. r=eoger
...
MozReview-Commit-ID: 4bmu45qUmFA
2017-08-04 15:00:51 +10:00
2b42c50319
Bug 1385440 - Serialize client commands additions. r=markh
...
MozReview-Commit-ID: 3qGcHVhOCeL
--HG--
extra : rebase_source : 3d71a5af631d2dd9be59ce0b1495959552f8c640
2017-08-02 11:33:24 -04:00
48e6bc2124
Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
...
MozReview-Commit-ID: FadrI2li43G
--HG--
extra : rebase_source : b455e846ab79c8141150517e67e542e3e06d630e
2017-07-25 23:45:41 +05:30
6b5f784403
Bug 1384818 - flush sync log files on sync reset. r=eoger
...
MozReview-Commit-ID: H6CkvHGxAmx
--HG--
extra : rebase_source : 53bede19ec7766c91c30324668dcca8d11f64197
2017-07-27 14:57:47 +10:00
5368b04624
Bug 1374722 - Expand the set of ids requested during the initial repair process r=markh
...
MozReview-Commit-ID: 92SGMd9fJgX
--HG--
extra : rebase_source : 0b6ca2379a03adc4488bf3f679a3f81b18de83b1
2017-06-20 13:40:17 -04:00
804a36e668
Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout
2017-07-31 14:44:34 +02:00
22dfa54ef4
Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
...
MozReview-Commit-ID: FadrI2li43G
--HG--
extra : rebase_source : 5992bdde34bcc2421350433bc8c1e498a6bba848
2017-07-25 23:45:41 +05:30
7a9b4d8b79
Bug 1336518 - Move Sync history queries into PlacesSyncUtils. r=kitcambridge
...
MozReview-Commit-ID: Lood8ivLeJf
--HG--
extra : rebase_source : dcb8207378afc6ce2995acfe4f235f3ed728a188
2017-07-30 17:46:56 -03:00
5c9899d993
Bug 1383621 - Use the async bookmarks API to insert the mobile query. r=markh
...
MozReview-Commit-ID: KaeXwFHEg7K
--HG--
extra : rebase_source : b67f8662e221614041aad391d71bdf381ce4e8b0
2017-07-24 16:45:17 -07:00
8d2320d13f
Bug 1385191 - Prefer email address from the FxA profile over that from the account. r=eoger
...
MozReview-Commit-ID: 78U2RZQ5xfB
--HG--
extra : rebase_source : b79b18ea8c545003998692cd97c7ad5d6606c7f7
2017-07-28 16:35:40 +10:00
250eef68d6
Bug 1375212 - Wrap thrown strings in Error objects r=eoger,markh
...
MozReview-Commit-ID: KquBcbNhBEN
--HG--
extra : rebase_source : 172bcad2eb178092bc7d49940db61e8cb5ad6572
2017-07-22 18:55:43 -07:00
932f724512
Bug 1382363 - Change most uses of `promiseDBConnection` to `withConnectionWrapper` in `PlacesSyncUtils`. r=markh
...
The read-only `promiseDBConnection` can return stale data if writes
are still pending. This patch changes `PlacesSyncUtils` to use the
read-write `withConnectionWrapper` instead, ensuring we fetch
up-to-date info.
I didn't change `fetchURLFrecency` and `fetchGuidsWithAnno`.
`fetchURLFrecency` is only used to set the sort index for history
records, and frecency is recalculated in the background, anyway.
`fetchGuidsWithAnno` is only used in tests.
MozReview-Commit-ID: Gq16sNm7K2e
--HG--
extra : rebase_source : e597233dae23d7582f34faeb83365896b6c22a75
2017-07-25 11:53:45 -07:00
65bbd0525a
Merge inbound to central, a=merge
...
MozReview-Commit-ID: E4oXfAM1mtd
2017-07-25 19:04:37 -07:00
061209972d
Bug 1368568 - Remove legacy SyncKeyBundle. r=eoger
...
MozReview-Commit-ID: JYiTeQnduto
2017-07-25 11:40:14 -04:00
1e3bdd598f
Bug 1382913 - throw an error when a non existing observer is removed from observers.js. r=kitcambridge
...
MozReview-Commit-ID: AR2IPDH0Rpw
--HG--
extra : rebase_source : c533d5a5e086fc43c9c847297c3fba97ed9e25d7
2017-07-25 13:59:44 +10:00
23b85ab316
Bug 1337978 - Unify the multiple notions of 'weak upload' in sync. r=kitcambridge,markh
...
MozReview-Commit-ID: 5vTCAhUfMzm
--HG--
extra : rebase_source : fea6783352868e15481a751923aac2a166ad5506
2017-07-18 14:18:04 -04:00
9a475a45bf
Bug 1382044 - Disable addon validation during some phases of TPS's test_addon_nonrestartless_xpi.js. r=markh
...
MozReview-Commit-ID: 112UJWjF7R4
--HG--
extra : rebase_source : d398e93deb2d5bd7cc43d96eb37580552b8e2d72
2017-07-18 19:56:50 -04:00
8893010bae
Bug 1380835 - Don't check queries with `excludeQueries` for cycles in the bookmark validator. r=tcsc
...
MozReview-Commit-ID: DsPzrCxWWMG
--HG--
extra : rebase_source : 25281ab8f8d53901d960a738212361831b12fc55
2017-07-13 19:52:57 -07:00
8fc0f2d795
Bug 1377183 - Manually follow folder queries when validating bookmarks. r=tcsc
...
MozReview-Commit-ID: K3nl5GcilMz
--HG--
extra : rebase_source : 3704f00919170e12652e4d977c50604d6f94ce49
2017-07-05 17:00:50 -07:00
35f3666937
Bug 1380009 - Enable the ESLint no-return-await call to avoid unnecessary intermediate promise creation. r=mossop
...
MozReview-Commit-ID: EnhSBHMjurr
--HG--
extra : rebase_source : 74ba4c10e369067629af95bf705a9acd0df1089b
2017-07-11 22:49:55 +01:00
764f64b2d5
Bug 1380094 - services/sync changes to support formautofill r=markh
...
MozReview-Commit-ID: BdsrrFOU5ec
--HG--
extra : rebase_source : b7bc64fd510c9db60c6788cda94a07b1a53d0594
2017-07-11 15:15:37 -04:00
314ef330a0
Bug 1210296 part 2 - Update tests. r=kitcambridge,markh,tcsc
...
MozReview-Commit-ID: 41dnyvdlNJv
--HG--
extra : rebase_source : 4c6e3cc63d4861d176ba053a1cff872c04f0f3b3
2017-06-05 18:49:43 -04:00
f4f4832d9e
Bug 1369539 - Sync UI startup performance improvements. r=florian,markh
...
MozReview-Commit-ID: 7ibJokJttLh
--HG--
extra : rebase_source : 7eac08de35da72744ce4b101d4f52229fe0e0688
2017-07-04 14:23:33 -04:00
881bce09ea
Bug 1374670 - Enabled the ESLint no-tabs rule across mozilla-central r=standard8
...
MozReview-Commit-ID: RT5QTipaOW
--HG--
extra : rebase_source : 84bccaeba083bc430316d3c80d5c8f56494f1950
2017-07-04 21:30:18 +05:30
0c16f513c9
Bug 1378551 - Separate `pullNewChanges` and `markChangesAsSyncing`. r=markh
...
MozReview-Commit-ID: FcysoHJtG60
--HG--
extra : rebase_source : 902460b486ef230c939608ee9bede93374069776
2017-07-05 13:49:48 -07:00
a4f06209c9
Bug 1378545 - Ensure `test_misreconciled_root` waits for the test server to start. r=markh
...
MozReview-Commit-ID: AyjdR5hfSOf
--HG--
extra : rebase_source : 9483f7f2d0c0437da1a3e97d9477ea8eae243843
2017-07-05 15:19:17 -07:00
03c81660b0
Bug 1377200 - Ensure Sync can recover after a profile refresh. r=markh
...
MozReview-Commit-ID: FeId4ANTNX9
--HG--
extra : rebase_source : 5c3f69ee524584617635375d9bc416fc57e9a67e
2017-07-04 15:03:43 -04:00
31ccf3dc94
Bug 1360872 - Return empty strings for `null` bookmark titles. r=mak
...
MozReview-Commit-ID: Dd2sEfYvnBt
--HG--
extra : rebase_source : 963b09955610d099b1acb508472a2a3c24202d73
2017-06-06 14:37:22 -07:00
53c93f8449
Bug 1367813 - 1) Add telemetry for prefs.js not existing or being corrupted, and the presence of a user.js file. 2) Rename and change the nsIPrefService.readUserPrefs API. The new API reads user prefs from a file but doesn't remember that location or save changed preferences to that location. r=milan data-r=rweiss
...
MozReview-Commit-ID: FD5npJlB24W
--HG--
extra : rebase_source : d30bac5044ecb8d86253e8bca3e8d47371fb9d1f
extra : source : 4f0ee0f75a307095e4a04afe4413e5bb6ea8e502
2017-06-21 15:26:10 -04:00
7e61aa8e97
Bug 1373093 - Add operating system information to the desktop Sync ping. r=tcsc
...
MozReview-Commit-ID: 9ypnosSawxu
--HG--
extra : rebase_source : 8a0192c70917c952431693c6864f96f7fd9b278e
2017-06-21 12:28:25 +10:00
c636da88e0
Backed out changeset 4f0ee0f75a30 (bug 1367813) for Windows opt permaorange in test_worker_basic.html
...
MozReview-Commit-ID: 2k693yFa28r
2017-06-22 20:43:11 -07:00
5cf8c34a94
Bug 1367813 - 1) Add telemetry for prefs.js not existing or being corrupted, and the presence of a user.js file. 2) Rename and change the nsIPrefService.readUserPrefs API. The new API reads user prefs from a file but doesn't remember that location or save changed preferences to that location. r=milan data-r=rweiss
...
MozReview-Commit-ID: FD5npJlB24W
--HG--
extra : rebase_source : 049275836880f0aa4d19a9af2de9ec4101432b44
2017-06-21 15:26:10 -04:00
66f6d259bc
Bug 1374282 - script generated patch to remove Task.jsm calls, r=Mossop.
2017-06-22 12:51:42 +02:00
a1b09f054d
Bug 1374599 - neuter the sync scheduler during some tests to avoid oranges. r=standard8
...
MozReview-Commit-ID: Ihun5yu3hit
--HG--
extra : rebase_source : 9448411e072d144456e7672b92699cdf288a13fc
2017-06-21 14:53:07 +10:00
d030707609
Bug 1095426 - Convert JSON backups code to the new async Bookmarks.jsm API. r=mak
...
MozReview-Commit-ID: FNZZGwWVSI2
--HG--
extra : rebase_source : dacb3c5ddb439d074c66e0baaa7e73044c5dcd46
2017-05-12 08:04:51 +01:00
a208081e56
Bug 1357798 - Ensure URLs don't end up in sync error telemetry. r=markh
...
MozReview-Commit-ID: AxFzysv0ks3
--HG--
extra : rebase_source : 6b2aa9354ed9540c5cdb8f537eaca7080c97a4eb
2017-06-12 13:38:39 -04:00
c3972efec6
Bug 1368393 - Handle already synced commands in clients collection duplicate checking r=eoger,markh
...
MozReview-Commit-ID: Hs0Jh8mMlOp
--HG--
extra : rebase_source : 8a8bae7330210547d128c322abed773cb73895e5
2017-06-09 12:07:43 -04:00
b599411285
Bug 1369119 - Refresh known stale devices list on FxA device disconnect. r=markh
...
MozReview-Commit-ID: A2iqas0kP20
--HG--
extra : rebase_source : 15db886e4751885e173a55c561df7ea1a3b2871b
2017-06-06 14:28:00 -04:00
3231cb3535
Bug 1372886 - Remove dead parameters from nsIConverterInputStream.init(). r=hsivonen
...
MozReview-Commit-ID: GliLHLsUWjt
--HG--
extra : rebase_source : 50d3f4680a498125ddf600b0d64f6740b0229f80
2017-06-17 19:30:09 +09:00
a1f2f47f82
Bug 1363412 - Notify other clients when uploading the local clients record for the first time. r=markh
...
MozReview-Commit-ID: Ldc3Jrj8RhV
--HG--
extra : rebase_source : 44bdeaa962ddbcb748f9e5a01871fd2ff7d6a676
2017-06-12 14:51:17 -04:00
1826fefb4c
Bug 1370985 - Change getBatched() to return records directly instead of using a callback. r=markh,tcsc
...
MozReview-Commit-ID: HfwPe8jSH66
--HG--
extra : rebase_source : 12c8800f1fcc090589c2a94a0fc1608b36c54181
2017-05-30 13:23:57 -04:00
adde19d4f4
Bug 1369855 - Update sinon.js to version 2.3.2. r=markh
...
MozReview-Commit-ID: FPB4HebP3g7
--HG--
extra : rebase_source : 1e55c1dbc8bff59e1a7a097e4a6a58a19bc95688
2017-06-02 15:50:30 -04:00
19362d0bfa
Bug 1354016 - Forms validator ignore clientMissing. r=tcsc
...
MozReview-Commit-ID: C2FD58C9HzS
--HG--
extra : rebase_source : f5b627342e7fa4915914cbfd3e54003fe6d94c1e
2017-06-01 22:32:23 -03:00
dc01c77702
Bug 1369285 - update how we build the default sync device name. r=tcsc
...
MozReview-Commit-ID: 6eY8IzKg9kd
--HG--
extra : rebase_source : ae321d48de0144c29fa4f40fd16a02c44539d795
2017-06-01 16:57:02 +10:00
9d1dc7c4a7
Bug 1368560 part 2 - Move Svc.Crypto to Weave.Crypto. r=markh
...
MozReview-Commit-ID: 74IFsVjZSgz
--HG--
extra : rebase_source : 00f77b7a24a509d5e9fabb8ee7793a59b38f639f
2017-05-29 13:24:01 -04:00
2c61cf7eb4
Bug 1368560 part 1 - Remove un-used legacy crypto methods. r=markh
...
MozReview-Commit-ID: JbzweOMFLpR
--HG--
extra : rebase_source : f7cece36dce26c96a740aede6c696deb08345a90
2017-05-29 17:27:13 -04:00
0c6026b415
Bug 1369092 - Listen to onverified events in UIState. r=markh
...
MozReview-Commit-ID: 8nfmpaz9obF
--HG--
extra : rebase_source : 736673d0c1245b81ea9f419f08b943c3ce26a8e6
2017-05-31 12:02:28 -04:00
9768267be1
Backed out changeset bf392a1d0c5a (bug 1368560) for failing xpcshell's test_ext_storage_sync.js and test_ext_storage_sync_crypto.js on Linux. r=backout on a CLOSED TREE
2017-05-31 22:53:16 +02:00
a9f8675d96
Backed out changeset c2d00a8b897b (bug 1368560)
2017-05-31 22:52:14 +02:00
275b48a53e
Bug 1368560 part 2 - Move Svc.Crypto to Weave.Crypto. r=markh
...
MozReview-Commit-ID: 74IFsVjZSgz
--HG--
extra : rebase_source : 29833856a9cca178a2b508b6401cdb6bd8ca1bb9
2017-05-29 13:24:01 -04:00
198e8ab1d1
Bug 1368560 part 1 - Remove un-used legacy crypto methods. r=markh
...
MozReview-Commit-ID: JbzweOMFLpR
--HG--
extra : rebase_source : f7cece36dce26c96a740aede6c696deb08345a90
2017-05-29 17:27:13 -04:00
71a24b858a
Bug 1366994 - prevent appDisabled addons from hanging sync. r=tcsc
...
MozReview-Commit-ID: 4RRCPlwUZrG
--HG--
extra : rebase_source : 8ab03af402dc15432252b74a120da286b810302f
2017-05-26 12:42:10 +10:00
7386600327
Bug 1366081 - Excise 'mobileGUIDFetchBatchSize' and other mobile sync-related constants. r=kitcambridge
...
MozReview-Commit-ID: 6JTtpWFFyvD
--HG--
extra : rebase_source : f6ca75e91ca38d0d1ba18ff79a0872d96a878954
2017-05-24 03:28:22 -03:00
fc8d285e3d
Bug 1036440 - Fix tests and consumers for rewritten `PlacesDBUtils`, r=mak
...
This includes 2 things:
1. Replacing the parts which test the logs for the presence of prefixes by testing
the returned map for `suceeded`.
2. We don't need to wait to observe the topic anymore, we can simply await methods
from `PlacesDBUtils` to know when they are done.
MozReview-Commit-ID: Ct9l9pzUW5x
--HG--
extra : rebase_source : 657e4ac53f8b3785740a5b732d483fad9600f73d
2017-05-24 11:00:47 +05:30
99947c9c38
Bug 1353307 - Add main process start time to sync ping. r=gfritzsche,markh
...
MozReview-Commit-ID: DbSZUmO0tuf
--HG--
extra : rebase_source : e13afbd5829b86b7bee5c82a7a1ff09263e9dc3f
2017-05-16 17:43:49 -04:00
df2d03a198
Bug 973166 - Only track passwords with changes to synced fields. r=eoger
...
MozReview-Commit-ID: 8ZOyVCaZIi8
--HG--
extra : rebase_source : 8252c5a9ad718594872d5bda38e04528cd227f44
2017-05-22 17:21:20 -07:00
d2833635e1
Bug 1352233 - Try to preserve synced folder child order in case of conflicts. r=tcsc
...
For folders, we resolve conflicts by taking the chronologically newer
list, then appending any missing items from the older list. This
preserves the order of those missing items relative to each other, but
not relative to those appearing in the newer list.
MozReview-Commit-ID: 6rimXpV7vLg
--HG--
extra : rebase_source : 10cda7f529cec3f71d9d45d253285d35788cb0b5
2017-04-28 14:08:11 -07:00
45fdbb5730
Bug 1355663 - Don't de-duplicate tabs from multiple devices. r=eoger
...
MozReview-Commit-ID: AciCTECtXJc
--HG--
extra : rebase_source : 82f81f227cf27cf03c4672f0402641010434e74e
2017-05-12 20:54:54 -03:00
4e937e42a2
Bug 1353542 - Cleanup the script output and fix tests, r=Mossop.
2017-05-12 14:54:05 +02:00
Andrew McCreight
Gurzau Raul
Florian Quèze
Edouard Oger
Noemi Erli
Mark Banner
Andreea Pavel
Dorel Luca
Andrew Swan
Kris Maglione
Cosmin Sabou
Brindusan Cristian
vinicius
Kit Cambridge
Thom Chiovoloni
Marco Bonardo
hemant
Doug Thayer
Mark Hammond
Dan Banner
Margareta Eliza Balazs
Andrea Marchesini
Manish Kumar
Sebastian Hengst
Nicholas Nethercote
Luciano I
NARCIS BELEUZU
Robert Helmer
Phil Ringnalda
Geoff Brown
Nicolas Ouellet-Payeur
Masatoshi Kimura
Rajesh Kathiriya
tiago
Wes Kocher
Rob Cutmore
Benjamin Smedberg
milindl