7251d442c0
Bug 1125693 - Fix -Wformat warning in xpcom/base/nsStackWalk.cpp and mark as FAIL_ON_WARNINGS. r=njn
2015-01-25 13:49:06 -08:00
af2a8de28a
Bug 1123533 - Clarify thread handling in NS_StackWalk() on Windows. r=ehsan.
...
- The way NS_StackWalk() sets up |targetThread| and |data.walkCallingThread| is
hard to read.
- The name |shouldBeThreadSafe| is unclear -- for a long time I thought it
meant "we are thread-safe, so we can print" and I thought it was named
incorrectly. But now I see it actually means the opposite, i.e. "we need to
be thread-safe, so we can't print". So |needToBeThreadSafe| would be
clearer...
- ...but |shouldBeThreadSafe| shouldn't be used anyway, because
|data.walkCallingThread| is better -- it correctly handles the case where
|aThread| is the current thread -- and it's what WalkStackMain64() uses.
This patch fixes these problems.
--HG--
extra : rebase_source : f1310f72db1e10c25e77af54a1d6df4114e59314
2015-01-19 19:19:55 -08:00
5f39b00c79
Bug 1120047 - Fix glibc version check guards for and importing of __libc_stack_end. r=glandium
2015-01-17 15:02:01 +11:00
059cf96c41
Bug 1122337 - Mark DMD directories as FAIL_ON_WARNINGS. r=glandium.
...
The DEFINES and XPCOM_API changes are needed to get rid of "inconsistent dll
linkage" warnings on Windows builds.
--HG--
extra : rebase_source : 00756f51ebee85c70f65d51dbac17b4835262697
2015-01-15 21:17:18 -08:00
ea66053341
Bug 1119776, Part 7: Avoid defining snprintf when MSVC provides it (other), r=bsmedberg
...
--HG--
extra : rebase_source : 3fc7e4e83f57252e15cf32846f23e497f8532ea5
2015-01-08 22:35:33 -08:00
05ce5cbc4a
Bug 1088343 (part 1) - Get NS_StackWalk working on Win64. r=aklotz.
...
--HG--
extra : rebase_source : 9b8262bba126a98b2c5007ee8e149f92e702f5a7
2015-01-08 16:00:07 -08:00
0c3e01557d
Bug 1088343 (part 0) - Clean up the windows implementation of NS_StackWalk a little. r=ehsan.
...
--HG--
extra : rebase_source : fb31dbf446f5485e5aea6b22687e32ff595efb0b
2015-01-08 15:13:21 -08:00
94adb30f77
Bug 1062709 (part 2, attempt 2) - Clean up stack printing and fixing. r=dbaron.
...
--HG--
extra : rebase_source : 626fd23a14ec90cfc9807c3d555169ec6463d19d
2014-09-01 22:56:05 -07:00
2eb56008e2
Bug 1062709 (part 1, attempt 2) - Add a frame number argument to NS_WalkStackCallback. r=dbaron.
...
--HG--
extra : rebase_source : 4f7060a9ae0bed180899651c50e8ea8857e72d63
2014-09-10 21:47:01 -07:00
2d0f9579b5
Backed out changeset a0b82c954206 (bug 1062709) for Windows mochitest 5 hangs
2014-10-03 15:06:16 +01:00
9e223d8a19
Backed out changeset 7a1b7d7eba12 (bug 1062709)
2014-10-03 15:05:26 +01:00
5a257b83f9
Bug 1062709 (part 2) - Clean up stack printing and fixing. r=dbaron.
...
--HG--
extra : rebase_source : 18158d4474cb8826813a3866eba57b710e14db99
2014-09-01 22:56:05 -07:00
c9c64de53c
Bug 1062709 (part 1) - Add a frame number argument to NS_WalkStackCallback. r=dbaron.
...
--HG--
extra : rebase_source : 0f9b2d6310433ed56f5552706fcf2a96571aee25
2014-09-10 21:47:01 -07:00
28935b35cb
Bug 1065834 - Remove long-busted Solaris stack-walking code. r=froydnj.
2014-09-10 19:46:54 -07:00
80ef08ccd8
Bug 1046841 - Fix more style violations in previously touched .cpp files in xpcom/. r=froydnj
2014-08-25 12:17:15 -07:00
601a3063e8
Bug 1017132. Don't call printf in FramePointerStackWalk. r=dbaron
...
This avoids hangs while profiling.
--HG--
extra : rebase_source : 1f6dd552ed3f26017107f41283ca667a246765c0
2014-06-03 15:42:10 -04:00
fb371cca99
Bug 995730 - Fix style violations in xpcom/base/. r=froydnj,continuation
2014-05-13 20:41:38 +03:00
8f4f3e6fea
Bug 995730 - Change xpcom/base/ to use 2 space indentation
...
This also removes trailing whitespace in reindented files.
2014-05-05 20:30:39 +03:00
ba8b77a271
Bug 995345 - Improve efficiency of NS_DescribeCodeAddress. r=froydnj
...
--HG--
extra : rebase_source : ab839d1898d9fe122f2519a657391437dc7216bc
2014-04-14 13:25:04 -07:00
66f56aca38
Bug 977457 - Move _GNU_SOURCE ifdef a little up to account for cxxabi.h from libcxxrt. r=ehsan
2014-03-03 10:29:08 -05:00
91839ef80b
Bug 939610: Return to printing stack walk addresses in uppercase hexidecimal rather than lowercase, since we have scripts depending on it. r=ted
2014-02-24 15:27:52 -08:00
29bd66584a
Bug 960700 - delete incorrect comment from nsStackWalk.cpp; r=ehsan
2014-01-16 14:53:04 -05:00
dd64672e33
Bug 956310 - DMD builds fail on Mac OS X. r=bgirard
2014-01-08 17:06:22 -06:00
ffae418d41
Bug 676907 - Refactor (replace) calls to Gestalt because it is deprecated in OS X 10.8 and will not work in after 10.9. r=BenWa
2013-12-19 11:42:19 -05:00
3440613a39
Bug 713082 - Part 2: Rename Util.h to ArrayUtils.h. r=Waldo
...
--HG--
rename : mfbt/Util.h => mfbt/ArrayUtils.h
2013-12-08 21:52:54 -05:00
178490a226
Bug 819839 - Part 1 - Allow NS_StackWalk to be called during static initialization on Windows. r=ehsan
2013-11-29 16:08:43 +01:00
0244dd58be
Bug 784739 - Switch from NULL to nullptr in xpcom/ (1/3); r=ehsan
2013-10-10 16:41:00 -04:00
54e46df93a
Bug 915765 - fix -Wformat warnings in xpcom/; r=bsmedberg
...
Unfortunately this doesn't fix all platforms, since Android's inttypes.h doesn't
have the right macros for intptr_t at least, but it makes the situation a little
better.
2013-09-12 13:18:36 -04:00
83edc15195
Bug 917885 - Minimize the #includes in xpcom/base; r=bsmedberg
2013-09-19 14:29:31 -04:00
5b80f8355d
Backed out changeset a8d6973e5743 (bug 917885) because I pushed the wrong patch
2013-09-19 14:27:35 -04:00
17ae4f436e
Bug 917885 - Minimize the #includes in xpcom/base; r=bsmedberg
2013-09-19 14:12:56 -04:00
9de23a845f
Bug 850408 - Part 2: Remove Snow Leopard OS check from nsStackWalk. r=bsmedberg
2013-03-07 22:59:39 +00:00
f5ce90e65a
bug 751673 - fix Windows assertion stacks. r=dbaron
...
--HG--
extra : rebase_source : b74882bb3914afaa44341088b9f737c909e88f65
2013-03-11 14:21:53 -04:00
0f94b545d6
bug 829288 - fix a bunch of mingw warnings in xpcom/ r=ehsan
2013-01-10 03:39:40 -05:00
1c4b07debe
Bug 818793 - Add a |aMaxFrames| parameter to NS_StackWalk. r=jlebar,glandium; sr=dbaron.
2012-12-20 21:31:57 -08:00
7d32dc00e9
Bug 717853 - Add a native version of DMD. r=jlebar,glandium.
...
--HG--
extra : rebase_source : 9b824556591abd63b42aa7ff823e9cd25976c162
2012-12-10 16:05:07 -08:00
5c2da9fbfd
Bug 816117 - Part 1: Add the ability to pass around a windows Thread Context to StackWalkMain64. r=ehsan
2012-12-08 06:15:21 +01:00
bec33406d9
Bug 819539 - Ignore _Unwind_Backtrace errors on ARM + Android. r=glandium
2012-12-07 17:18:22 -05:00
088b05ec2d
Bug 806209 followup - fix a stupid mistake; irc-r=BenWa
2012-10-29 14:18:14 -04:00
4cd8fa878c
Bug 806209 - Prevent the Windows implementation of NS_StackWalk from accessing the stdio APIs in order to avoid deadlocks when profiling on Windows; r=BenWa
...
--HG--
extra : rebase_source : cb945d9d3cb162a1177029a6aa097af33f7c917b
2012-10-29 14:03:01 -04:00
7beb8867af
Bug 796526 - stop spewing errors re SysGetModuleInfo64 in debug builds. r=dbaron
2012-10-16 11:26:35 +11:00
00ccc3bc2e
Bug 795507: Remove usage of PR_BEGIN_EXTERN_C and PR_END_EXTERN_C; r=ehsan
2012-09-30 21:10:22 -05:00
8cc30b88b2
Bug 792502 - Kill the FunctionTimer code; r=vlad
2012-09-19 16:59:38 -04:00
b4d77fc8e0
Bug 788546 - In our stack-walking code, instead of asserting that we're initialized and failing if we're not, go ahead and initialize ourself when necessary. r=espindola
2012-09-10 15:51:45 -04:00
291bfa222b
Bug 783523 - Fix platform-specific nsresult misuse; r=ehsan,tbsaunde,smaug
2012-08-16 14:58:11 +03:00
e368dc9c85
Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
...
This patch was generated by a script. Here's the source of the script for
future reference:
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int
convert PRUintn unsigned
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
2012-08-22 11:56:38 -04:00
4733ffae7d
Bug 781457 - Define _GNU_SOURCE for _Unwind_Backtrace. r=dbaron
2012-08-10 11:29:59 -04:00
d0ad5a7d0c
Bug 777292 part 2 - Change all nsnull to nullptr
2012-07-30 17:20:58 +03:00
6640c590c3
Bug 766579 - Part 3: Follow up fix. r=dbaron
2012-07-10 17:39:10 -04:00
325b77e999
Bug 766579 - Part 1: Add SP param to NS_StackWalk. r=dbaron
...
--HG--
extra : rebase_source : dd4905ffadf5fe9327449fffdfbc665b05d74a6a
2012-06-27 16:08:21 -04:00
Chris Peterson
Nicholas Nethercote
Cameron McCormack
Brian Smith
Ed Morley
Birunthan Mohanathas
Jeff Muizelaar
Eric Rahm
Jan Beich
L. David Baron
Nathan Froyd
Steven Michaud
Isura Edirisinghe
Catalin Iacob
Ehsan Akhgari
Ted Mielczarek
Trevor Saunders
Bas Schouten
Justin Lebar
Mark Hammond
Isaac Aggrey
Aryeh Gregor
Benoit Girard