Luca Greco
18f8c6e78a
Bug 1299001 - Ensure that the toolbox resets the preferences set when it is closed. r=ochameau
...
This patch fixes a regression which has been likely introduced in the refactoring
we did in Bug 1222047 on Firefox 63.
Differential Revision: https://phabricator.services.mozilla.com/D7523
--HG--
extra : moz-landing-system : lando
2018-10-02 19:09:37 +00:00
Jason Laster
46254f84e4
Bug 1496468 - Add a console pause indicator. r=loganfsmyth
...
Differential Revision: https://phabricator.services.mozilla.com/D7741
--HG--
extra : moz-landing-system : lando
2018-10-04 20:14:53 +00:00
Gabriel Luong
78c208ee0c
Bug 1494162 - Part 44: Use refs instead of findDOMNode. r=pbro
2018-10-02 12:22:32 -04:00
Gurzau Raul
ede1418858
Merge mozilla-central to inbound. a=merge CLOSED TREE
2018-10-02 19:08:39 +03:00
Gabriel Luong
5dab8a6e0d
Bug 1494162 - Part 32: Lazy load Grid components. r=pbro
2018-10-02 11:20:51 -04:00
Gurzau Raul
468d16cf6a
Merge mozilla-central to autoland. a=merge CLOSED TREE
2018-10-02 10:15:31 +03:00
Gurzau Raul
b7cb3e6ec9
Backed out changeset c209b1927107 (bug 923975) for failing at mochitest/browser_dbg_rr_stepping-02.js, etc. removed obsolete files. a=backout
2018-10-02 09:16:01 +03:00
Gurzau Raul
f74a105ce1
Backed out changeset c209b1927107 (bug 923975) for failing at mochitest/browser_dbg_rr_stepping-02.js, etc. a=backout
2018-10-02 09:11:50 +03:00
Brindusan Cristian
fc5031a446
Merge inbound to mozilla-central. a=merge
2018-10-02 07:01:43 +03:00
Brindusan Cristian
9e3b348e37
Merge mozilla-central to autoland. a=merge CLOSED TREE
2018-10-02 07:04:47 +03:00
Markus Stange
9d56241b4f
Bug 1457481 - Hook up the new devtools performance panel to nsIProfiler.getSymbolTable. r=gregtatum
...
Depends on D7023
Differential Revision: https://phabricator.services.mozilla.com/D7024
--HG--
extra : moz-landing-system : lando
2018-10-02 01:52:32 +00:00
shindli
2cc7085b7a
Backed out 4 changesets (bug 1457481) for c1 failures in devtools/client/performance-new/test/chrome/test_perf-settings-entries.html
...
Backed out changeset 212450f77860 (bug 1457481)
Backed out changeset ac3deff9340f (bug 1457481)
Backed out changeset 4478820fbcaa (bug 1457481)
Backed out changeset 1c8460b1d6da (bug 1457481)
--HG--
rename : third_party/rust/syn-0.14.6/src/parsers.rs => third_party/rust/syn/src/parsers.rs
rename : third_party/rust/syn-0.14.6/src/verbatim.rs => third_party/rust/syn/src/verbatim.rs
rename : third_party/rust/uuid-0.5.1/.travis.yml => third_party/rust/uuid/.travis.yml
rename : third_party/rust/uuid-0.5.1/src/rustc_serialize.rs => third_party/rust/uuid/src/rustc_serialize.rs
rename : third_party/rust/uuid-0.5.1/src/serde.rs => third_party/rust/uuid/src/serde.rs
2018-10-02 01:43:46 +03:00
Brindusan Cristian
9b5034705f
Merge mozilla-central to autoland. a=merge CLOSED TREE
2018-10-02 01:04:29 +03:00
Jason Laster
68a4b4feea
Bug 923975 - Teach step out to leave the current frame. r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D2135
--HG--
extra : moz-landing-system : lando
2018-10-01 20:54:43 +00:00
Markus Stange
12d3a22f24
Bug 1457481 - Hook up the new devtools performance panel to nsIProfiler.getSymbolTable. r=gregtatum
...
Depends on D7023
Differential Revision: https://phabricator.services.mozilla.com/D7024
--HG--
extra : moz-landing-system : lando
2018-10-01 20:53:20 +00:00
Yura Zenevich
931d684ad7
Bug 1482461 - remove "New" bubble from Accessibility panel tab. r=gl
...
MozReview-Commit-ID: HOB4qlx0xJ5
Differential Revision: https://phabricator.services.mozilla.com/D7289
--HG--
extra : moz-landing-system : lando
2018-10-01 16:58:23 +00:00
Julian Descottes
8ee8fcf903
Bug 1492374 - Uninstall ADB Helper when starting WebIDE addons module;r=ladybenko
...
Depends on D7058. To test this you should first install ADB helper
(xpis at https://ftp.mozilla.org/pub/labs/fxos-simulator/adb-helper/mac64/ )
and then start webIDE. Normally ADB Helper should be removed.
Differential Revision: https://phabricator.services.mozilla.com/D7059
--HG--
extra : moz-landing-system : lando
2018-10-01 15:42:23 +00:00
Julian Descottes
dfde1cb173
Bug 1492374 - Remove unused webide Addon abstract class;r=ladybenko
...
The addons module will be further simplified and transformed into a shared module
in coming bgs. Here since we introduce more ADBAddon-specific logic and we have no other
implementation for the Addon class, I prefer to remove it. (note that it was already doing
some adb-only processing in the current version anyway)
Differential Revision: https://phabricator.services.mozilla.com/D7058
--HG--
extra : moz-landing-system : lando
2018-10-01 12:05:12 +00:00
Julian Descottes
293c15aec0
Bug 1492374 - Move all ADB related preferences out of webide;r=ladybenko
...
While this is not strictly related for uninstalling ADB helper this
small cleanup avoids duplicating the declaration of the adb extension
in two different preferences.
The URL preference also moves to a devtools-shared preference as there
is not much sense to keep it webide only.
Differential Revision: https://phabricator.services.mozilla.com/D7057
--HG--
extra : moz-landing-system : lando
2018-10-01 11:40:23 +00:00
David Walsh
93a27fafa2
Bug 1314057 - Remove tests not relevant to the new debugger. r=jlast
...
--HG--
extra : histedit_source : 41ceb71fea5844c7b4c2788683243e9d2c90372c
2018-09-28 14:52:05 -05:00
David Walsh
1c7c13a9e5
Bug 1314057 - Remove stack tests which we have equivalents for in new debugger. r=jlast
...
--HG--
extra : histedit_source : 5b3a0a66f65c66f6203111e1587156f1eacd5b66
2018-09-28 11:23:21 -05:00
David Walsh
479fe389fe
Bug 1314057 - Remove unnecessary puase tests for debugger removal. r=jlast
...
--HG--
extra : histedit_source : e977707fa7dca2b2271a1171eeb4daeeb5596b98
2018-09-28 09:35:21 -05:00
Razvan Caliman
b44224fb5f
Bug 1493961 - Font editor: replace capitalization via CSS text-transform with manual capitalization where needed. r=gl
...
Localization means words in other languages that shouldn't be capitalized will be if using CSS text-transform.
Differential Revision: https://phabricator.services.mozilla.com/D7190
--HG--
extra : moz-landing-system : lando
2018-09-29 21:42:18 +00:00
Daisuke Akatsuka
670b00e560
Bug 1494171: Make tabs on android debuggable. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D7258
--HG--
extra : moz-landing-system : lando
2018-10-01 12:48:23 +00:00
Noemi Erli
0141b9c94c
Backed out 4 changesets (bug 1488507, bug 1494170) for failures in browser/base/content/test/static/browser_all_files_referenced.js CLOSED TREE
...
Backed out changeset 51b6727d7abd (bug 1488507)
Backed out changeset 8887f8ebc376 (bug 1494170)
Backed out changeset fc1300333ea2 (bug 1494170)
Backed out changeset c9b20f40041d (bug 1494170)
2018-10-01 15:56:26 +03:00
Noemi Erli
31a0611e5a
Merge mozilla-central to autoland. a=merge CLOSED TREE
2018-10-01 12:45:32 +03:00
Noemi Erli
05d24a8ad0
Merge inbound to mozilla-central. a=merge
2018-10-01 12:41:32 +03:00
Daisuke Akatsuka
9d101b9e44
Bug 1488507: Disable extension/worker debugging except this firefox. r=jdescottes
...
Depends on D7038
Differential Revision: https://phabricator.services.mozilla.com/D7039
--HG--
extra : moz-landing-system : lando
2018-10-01 09:17:38 +00:00
Daisuke Akatsuka
c9e805c422
Bug 1494170: Show device name for Android. r=jdescottes
...
Depends on D7037
Differential Revision: https://phabricator.services.mozilla.com/D7038
--HG--
extra : moz-landing-system : lando
2018-10-01 07:58:51 +00:00
Daisuke Akatsuka
11214aad9d
Bug 1494170: Show proper icon of runtime. r=jdescottes
...
Depends on D7036
Differential Revision: https://phabricator.services.mozilla.com/D7037
--HG--
extra : moz-landing-system : lando
2018-10-01 07:41:31 +00:00
Daisuke Akatsuka
f83a54699b
Bug 1494170: Show proper runtime's name and version. r=jdescottes
...
Depends on D6881
Differential Revision: https://phabricator.services.mozilla.com/D7036
--HG--
extra : moz-landing-system : lando
2018-10-01 07:33:16 +00:00
Julien Wajsberg
c2de61821b
Bug 1459720 - Add a test that checks that we correctly launch the perf panel when pushing the button in WebIDE r=jdescottes
...
Depends on D6904
Differential Revision: https://phabricator.services.mozilla.com/D6934
--HG--
extra : moz-landing-system : lando
2018-10-01 06:21:54 +00:00
Alexander Surkov
bdd3f4e880
Bug 1494230 - replace #text-base binding by webidl control, r=smaug
2018-10-01 11:37:39 +08:00
yulia
9809b1f863
Bug 1488381 - Use target.getFront to instantiate WebExtensionInspectedWindowFront; r=ochameau
...
Depends on D6768
Differential Revision: https://phabricator.services.mozilla.com/D7063
--HG--
extra : moz-landing-system : lando
2018-09-28 17:52:26 +00:00
yulia
1f713970f4
Bug 1488373 - Use target.getFront to instantiate StyleSheetsFront; r=ochameau
...
Depends on D6768
Differential Revision: https://phabricator.services.mozilla.com/D7093
--HG--
extra : moz-landing-system : lando
2018-09-27 15:44:54 +00:00
yulia
93303e9746
Bug 1488370 - Use target.getFront to instantiate WebGLFront; r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D7094
--HG--
extra : moz-landing-system : lando
2018-09-28 18:04:29 +00:00
yulia
b107324366
Bug 1488374 - Use target.getFront to instantiate StorageFront; r=ochameau
...
Depends on D7061
Differential Revision: https://phabricator.services.mozilla.com/D7062
--HG--
extra : moz-landing-system : lando
2018-09-30 06:55:23 +00:00
David Walsh
562c3178d7
Bug 1314057 - Remove search and breadcrumb tests for old debugger. r=jlast
...
--HG--
extra : histedit_source : 0544e5cad57a035055a027dc240ffe17051baf98
2018-09-26 10:23:02 -05:00
Gabriel Luong
bf360fcb91
Bug 1494162 - Part 38: Use the cached css properties in the inspector. r=pbro
...
Avoid using getCssProperties where possible to fetch the css properties when we
can used the cached version in the inspector.
2018-10-01 13:38:19 -04:00
Brian Hackett
c27c10805b
Bug 1495342 - Add 'Reload and Record Tab' menu item and functionality, r=jlast.
...
--HG--
extra : rebase_source : d8c053278ec3d50367f63219e51cf178b8decf7a
2018-10-01 09:42:50 -10:00
Brian Hackett
2ff1490550
Bug 1495341 - Place Web Replay menu items in their own submenu, r=jlast.
...
--HG--
extra : rebase_source : f710745682fe0bce31a8c4f97edfbf2868507c10
2018-10-01 09:41:32 -10:00
meagonqz
bbaebad945
Bug 1492730 - network: show resent XHR when filtering r=honza
2018-09-25 00:31:09 -04:00
Daniel Varga
6a29e8afe5
Merge mozilla-central to mozilla-inbound. a=merge
2018-10-03 01:17:27 +03:00
Jason Laster
d4c53d0048
Revert "Backed out changeset c209b1927107 (bug 923975) for failing at mochitest/browser_dbg_rr_stepping-02.js, etc. removed obsolete files. a=backout"
...
This reverts commit b7f018206386dab85fb82cbaaf24f15ad60eff14.
2018-10-02 16:40:32 -04:00
Jason Laster
5fad9a20a0
Revert "Backed out changeset 3599e95a53b7 (bug 923975) for build bustage when reverting backout on a CLOSED TREE"
...
This reverts commit e0e90b5c82d8f05feb9df1e5b675c0680b469524.
2018-10-02 16:40:32 -04:00
arthur.iakab
6d5ae40a02
Merge inbound to mozilla-central a=merge
2018-09-29 07:16:35 +03:00
Jason Laster
ecd19c3ae0
Bug 1494464 - Update Debugger Frontend v90. r=dwalsh
2018-10-01 16:41:32 -04:00
Gabriel Luong
0f9c8cd9fb
Bug 1494162 - Part 35: Lazy load MenuButton, MenuItem, and MenuList components in ToolboxTabs. r=jdescottes
...
These Menu components are only needed when we show the chevron.
2018-10-01 15:30:21 -04:00
Razvan Caliman
fcbdeb7942
Bug 1490720 - Log changes to CSS declarations from StyleRuleActor. r=pbro
...
MozReview-Commit-ID: 9J4zBcSxYwj
Differential Revision: https://phabricator.services.mozilla.com/D5681
--HG--
extra : moz-landing-system : lando
2018-09-28 17:30:49 +00:00
Logan Smyth
1fe5b507c8
Bug 1495029 - Add source-map@0.7.3's mappings.wasm asset to prepare for upgrade. r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D7207
--HG--
rename : devtools/client/shared/source-map/dwarf_to_json.wasm => devtools/client/shared/source-map/assets/dwarf_to_json.wasm
extra : moz-landing-system : lando
2018-09-28 19:41:21 +00:00
Tiberius Oros
5b3b1df198
Merge inbound to mozilla-central. a=merge
2018-09-28 18:39:03 +03:00
Julien Wajsberg
6ddb5fb144
Bug 1459720 - Move the performance panel out of the toolbox to the WebIDE's top level window r=jdescottes
...
This effectively removes the devtools overhead while profiling... as
long as the toolbox isn't opened as well of course.
This also removes the performance panel from the Browser Toolbox and the
Browser Content Toolbox where it shouldn't have been in the first place.
Differential Revision: https://phabricator.services.mozilla.com/D6904
--HG--
extra : moz-landing-system : lando
2018-09-28 12:48:05 +00:00
Alexandre Poirot
5982b4bf8b
Bug 1494288 - Remove noTabReconfigureOnClose trait and client code to reconfigure on disconnect r=yulia
...
MozReview-Commit-ID: 4zy9ho4425q
Differential Revision: https://phabricator.services.mozilla.com/D6938
--HG--
extra : moz-landing-system : lando
2018-09-28 07:39:44 +00:00
yulia
bb6365c720
Bug 1487428 - Use target.getFront in server browser tests; r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D6768
--HG--
extra : moz-landing-system : lando
2018-09-28 05:46:29 +00:00
yulia
2324dc62c4
Bug 1485373
- Use client.mainRoot.getFront to fetch all global actors; r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D6792
--HG--
extra : moz-landing-system : lando
2018-09-28 07:07:14 +00:00
Daisuke Akatsuka
dcbc040145
Bug 1494169 - Part 2: Connect to USB device. r=jdescottes
...
Depends on D6880
Differential Revision: https://phabricator.services.mozilla.com/D6881
--HG--
extra : moz-landing-system : lando
2018-09-28 04:27:44 +00:00
Daisuke Akatsuka
c6aa91edfc
Bug 1494169 - Part 1: Show connect button to USB debice. r=jdescottes
...
Depends on D6878
Differential Revision: https://phabricator.services.mozilla.com/D6880
--HG--
extra : moz-landing-system : lando
2018-09-27 07:38:15 +00:00
Bogdan Tara
273a59bcda
Backed out changeset e7624782898d (bug 1487428) for test_inspector-insert.html failures CLOSED TREE
2018-09-27 23:38:04 +03:00
Jason Laster
b0a0465f39
Bug 1491471 - Move the OI store to the console. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D5911
--HG--
rename : devtools/client/shared/components/reps/reps.js => devtools/client/shared/components/reps/reps-old.js
extra : moz-landing-system : lando
2018-09-27 20:09:51 +00:00
yulia
26f84dc0e4
Bug 1487428 - Use target.getFront in server browser tests; r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D6768
--HG--
extra : moz-landing-system : lando
2018-09-27 15:18:08 +00:00
Nicolas Chevobbe
433264a3b1
Bug 1410820 - Extensively test top-level await evaluation; r=bgrins.
...
We add several tests and modify the existing one to make sure we handle
top level await correctly in different situation (resolving, rejecting,
when paused in the debugger, when using $_, …).
Depends on D6925
Differential Revision: https://phabricator.services.mozilla.com/D6926
--HG--
extra : moz-landing-system : lando
2018-09-27 16:01:16 +00:00
Nicolas Chevobbe
674b26da5e
Bug 1410820 - Enhance webconsole test helpers; r=bgrins.
...
1. Allow passing a selector to waitForMessage helper function:
This will allow to wait for specific message (warning, error, result, …).
This patch also fixes 2 tests that were already passing an erroneous selector
to waitForMessage.
2. Add an executeAndWaitForMessage function:
This will make a lot of our tests much easier to read. The function takes
an input, an expected output and an optional selector, execute the input
and resolves when a message matching the provided text (and selector
if passed) is displayed in the output.
Depends on D6903
Differential Revision: https://phabricator.services.mozilla.com/D6925
--HG--
extra : moz-landing-system : lando
2018-09-27 16:00:32 +00:00
Nicolas Chevobbe
2aa2e07452
Bug 1410820 - top-level await evaluation should be handled as regular evaluation; r=bgrins.
...
This patch turns the current top-level handling, which relies on
the console API to print the result of the await expression, into
something natively handled by the server.
First, we don't add a .then handler to the generated async iife by
the mapper. We also removes the case we added in the JsTerm to *not*
print the result for top-level await expression.
In order to make the server capable of handling generated async iife
caused by the mapper, we send to evaluateJsAsync the `mapped` object
that `mapExpression` returns. This way, the server can check if an
expression was originally a top-level await.
If it is the case, we get the promise from the async iife and wait for
it to settle. If it resolves, we simply return the result, as a grip,
to the client. If it rejects, we return a special packet indicating to
not print anything to the client. The error will be reported by the
engine as `uncaught exception: …`.
We add several tests and modify the existing one to make sure we handle
top level await correctly in different situation (resolving, rejecting,
when paused in the debugger, when using $_, …).
Differential Revision: https://phabricator.services.mozilla.com/D6903
--HG--
extra : moz-landing-system : lando
2018-09-27 15:59:47 +00:00
Nicolas Chevobbe
237c4ba134
Bug 1494545 - Make Ctrl+Space open the autocomplete popup in the console; r=Honza.
...
Differential Revision: https://phabricator.services.mozilla.com/D7049
--HG--
extra : moz-landing-system : lando
2018-09-27 16:36:11 +00:00
Gurzau Raul
a8d8876e9e
Merge mozilla-central to autoland. a=merge CLOSED TREE
2018-09-27 19:45:35 +03:00
Julien Wajsberg
9ce2cbff3e
Bug 1494337 - Do not display the 'triggers refresh' note if there's no option needing it r=ochameau
...
Depends on D6923
Differential Revision: https://phabricator.services.mozilla.com/D6920
--HG--
extra : moz-landing-system : lando
2018-09-27 14:33:41 +00:00
Julien Wajsberg
f74fc26e96
Bug 1494337 - Move the 'tool not supported' label to the right place r=ochameau
...
Depends on D6922
Differential Revision: https://phabricator.services.mozilla.com/D6923
--HG--
extra : moz-landing-system : lando
2018-09-27 14:33:39 +00:00
Julien Wajsberg
b29f25d7b3
Bug 1494337 - Insert the settings for nightly before the 'reloads the page' indication r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D6922
--HG--
extra : moz-landing-system : lando
2018-09-27 14:33:38 +00:00
StefanYohansson
41d490dca9
Bug 1172314 - Print arguments passed into console.trace. r=bgrins.
...
Added trace extra parameters to be printed alongside console.trace() output.
Differential Revision: https://phabricator.services.mozilla.com/D7051
--HG--
extra : moz-landing-system : lando
2018-09-27 13:27:57 +00:00
Nicolas Chevobbe
89eca29ba9
Bug 1492827 - Remove unused listeners and handlers from webconsole-connection-proxy; r=ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D7073
--HG--
extra : moz-landing-system : lando
2018-09-27 11:46:26 +00:00
yulia
72f9e83eb1
Bug 1473513 - move ActorRegistry module to server/actors/utils; r=ochameau
...
Summary: Depends on D6477
Reviewers: ochameau
Reviewed By: ochameau
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6479
--HG--
rename : devtools/server/actor-registry.js => devtools/server/actors/utils/actor-registry.js
extra : rebase_source : ae52db7b028b4d866d8a363eae9ae7c124714458
2018-09-26 10:09:15 +02:00
yulia
29af71d6af
Bug 1473513 - resolve memory leak
...
Summary: Depends on D6476
Reviewers: ochameau
Reviewed By: ochameau
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6477
--HG--
extra : rebase_source : 61ccae905e3136ad3c293db692551786e83075c7
2018-09-26 10:08:43 +02:00
yulia
c6dbe43c8e
Bug 1473513 - reduce number of poolFor calls; r=ochameau
...
Summary:
MozReview-Commit-ID: 9VqKPauAP9j
Depends on D6475
Reviewers: ochameau
Reviewed By: ochameau
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6476
--HG--
extra : rebase_source : 1bebc34bf805dfcf7bce0b5d8f3a2a13bab11173
2018-09-26 10:08:10 +02:00
yulia
dd29e366ea
Bug 1473513 - refactor main.js to use protocol.js pools; r=ochameau
...
Summary:
MozReview-Commit-ID: FNMK4f553yI
Depends on D6474
Reviewers: ochameau
Reviewed By: ochameau
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6475
--HG--
extra : rebase_source : c61d394da0a20991def49968f01ee563fea9afde
2018-09-26 10:07:27 +02:00
yulia
9c120b705d
Bug 1473513 - separate registerModule behavior from DebuggerServer; r=ochameau
...
Summary:
MozReview-Commit-ID: 3GsXRxcIKfx
Depends on D6473
Reviewers: ochameau
Reviewed By: ochameau
Subscribers: reviewbot
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6474
--HG--
rename : devtools/server/main.js => devtools/server/actor-registry.js
extra : rebase_source : 3ea4edd91ca8b09ad5e25ae01df885c587bee7b1
2018-09-26 10:06:43 +02:00
yulia
0c9522358e
Bug 1473513 - Ensure that actorPools in root are destroyed on destroy; r=ochameau
...
Summary: Depends on D6472
Reviewers: ochameau
Reviewed By: ochameau
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6473
--HG--
extra : rebase_source : 075dd9b2128adf04f0bbf6fc7f0708ca532a49aa
2018-09-26 10:06:00 +02:00
yulia
e1c0e43fff
Bug 1473513 - remove other instances of ActorPool from browsingContext and root; r=ochameau
...
Summary:
MozReview-Commit-ID: GxkLzvxJgdY
Depends on D6471
Reviewers: ochameau
Reviewed By: ochameau
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6472
--HG--
extra : rebase_source : 8877be9e01d379375a167c58c61d94efd4997e19
2018-09-26 10:05:31 +02:00
yulia
99bb10079e
Bug 1473513 - make log function safer so that tests do not time out; r=ochameau
...
Summary:
MozReview-Commit-ID: BIk5pWzxJcx
Depends on D6470
Reviewers: ochameau
Reviewed By: ochameau
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6471
--HG--
extra : rebase_source : 0284679e1a6d33ed915ebf69cf56557847bceb66
2018-09-26 10:04:57 +02:00
yulia
4a8f74eb3e
Bug 1473513 - create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor; r=ochameau
...
Summary:
create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor;
Depends on D6468
Reviewers: ochameau
Reviewed By: ochameau
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6470
--HG--
rename : devtools/server/actors/common.js => devtools/shared/protocol/lazy-pool.js
extra : rebase_source : 09a1c8eac3cbb5856a5e3e61a1c0540efe32e5bd
2018-09-26 10:03:33 +02:00
yulia
7caf289dbe
Bug 1473513 - use Protocol.js pools for workerTargetActorPool in Target Actors; r=ochameau
...
Summary: MozReview-Commit-ID: 5uIWwOR7CHp
Reviewers: ochameau
Reviewed By: ochameau
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6468
--HG--
extra : rebase_source : b5f560e404727a168c5b35924961a49c51b849df
2018-09-26 10:02:54 +02:00
Michael Ratcliffe
4e3c6d2b5f
Bug 1491879 - Fix telemetry support for multiple tabs / windows r=nchevobbe
...
- Various telemetry methods now need an object to be passed in in order to keep them seperate e.g. if the inspector is opened in tab 1 a timer is started. If an inspector is opened in tab 2 the same timer is restarted. Closing tab 2 would then erase the timing event invalidating the timer in tab 1.
- We no longer need to preface telemetry calls with category "devtools.main" because this is the only category we will be using.
- There are some changes to `devtools/client/debugger/new/dist/vendors.js` and `devtools/client/debugger/new/src/utils/telemetry.js` that need to be ported to the debugger at the same time as landing this.
Differential Revision: https://phabricator.services.mozilla.com/D6137
--HG--
extra : moz-landing-system : lando
2018-09-25 12:57:13 +00:00
Alexandre Poirot
0df7ab9a73
Bug 1494317 - Remove "newScript" event leftovers r=yulia
...
MozReview-Commit-ID: 3lc5XXdBWgS
Depends on D6941
Differential Revision: https://phabricator.services.mozilla.com/D6942
--HG--
extra : moz-landing-system : lando
2018-09-26 18:11:55 +00:00
Alexandre Poirot
06ff174025
Bug 1494319 - Remove unused "newGlobal" event r=yulia
...
MozReview-Commit-ID: 4bQyjXYuN18
Depends on D6940
Differential Revision: https://phabricator.services.mozilla.com/D6941
--HG--
extra : moz-landing-system : lando
2018-09-26 18:09:54 +00:00
Alexandre Poirot
340ed44d31
Bug 1494322 - Remove unused UnsolicitedNotifications r=yulia
...
MozReview-Commit-ID: Fc2upXImxP2
Differential Revision: https://phabricator.services.mozilla.com/D6940
--HG--
extra : moz-landing-system : lando
2018-09-27 08:50:13 +00:00
Alexandre Poirot
c4e18d3974
Bug 1494305 - Refactor all tabClient usages to use promise API instead of callback style r=yulia
...
MozReview-Commit-ID: DZVG1X45sQV
Differential Revision: https://phabricator.services.mozilla.com/D6908
--HG--
extra : moz-landing-system : lando
2018-09-26 18:02:45 +00:00
Alexandre Poirot
3ad83b9241
Bug 1492856 - Remove compatiblity code to guard against miss of RootActor.getRoot r=jdescottes
...
MozReview-Commit-ID: L5kkG9r7Rtv
Differential Revision: https://phabricator.services.mozilla.com/D6755
--HG--
extra : moz-landing-system : lando
2018-09-26 21:12:16 +00:00
Alexandre Poirot
4c1bb0403e
Bug 1397020 - Remove useless calls to TabTarget.attach r=yulia
...
TabTarget.attach is being called from the toolbox, before opening the tools,
so we do not have to call it from panel's open functions, nor code that is opening
a toolbox right after.
MozReview-Commit-ID: 77TZFbvOaFt
Differential Revision: https://phabricator.services.mozilla.com/D6668
--HG--
extra : moz-landing-system : lando
2018-09-26 21:11:51 +00:00
Mantaroh Yoshinaga
495837c33c
Bug 1472942 - Part 2. Add setContentSize() instead of setContent() in HTMLTooltip. r=birtles
...
This patch will remove setContest(), and change the following things instead of this:
* Use HTMLTooltip.panel.appendChild() instead of HTMLTooltip.setContent().
* Add HTMLTooltip.setContetnSize() to specify the panel size if need this.
Differential Revision: https://phabricator.services.mozilla.com/D7044
--HG--
extra : moz-landing-system : lando
2018-09-27 07:14:55 +00:00
Mantaroh Yoshinaga
adb9bb2f7a
Bug 1472942 - Part 1. Remove unused paramter of HTMLTooltip.show from SwatchBaseEditorTooltip. r=jdescottes
...
SwatchBaseEditorTooltip specify the "topcentor bototmleft" to second parameter
of HTMLTooltip.show(). However, this parameter will ignore since show() function
require the second parameter as the object, not the string.
Bug 1307481 comment 42 has pointed out this parameter.
Differential Revision: https://phabricator.services.mozilla.com/D7043
--HG--
extra : moz-landing-system : lando
2018-09-27 07:15:18 +00:00
Julian Descottes
d03effab3f
Bug 1493968 - Wait for initial targets in aboutdebugging navigate test to avoid race condition;r=daisuke
...
Differential Revision: https://phabricator.services.mozilla.com/D6975
--HG--
extra : moz-landing-system : lando
2018-09-27 05:48:45 +00:00
Daisuke Akatsuka
a5baf7ae30
Bug 1493883: Add 'name' field to network runtime for consistency. r=jdescottes
...
Depends on D6878
Differential Revision: https://phabricator.services.mozilla.com/D6885
--HG--
extra : moz-landing-system : lando
2018-09-27 04:46:38 +00:00
Daisuke Akatsuka
e2089c90e6
Bug 1493883: Extract USB runtime data needed. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D6878
--HG--
extra : moz-landing-system : lando
2018-09-26 11:55:17 +00:00
Xidorn Quan
cb87cec282
Bug 1494501 - Rename pref "layout.css.scrollbar-colors.enabled" to "layout.css.scrollbar-color.enabled". r=heycam
...
Differential Revision: https://phabricator.services.mozilla.com/D7030
--HG--
extra : moz-landing-system : lando
2018-09-27 00:38:16 +00:00
shindli
a8d55dae12
Merge inbound to mozilla-central. a=merge
2018-09-27 00:52:12 +03:00
Logan F Smyth
c14f7c8aff
Bug 1473996 - Expose fn.apply in the devtools server. r=nchevobbe
...
Depends on D6722
Differential Revision: https://phabricator.services.mozilla.com/D6723
--HG--
extra : moz-landing-system : lando
2018-09-26 16:23:25 +00:00
Logan F Smyth
11febfa688
Bug 1473996 - Expose getPropertyValue in devtools server to fully evaluate an object property. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D6722
--HG--
extra : moz-landing-system : lando
2018-09-26 16:12:56 +00:00
Julian Descottes
778d5e8d33
Bug 1489220 - Add mochitest for empty message in debug target pane;r=daisuke
...
Differential Revision: https://phabricator.services.mozilla.com/D6495
--HG--
extra : moz-landing-system : lando
2018-09-26 08:58:15 +00:00
Nicolas Chevobbe
14ff2e3235
Bug 1476656 - Trigger autocomplete on bracket; r=Honza.
...
This patch adds the ability to open the autocomplete popup when
typing an opening bracket (i.e. `[`]) in the console input.
This impacts a significant amount of function where we assumed
that the only way to get a completion was to use a dot.
We uses the rename `anylyzeInputString` function to get the
completion part from an input, as well as if the user is performing
an element access (i.e., using the bracket).
We then send that information to the webconsole actor, which send
it to the client.
This allows us to rely on a single parse of the input and gives us
access to this information everywhere we need to, be it on the client
or on the server.
We allow the user to type property name without quotes, and we add
them when the user accept an autocompletion.
We also automatically add a closing bracket (i.e. `]`), when it's needed.
Some test are added. On the server side to make sure the actor's autocomplete
function returns what's expected.
We take that as an opportunity to add test for commands.
On the client side, tests are added to ensure the different behavior works
as expected (check the completion text and the input after accepting
the completion when the user entered some letters, or not, with or without
quotes, with different quotes, hitting the autocomplete cache, …).
A test which accesses the autocomplete cache was modified since the shape
of the cache changed to include the last matchProp as well as the
isElementAccess boolean.
Differential Revision: https://phabricator.services.mozilla.com/D6128
--HG--
extra : moz-landing-system : lando
2018-09-26 13:54:35 +00:00
arthur.iakab
e1e94e3d20
Merge mozilla-central to autoland
2018-09-26 15:57:12 +03:00
arthur.iakab
ec46826255
Merge inbound to mozilla-central. a=merge
2018-09-26 15:54:41 +03:00
sreeise
847b33d284
Bug 1423201 - Changed uses of defer to new Promise in devtools/server/tests/mochitest r=nchevobbe
...
Functions using 'defer' for promises are being switched to the 'new Promise' syntax. This is for changes in devtools/server/tests/mochitest.
Differential Revision: https://phabricator.services.mozilla.com/D6618
--HG--
extra : moz-landing-system : lando
2018-09-26 02:44:56 +00:00
Xidorn Quan
c46ef183e2
Bug 1492012 - Enable scrollbar-color and scrollbar-width by default. r=heycam
...
Differential Revision: https://phabricator.services.mozilla.com/D6872
--HG--
extra : moz-landing-system : lando
2018-09-26 03:30:32 +00:00
Ciure Andrei
ce57be88b8
Merge inbound to mozilla-central. a=merge
2018-09-26 00:49:06 +03:00
Amy Chan
5c903b5d23
Bug 1479421 - Making the response panel visible; r=Honza
...
Making the response panel visible
Differential Revision: https://phabricator.services.mozilla.com/D4636
--HG--
extra : moz-landing-system : lando
2018-09-26 07:14:33 +00:00
Jason Laster
716f4ecb2b
Bug 923975 - Teach step out to leave the current frame. r=jlast
2018-10-03 09:50:44 -04:00
Alexandre Poirot
816dd96825
Bug 1490927 - Stop sharing maps in NetworkMonitor between all instances. r=Honza
...
When opening a web console and a browser console, we instantiate two NetworkMonitor
instances in the same process and they need independant states.
Differential Revision: https://phabricator.services.mozilla.com/D6054
--HG--
extra : moz-landing-system : lando
2018-09-19 23:26:05 +00:00
Julian Descottes
17903b38b8
Bug 1492863 - Fix react warnings in aboutdebugging-new;r=daisuke
...
Differential Revision: https://phabricator.services.mozilla.com/D6400
--HG--
extra : moz-landing-system : lando
2018-09-25 11:04:58 +00:00
Alexandre Poirot
e008acf411
Bug 1473513 - Backed out changeset 0e431edddacd for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
...
Summary:
MozReview-Commit-ID: 1BlQk4H0c1w
Depends on D6812
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6813
2018-09-25 19:35:14 +03:00
Alexandre Poirot
18a737b18d
Bug 1473513 - Backed out changeset 27419719402e for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
...
Summary:
MozReview-Commit-ID: 43tUMmC1Je0
Depends on D6811
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6812
2018-09-25 19:35:00 +03:00
Alexandre Poirot
3695cdf575
Bug 1473513 - Backed out changeset 6fc241b06e0b for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
...
Summary:
MozReview-Commit-ID: 6dCPXvBYhsJ
Depends on D6810
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6811
2018-09-25 19:34:52 +03:00
Alexandre Poirot
67f96eff34
Bug 1473513 - Backed out changeset e56c70bd2f9a for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
...
Summary:
MozReview-Commit-ID: 9FIL35Nq726
Depends on D6809
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6810
2018-09-25 19:34:43 +03:00
Alexandre Poirot
bb3ecc7ca4
Bug 1473513 - Backed out changeset c690d2383ca4 for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
...
Summary:
MozReview-Commit-ID: KSgxXnGdsJk
Depends on D6808
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6809
2018-09-25 19:34:35 +03:00
Alexandre Poirot
1255c658b2
Bug 1473513 - Backed out changeset d72f6ff37ca6 for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
...
Summary:
MozReview-Commit-ID: LKPmFrhaQ5q
Depends on D6807
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6808
2018-09-25 19:34:26 +03:00
Alexandre Poirot
40272ff560
Bug 1473513 - Backed out changeset f9f12b44a3ab for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
...
Summary:
MozReview-Commit-ID: 8POm9seFrAk
Depends on D6806
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6807
2018-09-25 19:34:18 +03:00
Alexandre Poirot
58167747ab
Bug 1473513 - Backed out changeset db43912632fb for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
...
Summary:
MozReview-Commit-ID: DbUwQ0NQZcE
Depends on D6805
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6806
2018-09-25 19:34:09 +03:00
Alexandre Poirot
e73ec8adf4
Bug 1473513 - Backed out changeset 80c51a6e896e for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
...
Summary:
MozReview-Commit-ID: 3TCiKetO6fn
Depends on D6804
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6805
2018-09-25 19:34:01 +03:00
Alexandre Poirot
a3c7499a55
Bug 1473513 - Backed out changeset 174fe98999ea for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
...
Summary:
MozReview-Commit-ID: GfSX2wYfLrN
Depends on D6803
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6804
--HG--
rename : devtools/server/actors/utils/actor-registry.js => devtools/server/actor-registry.js
2018-09-25 19:33:52 +03:00
Alexandre Poirot
8dac98409f
Bug 1473513 - Backed out changeset 950ce58bfb24 for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
...
Summary: MozReview-Commit-ID: 1HAisV9S6ls
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6803
2018-09-25 19:33:43 +03:00
Alexandre Poirot
62fca91459
Bug 1473513 - Fix merge conflict between bug 1473513 and 1485676 against this test. CLOSED TREE
...
Summary: MozReview-Commit-ID: KyizI0V5pt5
Bug #: 1473513
Differential Revision: https://phabricator.services.mozilla.com/D6778
2018-09-25 17:24:00 +03:00
Alexandre Poirot
e490a53de2
Bug 1492826 - Better document TabTarget.attach as well as DebuggerClient.attachTarget and attachConsole. r=jdescottes
...
Depends On D6162
Differential Revision: https://phabricator.services.mozilla.com/D6388
--HG--
extra : moz-landing-system : lando
2018-09-24 16:24:07 +00:00
Margareta Eliza Balazs
5ad86cabda
Merge mozilla-central to autoland. a=merge CLOSED TREE
2018-09-25 12:50:02 +03:00
Margareta Eliza Balazs
ffe6eaf2f0
Merge inbound to mozilla-central. a=merge
2018-09-25 12:42:09 +03:00
yulia
04d870f203
Bug 1473513 - move ActorRegistry module to server/actors/utils; r=ochameau
...
Depends on D6477
Differential Revision: https://phabricator.services.mozilla.com/D6479
--HG--
rename : devtools/server/actor-registry.js => devtools/server/actors/utils/actor-registry.js
extra : moz-landing-system : lando
2018-09-25 08:47:10 +00:00
yulia
19b4e8fbe6
Bug 1473513 - resolve memory leak r=ochameau
...
Depends on D6476
Differential Revision: https://phabricator.services.mozilla.com/D6477
--HG--
extra : moz-landing-system : lando
2018-09-25 08:06:25 +00:00
yulia
a0882d24f7
Bug 1473513 - reduce number of poolFor calls; r=ochameau
...
MozReview-Commit-ID: 9VqKPauAP9j
Depends on D6475
Differential Revision: https://phabricator.services.mozilla.com/D6476
--HG--
extra : moz-landing-system : lando
2018-09-25 08:06:17 +00:00
yulia
1ad50b5afe
Bug 1473513 - refactor main.js to use protocol.js pools; r=ochameau
...
MozReview-Commit-ID: FNMK4f553yI
Depends on D6474
Differential Revision: https://phabricator.services.mozilla.com/D6475
--HG--
extra : moz-landing-system : lando
2018-09-25 08:05:47 +00:00
yulia
e857119004
Bug 1473513 - separate registerModule behavior from DebuggerServer; r=ochameau
...
MozReview-Commit-ID: 3GsXRxcIKfx
Depends on D6473
Differential Revision: https://phabricator.services.mozilla.com/D6474
--HG--
rename : devtools/server/main.js => devtools/server/actor-registry.js
extra : moz-landing-system : lando
2018-09-25 08:05:29 +00:00
yulia
08c887b837
Bug 1473513 - Ensure that actorPools in root are destroyed on destroy; r=ochameau
...
Depends on D6472
Differential Revision: https://phabricator.services.mozilla.com/D6473
--HG--
extra : moz-landing-system : lando
2018-09-25 08:04:59 +00:00
yulia
54d3f62aa0
Bug 1473513 - remove other instances of ActorPool from browsingContext and root; r=ochameau
...
MozReview-Commit-ID: GxkLzvxJgdY
Depends on D6471
Differential Revision: https://phabricator.services.mozilla.com/D6472
--HG--
extra : moz-landing-system : lando
2018-09-25 08:04:41 +00:00
yulia
de5a5707d6
Bug 1473513 - make log function safer so that tests do not time out; r=ochameau
...
MozReview-Commit-ID: BIk5pWzxJcx
Depends on D6470
Differential Revision: https://phabricator.services.mozilla.com/D6471
--HG--
extra : moz-landing-system : lando
2018-09-25 08:04:22 +00:00
yulia
1cea42cdd7
Bug 1473513 - create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor; r=ochameau
...
create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor;
Depends on D6468
Differential Revision: https://phabricator.services.mozilla.com/D6470
--HG--
rename : devtools/server/actors/common.js => devtools/shared/protocol/lazy-pool.js
extra : moz-landing-system : lando
2018-09-25 08:03:42 +00:00
yulia
56e91adaa1
Bug 1473513 - use Protocol.js pools for workerTargetActorPool in Target Actors; r=ochameau
...
MozReview-Commit-ID: 5uIWwOR7CHp
Differential Revision: https://phabricator.services.mozilla.com/D6468
--HG--
extra : moz-landing-system : lando
2018-09-25 08:02:11 +00:00
Gabriel Luong
697b700c0f
Bug 1317102 - Part 3: Disable grid highlighter toggles in the markup when the max highlighter is reached. r=jdescottes
...
--HG--
rename : devtools/client/inspector/markup/test/browser_markup_grid_display_badge.js => devtools/client/inspector/markup/test/browser_markup_grid_display_badge_01.js
2018-09-24 20:38:11 -04:00
Julian Descottes
26887111d9
Bug 1489434 - Add i18n for DeviceSidebarItemAction component;r=birtles
...
Depends on D6614
Differential Revision: https://phabricator.services.mozilla.com/D6615
--HG--
extra : moz-landing-system : lando
2018-09-25 06:38:52 +00:00
Julian Descottes
b246d48d96
Bug 1489434 - Add i18n for ConnectPage component;r=birtles
...
Depends on D6613
Differential Revision: https://phabricator.services.mozilla.com/D6614
--HG--
extra : moz-landing-system : lando
2018-09-25 06:38:13 +00:00
Julian Descottes
641123a0a4
Bug 1489434 - Add i18n for NetworkLocationsForm component;r=birtles
...
Depends on D6612
Differential Revision: https://phabricator.services.mozilla.com/D6613
--HG--
extra : moz-landing-system : lando
2018-09-25 06:37:19 +00:00
Julian Descottes
e22e59e285
Bug 1489434 - Add i18n for NetworkLocationsList component;r=birtles
...
Depends on D6611
Differential Revision: https://phabricator.services.mozilla.com/D6612
--HG--
extra : moz-landing-system : lando
2018-09-25 06:35:23 +00:00
Julian Descottes
8b8f412ae2
Bug 1489427 - Add i18n for WorkerDetail component;r=birtles
...
Depends on D6610
Differential Revision: https://phabricator.services.mozilla.com/D6611
--HG--
extra : moz-landing-system : lando
2018-09-25 06:09:09 +00:00
Gurzau Raul
79c1eec12d
Merge mozilla-central to inbound. a=merge CLOSED TREE
2018-09-25 01:10:22 +03:00
Alexandre Poirot
4be011069c
Bug 1485676 - Fix missing await on TargetFactory.forTab in console tests after rebase. (hotfix) r=me
...
MozReview-Commit-ID: 9S2SGGFE9xw
2018-09-24 11:31:37 -07:00
Gabriel Luong
08a1d10fb1
Bug 1317102 - Part 2: Refactor the highlighter event handlers into ElementEditor and prevent flickering of the display badge when toggled from a click. r=jdescottes
...
- Refactor the highlighter shown/hidden event handlers from MarkupElementContainer in ElementEditor.
We do this because we want to be a bit more lazy when we set these on/off highlighters to only when
there is only a display badge and appropriate display type.
- This fixes a flickering bug cause by the event handlers when you click on the display badges in the markup view.
STR:
1. Have 2 grids shown on the markup view.
2. Toggle on one of them
3. Toggle the other one.
4. See that the active state toggles on, off and on.
We want to toggle the active state manually instead of waiting for the highlighter event handler
to toggle its active state when we click on the display badge. This is because waiting for
the highlight event handler to toggle the active state will cause a brief delay from showing
the active state when the user clicked on the display badge. To fix this, we added a way
to start/stop the highlighter event handlers.
2018-09-24 13:45:13 -04:00
Gabriel Luong
3a26040bed
Bug 1248619 - Part 1: Refactor and restore the reload condition settings in RDM. r=rcaliman
2018-09-24 13:04:03 -04:00
Alexandre Poirot
c7a9923fc3
Bug 1485676 - Rename DebuggerClient.attachTab to attachTarget. r=jdescottes
...
Summary:
This method isn't specific to tabs. It can attach to any "target" actor that inherits from BrowsingContextActor.
Depends On D6161
Reviewers: yulia!
Tags: #secure-revision
Bug #: 1485676
Differential Revision: https://phabricator.services.mozilla.com/D6162
MozReview-Commit-ID: Exz5fWyWyfN
2018-09-24 09:52:59 -07:00
Alexandre Poirot
fc8714580a
Bug 1485676 - Rename TabTarget.makeRemote to TabTarget.attach. r=jdescottes
...
Summary:
Now that all the "remoting" of this method has been moved to TargetFactory.createTargetForTab,
we should rename this method to what it does now. It mostly call attach requests
of the target actor and its child console actor.
It also "connect" the webextension target actor, but I would like to eventually move that
outside of TabTarget.attach, like makeRemote.
Depends On D4078
Reviewers: yulia!
Tags: #secure-revision
Bug #: 1485676
Differential Revision: https://phabricator.services.mozilla.com/D6161
MozReview-Commit-ID: KmFi1LIUBga
2018-09-24 09:52:57 -07:00
Alexandre Poirot
082e20e693
Bug 1485676 - Connect to local server from TargetFactory.forTab and make TabTarget always remote-like. r=yulia
...
Tags: #secure-revision
Bug #: 1485676
Differential Revision: https://phabricator.services.mozilla.com/D4078
MozReview-Commit-ID: JAwiySsBZBu
2018-09-24 09:52:55 -07:00
Alexandre Poirot
d31ef570b8
Bug 1485676 - Adapt gDevTools API to new async forTab and also adapt its callsites. r=yulia
...
Summary:
When switching to async, it is important to catch exception or register a rejection handler
so that errors keep being logged.
So in this patch I'm catching exception in a couple of important codepath.
Depends On D4541
Reviewers: yulia!
Tags: #secure-revision
Bug #: 1485676
Differential Revision: https://phabricator.services.mozilla.com/D4542
MozReview-Commit-ID: IDPJVkAPbTs
2018-09-24 09:52:54 -07:00
Alexandre Poirot
1322b8f8a4
Bug 1485676 - Prevent exceptions in the emulation actor when trying to use it while it is already destroyed. r=yulia
...
Summary: Depends On D4540
Reviewers: yulia!
Tags: #secure-revision
Bug #: 1485676
Differential Revision: https://phabricator.services.mozilla.com/D4541
MozReview-Commit-ID: 2fTZ4WRq9je
2018-09-24 09:52:52 -07:00
Alexandre Poirot
5af3a78471
Bug 1485676 - Tweak RDM manage to support new async forTab. r=yulia
...
Summary:
Fetching any target is now asynchronous. But RDM setup/destroy codepath is very fragile
and introduce many low level exception when trying to restore the original browser element
if any timing changes.
So this patch prevents trying to fetch the target object if a toolbox isn't already opened.
The target object is being used only for Telemetry purpose for now.
Depends On D4538
Reviewers: yulia!
Tags: #secure-revision
Bug #: 1485676
Differential Revision: https://phabricator.services.mozilla.com/D4540
MozReview-Commit-ID: 2QDUNqentMP
2018-09-24 09:52:51 -07:00
Alexandre Poirot
f421baa62a
Bug 1485676 - Adapt gDevTools.createTargetForTab to new TabTarget class. r=yulia
...
Summary: Depends On D4536
Reviewers: yulia!
Tags: #secure-revision
Bug #: 1485676
Differential Revision: https://phabricator.services.mozilla.com/D4537
MozReview-Commit-ID: E3AIMyFgL5m
2018-09-24 09:52:50 -07:00
Alexandre Poirot
dff4dedc72
Bug 1485676 - Convert TargetFactory.forTab call to forRemoteTab in debugger mochitest. r=yulia
...
Summary:
We are not passing a tab here. It only works by chance!
Depends On D4535
Reviewers: yulia!
Tags: #secure-revision
Bug #: 1485676
Differential Revision: https://phabricator.services.mozilla.com/D4536
MozReview-Commit-ID: K0ztxPM2N6A
2018-09-24 09:52:48 -07:00