Граф коммитов

8708 Коммитов

Автор SHA1 Сообщение Дата
Andrey Bienkowski 9985e57c16 Bug 1675094 Replace executeSoon() with waitForTick() in accessible/tests/browser r=Jamie,yzen
Differential Revision: https://phabricator.services.mozilla.com/D95779
2020-11-05 18:27:40 +00:00
Aaron Klotz 01caccf15a Bug 1674904: Part 4 - Update AccessibleHandler to delayload dependencies that are only used during registration; r=Jamie
We should delayload DLLs that for APIs that are only used during registration
so that they aren't referenced during normal operation.

Differential Revision: https://phabricator.services.mozilla.com/D95609
2020-11-04 21:50:06 +00:00
Dorel Luca e3198dde0a Backed out 4 changesets (bug 1674904) for Build bustage in worker/checkouts/gecko/config/rules.mk. CLOSED TREE
Backed out changeset 50576e0fbd98 (bug 1674904)
Backed out changeset b3b7d68c33f6 (bug 1674904)
Backed out changeset 660cdea23685 (bug 1674904)
Backed out changeset 7322c3af8006 (bug 1674904)
2020-11-04 23:20:51 +02:00
Aaron Klotz da717f3b82 Bug 1674904: Part 4 - Update AccessibleHandler to delayload dependencies that are only used during registration; r=Jamie
We should delayload DLLs that for APIs that are only used during registration
so that they aren't referenced during normal operation.

Differential Revision: https://phabricator.services.mozilla.com/D95609
2020-11-04 20:41:33 +00:00
Eitan Isaacson f42d5e8b3d Bug 1672694 - P1: Query layout for selectable text state. r=morgan,Jamie,yzen
The SELECTABLE_TEXT state is currently under-utilized and probably wrong, since it simply relies on testing if a hypertext has any text. A more correct reflection of the state should be taken from layout's IsSelectable method.

Note, even if an element is styled `user-select: none`, the text will still be keyboard selectable if it is editable (eg. input or contenteditable), so we should consider that SELECTABLE_TEXT.

Differential Revision: https://phabricator.services.mozilla.com/D95783
2020-11-04 19:56:55 +00:00
Marco Zehe 19a10e117a Bug 1675172 - Prevent an infinite loop when finding the line end boundary for an offset of 0, r=Jamie
Use a safer looping method, walking forward from aOffset to tmpOffset to prevent wrapping around at 0.

Differential Revision: https://phabricator.services.mozilla.com/D95826
2020-11-04 07:09:59 +00:00
Razvan Maries 10425eddfc Backed out 7 changesets (bug 1658084, bug 1671983) for perma failures on browser_async_remove_tab.js and browser_e10s_chrome_process.js. CLOSED TREE
Backed out changeset 2e6309c1cdbd (bug 1658084)
Backed out changeset 99aafd9304ef (bug 1671983)
Backed out changeset 80280b85280a (bug 1671983)
Backed out changeset 008db2659002 (bug 1671983)
Backed out changeset 32bd45c7fe3a (bug 1671983)
Backed out changeset 56e227e6580c (bug 1671983)
Backed out changeset a404f809f79d (bug 1671983)
2020-11-04 04:23:47 +02:00
Razvan Maries fd7d890c94 Backed out 2 changesets (bug 1672694) for Lint failures on browser_text_selection.js and perma failures on browser_accessibility_node.js. CLOSED TREE
Backed out changeset 0f340ea56805 (bug 1672694)
Backed out changeset b222e4ff438f (bug 1672694)
2020-11-04 03:15:17 +02:00
Nika Layzell 5f9c85da95 Bug 1671983 - Part 4: Stop awaiting BrowserTestUtils.loadURI, r=annyG,remote-protocol-reviewers,extension-reviewers,preferences-reviewers,whimboo,zombie
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.

This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.

Differential Revision: https://phabricator.services.mozilla.com/D94641
2020-11-04 00:55:36 +00:00
Eitan Isaacson f80fe575c5 Bug 1672694 - P2: Don't fire AXSelectedTextChanged if target is not selectable. r=morgan
This causes VoiceOver to mess with `AXFocused` and as a result redirect the VO cursor.

Differential Revision: https://phabricator.services.mozilla.com/D95784
2020-11-04 00:26:27 +00:00
Eitan Isaacson 8a078f1f55 Bug 1672694 - P1: Query layout for selectable text state. r=morgan,Jamie
The SELECTABLE_TEXT state is currently under-utilized and probably wrong, since it simply relies on testing if a hypertext has any text. A more correct reflection of the state should be taken from layout's IsSelectable method.

Note, even if an element is styled `user-select: none`, the text will still be keyboard selectable if it is editable (eg. input or contenteditable), so we should consider that SELECTABLE_TEXT.

Differential Revision: https://phabricator.services.mozilla.com/D95783
2020-11-04 00:28:57 +00:00
Aaron Klotz f71723139d Bug 1674909: Mark LazyInstantiator::GetRootAccessible as nodiscard; r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D95593
2020-11-03 02:05:32 +00:00
Eitan Isaacson d89268f7cd Bug 1619092 - Don't expose tbody/tfoot/thead as intermediate groups. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D94889
2020-11-02 21:41:12 +00:00
Bogdan Tara 0ee83920b6 Backed out changeset 6abea0908b00 (bug 1619092) for test_table_3 failures CLOSED TREE 2020-11-02 20:11:22 +02:00
Eitan Isaacson b7d75e0412 Bug 1619092 - Don't expose tbody/tfoot/thead as intermediate groups. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D94889
2020-10-30 00:24:33 +00:00
Eitan Isaacson 25ed6d4702 Bug 1674194 - If cell or row has aria role, make it a layout table. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D95193
2020-10-29 23:32:37 +00:00
Eitan Isaacson 33d5e972fd Bug 1674196 - Don't return children columns in layout tables. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D95228
2020-10-30 04:42:18 +00:00
Eitan Isaacson ef1779b14c Bug 1672776 - Return nil TextMarker(Range) if GeckoTextMarker(Range) is invalid. r=morgan
It seems like the GeckoTextMarker::Range can sometimes return invalid ranges.
We need to check if they are valid or not before marshalling them.

Differential Revision: https://phabricator.services.mozilla.com/D95230
2020-10-30 04:41:20 +00:00
Eitan Isaacson 617e00d069 Bug 1672803 - Add AXMozDebugDescription and override NSObject description when logging. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D94473
2020-10-28 20:22:02 +00:00
James Teh 72da707476 Bug 1673919: Make ParagraphBoundaryRule skip over OuterDocAccessibles. r=MarcoZ
The browser test is really a crash test, but it's really difficult to test a11y APIs properly using the crashtest framework.

Differential Revision: https://phabricator.services.mozilla.com/D95107
2020-10-29 06:04:33 +00:00
Eitan Isaacson 66f17f5351 Bug 1020603 - Check table children for alternative frame types when mapping element. r=Jamie
If an HTML table's children (tr/thead/tfoot) are anything but row or row
group frames, our layout-based HTMLTableAccessible implementation won't work.

Differential Revision: https://phabricator.services.mozilla.com/D94888
2020-10-28 15:58:55 +00:00
Eitan Isaacson cf25b74412 Bug 1673036 - If focused accessible is styled away, emit focus event on document. r=Jamie
Previously, the focus was emitted on the accessible's visible
container, even if it was not focusable.

Differential Revision: https://phabricator.services.mozilla.com/D94746
2020-10-26 18:40:24 +00:00
Marco Zehe f9e0ccb2a1 Bug 1525631 - Return correct line start and end offsets for inline-block elements with nested line breaks, r=Jamie
If an inline-block element contains nested elements that may contain line breaks, or whitespace that comes from how the HTML file is formatted, both start and end offsets returned from layout may be incorrect. Adjust for the following cases:

* The start offset goes too far back from the passed-in offset, overshooting a line boundary.
* The end offset returned is smaller than the passed-in offset, even though we want the start of the next line. Even on the last line, this should never happen.

Differential Revision: https://phabricator.services.mozilla.com/D94744
2020-10-27 06:10:33 +00:00
Ricky Stewart 02a7b4ebdf Bug 1654103: Standardize on Black for Python code in `mozilla-central`.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara da1098d4aa Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart c0cea3b0fa Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Marco Zehe 92ae4518de Bug 1670541 - Return the parent line end offset if an embedded character contains a line break, r=Jamie
If the offset for an embedded character is queried, and it is an inline element, such as a link, and it contains a line break, return the full parent line.

Likewise, if querying character offsets before that embedded character, include its line break in the end offset.

Differential Revision: https://phabricator.services.mozilla.com/D94024
2020-10-23 04:57:17 +00:00
Eitan Isaacson 0e6061d30d Bug 1672243 - Introduce AXIndexForChildUIElement and implement AXTopLevelUIElement. r=MarcoZ
AXTopLevelUIElement is not really testable because it doesn't give a useful result in
headless mode. Since it is a clone of AXWindow, this shouldn't be much of an issue.

Differential Revision: https://phabricator.services.mozilla.com/D94154
2020-10-22 17:12:39 +00:00
Yura Zenevich c455096aee Bug 1638880 - wait for all EVENT_DOCUMENT_LOAD_COMPLETE events and check for URL matches in the test_browserui.xhtml test. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D94216
2020-10-21 22:17:17 +00:00
James Teh 64ef64960b Bug 1672593: When calculating the paragraph end offset starting from an inline child and a block boundary is found, stop on the boundary, not after it. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D94407
2020-10-22 04:58:46 +00:00
Dorel Luca 1ff59cb7a3 Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart 50762dacab Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
James Teh 29fd7c7753 Bug 1670846: Treat line break characters in pre-formatted text as a11y paragraph boundaries. r=MarcoZ
In pre-formatted text (including textareas), text leaf nodes can contain line break characters ("\n").
Therefore, when searching for a paragraph boundary, we must match these.
Pivot can't return an ofset, only an Accessible, so we store the offset for the last match on the rule.
Because our origin point might be within a text leaf which contains a line break before/after it, we must also pass in the offset in our origin in this case so we can begin the text search from the right place.

Differential Revision: https://phabricator.services.mozilla.com/D93719
2020-10-18 09:19:23 +00:00
Morgan Reschenberg c5ff480218 Bug 1668101: Support same/different type naviagation with VO r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D91833
2020-10-15 16:42:14 +00:00
David Parks 5bf758ea20 Bug 1670800: Add accessibility tests for non-plugin object and embed elements r=eeejay
<object> and <embed> elements can handle a number of media-like resources, like images, videos, audio, PDFs.  This patch adds tests for all but video.  See bug 1670803 for video tests.

Differential Revision: https://phabricator.services.mozilla.com/D93273
2020-10-15 05:04:00 +00:00
Eitan Isaacson 2e476d423a Bug 1671049 - Invalidate cached ARIA role and role in mozAccessible when role changes. r=morgan
Besides the ARIA role invalidation, this fixes an issue where the mozAccessible's role is also incorrect when the aria role changes on a body tag.

Depends on D93439

Differential Revision: https://phabricator.services.mozilla.com/D93440
2020-10-14 00:04:49 +00:00
Eitan Isaacson c548ecd683 Bug 1671049 - Cache proxy ARIA role in mozAccessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D93439
2020-10-14 00:04:54 +00:00
Edgar Chen 07458c65e6 Bug 1670919 - Cleanup some code around nsIFormControl::GetFormElement; r=emilio
nsIFormControl::GetFormElement now returns HTMLFormElement*, we could remove
some type convertion.

Differential Revision: https://phabricator.services.mozilla.com/D93349
2020-10-13 15:15:57 +00:00
Bas Schouten 25a1b0f61f Bug 1669256 - Part 1: Remove AbstractEventQueue and de-templatize ThreadEventQueue. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D92709
2020-10-09 17:56:34 +00:00
Marco Zehe 0ada0a0e77 Bug 1668546 Part 2 - Remove the explicit class tag to Pivot from HyperTextAccessible and make it a normal assignment, r=eeejay
Depends on D92216

Differential Revision: https://phabricator.services.mozilla.com/D92217
2020-10-05 17:45:58 +00:00
Marco Zehe 1d00f10ad1 Bug 1668546 Part 1 - Rename the Pivot function in Android's AccessibleWrap so it doesn't collide with the name of the Pivot class, r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D92216
2020-10-05 17:45:30 +00:00
Eitan Isaacson 7a572196df Bug 1669821 - Implement search predicate API on virtual root. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92820
2020-10-07 20:34:21 +00:00
Eitan Isaacson f050b91638 Bug 1669599 - Support AXEditableAncestor and make it text event target. r=morgan
Depends on D92689

Differential Revision: https://phabricator.services.mozilla.com/D92690
2020-10-07 00:13:34 +00:00
Eitan Isaacson c173a1f486 Bug 1669596 - Allow subdoc GeckoTextMarker to be demarshalled in top document. r=morgan
Depends on D92688

Differential Revision: https://phabricator.services.mozilla.com/D92689
2020-10-06 23:31:32 +00:00
Eitan Isaacson 16d2fdfadc Bug 1669595 - Use top AXWebArea as text event source. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92688
2020-10-07 18:38:52 +00:00
Eitan Isaacson 029b948f0c Bug 1668958 - Don't wrap to first word when getting right word at end of input. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92310
2020-10-06 22:19:13 +00:00
Eitan Isaacson 10dfa8214c Bug 1668936 - Return element when calling AXUIElementForTextMarker in entry. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92309
2020-10-06 22:19:11 +00:00
Eitan Isaacson 7293c05ee8 Bug 1668933 - Fix get previous marker outside of entry. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92308
2020-10-06 22:19:03 +00:00
Eitan Isaacson bacf4042da Bug 1668961 - Avoid 2 IPC round trips in moxStringForTextMarkerRange. r=morgan
The state checking can happen in the iterator in HyperTextAccessibleWrap.

Differential Revision: https://phabricator.services.mozilla.com/D92307
2020-10-06 22:18:56 +00:00
Morgan Reschenberg bff9a869c8 Bug 1666380: Add support for AXTextFieldSearchKey to VO rotor r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D90941
2020-10-06 18:50:31 +00:00