Sylvestre Ledru
d0f6c7fc66
Bug 1856795 - Remove redundant member init r=emilio
...
Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .
https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html
Differential Revision: https://phabricator.services.mozilla.com/D190002
2023-10-15 15:29:02 +00:00
Cristina Horotan
6a90f5eded
Backed out 2 changesets (bug 1856795) for causing build bustage at BasicEvents.h CLOSED TREE
...
Backed out changeset 1d98b028923a (bug 1856795)
Backed out changeset eae2ac93e17c (bug 1856795)
2023-10-14 21:42:14 +03:00
Sylvestre Ledru
cc8a0ee742
Bug 1856795 - Remove redundant member init r=emilio
...
Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .
https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html
Differential Revision: https://phabricator.services.mozilla.com/D190002
2023-10-14 17:34:26 +00:00
Paul Adenot
7c1e298af8
Bug 1856145 - Protect against incorrect granulepos in OGG bytestream. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D189820
2023-10-03 08:25:18 +00:00
alwu
1c3f68905f
Bug 1852170 - check if the duration is valid. r=media-playback-reviewers,azebrowski
...
Differential Revision: https://phabricator.services.mozilla.com/D187803
2023-09-09 03:36:42 +00:00
alwu
e0a6f72e0b
Bug 1850434 - part1 : duration shouldn't be negative. r=media-playback-reviewers,azebrowski
...
The reasons of OGG crashing are
1) Duration becomes negative after trimming
2) Invalid negativae duration in the file
Therefore, we should always adjust duration to make it non-negative in
order to safely discard those samples.
Differential Revision: https://phabricator.services.mozilla.com/D187499
2023-09-06 00:46:40 +00:00
Paul Adenot
86b2ace5b5
Bug 1849870 - Return a delta granulepos of 0 when finding an invalid Opus packet. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D186719
2023-08-25 13:22:23 +00:00
Paul Adenot
fb69e39988
Bug 1848669 - Fix clang-tidy warnings in OggDemuxer.cpp. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D186357
2023-08-22 14:47:16 +00:00
Paul Adenot
71e467de2a
Bug 1848669 - Handle invalid duration in OGG files gracefully. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D186356
2023-08-22 14:47:16 +00:00
Paul Adenot
9aee86d338
Bug 1848258 - Restore handling of invalid OGG Vorbis file. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D186016
2023-08-16 17:06:50 +00:00
Paul Adenot
7c67bcb021
Bug 1840399 - Fix static-analysis warnings in OpusParser. r=media-playback-reviewers,alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D182068
2023-08-08 12:12:53 +00:00
Paul Adenot
ace3332128
Bug 1840399 - Fix static-analysis warnings in OggCodecState. r=media-playback-reviewers,alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D182067
2023-08-08 12:12:53 +00:00
Paul Adenot
be5e766a30
Bug 1839391 - Fix looping of OGG files. r=alwu
...
It goes like this:
Seek to 0, while looping (some packets have already been demuxed, the headers have been parsed, etc.).
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggDemuxer.cpp#1155
There are no packet because just we just reset the demuxer, the while loop body
is executed.
We've seeked to 0, so we need read a page in, and then we proceed to demux it
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggDemuxer.cpp#821
Calling PageIn for Vorbis:
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggCodecState.cpp#823
PacketOutUntilGranulePos is executed:
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggCodecState.cpp#321
First few packets are header packets (3 in the case of Vorbis),
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggCodecState.cpp#338
and then there's no more data, returning, granulePos hasn't been found because for now it's been header packets.
Not entering this if:
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggCodecState.cpp#840 ,
but we have a packet, becaues it's been appended despite being header packets.
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggDemuxer.cpp#1161
Goes here, packet isn't known (because it's a header packet we're trying to get the timing information of):
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggCodecState.cpp#794 ,
return -1. `duration - endTime` is therefore 1, so we have the packet time be 1 instead of 0.
With the TimeUnit change it's now TimeUnit::Invalid, and we're attempting to do
arithmetics with it, so it crashes.
It's best to simply skip those packets at this point, there's lots of logic to
change otherwise: sometimes the headers are expected to be skipped (looping),
sometimes they are expected to be read (chaining).
Differential Revision: https://phabricator.services.mozilla.com/D181528
2023-08-08 12:12:49 +00:00
Paul Adenot
332e384689
Bug 1839391 - Switch the OGG demuxer to use TimeUnit in the correct base for audio. r=alwu
...
This is pretty big, but is just propagating changes down to make it compile.
Differential Revision: https://phabricator.services.mozilla.com/D181525
2023-08-08 12:12:48 +00:00
Paul Adenot
d2caeb9b64
Bug 1839391 - Use AudioTrimmer to trim audio in OGG containers. r=alwu
...
This removes all custom code there.
The AudioTrimmer change allows handling decoders that have one packet of delay,
such as some codecs when used through ffmpeg. There was a comment about this,
but the code was gone somehow. We can verify that this happens when enabling
`PlaformDecoderModule:4` and decoding using ffmpeg: lots of `EAGAIN` logs will
be output, because ffmpeg requires more input.
Differential Revision: https://phabricator.services.mozilla.com/D181522
2023-08-08 12:12:47 +00:00
Paul Adenot
374d4dcd7e
Bug 1833654 - Remove libtremor from the tree. r=karlt,media-playback-reviewers,sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D181519
2023-08-08 12:12:45 +00:00
Paul Adenot
3902121a68
Bug 1823953 - Add vorbis, opus, ogg headers to the system wrapper list, and fix all users of those headers to consistently include those headers with <>. r=glandium,media-playback-reviewers,webrtc-reviewers,mjf,karlt
...
Despite some files being under `third_party`, it's our files, that we can
modify.
We want to include codec headers using `<>` and not `""` because angle bracket
includes from `dist/system_wrappers` and not `dist/include`. The former location
wraps the include in a way that makes the symbols have a default visibility,
while the latter hides the symbol. Because those codecs have been moved to a
different shared library, we need their symbols exported.
Differential Revision: https://phabricator.services.mozilla.com/D176158
2023-08-08 12:12:44 +00:00
Cristian Tuns
5d6b51256b
Backed out 57 changesets (bug 1839389, bug 1840869, bug 1840399, bug 1840402, bug 1823953, bug 1828912, bug 1826382, bug 1837160, bug 1839391, bug 1833654) for causing build bustages in ogg_<something> CLOSED TREE
...
Backed out changeset 61356e1447e3 (bug 1823953)
Backed out changeset 85785505b6d6 (bug 1823953)
Backed out changeset 46a61cbfe8a8 (bug 1833654)
Backed out changeset 83e3de80337b (bug 1833654)
Backed out changeset 1a10c12874ac (bug 1840399)
Backed out changeset 6b087145b67f (bug 1833654)
Backed out changeset b9ac857ad43f (bug 1840399)
Backed out changeset 4b841e8dd033 (bug 1823953)
Backed out changeset 650e35803834 (bug 1823953)
Backed out changeset c11b58ac0709 (bug 1823953)
Backed out changeset c0249c90bc31 (bug 1823953)
Backed out changeset 8929288d5aec (bug 1823953)
Backed out changeset 828792b886bd (bug 1823953)
Backed out changeset 873f1d4a8875 (bug 1840869)
Backed out changeset a25abd05302c (bug 1823953)
Backed out changeset d4b1eb442c36 (bug 1840399)
Backed out changeset c25509d72a96 (bug 1840399)
Backed out changeset 0f72a0626a28 (bug 1840402)
Backed out changeset 82e7574364ce (bug 1840399)
Backed out changeset 93073105f063 (bug 1840399)
Backed out changeset 56ec8e3405e9 (bug 1840399)
Backed out changeset ff15dad37ab8 (bug 1840399)
Backed out changeset 0655ebd61eda (bug 1840399)
Backed out changeset 7bca1ae06c7d (bug 1828912)
Backed out changeset 8a5a849cfe5f (bug 1828912)
Backed out changeset 3d8422a2038a (bug 1828912)
Backed out changeset f08ee5de9370 (bug 1823953)
Backed out changeset a4eb210620ff (bug 1823953)
Backed out changeset aa8914cd55be (bug 1839391)
Backed out changeset 3ea1f43e4024 (bug 1823953)
Backed out changeset 3efe02ffa1c8 (bug 1826382)
Backed out changeset 81c4553ec23d (bug 1839391)
Backed out changeset 130894e4a781 (bug 1839391)
Backed out changeset 9a0247b0fc85 (bug 1839391)
Backed out changeset 11a923064382 (bug 1839391)
Backed out changeset 98ffb66160c3 (bug 1837160)
Backed out changeset a80dda9a220a (bug 1837160)
Backed out changeset 251b4ef97a2b (bug 1837160)
Backed out changeset 7372632eb32f (bug 1837160)
Backed out changeset c5d54bc3ee26 (bug 1839389)
Backed out changeset b232ec1bbc2d (bug 1833654)
Backed out changeset fc7ba125c2fe (bug 1833654)
Backed out changeset 8a47f6882e61 (bug 1823953)
Backed out changeset e29810541b53 (bug 1828912)
Backed out changeset bcf10730c8c9 (bug 1828912)
Backed out changeset 8df8290b6c33 (bug 1826382)
Backed out changeset 2811d12803cf (bug 1826382)
Backed out changeset 3fc718561ec9 (bug 1826382)
Backed out changeset 7827183776e1 (bug 1823953)
Backed out changeset a3eb5f228d9a (bug 1826382)
Backed out changeset 3113ad2e0987 (bug 1823953)
Backed out changeset 4b1dc01525af (bug 1823953)
Backed out changeset f7f4a7585ceb (bug 1823953)
Backed out changeset 93042f1becec (bug 1823953)
Backed out changeset b9ca30a0a066 (bug 1823953)
Backed out changeset 1000c4a6a92a (bug 1823953)
Backed out changeset 05dc13775fd6 (bug 1823953)
2023-08-01 09:37:39 -04:00
Paul Adenot
05930dc13a
Bug 1840399 - Fix static-analysis warnings in OpusParser. r=media-playback-reviewers,alwu DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D182068
2023-08-01 12:41:13 +00:00
Paul Adenot
4e1b0f6a67
Bug 1840399 - Fix static-analysis warnings in OggCodecState. r=media-playback-reviewers,alwu DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D182067
2023-08-01 12:41:13 +00:00
Paul Adenot
74c52e3fcd
Bug 1839391 - Fix looping of OGG files. r=alwu DONTBUILD
...
It goes like this:
Seek to 0, while looping (some packets have already been demuxed, the headers have been parsed, etc.).
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggDemuxer.cpp#1155
There are no packet because just we just reset the demuxer, the while loop body
is executed.
We've seeked to 0, so we need read a page in, and then we proceed to demux it
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggDemuxer.cpp#821
Calling PageIn for Vorbis:
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggCodecState.cpp#823
PacketOutUntilGranulePos is executed:
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggCodecState.cpp#321
First few packets are header packets (3 in the case of Vorbis),
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggCodecState.cpp#338
and then there's no more data, returning, granulePos hasn't been found because for now it's been header packets.
Not entering this if:
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggCodecState.cpp#840 ,
but we have a packet, becaues it's been appended despite being header packets.
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggDemuxer.cpp#1161
Goes here, packet isn't known (because it's a header packet we're trying to get the timing information of):
https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/dom/media/ogg/OggCodecState.cpp#794 ,
return -1. `duration - endTime` is therefore 1, so we have the packet time be 1 instead of 0.
With the TimeUnit change it's now TimeUnit::Invalid, and we're attempting to do
arithmetics with it, so it crashes.
It's best to simply skip those packets at this point, there's lots of logic to
change otherwise: sometimes the headers are expected to be skipped (looping),
sometimes they are expected to be read (chaining).
Differential Revision: https://phabricator.services.mozilla.com/D181528
2023-08-01 12:41:10 +00:00
Paul Adenot
669d8f4ae3
Bug 1839391 - Switch the OGG demuxer to use TimeUnit in the correct base for audio. r=alwu DONTBUILD
...
This is pretty big, but is just propagating changes down to make it compile.
Differential Revision: https://phabricator.services.mozilla.com/D181525
2023-08-01 12:41:09 +00:00
Paul Adenot
ed7ca36299
Bug 1839391 - Use AudioTrimmer to trim audio in OGG containers. r=alwu DONTBUILD
...
This removes all custom code there.
The AudioTrimmer change allows handling decoders that have one packet of delay,
such as some codecs when used through ffmpeg. There was a comment about this,
but the code was gone somehow. We can verify that this happens when enabling
`PlaformDecoderModule:4` and decoding using ffmpeg: lots of `EAGAIN` logs will
be output, because ffmpeg requires more input.
Differential Revision: https://phabricator.services.mozilla.com/D181522
2023-08-01 12:41:08 +00:00
Paul Adenot
03e1982151
Bug 1833654 - Remove libtremor from the tree. r=karlt,media-playback-reviewers,sylvestre DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D181519
2023-08-01 12:41:07 +00:00
Paul Adenot
86a671a21e
Bug 1823953 - Add vorbis, opus, ogg headers to the system wrapper list, and fix all users of those headers to consistently include those headers with <>. r=glandium,media-playback-reviewers,webrtc-reviewers,mjf,karlt DONTBUILD
...
Despite some files being under `third_party`, it's our files, that we can
modify.
We want to include codec headers using `<>` and not `""` because angle bracket
includes from `dist/system_wrappers` and not `dist/include`. The former location
wraps the include in a way that makes the symbols have a default visibility,
while the latter hides the symbol. Because those codecs have been moved to a
different shared library, we need their symbols exported.
Differential Revision: https://phabricator.services.mozilla.com/D176158
2023-08-01 12:41:06 +00:00
Masatoshi Kimura
181d1d2914
Bug 1844257 - Remove ipc/glue/LibrarySandboxPreload.(cpp|h). r=glandium
...
They are leftovers from bug 1572618 and bug 1737733
.
Differential Revision: https://phabricator.services.mozilla.com/D183973
2023-07-19 23:29:19 +00:00
Otto Länd
43499f6fab
Bug 1703812, 1817997
, 1821362: apply code formatting via Lando
...
# ignore-this-changeset
2023-05-24 13:28:38 +00:00
Paul Adenot
20b2262251
Bug 1817997
- Adjust code to take advantage of the new TimeUnit API. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D171256
2023-05-24 13:18:39 +00:00
Cosmin Sabou
5fd965f028
Backed out 80 changesets (bug 1821362, bug 1703812, bug 1817997
) for causing media crashes as in Bug 1833890. a=backout
...
Backed out changeset f2113c9b661f (bug 1817997
)
Backed out changeset f1ecfbba7ed2 (bug 1703812)
Backed out changeset 011cece33b0d (bug 1817997
)
Backed out changeset 4b42659090f3 (bug 1817997
)
Backed out changeset 2d92f903dd66 (bug 1817997
)
Backed out changeset 0ef13d357ee3 (bug 1817997
)
Backed out changeset 7353f869efd2 (bug 1703812)
Backed out changeset 14b061d0f595 (bug 1817997
)
Backed out changeset d29bc29397c8 (bug 1703812)
Backed out changeset 54c3294f0839 (bug 1817997
)
Backed out changeset b9f2e1155bd7 (bug 1817997
)
Backed out changeset d5d5d390dcbf (bug 1817997
)
Backed out changeset 8fca27bd0f6b (bug 1817997
)
Backed out changeset 670c599a3b99 (bug 1817997
)
Backed out changeset deea3077f762 (bug 1817997
)
Backed out changeset 25ecea0f3d49 (bug 1817997
)
Backed out changeset 35ab3ed5e3fc (bug 1817997
)
Backed out changeset f516a428ba32 (bug 1817997
)
Backed out changeset e589b4d30995 (bug 1817997
)
Backed out changeset d096b9cc905d (bug 1817997
)
Backed out changeset 2952a6fa06e5 (bug 1817997
)
Backed out changeset c1ac4c31ad9a (bug 1817997
)
Backed out changeset 04c60cd83c5f (bug 1821362)
Backed out changeset 6dd80575e551 (bug 1821362)
Backed out changeset b86b569ecd46 (bug 1817997
)
Backed out changeset 412e0a9ec4e8 (bug 1817997
)
Backed out changeset 8e0dcf163138 (bug 1817997
)
Backed out changeset 7af506896930 (bug 1817997
)
Backed out changeset 29f7cd2b341c (bug 1817997
)
Backed out changeset 7f64e65d9497 (bug 1817997
)
Backed out changeset 89c241451a32 (bug 1817997
)
Backed out changeset 66e4a26e1ebe (bug 1817997
)
Backed out changeset ea1aebd4e245 (bug 1817997
)
Backed out changeset 2d88a5915db9 (bug 1817997
)
Backed out changeset 697ec1928f9c (bug 1817997
)
Backed out changeset 41c0bd1133c5 (bug 1817997
)
Backed out changeset b20cc750c020 (bug 1817997
)
Backed out changeset dc5fd84a3a4c (bug 1703812)
Backed out changeset efa6d130d4eb (bug 1703812)
Backed out changeset 20d9b7cf0ddc (bug 1703812)
Backed out changeset e77c61e8fad2 (bug 1703812)
Backed out changeset 582d5c680e5a (bug 1703812)
Backed out changeset 96c9aacc6811 (bug 1703812)
Backed out changeset 56ec4a57a6a6 (bug 1703812)
Backed out changeset 8f96c8811675 (bug 1703812)
Backed out changeset a79a2f1b2b51 (bug 1703812)
Backed out changeset 07eb8b2c5b9f (bug 1703812)
Backed out changeset bae2b2fb9759 (bug 1703812)
Backed out changeset 38b0416538f3 (bug 1703812)
Backed out changeset b27b54c95cf2 (bug 1703812)
Backed out changeset cab00065d83d (bug 1703812)
Backed out changeset ab44727b2e1a (bug 1703812)
Backed out changeset b7fdcb494670 (bug 1703812)
Backed out changeset 73db43d49c6d (bug 1703812)
Backed out changeset ce754dbfb862 (bug 1703812)
Backed out changeset d694726a3ee6 (bug 1703812)
Backed out changeset 6acede55acbb (bug 1703812)
Backed out changeset 86e7d4784a20 (bug 1703812)
Backed out changeset 6b2e055d9314 (bug 1703812)
Backed out changeset b08695e5728a (bug 1703812)
Backed out changeset 3b8a0081fd10 (bug 1703812)
Backed out changeset 3a163596f982 (bug 1703812)
Backed out changeset 5be1d4b282ab (bug 1703812)
Backed out changeset 1ce012d7509e (bug 1703812)
Backed out changeset ee2fab5881c7 (bug 1703812)
Backed out changeset 62941a522893 (bug 1703812)
Backed out changeset d4f11dc33eed (bug 1703812)
Backed out changeset 781bb4c3cc02 (bug 1703812)
Backed out changeset f070e0de0566 (bug 1703812)
Backed out changeset 9f65c67ba2a6 (bug 1703812)
Backed out changeset 1e76eecb85e2 (bug 1703812)
Backed out changeset 953432408a83 (bug 1703812)
Backed out changeset fd1dc92d3911 (bug 1703812)
Backed out changeset 34d56948c6b6 (bug 1703812)
Backed out changeset 2ba7ca61ecc3 (bug 1703812)
Backed out changeset 545253c469e6 (bug 1703812)
Backed out changeset fb4a61ab1300 (bug 1703812)
Backed out changeset bf07b3cfd3d5 (bug 1703812)
Backed out changeset eaff51e7754b (bug 1703812)
Backed out changeset f5c485c41d13 (bug 1703812)
2023-05-19 14:49:57 +03:00
Otto Länd
73f06050fb
Bug 1703812, 1817997
, 1821362: apply code formatting via Lando
...
# ignore-this-changeset
2023-05-17 16:00:46 +00:00
Paul Adenot
0aeade5787
Bug 1817997
- Adjust code to take advantage of the new TimeUnit API. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D171256
2023-05-17 15:47:03 +00:00
Andi-Bogdan Postelnicu
d7e8a09c21
Bug 1519636 - Reformat recent changes to the Google coding style. r=glandium
...
Updated with clang-format version 15.0.5 (taskcluster-MKK8dHUpQkGfPLA793lizg)
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D168658
2023-02-13 15:02:07 +00:00
Bryce Seager van Dyk
45ccca4aaf
Bug 1747760 - P9: Handle Vorbis data with Vorbis codec specific variant. r=kinetik
...
Differential Revision: https://phabricator.services.mozilla.com/D145522
2022-05-17 23:09:08 +00:00
Bryce Seager van Dyk
d9f0575073
Bug 1747760 - P8: Handle Opus data using Opus codec specific variant. r=kinetik.
...
This means as of this patch
- All mp4 specific audio codecs are handled. There's some more we could
theoretically get, stuff like ALAC, but it's not clear to me we handle them
following demuxing. I've left a catch all in the mp4 demuxing code just in
case.
- We no longer pack the codec-delay/preskip at the head of the opus binary blob.
This means that the binary blob is just the opus header data and the container
specific preskip has its own member. My hope is this is clearer and easier to
understand. It also means we can drop some of the code we had for packing the
delay/preskip into a binary blob.
Differential Revision: https://phabricator.services.mozilla.com/D145521
2022-05-17 23:09:07 +00:00
Bryce Seager van Dyk
60ac1098c6
Bug 1747760 - P3: Rework audio codec specific data to use new variant with a generic blob. r=kinetik
...
This switches existing code to use the new variant style codec specific
information for audio, but retains the binary blob style apporach everywhere.
There should be no functional changes following this refactor. Internally all
codec specific data is still stored in blobs. This allows a baseline from which
we can modify specific codecs to use more constrained versions of the variant.
Depends on D134728
Differential Revision: https://phabricator.services.mozilla.com/D134729
2022-05-17 23:09:05 +00:00
criss
715c6ab9a9
Backed out 10 changesets (bug 1747760) for causing wpt failures on mediasource-correct-frames-after-reappend.html. CLOSED TREE
...
Backed out changeset aae68dac17d0 (bug 1747760)
Backed out changeset dbb36eb962f7 (bug 1747760)
Backed out changeset 51ded936bda1 (bug 1747760)
Backed out changeset 706c89c31a6d (bug 1747760)
Backed out changeset ede5ba8832cb (bug 1747760)
Backed out changeset 4740c9cf6d51 (bug 1747760)
Backed out changeset 71e0dd7f0dad (bug 1747760)
Backed out changeset 0f6c6489a2c6 (bug 1747760)
Backed out changeset ad0284c66cb0 (bug 1747760)
Backed out changeset b0b666cba2ce (bug 1747760)
2022-05-12 01:37:32 +03:00
Bryce Seager van Dyk
b1bdfce5fc
Bug 1747760 - P9: Handle Vorbis data with Vorbis codec specific variant. r=kinetik
...
Differential Revision: https://phabricator.services.mozilla.com/D145522
2022-05-11 19:20:04 +00:00
Bryce Seager van Dyk
8c1b8958f3
Bug 1747760 - P8: Handle Opus data using Opus codec specific variant. r=kinetik.
...
This means as of this patch
- All mp4 specific audio codecs are handled. There's some more we could
theoretically get, stuff like ALAC, but it's not clear to me we handle them
following demuxing. I've left a catch all in the mp4 demuxing code just in
case.
- We no longer pack the codec-delay/preskip at the head of the opus binary blob.
This means that the binary blob is just the opus header data and the container
specific preskip has its own member. My hope is this is clearer and easier to
understand. It also means we can drop some of the code we had for packing the
delay/preskip into a binary blob.
Differential Revision: https://phabricator.services.mozilla.com/D145521
2022-05-11 19:20:04 +00:00
Bryce Seager van Dyk
50cd3726bf
Bug 1747760 - P3: Rework audio codec specific data to use new variant with a generic blob. r=kinetik
...
This switches existing code to use the new variant style codec specific
information for audio, but retains the binary blob style apporach everywhere.
There should be no functional changes following this refactor. Internally all
codec specific data is still stored in blobs. This allows a baseline from which
we can modify specific codecs to use more constrained versions of the variant.
Depends on D134728
Differential Revision: https://phabricator.services.mozilla.com/D134729
2022-05-11 19:20:02 +00:00
Mike Hommey
407fae9455
Bug 1765474 - Fix unused-but-set-variable warning in OggDemuxer.cpp. r=media-playback-reviewers,padenot
...
dom/media/ogg/OggDemuxer.cpp:1905:7: error: variable 'hops' set but not used [-Werror,-Wunused-but-set-variable]
int hops = 0;
^
Differential Revision: https://phabricator.services.mozilla.com/D144147
2022-04-22 01:25:08 +00:00
Randell Jesup
fcaf70841e
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 18:47:08 +00:00
Noemi Erli
2390d257e6
Backed out changeset 12a59e5a50bf (bug 1207753) for causing build bustage CLOSED TREE
2022-03-16 18:32:51 +02:00
Randell Jesup
4b033a5256
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 16:16:14 +00:00
Butkovits Atila
927ad62c6a
Backed out changeset a68ee4b09f92 (bug 1207753) for causing Hazard bustages. CLOSED TREE
2022-03-16 14:38:14 +02:00
Randell Jesup
7d4b5fae04
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 12:01:14 +00:00
Paul Adenot
831b3b9a2c
Bug 1749761 - Fix signed->unsigned conversion in the OGG demuxer. r=media-playback-reviewers,alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D135504
2022-02-08 16:36:39 +00:00
Deian Stefan
26994de326
Bug 1738550 - Clean up RLBox type definitions r=bholley
...
Differential Revision: https://phabricator.services.mozilla.com/D129970
2021-11-18 19:51:08 +00:00
shravanrn@gmail.com
2a11cb1f78
Bug 1737733
- Update rlbox wasm configuration to use direct function calls r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D128566
2021-10-26 23:41:11 +00:00
shravanrn@gmail.com
126f016b59
Bug 1728934 - Ensure Ogg demux fails gracefully on rlbox sandbox OOM r=glandium,bholley
...
Differential Revision: https://phabricator.services.mozilla.com/D127023
2021-10-26 05:16:32 +00:00
criss
7897dc6975
Backed out 4 changesets (bug 1728934) for causing Mochitest failures. CLOSED TREE
...
Backed out changeset 5e64ae0a8b00 (bug 1728934)
Backed out changeset 3538237090bf (bug 1728934)
Backed out changeset a240e5a52df4 (bug 1728934)
Backed out changeset a932fbd95f01 (bug 1728934)
2021-10-01 11:49:44 +03:00